date:20180214

[Mahara-contributors] [Bug 1749403] [NEW] Code correction in function find_key_name of lib/ddl.php

2018-02-14 Thread Alexander Del Ponte

Public bug reported:

In line 523 the existing code

if (!$field == $col->column_name) {

should be replaced with

if ($field !== $col->column_name) {


Greetings
Alex

** Affects: mahara
 Importance: Undecided
 Status: New

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1749403

Title:
  Code correction in function find_key_name of lib/ddl.php

Status in Mahara:
  New

Bug description:
  In line 523 the existing code

  if (!$field == $col->column_name) {

  should be replaced with

  if ($field !== $col->column_name) {

  
  Greetings
  Alex

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1749403/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1749402] [NEW] Views and collection list (in group) throws MySQL error

2018-02-14 Thread Alexander Del Ponte

Public bug reported:

If a normal group member tries to visit views and collections of the
group, following warning/error is thrown under some conditions which are
mentioned below:

SQL:
[WAR] 93 (lib/errors.php:859) Failed to get a recordset: mysqli error: [1452: 
Cannot add or update a child row: a foreign key constraint fails 
("dp-dev-master-ep"."view_rows_columns", CONSTRAINT "viewrowscolu_vie_fk" 
FOREIGN KEY ("view") REFERENCES "view" ("id"))] in EXECUTE("INSERT INTO 
"view_rows_columns" ("view", "row", "columns") VALUES ('46', '1', '3')")Command 
was: INSERT INTO "view_rows_columns" ("view", "row", "columns") VALUES (?, ?, 
?) and values was (view:46,row:1,columns:3)

PHP:
Call stack (most recent first):
log_message("Failed to get a recordset: mysqli error: [1452: Ca...", 8, true, 
true) at /var/www/mahara/master/htdocs/lib/errors.php:95
log_warn("Failed to get a recordset: mysqli error: [1452: Ca...") at 
/var/www/mahara/master/htdocs/lib/errors.php:859
SQLException->__construct("Failed to get a recordset: mysqli error: [1452: 
Ca...") at /var/www/mahara/master/htdocs/lib/dml.php:1105
insert_record("view_rows_columns", object(stdClass), false, false) at 
/var/www/mahara/master/htdocs/lib/dml.php:1192
ensure_record_exists("view_rows_columns", object(stdClass), object(stdClass)) 
at /var/www/mahara/master/htdocs/lib/view.php:356
View->__construct(0array(size 25)) at 
/var/www/mahara/master/htdocs/lib/view.php:5581
View::get_extra_view_info(array(size 2), false) at 
/var/www/mahara/master/htdocs/view/groupviews.php:52

This happens if the group views and collections are readonly to members,
a group collection exisits with at least one view inside and in the DB
there is no view which has the same id as this collection.

I didn't went too deep inside the code, but it seems that this issue is
somehow connected to the bug #1514608.

It further seems that Mahara interprets a collection as a view trying to
get/set view related data using a collection id to avoid having no DB
entry in table view_rows_columns for this erroneously supposed view so
the actually error should be found in functions calling this code areas
(get_extra_view_info).

Reproduce error:
Create a group in which views and collections are only editable by others that 
normal group members.
Create a view and a collection inside this group and assign the view to the 
collection.
Make sure, that in the DB there are no entries referring to a view which has 
the same id as the above created collection (e. g. by deleting a possibly 
existing view with this id inside Mahara).
As a normal group member call the tab views and collection of the group.

Greetings
Alex

** Affects: mahara
 Importance: Undecided
 Status: New

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1749402

Title:
  Views and collection list (in group) throws MySQL error

Status in Mahara:
  New

Bug description:
  If a normal group member tries to visit views and collections of the
  group, following warning/error is thrown under some conditions which
  are mentioned below:

  SQL:
  [WAR] 93 (lib/errors.php:859) Failed to get a recordset: mysqli error: [1452: 
Cannot add or update a child row: a foreign key constraint fails 
("dp-dev-master-ep"."view_rows_columns", CONSTRAINT "viewrowscolu_vie_fk" 
FOREIGN KEY ("view") REFERENCES "view" ("id"))] in EXECUTE("INSERT INTO 
"view_rows_columns" ("view", "row", "columns") VALUES ('46', '1', '3')")Command 
was: INSERT INTO "view_rows_columns" ("view", "row", "columns") VALUES (?, ?, 
?) and values was (view:46,row:1,columns:3)

  PHP:
  Call stack (most recent first):
  log_message("Failed to get a recordset: mysqli error: [1452: Ca...", 8, true, 
true) at /var/www/mahara/master/htdocs/lib/errors.php:95
  log_warn("Failed to get a recordset: mysqli error: [1452: Ca...") at 
/var/www/mahara/master/htdocs/lib/errors.php:859
  SQLException->__construct("Failed to get a recordset: mysqli error: [1452: 
Ca...") at /var/www/mahara/master/htdocs/lib/dml.php:1105
  insert_record("view_rows_columns", object(stdClass), false, false) at 
/var/www/mahara/master/htdocs/lib/dml.php:1192
  ensure_record_exists("view_rows_columns", object(stdClass), object(stdClass)) 
at /var/www/mahara/master/htdocs/lib/view.php:356
  View->__construct(0array(size 25)) at 
/var/www/mahara/master/htdocs/lib/view.php:5581
  View::get_extra_view_info(array(size 2), false) at 
/var/www/mahara/master/htdocs/view/groupviews.php:52

  This happens if the group views and collections are readonly to
  members, a group collection exisits with at least one view inside and
  in the DB there is no view which has the same id as this collection.

  I didn't went too deep inside the code, but it seems that this issue

[Mahara-contributors] [Bug 1749396] [NEW] Finnish translation pack missing strings

2018-02-14 Thread Urpo Karhula

Public bug reported:

Hello,

Finnish mahara translation packs (16.10 & 17.10 at);

http://langpacks.mahara.org/

are missing a translation strings

$string['Blogs'] = 'Journals';
$string['Blog'] = 'Journal';
 
and by so Blogs doesn't translate at all. In the english language pack you have 
four of them 

$string['Blogs'] = 'Journals';
$string['blogs'] = 'journals';
$string['Blogs'] = 'Journals';
$string['blogs'] = 'journals';

The ones with the capital B in the string name area the ones that affect
the translation seen on the screen so could someone add them to the
finnish language packs? I wonder why this have been done in such a weird
way in the first place.

** Affects: mahara
 Importance: Undecided
 Status: New


** Tags: translations

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1749396

Title:
  Finnish translation pack missing strings

Status in Mahara:
  New

Bug description:
  Hello,

  Finnish mahara translation packs (16.10 & 17.10 at);

  http://langpacks.mahara.org/

  are missing a translation strings

  $string['Blogs'] = 'Journals';
  $string['Blog'] = 'Journal';
   
  and by so Blogs doesn't translate at all. In the english language pack you 
have four of them 

  $string['Blogs'] = 'Journals';
  $string['blogs'] = 'journals';
  $string['Blogs'] = 'Journals';
  $string['blogs'] = 'journals';

  The ones with the capital B in the string name area the ones that
  affect the translation seen on the screen so could someone add them to
  the finnish language packs? I wonder why this have been done in such a
  weird way in the first place.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1749396/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1749408] Re: Make it possible for PlugIns defining a grouptab

2018-02-14 Thread Alexander Del Ponte

For this perhaps following idea could be a kind of code basis:

// ToDo: Make it possible to insert group_tabs by PlugIn conventions based 
on following code
foreach (plugin_types_installed() as $plugin_type_installed) {
foreach (plugins_installed($plugin_type_installed) as $plugin) {
// ToDo: Call PlugIn Method display_group_tab_allowed which 
provides the code which does all the checks here
if (method_exists(generate_class_name($plugin_type_installed, 
$plugin->name),'group_tabs')) {
$plugin_menu = 
call_static_method(generate_class_name($plugin_type_installed, $plugin->name), 
'group_tabs', $group->id);
$menu = array_merge($menu, $plugin_menu);
}
}
}

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1749408

Title:
  Make it possible for PlugIns defining a grouptab

Status in Mahara:
  New

Bug description:
  Currently we are developing an artefact plugin and a module plugin and
  therefore we need to have related grouptabs for users to use the new
  functionalities of these plugins.

  Unfortunately such additional tabs are only considered for interaction
  plugins.

  For our purposes we use a workaround by adding some code to the
  lib/group.php file at line 2046 to get this handled for our plugins
  like it is implemented as core code at line 2022 and following.

  It would be nice if group menu items of other plugin types than
  interaction could be defined if necessary by default without modifying
  the mahara core.

  Thank you
  Alex

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1749408/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1749408] [NEW] Make it possible for PlugIns defining a grouptab

2018-02-14 Thread Alexander Del Ponte

Public bug reported:

Currently we are developing an artefact plugin and a module plugin and
therefore we need to have related grouptabs for users to use the new
functionalities of these plugins.

Unfortunately such additional tabs are only considered for interaction
plugins.

For our purposes we use a workaround by adding some code to the
lib/group.php file at line 2046 to get this handled for our plugins like
it is implemented as core code at line 2022 and following.

It would be nice if group menu items of other plugin types than
interaction could be defined if necessary by default without modifying
the mahara core.

Thank you
Alex

** Affects: mahara
 Importance: Undecided
 Status: New

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1749408

Title:
  Make it possible for PlugIns defining a grouptab

Status in Mahara:
  New

Bug description:
  Currently we are developing an artefact plugin and a module plugin and
  therefore we need to have related grouptabs for users to use the new
  functionalities of these plugins.

  Unfortunately such additional tabs are only considered for interaction
  plugins.

  For our purposes we use a workaround by adding some code to the
  lib/group.php file at line 2046 to get this handled for our plugins
  like it is implemented as core code at line 2022 and following.

  It would be nice if group menu items of other plugin types than
  interaction could be defined if necessary by default without modifying
  the mahara core.

  Thank you
  Alex

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1749408/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1746259] Re: Make the T have the same behaviour as the privacy statement

2018-02-14 Thread Robert Lyon

** Changed in: mahara
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1746259

Title:
  Make the T have the same behaviour as the privacy statement

Status in Mahara:
  Fix Committed

Bug description:
  We need to make a series of changes in Mahara to comply with the GDPR.
  More info is available on the wiki at
  
https://wiki.mahara.org/wiki/Developer_Area/Specifications_in_Development/GDPR_compliance.

  We will need to make the following changes:

  1. Add the T to the site_content_version table.

  2. Display the T under the 'Legal' navigation link.

  3. Allow the site/institution admins to create new T versions.

  4. Ask user to agree to the site and institution T

  5. Show the user the current T version they have consented to.

  6. Allow the user to withdraw their consent to the current T
  version.

  7. Add T to the registration form

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1746259/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1746259] A change has been merged

2018-02-14 Thread Mahara Bot

Reviewed:  https://reviews.mahara.org/8488
Committed: 
https://git.mahara.org/mahara/mahara/commit/4e67c147b74e5f51ca92c98d64b3eba7a37046b0
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit 4e67c147b74e5f51ca92c98d64b3eba7a37046b0
Author: Maria Sorica 
Date:   Wed Jan 31 17:14:47 2018 +

Bug 1746259: Make the data on the site's 'Legal' page editable

The last version of privacy statement and the last version
of T are editable.

behatnotneeded

Change-Id: I444bb2dba4d119e86fb1c77d3595f982e99bd2b5

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1746259

Title:
  Make the T have the same behaviour as the privacy statement

Status in Mahara:
  Fix Committed

Bug description:
  We need to make a series of changes in Mahara to comply with the GDPR.
  More info is available on the wiki at
  
https://wiki.mahara.org/wiki/Developer_Area/Specifications_in_Development/GDPR_compliance.

  We will need to make the following changes:

  1. Add the T to the site_content_version table.

  2. Display the T under the 'Legal' navigation link.

  3. Allow the site/institution admins to create new T versions.

  4. Ask user to agree to the site and institution T

  5. Show the user the current T version they have consented to.

  6. Allow the user to withdraw their consent to the current T
  version.

  7. Add T to the registration form

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1746259/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1746259] A change has been merged

2018-02-14 Thread Mahara Bot

Reviewed:  https://reviews.mahara.org/8511
Committed: 
https://git.mahara.org/mahara/mahara/commit/5f27da1e7a07731297b8232d2cd9301d88476413
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit 5f27da1e7a07731297b8232d2cd9301d88476413
Author: Maria Sorica 
Date:   Wed Feb 7 12:35:46 2018 +

Bug 1746259: Withdraw consent to the T

1. Change the user manu item name from
Settings -> Privacy statement to Settings -> Legal.
2. Display T on the user's Legal page.
3. Allow T consent withdraw.

behatnotneeded

Change-Id: I08e5d97fc5ee712d3b930881aa97de6b2486ead4

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1746259

Title:
  Make the T have the same behaviour as the privacy statement

Status in Mahara:
  Fix Committed

Bug description:
  We need to make a series of changes in Mahara to comply with the GDPR.
  More info is available on the wiki at
  
https://wiki.mahara.org/wiki/Developer_Area/Specifications_in_Development/GDPR_compliance.

  We will need to make the following changes:

  1. Add the T to the site_content_version table.

  2. Display the T under the 'Legal' navigation link.

  3. Allow the site/institution admins to create new T versions.

  4. Ask user to agree to the site and institution T

  5. Show the user the current T version they have consented to.

  6. Allow the user to withdraw their consent to the current T
  version.

  7. Add T to the registration form

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1746259/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1746259] A change has been merged

2018-02-14 Thread Mahara Bot

Reviewed:  https://reviews.mahara.org/8505
Committed: 
https://git.mahara.org/mahara/mahara/commit/2814975b37c818b1ba73fb7875bc3d9adbaf806c
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit 2814975b37c818b1ba73fb7875bc3d9adbaf806c
Author: Maria Sorica 
Date:   Mon Feb 5 17:07:34 2018 +

Bug 1746259: Show the T on the after login page

behatnotneeded

Change-Id: I3bf21e40c957fd97b7c1b0d836ed340bebeb7616

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1746259

Title:
  Make the T have the same behaviour as the privacy statement

Status in Mahara:
  Fix Committed

Bug description:
  We need to make a series of changes in Mahara to comply with the GDPR.
  More info is available on the wiki at
  
https://wiki.mahara.org/wiki/Developer_Area/Specifications_in_Development/GDPR_compliance.

  We will need to make the following changes:

  1. Add the T to the site_content_version table.

  2. Display the T under the 'Legal' navigation link.

  3. Allow the site/institution admins to create new T versions.

  4. Ask user to agree to the site and institution T

  5. Show the user the current T version they have consented to.

  6. Allow the user to withdraw their consent to the current T
  version.

  7. Add T to the registration form

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1746259/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1746259] A change has been merged

2018-02-14 Thread Mahara Bot

Reviewed:  https://reviews.mahara.org/8500
Committed: 
https://git.mahara.org/mahara/mahara/commit/94533accac91ce140d9992a7ce9630b9ac10d149
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit 94533accac91ce140d9992a7ce9630b9ac10d149
Author: Maria Sorica 
Date:   Fri Feb 2 13:44:06 2018 +

Bug 1746259: Display and edit the T of an institution

behatnotneeded

Change-Id: I71f21f76129bc160904cffd1ff62dc6c7fd83c27

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1746259

Title:
  Make the T have the same behaviour as the privacy statement

Status in Mahara:
  Fix Committed

Bug description:
  We need to make a series of changes in Mahara to comply with the GDPR.
  More info is available on the wiki at
  
https://wiki.mahara.org/wiki/Developer_Area/Specifications_in_Development/GDPR_compliance.

  We will need to make the following changes:

  1. Add the T to the site_content_version table.

  2. Display the T under the 'Legal' navigation link.

  3. Allow the site/institution admins to create new T versions.

  4. Ask user to agree to the site and institution T

  5. Show the user the current T version they have consented to.

  6. Allow the user to withdraw their consent to the current T
  version.

  7. Add T to the registration form

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1746259/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1692757] A patch has been submitted for review

2018-02-14 Thread Mahara Bot

Patch for "master" branch: https://reviews.mahara.org/8523

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1692757

Title:
  Collapse main menu by pressing Esc key

Status in Mahara:
  In Progress

Bug description:
  Mahara 17.04+

  User should be able to collapse the main navigation menus (user menu,
  admin menu, main menu) by pressing the Escape key.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1692757/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1446400] A change has been merged

2018-02-14 Thread Mahara Bot

Reviewed:  https://reviews.mahara.org/8485
Committed: 
https://git.mahara.org/mahara/mahara/commit/099b3d3119a1e9900ab2ea2341470d15f05adbe3
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit 099b3d3119a1e9900ab2ea2341470d15f05adbe3
Author: Liam 
Date:   Wed Jan 31 10:29:47 2018 +1300

Bug #1446400: Add anchor button to tinymce

behatnotneeded

Change-Id: I6f2b26e6bb9e839e8c3ccaddef6fdfc916b3bdd9

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1446400

Title:
  Add anchor button to tinymce

Status in Mahara:
  Fix Committed

Bug description:
  One of the useful tinyMCE buttons that we currently do not use is the
  Anchor button to allow one to add anchors to a block of text.

  It should be a matter of adding 'anchor' to the plugins and toolbar
  sections of lib/web.php

  and then testing it out to make sure it works as expected

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1446400/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1711968] Re: HTML export doesn't show icons on file browser page

2018-02-14 Thread Robert Lyon

** Changed in: mahara
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1711968

Title:
  HTML export doesn't show icons on file browser page

Status in Mahara:
  Fix Committed

Bug description:
  When you export your entire portfolio as HTML and click on "Browse
  your file collection" on the index.html page, you see your file
  browser (see attached), but without the Font Awesome icons that should
  be displayed. We can display Font Awesome icons in other areas and
  thus it should be possible here as well.

  Instead, the placeholders still point to image files, e.g. 

  Changing this path to Font Awesome must have been forgotten when we
  removed the images.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1711968/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1711968] A change has been merged

2018-02-14 Thread Mahara Bot

Reviewed:  https://reviews.mahara.org/8480
Committed: 
https://git.mahara.org/mahara/mahara/commit/8d2ff36e792d025f367068f2f42f83023a3e8422
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit 8d2ff36e792d025f367068f2f42f83023a3e8422
Author: Liam 
Date:   Tue Jan 30 10:56:41 2018 +1300

Bug #1711968: HTML export doesn't show icons on file browser page

behatnotneeded

Change-Id: Id1fef94f4a0a2e466201bf4ad69a63c38fbb7b50

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1711968

Title:
  HTML export doesn't show icons on file browser page

Status in Mahara:
  Fix Committed

Bug description:
  When you export your entire portfolio as HTML and click on "Browse
  your file collection" on the index.html page, you see your file
  browser (see attached), but without the Font Awesome icons that should
  be displayed. We can display Font Awesome icons in other areas and
  thus it should be possible here as well.

  Instead, the placeholders still point to image files, e.g. 

  Changing this path to Font Awesome must have been forgotten when we
  removed the images.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1711968/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1017785] A patch has been submitted for review

2018-02-14 Thread Mahara Bot

Patch for "master" branch: https://reviews.mahara.org/8524

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1017785

Title:
  Empty blog should display "No entries yet." and "Add one" link

Status in Mahara:
  Confirmed

Bug description:
  Version: master

  Assumptions
   - Logged in user has one empty journal.

  Actions
   1. Open the empty journal.

  Expected results
   - Lang string "No entries yet. Add one" with link to create a new entry.

  Actual results
   - string: "0 entries"

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1017785/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1749635] [NEW] Behat test for Cover Letter 4.5.1.1 in manual test suite

2018-02-14 Thread Rebecca Blundell

Public bug reported:

test/behat/features/user_content/resume_page.feature is pretty comprehensive, 
but doesn't include a test for the cover letter part of the resume.
http://manual.mahara.org/en/17.10/content/resume.html#write-your-cover-letter


We need to add some lines to test the cover letter function to the first 
scenario:
Scenario: Editing admin resume page (Bug 1426983)
The scenario name can also be changed to "Editing Introduction"

** Affects: mahara
 Importance: Undecided
 Status: New


** Tags: behat

** Tags added: behat

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1749635

Title:
  Behat test for Cover Letter 4.5.1.1 in manual test suite

Status in Mahara:
  New

Bug description:
  test/behat/features/user_content/resume_page.feature is pretty comprehensive, 
but doesn't include a test for the cover letter part of the resume.
  http://manual.mahara.org/en/17.10/content/resume.html#write-your-cover-letter

  
  We need to add some lines to test the cover letter function to the first 
scenario:
  Scenario: Editing admin resume page (Bug 1426983)
  The scenario name can also be changed to "Editing Introduction"

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1749635/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1749628] [NEW] Behat test for File Quota 4.3.5 in manual test suite

2018-02-14 Thread Rebecca Blundell

Public bug reported:

Verify Quota is displayed on the sidebar of the Content->Files page

This only requires a line or two, so can be combined with
https://bugs.launchpad.net/mahara/+bug/1749626.

Just check quota is displayed with default maximum of 50.0MB, as here:
http://manual.mahara.org/en/17.10/content/files.html#file-quota

If the test needs to check what the maximum is set to before checking
the display, we could have a step to do that.

** Affects: mahara
 Importance: Undecided
 Status: New


** Tags: behat

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1749628

Title:
  Behat test for File Quota 4.3.5 in manual test suite

Status in Mahara:
  New

Bug description:
  Verify Quota is displayed on the sidebar of the Content->Files page

  This only requires a line or two, so can be combined with
  https://bugs.launchpad.net/mahara/+bug/1749626.

  Just check quota is displayed with default maximum of 50.0MB, as here:
  http://manual.mahara.org/en/17.10/content/files.html#file-quota

  If the test needs to check what the maximum is set to before checking
  the display, we could have a step to do that.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1749628/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1017785] Re: Empty blog should display "No entries yet." and "Add one" link

2018-02-14 Thread Liam

** Changed in: mahara
 Assignee: (unassigned) => Liam (liam-sharpe)

** Changed in: mahara
   Status: Confirmed => In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1017785

Title:
  Empty blog should display "No entries yet." and "Add one" link

Status in Mahara:
  In Progress

Bug description:
  Version: master

  Assumptions
   - Logged in user has one empty journal.

  Actions
   1. Open the empty journal.

  Expected results
   - Lang string "No entries yet. Add one" with link to create a new entry.

  Actual results
   - string: "0 entries"

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1017785/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1749626] [NEW] Behat test for Edit file 4.3.4 in manual test suite

2018-02-14 Thread Rebecca Blundell

Public bug reported:

We could automate this test

http://manual.mahara.org/en/17.10/content/files.html#edit-a-file-or-folder
4.3.4. Edit a file or folder

You can edit the properties of a file or folder at any time. The file
does not have to be re-linked in portfolio pages, but the properties you
changed will be updated automatically.

Test steps

need a user, a file, admin settings turned on.

add a file
add it to a page in a files block
edit the file - change the name
 - add a desc
 - a tag
 ...other options as turned on
Go to the page and check you can see the changes without having to re-link the 
file.

** Affects: mahara
 Importance: Undecided
 Status: New


** Tags: behat

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1749626

Title:
  Behat test for Edit file 4.3.4 in manual test suite

Status in Mahara:
  New

Bug description:
  We could automate this test

  http://manual.mahara.org/en/17.10/content/files.html#edit-a-file-or-folder
  4.3.4. Edit a file or folder

  You can edit the properties of a file or folder at any time. The file
  does not have to be re-linked in portfolio pages, but the properties
  you changed will be updated automatically.

  Test steps

  need a user, a file, admin settings turned on.

  add a file
  add it to a page in a files block
  edit the file - change the name
   - add a desc
   - a tag
   ...other options as turned on
  Go to the page and check you can see the changes without having to re-link 
the file.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1749626/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1749631] [NEW] Behat test for Journal Settings, 4.4.1 in manual test suite

2018-02-14 Thread Rebecca Blundell

Public bug reported:

expand the test/behat/features/user_content/add_blogs.feature to include check 
that settings can be changed, as described here:
You can change the title of your default journal (and all others if you have 
enabled multiple journals) and add a description as well as tags.
http://manual.mahara.org/en/17.10/content/journal.html#change-your-journal-settings

** Affects: mahara
 Importance: Undecided
 Status: New

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1749631

Title:
  Behat test for Journal Settings, 4.4.1 in manual test suite

Status in Mahara:
  New

Bug description:
  expand the test/behat/features/user_content/add_blogs.feature to include 
check that settings can be changed, as described here:
  You can change the title of your default journal (and all others if you have 
enabled multiple journals) and add a description as well as tags.
  
http://manual.mahara.org/en/17.10/content/journal.html#change-your-journal-settings

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1749631/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp

[Mahara-contributors] [Bug 1749403] [NEW] Code correction in function find_key_name of lib/ddl.php

[Mahara-contributors] [Bug 1749402] [NEW] Views and collection list (in group) throws MySQL error

[Mahara-contributors] [Bug 1749396] [NEW] Finnish translation pack missing strings

[Mahara-contributors] [Bug 1749408] Re: Make it possible for PlugIns defining a grouptab

[Mahara-contributors] [Bug 1749408] [NEW] Make it possible for PlugIns defining a grouptab

[Mahara-contributors] [Bug 1746259] Re: Make the T have the same behaviour as the privacy statement

[Mahara-contributors] [Bug 1746259] A change has been merged

[Mahara-contributors] [Bug 1746259] A change has been merged

[Mahara-contributors] [Bug 1746259] A change has been merged

[Mahara-contributors] [Bug 1746259] A change has been merged

[Mahara-contributors] [Bug 1692757] A patch has been submitted for review

[Mahara-contributors] [Bug 1446400] A change has been merged

[Mahara-contributors] [Bug 1711968] Re: HTML export doesn't show icons on file browser page

[Mahara-contributors] [Bug 1711968] A change has been merged

[Mahara-contributors] [Bug 1017785] A patch has been submitted for review

[Mahara-contributors] [Bug 1749635] [NEW] Behat test for Cover Letter 4.5.1.1 in manual test suite

[Mahara-contributors] [Bug 1749628] [NEW] Behat test for File Quota 4.3.5 in manual test suite

[Mahara-contributors] [Bug 1017785] Re: Empty blog should display "No entries yet." and "Add one" link

[Mahara-contributors] [Bug 1749626] [NEW] Behat test for Edit file 4.3.4 in manual test suite

[Mahara-contributors] [Bug 1749631] [NEW] Behat test for Journal Settings, 4.4.1 in manual test suite

20 matches

Site Navigation

Mail list logo

Footer information