[Mahara-contributors] [Bug 1778439] A patch has been submitted for review
Patch for "master" branch: https://reviews.mahara.org/9947 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1778439 Title: Behat help_icon test - put commented lines back in Status in Mahara: Confirmed Bug description: The other side of https://bugs.launchpad.net/mahara/+bug/1778438 We need to remember to put the commented out lines back into test/behat/features/site_content/help_icon.feature once jenkins is up- to-date. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1778439/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1827305] A patch has been submitted for review
Patch for "19.04_STABLE" branch: https://reviews.mahara.org/9948 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1827305 Title: Fixing add_tags behat feature Status in Mahara: In Progress Status in Mahara 18.10 series: In Progress Status in Mahara 19.04 series: In Progress Status in Mahara 19.10 series: In Progress Bug description: There was a failed step commented out but not fixed also not commented out in prev versions so was failing there will fix up To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1827305/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1827305] A change has been merged
Reviewed: https://reviews.mahara.org/9942 Committed: https://git.mahara.org/mahara/mahara/commit/e6069b7c52b0211f82544ace46a5d7055ff63e34 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:master commit e6069b7c52b0211f82544ace46a5d7055ff63e34 Author: Robert Lyon Date: Thu May 2 13:27:32 2019 +1200 Bug 1827305: add_tags behat failing due to external media loading Because the external media loading takes focus from next add block we should do this one last to avoid the clash. Change-Id: If89a658fd5be4578052ede703299832a0498eac4 Signed-off-by: Robert Lyon -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1827305 Title: Fixing add_tags behat feature Status in Mahara: In Progress Status in Mahara 18.10 series: In Progress Status in Mahara 19.04 series: In Progress Status in Mahara 19.10 series: In Progress Bug description: There was a failed step commented out but not fixed also not commented out in prev versions so was failing there will fix up To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1827305/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1827305] A patch has been submitted for review
Patch for "18.10_STABLE" branch: https://reviews.mahara.org/9949 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1827305 Title: Fixing add_tags behat feature Status in Mahara: In Progress Status in Mahara 18.10 series: In Progress Status in Mahara 19.04 series: In Progress Status in Mahara 19.10 series: In Progress Bug description: There was a failed step commented out but not fixed also not commented out in prev versions so was failing there will fix up To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1827305/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1827305] A change has been merged
Reviewed: https://reviews.mahara.org/9948 Committed: https://git.mahara.org/mahara/mahara/commit/50adda153a9f9e6d6fc7df6cfe386a81031433aa Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:19.04_STABLE commit 50adda153a9f9e6d6fc7df6cfe386a81031433aa Author: Robert Lyon Date: Thu May 2 13:27:32 2019 +1200 Bug 1827305: add_tags behat failing due to external media loading Because the external media loading takes focus from next add block we should do this one last to avoid the clash. Change-Id: If89a658fd5be4578052ede703299832a0498eac4 Signed-off-by: Robert Lyon (cherry picked from commit e6069b7c52b0211f82544ace46a5d7055ff63e34) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1827305 Title: Fixing add_tags behat feature Status in Mahara: In Progress Status in Mahara 18.10 series: In Progress Status in Mahara 19.04 series: In Progress Status in Mahara 19.10 series: In Progress Bug description: There was a failed step commented out but not fixed also not commented out in prev versions so was failing there will fix up To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1827305/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1044878] Re: Make the info on copying text box more obvious
** Changed in: mahara Status: In Progress => Fix Committed ** Changed in: mahara Milestone: None => 19.10.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1044878 Title: Make the info on copying text box more obvious Status in Mahara: Fix Committed Bug description: The text for re-using a text box "If you edit the text of this block, it will also be changed in 1 other block(s) where it appears. Make a copy (link to make a copy)" is not obvious enough for some users and may be overlooked. Can it be made more prominent, e.g. via a pop-up window? Is it possible to link "Make a copy" still within a pop-up or would we have to think of a different solution? For the discussion, please see https://mahara.org/interaction/forum/topic.php?id=4827 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1044878/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1044878] A change has been merged
Reviewed: https://reviews.mahara.org/9655 Committed: https://git.mahara.org/mahara/mahara/commit/0df38c69d7cc8076502c717b693cf75179e22ac0 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:master commit 0df38c69d7cc8076502c717b693cf75179e22ac0 Author: Kevin Dibble Date: Mon Mar 25 14:17:55 2019 +1300 Bug 1044878: Editing duplicated content Added a new feature that the user has to choose yes to start editing copy. This will force users to interact with the form before editing with the choice that they are editing all copies of this content. When selecting to use content from another note, the form will update based on their choice. The editor will remain open if yes has been selected. The editor will be hidden and only the content will show if 'Yes' has not be selected. This is a UI element only - no decision is saved to the DB as this is an editor based decision. behatnotneeded Change-Id: Idb8d6736796a2350359bd59395393f6c7d742f96 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1044878 Title: Make the info on copying text box more obvious Status in Mahara: Fix Committed Bug description: The text for re-using a text box "If you edit the text of this block, it will also be changed in 1 other block(s) where it appears. Make a copy (link to make a copy)" is not obvious enough for some users and may be overlooked. Can it be made more prominent, e.g. via a pop-up window? Is it possible to link "Make a copy" still within a pop-up or would we have to think of a different solution? For the discussion, please see https://mahara.org/interaction/forum/topic.php?id=4827 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1044878/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1827305] A change has been merged
Reviewed: https://reviews.mahara.org/9949 Committed: https://git.mahara.org/mahara/mahara/commit/b89c8ddf316aedc4087842232c1454b9b99db20b Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:18.10_STABLE commit b89c8ddf316aedc4087842232c1454b9b99db20b Author: Robert Lyon Date: Thu May 2 13:27:32 2019 +1200 Bug 1827305: add_tags behat failing due to external media loading Because the external media loading takes focus from next add block we should do this one last to avoid the clash. Change-Id: If89a658fd5be4578052ede703299832a0498eac4 Signed-off-by: Robert Lyon (cherry picked from commit e6069b7c52b0211f82544ace46a5d7055ff63e34) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1827305 Title: Fixing add_tags behat feature Status in Mahara: In Progress Status in Mahara 18.10 series: In Progress Status in Mahara 19.04 series: In Progress Status in Mahara 19.10 series: In Progress Bug description: There was a failed step commented out but not fixed also not commented out in prev versions so was failing there will fix up To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1827305/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1821082] Re: PHPUnit test - Installing lastcoredata fail
** Changed in: mahara
Status: New => Invalid
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1821082
Title:
PHPUnit test - Installing lastcoredata fail
Status in Mahara:
Invalid
Bug description:
Hi,
When i try to laucnh phpunit test (make phpunit) i get this error
[INF] 4f (lib/phpunit.php:107) Installing lastcoredata
PHP Warning: require_once(Zend/Cache/Backend/ExtendedInterface.php): failed
to open stream: No such file or directory in
/app/jenkins/mahara_test/htdocs/webservice/libs/zend/Zend/Cache/Backend/Test.php
on line 27
Warning: require_once(Zend/Cache/Backend/ExtendedInterface.php): failed to
open stream: No such file or directory in
/app/jenkins/mahara_test/htdocs/webservice/libs/zend/Zend/Cache/Backend/Test.php
on line 27
PHP Fatal error: require_once(): Failed opening required
'Zend/Cache/Backend/ExtendedInterface.php'
(include_path='/app/jenkins/mahara_test/htdocs/lib/:/app/jenkins/mahara_test/htdocs/lib/pear/:.:/usr/share/pear:/usr/share/php')
in
/app/jenkins/mahara_test/htdocs/webservice/libs/zend/Zend/Cache/Backend/Test.php
on line 27
Fatal error: require_once(): Failed opening required
'Zend/Cache/Backend/ExtendedInterface.php'
(include_path='/app/jenkins/mahara_test/htdocs/lib/:/app/jenkins/mahara_test/htdocs/lib/pear/:.:/usr/share/pear:/usr/share/php')
in
/app/jenkins/mahara_test/htdocs/webservice/libs/zend/Zend/Cache/Backend/Test.php
on line 27
make: *** [phpunit] Error 255
And the second try i get this
[DBG] bf (lib/ddl.php:753) CONSTRAINT tst_oautservconf_oau_fk FOREIGN KEY
(oauthserverregistryid) REFERENCES tst_oauth_server_registry (id)
[DBG] bf (lib/ddl.php:753) )ENGINE=innodb
[DBG] bf (lib/ddl.php:753) [36] => ALTER TABLE tst_oauth_server_config
COMMENT='Table to store settings related to an oauth server registry'
[DBG] bf (lib/ddl.php:753) [37] => CREATE INDEX tst_oautservconf_oau_ix
ON tst_oauth_server_config (oauthserverregistryid)
[DBG] bf (lib/ddl.php:753) )
[DBG] bf (lib/ddl.php:753)
PHP Fatal error: Uncaught SQLException: Failed to install (check logs for
xmldb errors) in /app/jenkins/mahara_test/htdocs/lib/ddl.php:754
Stack trace:
#0 /app/jenkins/mahara_test/htdocs/lib/upgrade.php(444):
install_from_xmldb_file('/app/jenkins/ma...')
#1 /app/jenkins/mahara_test/htdocs/lib/phpunit.php(121):
upgrade_plugin(Object(stdClass))
#2 /app/jenkins/mahara_test/htdocs/lib/tests/phpunit/bootstrap.php(34):
UnitTestBootstrap->install_mahara()
#3
/app/jenkins/mahara_test/external/vendor/phpunit/phpunit/src/Util/Fileloader.php(64):
include_once('/app/jenkins/ma...')
#4
/app/jenkins/mahara_test/external/vendor/phpunit/phpunit/src/Util/Fileloader.php(48):
PHPUnit\Util\Fileloader::load('/app/jenkins/ma...')
#5
/app/jenkins/mahara_test/external/vendor/phpunit/phpunit/src/TextUI/Command.php(991):
PHPUnit\Util\Fileloader::checkAndLoad('/app/jenkins/ma...')
#6
/app/jenkins/mahara_test/external/vendor/phpunit/phpunit/src/TextUI/Command.php(788):
PHPUnit\TextUI\Command->handleBootstrap('/app/jenkins/ma...')
#7 /app/jenkins/mahara_ in /app/jenkins/mahara_test/htdocs/lib/ddl.php on
line 754
Fatal error: Uncaught SQLException: Failed to install (check logs for xmldb
errors) in /app/jenkins/mahara_test/htdocs/lib/ddl.php:754
Stack trace:
#0 /app/jenkins/mahara_test/htdocs/lib/upgrade.php(444):
install_from_xmldb_file('/app/jenkins/ma...')
#1 /app/jenkins/mahara_test/htdocs/lib/phpunit.php(121):
upgrade_plugin(Object(stdClass))
#2 /app/jenkins/mahara_test/htdocs/lib/tests/phpunit/bootstrap.php(34):
UnitTestBootstrap->install_mahara()
#3
/app/jenkins/mahara_test/external/vendor/phpunit/phpunit/src/Util/Fileloader.php(64):
include_once('/app/jenkins/ma...')
#4
/app/jenkins/mahara_test/external/vendor/phpunit/phpunit/src/Util/Fileloader.php(48):
PHPUnit\Util\Fileloader::load('/app/jenkins/ma...')
#5
/app/jenkins/mahara_test/external/vendor/phpunit/phpunit/src/TextUI/Command.php(991):
PHPUnit\Util\Fileloader::checkAndLoad('/app/jenkins/ma...')
#6
/app/jenkins/mahara_test/external/vendor/phpunit/phpunit/src/TextUI/Command.php(788):
PHPUnit\TextUI\Command->handleBootstrap('/app/jenkins/ma...')
#7 /app/jenkins/mahara_ in /app/jenkins/mahara_test/htdocs/lib/ddl.php on
line 754
make: *** [phpunit] Error 255
OS RedHat
Mahara 18.10
Php 7.2
Mysql 5.7
PhpUnit 8
To manage notifications about
[Mahara-contributors] [Bug 1827390] [NEW] Latency smarty header_logo_small - IMPORTANT
Public bug reported:
public function header_logo_small() {
if (!empty($this->headerlogosmall)) {
returnget_config('wwwroot')
.'thumb.php?type=logobyid='.$this->headerlogosmall;
}
else {
require_once('ddl.php');
$table = newXMLDBTable('institution');
$field = newXMLDBField('logoxs');
if (field_exists($table, $field) && $sitelogosmallid =
get_field('institution', 'logoxs', 'name', 'mahara')) {
returnget_config('wwwroot')
.'thumb.php?type=logobyid='.$sitelogosmallid;
}
}
returnfalse;
}
In this function compare to header_logo, why using ddl.php and newXMLDBTable /
Field. It's not ncessary and that's create many latency when i test with a
profiler.
Rewrite this fucntion like header_logo just decrease calls on data base.
- Mahara 18.10
- MySqL 5.7
- Php 7.2
** Affects: mahara
Importance: Undecided
Status: New
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1827390
Title:
Latency smarty header_logo_small - IMPORTANT
Status in Mahara:
New
Bug description:
public function header_logo_small() {
if (!empty($this->headerlogosmall)) {
returnget_config('wwwroot')
.'thumb.php?type=logobyid='.$this->headerlogosmall;
}
else {
require_once('ddl.php');
$table = newXMLDBTable('institution');
$field = newXMLDBField('logoxs');
if (field_exists($table, $field) && $sitelogosmallid =
get_field('institution', 'logoxs', 'name', 'mahara')) {
returnget_config('wwwroot')
.'thumb.php?type=logobyid='.$sitelogosmallid;
}
}
returnfalse;
}
In this function compare to header_logo, why using ddl.php and newXMLDBTable
/ Field. It's not ncessary and that's create many latency when i test with a
profiler.
Rewrite this fucntion like header_logo just decrease calls on data base.
- Mahara 18.10
- MySqL 5.7
- Php 7.2
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1827390/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1827445] Re: Improve efficiency when checking if a table field exists
*** This bug is a duplicate of bug 1827390 ***
https://bugs.launchpad.net/bugs/1827390
** This bug has been marked a duplicate of bug 1827390
Latency smarty header_logo_small - IMPORTANT
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1827445
Title:
Improve efficiency when checking if a table field exists
Status in Mahara:
In Progress
Bug description:
When upgrading we use a field_exists() check to see if a table has a
certain column or not which is fine there as upgrade chunks are a one-
time execution run when users are all logged out.
However we have begun to use field_exists() within other parts of the
code and so this can get called on every page load by multiple users
at once. This requires fetching the ddl.lib file and setting ul an
XMLDB table object and an XMLDB field object which has overhead.
Instead we should just query the database directly and ask it if the
table has the column or not
So instead of doing:
require_once('ddl.php');
$table = new XMLDBTable('tablename');
$field = new XMLDBField('fieldname');
if (field_exists($table, $field)) {
...
}
We could just do:
if (column_exists('tablename', 'fieldname')) {
...
}
And have the column_exists function that call the database directly
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1827445/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1827390] Re: Latency smarty header_logo_small - IMPORTANT
** Changed in: mahara
Status: New => In Progress
** Changed in: mahara
Importance: Undecided => Medium
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1827390
Title:
Latency smarty header_logo_small - IMPORTANT
Status in Mahara:
In Progress
Bug description:
public function header_logo_small() {
if (!empty($this->headerlogosmall)) {
returnget_config('wwwroot')
.'thumb.php?type=logobyid='.$this->headerlogosmall;
}
else {
require_once('ddl.php');
$table = newXMLDBTable('institution');
$field = newXMLDBField('logoxs');
if (field_exists($table, $field) && $sitelogosmallid =
get_field('institution', 'logoxs', 'name', 'mahara')) {
returnget_config('wwwroot')
.'thumb.php?type=logobyid='.$sitelogosmallid;
}
}
returnfalse;
}
In this function compare to header_logo, why using ddl.php and newXMLDBTable
/ Field. It's not ncessary and that's create many latency when i test with a
profiler.
Rewrite this fucntion like header_logo just decrease calls on data base.
- Mahara 18.10
- MySqL 5.7
- Php 7.2
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1827390/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 655443] Re: Make block titles optional
TITLE: Make block titles optional BUG SUMMARY: In some blocks, like 'blog', the title defaults to the title of the blog if you leave the title blank, but others (like text box) let you have no title just by leaving it blank (and the view editor helpfully shows "[No title]"). See some other discussion on https://bugs.launchpad.net/mahara/+bug/617159 ACCEPTANCE CRITERIA: 1) Added a switch to the form to allow Block titles to be hidden. If it is not set, it will default to false to show the blocks title. 2) The following blocks are not configurable and will not have the ability to use this "Hide title" functionality a) Comments block b) Signoff block c) Wall block (profile page) d) My friends block (profile page) e) My Groups (profile page) f) My portfolios (profile page) 3) Functionality should work on the following pages: a) portfolio pages b) profile pages c) dashboard pages d) group pages e) Institution pages f) Site pages == Commit hash: 5a981ed236b87c02d7b8d79fbcbdc5264d853f88 Environment tested: Master Browser tested: Chrome Theme used: Primary school PRECONDITIONS: 1) Mahara User exists (User4) 2) Mahara User4 has a journal with 3 journal entries 3) Group exists TEST STEPS: 1) Log in as Mahara User4 (no roles) 2) Create a portfolio page give it a name, and description text - use default settings (3 column layout) 3) Add a "Journal block" - use default title 4)VERIFY the Block title field default value is "Set block title" ✔ 4)VERIFY there is a Yes/No toggle switch labelled "Hide title" ✔ 5)VERIFY that the default setting for the "Hide title" toggle is "No" ✔ 6) Set the "Hide title" switch to = Yes (leave the rest of the fields as they are) 7) Click "Save" button 8)VERIFY "Journal block" is displayed as follows: a) Block title = " Journal" ✔ b) existing journal entries also displayed ✔ NOTE: while user is in edit mode the block titles will display - User must view the displayed page to see effects of hiding block titles 9) Click the "Display page" button 10)VERIFY that the "Journal block" is displayed with NO title but the existing journal entries are displayed ✔ # Add a Text Block with a title - do not use the "Hide title" field 11) Go back to edit mode for the page and - Add a "Text block" as follows: a) Add a title in the title field b) Ensure "Hide title" field is set to = Yes c) Add 1 paragraph of text in block content field 12)VERIFY (in edit mode) that the "Text" block is displayed with a title and 1 paragraph of text is also displayed ✔ 13) Click "Save" button 14)VERIFY that the "Text block" is displayed as follows: a) Block title = [No title] ✔ b) 1 paragraph of text is displayed ✔ # Add a Text Block with NO title - do not use the "Hide title" field (leave as default value) NOTE: This is existing functionality 15) Go back to edit mode for the page and - Add a "Text block" as follows: a) Delete the title field b) Ensure "Hide title" field is set to = No c) Add 1 paragraph of text in block content field 16) Click "Save" button 17)VERIFY that the "Text block" is displayed as follows: a) Block title = [No title] ✔ b) 1 paragraph of text is displayed ✔ 18) Click the "Display page" button 19)VERIFY that the "Text block" is displayed as follows: a) No title is displayed ✔ b) 1 paragraph of text is displayed ✔ 20) run the above script for the following pages: a) portfolio pages ✔ b) profile pages ✔ c) dashboard pages ✔ d) group pages ✔ e) Institution pages ✔ f) Site pages ✔ Catalyst QA Approved ✔ -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/655443 Title: Make block titles optional Status in Mahara: In Progress Bug description: In some blocks, like 'blog', the title defaults to the title of the blog if you leave the title blank, but others (like text box) let you have no title just by leaving it blank (and the view editor helpfully shows "[No title]"). I think we need a "No title" checkbox for the blocks that don't already allow you to have no title by leaving the title blank. Or maybe instead, a blank title should really mean 'no title' and there should be a checkbox on some of the blocks saying stuff like "use the blog's title". See some other discussion on https://bugs.launchpad.net/mahara/+bug/617159 To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/655443/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to :
[Mahara-contributors] [Bug 1827445] Re: Improve efficiency when checking if a table field exists
Ok, have made patch
https://reviews.mahara.org/#/c/9950/
And tested in the following way:
// Old way
$stime = time();
log_debug('start: ' . $stime);
for ($i = 1; $i <= 1; $i++) {
require_once('ddl.php');
$table = new XMLDBTable('view_access');
$field = new XMLDBField('id');
if (field_exists($table, $field)) { }
if (($i % 1000) == 0) {
log_debug('.');
}
}
$etime = time();
log_debug('end: ' . $etime);
log_debug($etime - $stime);
had time diff of approx 130 seconds per run for postgres
had time diff of approx 90 seconds per run for mysql
// vs New way
$stime = time();
log_debug('start: ' . $stime);
for ($i = 1; $i <= 1; $i++) {
if (column_exists('view_access', 'id')) { }
if (($i % 1000) == 0) {
log_debug('.');
}
}
$etime = time();
log_debug('end: ' . $etime);
log_debug($etime - $stime);
had time diff of approx 40 seconds for postgres
had time diff of approx 4 seconds for mysql
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1827445
Title:
Improve efficiency when checking if a table field exists
Status in Mahara:
In Progress
Bug description:
When upgrading we use a field_exists() check to see if a table has a
certain column or not which is fine there as upgrade chunks are a one-
time execution run when users are all logged out.
However we have begun to use field_exists() within other parts of the
code and so this can get called on every page load by multiple users
at once. This requires fetching the ddl.lib file and setting ul an
XMLDB table object and an XMLDB field object which has overhead.
Instead we should just query the database directly and ask it if the
table has the column or not
So instead of doing:
require_once('ddl.php');
$table = new XMLDBTable('tablename');
$field = new XMLDBField('fieldname');
if (field_exists($table, $field)) {
...
}
We could just do:
if (column_exists('tablename', 'fieldname')) {
...
}
And have the column_exists function that call the database directly
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1827445/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1827305] Re: Fixing add_tags behat feature
** Changed in: mahara/19.10 Status: In Progress => Fix Committed ** Changed in: mahara/19.04 Status: In Progress => Fix Committed ** Changed in: mahara/18.10 Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1827305 Title: Fixing add_tags behat feature Status in Mahara: Fix Committed Status in Mahara 18.10 series: Fix Committed Status in Mahara 19.04 series: Fix Committed Status in Mahara 19.10 series: Fix Committed Bug description: There was a failed step commented out but not fixed also not commented out in prev versions so was failing there will fix up To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1827305/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1813987] A patch has been submitted for review
Patch for "master" branch: https://reviews.mahara.org/9952 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1813987 Title: more usable and simpler layout selector for Mahara pages Status in Mahara: In Progress Bug description: We are planning to improve the layout of mahara pages using the gridstack library. http://gridstackjs.com/ To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1813987/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1827445] [NEW] Improve efficiency when checking if a table field exists
Public bug reported:
When upgrading we use a field_exists() check to see if a table has a
certain column or not which is fine there as upgrade chunks are a one-
time execution run when users are all logged out.
However we have begun to use field_exists() within other parts of the
code and so this can get called on every page load by multiple users at
once. This requires fetching the ddl.lib file and setting ul an XMLDB
table object and an XMLDB field object which has overhead.
Instead we should just query the database directly and ask it if the
table has the column or not
So instead of doing:
require_once('ddl.php');
$table = new XMLDBTable('tablename');
$field = new XMLDBField('fieldname');
if (field_exists($table, $field)) {
...
}
We could just do:
if (column_exists('tablename', 'fieldname')) {
...
}
** Affects: mahara
Importance: Undecided
Status: New
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1827445
Title:
Improve efficiency when checking if a table field exists
Status in Mahara:
New
Bug description:
When upgrading we use a field_exists() check to see if a table has a
certain column or not which is fine there as upgrade chunks are a one-
time execution run when users are all logged out.
However we have begun to use field_exists() within other parts of the
code and so this can get called on every page load by multiple users
at once. This requires fetching the ddl.lib file and setting ul an
XMLDB table object and an XMLDB field object which has overhead.
Instead we should just query the database directly and ask it if the
table has the column or not
So instead of doing:
require_once('ddl.php');
$table = new XMLDBTable('tablename');
$field = new XMLDBField('fieldname');
if (field_exists($table, $field)) {
...
}
We could just do:
if (column_exists('tablename', 'fieldname')) {
...
}
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1827445/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1827455] [NEW] ClamAV admin message missing info
Public bug reported: When getting an admin ClamAV message when something goes wrong with ClamAV scan we get: - Subject: Mahara :: ClamAV notification ClamAV has failed to run. The return error message was There was an unknown error with ClamAV.. Here is the output from ClamAV: Killed The file has been moved to a quarantine directory. - We are missing the information about the file that caused the scan to be kicked off ** Affects: mahara Importance: Low Status: In Progress ** Changed in: mahara Status: New => In Progress ** Changed in: mahara Importance: Undecided => Low ** Changed in: mahara Milestone: None => 19.10.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1827455 Title: ClamAV admin message missing info Status in Mahara: In Progress Bug description: When getting an admin ClamAV message when something goes wrong with ClamAV scan we get: - Subject: Mahara :: ClamAV notification ClamAV has failed to run. The return error message was There was an unknown error with ClamAV.. Here is the output from ClamAV: Killed The file has been moved to a quarantine directory. - We are missing the information about the file that caused the scan to be kicked off To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1827455/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1827455] A patch has been submitted for review
Patch for "master" branch: https://reviews.mahara.org/9951 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1827455 Title: ClamAV admin message missing info Status in Mahara: In Progress Bug description: When getting an admin ClamAV message when something goes wrong with ClamAV scan we get: - Subject: Mahara :: ClamAV notification ClamAV has failed to run. The return error message was There was an unknown error with ClamAV.. Here is the output from ClamAV: Killed The file has been moved to a quarantine directory. - We are missing the information about the file that caused the scan to be kicked off To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1827455/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1827445] Re: Improve efficiency when checking if a table field exists
** Description changed:
When upgrading we use a field_exists() check to see if a table has a
certain column or not which is fine there as upgrade chunks are a one-
time execution run when users are all logged out.
However we have begun to use field_exists() within other parts of the
code and so this can get called on every page load by multiple users at
once. This requires fetching the ddl.lib file and setting ul an XMLDB
table object and an XMLDB field object which has overhead.
Instead we should just query the database directly and ask it if the
table has the column or not
-
So instead of doing:
require_once('ddl.php');
$table = new XMLDBTable('tablename');
$field = new XMLDBField('fieldname');
if (field_exists($table, $field)) {
- ...
+ ...
}
We could just do:
if (column_exists('tablename', 'fieldname')) {
- ...
+ ...
}
+
+ And have the column_exists function that call the database directly
** Changed in: mahara
Milestone: None => 19.10.0
** Changed in: mahara
Status: New => In Progress
** Changed in: mahara
Importance: Undecided => Medium
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1827445
Title:
Improve efficiency when checking if a table field exists
Status in Mahara:
In Progress
Bug description:
When upgrading we use a field_exists() check to see if a table has a
certain column or not which is fine there as upgrade chunks are a one-
time execution run when users are all logged out.
However we have begun to use field_exists() within other parts of the
code and so this can get called on every page load by multiple users
at once. This requires fetching the ddl.lib file and setting ul an
XMLDB table object and an XMLDB field object which has overhead.
Instead we should just query the database directly and ask it if the
table has the column or not
So instead of doing:
require_once('ddl.php');
$table = new XMLDBTable('tablename');
$field = new XMLDBField('fieldname');
if (field_exists($table, $field)) {
...
}
We could just do:
if (column_exists('tablename', 'fieldname')) {
...
}
And have the column_exists function that call the database directly
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1827445/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1827445] A patch has been submitted for review
Patch for "master" branch: https://reviews.mahara.org/9950
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1827445
Title:
Improve efficiency when checking if a table field exists
Status in Mahara:
In Progress
Bug description:
When upgrading we use a field_exists() check to see if a table has a
certain column or not which is fine there as upgrade chunks are a one-
time execution run when users are all logged out.
However we have begun to use field_exists() within other parts of the
code and so this can get called on every page load by multiple users
at once. This requires fetching the ddl.lib file and setting ul an
XMLDB table object and an XMLDB field object which has overhead.
Instead we should just query the database directly and ask it if the
table has the column or not
So instead of doing:
require_once('ddl.php');
$table = new XMLDBTable('tablename');
$field = new XMLDBField('fieldname');
if (field_exists($table, $field)) {
...
}
We could just do:
if (column_exists('tablename', 'fieldname')) {
...
}
And have the column_exists function that call the database directly
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1827445/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1818166] Re: login form error when upgrading site
[Expired for Mahara because there has been no activity for 60 days.]
** Changed in: mahara
Status: Incomplete => Expired
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1818166
Title:
login form error when upgrading site
Status in Mahara:
Expired
Bug description:
On master, go to /admin/upgrade.php
after adding the urlsecret, we can see the error message
[INF] 8d (admin/upgrade.php:59) Performing upgrades...
[WAR] 8d (lib/pieforms/pieform.php:1596) Pieform element login_login_password
wants to add headdata to the page, but it's too late. Build your form before
generating the page.
Call stack (most recent first):
log_message("Pieform element login_login_password wants to add ...", 8,
true, true) at /home/ceciliavg/maharacode/mahara/htdocs/lib/errors.php:95
log_warn("Pieform element login_login_password wants to add ...") at
/home/ceciliavg/maharacode/mahara/htdocs/lib/pieforms/pieform.php:1596
Pieform->build_element_html(array(size 10)) at
/home/ceciliavg/maharacode/mahara/htdocs/lib/pieforms/pieform.php:722
Pieform->build() at
/home/ceciliavg/maharacode/mahara/htdocs/lib/pieforms/pieform.php:171
Pieform::process(array(size 7)) at
/home/ceciliavg/maharacode/mahara/htdocs/lib/mahara.php:5412
pieform(array(size 7)) at
/home/ceciliavg/maharacode/mahara/htdocs/auth/lib.php:2255
auth_generate_login_form() at
/home/ceciliavg/maharacode/mahara/htdocs/lib/web.php:175
smarty(array(size 0), array(size 0), array(size 0), array(size 1)) at
/home/ceciliavg/maharacode/mahara/htdocs/lib/errors.php:458
die_info("Nothing to upgrade. You are fully up to date.https://bugs.launchpad.net/mahara/+bug/1818166/+subscriptions
___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
