Re: [Mailman-Users] SpamDetect loop?

2006-01-15 Thread David Gibbs
Tokio Kikuchi wrote:
 Can you test this patch?

Seems to be working fine.

david
--
Mailman-Users mailing list
Mailman-Users@python.org
http://mail.python.org/mailman/listinfo/mailman-users
Mailman FAQ: http://www.python.org/cgi-bin/faqw-mm.py
Searchable Archives: http://www.mail-archive.com/mailman-users%40python.org/
Unsubscribe: 
http://mail.python.org/mailman/options/mailman-users/archive%40jab.org

Security Policy: 
http://www.python.org/cgi-bin/faqw-mm.py?req=showamp;file=faq01.027.htp


Re: [Mailman-Users] SpamDetect loop?

2006-01-15 Thread Tokio Kikuchi
David Gibbs wrote:
 Tokio Kikuchi wrote:
 
Can you test this patch?
 
 
 Seems to be working fine.
 
 david
 
 
 
Thank you David.  I changed the patch slightly and checked into the CVS. 
  See also this patch tracker entry:
http://sourceforge.net/tracker/index.php?func=detailaid=1405790group_id=103atid=300103

Cheers,
-- 
Tokio Kikuchi, tkikuchi@ is.kochi-u.ac.jp
http://weather.is.kochi-u.ac.jp/
--
Mailman-Users mailing list
Mailman-Users@python.org
http://mail.python.org/mailman/listinfo/mailman-users
Mailman FAQ: http://www.python.org/cgi-bin/faqw-mm.py
Searchable Archives: http://www.mail-archive.com/mailman-users%40python.org/
Unsubscribe: 
http://mail.python.org/mailman/options/mailman-users/archive%40jab.org

Security Policy: 
http://www.python.org/cgi-bin/faqw-mm.py?req=showamp;file=faq01.027.htp


[Mailman-Users] SpamDetect loop?

2006-01-11 Thread David Gibbs
Folks:

Since I upgraded to MM 2.1.7 I've noticed something odd in my admin
queue ... it appears that messages coming through the SpamDetect
pipeline for the owner-address are getting into a loop.

Basically, if I get a message in my admin queue for 'out of office'
(simple spam filter), I get dozens if not hundreds of the following also
in my admin queue ...

---
As list administrator, your authorization is requested for the
following mailing list posting:

List:[EMAIL PROTECTED]
From:[EMAIL PROTECTED]
Subject: RPG400-L post from [EMAIL PROTECTED] requires approval
Reason:  The message headers matched a filter rule

At your convenience, visit:

http://lists.midrange.com/mailman/admindb/rpg400-l

to approve or deny the request.
As list administrator, your authorization is requested for the
following mailing list posting:

List:[EMAIL PROTECTED]
From:[EMAIL PROTECTED]
Subject: user CV Rao/PGG/example is out of the office.
Reason:  The message headers matched a filter rule

At your convenience, visit:

http://lists.midrange.com/mailman/admindb/rpg400-l

to approve or deny the request.

I will be out of the office starting  11/01/2006 and will not return until
07/02/2006.
---

It *APPEARS* to me that the spam detect filters are keying on the out
of office message that is included in the original message.

As an experiment, I've removed the SpamDetect entry from the
OWNER_PIPELINE entry in mm_cfg.py.

Any other suggestions?

Thanks!

david

--
Mailman-Users mailing list
Mailman-Users@python.org
http://mail.python.org/mailman/listinfo/mailman-users
Mailman FAQ: http://www.python.org/cgi-bin/faqw-mm.py
Searchable Archives: http://www.mail-archive.com/mailman-users%40python.org/
Unsubscribe: 
http://mail.python.org/mailman/options/mailman-users/archive%40jab.org

Security Policy: 
http://www.python.org/cgi-bin/faqw-mm.py?req=showamp;file=faq01.027.htp


Re: [Mailman-Users] SpamDetect loop?

2006-01-11 Thread Mark Sapiro
David Gibbs wrote:

Since I upgraded to MM 2.1.7 I've noticed something odd in my admin
queue ... it appears that messages coming through the SpamDetect
pipeline for the owner-address are getting into a loop.

Basically, if I get a message in my admin queue for 'out of office'
(simple spam filter), I get dozens if not hundreds of the following also
in my admin queue ...

snip

It *APPEARS* to me that the spam detect filters are keying on the out
of office message that is included in the original message.

As an experiment, I've removed the SpamDetect entry from the
OWNER_PIPELINE entry in mm_cfg.py.

Any other suggestions?

There are a few things going on. Did you upgrade from 2.1.6 or from
pre-2.1.6? Starting in 2.1.6, header_filter_rules are applied to the
headers of sub-parts which might cause a problem if the admin
notification contains something that matches, BUT there is a safety
valve in that the SpamDetect process is never supposed to be applied
to internally generated messages such as admin notifications.

So something is going wrong here, but I don't know what. I will
investigate, but if you could send me off list what your
header_filter_rules are and a copy of the original problem message, it
may help me.

-- 
Mark Sapiro [EMAIL PROTECTED]   The highway is for gamblers,
San Francisco Bay Area, Californiabetter use your sense - B. Dylan

--
Mailman-Users mailing list
Mailman-Users@python.org
http://mail.python.org/mailman/listinfo/mailman-users
Mailman FAQ: http://www.python.org/cgi-bin/faqw-mm.py
Searchable Archives: http://www.mail-archive.com/mailman-users%40python.org/
Unsubscribe: 
http://mail.python.org/mailman/options/mailman-users/archive%40jab.org

Security Policy: 
http://www.python.org/cgi-bin/faqw-mm.py?req=showamp;file=faq01.027.htp


Re: [Mailman-Users] SpamDetect loop?

2006-01-11 Thread David Gibbs
Mark Sapiro wrote:
 There are a few things going on. Did you upgrade from 2.1.6 or from
 pre-2.1.6? 

2.1.5 with some custom patches (nothing major, just text changes  the
like).

 Starting in 2.1.6, header_filter_rules are applied to the
 headers of sub-parts which might cause a problem if the admin
 notification contains something that matches, BUT there is a safety
 valve in that the SpamDetect process is never supposed to be applied
 to internally generated messages such as admin notifications.

Ok, that does appear to be what is happening ... but the safety valve
doesn't seem to be kicking in.

 So something is going wrong here, but I don't know what. I will
 investigate, but if you could send me off list what your
 header_filter_rules are and a copy of the original problem message, it
 may help me.

I'll send that under separate cover :)

david

--
Mailman-Users mailing list
Mailman-Users@python.org
http://mail.python.org/mailman/listinfo/mailman-users
Mailman FAQ: http://www.python.org/cgi-bin/faqw-mm.py
Searchable Archives: http://www.mail-archive.com/mailman-users%40python.org/
Unsubscribe: 
http://mail.python.org/mailman/options/mailman-users/archive%40jab.org

Security Policy: 
http://www.python.org/cgi-bin/faqw-mm.py?req=showamp;file=faq01.027.htp


Re: [Mailman-Users] SpamDetect loop?

2006-01-11 Thread Tokio Kikuchi
Hi,

I've coded that bug in the last minute of releasing. :-(
I think I can generate a patch, but in the meantime, please copy the 
SpamDetect.py file from 2.1.6 distribution and restart.

David Gibbs wrote:
 Mark Sapiro wrote:
 
There are a few things going on. Did you upgrade from 2.1.6 or from
pre-2.1.6? 
 
 
 2.1.5 with some custom patches (nothing major, just text changes  the
 like).
 
 
Starting in 2.1.6, header_filter_rules are applied to the
headers of sub-parts which might cause a problem if the admin
notification contains something that matches, BUT there is a safety
valve in that the SpamDetect process is never supposed to be applied
to internally generated messages such as admin notifications.
 
 
 Ok, that does appear to be what is happening ... but the safety valve
 doesn't seem to be kicking in.
 
 
So something is going wrong here, but I don't know what. I will
investigate, but if you could send me off list what your
header_filter_rules are and a copy of the original problem message, it
may help me.
 
 
 I'll send that under separate cover :)
 
 david

-- 
Tokio Kikuchi, tkikuchi@ is.kochi-u.ac.jp
http://weather.is.kochi-u.ac.jp/
--
Mailman-Users mailing list
Mailman-Users@python.org
http://mail.python.org/mailman/listinfo/mailman-users
Mailman FAQ: http://www.python.org/cgi-bin/faqw-mm.py
Searchable Archives: http://www.mail-archive.com/mailman-users%40python.org/
Unsubscribe: 
http://mail.python.org/mailman/options/mailman-users/archive%40jab.org

Security Policy: 
http://www.python.org/cgi-bin/faqw-mm.py?req=showamp;file=faq01.027.htp


Re: [Mailman-Users] SpamDetect loop?

2006-01-11 Thread David Gibbs
Tokio Kikuchi wrote:
 I've coded that bug in the last minute of releasing. :-(

Doh!

 I think I can generate a patch, but in the meantime, please copy the
 SpamDetect.py file from 2.1.6 distribution and restart.

I've temporarily removed the SpamDetect module from the owner pipeline
and it seems to be working ok for now.

david

--
Mailman-Users mailing list
Mailman-Users@python.org
http://mail.python.org/mailman/listinfo/mailman-users
Mailman FAQ: http://www.python.org/cgi-bin/faqw-mm.py
Searchable Archives: http://www.mail-archive.com/mailman-users%40python.org/
Unsubscribe: 
http://mail.python.org/mailman/options/mailman-users/archive%40jab.org

Security Policy: 
http://www.python.org/cgi-bin/faqw-mm.py?req=showamp;file=faq01.027.htp


Re: [Mailman-Users] SpamDetect loop?

2006-01-11 Thread Tokio Kikuchi

David Gibbs wrote:




I think I can generate a patch, but in the meantime, please copy the
SpamDetect.py file from 2.1.6 distribution and restart.



I've temporarily removed the SpamDetect module from the owner pipeline
and it seems to be working ok for now.



David,

Can you test this patch?

Removing SpamDetect from the owner pipeline means spams pass through to 
the list owner.  This should be inconvenient.



--
Tokio Kikuchi, tkikuchi@ is.kochi-u.ac.jp
http://weather.is.kochi-u.ac.jp/
Index: SpamDetect.py
===
RCS file: /cvsroot/mailman/mailman/Mailman/Handlers/SpamDetect.py,v
retrieving revision 2.3.2.10
diff -u -r2.3.2.10 SpamDetect.py
--- SpamDetect.py   31 Dec 2005 06:15:33 -  2.3.2.10
+++ SpamDetect.py   12 Jan 2006 00:05:56 -
@@ -92,8 +92,12 @@
 
 
 def process(mlist, msg, msgdata):
-if msgdata.get('approved') or msgdata.get('reduced_list_headers'):
-# TK: 'reduced_list_headers' is intenally crafted message (virgin).
+# Do not spam check if the messages is approved or if the message
+# was internally crafted and sent to the -owner address like
+# message hold notification.  This avoids loop of hold notifications
+# since this module checks deep into the attachment headers.
+if msgdata.get('approved') or\
+   msgdata.get('toowner') and msg.get('x-list-administrivia') == 'yes':
 return
 # First do site hard coded header spam checks
 for header, regex in mm_cfg.KNOWN_SPAMMERS:
--
Mailman-Users mailing list
Mailman-Users@python.org
http://mail.python.org/mailman/listinfo/mailman-users
Mailman FAQ: http://www.python.org/cgi-bin/faqw-mm.py
Searchable Archives: http://www.mail-archive.com/mailman-users%40python.org/
Unsubscribe: 
http://mail.python.org/mailman/options/mailman-users/archive%40jab.org

Security Policy: 
http://www.python.org/cgi-bin/faqw-mm.py?req=showamp;file=faq01.027.htp

Re: [Mailman-Users] SpamDetect loop?

2006-01-11 Thread David Gibbs
 Can you test this patch?

Ok.

 Removing SpamDetect from the owner pipeline means spams pass through to
 the list owner.  This should be inconvenient.

Eh ... I'm not 100% sure that particular module is all that effective.
I've been using one of the SpamAssassin integrations (from the patches
repository on sf) to great effect.

I'll let you know how the patch works ... I've applied it and re-enabled
the SpamDetect module in the owners pipeline.

david

--
Mailman-Users mailing list
Mailman-Users@python.org
http://mail.python.org/mailman/listinfo/mailman-users
Mailman FAQ: http://www.python.org/cgi-bin/faqw-mm.py
Searchable Archives: http://www.mail-archive.com/mailman-users%40python.org/
Unsubscribe: 
http://mail.python.org/mailman/options/mailman-users/archive%40jab.org

Security Policy: 
http://www.python.org/cgi-bin/faqw-mm.py?req=showamp;file=faq01.027.htp