[Gluster-Maintainers] Build failed in Jenkins: regression-test-with-multiplex #324

2017-09-07 Thread jenkins 
See 


Changes:

[Jeff Darcy] Fix clang/gcc warning -Wformat-extra-args

[Jeff Darcy] Do not declare the variable timeout_ms if TCP_USER_TIMEOUT is not

[Jeff Darcy] Fix the conditional

--
[...truncated 757.36 KB...]
./tests/bugs/glusterd/bug-949930.t  -  12 second
./tests/bugs/glusterd/bug-889630.t  -  12 second
./tests/bugs/fuse/bug-985074.t  -  12 second
./tests/bugs/distribute/bug-961615.t  -  12 second
./tests/bugs/distribute/bug-1247563.t  -  12 second
./tests/bugs/distribute/bug-1088231.t  -  12 second
./tests/bugs/distribute/bug-1086228.t  -  12 second
./tests/bugs/bitrot/1207029-bitrot-daemon-should-start-on-valid-node.t  -  12 
second
./tests/basic/stats-dump.t  -  12 second
./tests/basic/fop-sampling.t  -  12 second
./tests/basic/ec/ec-root-heal.t  -  12 second
./tests/performance/open-behind.t  -  11 second
./tests/features/ssl-authz.t  -  11 second
./tests/bugs/upcall/bug-1458127.t  -  11 second
./tests/bugs/tier/bug-1205545-CTR-and-trash-integration.t  -  11 second
./tests/bugs/replicate/bug-1448804-check-quorum-type-values.t  -  11 second
./tests/bugs/replicate/bug-1132102.t  -  11 second
./tests/bugs/posix/bug-1360679.t  -  11 second
./tests/bugs/posix/bug-1122028.t  -  11 second
./tests/bugs/md-cache/bug-1211863.t  -  11 second
./tests/bugs/glusterfs/bug-902610.t  -  11 second
./tests/bugs/glusterd/bug-948729/bug-948729-mode-script.t  -  11 second
./tests/bugs/glusterd/bug-948729/bug-948729-force.t  -  11 second
./tests/bugs/glusterd/bug-1242875-do-not-pass-volinfo-quota.t  -  11 second
./tests/bugs/glusterd/bug-1121584-brick-existing-validation-for-remove-brick-status-stop.t
  -  11 second
./tests/bugs/glusterd/bug-1046308.t  -  11 second
./tests/bugs/gfapi/bug-1447266/1460514.t  -  11 second
./tests/bugs/ec/bug-1179050.t  -  11 second
./tests/bugs/distribute/bug-1122443.t  -  11 second
./tests/bugs/cli/bug-1087487.t  -  11 second
./tests/bugs/cli/bug-1022905.t  -  11 second
./tests/bugs/bitrot/1209818-vol-info-show-scrub-process-properly.t  -  11 second
./tests/basic/tier/ctr-rename-overwrite.t  -  11 second
./tests/basic/quota-nfs.t  -  11 second
./tests/basic/pump.t  -  11 second
./tests/basic/md-cache/bug-1317785.t  -  11 second
./tests/basic/gfapi/upcall-cache-invalidate.t  -  11 second
./tests/basic/gfapi/glfs_xreaddirplus_r.t  -  11 second
./tests/basic/gfapi/bug-1241104.t  -  11 second
./tests/basic/ec/ec-read-policy.t  -  11 second
./tests/gfid2path/block-mount-access.t  -  10 second
./tests/bugs/upcall/bug-1227204.t  -  10 second
./tests/bugs/transport/bug-873367.t  -  10 second
./tests/bugs/snapshot/bug-1260848.t  -  10 second
./tests/bugs/replicate/bug-1250170-fsync.t  -  10 second
./tests/bugs/quota/bug-1287996.t  -  10 second
./tests/bugs/quota/bug-1243798.t  -  10 second
./tests/bugs/io-cache/bug-read-hang.t  -  10 second
./tests/bugs/glusterd/bug-948729/bug-948729.t  -  10 second
./tests/bugs/glusterd/bug-1266818-shared-storage-disable.t  -  10 second
./tests/bugs/glusterd/bug-1091935-brick-order-check-from-cli-to-glusterd.t  -  
10 second
./tests/bugs/ec/bug-1227869.t  -  10 second
./tests/bugs/changelog/bug-1208470.t  -  10 second
./tests/bugs/bug-1258069.t  -  10 second
./tests/bugs/bitrot/bug-1229134-bitd-not-support-vol-set.t  -  10 second
./tests/bitrot/br-stub.t  -  10 second
./tests/basic/gfapi/gfapi-dup.t  -  10 second
./tests/basic/gfapi/anonymous_fd.t  -  10 second
./tests/basic/ec/ec-anonymous-fd.t  -  10 second
./tests/gfid2path/get-gfid-to-path.t  -  9 second
./tests/features/readdir-ahead.t  -  9 second
./tests/bugs/upcall/bug-1369430.t  -  9 second
./tests/bugs/snapshot/bug-1178079.t  -  9 second
./tests/bugs/snapshot/bug-1064768.t  -  9 second
./tests/bugs/shard/bug-1260637.t  -  9 second
./tests/bugs/shard/bug-1258334.t  -  9 second
./tests/bugs/replicate/bug-966018.t  -  9 second
./tests/bugs/replicate/bug-767585-gfid.t  -  9 second
./tests/bugs/replicate/bug-1365455.t  -  9 second
./tests/bugs/replicate/bug-1101647.t  -  9 second
./tests/bugs/quota/bug-1104692.t  -  9 second
./tests/bugs/posix/bug-990028.t  -  9 second
./tests/bugs/posix/bug-1175711.t  -  9 second
./tests/bugs/nfs/bug-915280.t  -  9 second
./tests/bugs/glusterfs-server/bug-873549.t  -  9 second
./tests/bugs/glusterd/bug-888752.t  -  9 second
./tests/bugs/glusterd/bug-1454418-seg-fault.t  -  9 second
./tests/bugs/glusterd/bug-1344407-volume-delete-on-node-down.t  -  9 second
./tests/bugs/glusterd/bug-1179175-uss-option-validation.t  -  9 second
./tests/bugs/glusterd/bug-1102656.t  -  9 second
./tests/bugs/glusterd/bug-1022055.t  -  9 second
./tests/bugs/distribute/bug-1368012.t  -  9 second
./tests/bugs/core/bug-986429.t  -  9 second
./tests/bugs/core/bug-834465.t  -  9 second
./tests/bugs/core/bug-1119582.t  -  9 second
./tests/bugs/bitrot/bug-1210684-scrub-pause-resume-error-handling.t  -  9 second
./tests/bitrot/bug-1221914.t  -  9 second

[Gluster-Maintainers] Build failed in Jenkins: regression-test-with-multiplex #323

2017-09-07 Thread jenkins 
See 


Changes:

[Niels de Vos] Fix warning on FreeBSD, show by -Wformat-extra-args

[Amar Tumballi] mount/fuse: Include sub-directory in source argument for mount()

[Amar Tumballi] libglusterfs: fix run.c demo mode

[Amar Tumballi] Use the new URL for the docs

--
[...truncated 761.63 KB...]
./tests/basic/quota_aux_mount.t  -  13 second
./tests/basic/inode-quota-enforcing.t  -  13 second
./tests/basic/ec/ec-root-heal.t  -  13 second
./tests/performance/open-behind.t  -  12 second
./tests/bugs/replicate/bug-1325792.t  -  12 second
./tests/bugs/posix/bug-1360679.t  -  12 second
./tests/bugs/glusterd/bug-949930.t  -  12 second
./tests/bugs/glusterd/bug-948729/bug-948729-force.t  -  12 second
./tests/bugs/glusterd/bug-889630.t  -  12 second
./tests/bugs/gfapi/bug-1447266/1460514.t  -  12 second
./tests/bugs/fuse/bug-985074.t  -  12 second
./tests/bugs/distribute/bug-1247563.t  -  12 second
./tests/bugs/distribute/bug-1088231.t  -  12 second
./tests/bugs/distribute/bug-1086228.t  -  12 second
./tests/basic/tier/ctr-rename-overwrite.t  -  12 second
./tests/basic/quota-nfs.t  -  12 second
./tests/basic/pump.t  -  12 second
./tests/basic/md-cache/bug-1317785.t  -  12 second
./tests/basic/gfapi/bug-1241104.t  -  12 second
./tests/basic/fop-sampling.t  -  12 second
./tests/basic/ec/ec-read-policy.t  -  12 second
./tests/features/ssl-authz.t  -  11 second
./tests/features/readdir-ahead.t  -  11 second
./tests/bugs/upcall/bug-1458127.t  -  11 second
./tests/bugs/upcall/bug-1227204.t  -  11 second
./tests/bugs/transport/bug-873367.t  -  11 second
./tests/bugs/snapshot/bug-1260848.t  -  11 second
./tests/bugs/replicate/bug-1448804-check-quorum-type-values.t  -  11 second
./tests/bugs/replicate/bug-1250170-fsync.t  -  11 second
./tests/bugs/replicate/bug-1132102.t  -  11 second
./tests/bugs/quota/bug-1287996.t  -  11 second
./tests/bugs/posix/bug-1122028.t  -  11 second
./tests/bugs/md-cache/bug-1211863.t  -  11 second
./tests/bugs/glusterfs/bug-872923.t  -  11 second
./tests/bugs/glusterd/bug-948729/bug-948729.t  -  11 second
./tests/bugs/glusterd/bug-1121584-brick-existing-validation-for-remove-brick-status-stop.t
  -  11 second
./tests/bugs/glusterd/bug-1091935-brick-order-check-from-cli-to-glusterd.t  -  
11 second
./tests/bugs/glusterd/bug-1046308.t  -  11 second
./tests/bugs/ec/bug-1179050.t  -  11 second
./tests/bugs/distribute/bug-1122443.t  -  11 second
./tests/bugs/cli/bug-1087487.t  -  11 second
./tests/bugs/changelog/bug-1208470.t  -  11 second
./tests/bugs/bitrot/1209818-vol-info-show-scrub-process-properly.t  -  11 second
./tests/basic/gfapi/upcall-cache-invalidate.t  -  11 second
./tests/basic/gfapi/libgfapi-fini-hang.t  -  11 second
./tests/basic/gfapi/gfapi-dup.t  -  11 second
./tests/basic/ec/ec-anonymous-fd.t  -  11 second
./tests/gfid2path/get-gfid-to-path.t  -  10 second
./tests/gfid2path/block-mount-access.t  -  10 second
./tests/bugs/tier/bug-1205545-CTR-and-trash-integration.t  -  10 second
./tests/bugs/shard/bug-1260637.t  -  10 second
./tests/bugs/shard/bug-1258334.t  -  10 second
./tests/bugs/replicate/bug-966018.t  -  10 second
./tests/bugs/quota/bug-1243798.t  -  10 second
./tests/bugs/posix/bug-990028.t  -  10 second
./tests/bugs/posix/bug-1175711.t  -  10 second
./tests/bugs/nfs/bug-1157223-symlink-mounting.t  -  10 second
./tests/bugs/nfs/bug-1143880-fix-gNFSd-auth-crash.t  -  10 second
./tests/bugs/glusterfs/bug-902610.t  -  10 second
./tests/bugs/glusterd/bug-948729/bug-948729-mode-script.t  -  10 second
./tests/bugs/glusterd/bug-888752.t  -  10 second
./tests/bugs/glusterd/bug-1266818-shared-storage-disable.t  -  10 second
./tests/bugs/glusterd/bug-1179175-uss-option-validation.t  -  10 second
./tests/bugs/glusterd/bug-1102656.t  -  10 second
./tests/bugs/glusterd/bug-1022055.t  -  10 second
./tests/bugs/ec/bug-1227869.t  -  10 second
./tests/bitrot/br-stub.t  -  10 second
./tests/basic/gfapi/glfs_xreaddirplus_r.t  -  10 second
./tests/basic/gfapi/anonymous_fd.t  -  10 second
./tests/basic/distribute/bug-1265677-use-readdirp.t  -  10 second
./tests/basic/afr/arbiter-remove-brick.t  -  10 second
./tests/features/delay-gen.t  -  9 second
./tests/bugs/upcall/bug-1369430.t  -  9 second
./tests/bugs/snapshot/bug-1064768.t  -  9 second
./tests/bugs/shard/bug-1342298.t  -  9 second
./tests/bugs/shard/bug-1245547.t  -  9 second
./tests/bugs/replicate/bug-767585-gfid.t  -  9 second
./tests/bugs/replicate/bug-1365455.t  -  9 second
./tests/bugs/replicate/bug-1101647.t  -  9 second
./tests/bugs/quota/bug-1104692.t  -  9 second
./tests/bugs/nfs/bug-915280.t  -  9 second
./tests/bugs/nfs/bug-1116503.t  -  9 second
./tests/bugs/md-cache/bug-1211863_unlink.t  -  9 second
./tests/bugs/md-cache/afr-stale-read.t  -  9 second
./tests/bugs/io-cache/bug-read-hang.t  -  9 second
./tests/bugs/io-cache/bug-858242.t  -  9 second
./tests/bugs/glusterfs-server/bug-873549.t  -

Re: [Gluster-Maintainers] Changing Submit Type on review.gluster.org

2017-09-07 Thread Niels de Vos 
On Thu, Sep 07, 2017 at 04:11:22PM +0530, Milind Changire wrote:
> *Squashed Patches*
> I believe, individual engineers have to own the responsibility of
> maintaining history of all appropriate Change-Ids as part of the commit
> message when multiple patches have been squashed/merged into one commit.

We do not recommend squashing multiple patches into one at any case. It
is much easier to follow the modifications when each functional change
has its own patch. This counts for the master branch, but also for
backports.

Niels


> 
> 
> 
> 
> On Thu, Sep 7, 2017 at 11:50 AM, Nigel Babu  wrote:
> 
> > Hello folks,
> >
> > A few times, we've merged dependent patches out of order because the Submit
> > type[1] did not block us from doing so. The last few times we've talked
> > about
> > this, we didn't actually take a strong decision either way. In yesterday's
> > maintainers meeting, we agreed to change the Submit type to
> > Rebase-If-Necessary. This change will happen on 18th September 2017.
> >
> > What this means:
> > * No more metadata flags added by Gerrit. There will only be a Change-Id,
> >   Signed-off-by, and BUG (if you've added it). Gerrit itself will not add
> > any
> >   metadata.
> > * If you push a patch on top of another patch, the Submit button will
> > either be
> >   grayed out because the dependent patches cannot be merged or they will be
> >   submited in the correct order in one go.
> >
> > Some of the concerns that have been raised:
> > Q: With the Reviewed-on flag gone, how do we keep track of changesets
> >(especially backports)?
> > A: The Change-Id will get you all the data directly on Gerrit. As long you
> >retain the Change-Id, Gerrit will get you the matching changesets.
> >
> > Q: Will who-wrote-what continue to work?
> > A: As far as I can see, it continues to work. I ran the script against
> >build-jobs repo and it works correctly. Additionally, we'll be setting
> > up an
> >instance of Gerrit Stats[2] to provide more detailed stats.
> >
> > Q: Can we have some of the metadata if not all?
> > Q: Why can't we have the metadata if we change the submit type?
> > A: There's no good answer to this other than, this is how Gerrit works and
> >I can neither change it nor control it.
> >
> > [1]: https://review.gluster.org/Documentation/intro-project-
> > owner.html#submit-type
> > [2]: http://gerritstats-demo.firebaseapp.com/
> >
> > --
> > nigelb
> > ___
> > maintainers mailing list
> > maintainers@gluster.org
> > http://lists.gluster.org/mailman/listinfo/maintainers
> >
> 
> 
> 
> -- 
> Milind

> ___
> maintainers mailing list
> maintainers@gluster.org
> http://lists.gluster.org/mailman/listinfo/maintainers

___
maintainers mailing list
maintainers@gluster.org
http://lists.gluster.org/mailman/listinfo/maintainers

Re: [Gluster-Maintainers] [Gluster-devel] Changing Submit Type on review.gluster.org

2017-09-07 Thread Kaushal M 
On 7 Sep 2017 6:25 pm, "Niels de Vos"  wrote:

On Thu, Sep 07, 2017 at 04:41:54PM +0530, Nigel Babu wrote:
> On Thu, Sep 07, 2017 at 12:43:28PM +0200, Niels de Vos wrote:
> >
> > Q: Can patches of a series be merged before all patches in the series
> > have a +2? Initial changes that prepare things, or add new (unused) core
> > functionalities should be mergable so that follow-up patches can be
> > posted against the HEAD of the branch.
> >
> > A: Nigel?
> >
>
> If you have patches that are dependent like this:
>
> A -> B -> C -> D
>
> where A is the first patch and B is based on top of A and so forth.
>
> Merging A is not dependent on B. It can be merged any time you have Code
Review
> and Regression votes.
>
> However, you cannot merge B until A is ready or merged. If A is unmerged,
but
> is ready to merge, when you merge B, Gerrit will merge them in order, i.e.
> first merge A, and B automatically.
>
> Does this answer your question? If it helps, I can arrange for staging to
be
> online so moe people can test this out.

That answers my question, I don't need to try it out myself.

Thanks!
Niels
___
maintainers mailing list
maintainers@gluster.org
http://lists.gluster.org/mailman/listinfo/maintainers



Gerrit still provides all the meta information about patches in a special
branch as git-notes. Git can be configured to display these notes along
with commit messages. You would still effectively get the same experience
as before.

More information is available at [1]. This depends on a gerrit plugin, but
I believe it's enabled by default.

[1]
https://gerrit.googlesource.com/plugins/reviewnotes/+/master/src/main/resources/Documentation/refs-notes-review.md
___
maintainers mailing list
maintainers@gluster.org
http://lists.gluster.org/mailman/listinfo/maintainers

Re: [Gluster-Maintainers] [Gluster-devel] Changing Submit Type on review.gluster.org

2017-09-07 Thread Niels de Vos 
On Thu, Sep 07, 2017 at 04:41:54PM +0530, Nigel Babu wrote:
> On Thu, Sep 07, 2017 at 12:43:28PM +0200, Niels de Vos wrote:
> >
> > Q: Can patches of a series be merged before all patches in the series
> > have a +2? Initial changes that prepare things, or add new (unused) core
> > functionalities should be mergable so that follow-up patches can be
> > posted against the HEAD of the branch.
> >
> > A: Nigel?
> >
> 
> If you have patches that are dependent like this:
> 
> A -> B -> C -> D
> 
> where A is the first patch and B is based on top of A and so forth.
> 
> Merging A is not dependent on B. It can be merged any time you have Code 
> Review
> and Regression votes.
> 
> However, you cannot merge B until A is ready or merged. If A is unmerged, but
> is ready to merge, when you merge B, Gerrit will merge them in order, i.e.
> first merge A, and B automatically.
> 
> Does this answer your question? If it helps, I can arrange for staging to be
> online so moe people can test this out.

That answers my question, I don't need to try it out myself.

Thanks!
Niels
___
maintainers mailing list
maintainers@gluster.org
http://lists.gluster.org/mailman/listinfo/maintainers

Re: [Gluster-Maintainers] Changing Submit Type on review.gluster.org

2017-09-07 Thread Shyam Ranganathan 

On 09/07/2017 02:20 AM, Nigel Babu wrote:

Hello folks,

A few times, we've merged dependent patches out of order because the Submit
type[1] did not block us from doing so. The last few times we've talked about
this, we didn't actually take a strong decision either way. In yesterday's
maintainers meeting, we agreed to change the Submit type to
Rebase-If-Necessary. This change will happen on 18th September 2017.


Unrelated: We possibly need to document on how to work with dependent 
patches, i.e how to create them? manage intermediate changes, etc.


I state this as it is a useful manner of keeping commits small and 
relevant and easy to review, and building on that practice with better 
instructions can help.


On topic: this would be a welcome change than breaking master when such 
events happen, or chasing dependencies (determining which patch is 
dependent on which) when merging the same.




What this means:
* No more metadata flags added by Gerrit. There will only be a Change-Id,
   Signed-off-by, and BUG (if you've added it). Gerrit itself will not add any
   metadata.
* If you push a patch on top of another patch, the Submit button will either be
   grayed out because the dependent patches cannot be merged or they will be
   submited in the correct order in one go.

Some of the concerns that have been raised:
Q: With the Reviewed-on flag gone, how do we keep track of changesets
(especially backports)?
A: The Change-Id will get you all the data directly on Gerrit. As long you
retain the Change-Id, Gerrit will get you the matching changesets.

Q: Will who-wrote-what continue to work?
A: As far as I can see, it continues to work. I ran the script against
build-jobs repo and it works correctly. Additionally, we'll be setting up an
instance of Gerrit Stats[2] to provide more detailed stats.

Q: Can we have some of the metadata if not all?
Q: Why can't we have the metadata if we change the submit type?
A: There's no good answer to this other than, this is how Gerrit works and
I can neither change it nor control it.

[1]: 
https://review.gluster.org/Documentation/intro-project-owner.html#submit-type
[2]: http://gerritstats-demo.firebaseapp.com/

--
nigelb
___
maintainers mailing list
maintainers@gluster.org
http://lists.gluster.org/mailman/listinfo/maintainers


___
maintainers mailing list
maintainers@gluster.org
http://lists.gluster.org/mailman/listinfo/maintainers

Re: [Gluster-Maintainers] [Gluster-devel] Changing Submit Type on review.gluster.org

2017-09-07 Thread Nigel Babu 
On Thu, Sep 07, 2017 at 12:43:28PM +0200, Niels de Vos wrote:
>
> Q: Can patches of a series be merged before all patches in the series
> have a +2? Initial changes that prepare things, or add new (unused) core
> functionalities should be mergable so that follow-up patches can be
> posted against the HEAD of the branch.
>
> A: Nigel?
>

If you have patches that are dependent like this:

A -> B -> C -> D

where A is the first patch and B is based on top of A and so forth.

Merging A is not dependent on B. It can be merged any time you have Code Review
and Regression votes.

However, you cannot merge B until A is ready or merged. If A is unmerged, but
is ready to merge, when you merge B, Gerrit will merge them in order, i.e.
first merge A, and B automatically.

Does this answer your question? If it helps, I can arrange for staging to be
online so moe people can test this out.

--
nigelb
___
maintainers mailing list
maintainers@gluster.org
http://lists.gluster.org/mailman/listinfo/maintainers

Re: [Gluster-Maintainers] Changing Submit Type on review.gluster.org

2017-09-07 Thread Nigel Babu 
On Thu, Sep 07, 2017 at 04:11:22PM +0530, Milind Changire wrote:
> *Squashed Patches*
> I believe, individual engineers have to own the responsibility of
> maintaining history of all appropriate Change-Ids as part of the commit
> message when multiple patches have been squashed/merged into one commit.

This is accurate. We'll need to continue to maintain this as we currently do
for backports.

--
nigelb
___
maintainers mailing list
maintainers@gluster.org
http://lists.gluster.org/mailman/listinfo/maintainers

Re: [Gluster-Maintainers] [Gluster-devel] Changing Submit Type on review.gluster.org

2017-09-07 Thread Niels de Vos 
On Thu, Sep 07, 2017 at 12:06:19PM +0530, Amar Tumballi wrote:
> On Thu, Sep 7, 2017 at 11:50 AM, Nigel Babu  wrote:
> 
> > Hello folks,
> >
> > A few times, we've merged dependent patches out of order because the Submit
> > type[1] did not block us from doing so. The last few times we've talked
> > about
> > this, we didn't actually take a strong decision either way. In yesterday's
> > maintainers meeting, we agreed to change the Submit type to
> > Rebase-If-Necessary. This change will happen on 18th September 2017.
> >
> > What this means:
> > * No more metadata flags added by Gerrit. There will only be a Change-Id,
> >   Signed-off-by, and BUG (if you've added it). Gerrit itself will not add
> > any
> >   metadata.
> > * If you push a patch on top of another patch, the Submit button will
> > either be
> >   grayed out because the dependent patches cannot be merged or they will be
> >   submited in the correct order in one go.
> >
> > Some of the concerns that have been raised:
> > Q: With the Reviewed-on flag gone, how do we keep track of changesets
> >(especially backports)?
> > A: The Change-Id will get you all the data directly on Gerrit. As long you
> >retain the Change-Id, Gerrit will get you the matching changesets.
> >
> > Q: Will who-wrote-what continue to work?
> > A: As far as I can see, it continues to work. I ran the script against
> >build-jobs repo and it works correctly. Additionally, we'll be setting
> > up an
> >instance of Gerrit Stats[2] to provide more detailed stats.
> >
> > Q: Can we have some of the metadata if not all?
> > Q: Why can't we have the metadata if we change the submit type?
> > A: There's no good answer to this other than, this is how Gerrit works and
> >I can neither change it nor control it.
> >
> >
> One of the major other concerns, which is valid is, stats on 'Reviewed-By'.
> Ie, people who actually reviewed the code. This metrics is equally
> important as 'who-wrote-the-patch', again, getting an infra like [2] below
> will solve it.

The /extras/who-wrote-glusterfs/who-wrote-glusterfs.sh script
will continue to work, but some of the statistics will not be available.
It is nice to have a Reviewed-by tag in the git commit message, but the
one that Gerrit adds is not complete in any case. Reviewers that did not
review the last version of the patch before it got merged do not get
added in the Gerrit-automated-commit-message-ammending. The statistics
of the who-wrote-glusterfs.sh script are cool, and people appreciate
their names in the git logs, but the script should not be used for
serious statistic gathering.

The gerritstats webapp seems much more appropriate for this.

Cheers,
Niels


> 
> Regards,
> Amar
> 
> 
> > [1]: https://review.gluster.org/Documentation/intro-project-
> > owner.html#submit-type
> > [2]: http://gerritstats-demo.firebaseapp.com/
> >
> > --
> > nigelb
> > ___
> > maintainers mailing list
> > maintainers@gluster.org
> > http://lists.gluster.org/mailman/listinfo/maintainers
> >
> 
> 
> 
> -- 
> Amar Tumballi (amarts)

> ___
> Gluster-devel mailing list
> gluster-de...@gluster.org
> http://lists.gluster.org/mailman/listinfo/gluster-devel

___
maintainers mailing list
maintainers@gluster.org
http://lists.gluster.org/mailman/listinfo/maintainers

Re: [Gluster-Maintainers] [Gluster-devel] Changing Submit Type on review.gluster.org

2017-09-07 Thread Niels de Vos 
On Thu, Sep 07, 2017 at 11:50:21AM +0530, Nigel Babu wrote:
> Hello folks,
> 
> A few times, we've merged dependent patches out of order because the Submit
> type[1] did not block us from doing so. The last few times we've talked about
> this, we didn't actually take a strong decision either way. In yesterday's
> maintainers meeting, we agreed to change the Submit type to
> Rebase-If-Necessary. This change will happen on 18th September 2017.
> 
> What this means:
> * No more metadata flags added by Gerrit. There will only be a Change-Id,
>   Signed-off-by, and BUG (if you've added it). Gerrit itself will not add any
>   metadata.
> * If you push a patch on top of another patch, the Submit button will either 
> be
>   grayed out because the dependent patches cannot be merged or they will be
>   submited in the correct order in one go.
> 
> Some of the concerns that have been raised:
> Q: With the Reviewed-on flag gone, how do we keep track of changesets
>(especially backports)?
> A: The Change-Id will get you all the data directly on Gerrit. As long you
>retain the Change-Id, Gerrit will get you the matching changesets.
> 
> Q: Will who-wrote-what continue to work?
> A: As far as I can see, it continues to work. I ran the script against
>build-jobs repo and it works correctly. Additionally, we'll be setting up 
> an
>instance of Gerrit Stats[2] to provide more detailed stats.
> 
> Q: Can we have some of the metadata if not all?
> Q: Why can't we have the metadata if we change the submit type?
> A: There's no good answer to this other than, this is how Gerrit works and
>I can neither change it nor control it.

Q: Can patches of a series be merged before all patches in the series
have a +2? Initial changes that prepare things, or add new (unused) core
functionalities should be mergable so that follow-up patches can be
posted against the HEAD of the branch.

A: Nigel?

Thanks,
Niels


> 
> [1]: 
> https://review.gluster.org/Documentation/intro-project-owner.html#submit-type
> [2]: http://gerritstats-demo.firebaseapp.com/
> 
> --
> nigelb
> ___
> Gluster-devel mailing list
> gluster-de...@gluster.org
> http://lists.gluster.org/mailman/listinfo/gluster-devel
___
maintainers mailing list
maintainers@gluster.org
http://lists.gluster.org/mailman/listinfo/maintainers

Re: [Gluster-Maintainers] Changing Submit Type on review.gluster.org

2017-09-07 Thread Milind Changire 
*Squashed Patches*
I believe, individual engineers have to own the responsibility of
maintaining history of all appropriate Change-Ids as part of the commit
message when multiple patches have been squashed/merged into one commit.




On Thu, Sep 7, 2017 at 11:50 AM, Nigel Babu  wrote:

> Hello folks,
>
> A few times, we've merged dependent patches out of order because the Submit
> type[1] did not block us from doing so. The last few times we've talked
> about
> this, we didn't actually take a strong decision either way. In yesterday's
> maintainers meeting, we agreed to change the Submit type to
> Rebase-If-Necessary. This change will happen on 18th September 2017.
>
> What this means:
> * No more metadata flags added by Gerrit. There will only be a Change-Id,
>   Signed-off-by, and BUG (if you've added it). Gerrit itself will not add
> any
>   metadata.
> * If you push a patch on top of another patch, the Submit button will
> either be
>   grayed out because the dependent patches cannot be merged or they will be
>   submited in the correct order in one go.
>
> Some of the concerns that have been raised:
> Q: With the Reviewed-on flag gone, how do we keep track of changesets
>(especially backports)?
> A: The Change-Id will get you all the data directly on Gerrit. As long you
>retain the Change-Id, Gerrit will get you the matching changesets.
>
> Q: Will who-wrote-what continue to work?
> A: As far as I can see, it continues to work. I ran the script against
>build-jobs repo and it works correctly. Additionally, we'll be setting
> up an
>instance of Gerrit Stats[2] to provide more detailed stats.
>
> Q: Can we have some of the metadata if not all?
> Q: Why can't we have the metadata if we change the submit type?
> A: There's no good answer to this other than, this is how Gerrit works and
>I can neither change it nor control it.
>
> [1]: https://review.gluster.org/Documentation/intro-project-
> owner.html#submit-type
> [2]: http://gerritstats-demo.firebaseapp.com/
>
> --
> nigelb
> ___
> maintainers mailing list
> maintainers@gluster.org
> http://lists.gluster.org/mailman/listinfo/maintainers
>



-- 
Milind
___
maintainers mailing list
maintainers@gluster.org
http://lists.gluster.org/mailman/listinfo/maintainers

Re: [Gluster-Maintainers] Changing Submit Type on review.gluster.org

2017-09-07 Thread Nigel Babu 
On Thu, Sep 07, 2017 at 12:17:32PM +0530, Atin Mukherjee wrote:
> One basic question (rather clarification) here. If indeed a rebase is
> necessary for a patch which was posted some time back and a regression was
> passed at that time, with this change will a (centos) regression job
> re-triggered and once we have a positive vote then only the patch will be
> in to the repo?

There's two cases here:
* The patch does not have any merge conflicts. In this case, Gerrit will do the
  rebase when you hit the submit button. There's no question of running
  regressions. Note: If the patch doesn't have any merge conflicts, you can
  still do a rebase using Gerrit UI or git command line. This will cause the
  regression votes to be retained, but the smoke jobs will be retriggered.
* The patch has merge conflicts. In this case, you'll have to rebase on the git
  command line locally and push up a fix. In this case, regressions votes are
  not carried over and will be triggered.

--
nigelb
___
maintainers mailing list
maintainers@gluster.org
http://lists.gluster.org/mailman/listinfo/maintainers

[Gluster-Maintainers] Build failed in Jenkins: regression-test-with-multiplex #322

2017-09-07 Thread jenkins 
See 


Changes:

[Raghavendra G] dht: add FOP check to dht_file_setattr_cbk

--
[...truncated 755.65 KB...]
./tests/bugs/glusterd/bug-949930.t  -  12 second
./tests/bugs/glusterd/bug-1242875-do-not-pass-volinfo-quota.t  -  12 second
./tests/bugs/glusterd/bug-1121584-brick-existing-validation-for-remove-brick-status-stop.t
  -  12 second
./tests/bugs/glusterd/bug-1046308.t  -  12 second
./tests/bugs/fuse/bug-985074.t  -  12 second
./tests/bugs/distribute/bug-961615.t  -  12 second
./tests/bugs/distribute/bug-1088231.t  -  12 second
./tests/bugs/cli/bug-1030580.t  -  12 second
./tests/basic/pump.t  -  12 second
./tests/basic/gfapi/glfs_xreaddirplus_r.t  -  12 second
./tests/basic/fop-sampling.t  -  12 second
./tests/basic/ec/ec-root-heal.t  -  12 second
./tests/performance/open-behind.t  -  11 second
./tests/bugs/upcall/bug-1227204.t  -  11 second
./tests/bugs/replicate/bug-1448804-check-quorum-type-values.t  -  11 second
./tests/bugs/replicate/bug-1325792.t  -  11 second
./tests/bugs/replicate/bug-1250170-fsync.t  -  11 second
./tests/bugs/replicate/bug-1132102.t  -  11 second
./tests/bugs/quota/bug-1287996.t  -  11 second
./tests/bugs/glusterd/bug-948729/bug-948729-mode-script.t  -  11 second
./tests/bugs/glusterd/bug-948729/bug-948729-force.t  -  11 second
./tests/bugs/glusterd/bug-889630.t  -  11 second
./tests/bugs/gfapi/bug-1447266/1460514.t  -  11 second
./tests/bugs/ec/bug-1179050.t  -  11 second
./tests/bugs/distribute/bug-1247563.t  -  11 second
./tests/bugs/distribute/bug-1086228.t  -  11 second
./tests/bugs/cli/bug-1087487.t  -  11 second
./tests/bugs/cli/bug-1022905.t  -  11 second
./tests/bugs/changelog/bug-1208470.t  -  11 second
./tests/bugs/bitrot/1209818-vol-info-show-scrub-process-properly.t  -  11 second
./tests/bitrot/br-stub.t  -  11 second
./tests/basic/tier/ctr-rename-overwrite.t  -  11 second
./tests/basic/stats-dump.t  -  11 second
./tests/basic/quota-nfs.t  -  11 second
./tests/basic/gfapi/upcall-cache-invalidate.t  -  11 second
./tests/basic/gfapi/anonymous_fd.t  -  11 second
./tests/basic/ec/ec-read-policy.t  -  11 second
./tests/gfid2path/block-mount-access.t  -  10 second
./tests/features/ssl-authz.t  -  10 second
./tests/features/readdir-ahead.t  -  10 second
./tests/bugs/upcall/bug-1458127.t  -  10 second
./tests/bugs/transport/bug-873367.t  -  10 second
./tests/bugs/tier/bug-1205545-CTR-and-trash-integration.t  -  10 second
./tests/bugs/snapshot/bug-1260848.t  -  10 second
./tests/bugs/replicate/bug-1101647.t  -  10 second
./tests/bugs/quota/bug-1243798.t  -  10 second
./tests/bugs/posix/bug-1122028.t  -  10 second
./tests/bugs/md-cache/bug-1211863.t  -  10 second
./tests/bugs/glusterfs/bug-902610.t  -  10 second
./tests/bugs/glusterd/bug-948729/bug-948729.t  -  10 second
./tests/bugs/glusterd/bug-888752.t  -  10 second
./tests/bugs/glusterd/bug-1179175-uss-option-validation.t  -  10 second
./tests/bugs/glusterd/bug-1091935-brick-order-check-from-cli-to-glusterd.t  -  
10 second
./tests/bugs/glusterd/bug-1022055.t  -  10 second
./tests/bugs/ec/bug-1227869.t  -  10 second
./tests/bugs/distribute/bug-1122443.t  -  10 second
./tests/basic/md-cache/bug-1317785.t  -  10 second
./tests/basic/gfapi/gfapi-dup.t  -  10 second
./tests/basic/gfapi/bug-1241104.t  -  10 second
./tests/basic/ec/ec-anonymous-fd.t  -  10 second
./tests/basic/afr/gfid-heal.t  -  10 second
./tests/gfid2path/get-gfid-to-path.t  -  9 second
./tests/bugs/upcall/bug-upcall-stat.t  -  9 second
./tests/bugs/upcall/bug-1369430.t  -  9 second
./tests/bugs/snapshot/bug-1064768.t  -  9 second
./tests/bugs/shard/bug-1260637.t  -  9 second
./tests/bugs/shard/bug-1258334.t  -  9 second
./tests/bugs/replicate/bug-966018.t  -  9 second
./tests/bugs/replicate/bug-767585-gfid.t  -  9 second
./tests/bugs/replicate/bug-1365455.t  -  9 second
./tests/bugs/quota/bug-1104692.t  -  9 second
./tests/bugs/posix/bug-990028.t  -  9 second
./tests/bugs/posix/bug-1175711.t  -  9 second
./tests/bugs/nfs/bug-915280.t  -  9 second
./tests/bugs/nfs/bug-1143880-fix-gNFSd-auth-crash.t  -  9 second
./tests/bugs/md-cache/afr-stale-read.t  -  9 second
./tests/bugs/io-cache/bug-read-hang.t  -  9 second
./tests/bugs/io-cache/bug-858242.t  -  9 second
./tests/bugs/glusterd/bug-1344407-volume-delete-on-node-down.t  -  9 second
./tests/bugs/glusterd/bug-1266818-shared-storage-disable.t  -  9 second
./tests/bugs/distribute/bug-1368012.t  -  9 second
./tests/bugs/core/bug-986429.t  -  9 second
./tests/bugs/core/bug-834465.t  -  9 second
./tests/bugs/core/bug-1119582.t  -  9 second
./tests/bugs/bitrot/bug-1229134-bitd-not-support-vol-set.t  -  9 second
./tests/bugs/bitrot/bug-1210684-scrub-pause-resume-error-handling.t  -  9 second
./tests/bitrot/bug-1221914.t  -  9 second
./tests/basic/gfapi/libgfapi-fini-hang.t  -  9 second
./tests/basic/ec/ec-fallocate.t  -  9 second

Re: [Gluster-Maintainers] Changing Submit Type on review.gluster.org

2017-09-07 Thread Atin Mukherjee 
On Thu, Sep 7, 2017 at 11:50 AM, Nigel Babu  wrote:

> Hello folks,
>
> A few times, we've merged dependent patches out of order because the Submit
> type[1] did not block us from doing so. The last few times we've talked
> about
> this, we didn't actually take a strong decision either way. In yesterday's
> maintainers meeting, we agreed to change the Submit type to
> Rebase-If-Necessary. This change will happen on 18th September 2017.
>

One basic question (rather clarification) here. If indeed a rebase is
necessary for a patch which was posted some time back and a regression was
passed at that time, with this change will a (centos) regression job
re-triggered and once we have a positive vote then only the patch will be
in to the repo?


> What this means:
> * No more metadata flags added by Gerrit. There will only be a Change-Id,
>   Signed-off-by, and BUG (if you've added it). Gerrit itself will not add
> any
>   metadata.
> * If you push a patch on top of another patch, the Submit button will
> either be
>   grayed out because the dependent patches cannot be merged or they will be
>   submited in the correct order in one go.
>
> Some of the concerns that have been raised:
> Q: With the Reviewed-on flag gone, how do we keep track of changesets
>(especially backports)?
> A: The Change-Id will get you all the data directly on Gerrit. As long you
>retain the Change-Id, Gerrit will get you the matching changesets.
>
> Q: Will who-wrote-what continue to work?
> A: As far as I can see, it continues to work. I ran the script against
>build-jobs repo and it works correctly. Additionally, we'll be setting
> up an
>instance of Gerrit Stats[2] to provide more detailed stats.
>
> Q: Can we have some of the metadata if not all?
> Q: Why can't we have the metadata if we change the submit type?
> A: There's no good answer to this other than, this is how Gerrit works and
>I can neither change it nor control it.
>
> [1]: https://review.gluster.org/Documentation/intro-project-
> owner.html#submit-type
> [2]: http://gerritstats-demo.firebaseapp.com/
>
> --
> nigelb
> ___
> maintainers mailing list
> maintainers@gluster.org
> http://lists.gluster.org/mailman/listinfo/maintainers
>
___
maintainers mailing list
maintainers@gluster.org
http://lists.gluster.org/mailman/listinfo/maintainers

Re: [Gluster-Maintainers] Changing Submit Type on review.gluster.org

2017-09-07 Thread Amar Tumballi 
On Thu, Sep 7, 2017 at 11:50 AM, Nigel Babu  wrote:

> Hello folks,
>
> A few times, we've merged dependent patches out of order because the Submit
> type[1] did not block us from doing so. The last few times we've talked
> about
> this, we didn't actually take a strong decision either way. In yesterday's
> maintainers meeting, we agreed to change the Submit type to
> Rebase-If-Necessary. This change will happen on 18th September 2017.
>
> What this means:
> * No more metadata flags added by Gerrit. There will only be a Change-Id,
>   Signed-off-by, and BUG (if you've added it). Gerrit itself will not add
> any
>   metadata.
> * If you push a patch on top of another patch, the Submit button will
> either be
>   grayed out because the dependent patches cannot be merged or they will be
>   submited in the correct order in one go.
>
> Some of the concerns that have been raised:
> Q: With the Reviewed-on flag gone, how do we keep track of changesets
>(especially backports)?
> A: The Change-Id will get you all the data directly on Gerrit. As long you
>retain the Change-Id, Gerrit will get you the matching changesets.
>
> Q: Will who-wrote-what continue to work?
> A: As far as I can see, it continues to work. I ran the script against
>build-jobs repo and it works correctly. Additionally, we'll be setting
> up an
>instance of Gerrit Stats[2] to provide more detailed stats.
>
> Q: Can we have some of the metadata if not all?
> Q: Why can't we have the metadata if we change the submit type?
> A: There's no good answer to this other than, this is how Gerrit works and
>I can neither change it nor control it.
>
>
One of the major other concerns, which is valid is, stats on 'Reviewed-By'.
Ie, people who actually reviewed the code. This metrics is equally
important as 'who-wrote-the-patch', again, getting an infra like [2] below
will solve it.

Regards,
Amar


> [1]: https://review.gluster.org/Documentation/intro-project-
> owner.html#submit-type
> [2]: http://gerritstats-demo.firebaseapp.com/
>
> --
> nigelb
> ___
> maintainers mailing list
> maintainers@gluster.org
> http://lists.gluster.org/mailman/listinfo/maintainers
>



-- 
Amar Tumballi (amarts)
___
maintainers mailing list
maintainers@gluster.org
http://lists.gluster.org/mailman/listinfo/maintainers

[Gluster-Maintainers] Changing Submit Type on review.gluster.org

2017-09-07 Thread Nigel Babu 
Hello folks,

A few times, we've merged dependent patches out of order because the Submit
type[1] did not block us from doing so. The last few times we've talked about
this, we didn't actually take a strong decision either way. In yesterday's
maintainers meeting, we agreed to change the Submit type to
Rebase-If-Necessary. This change will happen on 18th September 2017.

What this means:
* No more metadata flags added by Gerrit. There will only be a Change-Id,
  Signed-off-by, and BUG (if you've added it). Gerrit itself will not add any
  metadata.
* If you push a patch on top of another patch, the Submit button will either be
  grayed out because the dependent patches cannot be merged or they will be
  submited in the correct order in one go.

Some of the concerns that have been raised:
Q: With the Reviewed-on flag gone, how do we keep track of changesets
   (especially backports)?
A: The Change-Id will get you all the data directly on Gerrit. As long you
   retain the Change-Id, Gerrit will get you the matching changesets.

Q: Will who-wrote-what continue to work?
A: As far as I can see, it continues to work. I ran the script against
   build-jobs repo and it works correctly. Additionally, we'll be setting up an
   instance of Gerrit Stats[2] to provide more detailed stats.

Q: Can we have some of the metadata if not all?
Q: Why can't we have the metadata if we change the submit type?
A: There's no good answer to this other than, this is how Gerrit works and
   I can neither change it nor control it.

[1]: 
https://review.gluster.org/Documentation/intro-project-owner.html#submit-type
[2]: http://gerritstats-demo.firebaseapp.com/

--
nigelb
___
maintainers mailing list
maintainers@gluster.org
http://lists.gluster.org/mailman/listinfo/maintainers