[jira] [Updated] (MAPREDUCE-5719) Potential null pointer access in AbstractYarnScheduler#getTransferredContainers()
[ https://issues.apache.org/jira/browse/MAPREDUCE-5719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated MAPREDUCE-5719: -- Attachment: mapreduce-5719-v1.txt With attached patch, TestRMContainerAllocator passes. Potential null pointer access in AbstractYarnScheduler#getTransferredContainers() - Key: MAPREDUCE-5719 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5719 Project: Hadoop Map/Reduce Issue Type: Bug Reporter: Ted Yu Attachments: mapreduce-5719-v1.txt From https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1666/console : {code} Tests run: 14, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 63.12 sec FAILURE! - in org.apache.hadoop.mapreduce.v2.app.TestRMContainerAllocator testCompletedTasksRecalculateSchedule(org.apache.hadoop.mapreduce.v2.app.TestRMContainerAllocator) Time elapsed: 2.083 sec ERROR! org.apache.hadoop.yarn.exceptions.YarnRuntimeException: java.lang.NullPointerException at org.apache.hadoop.yarn.server.resourcemanager.scheduler.AbstractYarnScheduler.getTransferredContainers(AbstractYarnScheduler.java:50) at org.apache.hadoop.yarn.server.resourcemanager.ApplicationMasterService.registerApplicationMaster(ApplicationMasterService.java:277) at org.apache.hadoop.mapreduce.v2.app.rm.RMCommunicator.register(RMCommunicator.java:154) at org.apache.hadoop.mapreduce.v2.app.TestRMContainerAllocator$MyContainerAllocator.register(TestRMContainerAllocator.java:1476) at org.apache.hadoop.mapreduce.v2.app.rm.RMCommunicator.serviceStart(RMCommunicator.java:112) at org.apache.hadoop.mapreduce.v2.app.rm.RMContainerAllocator.serviceStart(RMContainerAllocator.java:219) at org.apache.hadoop.service.AbstractService.start(AbstractService.java:193) at org.apache.hadoop.mapreduce.v2.app.TestRMContainerAllocator$MyContainerAllocator.init(TestRMContainerAllocator.java:1444) at org.apache.hadoop.mapreduce.v2.app.TestRMContainerAllocator$RecalculateContainerAllocator.init(TestRMContainerAllocator.java:1629) at org.apache.hadoop.mapreduce.v2.app.TestRMContainerAllocator.testCompletedTasksRecalculateSchedule(TestRMContainerAllocator.java:1665) {code} In above case getMasterContainer() returned null. AbstractYarnScheduler#getTransferredContainers() should check such condition. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (MAPREDUCE-5719) Potential null pointer access in AbstractYarnScheduler#getTransferredContainers()
[ https://issues.apache.org/jira/browse/MAPREDUCE-5719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated MAPREDUCE-5719: -- Status: Patch Available (was: Open) Potential null pointer access in AbstractYarnScheduler#getTransferredContainers() - Key: MAPREDUCE-5719 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5719 Project: Hadoop Map/Reduce Issue Type: Bug Reporter: Ted Yu Attachments: mapreduce-5719-v1.txt From https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1666/console : {code} Tests run: 14, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 63.12 sec FAILURE! - in org.apache.hadoop.mapreduce.v2.app.TestRMContainerAllocator testCompletedTasksRecalculateSchedule(org.apache.hadoop.mapreduce.v2.app.TestRMContainerAllocator) Time elapsed: 2.083 sec ERROR! org.apache.hadoop.yarn.exceptions.YarnRuntimeException: java.lang.NullPointerException at org.apache.hadoop.yarn.server.resourcemanager.scheduler.AbstractYarnScheduler.getTransferredContainers(AbstractYarnScheduler.java:50) at org.apache.hadoop.yarn.server.resourcemanager.ApplicationMasterService.registerApplicationMaster(ApplicationMasterService.java:277) at org.apache.hadoop.mapreduce.v2.app.rm.RMCommunicator.register(RMCommunicator.java:154) at org.apache.hadoop.mapreduce.v2.app.TestRMContainerAllocator$MyContainerAllocator.register(TestRMContainerAllocator.java:1476) at org.apache.hadoop.mapreduce.v2.app.rm.RMCommunicator.serviceStart(RMCommunicator.java:112) at org.apache.hadoop.mapreduce.v2.app.rm.RMContainerAllocator.serviceStart(RMContainerAllocator.java:219) at org.apache.hadoop.service.AbstractService.start(AbstractService.java:193) at org.apache.hadoop.mapreduce.v2.app.TestRMContainerAllocator$MyContainerAllocator.init(TestRMContainerAllocator.java:1444) at org.apache.hadoop.mapreduce.v2.app.TestRMContainerAllocator$RecalculateContainerAllocator.init(TestRMContainerAllocator.java:1629) at org.apache.hadoop.mapreduce.v2.app.TestRMContainerAllocator.testCompletedTasksRecalculateSchedule(TestRMContainerAllocator.java:1665) {code} In above case getMasterContainer() returned null. AbstractYarnScheduler#getTransferredContainers() should check such condition. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Created] (MAPREDUCE-5719) Potential null pointer access in AbstractYarnScheduler#getTransferredContainers()
Ted Yu created MAPREDUCE-5719: - Summary: Potential null pointer access in AbstractYarnScheduler#getTransferredContainers() Key: MAPREDUCE-5719 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5719 Project: Hadoop Map/Reduce Issue Type: Bug Reporter: Ted Yu From https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1666/console : {code} Tests run: 14, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 63.12 sec FAILURE! - in org.apache.hadoop.mapreduce.v2.app.TestRMContainerAllocator testCompletedTasksRecalculateSchedule(org.apache.hadoop.mapreduce.v2.app.TestRMContainerAllocator) Time elapsed: 2.083 sec ERROR! org.apache.hadoop.yarn.exceptions.YarnRuntimeException: java.lang.NullPointerException at org.apache.hadoop.yarn.server.resourcemanager.scheduler.AbstractYarnScheduler.getTransferredContainers(AbstractYarnScheduler.java:50) at org.apache.hadoop.yarn.server.resourcemanager.ApplicationMasterService.registerApplicationMaster(ApplicationMasterService.java:277) at org.apache.hadoop.mapreduce.v2.app.rm.RMCommunicator.register(RMCommunicator.java:154) at org.apache.hadoop.mapreduce.v2.app.TestRMContainerAllocator$MyContainerAllocator.register(TestRMContainerAllocator.java:1476) at org.apache.hadoop.mapreduce.v2.app.rm.RMCommunicator.serviceStart(RMCommunicator.java:112) at org.apache.hadoop.mapreduce.v2.app.rm.RMContainerAllocator.serviceStart(RMContainerAllocator.java:219) at org.apache.hadoop.service.AbstractService.start(AbstractService.java:193) at org.apache.hadoop.mapreduce.v2.app.TestRMContainerAllocator$MyContainerAllocator.init(TestRMContainerAllocator.java:1444) at org.apache.hadoop.mapreduce.v2.app.TestRMContainerAllocator$RecalculateContainerAllocator.init(TestRMContainerAllocator.java:1629) at org.apache.hadoop.mapreduce.v2.app.TestRMContainerAllocator.testCompletedTasksRecalculateSchedule(TestRMContainerAllocator.java:1665) {code} In above case getMasterContainer() returned null. AbstractYarnScheduler#getTransferredContainers() should check such condition. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (MAPREDUCE-5719) Potential null pointer access in AbstractYarnScheduler#getTransferredContainers()
[ https://issues.apache.org/jira/browse/MAPREDUCE-5719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13868809#comment-13868809 ] Hadoop QA commented on MAPREDUCE-5719: -- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12622502/mapreduce-5719-v1.txt against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager. {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4315//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4315//console This message is automatically generated. Potential null pointer access in AbstractYarnScheduler#getTransferredContainers() - Key: MAPREDUCE-5719 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5719 Project: Hadoop Map/Reduce Issue Type: Bug Reporter: Ted Yu Attachments: mapreduce-5719-v1.txt From https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1666/console : {code} Tests run: 14, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 63.12 sec FAILURE! - in org.apache.hadoop.mapreduce.v2.app.TestRMContainerAllocator testCompletedTasksRecalculateSchedule(org.apache.hadoop.mapreduce.v2.app.TestRMContainerAllocator) Time elapsed: 2.083 sec ERROR! org.apache.hadoop.yarn.exceptions.YarnRuntimeException: java.lang.NullPointerException at org.apache.hadoop.yarn.server.resourcemanager.scheduler.AbstractYarnScheduler.getTransferredContainers(AbstractYarnScheduler.java:50) at org.apache.hadoop.yarn.server.resourcemanager.ApplicationMasterService.registerApplicationMaster(ApplicationMasterService.java:277) at org.apache.hadoop.mapreduce.v2.app.rm.RMCommunicator.register(RMCommunicator.java:154) at org.apache.hadoop.mapreduce.v2.app.TestRMContainerAllocator$MyContainerAllocator.register(TestRMContainerAllocator.java:1476) at org.apache.hadoop.mapreduce.v2.app.rm.RMCommunicator.serviceStart(RMCommunicator.java:112) at org.apache.hadoop.mapreduce.v2.app.rm.RMContainerAllocator.serviceStart(RMContainerAllocator.java:219) at org.apache.hadoop.service.AbstractService.start(AbstractService.java:193) at org.apache.hadoop.mapreduce.v2.app.TestRMContainerAllocator$MyContainerAllocator.init(TestRMContainerAllocator.java:1444) at org.apache.hadoop.mapreduce.v2.app.TestRMContainerAllocator$RecalculateContainerAllocator.init(TestRMContainerAllocator.java:1629) at org.apache.hadoop.mapreduce.v2.app.TestRMContainerAllocator.testCompletedTasksRecalculateSchedule(TestRMContainerAllocator.java:1665) {code} In above case getMasterContainer() returned null. AbstractYarnScheduler#getTransferredContainers() should check such condition. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (MAPREDUCE-5717) Task pings are interpreted as task progress
[ https://issues.apache.org/jira/browse/MAPREDUCE-5717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13868942#comment-13868942 ] Chris Douglas commented on MAPREDUCE-5717: -- +1 Thanks for catching this, Jason Task pings are interpreted as task progress --- Key: MAPREDUCE-5717 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5717 Project: Hadoop Map/Reduce Issue Type: Bug Affects Versions: 3.0.0 Reporter: Jason Lowe Assignee: Jason Lowe Attachments: MAPREDUCE-5717.patch -- This message was sent by Atlassian JIRA (v6.1.5#6160)