[jira] [Commented] (MAPREDUCE-6654) Possible NPE in JobHistoryEventHandler#handleEvent
[
https://issues.apache.org/jira/browse/MAPREDUCE-6654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16186550#comment-16186550
]
Hadoop QA commented on MAPREDUCE-6654:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 5s{color}
| {color:red} MAPREDUCE-6654 does not apply to trunk. Rebase required? Wrong
Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | MAPREDUCE-6654 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12821326/MAPREDUCE-6654-v2.1.patch
|
| Console output |
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/7168/console |
| Powered by | Apache Yetus 0.5.0 http://yetus.apache.org |
This message was automatically generated.
> Possible NPE in JobHistoryEventHandler#handleEvent
> --
>
> Key: MAPREDUCE-6654
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-6654
> Project: Hadoop Map/Reduce
> Issue Type: Bug
>Reporter: Xiao Chen
>Assignee: Junping Du
>Priority: Critical
> Attachments: MAPREDUCE-6654.patch, MAPREDUCE-6654-v2.1.patch,
> MAPREDUCE-6654-v2.patch
>
>
> I have seen NPE thrown from {{JobHistoryEventHandler#handleEvent}}:
> {noformat}
> 2016-03-14 16:42:15,231 INFO [Thread-69]
> org.apache.hadoop.service.AbstractService: Service JobHistoryEventHandler
> failed in state STOPPED; cause: java.lang.NullPointerException
> java.lang.NullPointerException
> at
> org.apache.hadoop.mapreduce.jobhistory.JobHistoryEventHandler.handleEvent(JobHistoryEventHandler.java:570)
> at
> org.apache.hadoop.mapreduce.jobhistory.JobHistoryEventHandler.serviceStop(JobHistoryEventHandler.java:382)
> at
> org.apache.hadoop.service.AbstractService.stop(AbstractService.java:221)
> at
> org.apache.hadoop.service.ServiceOperations.stop(ServiceOperations.java:52)
> at
> org.apache.hadoop.service.ServiceOperations.stopQuietly(ServiceOperations.java:80)
> at
> org.apache.hadoop.service.CompositeService.stop(CompositeService.java:157)
> at
> org.apache.hadoop.service.CompositeService.serviceStop(CompositeService.java:131)
> at
> org.apache.hadoop.mapreduce.v2.app.MRAppMaster.serviceStop(MRAppMaster.java:1651)
> at
> org.apache.hadoop.service.AbstractService.stop(AbstractService.java:221)
> at
> org.apache.hadoop.mapreduce.v2.app.MRAppMaster.stop(MRAppMaster.java:1147)
> at
> org.apache.hadoop.mapreduce.v2.app.MRAppMaster.shutDownJob(MRAppMaster.java:573)
> at
> org.apache.hadoop.mapreduce.v2.app.MRAppMaster$JobFinishEventHandler$1.run(MRAppMaster.java:620)
> {noformat}
> In the version this exception is thrown, the
> [line|https://github.com/apache/hadoop/blob/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/jobhistory/JobHistoryEventHandler.java#L586]
> is:
> {code:java}mi.writeEvent(historyEvent);{code}
> IMHO, this may be caused by an exception in a previous step. Specifically, in
> the kerberized environment, when creating event writer which calls to decrypt
> EEK, the connection to KMS failed. Exception below:
> {noformat}
> 2016-03-14 16:41:57,559 ERROR [eventHandlingThread]
> org.apache.hadoop.mapreduce.jobhistory.JobHistoryEventHandler: Error
> JobHistoryEventHandler in handleEvent: EventType: AM_STARTED
> java.net.SocketTimeoutException: Read timed out
> at java.net.SocketInputStream.socketRead0(Native Method)
> at java.net.SocketInputStream.read(SocketInputStream.java:152)
> at java.net.SocketInputStream.read(SocketInputStream.java:122)
> at java.io.BufferedInputStream.fill(BufferedInputStream.java:235)
> at java.io.BufferedInputStream.read1(BufferedInputStream.java:275)
> at java.io.BufferedInputStream.read(BufferedInputStream.java:334)
> at sun.net.www.http.HttpClient.parseHTTPHeader(HttpClient.java:687)
> at sun.net.www.http.HttpClient.parseHTTP(HttpClient.java:633)
> at
> sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1323)
> at
> java.net.HttpURLConnection.getResponseCode(HttpURLConnection.java:468)
> at
> org.apache.hadoop.crypto.key.kms.KMSClientProvider.call(KMSClientProvider.java:520)
> at
> org.apache.hadoop.crypto.key.kms.KMSClientProvider.call(KMSClientProvider.java:505)
> at
> org.apache.hadoop.crypto.key.kms.KMSClientProvider.decryptEncryptedKey(KMSClientProvider.java:779)
> at
>
[jira] [Updated] (MAPREDUCE-6654) Possible NPE in JobHistoryEventHandler#handleEvent
[
https://issues.apache.org/jira/browse/MAPREDUCE-6654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arun Suresh updated MAPREDUCE-6654:
---
Is this still on target for 2.9.0 ? If not, can we we push this out to the next
major release ?
> Possible NPE in JobHistoryEventHandler#handleEvent
> --
>
> Key: MAPREDUCE-6654
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-6654
> Project: Hadoop Map/Reduce
> Issue Type: Bug
>Reporter: Xiao Chen
>Assignee: Junping Du
>Priority: Critical
> Attachments: MAPREDUCE-6654.patch, MAPREDUCE-6654-v2.1.patch,
> MAPREDUCE-6654-v2.patch
>
>
> I have seen NPE thrown from {{JobHistoryEventHandler#handleEvent}}:
> {noformat}
> 2016-03-14 16:42:15,231 INFO [Thread-69]
> org.apache.hadoop.service.AbstractService: Service JobHistoryEventHandler
> failed in state STOPPED; cause: java.lang.NullPointerException
> java.lang.NullPointerException
> at
> org.apache.hadoop.mapreduce.jobhistory.JobHistoryEventHandler.handleEvent(JobHistoryEventHandler.java:570)
> at
> org.apache.hadoop.mapreduce.jobhistory.JobHistoryEventHandler.serviceStop(JobHistoryEventHandler.java:382)
> at
> org.apache.hadoop.service.AbstractService.stop(AbstractService.java:221)
> at
> org.apache.hadoop.service.ServiceOperations.stop(ServiceOperations.java:52)
> at
> org.apache.hadoop.service.ServiceOperations.stopQuietly(ServiceOperations.java:80)
> at
> org.apache.hadoop.service.CompositeService.stop(CompositeService.java:157)
> at
> org.apache.hadoop.service.CompositeService.serviceStop(CompositeService.java:131)
> at
> org.apache.hadoop.mapreduce.v2.app.MRAppMaster.serviceStop(MRAppMaster.java:1651)
> at
> org.apache.hadoop.service.AbstractService.stop(AbstractService.java:221)
> at
> org.apache.hadoop.mapreduce.v2.app.MRAppMaster.stop(MRAppMaster.java:1147)
> at
> org.apache.hadoop.mapreduce.v2.app.MRAppMaster.shutDownJob(MRAppMaster.java:573)
> at
> org.apache.hadoop.mapreduce.v2.app.MRAppMaster$JobFinishEventHandler$1.run(MRAppMaster.java:620)
> {noformat}
> In the version this exception is thrown, the
> [line|https://github.com/apache/hadoop/blob/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/jobhistory/JobHistoryEventHandler.java#L586]
> is:
> {code:java}mi.writeEvent(historyEvent);{code}
> IMHO, this may be caused by an exception in a previous step. Specifically, in
> the kerberized environment, when creating event writer which calls to decrypt
> EEK, the connection to KMS failed. Exception below:
> {noformat}
> 2016-03-14 16:41:57,559 ERROR [eventHandlingThread]
> org.apache.hadoop.mapreduce.jobhistory.JobHistoryEventHandler: Error
> JobHistoryEventHandler in handleEvent: EventType: AM_STARTED
> java.net.SocketTimeoutException: Read timed out
> at java.net.SocketInputStream.socketRead0(Native Method)
> at java.net.SocketInputStream.read(SocketInputStream.java:152)
> at java.net.SocketInputStream.read(SocketInputStream.java:122)
> at java.io.BufferedInputStream.fill(BufferedInputStream.java:235)
> at java.io.BufferedInputStream.read1(BufferedInputStream.java:275)
> at java.io.BufferedInputStream.read(BufferedInputStream.java:334)
> at sun.net.www.http.HttpClient.parseHTTPHeader(HttpClient.java:687)
> at sun.net.www.http.HttpClient.parseHTTP(HttpClient.java:633)
> at
> sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1323)
> at
> java.net.HttpURLConnection.getResponseCode(HttpURLConnection.java:468)
> at
> org.apache.hadoop.crypto.key.kms.KMSClientProvider.call(KMSClientProvider.java:520)
> at
> org.apache.hadoop.crypto.key.kms.KMSClientProvider.call(KMSClientProvider.java:505)
> at
> org.apache.hadoop.crypto.key.kms.KMSClientProvider.decryptEncryptedKey(KMSClientProvider.java:779)
> at
> org.apache.hadoop.crypto.key.kms.LoadBalancingKMSClientProvider$3.call(LoadBalancingKMSClientProvider.java:185)
> at
> org.apache.hadoop.crypto.key.kms.LoadBalancingKMSClientProvider$3.call(LoadBalancingKMSClientProvider.java:181)
> at
> org.apache.hadoop.crypto.key.kms.LoadBalancingKMSClientProvider.doOp(LoadBalancingKMSClientProvider.java:94)
> at
> org.apache.hadoop.crypto.key.kms.LoadBalancingKMSClientProvider.decryptEncryptedKey(LoadBalancingKMSClientProvider.java:181)
> at
> org.apache.hadoop.crypto.key.KeyProviderCryptoExtension.decryptEncryptedKey(KeyProviderCryptoExtension.java:388)
> at
> org.apache.hadoop.hdfs.DFSClient.decryptEncryptedDataEncryptionKey(DFSClient.java:1420)
> at
> org.apache.hadoop.hdfs.DFSClient.createWrappedOutputStream(DFSClient.java:1522)
> at
[jira] [Updated] (MAPREDUCE-6241) Native compilation fails for Checksum.cc due to an incompatibility of assembler register constraint for PowerPC
[ https://issues.apache.org/jira/browse/MAPREDUCE-6241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arun Suresh updated MAPREDUCE-6241: --- Is this still on target for 2.9.0 ? If not, can we we push this out to the next major release ? > Native compilation fails for Checksum.cc due to an incompatibility of > assembler register constraint for PowerPC > > > Key: MAPREDUCE-6241 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-6241 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: build >Affects Versions: 2.6.0, 3.0.0-alpha1 > Environment: Debian/Jessie, kernel 3.18.5, ppc64 GNU/Linux > gcc (Debian 4.9.1-19) > protobuf 2.6.1 > OpenJDK Runtime Environment (IcedTea 2.5.3) (7u71-2.5.3-2) > OpenJDK Zero VM (build 24.65-b04, interpreted mode) > source was cloned (and updated) from Apache-Hadoop's git repository >Reporter: Stephan Drescher >Assignee: Binglin Chang > Labels: BB2015-05-TBR, features > Attachments: MAPREDUCE-6241.001.patch, MAPREDUCE-6241.002.patch, > MAPREDUCE-6241.003.patch > > > Issue when using assembler code for performance optimization on the powerpc > platform (compiled for 32bit) > mvn compile -Pnative -DskipTests > [exec] /usr/bin/c++ -Dnativetask_EXPORTS -m32 -DSIMPLE_MEMCPY > -fno-strict-aliasing -Wall -Wno-sign-compare -g -O2 -DNDEBUG -fPIC > -I/home/hadoop/Developer/hadoop/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/target/native/javah > > -I/home/hadoop/Developer/hadoop/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src > > -I/home/hadoop/Developer/hadoop/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/util > > -I/home/hadoop/Developer/hadoop/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/lib > > -I/home/hadoop/Developer/hadoop/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/test > > -I/home/hadoop/Developer/hadoop/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src > > -I/home/hadoop/Developer/hadoop/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/target/native > -I/home/hadoop/Java/java7/include -I/home/hadoop/Java/java7/include/linux > -isystem > /home/hadoop/Developer/hadoop/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/gtest/include > -o CMakeFiles/nativetask.dir/main/native/src/util/Checksum.cc.o -c > /home/hadoop/Developer/hadoop/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/util/Checksum.cc > [exec] CMakeFiles/nativetask.dir/build.make:744: recipe for target > 'CMakeFiles/nativetask.dir/main/native/src/util/Checksum.cc.o' failed > [exec] make[2]: Leaving directory > '/home/hadoop/Developer/hadoop/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/target/native' > [exec] CMakeFiles/Makefile2:95: recipe for target > 'CMakeFiles/nativetask.dir/all' failed > [exec] make[1]: Leaving directory > '/home/hadoop/Developer/hadoop/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/target/native' > [exec] Makefile:76: recipe for target 'all' failed > [exec] > /home/hadoop/Developer/hadoop/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/util/Checksum.cc: > In function ‘void NativeTask::init_cpu_support_flag()’: > /home/hadoop/Developer/hadoop/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/util/Checksum.cc:611:14: > error: impossible register constraint in ‘asm’ > --> > "popl %%ebx" : "=a" (eax), [ebx] "=r"(ebx), "=c"(ecx), "=d"(edx) : "a" > (eax_in) : "cc"); > <-- -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
[jira] [Updated] (MAPREDUCE-6925) CLONE - Make Counter limits consistent across JobClient, MRAppMaster, and YarnChild
[
https://issues.apache.org/jira/browse/MAPREDUCE-6925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arun Suresh updated MAPREDUCE-6925:
---
Target Version/s: 3.1.0 (was: 2.9.0, 3.0.0)
> CLONE - Make Counter limits consistent across JobClient, MRAppMaster, and
> YarnChild
> ---
>
> Key: MAPREDUCE-6925
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-6925
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: applicationmaster, client, task
>Affects Versions: 2.4.0
>Reporter: Gera Shegalov
>Assignee: Gera Shegalov
>
> Currently, counter limits "mapreduce.job.counters.*" handled by
> {{org.apache.hadoop.mapreduce.counters.Limits}} are initialized
> asymmetrically: on the client side, and on the AM, job.xml is ignored whereas
> it's taken into account in YarnChild.
> It would be good to make the Limits job-configurable, such that max
> counters/groups is only increased when needed. With the current Limits
> implementation relying on static constants, it's going to be challenging for
> tools that submit jobs concurrently without resorting to class loading
> isolation.
> The patch that I am uploading is not perfect but demonstrates the issue.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
[jira] [Updated] (MAPREDUCE-6946) Moving logging APIs over to slf4j in hadoop-mapreduce
[ https://issues.apache.org/jira/browse/MAPREDUCE-6946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arun Suresh updated MAPREDUCE-6946: --- Target Version/s: 3.1.0 (was: 2.9.0, 3.0.0) > Moving logging APIs over to slf4j in hadoop-mapreduce > - > > Key: MAPREDUCE-6946 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-6946 > Project: Hadoop Map/Reduce > Issue Type: Improvement >Reporter: Akira Ajisaka > > MapReduce side of YARN-6712. This is an umbrella jira for MapReduce. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
[jira] [Updated] (MAPREDUCE-6973) Comment refers to "_done" file instead of "_SUCCESS" file
[ https://issues.apache.org/jira/browse/MAPREDUCE-6973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Lowe updated MAPREDUCE-6973: -- Fix Version/s: (was: 3.0.0-beta1) > Comment refers to "_done" file instead of "_SUCCESS" file > - > > Key: MAPREDUCE-6973 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-6973 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: documentation >Affects Versions: 3.0.0-beta1 >Reporter: Mehul Garnara (MG) >Assignee: Mehul Garnara (MG) >Priority: Trivial > Labels: easyfix, newbie > Original Estimate: 10m > Remaining Estimate: 10m > > I went through couple of old JIRA issues and understood that earlier app was > creating "_done" file on job has completed successfully. After some > conversation by group decided to create "_SUCCESS" instead of "_done". > However, while learning the code, I found there is one comment has reference > of "_done" and would like to start with small contribution to fix it. > Note: I would like to work on this trivial issue so can get opportunity to > follow standard process of contribution steps, that will myself to come on > track quickly for future contribution that I would like to do. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
[jira] [Updated] (MAPREDUCE-6973) Comment refers to "_done" file instead of "_SUCCESS" file
[ https://issues.apache.org/jira/browse/MAPREDUCE-6973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Lowe updated MAPREDUCE-6973: -- Hadoop Flags: (was: Incompatible change) > Comment refers to "_done" file instead of "_SUCCESS" file > - > > Key: MAPREDUCE-6973 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-6973 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: documentation >Affects Versions: 3.0.0-beta1 >Reporter: Mehul Garnara (MG) >Assignee: Mehul Garnara (MG) >Priority: Trivial > Labels: easyfix, newbie > Original Estimate: 10m > Remaining Estimate: 10m > > I went through couple of old JIRA issues and understood that earlier app was > creating "_done" file on job has completed successfully. After some > conversation by group decided to create "_SUCCESS" instead of "_done". > However, while learning the code, I found there is one comment has reference > of "_done" and would like to start with small contribution to fix it. > Note: I would like to work on this trivial issue so can get opportunity to > follow standard process of contribution steps, that will myself to come on > track quickly for future contribution that I would like to do. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
[jira] [Updated] (MAPREDUCE-6973) Comment refers to "_done" file instead of "_SUCCESS" file
[ https://issues.apache.org/jira/browse/MAPREDUCE-6973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Lowe updated MAPREDUCE-6973: -- Target Version/s: 3.0.0 (was: 3.0.0-beta1) > Comment refers to "_done" file instead of "_SUCCESS" file > - > > Key: MAPREDUCE-6973 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-6973 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: documentation >Affects Versions: 3.0.0-beta1 >Reporter: Mehul Garnara (MG) >Assignee: Mehul Garnara (MG) >Priority: Trivial > Labels: easyfix, newbie > Original Estimate: 10m > Remaining Estimate: 10m > > I went through couple of old JIRA issues and understood that earlier app was > creating "_done" file on job has completed successfully. After some > conversation by group decided to create "_SUCCESS" instead of "_done". > However, while learning the code, I found there is one comment has reference > of "_done" and would like to start with small contribution to fix it. > Note: I would like to work on this trivial issue so can get opportunity to > follow standard process of contribution steps, that will myself to come on > track quickly for future contribution that I would like to do. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
[jira] [Assigned] (MAPREDUCE-6973) Comment refers to "_done" file instead of "_SUCCESS" file
[ https://issues.apache.org/jira/browse/MAPREDUCE-6973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Lowe reassigned MAPREDUCE-6973: - Assignee: Mehul Garnara (MG) Summary: Comment refers to "_done" file instead of "_SUCCESS" file (was: Remove comment reference of "_done" that was replaced with "_SUCCESS") Issue Type: Bug (was: Wish) > Comment refers to "_done" file instead of "_SUCCESS" file > - > > Key: MAPREDUCE-6973 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-6973 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: documentation >Affects Versions: 3.0.0-beta1 >Reporter: Mehul Garnara (MG) >Assignee: Mehul Garnara (MG) >Priority: Trivial > Labels: easyfix, newbie > Fix For: 3.0.0-beta1 > > Original Estimate: 10m > Remaining Estimate: 10m > > I went through couple of old JIRA issues and understood that earlier app was > creating "_done" file on job has completed successfully. After some > conversation by group decided to create "_SUCCESS" instead of "_done". > However, while learning the code, I found there is one comment has reference > of "_done" and would like to start with small contribution to fix it. > Note: I would like to work on this trivial issue so can get opportunity to > follow standard process of contribution steps, that will myself to come on > track quickly for future contribution that I would like to do. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
[jira] [Updated] (MAPREDUCE-6973) Remove comment reference of "_done" that was replaced with "_SUCCESS"
[ https://issues.apache.org/jira/browse/MAPREDUCE-6973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mehul updated MAPREDUCE-6973: - Description: I went through couple of old JIRA issues and understood that earlier app was creating "_done" file on job has completed successfully. After some conversation by group decided to create "_SUCCESS" instead of "_done". However, while learning the code, I found there is one comment has reference of "_done" and would like to start with small contribution to fix it. Note: I would like to work on this trivial issue so can get opportunity to follow standard process of contribution steps, that will myself to come on track quickly for future contribution that I would like to do. was: I went through couple of old JIRA issues and understood that earlier app was creating "_done" file on job has completed successfully. After some conversation by group decided to create "_SUCCESS" instead of "_done". However, while learning the code, I found there is one comment has reference of "_done" and would like to start with small contribution to fix it. Note: I would like to work on this trivial issue so can learn for standard process of contribution steps so that will help myself to come on track for future contribution that I would like to do. > Remove comment reference of "_done" that was replaced with "_SUCCESS" > - > > Key: MAPREDUCE-6973 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-6973 > Project: Hadoop Map/Reduce > Issue Type: Wish > Components: documentation >Affects Versions: 3.0.0-beta1 >Reporter: Mehul >Priority: Trivial > Labels: easyfix, newbie > Fix For: 3.0.0-beta1 > > Original Estimate: 10m > Remaining Estimate: 10m > > I went through couple of old JIRA issues and understood that earlier app was > creating "_done" file on job has completed successfully. After some > conversation by group decided to create "_SUCCESS" instead of "_done". > However, while learning the code, I found there is one comment has reference > of "_done" and would like to start with small contribution to fix it. > Note: I would like to work on this trivial issue so can get opportunity to > follow standard process of contribution steps, that will myself to come on > track quickly for future contribution that I would like to do. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
[jira] [Created] (MAPREDUCE-6973) Remove comment reference of "_done" that was replaced with "_SUCCESS"
Mehul created MAPREDUCE-6973: Summary: Remove comment reference of "_done" that was replaced with "_SUCCESS" Key: MAPREDUCE-6973 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6973 Project: Hadoop Map/Reduce Issue Type: Wish Components: documentation Affects Versions: 3.0.0-beta1 Reporter: Mehul Priority: Trivial Fix For: 3.0.0-beta1 I went through couple of old JIRA issues and understood that earlier app was creating "_done" file on job has completed successfully. After some conversation by group decided to create "_SUCCESS" instead of "_done". However, while learning the code, I found there is one comment has reference of "_done" and would like to start with small contribution to fix it. Note: I would like to work on this trivial issue so can learn for standard process of contribution steps so that will help myself to come on track for future contribution that I would like to do. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
[jira] [Commented] (MAPREDUCE-6972) enable try-with-resources for RecordReader
[
https://issues.apache.org/jira/browse/MAPREDUCE-6972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16185728#comment-16185728
]
Hadoop QA commented on MAPREDUCE-6972:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
18s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 13m
18s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
27s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
19s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
29s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
48s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
23s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
20s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
40s{color} | {color:green} hadoop-mapreduce-client-core in the patch passed.
{color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
14s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 22m 19s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:71bbb86 |
| JIRA Issue | MAPREDUCE-6972 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12889678/MAPREDUCE-6972.02.patch
|
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit findbugs checkstyle |
| uname | Linux 23996186e544 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11
12:48:20 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh
|
| git revision | trunk / d3b1c63 |
| Default Java | 1.8.0_144 |
| findbugs | v3.1.0-RC1 |
| Test Results |
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/7167/testReport/ |
| modules | C:
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core
U:
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core |
| Console output |
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/7167/console |
| Powered by | Apache Yetus 0.5.0 http://yetus.apache.org |
This message was automatically generated.
> enable try-with-resources for RecordReader
> --
>
> Key: MAPREDUCE-6972
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-6972
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
>Reporter: Zoltan Haindrich
> Attachments: MAPREDUCE-6972.01.patch, MAPREDUCE-6972.02.patch
>
>
> {{org.apache.hadoop.mapred.RecordReader}}
[jira] [Updated] (MAPREDUCE-6972) enable try-with-resources for RecordReader
[
https://issues.apache.org/jira/browse/MAPREDUCE-6972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zoltan Haindrich updated MAPREDUCE-6972:
Attachment: MAPREDUCE-6972.02.patch
Thank you [~ajisakaa], I've just added the missing annotation :)
> enable try-with-resources for RecordReader
> --
>
> Key: MAPREDUCE-6972
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-6972
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
>Reporter: Zoltan Haindrich
> Attachments: MAPREDUCE-6972.01.patch, MAPREDUCE-6972.02.patch
>
>
> {{org.apache.hadoop.mapred.RecordReader}} has a close method; but doesn't
> implement closeable; it would be nice to add that - it would enable to use:
> {code}
> try( org.apache.hadoop.mapred.RecordReader recordReader =
> inputFormat.getRecordReader(... ) ){
> [...]
> }
> {code}
> ...supporting t-w-r makes it easier to throw exceptions more safely
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
[jira] [Commented] (MAPREDUCE-6972) enable try-with-resources for RecordReader
[
https://issues.apache.org/jira/browse/MAPREDUCE-6972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16185662#comment-16185662
]
Akira Ajisaka commented on MAPREDUCE-6972:
--
Would you add {{@Override}} annotation to the close method? I'm +1 if that is
addressed.
> enable try-with-resources for RecordReader
> --
>
> Key: MAPREDUCE-6972
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-6972
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
>Reporter: Zoltan Haindrich
> Attachments: MAPREDUCE-6972.01.patch
>
>
> {{org.apache.hadoop.mapred.RecordReader}} has a close method; but doesn't
> implement closeable; it would be nice to add that - it would enable to use:
> {code}
> try( org.apache.hadoop.mapred.RecordReader recordReader =
> inputFormat.getRecordReader(... ) ){
> [...]
> }
> {code}
> ...supporting t-w-r makes it easier to throw exceptions more safely
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
[jira] [Commented] (MAPREDUCE-6972) enable try-with-resources for RecordReader
[
https://issues.apache.org/jira/browse/MAPREDUCE-6972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16185572#comment-16185572
]
Hadoop QA commented on MAPREDUCE-6972:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
27s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 13m
19s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
26s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
18s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
29s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
50s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
23s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
19s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
41s{color} | {color:green} hadoop-mapreduce-client-core in the patch passed.
{color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
14s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 22m 30s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:71bbb86 |
| JIRA Issue | MAPREDUCE-6972 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12889666/MAPREDUCE-6972.01.patch
|
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit findbugs checkstyle |
| uname | Linux bedf76e54844 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11
12:48:20 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh
|
| git revision | trunk / d3b1c63 |
| Default Java | 1.8.0_144 |
| findbugs | v3.1.0-RC1 |
| Test Results |
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/7166/testReport/ |
| modules | C:
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core
U:
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core |
| Console output |
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/7166/console |
| Powered by | Apache Yetus 0.5.0 http://yetus.apache.org |
This message was automatically generated.
> enable try-with-resources for RecordReader
> --
>
> Key: MAPREDUCE-6972
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-6972
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
>Reporter: Zoltan Haindrich
> Attachments: MAPREDUCE-6972.01.patch
>
>
> {{org.apache.hadoop.mapred.RecordReader}} has a close method; but
[jira] [Updated] (MAPREDUCE-6972) enable try-with-resources for RecordReader
[
https://issues.apache.org/jira/browse/MAPREDUCE-6972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zoltan Haindrich updated MAPREDUCE-6972:
Status: Patch Available (was: Open)
> enable try-with-resources for RecordReader
> --
>
> Key: MAPREDUCE-6972
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-6972
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
>Reporter: Zoltan Haindrich
> Attachments: MAPREDUCE-6972.01.patch
>
>
> {{org.apache.hadoop.mapred.RecordReader}} has a close method; but doesn't
> implement closeable; it would be nice to add that - it would enable to use:
> {code}
> try( org.apache.hadoop.mapred.RecordReader recordReader =
> inputFormat.getRecordReader(... ) ){
> [...]
> }
> {code}
> ...supporting t-w-r makes it easier to throw exceptions more safely
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
[jira] [Updated] (MAPREDUCE-6972) enable try-with-resources for RecordReader
[
https://issues.apache.org/jira/browse/MAPREDUCE-6972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zoltan Haindrich updated MAPREDUCE-6972:
Attachment: MAPREDUCE-6972.01.patch
> enable try-with-resources for RecordReader
> --
>
> Key: MAPREDUCE-6972
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-6972
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
>Reporter: Zoltan Haindrich
> Attachments: MAPREDUCE-6972.01.patch
>
>
> {{org.apache.hadoop.mapred.RecordReader}} has a close method; but doesn't
> implement closeable; it would be nice to add that - it would enable to use:
> {code}
> try( org.apache.hadoop.mapred.RecordReader recordReader =
> inputFormat.getRecordReader(... ) ){
> [...]
> }
> {code}
> ...supporting t-w-r makes it easier to throw exceptions more safely
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
[jira] [Created] (MAPREDUCE-6972) enable try-with-resources for RecordReader
Zoltan Haindrich created MAPREDUCE-6972:
---
Summary: enable try-with-resources for RecordReader
Key: MAPREDUCE-6972
URL: https://issues.apache.org/jira/browse/MAPREDUCE-6972
Project: Hadoop Map/Reduce
Issue Type: Improvement
Reporter: Zoltan Haindrich
{{org.apache.hadoop.mapred.RecordReader}} has a close method; but doesn't
implement closeable; it would be nice to add that - it would enable to use:
{code}
try( org.apache.hadoop.mapred.RecordReader recordReader =
inputFormat.getRecordReader(... ) ){
[...]
}
{code}
...supporting t-w-r makes it easier to throw exceptions more safely
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
