[jira] [Commented] (MAPREDUCE-7021) Remove logger dependencies other than org.slf4j in hadoop-mapreduce
[ https://issues.apache.org/jira/browse/MAPREDUCE-7021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16798759#comment-16798759 ] Akira Ajisaka commented on MAPREDUCE-7021: -- Thanks [~eyang] for reviewing this. Agreed to fix it later. > Remove logger dependencies other than org.slf4j in hadoop-mapreduce > --- > > Key: MAPREDUCE-7021 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-7021 > Project: Hadoop Map/Reduce > Issue Type: Sub-task >Reporter: Akira Ajisaka >Assignee: Akira Ajisaka >Priority: Major > Attachments: MAPREDUCE-7021.001.patch > > > We moved logging APIs over to slf4j, however, the dependency is left. We need > to cut the dependency. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
[jira] [Commented] (MAPREDUCE-7021) Remove logger dependencies other than org.slf4j in hadoop-mapreduce
[ https://issues.apache.org/jira/browse/MAPREDUCE-7021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16796260#comment-16796260 ] Eric Yang commented on MAPREDUCE-7021: -- [~ajisakaa] Thank you for the patch. I did a search on github.com for projects that uses mapreduce and commons logging api. There are 7,980 results. I think this change should not be included in a minor release because it breaks existing applications. As long as Hadoop framework doesn't deadlock in highly stressed system, the task should be allowed to run with commons logging. Not fixing this in the short term is probably ok. Can we target this for 4.0 to prevent breaking compatibility? > Remove logger dependencies other than org.slf4j in hadoop-mapreduce > --- > > Key: MAPREDUCE-7021 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-7021 > Project: Hadoop Map/Reduce > Issue Type: Sub-task >Reporter: Akira Ajisaka >Assignee: Akira Ajisaka >Priority: Major > Attachments: MAPREDUCE-7021.001.patch > > > We moved logging APIs over to slf4j, however, the dependency is left. We need > to cut the dependency. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
[jira] [Commented] (MAPREDUCE-7021) Remove logger dependencies other than org.slf4j in hadoop-mapreduce
[ https://issues.apache.org/jira/browse/MAPREDUCE-7021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795690#comment-16795690 ] Hadoop QA commented on MAPREDUCE-7021: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 15s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s{color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} | || || || || {color:brown} trunk Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 34s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 16m 53s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 3s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 2m 5s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 31m 27s{color} | {color:green} branch has no errors when building and testing our client artifacts. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 5s{color} | {color:green} trunk passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 12s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m 4s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 2s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m 2s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 2m 5s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 2s{color} | {color:green} The patch has no ill-formed XML file. {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 11m 50s{color} | {color:green} patch has no errors when building and testing our client artifacts. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 55s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} unit {color} | {color:red}149m 6s{color} | {color:red} hadoop-mapreduce-client in the patch failed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 43s{color} | {color:green} hadoop-mapreduce-examples in the patch passed. {color} | | {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m 33s{color} | {color:red} The patch generated 1 ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}203m 16s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:8f97d6f | | JIRA Issue | MAPREDUCE-7021 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12903170/MAPREDUCE-7021.001.patch | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml | | uname | Linux 1caa67897ee8 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | trunk / 09eabda | | maven | version: Apache Maven 3.3.9 | | Default Java | 1.8.0_191 | | unit | https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/7604/artifact/out/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client.txt | | Test Results | https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/7604/testReport/ | | asflicense | https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/7604/artifact/out/patch-asflicense-problems.txt | | Max. process+thread count | 1296 (vs. ulimit of 1) | | modules | C:
[jira] [Commented] (MAPREDUCE-7021) Remove logger dependencies other than org.slf4j in hadoop-mapreduce
[ https://issues.apache.org/jira/browse/MAPREDUCE-7021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795536#comment-16795536 ] Akira Ajisaka commented on MAPREDUCE-7021: -- Hi [~eyang], would you review this? This issue is similar to YARN-9364. > Remove logger dependencies other than org.slf4j in hadoop-mapreduce > --- > > Key: MAPREDUCE-7021 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-7021 > Project: Hadoop Map/Reduce > Issue Type: Sub-task >Reporter: Akira Ajisaka >Assignee: Akira Ajisaka >Priority: Major > Attachments: MAPREDUCE-7021.001.patch > > > We moved logging APIs over to slf4j, however, the dependency is left. We need > to cut the dependency. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
[jira] [Commented] (MAPREDUCE-7021) Remove logger dependencies other than org.slf4j in hadoop-mapreduce
[ https://issues.apache.org/jira/browse/MAPREDUCE-7021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697123#comment-16697123 ] Hadoop QA commented on MAPREDUCE-7021: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 16s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s{color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} | || || || || {color:brown} trunk Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 3m 5s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 21m 28s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 57s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 2m 25s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 39m 16s{color} | {color:green} branch has no errors when building and testing our client artifacts. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 1s{color} | {color:green} trunk passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 10s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m 11s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 56s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 56s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 55s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 3s{color} | {color:green} The patch has no ill-formed XML file. {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 11m 24s{color} | {color:green} patch has no errors when building and testing our client artifacts. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 59s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} unit {color} | {color:red} 16m 55s{color} | {color:red} hadoop-mapreduce-client in the patch failed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 42s{color} | {color:green} hadoop-mapreduce-examples in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 29s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 78m 11s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.mapreduce.jobhistory.TestEvents | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:8f97d6f | | JIRA Issue | MAPREDUCE-7021 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12903170/MAPREDUCE-7021.001.patch | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml | | uname | Linux f0c9d0141dba 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | trunk / 753f421 | | maven | version: Apache Maven 3.3.9 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/7531/artifact/out/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client.txt | | Test Results | https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/7531/testReport/ | | Max. process+thread count | 1572 (vs. ulimit of 1) | | modules | C:
[jira] [Commented] (MAPREDUCE-7021) Remove logger dependencies other than org.slf4j in hadoop-mapreduce
[ https://issues.apache.org/jira/browse/MAPREDUCE-7021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326134#comment-16326134 ] Takanobu Asanuma commented on MAPREDUCE-7021: - I filed the license error in MAPREDUCE-7036 and it is not related to this patch. +1 (non-binding) > Remove logger dependencies other than org.slf4j in hadoop-mapreduce > --- > > Key: MAPREDUCE-7021 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-7021 > Project: Hadoop Map/Reduce > Issue Type: Sub-task >Reporter: Akira Ajisaka >Assignee: Akira Ajisaka >Priority: Major > Attachments: MAPREDUCE-7021.001.patch > > > We moved logging APIs over to slf4j, however, the dependency is left. We need > to cut the dependency. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
[jira] [Commented] (MAPREDUCE-7021) Remove logger dependencies other than org.slf4j in hadoop-mapreduce
[ https://issues.apache.org/jira/browse/MAPREDUCE-7021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326071#comment-16326071 ] Hadoop QA commented on MAPREDUCE-7021: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 10s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 1s{color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} | || || || || {color:brown} trunk Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 41s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 15m 4s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 46s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 49s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 28m 15s{color} | {color:green} branch has no errors when building and testing our client artifacts. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 8s{color} | {color:green} trunk passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 9s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m 2s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 42s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 42s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 43s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 3s{color} | {color:green} The patch has no ill-formed XML file. {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 10m 29s{color} | {color:green} patch has no errors when building and testing our client artifacts. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 2s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} unit {color} | {color:red}150m 22s{color} | {color:red} hadoop-mapreduce-client in the patch failed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 40s{color} | {color:green} hadoop-mapreduce-examples in the patch passed. {color} | | {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m 25s{color} | {color:red} The patch generated 1 ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}198m 52s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.mapreduce.v2.TestUberAM | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:5b98639 | | JIRA Issue | MAPREDUCE-7021 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12903170/MAPREDUCE-7021.001.patch | | Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml | | uname | Linux 51526a57c977 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | trunk / 2e1e901 | | maven | version: Apache Maven 3.3.9 | | Default Java | 1.8.0_151 | | unit | https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/7298/artifact/out/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client.txt | | Test Results | https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/7298/testReport/ | | asflicense | https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/7298/artifact/out/patch-asflicense-problems.txt | |