[jira] [Commented] (MAPREDUCE-7047) Make HAR tool support IndexedLogAggregtionController
[ https://issues.apache.org/jira/browse/MAPREDUCE-7047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401136#comment-16401136 ] Hudson commented on MAPREDUCE-7047: --- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13846 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/13846/]) MAPREDUCE-7047. Make HAR tool support IndexedLogAggregtionController. (wangda: rev f47659fb9709f69846f08c489bcafd1e36f5bf09) * (edit) hadoop-tools/hadoop-archive-logs/src/test/java/org/apache/hadoop/tools/TestHadoopArchiveLogs.java * (edit) hadoop-tools/hadoop-archive-logs/src/main/java/org/apache/hadoop/tools/HadoopArchiveLogs.java > Make HAR tool support IndexedLogAggregtionController > > > Key: MAPREDUCE-7047 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-7047 > Project: Hadoop Map/Reduce > Issue Type: Improvement >Reporter: Xuan Gong >Assignee: Xuan Gong >Priority: Major > Fix For: 3.2.0 > > Attachments: MAPREDUCE-7047.trunk.1.patch, > MAPREDUCE-7047.trunk.2.patch, MAPREDUCE-7047.trunk.3.patch > > > In https://issues.apache.org/jira/browse/MAPREDUCE-6415, we have created a > tool to combine aggregated logs into HAR files which currently only work for > TFileLogAggregationFileController. We should make it support > IndexedLogAggregtionController as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
[jira] [Commented] (MAPREDUCE-7047) Make HAR tool support IndexedLogAggregtionController
[ https://issues.apache.org/jira/browse/MAPREDUCE-7047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16399541#comment-16399541 ] Wangda Tan commented on MAPREDUCE-7047: --- Thanks [~xgong]/[~rkanter], will commit tomorrow if no objections. > Make HAR tool support IndexedLogAggregtionController > > > Key: MAPREDUCE-7047 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-7047 > Project: Hadoop Map/Reduce > Issue Type: Improvement >Reporter: Xuan Gong >Assignee: Xuan Gong >Priority: Major > Attachments: MAPREDUCE-7047.trunk.1.patch, > MAPREDUCE-7047.trunk.2.patch, MAPREDUCE-7047.trunk.3.patch > > > In https://issues.apache.org/jira/browse/MAPREDUCE-6415, we have created a > tool to combine aggregated logs into HAR files which currently only work for > TFileLogAggregationFileController. We should make it support > IndexedLogAggregtionController as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
[jira] [Commented] (MAPREDUCE-7047) Make HAR tool support IndexedLogAggregtionController
[ https://issues.apache.org/jira/browse/MAPREDUCE-7047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16399363#comment-16399363 ] Robert Kanter commented on MAPREDUCE-7047: -- LGTM +1 > Make HAR tool support IndexedLogAggregtionController > > > Key: MAPREDUCE-7047 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-7047 > Project: Hadoop Map/Reduce > Issue Type: Improvement >Reporter: Xuan Gong >Assignee: Xuan Gong >Priority: Major > Attachments: MAPREDUCE-7047.trunk.1.patch, > MAPREDUCE-7047.trunk.2.patch, MAPREDUCE-7047.trunk.3.patch > > > In https://issues.apache.org/jira/browse/MAPREDUCE-6415, we have created a > tool to combine aggregated logs into HAR files which currently only work for > TFileLogAggregationFileController. We should make it support > IndexedLogAggregtionController as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
[jira] [Commented] (MAPREDUCE-7047) Make HAR tool support IndexedLogAggregtionController
[
https://issues.apache.org/jira/browse/MAPREDUCE-7047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16397952#comment-16397952
]
Hadoop QA commented on MAPREDUCE-7047:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
17s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 16m
32s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
21s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
10s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
20s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
9m 23s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
23s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
14s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
15s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 9s{color} | {color:orange} hadoop-tools/hadoop-archive-logs: The patch
generated 1 new + 7 unchanged - 1 fixed = 8 total (was 8) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
9m 42s{color} | {color:green} patch has no errors when building and testing our
client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
30s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
14s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
43s{color} | {color:green} hadoop-archive-logs in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
20s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 40m 41s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:d4cc50f |
| JIRA Issue | MAPREDUCE-7047 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12914369/MAPREDUCE-7047.trunk.3.patch
|
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit shadedclient findbugs checkstyle |
| uname | Linux 43a32b04a089 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12
13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / 9714fc1 |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_151 |
| findbugs | v3.1.0-RC1 |
| checkstyle |
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/7368/artifact/out/diff-checkstyle-hadoop-tools_hadoop-archive-logs.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/7368/testReport/ |
| Max. process+thread count | 509 (vs. ulimit of 1) |
| modules | C: hadoop-tools/hadoop-archive-logs U:
hadoop-tools/hadoop-archive-logs |
| Console output |
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/7368/console |
| Powered by | Apache
[jira] [Commented] (MAPREDUCE-7047) Make HAR tool support IndexedLogAggregtionController
[ https://issues.apache.org/jira/browse/MAPREDUCE-7047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16397794#comment-16397794 ] Xuan Gong commented on MAPREDUCE-7047: -- fix the findbug issue > Make HAR tool support IndexedLogAggregtionController > > > Key: MAPREDUCE-7047 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-7047 > Project: Hadoop Map/Reduce > Issue Type: Improvement >Reporter: Xuan Gong >Assignee: Xuan Gong >Priority: Major > Attachments: MAPREDUCE-7047.trunk.1.patch, > MAPREDUCE-7047.trunk.2.patch, MAPREDUCE-7047.trunk.3.patch > > > In https://issues.apache.org/jira/browse/MAPREDUCE-6415, we have created a > tool to combine aggregated logs into HAR files which currently only work for > TFileLogAggregationFileController. We should make it support > IndexedLogAggregtionController as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
[jira] [Commented] (MAPREDUCE-7047) Make HAR tool support IndexedLogAggregtionController
[
https://issues.apache.org/jira/browse/MAPREDUCE-7047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16397771#comment-16397771
]
Hadoop QA commented on MAPREDUCE-7047:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
21s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 16m
43s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
21s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
16s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
24s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
10m 14s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
27s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
18s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
17s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 11s{color} | {color:orange} hadoop-tools/hadoop-archive-logs: The patch
generated 4 new + 7 unchanged - 1 fixed = 11 total (was 8) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
20s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch has 1 line(s) that end in whitespace. Use git
apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply
{color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
10m 43s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
31s{color} | {color:red} hadoop-tools/hadoop-archive-logs generated 1 new + 0
unchanged - 0 fixed = 1 total (was 0) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
17s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
52s{color} | {color:green} hadoop-archive-logs in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
18s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 43m 12s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hadoop-tools/hadoop-archive-logs |
| | Primitive is boxed to call Long.compareTo(Long):Long.compareTo(Long): use
Long.compare(long, long) instead At HadoopArchiveLogs.java:[line 689] |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:d4cc50f |
| JIRA Issue | MAPREDUCE-7047 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12914359/MAPREDUCE-7047.trunk.2.patch
|
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit shadedclient findbugs checkstyle |
| uname | Linux a60080e2f2f7 4.4.0-116-generic #140-Ubuntu SMP Mon Feb 12
21:23:04 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / 9d6994d |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_151 |
| findbugs | v3.1.0-RC1 |
| checkstyle |
[jira] [Commented] (MAPREDUCE-7047) Make HAR tool support IndexedLogAggregtionController
[ https://issues.apache.org/jira/browse/MAPREDUCE-7047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16397700#comment-16397700 ] Xuan Gong commented on MAPREDUCE-7047: -- Thanks for the review. [~rkanter] Uploaded a new patch to address all your comments > Make HAR tool support IndexedLogAggregtionController > > > Key: MAPREDUCE-7047 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-7047 > Project: Hadoop Map/Reduce > Issue Type: Improvement >Reporter: Xuan Gong >Assignee: Xuan Gong >Priority: Major > Attachments: MAPREDUCE-7047.trunk.1.patch, > MAPREDUCE-7047.trunk.2.patch > > > In https://issues.apache.org/jira/browse/MAPREDUCE-6415, we have created a > tool to combine aggregated logs into HAR files which currently only work for > TFileLogAggregationFileController. We should make it support > IndexedLogAggregtionController as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
[jira] [Commented] (MAPREDUCE-7047) Make HAR tool support IndexedLogAggregtionController
[
https://issues.apache.org/jira/browse/MAPREDUCE-7047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16395559#comment-16395559
]
Robert Kanter commented on MAPREDUCE-7047:
--
Thanks [~xgong]. A few minor things:
# This code can be simplified, and should return a non-zero exit code:
{code:java}
boolean createdWorkingDirsSuccess = true;
for (Path workingDir : workingDirs) {
if (!prepareWorkingDir(fs, workingDir)) {
createdWorkingDirsSuccess = false;
LOG.error("Failed to create the workingDir:"
+ workingDir.toString());
break;
}
}
if (!createdWorkingDirsSuccess) {
return 0;
}
{code}
to
{code:java}
for (Path workingDir : workingDirs) {
if (!prepareWorkingDir(fs, workingDir)) {
createdWorkingDirsSuccess = false;
LOG.error("Failed to create the workingDir:"
+ workingDir.toString());
return 1
}
}
{code}
# When cleaning up the working directories, is it necessary to check that the
directories exist before trying to delete them? That's going to result in
additional calls. IIRC, delete will do a no-op if the directory doesn't exist.
# Looks like we accidentally lost a blank line above the
{{runDistributedShell}} method
# {{equals}} should also consider the other fields added to {{AppInfo}}. I
don't think we'll have any cases where this would cause a problem, but it's
safer if we take those into account.
# It would be better if the test used different values for the applications
(e.g. different working dirs, etc)
> Make HAR tool support IndexedLogAggregtionController
>
>
> Key: MAPREDUCE-7047
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-7047
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
>Reporter: Xuan Gong
>Assignee: Xuan Gong
>Priority: Major
> Attachments: MAPREDUCE-7047.trunk.1.patch
>
>
> In https://issues.apache.org/jira/browse/MAPREDUCE-6415, we have created a
> tool to combine aggregated logs into HAR files which currently only work for
> TFileLogAggregationFileController. We should make it support
> IndexedLogAggregtionController as well.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
[jira] [Commented] (MAPREDUCE-7047) Make HAR tool support IndexedLogAggregtionController
[ https://issues.apache.org/jira/browse/MAPREDUCE-7047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16393890#comment-16393890 ] Robert Kanter commented on MAPREDUCE-7047: -- Sure :) I'll take a look on Monday. > Make HAR tool support IndexedLogAggregtionController > > > Key: MAPREDUCE-7047 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-7047 > Project: Hadoop Map/Reduce > Issue Type: Improvement >Reporter: Xuan Gong >Assignee: Xuan Gong >Priority: Major > Attachments: MAPREDUCE-7047.trunk.1.patch > > > In https://issues.apache.org/jira/browse/MAPREDUCE-6415, we have created a > tool to combine aggregated logs into HAR files which currently only work for > TFileLogAggregationFileController. We should make it support > IndexedLogAggregtionController as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
[jira] [Commented] (MAPREDUCE-7047) Make HAR tool support IndexedLogAggregtionController
[ https://issues.apache.org/jira/browse/MAPREDUCE-7047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16393879#comment-16393879 ] Wangda Tan commented on MAPREDUCE-7047: --- +1, thanks [~xgong]. [~rkanter], do you want to take a look at the patch? I think you're more familiar with the code :) > Make HAR tool support IndexedLogAggregtionController > > > Key: MAPREDUCE-7047 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-7047 > Project: Hadoop Map/Reduce > Issue Type: Improvement >Reporter: Xuan Gong >Assignee: Xuan Gong >Priority: Major > Attachments: MAPREDUCE-7047.trunk.1.patch > > > In https://issues.apache.org/jira/browse/MAPREDUCE-6415, we have created a > tool to combine aggregated logs into HAR files which currently only work for > TFileLogAggregationFileController. We should make it support > IndexedLogAggregtionController as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
[jira] [Commented] (MAPREDUCE-7047) Make HAR tool support IndexedLogAggregtionController
[ https://issues.apache.org/jira/browse/MAPREDUCE-7047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16392303#comment-16392303 ] Xuan Gong commented on MAPREDUCE-7047: -- I have test the patch for both log aggregation file format, and make sure it works for both of them > Make HAR tool support IndexedLogAggregtionController > > > Key: MAPREDUCE-7047 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-7047 > Project: Hadoop Map/Reduce > Issue Type: Improvement >Reporter: Xuan Gong >Assignee: Xuan Gong >Priority: Major > Attachments: MAPREDUCE-7047.trunk.1.patch > > > In https://issues.apache.org/jira/browse/MAPREDUCE-6415, we have created a > tool to combine aggregated logs into HAR files which currently only work for > TFileLogAggregationFileController. We should make it support > IndexedLogAggregtionController as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
[jira] [Commented] (MAPREDUCE-7047) Make HAR tool support IndexedLogAggregtionController
[
https://issues.apache.org/jira/browse/MAPREDUCE-7047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16352247#comment-16352247
]
Hadoop QA commented on MAPREDUCE-7047:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
11s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 15m
21s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
21s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
12s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
22s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
9m 54s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
26s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
17s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
17s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 10s{color} | {color:orange} hadoop-tools/hadoop-archive-logs: The patch
generated 4 new + 7 unchanged - 1 fixed = 11 total (was 8) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
10m 35s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
15s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
38s{color} | {color:green} hadoop-archive-logs in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
20s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 40m 56s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:5b98639 |
| JIRA Issue | MAPREDUCE-7047 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12909207/MAPREDUCE-7047.trunk.1.patch
|
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit shadedclient findbugs checkstyle |
| uname | Linux f382deb05764 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12
13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / 4e9a59c |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_151 |
| findbugs | v3.1.0-RC1 |
| checkstyle |
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/7326/artifact/out/diff-checkstyle-hadoop-tools_hadoop-archive-logs.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/7326/testReport/ |
| Max. process+thread count | 500 (vs. ulimit of 5500) |
| modules | C: hadoop-tools/hadoop-archive-logs U:
hadoop-tools/hadoop-archive-logs |
| Console output |
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/7326/console |
| Powered by | Apache
