[jira] [Commented] (MAPREDUCE-7114) Make FrameworkUploader symlink ignore improvement
[ https://issues.apache.org/jira/browse/MAPREDUCE-7114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16521435#comment-16521435 ] Hudson commented on MAPREDUCE-7114: --- FAILURE: Integrated in Jenkins build Hadoop-precommit-ozone-acceptance #20 (See [https://builds.apache.org/job/Hadoop-precommit-ozone-acceptance/20/]) MAPREDUCE-7114. Make FrameworkUploader symlink ignore improvement. (miklos.szegedi: [https://github.com/apache/hadoop/commit/ae055622edeb3cbf82baa6ed952fc2abc84c021e]) * (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-uploader/src/test/java/org/apache/hadoop/mapred/uploader/TestFrameworkUploader.java * (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-uploader/src/main/java/org/apache/hadoop/mapred/uploader/FrameworkUploader.java > Make FrameworkUploader symlink ignore improvement > - > > Key: MAPREDUCE-7114 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-7114 > Project: Hadoop Map/Reduce > Issue Type: Bug >Affects Versions: 3.1.0 >Reporter: Gergo Repas >Assignee: Gergo Repas >Priority: Major > Fix For: 3.2.0 > > Attachments: MAPREDUCE-7114.000.patch, MAPREDUCE-7114.001.patch, > MAPREDUCE-7114.002.patch, MAPREDUCE-7114.003.patch > > > /dir1/dir2/./hadoop-common.jar style symlinks are not ignored, even if they > link to a file within the same directory. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
[jira] [Commented] (MAPREDUCE-7114) Make FrameworkUploader symlink ignore improvement
[ https://issues.apache.org/jira/browse/MAPREDUCE-7114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16520807#comment-16520807 ] Gergo Repas commented on MAPREDUCE-7114: Thanks for the review and commit [~szegedim]! > Make FrameworkUploader symlink ignore improvement > - > > Key: MAPREDUCE-7114 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-7114 > Project: Hadoop Map/Reduce > Issue Type: Bug >Affects Versions: 3.1.0 >Reporter: Gergo Repas >Assignee: Gergo Repas >Priority: Major > Fix For: 3.2.0 > > Attachments: MAPREDUCE-7114.000.patch, MAPREDUCE-7114.001.patch, > MAPREDUCE-7114.002.patch, MAPREDUCE-7114.003.patch > > > /dir1/dir2/./hadoop-common.jar style symlinks are not ignored, even if they > link to a file within the same directory. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
[jira] [Commented] (MAPREDUCE-7114) Make FrameworkUploader symlink ignore improvement
[ https://issues.apache.org/jira/browse/MAPREDUCE-7114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16520759#comment-16520759 ] Hudson commented on MAPREDUCE-7114: --- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14466 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/14466/]) MAPREDUCE-7114. Make FrameworkUploader symlink ignore improvement. (miklos.szegedi: rev ae055622edeb3cbf82baa6ed952fc2abc84c021e) * (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-uploader/src/test/java/org/apache/hadoop/mapred/uploader/TestFrameworkUploader.java * (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-uploader/src/main/java/org/apache/hadoop/mapred/uploader/FrameworkUploader.java > Make FrameworkUploader symlink ignore improvement > - > > Key: MAPREDUCE-7114 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-7114 > Project: Hadoop Map/Reduce > Issue Type: Bug >Affects Versions: 3.1.0 >Reporter: Gergo Repas >Assignee: Gergo Repas >Priority: Major > Fix For: 3.2.0 > > Attachments: MAPREDUCE-7114.000.patch, MAPREDUCE-7114.001.patch, > MAPREDUCE-7114.002.patch, MAPREDUCE-7114.003.patch > > > /dir1/dir2/./hadoop-common.jar style symlinks are not ignored, even if they > link to a file within the same directory. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
[jira] [Commented] (MAPREDUCE-7114) Make FrameworkUploader symlink ignore improvement
[ https://issues.apache.org/jira/browse/MAPREDUCE-7114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16520749#comment-16520749 ] Miklos Szegedi commented on MAPREDUCE-7114: --- +1 LGTM. > Make FrameworkUploader symlink ignore improvement > - > > Key: MAPREDUCE-7114 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-7114 > Project: Hadoop Map/Reduce > Issue Type: Bug >Affects Versions: 3.1.0 >Reporter: Gergo Repas >Assignee: Gergo Repas >Priority: Major > Attachments: MAPREDUCE-7114.000.patch, MAPREDUCE-7114.001.patch, > MAPREDUCE-7114.002.patch, MAPREDUCE-7114.003.patch > > > /dir1/dir2/./hadoop-common.jar style symlinks are not ignored, even if they > link to a file within the same directory. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
[jira] [Commented] (MAPREDUCE-7114) Make FrameworkUploader symlink ignore improvement
[
https://issues.apache.org/jira/browse/MAPREDUCE-7114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16520738#comment-16520738
]
Hadoop QA commented on MAPREDUCE-7114:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
15s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 23m
45s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
21s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
14s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
22s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
10m 33s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
27s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
17s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
11m 10s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
15s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
21s{color} | {color:green} hadoop-mapreduce-client-uploader in the patch
passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
23s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 50m 26s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:abb62dd |
| JIRA Issue | MAPREDUCE-7114 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12928803/MAPREDUCE-7114.003.patch
|
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit shadedclient findbugs checkstyle |
| uname | Linux 40d63318e84e 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12
13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / 55fad6a |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_171 |
| findbugs | v3.1.0-RC1 |
| Test Results |
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/7455/testReport/ |
| Max. process+thread count | 440 (vs. ulimit of 1) |
| modules | C:
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-uploader
U:
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-uploader
|
| Console output |
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/7455/console |
| Powered by | Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> Make FrameworkUploader
[jira] [Commented] (MAPREDUCE-7114) Make FrameworkUploader symlink ignore improvement
[ https://issues.apache.org/jira/browse/MAPREDUCE-7114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16520691#comment-16520691 ] Gergo Repas commented on MAPREDUCE-7114: [~miklos.szeg...@cloudera.com] Thanks, good point, I removed that if statement in v003. I re-checked, the test fails without the fix and passes with the fix. > Make FrameworkUploader symlink ignore improvement > - > > Key: MAPREDUCE-7114 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-7114 > Project: Hadoop Map/Reduce > Issue Type: Bug >Affects Versions: 3.1.0 >Reporter: Gergo Repas >Assignee: Gergo Repas >Priority: Major > Attachments: MAPREDUCE-7114.000.patch, MAPREDUCE-7114.001.patch, > MAPREDUCE-7114.002.patch, MAPREDUCE-7114.003.patch > > > /dir1/dir2/./hadoop-common.jar style symlinks are not ignored, even if they > link to a file within the same directory. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
[jira] [Commented] (MAPREDUCE-7114) Make FrameworkUploader symlink ignore improvement
[
https://issues.apache.org/jira/browse/MAPREDUCE-7114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16520586#comment-16520586
]
Miklos Szegedi commented on MAPREDUCE-7114:
---
Thank you for the patch [~grepas].
{code:java}
410 if (linkPathParent != null) {
411 linkPathParent = linkPathParent.normalize();
412 }
413 java.nio.file.Path normalizedLinkPath =
414 linkPathParent == null ? null : linkPathParent.normalize();
415 if (normalizedLinkPath != null && jarParent.normalize().equals({code}
What is the point of normalizing {{linkPathParent}} twice?
> Make FrameworkUploader symlink ignore improvement
> -
>
> Key: MAPREDUCE-7114
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-7114
> Project: Hadoop Map/Reduce
> Issue Type: Bug
>Affects Versions: 3.1.0
>Reporter: Gergo Repas
>Assignee: Gergo Repas
>Priority: Major
> Attachments: MAPREDUCE-7114.000.patch, MAPREDUCE-7114.001.patch,
> MAPREDUCE-7114.002.patch
>
>
> /dir1/dir2/./hadoop-common.jar style symlinks are not ignored, even if they
> link to a file within the same directory.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
[jira] [Commented] (MAPREDUCE-7114) Make FrameworkUploader symlink ignore improvement
[
https://issues.apache.org/jira/browse/MAPREDUCE-7114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16520524#comment-16520524
]
Hadoop QA commented on MAPREDUCE-7114:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
16s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 23m
47s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
21s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
14s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
23s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
10m 34s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
26s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
17s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
9s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
11m 4s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
30s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
16s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
22s{color} | {color:green} hadoop-mapreduce-client-uploader in the patch
passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
22s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 50m 24s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:abb62dd |
| JIRA Issue | MAPREDUCE-7114 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12928778/MAPREDUCE-7114.002.patch
|
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit shadedclient findbugs checkstyle |
| uname | Linux f45bb25dd7fd 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12
13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / 30728ac |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_171 |
| findbugs | v3.1.0-RC1 |
| Test Results |
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/7454/testReport/ |
| Max. process+thread count | 410 (vs. ulimit of 1) |
| modules | C:
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-uploader
U:
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-uploader
|
| Console output |
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/7454/console |
| Powered by | Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> Make FrameworkUploader
[jira] [Commented] (MAPREDUCE-7114) Make FrameworkUploader symlink ignore improvement
[ https://issues.apache.org/jira/browse/MAPREDUCE-7114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16520456#comment-16520456 ] Gergo Repas commented on MAPREDUCE-7114: Patch v002: addressing findbugs issue. > Make FrameworkUploader symlink ignore improvement > - > > Key: MAPREDUCE-7114 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-7114 > Project: Hadoop Map/Reduce > Issue Type: Bug >Affects Versions: 3.1.0 >Reporter: Gergo Repas >Assignee: Gergo Repas >Priority: Major > Attachments: MAPREDUCE-7114.000.patch, MAPREDUCE-7114.001.patch, > MAPREDUCE-7114.002.patch > > > /dir1/dir2/./hadoop-common.jar style symlinks are not ignored, even if they > link to a file within the same directory. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
[jira] [Commented] (MAPREDUCE-7114) Make FrameworkUploader symlink ignore improvement
[
https://issues.apache.org/jira/browse/MAPREDUCE-7114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16520451#comment-16520451
]
Hadoop QA commented on MAPREDUCE-7114:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
16s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 23m
46s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
21s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
14s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
23s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
10m 40s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
26s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
17s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
9s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
11m 1s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
35s{color} | {color:red}
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-uploader
generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
15s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
21s{color} | {color:green} hadoop-mapreduce-client-uploader in the patch
passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
23s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 50m 29s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs |
module:hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-uploader
|
| | Possible null pointer dereference in
org.apache.hadoop.mapred.uploader.FrameworkUploader.checkSymlink(File) due to
return value of called method Dereferenced at
FrameworkUploader.java:org.apache.hadoop.mapred.uploader.FrameworkUploader.checkSymlink(File)
due to return value of called method Dereferenced at
FrameworkUploader.java:[line 409] |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:abb62dd |
| JIRA Issue | MAPREDUCE-7114 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12928766/MAPREDUCE-7114.001.patch
|
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit shadedclient findbugs checkstyle |
| uname | Linux 5f5e85265b9e 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12
13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / 30728ac |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_171
[jira] [Commented] (MAPREDUCE-7114) Make FrameworkUploader symlink ignore improvement
[
https://issues.apache.org/jira/browse/MAPREDUCE-7114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16520373#comment-16520373
]
Hadoop QA commented on MAPREDUCE-7114:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
16s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 23m
50s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
20s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
14s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
23s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
10m 24s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
25s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
17s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
9s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
10m 50s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
33s{color} | {color:red}
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-uploader
generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
15s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
22s{color} | {color:green} hadoop-mapreduce-client-uploader in the patch
passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
23s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 50m 4s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs |
module:hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-uploader
|
| | Possible null pointer dereference in
org.apache.hadoop.mapred.uploader.FrameworkUploader.checkSymlink(File) due to
return value of called method Dereferenced at
FrameworkUploader.java:org.apache.hadoop.mapred.uploader.FrameworkUploader.checkSymlink(File)
due to return value of called method Dereferenced at
FrameworkUploader.java:[line 409] |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:abb62dd |
| JIRA Issue | MAPREDUCE-7114 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12928761/MAPREDUCE-7114.000.patch
|
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit shadedclient findbugs checkstyle |
| uname | Linux 269dd68ee450 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12
13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
[jira] [Commented] (MAPREDUCE-7114) Make FrameworkUploader symlink ignore improvement
[ https://issues.apache.org/jira/browse/MAPREDUCE-7114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16520370#comment-16520370 ] Gergo Repas commented on MAPREDUCE-7114: Patch v001: I extended the test case checking the symlinks. This test case fails without the fix provided in the patch, and passes with this fix. > Make FrameworkUploader symlink ignore improvement > - > > Key: MAPREDUCE-7114 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-7114 > Project: Hadoop Map/Reduce > Issue Type: Bug >Affects Versions: 3.1.0 >Reporter: Gergo Repas >Assignee: Gergo Repas >Priority: Major > Attachments: MAPREDUCE-7114.000.patch, MAPREDUCE-7114.001.patch > > > /dir1/dir2/./hadoop-common.jar style symlinks are not ignored, even if they > link to a file within the same directory. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
