[jira] [Commented] (MAPREDUCE-7151) RMContainerAllocator#handleJobPriorityChange expects application_priority always
[
https://issues.apache.org/jira/browse/MAPREDUCE-7151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16662652#comment-16662652
]
Hudson commented on MAPREDUCE-7151:
---
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #15309 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/15309/])
MAPREDUCE-7151. RMContainerAllocator#handleJobPriorityChange expects
(bibinchundatt: rev 74a5e683fe65ee624a094de77940a42777ed7a26)
* (edit)
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/rm/RMContainerAllocator.java
* (edit)
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/rm/TestRMContainerAllocator.java
> RMContainerAllocator#handleJobPriorityChange expects application_priority
> always
>
>
> Key: MAPREDUCE-7151
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-7151
> Project: Hadoop Map/Reduce
> Issue Type: Bug
>Reporter: Bibin A Chundatt
>Assignee: Bilwa S T
>Priority: Major
> Fix For: 3.3.0
>
> Attachments: MAPREDUCE-7151-001.patch, MAPREDUCE-7151-002.patch
>
>
> As per yarn_service.proto {{AllocateResponseProto}} *application_priority* is
> *optional* field.
> But {{RMContainerAllocator#handleJobPriorityChange}} expects to have
> application priority always in response which is not mandatory.
> {code}
> private void handleJobPriorityChange(AllocateResponse response) {
> Priority priorityFromResponse = Priority.newInstance(response
> .getApplicationPriority().getPriority());
> // Update the job priority to Job directly.
> getJob().setJobPriority(priorityFromResponse);
> }
> {code}
> {code}
> message AllocateResponseProto {
> ..
> optional hadoop.common.TokenProto am_rm_token = 12;
> optional PriorityProto application_priority = 13;
> optional CollectorInfoProto collector_info = 14;
> ..
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
[jira] [Commented] (MAPREDUCE-7151) RMContainerAllocator#handleJobPriorityChange expects application_priority always
[
https://issues.apache.org/jira/browse/MAPREDUCE-7151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16655384#comment-16655384
]
Bibin A Chundatt commented on MAPREDUCE-7151:
-
+ 1 for the latest patch .
Will commit by tomorrow if no one objects.
> RMContainerAllocator#handleJobPriorityChange expects application_priority
> always
>
>
> Key: MAPREDUCE-7151
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-7151
> Project: Hadoop Map/Reduce
> Issue Type: Bug
>Reporter: Bibin A Chundatt
>Assignee: Bilwa S T
>Priority: Major
> Attachments: MAPREDUCE-7151-001.patch, MAPREDUCE-7151-002.patch
>
>
> As per yarn_service.proto {{AllocateResponseProto}} *application_priority* is
> *optional* field.
> But {{RMContainerAllocator#handleJobPriorityChange}} expects to have
> application priority always in response which is not mandatory.
> {code}
> private void handleJobPriorityChange(AllocateResponse response) {
> Priority priorityFromResponse = Priority.newInstance(response
> .getApplicationPriority().getPriority());
> // Update the job priority to Job directly.
> getJob().setJobPriority(priorityFromResponse);
> }
> {code}
> {code}
> message AllocateResponseProto {
> ..
> optional hadoop.common.TokenProto am_rm_token = 12;
> optional PriorityProto application_priority = 13;
> optional CollectorInfoProto collector_info = 14;
> ..
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
[jira] [Commented] (MAPREDUCE-7151) RMContainerAllocator#handleJobPriorityChange expects application_priority always
[
https://issues.apache.org/jira/browse/MAPREDUCE-7151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16655065#comment-16655065
]
Hadoop QA commented on MAPREDUCE-7151:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
25s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 18m
32s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
32s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
22s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
30s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
11m 34s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
45s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
22s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
30s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch has 2 line(s) that end in whitespace. Use git
apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply
{color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
11m 59s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
48s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
20s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 9m
48s{color} | {color:green} hadoop-mapreduce-client-app in the patch passed.
{color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
25s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 58m 28s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:4b8c2b1 |
| JIRA Issue | MAPREDUCE-7151 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12944520/MAPREDUCE-7151-002.patch
|
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient findbugs checkstyle |
| uname | Linux 47aba18128c4 4.4.0-133-generic #159-Ubuntu SMP Fri Aug 10
07:31:43 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / 2202e00 |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.0-RC1 |
| whitespace |
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/7516/artifact/out/whitespace-eol.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/7516/testReport/ |
| Max. process+thread count | 593 (vs. ulimit of 1) |
| modules | C:
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app U:
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app |
| Console output |
[jira] [Commented] (MAPREDUCE-7151) RMContainerAllocator#handleJobPriorityChange expects application_priority always
[
https://issues.apache.org/jira/browse/MAPREDUCE-7151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16655005#comment-16655005
]
Bilwa S T commented on MAPREDUCE-7151:
--
[~bibinchundatt] Thank you for reviewing the patch
i have updated patch.
> RMContainerAllocator#handleJobPriorityChange expects application_priority
> always
>
>
> Key: MAPREDUCE-7151
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-7151
> Project: Hadoop Map/Reduce
> Issue Type: Bug
>Reporter: Bibin A Chundatt
>Assignee: Bilwa S T
>Priority: Major
> Attachments: MAPREDUCE-7151-001.patch, MAPREDUCE-7151-002.patch
>
>
> As per yarn_service.proto {{AllocateResponseProto}} *application_priority* is
> *optional* field.
> But {{RMContainerAllocator#handleJobPriorityChange}} expects to have
> application priority always in response which is not mandatory.
> {code}
> private void handleJobPriorityChange(AllocateResponse response) {
> Priority priorityFromResponse = Priority.newInstance(response
> .getApplicationPriority().getPriority());
> // Update the job priority to Job directly.
> getJob().setJobPriority(priorityFromResponse);
> }
> {code}
> {code}
> message AllocateResponseProto {
> ..
> optional hadoop.common.TokenProto am_rm_token = 12;
> optional PriorityProto application_priority = 13;
> optional CollectorInfoProto collector_info = 14;
> ..
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
[jira] [Commented] (MAPREDUCE-7151) RMContainerAllocator#handleJobPriorityChange expects application_priority always
[
https://issues.apache.org/jira/browse/MAPREDUCE-7151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653746#comment-16653746
]
Hadoop QA commented on MAPREDUCE-7151:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
40s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 44m
29s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
14s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
51s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
15s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
18m 59s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
35s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
49s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
9s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
9s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch has 1 line(s) that end in whitespace. Use git
apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply
{color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
19m 7s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
42s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 14m
57s{color} | {color:green} hadoop-mapreduce-client-app in the patch passed.
{color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
50s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}111m 27s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:4b8c2b1 |
| JIRA Issue | MAPREDUCE-7151 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12944302/MAPREDUCE-7151-001.patch
|
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient findbugs checkstyle |
| uname | Linux f554753a1fc9 3.13.0-153-generic #203-Ubuntu SMP Thu Jun 14
08:52:28 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / d54f559 |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.0-RC1 |
| whitespace |
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/7512/artifact/out/whitespace-eol.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/7512/testReport/ |
| Max. process+thread count | 583 (vs. ulimit of 1) |
| modules | C:
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app U:
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app |
| Console output |
[jira] [Commented] (MAPREDUCE-7151) RMContainerAllocator#handleJobPriorityChange expects application_priority always
[
https://issues.apache.org/jira/browse/MAPREDUCE-7151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653592#comment-16653592
]
Bibin A Chundatt commented on MAPREDUCE-7151:
-
Thank you [~BilwaST] for patch
Minor comment.
# default visibility can be set for {{handleJobPriorityChange}}
> RMContainerAllocator#handleJobPriorityChange expects application_priority
> always
>
>
> Key: MAPREDUCE-7151
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-7151
> Project: Hadoop Map/Reduce
> Issue Type: Bug
>Reporter: Bibin A Chundatt
>Assignee: Bilwa S T
>Priority: Major
> Attachments: MAPREDUCE-7151-001.patch
>
>
> As per yarn_service.proto {{AllocateResponseProto}} *application_priority* is
> *optional* field.
> But {{RMContainerAllocator#handleJobPriorityChange}} expects to have
> application priority always in response which is not mandatory.
> {code}
> private void handleJobPriorityChange(AllocateResponse response) {
> Priority priorityFromResponse = Priority.newInstance(response
> .getApplicationPriority().getPriority());
> // Update the job priority to Job directly.
> getJob().setJobPriority(priorityFromResponse);
> }
> {code}
> {code}
> message AllocateResponseProto {
> ..
> optional hadoop.common.TokenProto am_rm_token = 12;
> optional PriorityProto application_priority = 13;
> optional CollectorInfoProto collector_info = 14;
> ..
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
[jira] [Commented] (MAPREDUCE-7151) RMContainerAllocator#handleJobPriorityChange expects application_priority always
[
https://issues.apache.org/jira/browse/MAPREDUCE-7151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653268#comment-16653268
]
Bilwa S T commented on MAPREDUCE-7151:
--
Hi [~bibinchundatt] ... i have put a patch for this. Updating application
priority only if its set. Added testcase too. Please review
> RMContainerAllocator#handleJobPriorityChange expects application_priority
> always
>
>
> Key: MAPREDUCE-7151
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-7151
> Project: Hadoop Map/Reduce
> Issue Type: Bug
>Reporter: Bibin A Chundatt
>Assignee: Bilwa S T
>Priority: Major
> Attachments: MAPREDUCE-7151-001.patch
>
>
> As per yarn_service.proto {{AllocateResponseProto}} *application_priority* is
> *optional* field.
> But {{RMContainerAllocator#handleJobPriorityChange}} expects to have
> application priority always in response which is not mandatory.
> {code}
> private void handleJobPriorityChange(AllocateResponse response) {
> Priority priorityFromResponse = Priority.newInstance(response
> .getApplicationPriority().getPriority());
> // Update the job priority to Job directly.
> getJob().setJobPriority(priorityFromResponse);
> }
> {code}
> {code}
> message AllocateResponseProto {
> ..
> optional hadoop.common.TokenProto am_rm_token = 12;
> optional PriorityProto application_priority = 13;
> optional CollectorInfoProto collector_info = 14;
> ..
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
