[jira] [Updated] (MAPREDUCE-5569) FloatSplitter is not generating correct splits

2014-09-03 Thread Allen Wittenauer (JIRA) 

 [ 
https://issues.apache.org/jira/browse/MAPREDUCE-5569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Allen Wittenauer updated MAPREDUCE-5569:

Fix Version/s: (was: 3.0.0)

 FloatSplitter is not generating correct splits
 --

 Key: MAPREDUCE-5569
 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5569
 Project: Hadoop Map/Reduce
  Issue Type: Bug
Affects Versions: trunk, 2.1.0-beta, 1.3.0, 0.23.9
Reporter: Nathan Roberts
Assignee: Nathan Roberts
 Fix For: 1.3.0, 0.23.10, 2.3.0

 Attachments: MAPREDUCE-5569-branch-1.patch, MAPREDUCE-5569-trunk.patch


 The closing split is not calculated correctly:
 {code}
  // Catch any overage and create the closed interval for the last split.
  if (curLower = maxVal || splits.size() == 1) {
splits.add(new DataDrivenDBInputFormat.DataDrivenDBInputSplit(
 -  lowClausePrefix + Double.toString(curUpper),
 +  lowClausePrefix + Double.toString(curLower),
colName +  =  + Double.toString(maxVal)));
  }
 {code}
 For the case of min=5.0, max=7.0, 2 splits, the current code returns splits 
 of (column1 =5.0, column1 6.0), (column1 =7.0, column1 =7.0). The second 
 split is obviously not correct.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (MAPREDUCE-5569) FloatSplitter is not generating correct splits

2013-10-09 Thread Nathan Roberts (JIRA) 

 [ 
https://issues.apache.org/jira/browse/MAPREDUCE-5569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nathan Roberts updated MAPREDUCE-5569:
--

Attachment: MAPREDUCE-5569-branch-1.patch

Added a patch for branch 1. I pulled over a unit test case from MAPREDUCE-5102 
in order to verify. So for branch 1, only this patch is required. For 
branch2/trunk, MAPREDUCE-5102+MAPREDUCE-5569 are required.

 FloatSplitter is not generating correct splits
 --

 Key: MAPREDUCE-5569
 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5569
 Project: Hadoop Map/Reduce
  Issue Type: Bug
Affects Versions: trunk, 2.1.0-beta, 1.3.0, 0.23.9
Reporter: Nathan Roberts
Assignee: Nathan Roberts
 Attachments: MAPREDUCE-5569-branch-1.patch, MAPREDUCE-5569-trunk.patch


 The closing split is not calculated correctly:
 {code}
  // Catch any overage and create the closed interval for the last split.
  if (curLower = maxVal || splits.size() == 1) {
splits.add(new DataDrivenDBInputFormat.DataDrivenDBInputSplit(
 -  lowClausePrefix + Double.toString(curUpper),
 +  lowClausePrefix + Double.toString(curLower),
colName +  =  + Double.toString(maxVal)));
  }
 {code}
 For the case of min=5.0, max=7.0, 2 splits, the current code returns splits 
 of (column1 =5.0, column1 6.0), (column1 =7.0, column1 =7.0). The second 
 split is obviously not correct.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

[jira] [Updated] (MAPREDUCE-5569) FloatSplitter is not generating correct splits

2013-10-09 Thread Jason Lowe (JIRA) 

 [ 
https://issues.apache.org/jira/browse/MAPREDUCE-5569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Lowe updated MAPREDUCE-5569:
--

   Resolution: Fixed
Fix Version/s: 2.2.1
   0.23.10
   1.3.0
   3.0.0
 Hadoop Flags: Reviewed
   Status: Resolved  (was: Patch Available)

Thanks, Nathan!  I committed this to trunk, branch-2, branch-2.2, branch-0.23, 
and branch-1.

 FloatSplitter is not generating correct splits
 --

 Key: MAPREDUCE-5569
 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5569
 Project: Hadoop Map/Reduce
  Issue Type: Bug
Affects Versions: trunk, 2.1.0-beta, 1.3.0, 0.23.9
Reporter: Nathan Roberts
Assignee: Nathan Roberts
 Fix For: 3.0.0, 1.3.0, 0.23.10, 2.2.1

 Attachments: MAPREDUCE-5569-branch-1.patch, MAPREDUCE-5569-trunk.patch


 The closing split is not calculated correctly:
 {code}
  // Catch any overage and create the closed interval for the last split.
  if (curLower = maxVal || splits.size() == 1) {
splits.add(new DataDrivenDBInputFormat.DataDrivenDBInputSplit(
 -  lowClausePrefix + Double.toString(curUpper),
 +  lowClausePrefix + Double.toString(curLower),
colName +  =  + Double.toString(maxVal)));
  }
 {code}
 For the case of min=5.0, max=7.0, 2 splits, the current code returns splits 
 of (column1 =5.0, column1 6.0), (column1 =7.0, column1 =7.0). The second 
 split is obviously not correct.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

[jira] [Updated] (MAPREDUCE-5569) FloatSplitter is not generating correct splits

2013-10-07 Thread Nathan Roberts (JIRA) 

 [ 
https://issues.apache.org/jira/browse/MAPREDUCE-5569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nathan Roberts updated MAPREDUCE-5569:
--

Affects Version/s: 0.23.9

 FloatSplitter is not generating correct splits
 --

 Key: MAPREDUCE-5569
 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5569
 Project: Hadoop Map/Reduce
  Issue Type: Bug
Affects Versions: trunk, 2.1.0-beta, 1.3.0, 0.23.9
Reporter: Nathan Roberts
Assignee: Nathan Roberts

 The closing split is not calculated correctly:
 {code}
  // Catch any overage and create the closed interval for the last split.
  if (curLower = maxVal || splits.size() == 1) {
splits.add(new DataDrivenDBInputFormat.DataDrivenDBInputSplit(
 -  lowClausePrefix + Double.toString(curUpper),
 +  lowClausePrefix + Double.toString(curLower),
colName +  =  + Double.toString(maxVal)));
  }
 {code}
 For the case of min=5.0, max=7.0, 2 splits, the current code returns splits 
 of (column1 =5.0, column1 6.0), (column1 =7.0, column1 =7.0). The second 
 split is obviously not correct.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

[jira] [Updated] (MAPREDUCE-5569) FloatSplitter is not generating correct splits

2013-10-07 Thread Nathan Roberts (JIRA) 

 [ 
https://issues.apache.org/jira/browse/MAPREDUCE-5569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nathan Roberts updated MAPREDUCE-5569:
--

Attachment: MAPREDUCE-5569-trunk.patch

 FloatSplitter is not generating correct splits
 --

 Key: MAPREDUCE-5569
 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5569
 Project: Hadoop Map/Reduce
  Issue Type: Bug
Affects Versions: trunk, 2.1.0-beta, 1.3.0, 0.23.9
Reporter: Nathan Roberts
Assignee: Nathan Roberts
 Attachments: MAPREDUCE-5569-trunk.patch


 The closing split is not calculated correctly:
 {code}
  // Catch any overage and create the closed interval for the last split.
  if (curLower = maxVal || splits.size() == 1) {
splits.add(new DataDrivenDBInputFormat.DataDrivenDBInputSplit(
 -  lowClausePrefix + Double.toString(curUpper),
 +  lowClausePrefix + Double.toString(curLower),
colName +  =  + Double.toString(maxVal)));
  }
 {code}
 For the case of min=5.0, max=7.0, 2 splits, the current code returns splits 
 of (column1 =5.0, column1 6.0), (column1 =7.0, column1 =7.0). The second 
 split is obviously not correct.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

[jira] [Updated] (MAPREDUCE-5569) FloatSplitter is not generating correct splits

2013-10-07 Thread Nathan Roberts (JIRA) 

 [ 
https://issues.apache.org/jira/browse/MAPREDUCE-5569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nathan Roberts updated MAPREDUCE-5569:
--

Status: Patch Available  (was: Open)

Attached patch for trunk. 
Unit tests are part of HADOOP-5102.

 FloatSplitter is not generating correct splits
 --

 Key: MAPREDUCE-5569
 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5569
 Project: Hadoop Map/Reduce
  Issue Type: Bug
Affects Versions: 0.23.9, 2.1.0-beta, trunk, 1.3.0
Reporter: Nathan Roberts
Assignee: Nathan Roberts
 Attachments: MAPREDUCE-5569-trunk.patch


 The closing split is not calculated correctly:
 {code}
  // Catch any overage and create the closed interval for the last split.
  if (curLower = maxVal || splits.size() == 1) {
splits.add(new DataDrivenDBInputFormat.DataDrivenDBInputSplit(
 -  lowClausePrefix + Double.toString(curUpper),
 +  lowClausePrefix + Double.toString(curLower),
colName +  =  + Double.toString(maxVal)));
  }
 {code}
 For the case of min=5.0, max=7.0, 2 splits, the current code returns splits 
 of (column1 =5.0, column1 6.0), (column1 =7.0, column1 =7.0). The second 
 split is obviously not correct.



--
This message was sent by Atlassian JIRA
(v6.1#6144)