[jira] [Work logged] (MAPREDUCE-7342) Non-idempotent test in TestClientRedirect
[ https://issues.apache.org/jira/browse/MAPREDUCE-7342?focusedWorklogId=643246=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-643246 ] ASF GitHub Bot logged work on MAPREDUCE-7342: - Author: ASF GitHub Bot Created on: 29/Aug/21 23:39 Start Date: 29/Aug/21 23:39 Worklog Time Spent: 10m Work Description: aajisaka merged pull request #2968: URL: https://github.com/apache/hadoop/pull/2968 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 643246) Time Spent: 40m (was: 0.5h) > Non-idempotent test in TestClientRedirect > - > > Key: MAPREDUCE-7342 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-7342 > Project: Hadoop Map/Reduce > Issue Type: Test >Reporter: Zhengxi Li >Assignee: Zhengxi Li >Priority: Minor > Labels: pull-request-available > Attachments: MAPREDUCE-7342-master.001.patch > > Time Spent: 40m > Remaining Estimate: 0h > > The test *{{*org.apache.hadoop.mapred.TestClientRedirect.testRedirect}}** is > not idempotent and fail if run twice in the same JVM, because it pollutes > some states shared among tests. It may be good to clean this state pollution > so that some other tests do not fail in the future due to the shared state > polluted by this test. > h3. Detail > Running *{{TestClientRedirect.testRedirect}}* twice would result in the > second run failing due to the following assertion error: > {noformat} > INFO [main] service.AbstractService (AbstractService.java:noteFailure(267)) > - Service test failed in state STARTED > org.apache.hadoop.yarn.exceptions.YarnRuntimeException: > java.net.BindException: > Problem binding to [0.0.0.0:8054] java.net.BindException: Address already in > use > {noformat} > The root cause is that the RM server listening on port 8054) is started in > the first run of this test, but hasn't been stopped when the test finishes. > In the second run, when the test is trying to start the RMService, it fails > because port 8054 is already in use, leading to the exception. > PR link: https://github.com/apache/hadoop/pull/2968 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
[jira] [Work logged] (MAPREDUCE-7342) Non-idempotent test in TestClientRedirect
[ https://issues.apache.org/jira/browse/MAPREDUCE-7342?focusedWorklogId=637922=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-637922 ] ASF GitHub Bot logged work on MAPREDUCE-7342: - Author: ASF GitHub Bot Created on: 14/Aug/21 02:01 Start Date: 14/Aug/21 02:01 Worklog Time Spent: 10m Work Description: lzx404243 commented on pull request #2968: URL: https://github.com/apache/hadoop/pull/2968#issuecomment-898794250 Hi @aajisaka , could you please help reviewing this change? It resolves similar issues as #2499 . Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 637922) Time Spent: 0.5h (was: 20m) > Non-idempotent test in TestClientRedirect > - > > Key: MAPREDUCE-7342 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-7342 > Project: Hadoop Map/Reduce > Issue Type: Test >Reporter: Zhengxi Li >Assignee: Zhengxi Li >Priority: Minor > Labels: pull-request-available > Attachments: MAPREDUCE-7342-master.001.patch > > Time Spent: 0.5h > Remaining Estimate: 0h > > The test *{{*org.apache.hadoop.mapred.TestClientRedirect.testRedirect}}** is > not idempotent and fail if run twice in the same JVM, because it pollutes > some states shared among tests. It may be good to clean this state pollution > so that some other tests do not fail in the future due to the shared state > polluted by this test. > h3. Detail > Running *{{TestClientRedirect.testRedirect}}* twice would result in the > second run failing due to the following assertion error: > {noformat} > INFO [main] service.AbstractService (AbstractService.java:noteFailure(267)) > - Service test failed in state STARTED > org.apache.hadoop.yarn.exceptions.YarnRuntimeException: > java.net.BindException: > Problem binding to [0.0.0.0:8054] java.net.BindException: Address already in > use > {noformat} > The root cause is that the RM server listening on port 8054) is started in > the first run of this test, but hasn't been stopped when the test finishes. > In the second run, when the test is trying to start the RMService, it fails > because port 8054 is already in use, leading to the exception. > PR link: https://github.com/apache/hadoop/pull/2968 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org
[jira] [Work logged] (MAPREDUCE-7342) Non-idempotent test in TestClientRedirect
[ https://issues.apache.org/jira/browse/MAPREDUCE-7342?focusedWorklogId=591869=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-591869 ] ASF GitHub Bot logged work on MAPREDUCE-7342: - Author: ASF GitHub Bot Created on: 01/May/21 12:00 Start Date: 01/May/21 12:00 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on pull request #2968: URL: https://github.com/apache/hadoop/pull/2968#issuecomment-830621028 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexec | 1m 2s | | Docker mode activated. | _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. | | +0 :ok: | codespell | 0m 1s | | codespell was not available. | | +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | | The patch appears to include 1 new or modified test files. | _ trunk Compile Tests _ | | +1 :green_heart: | mvninstall | 34m 26s | | trunk passed | | +1 :green_heart: | compile | 0m 37s | | trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 | | +1 :green_heart: | compile | 0m 33s | | trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 | | +1 :green_heart: | checkstyle | 0m 34s | | trunk passed | | +1 :green_heart: | mvnsite | 0m 37s | | trunk passed | | +1 :green_heart: | javadoc | 0m 28s | | trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 | | +1 :green_heart: | javadoc | 0m 25s | | trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 | | +1 :green_heart: | spotbugs | 0m 49s | | trunk passed | | +1 :green_heart: | shadedclient | 13m 47s | | branch has no errors when building and testing our client artifacts. | _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 0m 30s | | the patch passed | | +1 :green_heart: | compile | 0m 28s | | the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 | | +1 :green_heart: | javac | 0m 28s | | the patch passed | | +1 :green_heart: | compile | 0m 26s | | the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 | | +1 :green_heart: | javac | 0m 26s | | the patch passed | | +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. | | +1 :green_heart: | checkstyle | 0m 25s | | the patch passed | | +1 :green_heart: | mvnsite | 0m 28s | | the patch passed | | +1 :green_heart: | javadoc | 0m 18s | | the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 | | +1 :green_heart: | javadoc | 0m 18s | | the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 | | +1 :green_heart: | spotbugs | 0m 50s | | the patch passed | | +1 :green_heart: | shadedclient | 13m 39s | | patch has no errors when building and testing our client artifacts. | _ Other Tests _ | | +1 :green_heart: | unit | 134m 59s | | hadoop-mapreduce-client-jobclient in the patch passed. | | +1 :green_heart: | asflicense | 0m 41s | | The patch does not generate ASF License warnings. | | | | 207m 59s | | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2968/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/2968 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell | | uname | Linux d8bd48a72748 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/bin/hadoop.sh | | git revision | trunk / bb83171934c16ae3491970fce324fabf2351204c | | Default Java | Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 | | Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08 | | Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2968/1/testReport/ | | Max. process+thread count | 1333 (vs. ulimit of 5500) | | modules | C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient | | Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2968/1/console | | versions
[jira] [Work logged] (MAPREDUCE-7342) Non-idempotent test in TestClientRedirect
[ https://issues.apache.org/jira/browse/MAPREDUCE-7342?focusedWorklogId=591823=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-591823 ] ASF GitHub Bot logged work on MAPREDUCE-7342: - Author: ASF GitHub Bot Created on: 01/May/21 08:30 Start Date: 01/May/21 08:30 Worklog Time Spent: 10m Work Description: lzx404243 opened a new pull request #2968: URL: https://github.com/apache/hadoop/pull/2968 The test `org.apache.hadoop.mapred.TestClientRedirect.testRedirect` is not idempotent and fail if run twice in the same JVM, because it pollutes some states shared among tests. It may be good to clean this state pollution so that some other tests do not fail in the future due to the shared state polluted by this test. ### Detail Running `TestClientRedirect.testRedirect` twice would result in the second run failing due to the following assertion error: ``` INFO [main] service.AbstractService (AbstractService.java:noteFailure(267)) - Service test failed in state STARTED org.apache.hadoop.yarn.exceptions.YarnRuntimeException: java.net.BindException: Problem binding to [0.0.0.0:8054] java.net.BindException: Address already in use ``` The root cause is that the RM server listening on port 8054 is started in the first run of this test, but hasn't been stopped when the test finishes. In the second run, when the test is trying to start the RMService, it fails because port 8054 is already in use, leading to the exception. The suggested fix is to stop the RM server in the added overridden method `RMService.serviceStop()`. With the proposed fix, the test does not pollute the shared state (and passes when run twice in the same JVM). JIRA link: [MAPREDUCE-7342](https://issues.apache.org/jira/browse/MAPREDUCE-7342) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 591823) Remaining Estimate: 0h Time Spent: 10m > Non-idempotent test in TestClientRedirect > - > > Key: MAPREDUCE-7342 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-7342 > Project: Hadoop Map/Reduce > Issue Type: Test >Reporter: Zhengxi Li >Assignee: Zhengxi Li >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > The test *{{*org.apache.hadoop.mapred.TestClientRedirect.testRedirect*}}* is > not idempotent and fail if run twice in the same JVM, because it pollutes > some states shared among tests. It may be good to clean this state pollution > so that some other tests do not fail in the future due to the shared state > polluted by this test. > h3. Detail > Running *{{TestClientRedirect.testRedirect}}* twice would result in the > second run failing due to the following assertion error: > {noformat} > INFO [main] service.AbstractService (AbstractService.java:noteFailure(267)) > - Service test failed in state STARTED > org.apache.hadoop.yarn.exceptions.YarnRuntimeException: > java.net.BindException: > Problem binding to [0.0.0.0:8054] java.net.BindException: Address already in > use > {noformat} > The root cause is that the RM server listening on port 8054) is started in > the first run of this test, but hasn't been stopped when the test finishes. > In the second run, when the test is trying to start the RMService, it fails > because port 8054 is already in use, leading to the exception. > PR link: [TBD] -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: mapreduce-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: mapreduce-issues-h...@hadoop.apache.org