[jira] Commented: (MAPREDUCE-546) Provide sample fair scheduler config file in conf/ and set config file property to point to this by default

2009-07-17 Thread Tom White (JIRA)

[ 
https://issues.apache.org/jira/browse/MAPREDUCE-546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12732468#action_12732468
 ] 

Tom White commented on MAPREDUCE-546:
-

+1

I think having a configuration that works like the other configuration in 
Hadoop is a win for users, even if it is more verbose. And you would get 
improvements like HADOOP-5670 for free. But this is a discussion for another 
Jira - the current patch is fine for now.

 Provide sample fair scheduler config file in conf/ and set config file 
 property to point to this by default
 ---

 Key: MAPREDUCE-546
 URL: https://issues.apache.org/jira/browse/MAPREDUCE-546
 Project: Hadoop Map/Reduce
  Issue Type: New Feature
Reporter: Matei Zaharia
Priority: Minor
 Fix For: 0.21.0

 Attachments: mapreduce-546-v1.patch, mapreduce-546.patch


 The capacity scheduler includes a config file template in hadoop/conf, so it 
 would make sense to create a similar one for the fair scheduler and mention 
 it in the README.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (MAPREDUCE-546) Provide sample fair scheduler config file in conf/ and set config file property to point to this by default

2009-07-08 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/MAPREDUCE-546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12728541#action_12728541
 ] 

Hadoop QA commented on MAPREDUCE-546:
-

-1 overall.  Here are the results of testing the latest attachment 
  
http://issues.apache.org/jira/secure/attachment/12412768/mapreduce-546-v1.patch
  against trunk revision 791909.

+1 @author.  The patch does not contain any @author tags.

-1 tests included.  The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

-1 contrib tests.  The patch failed contrib unit tests.

Test results: 
http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/365/testReport/
Findbugs warnings: 
http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/365/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: 
http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/365/artifact/trunk/build/test/checkstyle-errors.html
Console output: 
http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/365/console

This message is automatically generated.

 Provide sample fair scheduler config file in conf/ and set config file 
 property to point to this by default
 ---

 Key: MAPREDUCE-546
 URL: https://issues.apache.org/jira/browse/MAPREDUCE-546
 Project: Hadoop Map/Reduce
  Issue Type: New Feature
Reporter: Matei Zaharia
Priority: Minor
 Fix For: 0.21.0

 Attachments: mapreduce-546-v1.patch, mapreduce-546.patch


 The capacity scheduler includes a config file template in hadoop/conf, so it 
 would make sense to create a similar one for the fair scheduler and mention 
 it in the README.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (MAPREDUCE-546) Provide sample fair scheduler config file in conf/ and set config file property to point to this by default

2009-07-07 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/MAPREDUCE-546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12727989#action_12727989
 ] 

Hadoop QA commented on MAPREDUCE-546:
-

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12412664/mapreduce-546.patch
  against trunk revision 791418.

+1 @author.  The patch does not contain any @author tags.

-1 tests included.  The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

-1 contrib tests.  The patch failed contrib unit tests.

Test results: 
http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/360/testReport/
Findbugs warnings: 
http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/360/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: 
http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/360/artifact/trunk/build/test/checkstyle-errors.html
Console output: 
http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/360/console

This message is automatically generated.

 Provide sample fair scheduler config file in conf/ and set config file 
 property to point to this by default
 ---

 Key: MAPREDUCE-546
 URL: https://issues.apache.org/jira/browse/MAPREDUCE-546
 Project: Hadoop Map/Reduce
  Issue Type: New Feature
Reporter: Matei Zaharia
Priority: Minor
 Fix For: 0.21.0

 Attachments: mapreduce-546.patch


 The capacity scheduler includes a config file template in hadoop/conf, so it 
 would make sense to create a similar one for the fair scheduler and mention 
 it in the README.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (MAPREDUCE-546) Provide sample fair scheduler config file in conf/ and set config file property to point to this by default

2009-07-07 Thread Tom White (JIRA)

[ 
https://issues.apache.org/jira/browse/MAPREDUCE-546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12728086#action_12728086
 ] 

Tom White commented on MAPREDUCE-546:
-

This looks reasonable to me. Could you use Configuration#getResource(String) or 
is there a classloader problem?

Longer term, it would be nice if the fair scheduler could migrate to using a 
Hadoop Configuration just like the capacity scheduler does.

 Provide sample fair scheduler config file in conf/ and set config file 
 property to point to this by default
 ---

 Key: MAPREDUCE-546
 URL: https://issues.apache.org/jira/browse/MAPREDUCE-546
 Project: Hadoop Map/Reduce
  Issue Type: New Feature
Reporter: Matei Zaharia
Priority: Minor
 Fix For: 0.21.0

 Attachments: mapreduce-546.patch


 The capacity scheduler includes a config file template in hadoop/conf, so it 
 would make sense to create a similar one for the fair scheduler and mention 
 it in the README.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.