D24642: Rework Android APK generation

[Aleix Pol Gonzalez]

apol added a comment.


  +1
  I'd like to see marble devs accepting it.

REPOSITORY
  R34 Marble

REVISION DETAIL
  https://phabricator.kde.org/D24642

To: nicolasfella, #marble
Cc: apol, marble-devel, kde-edu, fbampaloukas, torhamzed, jalvarez, mnafees, 
shentey, chaz6, dkolozsvari, narvaez, cmihalache, rahn, nienhueser

D19228: Fix Android build without WebEngine

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R34 Marble

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19228

To: vkrause, apol
Cc: marble-devel, kde-edu, torhamzed, jalvarez, mnafees, shentey, chaz6, 
dkolozsvari, narvaez, cmihalache, rahn, apol, nienhueser

D16866: Include a comment to the desktop file

[Aleix Pol Gonzalez]

apol added subscribers: aacid, ltoscano.
apol added a comment.


  I'm fine with backporting to 18.12, it would mean there will be a new string 
altogether.
  
  You'll be getting a packaging error now because you were ignoring the 
appstream error this was producing after all.
  
  Ideas @ltoscano or @aacid?

REPOSITORY
  R34 Marble

REVISION DETAIL
  https://phabricator.kde.org/D16866

To: apol, #marble, kossebau, sanjibanb
Cc: ltoscano, aacid, rikmills, marble-devel, kde-edu, torhamzed, jalvarez, 
mnafees, shentey, chaz6, dkolozsvari, narvaez, cmihalache, rahn, apol, 
nienhueser

D16866: Include a comment to the desktop file

[Aleix Pol Gonzalez]

apol closed this revision.

REPOSITORY
  R34 Marble

REVISION DETAIL
  https://phabricator.kde.org/D16866

To: apol, #marble, kossebau, sanjibanb
Cc: marble-devel, kde-edu, torhamzed, jalvarez, mnafees, shentey, chaz6, 
dkolozsvari, narvaez, cmihalache, rahn, apol, nienhueser

D16866: Include a comment to the desktop file

[Aleix Pol Gonzalez]

apol added a comment.


  Related https://phabricator.kde.org/D16867

REPOSITORY
  R34 Marble

REVISION DETAIL
  https://phabricator.kde.org/D16866

To: apol, #marble, kossebau
Cc: marble-devel, kde-edu, torhamzed, jalvarez, mnafees, shentey, chaz6, 
dkolozsvari, narvaez, cmihalache, rahn, apol, nienhueser

D16866: Include a comment to the desktop file

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: Marble, kossebau.
Herald added projects: Marble, KDE Edu.
Herald added subscribers: kde-edu, marble-devel.
apol requested review of this revision.

REVISION SUMMARY
  Otherwise the appstream file won't have a summary and appstream complains.
  
  CCBUG: 400431

REPOSITORY
  R34 Marble

BRANCH
  Applications/18.12

REVISION DETAIL
  https://phabricator.kde.org/D16866

AFFECTED FILES
  src/plasma/wallpapers/worldmap/metadata.desktop

To: apol, #marble, kossebau
Cc: marble-devel, kde-edu, torhamzed, jalvarez, mnafees, shentey, chaz6, 
dkolozsvari, narvaez, cmihalache, rahn, apol, nienhueser

D13404: Make it possible to build Marble with KDE Android tooling

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R34:5893973153c8: Make it possible to build Marble with KDE 
Android tooling (authored by apol).

REPOSITORY
  R34 Marble

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13404?vs=35752=38215

REVISION DETAIL
  https://phabricator.kde.org/D13404

AFFECTED FILES
  src/apps/behaim/CMakeLists.txt
  src/apps/behaim/package/AndroidManifest.xml
  src/apps/marble-maps/CMakeLists.txt
  src/apps/marble-maps/package/AndroidManifest.xml

To: apol, #marble, sanjibanb
Cc: sanjibanb, marble-devel, kde-edu, torhamzed, jalvarez, tjakobi, mnafees, 
shentey, chaz6, dkolozsvari, narvaez, cmihalache, rahn, apol, nienhueser

D13404: Make it possible to build Marble with KDE Android tooling

[Aleix Pol Gonzalez]

apol added a comment.


  > I was just wondering if there is a way to test these changes locally?
  
  Sure!
  https://community.kde.org/Android/Environment_via_Container

INLINE COMMENTS

> sanjibanb wrote in AndroidManifest.xml:22
> Not too important, but can we change it from "Marble" to "MarbleMaps"? This 
> would help distinguish it as the Android app and not the Desktop version.
> 
> Making similar changes in marble-maps/CMakeLists.txt as well would help 
> retain this consistency.

It's the target name. I really don't mind what we call it. Just needs to be the 
same as passed to add_executable.

REPOSITORY
  R34 Marble

REVISION DETAIL
  https://phabricator.kde.org/D13404

To: apol, #marble
Cc: sanjibanb, marble-devel, kde-edu, torhamzed, jalvarez, tjakobi, mnafees, 
shentey, chaz6, dkolozsvari, narvaez, cmihalache, rahn, apol, nienhueser

D13404: Make it possible to build Marble with KDE Android tooling

[Aleix Pol Gonzalez]

apol added a comment.


  Can I please have a review?

REPOSITORY
  R34 Marble

REVISION DETAIL
  https://phabricator.kde.org/D13404

To: apol, #marble
Cc: marble-devel, kde-edu, torhamzed, jalvarez, tjakobi, mnafees, shentey, 
chaz6, dkolozsvari, narvaez, cmihalache, rahn, apol, nienhueser

D13404: Make it possible to build Marble with KDE Android tooling

[Aleix Pol Gonzalez]

apol added a comment.


  Ping

REPOSITORY
  R34 Marble

REVISION DETAIL
  https://phabricator.kde.org/D13404

To: apol, #marble
Cc: marble-devel, kde-edu, torhamzed, jalvarez, tjakobi, mnafees, shentey, 
chaz6, dkolozsvari, narvaez, cmihalache, rahn, apol, nienhueser

D13404: Make it possible to build Marble with KDE Android tooling

[Aleix Pol Gonzalez]

apol added a comment.


  I intentionally left the old logic so it doesn't break your work-flow but it 
should allow to remove quite some code.
  
  Also I didn't really understand what's going on with these python scripts.

REPOSITORY
  R34 Marble

REVISION DETAIL
  https://phabricator.kde.org/D13404

To: apol, #marble
Cc: marble-devel, kde-edu, torhamzed, jalvarez, tjakobi, mnafees, shentey, 
chaz6, dkolozsvari, narvaez, cmihalache, rahn, apol, nienhueser

D13404: Make it possible to build Marble with KDE Android tooling

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Marble.
Restricted Application added projects: Marble, KDE Edu.
Restricted Application added subscribers: kde-edu, marble-devel.
apol requested review of this revision.

REVISION SUMMARY
  It will allow to have it built by the CI and appear on
  binary-factory.kde.org.
  
  Depends on D13403 

REPOSITORY
  R34 Marble

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13404

AFFECTED FILES
  src/apps/behaim/CMakeLists.txt
  src/apps/behaim/package/AndroidManifest.xml
  src/apps/marble-maps/CMakeLists.txt
  src/apps/marble-maps/package/AndroidManifest.xml

To: apol, #marble
Cc: marble-devel, kde-edu, torhamzed, jalvarez, tjakobi, mnafees, shentey, 
chaz6, dkolozsvari, narvaez, cmihalache, rahn, apol, nienhueser

Re: [Marble-devel] Review Request 125176: Cleanup Android build and make compatible with ECM

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125176/#review85218
---


+1

I saw it working, it could make sense to look into using the script for 
generating the apk as well if you want.

- Aleix Pol Gonzalez


On Sept. 11, 2015, 10:37 p.m., Andreas Cord-Landwehr wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125176/
> ---
> 
> (Updated Sept. 11, 2015, 10:37 p.m.)
> 
> 
> Review request for Marble and Aleix Pol Gonzalez.
> 
> 
> Repository: marble
> 
> 
> Description
> ---
> 
> Change to proper use of CMAKE_SYSTEM_NAME, which is required by the ECM 
> toolchain. After this change, Marble-Maps can be build by the command:
> 
> cmake -DCMAKE_TOOLCHAIN_FILE=/path/to/ECM/toolchain/Android.cmake\
>   -DCMAKE_PREFIX_PATH=/path/to/5.5/android_armv7/\
>   -DQT_NO_WEBKIT=TRUE -DQT_NO_PRINTER=TRUE -DQT_NO_DBUS=TRUE ../marble
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 570be7f 
>   src/apps/CMakeLists.txt 5f71ced 
> 
> Diff: https://git.reviewboard.kde.org/r/125176/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andreas Cord-Landwehr
> 
>

___
Marble-devel mailing list
Marble-devel@kde.org
https://mail.kde.org/mailman/listinfo/marble-devel