Re: [Marble-devel] Review Request 119448: View routes as tours
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119448/ --- (Updated July 27, 2014, 12:23 p.m.) Review request for Marble. Changes --- Make checks before using pointers Repository: marble Description --- This patch helps to view a route as a tour, by clicking on a toggled Play/Pause button in the RoutingWidget when a route has been loaded Diffs (updated) - src/lib/marble/SerialTrack.cpp b5d1904 src/lib/marble/TourPlayback.cpp 6682322 src/lib/marble/routing/RoutingWidget.h b0e6b6d src/lib/marble/routing/RoutingWidget.cpp 7abee97 Diff: https://git.reviewboard.kde.org/r/119448/diff/ Testing --- Thanks, Sanjiban Bairagya ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel
Re: [Marble-devel] Review Request 119448: View routes as tours
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119448/ --- (Updated July 27, 2014, 11:55 a.m.) Status -- This change has been marked as submitted. Review request for Marble. Repository: marble Description --- This patch helps to view a route as a tour, by clicking on a toggled Play/Pause button in the RoutingWidget when a route has been loaded Diffs - src/lib/marble/SerialTrack.cpp b5d1904 src/lib/marble/TourPlayback.cpp 6682322 src/lib/marble/routing/RoutingWidget.h b0e6b6d src/lib/marble/routing/RoutingWidget.cpp 7abee97 Diff: https://git.reviewboard.kde.org/r/119448/diff/ Testing --- Thanks, Sanjiban Bairagya ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel
Re: [Marble-devel] Review Request 119448: View routes as tours
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119448/#review63232 --- src/lib/marble/routing/RoutingWidget.cpp https://git.reviewboard.kde.org/r/119448/#comment44016 now that the destructor of TourPlayback calls stop() this is not needed anymore. src/lib/marble/routing/RoutingWidget.cpp https://git.reviewboard.kde.org/r/119448/#comment44017 now that the destructor of TourPlayback calls stop() this is not needed anymore. - Dennis Nienhüser On July 26, 2014, 6:54 p.m., Sanjiban Bairagya wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119448/ --- (Updated July 26, 2014, 6:54 p.m.) Review request for Marble. Repository: marble Description --- This patch helps to view a route as a tour, by clicking on a toggled Play/Pause button in the RoutingWidget when a route has been loaded Diffs - src/lib/marble/TourPlayback.cpp 6682322 src/lib/marble/routing/RoutingWidget.cpp 7abee97 src/lib/marble/routing/RoutingWidget.h b0e6b6d Diff: https://git.reviewboard.kde.org/r/119448/diff/ Testing --- Thanks, Sanjiban Bairagya ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel
Re: [Marble-devel] Review Request 119448: View routes as tours
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119448/ --- (Updated July 24, 2014, 8:10 p.m.) Review request for Marble. Changes --- Fixed issues in previous patch Repository: marble Description --- This patch helps to view a route as a tour, by clicking on a toggled Play/Pause button in the RoutingWidget when a route has been loaded Diffs (updated) - src/lib/marble/routing/RoutingWidget.cpp 7abee97 src/lib/marble/TourPlayback.cpp 6682322 src/lib/marble/routing/RoutingWidget.h b0e6b6d Diff: https://git.reviewboard.kde.org/r/119448/diff/ Testing --- Thanks, Sanjiban Bairagya ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel
Re: [Marble-devel] Review Request 119448: View routes as tours
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119448/ --- (Updated July 24, 2014, 8:55 p.m.) Review request for Marble. Changes --- Fixed memory leak for both the tour and its playback Repository: marble Description --- This patch helps to view a route as a tour, by clicking on a toggled Play/Pause button in the RoutingWidget when a route has been loaded Diffs (updated) - src/lib/marble/TourPlayback.cpp 6682322 src/lib/marble/routing/RoutingWidget.h b0e6b6d src/lib/marble/routing/RoutingWidget.cpp 7abee97 Diff: https://git.reviewboard.kde.org/r/119448/diff/ Testing --- Thanks, Sanjiban Bairagya ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel
Re: [Marble-devel] Review Request 119448: View routes as tours
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119448/#review63095 --- There's no change in zoom yet. This is because centerOn() is connected directly to MarbleWidget's centerOn() slot which ignores any altitude. See TourWidget::centerOn() for a working implementation. When the route is changed, any running/existing tour and tour playback should be stopped and deleted. Currently you can change the route and the old tour will still be played, following the already gone route. src/lib/marble/routing/RoutingWidget.cpp https://git.reviewboard.kde.org/r/119448/#comment43841 Please remove, causes a wrong icon on the very first play click. - Dennis Nienhüser On July 24, 2014, 3:25 p.m., Sanjiban Bairagya wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119448/ --- (Updated July 24, 2014, 3:25 p.m.) Review request for Marble. Repository: marble Description --- This patch helps to view a route as a tour, by clicking on a toggled Play/Pause button in the RoutingWidget when a route has been loaded Diffs - src/lib/marble/TourPlayback.cpp 6682322 src/lib/marble/routing/RoutingWidget.h b0e6b6d src/lib/marble/routing/RoutingWidget.cpp 7abee97 Diff: https://git.reviewboard.kde.org/r/119448/diff/ Testing --- Thanks, Sanjiban Bairagya ___ Marble-devel mailing list Marble-devel@kde.org https://mail.kde.org/mailman/listinfo/marble-devel
