Re: [RFE][PATCH] Display free space on device in panels
Hi Leonard, On Thu, 2006-05-18 at 23:42 +0200, Leonard den Ottolander wrote: On Thu, 2006-05-18 at 16:36 +0300, Pavel Tsekov wrote: Btw if anyone on this list wants to share his thoughts on this patch - now is the time. Personally I don't like the highlighting of the free space indicator. I find it rather distracting. It suffices that the top of the panel is highlighted, no need to highlight that info for the active panel. IMO the conditional attrset (REVERSE_COLOR) etc should be removed. I noticed your reply related to the free space widget highlighting also on bugzilla. I my opinion it makes the look-and-feel of mc more consistent when the free space widget is highlighted. The reasons are: 1) Everything what is written directly to the panel frame is highlighted (current working directory, directory history widget). 2) You are sure that you are looking at the correct free space in the panel you are working in. When it wouldn't be highlighted, you need to look up at the panel title to be sure whether it's active since the the highlighted widgets are on top of the panel. This may save you one eye movement ;) It seems that we need a feedback from someone else whether to highlight or not. If more users are unhappy with the highlighting, I have no problem with removing it. The current version of the patch is applied in FC5 if you want to see how it looks like (highlighted version). Cheers, Jindrich -- Jindrich Novy [EMAIL PROTECTED] ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [RFE][PATCH] Display free space on device in panels
On Fri, 19 May 2006, Jindrich Novy wrote: On Thu, 2006-05-18 at 23:42 +0200, Leonard den Ottolander wrote: On Thu, 2006-05-18 at 16:36 +0300, Pavel Tsekov wrote: Btw if anyone on this list wants to share his thoughts on this patch - now is the time. Personally I don't like the highlighting of the free space indicator. I find it rather distracting. It suffices that the top of the panel is highlighted, no need to highlight that info for the active panel. IMO the conditional attrset (REVERSE_COLOR) etc should be removed. I noticed your reply related to the free space widget highlighting also on bugzilla. I my opinion it makes the look-and-feel of mc more consistent when the free space widget is highlighted. The reasons are: 1) Everything what is written directly to the panel frame is highlighted (current working directory, directory history widget). I second that. 2) You are sure that you are looking at the correct free space in the panel you are working in. When it wouldn't be highlighted, you need to look up at the panel title to be sure whether it's active since the the highlighted widgets are on top of the panel. This may save you one eye movement ;) How about moving the free space indicator to same line on which the panel title is displayed ? How is it implemented in other file managers ? ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [RFE][PATCH] Display free space on device in panels
Hi Pavel, On Fri, 2006-05-19 at 16:07 +0300, Pavel Tsekov wrote: 2) You are sure that you are looking at the correct free space in the panel you are working in. When it wouldn't be highlighted, you need to look up at the panel title to be sure whether it's active since the the highlighted widgets are on top of the panel. This may save you one eye movement ;) How about moving the free space indicator to same line on which the panel title is displayed ? How is it implemented in other file managers ? I was originally inspired by the old czech m602 file manager: http://oldgame.legalne.net/big/images/Manazer-M602.00.120.jpg A bit more talky design was used in the DOS Navigator: http://www.dev0.de/pix/dn151lfnbeta3.png You can see the free space widget is on top in m602. I decided to put it down for mc to have more space for the directory name since the bottom frame of the panel is unused. It could be moved upwards though if more people like it. Cheers, Jindrich -- Jindrich Novy [EMAIL PROTECTED] ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [RFE][PATCH] Display free space on device in panels
Hi Jindrich, On Fri, 2006-05-19 at 17:16 +0200, Jindrich Novy wrote: When it wouldn't be highlighted, you need to look up at the panel title to be sure whether it's active since the the highlighted widgets are on top of the panel. This may save you one eye movement ;) I don't need any eye movement to see which panel is highlighted. Not much of an argument IMO ;p . I decided to put it down for mc to have more space for the directory name since the bottom frame of the panel is unused. It could be moved upwards though if more people like it. At the top it would only take away space for the file name. The positioning is fine with me, it's just the (extra) highlighting that I find distracting. But opinions on this matter differ :) . Leonard. -- mount -t life -o ro /dev/dna /genetic/research ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [RFE][PATCH] Display free space on device in panels
Hello! I was originally inspired by the old czech m602 file manager: http://oldgame.legalne.net/big/images/Manazer-M602.00.120.jpg A bit more talky design was used in the DOS Navigator: http://www.dev0.de/pix/dn151lfnbeta3.png Can we avoid any highlighting? I think Far Manager does it right: http://red-bean.com/proski/mc/far.png -- Regards, Pavel Roskin ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [RFE][PATCH] Display free space on device in panels
On Fri, May 19, 2006 at 02:29:49PM -0400, Pavel Roskin wrote: Hello! I was originally inspired by the old czech m602 file manager: http://oldgame.legalne.net/big/images/Manazer-M602.00.120.jpg A bit more talky design was used in the DOS Navigator: http://www.dev0.de/pix/dn151lfnbeta3.png Can we avoid any highlighting? I think Far Manager does it right: http://red-bean.com/proski/mc/far.png yes, but i definitely prefer the totals above the mini-status. i think that's what they had in earlier times, too. -- Hi! I'm a .signature virus! Copy me into your ~/.signature, please! -- Chaos, panic, and disorder - my work here is done. ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel