Re: utf8 patch for mc, slang 2 version
In non-UTF-8 mode slang2 behaves a bit different than the patched slang1. As a result, mc does work with 8bit encodings, like 8859-2 or KOI8. The attached patch fixes the SLsmg_write_nwchars() function to be fully compatible with the slang1 version and uses it consistently instead of SLsmg_write_char(). It should be applied on top of all the previous patches. Thanks for the patch. The last hunk didn't apply as there's no view_add_character used in editdraw.c. My patch is based on mc-4.6.1 The idea is to replace all occurrences of SLsmg_write_char with the now fixed SLsmg_write_nwchars, because it is the only way that works in all locales. -- Vladimir Nadvornik ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Directory Tree feature
Hello, I find the directory tree feature quite obscure and unusable ? Does anyone here feel the same way ? If this is the case I'd like that we discuss how it could be improved. There are several things which I think make the directory tree totally unusable: * When I invoke the Directory Tree command and the mode is Static I cannot easily navigate trough the directory structure. I'd expect that I'd be able to move around the tree using the arrow keys but it doesn't work this way. To enter a directory and list it contents I have to press Enter which closes the dialog box i.e. I cannot use left and right to navigate the subdirectories. So if I start from the root directory and want to go to /home/ptsekov it will take to invocations of the Directory Tree dialog to do so. * The directory tree remebers its state and if I navigate the directory hierarchy more and more directories become expanded I cannot close them - this makes the tree pretty hard to navigate. * The dynamic mode - I fee totally confused when using it. To some degree it is improvement over the static mode in terms of navigation but all the tree changes just confuse me too much and at some point I just become lost. * The whole dynamic/static mode thing is just too much - I'd prefer a single user friendly mode. ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: utf8 patch for mc, slang 2 version
Hi Vladimir (and others), I've just upgraded to slang-2 in our distro and also updated the UTF-8 patches to mc-4.6.1 (based on SUSE's version). It was easier than I thought it would be. I was glad to see that you had applied plenty of my patches in SUSE (those named 00-*). Please take a look at here again: https://svn.uhulinux.hu/packages/dev/mc/patches/ 00-77 had to be updated to slang-2. When a user searches for a file by ^S, panel-search_buffer is filled up individually with every single byte pressed. Hence it often contains partial UTF-8 string. Displaying it just happened to work with slang-1, but slang-2 prints the partial UTF-8 as C3 or similar. As a result, the cyan box overflows: if you search in the left panel for an existing accented filename, two cyan blocks appear in the right panel. The updated patch first finds the longest valid UTF-8 prefix of the string and only prints that part. You might find 00-79 useful too, it fixes an off-by-one bug introduced by the UTF-8 patches that causes Alt+Backspace to behave differently (erase a whole word and one more character, usually a space) than in bash or in vanilla mc (erase only the word). bye, Egmont ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
