Re: utf8 patch for mc, slang 2 version
On Thu, 15 Jun 2006, Egmont Koblinger wrote: Anyway, there are plenty of apps (e.g. vim, joe) that perfectly support UTF-8 and use ncurses (not the w version). I wonder how it is possible... Because they only use the terminfo (low-level) parts of ncurses, see man 3ncurses terminfo. Those parts do not care about UTF-8. MC uses a higher level part of ncurses (the display routines), but restricted to stdscr. There's an even higher level part of ncurses that supports managing (overlapping) windows, but MC does not use it. SLang (without the newt library) does not support that. So one advantage of using ncurses over slang is that MC could make use of ncurses' windowing code, thereby simplifying its own code. In the way that MC uses SLang and ncurses right now there is very little difference between the two libraries. If you google (groups) for it (Miguel's posts) you'll find that around '95/'96 SLang was preferred over ncurses because it was faster, smaller, and less buggy. But that is no longer the case, there is not much difference now. Bart ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
[bug #16762] Cannot compile mc-2006-06-05-20
Follow-up Comment #20, bug #16762 (project mc): Yeah, great! I can't compile it with tuesday's version, but with yesterday's I can, thanx :] ___ Reply to this item at: http://savannah.gnu.org/bugs/?func=detailitemitem_id=16762 ___ Message sent via/by Savannah http://savannah.gnu.org/ ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Symlink attack in file.c?
Hi, Something I came across a couple of times this week, just now in relation to an RFE regarding file permissions on copying fat files in RHs bugzilla (https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195614): http://cvs.savannah.gnu.org/viewcvs/mc/src/file.c?root=mcr1=1.28r2=1.29 A commit by pavel (Machek?) who added the remark FIXME: You have security hole here, btw. Imagine copying to /tmp and symlink attack :-( Is there anybody that can explain to me what he's concerned about and if that is still an issue? If so this is a rather long standing hole... If not, let's get rid of that warning. Leonard. -- mount -t life -o ro /dev/dna /genetic/research ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
[bug #16829] Crash when formatting paragraph
Update of bug #16829 (project mc): Status: Invalid = None Assigned to:None = leonardjo Open/Closed: Closed = Open Operating System:GNU/Hurd = All ___ Follow-up Comment #3: Turns out to be a general mc issue after all: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194562 Jindrich Novy proposes the following solution: https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=131038 ___ Reply to this item at: http://savannah.gnu.org/bugs/?func=detailitemitem_id=16829 ___ Message sent via/by Savannah http://savannah.gnu.org/ ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
[PATCH] segfault fix while formatting paragraph (alt-p)
Hi,
there's a segfault while formatting a paragraph with alt-p. The
next_word_start() in wordproc.c misses the upper boundary check.
The attached patch fixes it.
References/Reproducer:
http://bugzilla.redhat.com/194562
Jindrich
--- mc/edit/wordproc.c.jn 2005-05-27 05:35:12.0 +0200
+++ mc/edit/wordproc.c 2006-06-16 14:19:38.0 +0200
@@ -198,10 +198,10 @@
}
static int
-next_word_start (unsigned char *t, int q)
+next_word_start (unsigned char *t, int q, int size)
{
int i;
-for (i = q;; i++) {
+for (i = q; i size; i++) {
switch (t[i]) {
case '\n':
return -1;
@@ -220,11 +220,11 @@
/* find the start of a word */
static int
-word_start (unsigned char *t, int q)
+word_start (unsigned char *t, int q, int size)
{
int i = q;
if (t[q] == ' ' || t[q] == '\t')
- return next_word_start (t, q);
+ return next_word_start (t, q, size);
for (;;) {
int c;
if (!i)
@@ -253,9 +253,9 @@
break;
if (t[q] == '\n')
break;
- p = word_start (t, q);
+ p = word_start (t, q, size);
if (p == -1)
- q = next_word_start (t, q); /* Return the end of the word if the beginning
+ q = next_word_start (t, q, size); /* Return the end of the word if the beginning
of the word is at the beginning of a line
(i.e. a very long word) */
else
___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel
Problems with the mailing list ?
Hello, Does anyone miss messages from the mc-devel list ? It seems like some messages do not reach the mailing list at all while others don't reach the mailing list subcsribers. Can anyone confirm or deny this ? Thanks! ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
better [PATCH] segfault fix while formatting paragraph (alt-p)
Hi,
after some refinement I'm sending a better patch that rewrites
next_word_start() and fixes the segfault.
Jindrich
--- mc/edit/wordproc.c.jn 2005-05-27 05:35:12.0 +0200
+++ mc/edit/wordproc.c 2006-06-16 18:48:42.0 +0200
@@ -198,33 +198,25 @@
}
static int
-next_word_start (unsigned char *t, int q)
+next_word_start (unsigned char *t, int q, int size)
{
int i;
-for (i = q;; i++) {
- switch (t[i]) {
- case '\n':
+for (i = q; isize; i++) {
+ if ( t[i] == '\n')
return -1;
- case '\t':
- case ' ':
- for (;; i++) {
- if (t[i] == '\n')
- return -1;
- if (t[i] != ' ' t[i] != '\t')
- return i;
- }
- break;
- }
+ if ( t[i] != ' ' t[i] != '\t')
+ return i;
}
+return -1;
}
/* find the start of a word */
static int
-word_start (unsigned char *t, int q)
+word_start (unsigned char *t, int q, int size)
{
int i = q;
if (t[q] == ' ' || t[q] == '\t')
- return next_word_start (t, q);
+ return next_word_start (t, q, size);
for (;;) {
int c;
if (!i)
@@ -253,9 +245,9 @@
break;
if (t[q] == '\n')
break;
- p = word_start (t, q);
+ p = word_start (t, q, size);
if (p == -1)
- q = next_word_start (t, q); /* Return the end of the word if the beginning
+ q = next_word_start (t, q, size); /* Return the end of the word if the beginning
of the word is at the beginning of a line
(i.e. a very long word) */
else
___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel
mc bugs
hi there, i would like to say i use a lot mc, it's just great. lately i've been updating my website, and i discovered i could edit my document remotely with mc. (cd /#ftp:bleh:[EMAIL PROTECTED] then push f4 key on the document i wish to edit) it's really nice but, i've been experiencing problems, at least with the ftp server i use: when i edit documents it take some time, enough to be disconnected from ftp server. in that case mc just re-log me in and properly save the document .. so far so good, but, after a while working like that, mc seems unable from time to time to connect to the ftp server. i even get seg fault, or it just fail to connect randomly.. when this happen, the only choice left is to quit mc and re-launch it .. i would say, i spend between 1 and 10minutes on a document, and i do lots of em per day (maybe 100 or 200minimum) and i have to restart mc at least 20times... i would say something is wrong in the ftp code inside mc. thanks for your time and efforts, mc is really cool to use. -- Let's start Yahoo! Auction - Free Campaign Now! http://pr.mail.yahoo.co.jp/auction/ ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
