[PATCH] Bad permission highlighting

2006-01-06 Thread Jindrich Novy 
Hello mc-devel,

Andy Shevchenko reported a bug to me for bad permissions highlighting.
I've written a patch for it and it's attached. It's not a big deal but
it fixes the highlighting problem.

For reference:
http://bugzilla.redhat.com/177100

ChangeLog:
2006-01-06  Jindrich Novy  [EMAIL PROTECTED]

* screen.c (add_permission_string): Fix incorrectly shifted
highlighting of permission string.

Thanks,
Jindrich
-- 
Jindrich Novy [EMAIL PROTECTED], http://people.redhat.com/jnovy/
(o_   _o)
//\  The worst evil in the world is refusal to think. //\
V_/_ _\_V

--- mc-4.6.1a/src/screen.c.perm	2006-01-06 13:09:18.0 +0100
+++ mc-4.6.1a/src/screen.c	2006-01-06 13:08:55.0 +0100
@@ -161,7 +161,7 @@ add_permission_string (char *dest, int w
 }
 
 for(i = 0; i  width; i++){
-	if (i = l  i  r){
+	if (i  l  i = r){
 if (attr == SELECTED || attr == MARKED_SELECTED)
 attrset (MARKED_SELECTED_COLOR);
 else
___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

Re: [PATCH] Bad permission highlighting

2006-01-06 Thread Pavel Roskin 
On Fri, 2006-01-06 at 13:32 +0100, Jindrich Novy wrote:
 Hello mc-devel,
 
 Andy Shevchenko reported a bug to me for bad permissions highlighting.
 I've written a patch for it and it's attached. It's not a big deal but
 it fixes the highlighting problem.

Actually, your patch breaks permission highlighting for CVS mc.  The
highlight is shifted to the right.  I tried both perm and mode.

But mc distributed by Fedora (mc-4.6.1a-6) has this problem.  It must be
caused by Red Hat patches.  So, the patch shouldn't be applied to the
original mc sources.  In any case, it would be better to adjust values
of l and r rather than their meaning.

-- 
Regards,
Pavel Roskin

___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel