[PATCH] PHP syntax highlighting broken

[Jindrich Novy]

Hello mc-devel,

the php.syntax file is broken due to bad highlighting definition of
LOG_LOCAL[0-7] symbols.

To reproduce:
F4 on any .php file.

Results: 
Error in file /usr/share/mc//syntax/php.syntax on line 4367

and file is edited without any highlighting. Patch is attached.

Jindrich
-- 
Jindrich Novy [EMAIL PROTECTED], http://people.redhat.com/jnovy/
(o_   _o)
//\  The worst evil in the world is refusal to think. //\
V_/_ _\_V

--- mc-4.6.1a/syntax/php.syntax.phpfix	2005-11-20 15:42:01.0 +0100
+++ mc-4.6.1a/syntax/php.syntax	2005-12-02 11:01:48.0 +0100
@@ -1,5 +1,8 @@
 # PHP syntax file
 
+# 2005-12-02  Jindrich Novy [EMAIL PROTECTED]
+#	* fix highlighting of LOG_LOCALn symbols to make the syntax file work
+
 # 2005-11-20  Leonard den Ottolander leonard den ottolander nl
 #	* regenerated from the docs at http://www.php.net
 
@@ -4364,7 +4367,14 @@
 keyword whole LOG_ERR white
 keyword whole LOG_INFO white
 keyword whole LOG_KERN white
-keyword whole LOG_LOCAL0 ... LOG_LOCAL7 white
+keyword whole LOG_LOCAL0 white
+keyword whole LOG_LOCAL1 white
+keyword whole LOG_LOCAL2 white
+keyword whole LOG_LOCAL3 white
+keyword whole LOG_LOCAL4 white
+keyword whole LOG_LOCAL5 white
+keyword whole LOG_LOCAL6 white
+keyword whole LOG_LOCAL7 white
 keyword whole LOG_LPR white
 keyword whole LOG_MAIL white
 keyword whole LOG_NDELAY white
___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

Re: [PATCH] PHP syntax highlighting broken

[Roland Illig]

Jindrich Novy wrote:

Hello mc-devel,

the php.syntax file is broken due to bad highlighting definition of
LOG_LOCAL[0-7] symbols.

To reproduce:
F4 on any .php file.

Results: 
Error in file /usr/share/mc//syntax/php.syntax on line 4367


and file is edited without any highlighting. Patch is attached.


Committed, Thanks.

I have removed the ChangeLog from the syntax file, and left only a list 
of authors. We don't really need _three_ different ChangeLogs.


Roland
___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

Re: [PATCH] PHP syntax highlighting broken

[Leonard den Ottolander]

Hello Roland, Jindrich,

On Fri, 2005-12-02 at 15:38 +0100, Roland Illig wrote:
  Error in file /usr/share/mc//syntax/php.syntax on line 4367
  and file is edited without any highlighting. Patch is attached.
 
 Committed, Thanks.

Thanks for committing. I should actually have tested that file before
committing ;) .

 I have removed the ChangeLog from the syntax file, and left only a list 
 of authors. We don't really need _three_ different ChangeLogs.

Don't we? The change log might be useful to see why certain (ad hoc)
fixes have been applied. You should have at least discussed this.

Leonard.

-- 
mount -t life -o ro /dev/dna /genetic/research


___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel