date:20170713

[MediaWiki-commits] [Gerrit] mediawiki...parsoid[master]: Write mocha tests for most of jsutils

2017-07-13 Thread TK-999 (Code Review)

TK-999 has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/365068 )

Change subject: Write mocha tests for most of jsutils
..

Write mocha tests for most of jsutils

Tests written for:
* JSUtils.deepFreeze
* JSUtils.deepFreezeButIgnore
* JSUtils.lastItem
* JSUtils.deepEquals
* JSUtils.freezeMap
* JSUtils.freezeSet

Change-Id: I289e8ec8b0c85f231aff9dff05c534b763a32c8a
---
A tests/mocha/jsutils.js
1 file changed, 300 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/parsoid 
refs/changes/68/365068/1

diff --git a/tests/mocha/jsutils.js b/tests/mocha/jsutils.js
new file mode 100644
index 000..3b09084
--- /dev/null
+++ b/tests/mocha/jsutils.js
@@ -0,0 +1,300 @@
+'use strict';
+
+/* eslint no-unused-expressions: off */
+/* global describe, it, Promise */
+require("chai").should();
+
+var JSUtils = require('../../lib/utils/jsutils').JSUtils;
+
+describe('JSUtils', function() {
+   describe('deepFreeze', function() {
+   it('should freeze the passed object', function() {
+   var frozenObject = {
+   anObject: 'withProperty'
+   };
+
+   JSUtils.deepFreeze(frozenObject);
+
+   frozenObject.should.be.frozen;
+   });
+
+   it('should recursively freeze all properties of the passed 
object', function() {
+   var frozenObject = {
+   anObject: {
+   withMultiple: {
+   nestedProperties: {}
+   }
+   }
+   };
+
+   JSUtils.deepFreeze(frozenObject);
+
+   frozenObject.should.be.frozen;
+   frozenObject.anObject.should.be.frozen;
+   frozenObject.anObject.withMultiple.should.be.frozen;
+   
frozenObject.anObject.withMultiple.nestedProperties.should.be.frozen;
+   });
+
+   it('should not freeze prototype properties', function() {
+   var SomeProtoType = function() {};
+   SomeProtoType.prototype.protoProperty = {};
+
+   var TestObject = function() {
+   SomeProtoType.call(this);
+   this.testProperty = {};
+   };
+
+   TestObject.prototype = 
Object.create(SomeProtoType.prototype);
+
+   var frozenTestObject = new TestObject();
+
+   JSUtils.deepFreeze(frozenTestObject);
+
+   frozenTestObject.should.be.frozen;
+   frozenTestObject.testProperty.should.be.frozen;
+   frozenTestObject.protoProperty.should.not.be.frozen;
+   });
+
+   it('should not freeze getters', function() {
+   var frozenObjectWithGetter = {
+   get foo() {
+   return {};
+   },
+   bar: {},
+   };
+
+   JSUtils.deepFreeze(frozenObjectWithGetter);
+
+   frozenObjectWithGetter.foo.should.not.be.frozen;
+   frozenObjectWithGetter.bar.should.be.frozen;
+   });
+   });
+
+   describe('deepFreezeButIgnore', function() {
+   it('should not freeze properties specified in the exclusion 
list', function() {
+   var frozenObject = {
+   propertyToFreeze: {},
+   propertyToExclude: {}
+   };
+
+   var exclusionList = {
+   propertyToExclude: true
+   };
+
+   JSUtils.deepFreezeButIgnore(frozenObject, 
exclusionList);
+
+   frozenObject.propertyToFreeze.should.be.frozen;
+   frozenObject.propertyToExclude.should.not.be.frozen;
+   });
+   });
+
+   describe('lastItem', function() {
+   it('should return the penultimate item when passed a non-empty 
array', function() {
+   var myArray = [5, 6];
+
+   JSUtils.lastItem(myArray).should.equal(6);
+   });
+
+   it('should throw error when passed an empty array', function() {
+   var functionWithEmptyArray = function() {
+   return JSUtils.lastItem([]);
+   };
+
+   functionWithEmptyArray.should.throw;
+   });
+   });
+
+   describe('mapObject', function() {
+

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Revert "db-eqiad.php: Depool db1072"

2017-07-13 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/365202 )

Change subject: Revert "db-eqiad.php: Depool db1072"
..


Revert "db-eqiad.php: Depool db1072"

This reverts commit e9380784e6e38af02ab32d59d819952ad31dd2ea.

Change-Id: I4628e90f42f3de1a7389697e187eb5fc37a9b209
---
M wmf-config/db-eqiad.php
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Marostegui: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/wmf-config/db-eqiad.php b/wmf-config/db-eqiad.php
index 285e1c1..4e91b9a 100644
--- a/wmf-config/db-eqiad.php
+++ b/wmf-config/db-eqiad.php
@@ -99,7 +99,7 @@
'db1055' => 50,  # C2 2.8TB  96GB, watchlist, recentchanges, 
contributions, logpager
'db1065' => 0,   # D1 2.8TB 160GB, vslow, dump, master for 
sanitarium
'db1066' => 10,  # D1 2.8TB 160GB, api
-#  'db1072' => 50,  # B2 2.8TB 160GB, api #T166204
+   'db1072' => 50,  # B2 2.8TB 160GB, api
'db1073' => 50,  # B3 2.8TB 160GB, api
'db1080' => 500, # A2 3.6TB 512GB
'db1083' => 500, # B1 3.6TB 512GB
@@ -261,7 +261,7 @@
],
'api' => [
'db1066' => 1,
-#  'db1072' => 1,
+   'db1072' => 1,
'db1073' => 1,
],
],

-- 
To view, visit https://gerrit.wikimedia.org/r/365202
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4628e90f42f3de1a7389697e187eb5fc37a9b209
Gerrit-PatchSet: 2
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Marostegui 
Gerrit-Reviewer: Florianschmidtwelzow 
Gerrit-Reviewer: Jcrespo 
Gerrit-Reviewer: Marostegui 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Revert "db-eqiad.php: Depool db1072"

2017-07-13 Thread Marostegui (Code Review)

Hello jenkins-bot, Jcrespo,

I'd like you to do a code review.  Please visit

https://gerrit.wikimedia.org/r/365202

to review the following change.


Change subject: Revert "db-eqiad.php: Depool db1072"
..

Revert "db-eqiad.php: Depool db1072"

This reverts commit e9380784e6e38af02ab32d59d819952ad31dd2ea.

Change-Id: I4628e90f42f3de1a7389697e187eb5fc37a9b209
---
M wmf-config/db-eqiad.php
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/02/365202/1

diff --git a/wmf-config/db-eqiad.php b/wmf-config/db-eqiad.php
index 285e1c1..4e91b9a 100644
--- a/wmf-config/db-eqiad.php
+++ b/wmf-config/db-eqiad.php
@@ -99,7 +99,7 @@
'db1055' => 50,  # C2 2.8TB  96GB, watchlist, recentchanges, 
contributions, logpager
'db1065' => 0,   # D1 2.8TB 160GB, vslow, dump, master for 
sanitarium
'db1066' => 10,  # D1 2.8TB 160GB, api
-#  'db1072' => 50,  # B2 2.8TB 160GB, api #T166204
+   'db1072' => 50,  # B2 2.8TB 160GB, api
'db1073' => 50,  # B3 2.8TB 160GB, api
'db1080' => 500, # A2 3.6TB 512GB
'db1083' => 500, # B1 3.6TB 512GB
@@ -261,7 +261,7 @@
],
'api' => [
'db1066' => 1,
-#  'db1072' => 1,
+   'db1072' => 1,
'db1073' => 1,
],
],

-- 
To view, visit https://gerrit.wikimedia.org/r/365202
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4628e90f42f3de1a7389697e187eb5fc37a9b209
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Marostegui 
Gerrit-Reviewer: Jcrespo 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Hygiene: updates diff test results for Media links

2017-07-13 Thread BearND (Code Review)

BearND has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/365201 )

Change subject: Hygiene: updates diff test results for Media links
..

Hygiene: updates diff test results for Media links

Bug: T169293
Change-Id: I3f7d7e7dfdb55a12026e9c6bc2cf5a19bac0f1f5
---
M 
test/diff/results/page_formatted-enwiki-User%3ABSitzmann_(WMF)_MCS_Test_Frankenstein.json
M 
test/diff/results/page_formatted-enwiki-User%3ABSitzmann_(WMF)_MCS_Test_Frankenstein/section4-text.html
M 
test/diff/results/page_mobile-sections-enwiki-User%3ABSitzmann_(WMF)_MCS_Test_Frankenstein.json
M 
test/diff/results/page_mobile-sections-enwiki-User%3ABSitzmann_(WMF)_MCS_Test_Frankenstein/section4-text.html
4 files changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/mobileapps 
refs/changes/01/365201/1

diff --git 
"a/test/diff/results/page_formatted-enwiki-User%3ABSitzmann_\050WMF\051_MCS_Test_Frankenstein.json"
 
"b/test/diff/results/page_formatted-enwiki-User%3ABSitzmann_\050WMF\051_MCS_Test_Frankenstein.json"
index b205e80..d80bea7 100644
--- 
"a/test/diff/results/page_formatted-enwiki-User%3ABSitzmann_\050WMF\051_MCS_Test_Frankenstein.json"
+++ 
"b/test/diff/results/page_formatted-enwiki-User%3ABSitzmann_\050WMF\051_MCS_Test_Frankenstein.json"
@@ -43,7 +43,7 @@
   },
   {
 "id": 4,
-"text": "\nSound\n\n",
+"text": "\nSound\n\n",
 "toclevel": 1,
 "line": "Media",
 "anchor": "Media"
diff --git 
"a/test/diff/results/page_formatted-enwiki-User%3ABSitzmann_\050WMF\051_MCS_Test_Frankenstein/section4-text.html"
 
"b/test/diff/results/page_formatted-enwiki-User%3ABSitzmann_\050WMF\051_MCS_Test_Frankenstein/section4-text.html"
index ce2629e..9f797cf 100644
--- 
"a/test/diff/results/page_formatted-enwiki-User%3ABSitzmann_\050WMF\051_MCS_Test_Frankenstein/section4-text.html"
+++ 
"b/test/diff/results/page_formatted-enwiki-User%3ABSitzmann_\050WMF\051_MCS_Test_Frankenstein/section4-text.html"
@@ -1,2 +1,2 @@
 
-  Sound
+  Sound
diff --git 
"a/test/diff/results/page_mobile-sections-enwiki-User%3ABSitzmann_\050WMF\051_MCS_Test_Frankenstein.json"
 
"b/test/diff/results/page_mobile-sections-enwiki-User%3ABSitzmann_\050WMF\051_MCS_Test_Frankenstein.json"
index 07cf030..7676792 100644
--- 
"a/test/diff/results/page_mobile-sections-enwiki-User%3ABSitzmann_\050WMF\051_MCS_Test_Frankenstein.json"
+++ 
"b/test/diff/results/page_mobile-sections-enwiki-User%3ABSitzmann_\050WMF\051_MCS_Test_Frankenstein.json"
@@ -197,7 +197,7 @@
   },
   {
 "id": 4,
-"text": "\nSound\n\n",
+"text": "\nSound\n\n",
 "toclevel": 1,
 "line": "Media",
 "anchor": "Media"
diff --git 
"a/test/diff/results/page_mobile-sections-enwiki-User%3ABSitzmann_\050WMF\051_MCS_Test_Frankenstein/section4-text.html"
 
"b/test/diff/results/page_mobile-sections-enwiki-User%3ABSitzmann_\050WMF\051_MCS_Test_Frankenstein/section4-text.html"
index ce2629e..9f797cf 100644
--- 
"a/test/diff/results/page_mobile-sections-enwiki-User%3ABSitzmann_\050WMF\051_MCS_Test_Frankenstein/section4-text.html"
+++ 
"b/test/diff/results/page_mobile-sections-enwiki-User%3ABSitzmann_\050WMF\051_MCS_Test_Frankenstein/section4-text.html"
@@ -1,2 +1,2 @@
 
-  Sound
+  Sound

-- 
To view, visit https://gerrit.wikimedia.org/r/365201
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3f7d7e7dfdb55a12026e9c6bc2cf5a19bac0f1f5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/mobileapps
Gerrit-Branch: master
Gerrit-Owner: BearND 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Re-enable MediaWiki.Commenting.FunctionComment.MissingReturn...

2017-07-13 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/364846 )

Change subject: Re-enable MediaWiki.Commenting.FunctionComment.MissingReturn 
sniff
..


Re-enable MediaWiki.Commenting.FunctionComment.MissingReturn sniff

Bug: T168384
Change-Id: I8d7b750503ca9c951267a948862c3685ea036100
---
M includes/PopupsContext.php
M phpcs.xml
2 files changed, 1 insertion(+), 2 deletions(-)

Approvals:
  jenkins-bot: Verified
  Phuedx: Looks good to me, approved



diff --git a/includes/PopupsContext.php b/includes/PopupsContext.php
index d508fb8..e6ffc6a 100644
--- a/includes/PopupsContext.php
+++ b/includes/PopupsContext.php
@@ -149,7 +149,7 @@
/**
 * Are Page previews visible on User Preferences Page
 *
-* return @bool
+* @return bool
 */
public function showPreviewsOptInOnPreferencesPage() {
return !$this->isBetaFeatureEnabled()
diff --git a/phpcs.xml b/phpcs.xml
index ce0878d..d29b557 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -1,7 +1,6 @@
 
 

-   




-- 
To view, visit https://gerrit.wikimedia.org/r/364846
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8d7b750503ca9c951267a948862c3685ea036100
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Pmiazga 
Gerrit-Reviewer: Phuedx 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Revert "Temporarily disable pronunciation tests"

2017-07-13 Thread BearND (Code Review)

BearND has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/365200 )

Change subject: Revert "Temporarily disable pronunciation tests"
..

Revert "Temporarily disable pronunciation tests"

This reverts commit 07ef2e8be08dbdd2c9627ab762711ae1ad233d5f.
But also updated the expected diff test results to account for
changes in Parsoid since then. I notice changes in red link and
redirect links.

Bug: T170325
Change-Id: Ie8017886a4e239abff881bd811c50e55090d2371
---
M spec.yaml
M 
test/diff/results/page_formatted-enwiki-User%3ABSitzmann_(WMF)_MCS_Test_Frankenstein.json
M 
test/diff/results/page_formatted-enwiki-User%3ABSitzmann_(WMF)_MCS_Test_Frankenstein/section4-text.html
M 
test/diff/results/page_mobile-sections-enwiki-User%3ABSitzmann_(WMF)_MCS_Test_Frankenstein.json
M 
test/diff/results/page_mobile-sections-enwiki-User%3ABSitzmann_(WMF)_MCS_Test_Frankenstein/section4-text.html
M test/features/mobile-sections-lead/pagecontent.js
M test/features/mobile-sections/pagecontent-v2.js
M test/features/mobile-sections/pagecontent.js
8 files changed, 13 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/mobileapps 
refs/changes/00/365200/1

diff --git a/spec.yaml b/spec.yaml
index 3618cf5..f414fa0 100644
--- a/spec.yaml
+++ b/spec.yaml
@@ -643,6 +643,8 @@
   editable: /.+/
   languagecount: /.+/
   ns: /.+/
+  pronunciation:
+url: /.+/
   spoken:
 files: [ /.+/ ]
   geo:
diff --git 
"a/test/diff/results/page_formatted-enwiki-User%3ABSitzmann_\050WMF\051_MCS_Test_Frankenstein.json"
 
"b/test/diff/results/page_formatted-enwiki-User%3ABSitzmann_\050WMF\051_MCS_Test_Frankenstein.json"
index b205e80..d80bea7 100644
--- 
"a/test/diff/results/page_formatted-enwiki-User%3ABSitzmann_\050WMF\051_MCS_Test_Frankenstein.json"
+++ 
"b/test/diff/results/page_formatted-enwiki-User%3ABSitzmann_\050WMF\051_MCS_Test_Frankenstein.json"
@@ -43,7 +43,7 @@
   },
   {
 "id": 4,
-"text": "\nSound\n\n",
+"text": "\nSound\n\n",
 "toclevel": 1,
 "line": "Media",
 "anchor": "Media"
diff --git 
"a/test/diff/results/page_formatted-enwiki-User%3ABSitzmann_\050WMF\051_MCS_Test_Frankenstein/section4-text.html"
 
"b/test/diff/results/page_formatted-enwiki-User%3ABSitzmann_\050WMF\051_MCS_Test_Frankenstein/section4-text.html"
index ce2629e..9f797cf 100644
--- 
"a/test/diff/results/page_formatted-enwiki-User%3ABSitzmann_\050WMF\051_MCS_Test_Frankenstein/section4-text.html"
+++ 
"b/test/diff/results/page_formatted-enwiki-User%3ABSitzmann_\050WMF\051_MCS_Test_Frankenstein/section4-text.html"
@@ -1,2 +1,2 @@
 
-  Sound
+  Sound
diff --git 
"a/test/diff/results/page_mobile-sections-enwiki-User%3ABSitzmann_\050WMF\051_MCS_Test_Frankenstein.json"
 
"b/test/diff/results/page_mobile-sections-enwiki-User%3ABSitzmann_\050WMF\051_MCS_Test_Frankenstein.json"
index 07cf030..7676792 100644
--- 
"a/test/diff/results/page_mobile-sections-enwiki-User%3ABSitzmann_\050WMF\051_MCS_Test_Frankenstein.json"
+++ 
"b/test/diff/results/page_mobile-sections-enwiki-User%3ABSitzmann_\050WMF\051_MCS_Test_Frankenstein.json"
@@ -197,7 +197,7 @@
   },
   {
 "id": 4,
-"text": "\nSound\n\n",
+"text": "\nSound\n\n",
 "toclevel": 1,
 "line": "Media",
 "anchor": "Media"
diff --git 
"a/test/diff/results/page_mobile-sections-enwiki-User%3ABSitzmann_\050WMF\051_MCS_Test_Frankenstein/section4-text.html"
 
"b/test/diff/results/page_mobile-sections-enwiki-User%3ABSitzmann_\050WMF\051_MCS_Test_Frankenstein/section4-text.html"
index ce2629e..9f797cf 100644
--- 
"a/test/diff/results/page_mobile-sections-enwiki-User%3ABSitzmann_\050WMF\051_MCS_Test_Frankenstein/section4-text.html"
+++ 
"b/test/diff/results/page_mobile-sections-enwiki-User%3ABSitzmann_\050WMF\051_MCS_Test_Frankenstein/section4-text.html"
@@ -1,2 +1,2 @@
 
-  Sound
+  Sound
diff --git a/test/features/mobile-sections-lead/pagecontent.js 
b/test/features/mobile-sections-lead/pagecontent.js
index af6cae3..3ba753b 100644
--- a/test/features/mobile-sections-lead/pagecontent.js
+++ b/test/features/mobile-sections-lead/pagecontent.js
@@ -136,7 +136,7 @@
 assert.ok(!{}.hasOwnProperty.call(lead, 'geo'));
 });
 });
-it.skip('Barack Obama should have a pronunciation', () => {
+it('Barack Obama should have a pronunciation', () => {
 const title = 'Barack_Obama';
 const uri = 
`${server.config.uri}en.wikipedia.org/v1/page/mobile-sections-lead/${title}`;
 const exp = 
'//upload.wikimedia.org/wikipedia/commons/8/82/En-us-Barack-Hussein-Obama.ogg';
@@ -156,7 +156,7 @@
   'The infobox has not been removed for backwards 
compatibility.');
 });
 });
-it.skip('Enwiki Uranus loads successfully (no pronunciation

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: High density logos for es.wikiversity

2017-07-13 Thread MarcoAurelio (Code Review)

MarcoAurelio has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/365066 )

Change subject: High density logos for es.wikiversity
..

High density logos for es.wikiversity

Bug: T170604
Change-Id: I7a89d81eea12e99be4df861908da2be4acdeaa2d
---
A static/images/project-logos/eswikiversity-1.5x.png
A static/images/project-logos/eswikiversity-2x.png
M wmf-config/InitialiseSettings.php
3 files changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/66/365066/1

diff --git a/static/images/project-logos/eswikiversity-1.5x.png 
b/static/images/project-logos/eswikiversity-1.5x.png
new file mode 100644
index 000..2f98b17
--- /dev/null
+++ b/static/images/project-logos/eswikiversity-1.5x.png
Binary files differ
diff --git a/static/images/project-logos/eswikiversity-2x.png 
b/static/images/project-logos/eswikiversity-2x.png
new file mode 100644
index 000..1813284
--- /dev/null
+++ b/static/images/project-logos/eswikiversity-2x.png
Binary files differ
diff --git a/wmf-config/InitialiseSettings.php 
b/wmf-config/InitialiseSettings.php
index 5d21213..899f0df 100644
--- a/wmf-config/InitialiseSettings.php
+++ b/wmf-config/InitialiseSettings.php
@@ -1430,6 +1430,7 @@
 
# Wikiversity
'cswikiversity' => [ '1.5x' => 
'/static/images/project-logos/cswikiversity-1.5x.png', '2x' => 
'/static/images/project-logos/cswikiversity-2x.png' ], // T150618
+   'eswikiversity' => [ '1.5x' => 
'/static/images/project-logos/eswikiversity-1.5x.png', '2x' => 
'/static/images/project-logos/eswikiversity-2x.png' ], // T170604
 
 # Wikivoyage
'cswikivoyage' => [ '1.5x' => 
'/static/images/project-logos/cswikivoyage-1.5x.png', '2x' => 
'/static/images/project-logos/cswikivoyage-2x.png' ], // T150618

-- 
To view, visit https://gerrit.wikimedia.org/r/365066
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7a89d81eea12e99be4df861908da2be4acdeaa2d
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: MarcoAurelio 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...ContributionTracking[master]: build: Updating mediawiki/mediawiki-codesniffer to 0.10.0

2017-07-13 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/364013 )

Change subject: build: Updating mediawiki/mediawiki-codesniffer to 0.10.0
..


build: Updating mediawiki/mediawiki-codesniffer to 0.10.0

Change-Id: Iced5cd59fc6dfefc5de7060ac8939c2426b9ac46
---
M ApiContributionTracking.php
M ContributionTracking.hooks.php
M ContributionTracking.processor.php
M ContributionTracking_body.php
M composer.json
M phpcs.xml
M special/SpecialFundraiserMaintenance.php
7 files changed, 39 insertions(+), 29 deletions(-)

Approvals:
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/ApiContributionTracking.php b/ApiContributionTracking.php
index 6ed4812..d4c0446 100644
--- a/ApiContributionTracking.php
+++ b/ApiContributionTracking.php
@@ -27,10 +27,9 @@
 * @return array Paramaters ready to be sent off to the processor.
 */
function getStagedParams( $params = null ) {
-
foreach ( $params as $key => $value ) {
if ( $value === '' ) {
-   unset( $params[$key] ); // gotcha. And might I 
add: BOO-URNS.
+   unset( $params[$key] );
}
}
return $params;
@@ -43,9 +42,9 @@
 */
function doReturn( $id, $params ) {
// foreach ($params as $key=>$value){
-   //  if ($value != ''){
-   //  $this->getResult()->addValue(array('returns', 
'parrot'), $key, $value);
-   //  }
+   // if ($value != ''){
+   // $this->getResult()->addValue(array('returns', 'parrot'), 
$key, $value);
+   // }
// }
$params['contribution_tracking_id'] = $id;
 
diff --git a/ContributionTracking.hooks.php b/ContributionTracking.hooks.php
index 5d93f7f..0ead253 100644
--- a/ContributionTracking.hooks.php
+++ b/ContributionTracking.hooks.php
@@ -3,8 +3,8 @@
 class ContributionTrackingHooks {
public static function extensionFunction() {
global $wgDBserver, $wgDBname, $wgDBuser, $wgDBpassword,
-  $wgContributionTrackingDBserver, 
$wgContributionTrackingDBname,
-  $wgContributionTrackingDBuser, 
$wgContributionTrackingDBpassword;
+   $wgContributionTrackingDBserver, 
$wgContributionTrackingDBname,
+   $wgContributionTrackingDBuser, 
$wgContributionTrackingDBpassword;
 
$wgContributionTrackingDBserver = 
$wgContributionTrackingDBserver ?: $wgDBserver;
$wgContributionTrackingDBname = $wgContributionTrackingDBname 
?: $wgDBname;
@@ -49,24 +49,25 @@
$updater->addExtensionUpdate( [ 
'addTable', 'contribution_tracking',
$dir . 
'ContributionTracking.pg.sql', true ] );
}
-   } else { // We are configured not to use the main 
mediawiki db.
+   } else {
+   // We are configured not to use the main 
mediawiki db.
// Unless the updater is modified not to run
// 'LoadExtensionSchemaUpdates' hooks in its 
constructor (or do so
// conditionally), we're going to have to do 
these manually.
$ctDB = 
ContributionTrackingProcessor::contributionTrackingConnection();
-   if ( !$ctDB->tableExists( 
'contribution_tracking' ) ){
+   if ( !$ctDB->tableExists( 
'contribution_tracking' ) ) {
$ctDB->sourceFile( $dir . 
'ContributionTracking.sql' );
}
-   if ( !$ctDB->tableExists( 
'contribution_tracking_owa_ref' ) ){
+   if ( !$ctDB->tableExists( 
'contribution_tracking_owa_ref' ) ) {
$ctDB->sourceFile( $dir . 
'ContributionTracking_OWA_ref.sql' );
}
-   if ( !$ctDB->fieldExists( 
'contribution_tracking', 'owa_session' ) ){
+   if ( !$ctDB->fieldExists( 
'contribution_tracking', 'owa_session' ) ) {
$ctDB->sourceFile( $dir . 
'patches/patch-owa.sql' );
}
-   if ( !$ctDB->fieldExists( 
'contribution_tracking', 'utm_key' ) ){
+   if ( !$ctDB->fieldExists( 
'contribution_tracking', 'utm_key' ) ) {
$ctDB->sourceFile( $dir . 
'patches/patch-utm_key.sql' );
}
-   if (

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Bump src/ to deploy-2017-07-13

2017-07-13 Thread Arlolra (Code Review)

Arlolra has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/365067 )

Change subject: Bump src/ to deploy-2017-07-13
..

Bump src/ to deploy-2017-07-13

Change-Id: I1a459d7fd533b2b8c17c6628894fd893dbceb865
---
M src
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/parsoid/deploy 
refs/changes/67/365067/1

diff --git a/src b/src
index b4187f1..71c0768 16
--- a/src
+++ b/src
@@ -1 +1 @@
-Subproject commit b4187f18321133dff3c62dc74818fc98c6cc9871
+Subproject commit 71c07681db3b6375025c5d8fb3e1ea72b808581e

-- 
To view, visit https://gerrit.wikimedia.org/r/365067
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1a459d7fd533b2b8c17c6628894fd893dbceb865
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/parsoid/deploy
Gerrit-Branch: master
Gerrit-Owner: Arlolra 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/dns[master]: add netmon1003, v4 and v6

2017-07-13 Thread Dzahn (Code Review)

Dzahn has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/365199 )

Change subject: add netmon1003, v4 and v6
..

add netmon1003, v4 and v6

Bug: T170653
Change-Id: I4da3cfeff4d77ba504d1c8e7c63e6cb874bba1c3
---
M templates/1.6.8.0.0.0.0.0.0.2.6.2.ip6.arpa
M templates/154.80.208.in-addr.arpa
M templates/wikimedia.org
3 files changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/dns 
refs/changes/99/365199/1

diff --git a/templates/1.6.8.0.0.0.0.0.0.2.6.2.ip6.arpa 
b/templates/1.6.8.0.0.0.0.0.0.2.6.2.ip6.arpa
index a13a9d5..2efe23c 100644
--- a/templates/1.6.8.0.0.0.0.0.0.2.6.2.ip6.arpa
+++ b/templates/1.6.8.0.0.0.0.0.0.2.6.2.ip6.arpa
@@ -23,6 +23,7 @@
 
 9.4.0.0.4.5.1.0.0.8.0.0.8.0.2.0 1H IN PTR   actinium.wikimedia.org.
 5.0.0.0.4.5.1.0.0.8.0.0.8.0.2.0 1H IN PTR   netmon1002.wikimedia.org.
+6.0.0.0.4.5.1.0.0.8.0.0.8.0.2.0 1H IN PTR   netmon1003.wikimedia.org.
 
 7.1.0.0.4.5.1.0.0.8.0.0.8.0.2.0 1H IN PTR   contint1001.wikimedia.org.
 
diff --git a/templates/154.80.208.in-addr.arpa 
b/templates/154.80.208.in-addr.arpa
index f5536cc..e2b7823 100644
--- a/templates/154.80.208.in-addr.arpa
+++ b/templates/154.80.208.in-addr.arpa
@@ -18,6 +18,7 @@
 2   1H  IN PTR  ae1-1001.cr1-eqiad.wikimedia.org.
 3   1H  IN PTR  ae1-1001.cr2-eqiad.wikimedia.org.
 5   1H  IN PTR  netmon1002.wikimedia.org.
+6   1H  IN PTR  netmon1003.wikimedia.org.
 
 11  1H  IN PTR  dataset1001.wikimedia.org.
 12  1H  IN PTR  labservices1002.wikimedia.org.
diff --git a/templates/wikimedia.org b/templates/wikimedia.org
index ee2ef36..f83256a 100644
--- a/templates/wikimedia.org
+++ b/templates/wikimedia.org
@@ -190,6 +190,8 @@
 netmon1001  1H  IN  2620:0:861:2:208:80:154:159
 netmon1002  1H  IN A208.80.154.5
 netmon1002  1H  IN  2620:0:861:1:208:80:154:5
+netmon1003  1H  IN A208.80.154.6
+netmon1003  1H  IN  2620:0:861:1:208:80:154:6
 netmon2001  1H  IN A208.80.153.110
 netmon2001  1H  IN  2620:0:860:4:208:80:153:110
 pay-lvs1001 1H  IN A208.80.155.2

-- 
To view, visit https://gerrit.wikimedia.org/r/365199
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4da3cfeff4d77ba504d1c8e7c63e6cb874bba1c3
Gerrit-PatchSet: 1
Gerrit-Project: operations/dns
Gerrit-Branch: master
Gerrit-Owner: Dzahn 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] integration/config[master]: Restore ArticleCreationWorkflow

2017-07-13 Thread MaxSem (Code Review)

MaxSem has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/365198 )

Change subject: Restore ArticleCreationWorkflow
..

Restore ArticleCreationWorkflow

The extension is getting rewritten.

Bug: T170354
Change-Id: I33062be79ddb2836f35be094222a00471e169005
---
M zuul/layout.yaml
1 file changed, 3 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/integration/config 
refs/changes/98/365198/1

diff --git a/zuul/layout.yaml b/zuul/layout.yaml
index e2fb31b..0979bb3 100644
--- a/zuul/layout.yaml
+++ b/zuul/layout.yaml
@@ -3897,7 +3897,9 @@
 
   - name: mediawiki/extensions/ArticleCreationWorkflow
 template:
-  - name: archived
+  - name: extension-gate
+  - name: extension-unittests-generic
+  - name: extension-phan-generic
 
   - name: mediawiki/extensions/ArticleIndex
 template:

-- 
To view, visit https://gerrit.wikimedia.org/r/365198
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I33062be79ddb2836f35be094222a00471e169005
Gerrit-PatchSet: 1
Gerrit-Project: integration/config
Gerrit-Branch: master
Gerrit-Owner: MaxSem 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...ArticleCreationWorkflow[master]: Resurrect this extension

2017-07-13 Thread MaxSem (Code Review)

MaxSem has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/365197 )

Change subject: Resurrect this extension
..

Resurrect this extension

This is a complete rewrite. As per task, the special page does nothing for now.

Bug: T170354
Change-Id: I846cc5265d1dcb8ed7214177e3a6121c96df0353
---
A .eslintrc.json
M .gitignore
A ArticleCreationWorkflow.alias.php
D ArticleCreationWorkflow.php
A COPYING
A Gruntfile.js
A composer.json
A extension.json
A i18n/en.json
A i18n/qqq.json
A includes/Hooks.php
A includes/SpecialCreatePage.php
A includes/Workflow.php
A jsduck.json
A package.json
A tests/phan/config.php
A tests/phan/issues/.gitkeep
A tests/phan/stubs/.gitkeep
A tests/phpunit/WorkflowTest.php
19 files changed, 543 insertions(+), 7 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ArticleCreationWorkflow 
refs/changes/97/365197/1

diff --git a/.eslintrc.json b/.eslintrc.json
new file mode 100644
index 000..488ab05
--- /dev/null
+++ b/.eslintrc.json
@@ -0,0 +1,15 @@
+{
+   "extends": "wikimedia",
+   "env": {
+   "browser": true,
+   "jquery": true,
+   "qunit": true
+   },
+   "globals": {
+   "OO": false,
+   "mediaWiki": false
+   },
+   "rules": {
+   "dot-notation": [ "error", { "allowKeywords": true } ]
+   }
+}
diff --git a/.gitignore b/.gitignore
index 98b092a..4aedbf2 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1,4 +1,8 @@
-.svn
+doc
+node_modules
+vendor
+*.log
 *~
 *.kate-swp
 .*.swp
+composer.lock
diff --git a/ArticleCreationWorkflow.alias.php 
b/ArticleCreationWorkflow.alias.php
new file mode 100644
index 000..1abf9b5
--- /dev/null
+++ b/ArticleCreationWorkflow.alias.php
@@ -0,0 +1,15 @@
+ array( 'CreatePage' ),
+);
diff --git a/ArticleCreationWorkflow.php b/ArticleCreationWorkflow.php
deleted file mode 100644
index c79b991..000
--- a/ArticleCreationWorkflow.php
+++ /dev/null
@@ -1,6 +0,0 @@
-https://www.mediawiki.org/wiki/Extension:ArticleCreationWorkflow
- * @Note This extension is archived. Do not use.
- */
diff --git a/COPYING b/COPYING
new file mode 100644
index 000..7bec2e3
--- /dev/null
+++ b/COPYING
@@ -0,0 +1,21 @@
+The MIT License (MIT)
+
+Copyright (c) 2017 Wikimedia contributors
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in
+all copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+THE SOFTWARE.
diff --git a/Gruntfile.js b/Gruntfile.js
new file mode 100644
index 000..e0a034e
--- /dev/null
+++ b/Gruntfile.js
@@ -0,0 +1,52 @@
+/* eslint-env node */
+module.exports = function ( grunt ) {
+   var conf = grunt.file.readJSON( 'extension.json' );
+
+   grunt.loadNpmTasks( 'grunt-banana-checker' );
+   grunt.loadNpmTasks( 'grunt-contrib-watch' );
+   grunt.loadNpmTasks( 'grunt-eslint' );
+   grunt.loadNpmTasks( 'grunt-jsonlint' );
+   grunt.loadNpmTasks( 'grunt-stylelint' );
+
+   grunt.initConfig( {
+   eslint: {
+   src: [
+   '**/*.js',
+   '!node_modules/**',
+   '!vendor/**',
+   '!tests/externals/**',
+   '!docs/**'
+   ]
+   },
+   // Lint – Styling
+   stylelint: {
+   options: {
+   syntax: 'less'
+   },
+   all: [
+   'modules/**/*.css',
+   'modules/**/*.less'
+   ]
+   },
+   banana: conf.MessagesDirs,
+   watch: {
+   files: [
+   '.{stylelintrc,eslintrc.json}',
+   '<%= eslint.all %>',
+   '<%= stylelint.all %>'
+   ],
+   tasks: 'test'
+

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Re-enable MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment....

2017-07-13 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/364851 )

Change subject: Re-enable 
MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment sniff
..


Re-enable MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment sniff

Bug: T168384
Change-Id: Id64269f5950d6da5fee3f18825ce2d713d0446b0
---
M includes/PopupsContext.php
M phpcs.xml
M tests/phpunit/PopupsContextTest.php
3 files changed, 16 insertions(+), 7 deletions(-)

Approvals:
  jenkins-bot: Verified
  Phuedx: Looks good to me, approved



diff --git a/includes/PopupsContext.php b/includes/PopupsContext.php
index f3408b8..390275b 100644
--- a/includes/PopupsContext.php
+++ b/includes/PopupsContext.php
@@ -210,7 +210,8 @@
'pageIdSource' => -1,
'hovercardsSuppressedByGadget' => false,
'pageToken' => wfRandomString(),
-   'sessionToken' => wfRandomString(), // we don't have 
access to mw.user.sessionId()
+   // we don't have access to mw.user.sessionId()
+   'sessionToken' => wfRandomString(),
'action' => 'disabled',
'isAnon' => false,
'popupEnabled' => false,
diff --git a/phpcs.xml b/phpcs.xml
index 26c9398..e105516 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -6,7 +6,6 @@



-   

.

diff --git a/tests/phpunit/PopupsContextTest.php 
b/tests/phpunit/PopupsContextTest.php
index 6ad80d0..7ac4589 100644
--- a/tests/phpunit/PopupsContextTest.php
+++ b/tests/phpunit/PopupsContextTest.php
@@ -225,31 +225,40 @@
 */
public function provideTestDataForTestAreDependenciesMet() {
return [
-   [ // Beta is off, dependencies are met even 
BetaFeatures ext is not available
+   // Beta is off, dependencies are met even BetaFeatures 
ext is not available
+   [
"betaOn" => false,
"textExtracts" => true,
"pageImages" => true,
"betaFeatures" => false,
"expected" => true
-   ], [ // textExtracts dep is missing
+   ],
+   // textExtracts dep is missing
+   [
"betaOn" => false,
"textExtracts" => false,
"pageImages" => true,
"betaFeatures" => false,
"expected" => false
-   ], [ // PageImages dep is missing
+   ],
+   // PageImages dep is missing
+   [
"betaOn" => false,
"textExtracts" => true,
"pageImages" => false,
"betaFeatures" => false,
"expected" => false
-   ], [ // Beta is on but BetaFeatures dep is missing
+   ],
+   // Beta is on but BetaFeatures dep is missing
+   [
"betaOn" => true,
"textExtracts" => true,
"pageImages" => true,
"betaFeatures" => false,
"expected" => false
-   ], [ // beta is on and all deps are available
+   ],
+   // beta is on and all deps are available
+   [
"betaOn" => true,
"textExtracts" => true,
"pageImages" => true,

-- 
To view, visit https://gerrit.wikimedia.org/r/364851
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id64269f5950d6da5fee3f18825ce2d713d0446b0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Pmiazga 
Gerrit-Reviewer: Phuedx 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: [wip] RCFilters: Emphasize UI when saved query is loaded

2017-07-13 Thread Mooeypoo (Code Review)

Mooeypoo has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/365196 )

Change subject: [wip] RCFilters: Emphasize UI when saved query is loaded
..

[wip] RCFilters: Emphasize UI when saved query is loaded

Bug: T169063
Change-Id: Ia300ca7bb4afb7d8e247e57e53ecff826ddf0d7e
---
M 
resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.FilterTagMultiselectWidget.less
M 
resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterTagMultiselectWidget.js
2 files changed, 17 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/96/365196/1

diff --git 
a/resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.FilterTagMultiselectWidget.less
 
b/resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.FilterTagMultiselectWidget.less
index 420bb44..1b17afd 100644
--- 
a/resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.FilterTagMultiselectWidget.less
+++ 
b/resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.FilterTagMultiselectWidget.less
@@ -17,6 +17,14 @@
margin-top: 1.6em;
}
 
+   .oo-ui-tagMultiselectWidget.oo-ui-widget-enabled 
&-emphasize.oo-ui-tagMultiselectWidget-handle {
+   background-color: #eaf3ff !important; // Accent90
+   -webkit-transition: background-color 500ms ease-out 1s;
+   -moz-transition: background-color 500ms ease-out 1s;
+   -o-transition: background-color 500ms ease-out 1s;
+   transition: background-color 500ms ease-out 1s;
+   }
+
&-wrapper {
.mw-rcfilters-ui-table {
margin-top: 0.3em;
@@ -29,7 +37,8 @@
}
 
&-savedQueryTitle {
-   color: #72777d;
+   color: #222; // Base10
+   font-weight: bold;
margin-left: 1em;
}
}
diff --git 
a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterTagMultiselectWidget.js
 
b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterTagMultiselectWidget.js
index dcada85..6405dc7 100644
--- 
a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterTagMultiselectWidget.js
+++ 
b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterTagMultiselectWidget.js
@@ -332,6 +332,8 @@
 */
mw.rcfilters.ui.FilterTagMultiselectWidget.prototype.onModelInitialize 
= function () {
this.setSavedQueryVisibility();
+
+   this.emphasize();
};
 
/**
@@ -588,6 +590,11 @@
}
};
 
+   mw.rcfilters.ui.FilterTagMultiselectWidget.prototype.emphasize = 
function () {
+   this.$handle
+   .removeClass( 
'mw-rcfilters-ui-filterTagMultiselectWidget-emphasize' )
+   .addClass( 
'mw-rcfilters-ui-filterTagMultiselectWidget-emphasize' )
+   };
/**
 * Scroll the element to top within its container
 *

-- 
To view, visit https://gerrit.wikimedia.org/r/365196
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia300ca7bb4afb7d8e247e57e53ecff826ddf0d7e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Mooeypoo 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: ce.MWTransclusionNode: make sure model exists before getting...

2017-07-13 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/365057 )

Change subject: ce.MWTransclusionNode: make sure model exists before getting 
its document
..


ce.MWTransclusionNode: make sure model exists before getting its document

Bug: T168932
Change-Id: Idf18839b1f1fae6eb29621f1950d2b52c99e3433
---
M modules/ve-mw/ce/nodes/ve.ce.MWTransclusionNode.js
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Bartosz Dziewoński: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/ve-mw/ce/nodes/ve.ce.MWTransclusionNode.js 
b/modules/ve-mw/ce/nodes/ve.ce.MWTransclusionNode.js
index 5a37a5f..518601c 100644
--- a/modules/ve-mw/ce/nodes/ve.ce.MWTransclusionNode.js
+++ b/modules/ve-mw/ce/nodes/ve.ce.MWTransclusionNode.js
@@ -155,7 +155,7 @@
}
 
// Work around https://github.com/jquery/jquery/issues/1997
-   contentNodes = $.parseHTML( response.visualeditor.content, 
this.getModelHtmlDocument() ) || [];
+   contentNodes = $.parseHTML( response.visualeditor.content, this.model 
&& this.getModelHtmlDocument() ) || [];
deferred.resolve( this.constructor.static.filterRendering( contentNodes 
) );
 };
 

-- 
To view, visit https://gerrit.wikimedia.org/r/365057
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idf18839b1f1fae6eb29621f1950d2b52c99e3433
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: DLynch 
Gerrit-Reviewer: Bartosz Dziewoński 
Gerrit-Reviewer: Esanders 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: RCFilters: Scroll to top on view switch

2017-07-13 Thread Mooeypoo (Code Review)

Mooeypoo has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/365195 )

Change subject: RCFilters: Scroll to top on view switch
..

RCFilters: Scroll to top on view switch

Bug: T170651
Change-Id: I07376569397651ebee0815c1e1d6e945ef1704dc
---
M resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.MenuSelectWidget.js
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/95/365195/1

diff --git 
a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.MenuSelectWidget.js 
b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.MenuSelectWidget.js
index 2bb0fdf..64b9ac9 100644
--- a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.MenuSelectWidget.js
+++ b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.MenuSelectWidget.js
@@ -210,6 +210,7 @@
.addClass( 
'mw-rcfilters-ui-menuSelectWidget-view-' + viewName );
 
this.currentView = viewName;
+   this.scrollToTop();
this.clip();
}
};

-- 
To view, visit https://gerrit.wikimedia.org/r/365195
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I07376569397651ebee0815c1e1d6e945ef1704dc
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Mooeypoo 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...SideBarMenu[master]: build: ignore extensions folder

2017-07-13 Thread Umherirrender (Code Review)

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/365070 )

Change subject: build: ignore extensions folder
..

build: ignore extensions folder

The build result is stored in extensions folder and should not shown as
unstashed files

Change-Id: Iecf99ede96125bbea321f756d13c921929ed11c5
---
M .gitignore
M composer.json
2 files changed, 5 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SideBarMenu 
refs/changes/70/365070/1

diff --git a/.gitignore b/.gitignore
index 039a014..f19b4b2 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1,4 +1,6 @@
-node_modules/
-vendor/
+/node_modules
+/vendor
+/composer.lock
+/extensions
 
 .idea
diff --git a/composer.json b/composer.json
index 066fa50..e3d6ff4 100644
--- a/composer.json
+++ b/composer.json
@@ -31,7 +31,7 @@
},
"scripts": {
"test": [
-   "parallel-lint . --exclude vendor"
+   "parallel-lint . --exclude vendor --exclude 
node_modules --exclude extensions"
]
}
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/365070
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iecf99ede96125bbea321f756d13c921929ed11c5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SideBarMenu
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] wikimedia...golden[master]: Fix sister search traffic query

2017-07-13 Thread Chelsyx (Code Review)

Chelsyx has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/365190 )

Change subject: Fix sister search traffic query
..


Fix sister search traffic query

- Creates a new category in the 'language' column for
  French and Catalan since they have their own sister
  search sidebar that shows up in addition to ours.
- Makes some adjustments for how SERPs are detected.

We'll need to clear out the current data and do a full
recount with this query. Since the backfill is only
from 2017-06-01, we should be OK as the original data
should still be present.

Bug: T164854, T170183
Change-Id: Ic21aeac43891ebb1b65696fe8e907bb959a4d7b7
---
M modules/metrics/search/sister_search_traffic
1 file changed, 11 insertions(+), 6 deletions(-)

Approvals:
  Chelsyx: Verified; Looks good to me, approved



diff --git a/modules/metrics/search/sister_search_traffic 
b/modules/metrics/search/sister_search_traffic
index 3dc2852..76c091c 100755
--- a/modules/metrics/search/sister_search_traffic
+++ b/modules/metrics/search/sister_search_traffic
@@ -12,8 +12,12 @@
  WHEN 'species' THEN 'wikispecies'
  ELSE normalized_host.project_class
 END AS project,
-IF(normalized_host.project IN('commons', 'meta', 'simple', 'incubator', 
'species'), '',
-   IF(normalized_host.project = 'en', 'English', 'Other languages')) AS 
language,
+CASE WHEN normalized_host.project IN('commons', 'meta', 'simple', 
'incubator', 'species') THEN ''
+ WHEN normalized_host.project = 'en' THEN 'English'
+ -- frwiki and cawiki use homebrew sister search that shows up in 
addition to ours
+ WHEN normalized_host.project IN('ca', 'fr') THEN 'French and Catalan'
+ ELSE 'Other languages'
+END AS language,
 -- flag for pageviews that are search results pages (e.g. if user clicked 
to see more results from a sister project):
 (
   page_id IS NULL
@@ -22,8 +26,8 @@
 OR (
   uri_path = '/w/index.php'
   AND (
-uri_query RLIKE '^\?search\='
-OR INSTR(uri_query, '?title=Special:Search=') > 0
+PARSE_URL(CONCAT('http://', uri_host, uri_path, uri_query), 
'QUERY', 'search') IS NOT NULL
+OR PARSE_URL(CONCAT('http://', uri_host, uri_path, uri_query), 
'QUERY', 'searchToken') IS NOT NULL
   )
 )
   )
@@ -34,10 +38,11 @@
 AND CONCAT(year, '-', LPAD(month, 2, '0'), '-', LPAD(day, 2, '0')) >= '$1'
 AND CONCAT(year, '-', LPAD(month, 2, '0'), '-', LPAD(day, 2, '0')) < '$2'
 AND is_pageview
+-- only those that have been referred by a search results page on a 
wikipedia:
 AND referer_class = 'internal'
 AND (
-  INSTR(referer, '/w/index.php?search=') > 0
-  OR INSTR(referer, '/wiki/Special:Search?search=') > 0
+  PARSE_URL(referer, 'QUERY', 'search') IS NOT NULL
+  OR PARSE_URL(referer, 'QUERY', 'searchToken') IS NOT NULL
 )
 -- warning: comparing uri_host = PARSE_URL(referer, 'HOST') would mark 
'en.m.wikipedia.org' as a sister of 'en.wikipedia.org'
 AND normalize_host(PARSE_URL(referer, 'HOST')).project_class = 'wikipedia'

-- 
To view, visit https://gerrit.wikimedia.org/r/365190
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic21aeac43891ebb1b65696fe8e907bb959a4d7b7
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/discovery/golden
Gerrit-Branch: master
Gerrit-Owner: Bearloga 
Gerrit-Reviewer: Chelsyx 
Gerrit-Reviewer: EBernhardson 
Gerrit-Reviewer: HaeB 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Revert "all wikis to 1.30.0-wmf.9"

2017-07-13 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/365194 )

Change subject: Revert "all wikis to 1.30.0-wmf.9"
..


Revert "all wikis to 1.30.0-wmf.9"

This reverts commit 34d9761984f6db2b8ff90856834324bcee85c7bf.

Change-Id: I9d5b5de7a48cdddaa1491ea5f37723115c0cc6c4
---
M wikiversions.json
1 file changed, 304 insertions(+), 304 deletions(-)

Approvals:
  Thcipriani: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/wikiversions.json b/wikiversions.json
index e3a0cbd..1a15c6a 100644
--- a/wikiversions.json
+++ b/wikiversions.json
@@ -1,40 +1,40 @@
 {
-"aawiki": "php-1.30.0-wmf.9",
+"aawiki": "php-1.30.0-wmf.7",
 "aawikibooks": "php-1.30.0-wmf.9",
 "aawiktionary": "php-1.30.0-wmf.9",
-"abwiki": "php-1.30.0-wmf.9",
+"abwiki": "php-1.30.0-wmf.7",
 "abwiktionary": "php-1.30.0-wmf.9",
-"acewiki": "php-1.30.0-wmf.9",
+"acewiki": "php-1.30.0-wmf.7",
 "advisorywiki": "php-1.30.0-wmf.9",
-"adywiki": "php-1.30.0-wmf.9",
-"afwiki": "php-1.30.0-wmf.9",
+"adywiki": "php-1.30.0-wmf.7",
+"afwiki": "php-1.30.0-wmf.7",
 "afwikibooks": "php-1.30.0-wmf.9",
 "afwikiquote": "php-1.30.0-wmf.9",
 "afwiktionary": "php-1.30.0-wmf.9",
-"akwiki": "php-1.30.0-wmf.9",
+"akwiki": "php-1.30.0-wmf.7",
 "akwikibooks": "php-1.30.0-wmf.9",
 "akwiktionary": "php-1.30.0-wmf.9",
-"alswiki": "php-1.30.0-wmf.9",
+"alswiki": "php-1.30.0-wmf.7",
 "alswikibooks": "php-1.30.0-wmf.9",
 "alswikiquote": "php-1.30.0-wmf.9",
 "alswiktionary": "php-1.30.0-wmf.9",
-"amwiki": "php-1.30.0-wmf.9",
+"amwiki": "php-1.30.0-wmf.7",
 "amwikiquote": "php-1.30.0-wmf.9",
 "amwiktionary": "php-1.30.0-wmf.9",
-"angwiki": "php-1.30.0-wmf.9",
+"angwiki": "php-1.30.0-wmf.7",
 "angwikibooks": "php-1.30.0-wmf.9",
 "angwikiquote": "php-1.30.0-wmf.9",
 "angwikisource": "php-1.30.0-wmf.9",
 "angwiktionary": "php-1.30.0-wmf.9",
-"anwiki": "php-1.30.0-wmf.9",
+"anwiki": "php-1.30.0-wmf.7",
 "anwiktionary": "php-1.30.0-wmf.9",
-"arbcom_cswiki": "php-1.30.0-wmf.9",
-"arbcom_dewiki": "php-1.30.0-wmf.9",
-"arbcom_enwiki": "php-1.30.0-wmf.9",
-"arbcom_fiwiki": "php-1.30.0-wmf.9",
-"arbcom_nlwiki": "php-1.30.0-wmf.9",
-"arcwiki": "php-1.30.0-wmf.9",
-"arwiki": "php-1.30.0-wmf.9",
+"arbcom_cswiki": "php-1.30.0-wmf.7",
+"arbcom_dewiki": "php-1.30.0-wmf.7",
+"arbcom_enwiki": "php-1.30.0-wmf.7",
+"arbcom_fiwiki": "php-1.30.0-wmf.7",
+"arbcom_nlwiki": "php-1.30.0-wmf.7",
+"arcwiki": "php-1.30.0-wmf.7",
+"arwiki": "php-1.30.0-wmf.7",
 "arwikibooks": "php-1.30.0-wmf.9",
 "arwikimedia": "php-1.30.0-wmf.9",
 "arwikinews": "php-1.30.0-wmf.9",
@@ -42,81 +42,81 @@
 "arwikisource": "php-1.30.0-wmf.9",
 "arwikiversity": "php-1.30.0-wmf.9",
 "arwiktionary": "php-1.30.0-wmf.9",
-"arzwiki": "php-1.30.0-wmf.9",
-"astwiki": "php-1.30.0-wmf.9",
+"arzwiki": "php-1.30.0-wmf.7",
+"astwiki": "php-1.30.0-wmf.7",
 "astwikibooks": "php-1.30.0-wmf.9",
 "astwikiquote": "php-1.30.0-wmf.9",
 "astwiktionary": "php-1.30.0-wmf.9",
-"aswiki": "php-1.30.0-wmf.9",
+"aswiki": "php-1.30.0-wmf.7",
 "aswikibooks": "php-1.30.0-wmf.9",
 "aswikisource": "php-1.30.0-wmf.9",
 "aswiktionary": "php-1.30.0-wmf.9",
-"atjwiki": "php-1.30.0-wmf.9",
+"atjwiki": "php-1.30.0-wmf.7",
 "auditcomwiki": "php-1.30.0-wmf.9",
-"avwiki": "php-1.30.0-wmf.9",
+"avwiki": "php-1.30.0-wmf.7",
 "avwiktionary": "php-1.30.0-wmf.9",
-"aywiki": "php-1.30.0-wmf.9",
+"aywiki": "php-1.30.0-wmf.7",
 "aywikibooks": "php-1.30.0-wmf.9",
 "aywiktionary": "php-1.30.0-wmf.9",
-"azbwiki": "php-1.30.0-wmf.9",
-"azwiki": "php-1.30.0-wmf.9",
+"azbwiki": "php-1.30.0-wmf.7",
+"azwiki": "php-1.30.0-wmf.7",
 "azwikibooks": "php-1.30.0-wmf.9",
 "azwikiquote": "php-1.30.0-wmf.9",
 "azwikisource": "php-1.30.0-wmf.9",
 "azwiktionary": "php-1.30.0-wmf.9",
-"barwiki": "php-1.30.0-wmf.9",
-"bat_smgwiki": "php-1.30.0-wmf.9",
-"bawiki": "php-1.30.0-wmf.9",
+"barwiki": "php-1.30.0-wmf.7",
+"bat_smgwiki": "php-1.30.0-wmf.7",
+"bawiki": "php-1.30.0-wmf.7",
 "bawikibooks": "php-1.30.0-wmf.9",
-"bclwiki": "php-1.30.0-wmf.9",
+"bclwiki": "php-1.30.0-wmf.7",
 "bdwikimedia": "php-1.30.0-wmf.9",
-"be_x_oldwiki": "php-1.30.0-wmf.9",
+"be_x_oldwiki": "php-1.30.0-wmf.7",
 "betawikiversity": "php-1.30.0-wmf.9",
-"bewiki": "php-1.30.0-wmf.9",
+"bewiki": "php-1.30.0-wmf.7",
 "bewikibooks": "php-1.30.0-wmf.9",
 "bewikimedia": "php-1.30.0-wmf.9",
 "bewikiquote": "php-1.30.0-wmf.9",
 "bewikisource": "php-1.30.0-wmf.9",
 "bewiktionary": "php-1.30.0-wmf.9",
-"bgwiki": "php-1.30.0-wmf.9",
+"bgwiki": "php-1.30.0-wmf.7",
 "bgwikibooks":

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Revert "all wikis to 1.30.0-wmf.9"

2017-07-13 Thread Thcipriani (Code Review)

Thcipriani has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/365194 )

Change subject: Revert "all wikis to 1.30.0-wmf.9"
..

Revert "all wikis to 1.30.0-wmf.9"

This reverts commit 34d9761984f6db2b8ff90856834324bcee85c7bf.

Change-Id: I9d5b5de7a48cdddaa1491ea5f37723115c0cc6c4
---
M wikiversions.json
1 file changed, 304 insertions(+), 304 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/94/365194/1

diff --git a/wikiversions.json b/wikiversions.json
index e3a0cbd..1a15c6a 100644
--- a/wikiversions.json
+++ b/wikiversions.json
@@ -1,40 +1,40 @@
 {
-"aawiki": "php-1.30.0-wmf.9",
+"aawiki": "php-1.30.0-wmf.7",
 "aawikibooks": "php-1.30.0-wmf.9",
 "aawiktionary": "php-1.30.0-wmf.9",
-"abwiki": "php-1.30.0-wmf.9",
+"abwiki": "php-1.30.0-wmf.7",
 "abwiktionary": "php-1.30.0-wmf.9",
-"acewiki": "php-1.30.0-wmf.9",
+"acewiki": "php-1.30.0-wmf.7",
 "advisorywiki": "php-1.30.0-wmf.9",
-"adywiki": "php-1.30.0-wmf.9",
-"afwiki": "php-1.30.0-wmf.9",
+"adywiki": "php-1.30.0-wmf.7",
+"afwiki": "php-1.30.0-wmf.7",
 "afwikibooks": "php-1.30.0-wmf.9",
 "afwikiquote": "php-1.30.0-wmf.9",
 "afwiktionary": "php-1.30.0-wmf.9",
-"akwiki": "php-1.30.0-wmf.9",
+"akwiki": "php-1.30.0-wmf.7",
 "akwikibooks": "php-1.30.0-wmf.9",
 "akwiktionary": "php-1.30.0-wmf.9",
-"alswiki": "php-1.30.0-wmf.9",
+"alswiki": "php-1.30.0-wmf.7",
 "alswikibooks": "php-1.30.0-wmf.9",
 "alswikiquote": "php-1.30.0-wmf.9",
 "alswiktionary": "php-1.30.0-wmf.9",
-"amwiki": "php-1.30.0-wmf.9",
+"amwiki": "php-1.30.0-wmf.7",
 "amwikiquote": "php-1.30.0-wmf.9",
 "amwiktionary": "php-1.30.0-wmf.9",
-"angwiki": "php-1.30.0-wmf.9",
+"angwiki": "php-1.30.0-wmf.7",
 "angwikibooks": "php-1.30.0-wmf.9",
 "angwikiquote": "php-1.30.0-wmf.9",
 "angwikisource": "php-1.30.0-wmf.9",
 "angwiktionary": "php-1.30.0-wmf.9",
-"anwiki": "php-1.30.0-wmf.9",
+"anwiki": "php-1.30.0-wmf.7",
 "anwiktionary": "php-1.30.0-wmf.9",
-"arbcom_cswiki": "php-1.30.0-wmf.9",
-"arbcom_dewiki": "php-1.30.0-wmf.9",
-"arbcom_enwiki": "php-1.30.0-wmf.9",
-"arbcom_fiwiki": "php-1.30.0-wmf.9",
-"arbcom_nlwiki": "php-1.30.0-wmf.9",
-"arcwiki": "php-1.30.0-wmf.9",
-"arwiki": "php-1.30.0-wmf.9",
+"arbcom_cswiki": "php-1.30.0-wmf.7",
+"arbcom_dewiki": "php-1.30.0-wmf.7",
+"arbcom_enwiki": "php-1.30.0-wmf.7",
+"arbcom_fiwiki": "php-1.30.0-wmf.7",
+"arbcom_nlwiki": "php-1.30.0-wmf.7",
+"arcwiki": "php-1.30.0-wmf.7",
+"arwiki": "php-1.30.0-wmf.7",
 "arwikibooks": "php-1.30.0-wmf.9",
 "arwikimedia": "php-1.30.0-wmf.9",
 "arwikinews": "php-1.30.0-wmf.9",
@@ -42,81 +42,81 @@
 "arwikisource": "php-1.30.0-wmf.9",
 "arwikiversity": "php-1.30.0-wmf.9",
 "arwiktionary": "php-1.30.0-wmf.9",
-"arzwiki": "php-1.30.0-wmf.9",
-"astwiki": "php-1.30.0-wmf.9",
+"arzwiki": "php-1.30.0-wmf.7",
+"astwiki": "php-1.30.0-wmf.7",
 "astwikibooks": "php-1.30.0-wmf.9",
 "astwikiquote": "php-1.30.0-wmf.9",
 "astwiktionary": "php-1.30.0-wmf.9",
-"aswiki": "php-1.30.0-wmf.9",
+"aswiki": "php-1.30.0-wmf.7",
 "aswikibooks": "php-1.30.0-wmf.9",
 "aswikisource": "php-1.30.0-wmf.9",
 "aswiktionary": "php-1.30.0-wmf.9",
-"atjwiki": "php-1.30.0-wmf.9",
+"atjwiki": "php-1.30.0-wmf.7",
 "auditcomwiki": "php-1.30.0-wmf.9",
-"avwiki": "php-1.30.0-wmf.9",
+"avwiki": "php-1.30.0-wmf.7",
 "avwiktionary": "php-1.30.0-wmf.9",
-"aywiki": "php-1.30.0-wmf.9",
+"aywiki": "php-1.30.0-wmf.7",
 "aywikibooks": "php-1.30.0-wmf.9",
 "aywiktionary": "php-1.30.0-wmf.9",
-"azbwiki": "php-1.30.0-wmf.9",
-"azwiki": "php-1.30.0-wmf.9",
+"azbwiki": "php-1.30.0-wmf.7",
+"azwiki": "php-1.30.0-wmf.7",
 "azwikibooks": "php-1.30.0-wmf.9",
 "azwikiquote": "php-1.30.0-wmf.9",
 "azwikisource": "php-1.30.0-wmf.9",
 "azwiktionary": "php-1.30.0-wmf.9",
-"barwiki": "php-1.30.0-wmf.9",
-"bat_smgwiki": "php-1.30.0-wmf.9",
-"bawiki": "php-1.30.0-wmf.9",
+"barwiki": "php-1.30.0-wmf.7",
+"bat_smgwiki": "php-1.30.0-wmf.7",
+"bawiki": "php-1.30.0-wmf.7",
 "bawikibooks": "php-1.30.0-wmf.9",
-"bclwiki": "php-1.30.0-wmf.9",
+"bclwiki": "php-1.30.0-wmf.7",
 "bdwikimedia": "php-1.30.0-wmf.9",
-"be_x_oldwiki": "php-1.30.0-wmf.9",
+"be_x_oldwiki": "php-1.30.0-wmf.7",
 "betawikiversity": "php-1.30.0-wmf.9",
-"bewiki": "php-1.30.0-wmf.9",
+"bewiki": "php-1.30.0-wmf.7",
 "bewikibooks": "php-1.30.0-wmf.9",
 "bewikimedia": "php-1.30.0-wmf.9",
 "bewikiquote": "php-1.30.0-wmf.9",
 "bewikisource": "php-1.30.0-wmf.9",
 "bewiktionary": "php-1.30.0-wmf.9",
-"bgwiki": "php-1.30.0-wmf.9",
+"bgwiki": "php-1.30.0-wmf.7",

[MediaWiki-commits] [Gerrit] mediawiki...MinervaNeue[master]: Add tooling for svg size checking

2017-07-13 Thread Jdlrobson (Code Review)

Jdlrobson has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/365193 )

Change subject: Add tooling for svg size checking
..

Add tooling for svg size checking

Bug: T170639
Change-Id: Ibcd5c29340d16c9cffc6e2eb90d33ee89b69874f
---
A dev_scripts/svg_check.sh
M package.json
2 files changed, 19 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/MinervaNeue 
refs/changes/93/365193/1

diff --git a/dev_scripts/svg_check.sh b/dev_scripts/svg_check.sh
new file mode 100755
index 000..3c7ef64
--- /dev/null
+++ b/dev_scripts/svg_check.sh
@@ -0,0 +1,17 @@
+#!/usr/bin/env bash
+found=0
+
+for svgfile in `find resources -type f -name "*.svg"`; do
+  outfile="$svgfile.tmp"
+  node_modules/.bin/svgo --config .svgo.yml -i $svgfile -o $outfile -q
+  if [ $(wc -c $svgfile | awk '{print $1}') -gt $(wc -c $outfile | awk '{print 
$1}') ]; then
+echo "File $svgfile is not compressed"
+found=$((found + 1))
+  fi
+  rm $outfile
+done
+
+if [ $found -gt 0 ]; then
+  echo "Found $found uncompressed SVG files. Please compress the files and 
re-submit the patch"
+  exit 1
+fi
\ No newline at end of file
diff --git a/package.json b/package.json
index 9ae3ac4..7184a14 100644
--- a/package.json
+++ b/package.json
@@ -1,13 +1,13 @@
 {
"private": true,
"scripts": {
-   "test": "grunt test"
+   "test": "grunt test && dev-scripts/svg_check.sh"
},
"dependencies": {
"svgo": ">=0.4.4"
},
"devDependencies": {
-   "eslint-config-wikimedia": "0.3.0",
+   "eslint-config-wikimedia": "0.4.0",
"grunt": "^1.0.1",
"grunt-banana-checker": "^0.5.0",
"grunt-contrib-watch": "^1.0.0",

-- 
To view, visit https://gerrit.wikimedia.org/r/365193
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibcd5c29340d16c9cffc6e2eb90d33ee89b69874f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/MinervaNeue
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Refactor: DRY and document

2017-07-13 Thread Jdlrobson (Code Review)

Jdlrobson has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/365192 )

Change subject: Refactor: DRY and document
..

Refactor: DRY and document

Pull repeated methods into their own private functions

Change-Id: I8c2a136ff55e9f810b8d443221fd267bd3e7df2c
---
M routes/mobile-sections.js
1 file changed, 45 insertions(+), 14 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/mobileapps 
refs/changes/92/365192/1

diff --git a/routes/mobile-sections.js b/routes/mobile-sections.js
index 9b8f720..5d86cf9 100644
--- a/routes/mobile-sections.js
+++ b/routes/mobile-sections.js
@@ -273,7 +273,7 @@
  * @param {!Response} res
  * @return {!Promise}
  */
-function handleNamespaceAndSpecialCases(req, res) {
+function _handleNamespaceAndSpecialCases(req, res) {
 const ns = res.meta.ns;
 if (res.meta.mainpage) {
 return mainPageFixPromise(req, res);
@@ -286,6 +286,24 @@
 }
 
 /*
+ * Creates a raw object representing a page in preparation
+ * for further massaging
+ * @param {!Request} req
+ * @param {?Boolean} [legacy] when true MCS will
+ *  not apply legacy transformations that we are in the process
+ *  of deprecating.
+ * @return {!BBPromise}
+ */
+function _collectRawPageData(req, legacy) {
+return BBPromise.props({
+page: parsoid.pageContentPromise(app, req, legacy),
+meta: pageMetadataPromise(req)
+}).then((interimState) => {
+return _handleNamespaceAndSpecialCases(req, interimState);
+});
+}
+
+/*
  * @param {!Request} req
  * @param {!Response} res
  * @param {?Boolean} [legacy] when true MCS will
@@ -294,12 +312,7 @@
  * @return {!BBPromise}
  */
 function buildAllResponse(req, res, legacy) {
-return BBPromise.props({
-page: parsoid.pageContentPromise(app, req, legacy),
-meta: pageMetadataPromise(req)
-}).then((response) => {
-return handleNamespaceAndSpecialCases(req, response);
-}).then((response) => {
+return _collectRawPageData(req, legacy).then((response) => {
 response = buildAll(response, legacy);
 res.status(200);
 mUtil.setETag(res, response.lead.revision);
@@ -308,14 +321,32 @@
 });
 }
 
+/*
+ * Builds an object which gives structure to the lead of an article
+ * providing access to metadata.
+ * @param {!Request} req
+ * @param {?Boolean} [legacy] when true MCS will
+ *  not apply legacy transformations that we are in the process
+ *  of deprecating.
+ * @return {!BBPromise}
+ */
+function buildLeadObject(req, legacy) {
+return _collectRawPageData(req, legacy).then((lead) => {
+return buildLead(lead, legacy);
+});
+}
+
+/*
+ * Responds with the lead content of a page in structured form.
+ * @param {!Request} req
+ * @param {!Response} res
+ * @param {?Boolean} [legacy] when true MCS will
+ *  not apply legacy transformations that we are in the process
+ *  of deprecating.
+ * @return {!BBPromise}
+ */
 function buildLeadResponse(req, res, legacy) {
-return BBPromise.props({
-page: parsoid.pageContentPromise(app, req, legacy),
-meta: pageMetadataPromise(req)
-}).then((response) => {
-return handleNamespaceAndSpecialCases(req, response);
-}).then((response) => {
-response = buildLead(response, legacy);
+return buildLeadObject(req, legacy).then((response) => {
 res.status(200);
 mUtil.setETag(res, response.revision);
 mUtil.setContentType(res, mUtil.CONTENT_TYPES.mobileSections);

-- 
To view, visit https://gerrit.wikimedia.org/r/365192
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8c2a136ff55e9f810b8d443221fd267bd3e7df2c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/mobileapps
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Refactor: Generalise hideRedLinks

2017-07-13 Thread Jdlrobson (Code Review)

Jdlrobson has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/365191 )

Change subject: Refactor: Generalise hideRedLinks
..

Refactor: Generalise hideRedLinks

hideRedLinks can be generalised to flatten any kind of element
This will be extremely useful for the proposed HTML summary
endpoint web is planning.

Additional changes:
* hideRedLinks is no longer exported as an object

Change-Id: I708b81b450876470a2132be985c9b53a007b78b2
---
A lib/transformations/flattenElements.js
M lib/transformations/hideRedLinks.js
M lib/transforms.js
3 files changed, 35 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/mobileapps 
refs/changes/91/365191/1

diff --git a/lib/transformations/flattenElements.js 
b/lib/transformations/flattenElements.js
new file mode 100644
index 000..cb938f8
--- /dev/null
+++ b/lib/transformations/flattenElements.js
@@ -0,0 +1,30 @@
+/**
+ * DOM transformation shared with app. Let's keep this in sync with the app.
+ * Last sync: Android repo 3d5b441 www/js/transforms/hideRedLinks.js
+ *
+ * The main change from the original Android app file is to use
+ * content.createElement() instead of document.createElement().
+ */
+
+'use strict';
+
+/**
+ * Replace all elements in Document `content` that match the
+ * css selector, replacing them with span tags.
+ * @param {!Document} content
+ * @param {?string} selector
+ */
+function flattenElements(content, selector) {
+const elements = content.querySelectorAll(selector || 'a');
+for (let i = 0; i < elements.length; i++) {
+const element = elements[i];
+const replacementSpan = content.createElement('span');
+replacementSpan.innerHTML = element.innerHTML;
+if (element.getAttribute('class')) {
+replacementSpan.setAttribute('class', 
element.getAttribute('class'));
+}
+element.parentNode.replaceChild(replacementSpan, element);
+}
+}
+
+module.exports = flattenElements;
diff --git a/lib/transformations/hideRedLinks.js 
b/lib/transformations/hideRedLinks.js
index b0355d6..b910196 100644
--- a/lib/transformations/hideRedLinks.js
+++ b/lib/transformations/hideRedLinks.js
@@ -7,16 +7,10 @@
  */
 
 'use strict';
+const flattenElements = require('./flattenElements');
 
 function hideRedLinks(content) {
-const redLinks = content.querySelectorAll('a.new');
-for (let i = 0; i < redLinks.length; i++) {
-const redLink = redLinks[i];
-const replacementSpan = content.createElement('span');
-replacementSpan.innerHTML = redLink.innerHTML;
-replacementSpan.setAttribute('class', redLink.getAttribute('class'));
-redLink.parentNode.replaceChild(replacementSpan, redLink);
-}
+flattenElements(content, 'a.new');
 }
 
 module.exports = {
diff --git a/lib/transforms.js b/lib/transforms.js
index 23d0248..be7ff1e 100644
--- a/lib/transforms.js
+++ b/lib/transforms.js
@@ -15,6 +15,7 @@
 const extractInfobox = require('./transformations/extractInfobox');
 const extractPageIssues = require('./transformations/extractPageIssues');
 const extractLeadIntroduction = 
require('./transformations/extractLeadIntroduction');
+const flattenElements = require('./transformations/flattenElements');
 
 const transforms = {};
 
@@ -271,7 +272,7 @@
  * Destructive, non-Parsoid-specific transforms previously performed in the 
app.
  */
 function _removeUnwantedWikiContentForApp(doc, legacy) {
-hideRedLinks.hideRedLinks(doc);
+hideRedLinks(doc);
 hideIPA.hideIPA(doc, legacy);
 }
 
@@ -341,5 +342,6 @@
 transforms.extractInfobox = extractInfobox;
 transforms.extractPageIssues = extractPageIssues;
 transforms.extractLeadIntroduction = extractLeadIntroduction;
+transforms.flattenElements = flattenElements;
 
 module.exports = transforms;

-- 
To view, visit https://gerrit.wikimedia.org/r/365191
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I708b81b450876470a2132be985c9b53a007b78b2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/mobileapps
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] wikimedia...golden[master]: Fix sister search traffic query

2017-07-13 Thread Bearloga (Code Review)

Bearloga has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/365190 )

Change subject: Fix sister search traffic query
..

Fix sister search traffic query

- Creates a new category in the 'language' column for
  French and Catalan since they have their own sister
  search sidebar that shows up in addition to ours.
- Makes some adjustments for how SERPs are detected.

We'll need to clear out the current data and do a full
recount with this query. Since the backfill is only
from 2017-06-01, we should be OK as the original data
should still be present.

Bug: T164854, T170183
Change-Id: Ic21aeac43891ebb1b65696fe8e907bb959a4d7b7
---
M modules/metrics/search/sister_search_traffic
1 file changed, 11 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/wikimedia/discovery/golden 
refs/changes/90/365190/1

diff --git a/modules/metrics/search/sister_search_traffic 
b/modules/metrics/search/sister_search_traffic
index 3dc2852..76c091c 100755
--- a/modules/metrics/search/sister_search_traffic
+++ b/modules/metrics/search/sister_search_traffic
@@ -12,8 +12,12 @@
  WHEN 'species' THEN 'wikispecies'
  ELSE normalized_host.project_class
 END AS project,
-IF(normalized_host.project IN('commons', 'meta', 'simple', 'incubator', 
'species'), '',
-   IF(normalized_host.project = 'en', 'English', 'Other languages')) AS 
language,
+CASE WHEN normalized_host.project IN('commons', 'meta', 'simple', 
'incubator', 'species') THEN ''
+ WHEN normalized_host.project = 'en' THEN 'English'
+ -- frwiki and cawiki use homebrew sister search that shows up in 
addition to ours
+ WHEN normalized_host.project IN('ca', 'fr') THEN 'French and Catalan'
+ ELSE 'Other languages'
+END AS language,
 -- flag for pageviews that are search results pages (e.g. if user clicked 
to see more results from a sister project):
 (
   page_id IS NULL
@@ -22,8 +26,8 @@
 OR (
   uri_path = '/w/index.php'
   AND (
-uri_query RLIKE '^\?search\='
-OR INSTR(uri_query, '?title=Special:Search=') > 0
+PARSE_URL(CONCAT('http://', uri_host, uri_path, uri_query), 
'QUERY', 'search') IS NOT NULL
+OR PARSE_URL(CONCAT('http://', uri_host, uri_path, uri_query), 
'QUERY', 'searchToken') IS NOT NULL
   )
 )
   )
@@ -34,10 +38,11 @@
 AND CONCAT(year, '-', LPAD(month, 2, '0'), '-', LPAD(day, 2, '0')) >= '$1'
 AND CONCAT(year, '-', LPAD(month, 2, '0'), '-', LPAD(day, 2, '0')) < '$2'
 AND is_pageview
+-- only those that have been referred by a search results page on a 
wikipedia:
 AND referer_class = 'internal'
 AND (
-  INSTR(referer, '/w/index.php?search=') > 0
-  OR INSTR(referer, '/wiki/Special:Search?search=') > 0
+  PARSE_URL(referer, 'QUERY', 'search') IS NOT NULL
+  OR PARSE_URL(referer, 'QUERY', 'searchToken') IS NOT NULL
 )
 -- warning: comparing uri_host = PARSE_URL(referer, 'HOST') would mark 
'en.m.wikipedia.org' as a sister of 'en.wikipedia.org'
 AND normalize_host(PARSE_URL(referer, 'HOST')).project_class = 'wikipedia'

-- 
To view, visit https://gerrit.wikimedia.org/r/365190
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic21aeac43891ebb1b65696fe8e907bb959a4d7b7
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/discovery/golden
Gerrit-Branch: master
Gerrit-Owner: Bearloga 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: all wikis to 1.30.0-wmf.9

2017-07-13 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/365189 )

Change subject: all wikis to 1.30.0-wmf.9
..


all wikis to 1.30.0-wmf.9

Change-Id: If49d9b407cb790275bd3d45da28eeaae1ab5e38b
---
M wikiversions.json
1 file changed, 304 insertions(+), 304 deletions(-)

Approvals:
  Thcipriani: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/wikiversions.json b/wikiversions.json
index 1a15c6a..e3a0cbd 100644
--- a/wikiversions.json
+++ b/wikiversions.json
@@ -1,40 +1,40 @@
 {
-"aawiki": "php-1.30.0-wmf.7",
+"aawiki": "php-1.30.0-wmf.9",
 "aawikibooks": "php-1.30.0-wmf.9",
 "aawiktionary": "php-1.30.0-wmf.9",
-"abwiki": "php-1.30.0-wmf.7",
+"abwiki": "php-1.30.0-wmf.9",
 "abwiktionary": "php-1.30.0-wmf.9",
-"acewiki": "php-1.30.0-wmf.7",
+"acewiki": "php-1.30.0-wmf.9",
 "advisorywiki": "php-1.30.0-wmf.9",
-"adywiki": "php-1.30.0-wmf.7",
-"afwiki": "php-1.30.0-wmf.7",
+"adywiki": "php-1.30.0-wmf.9",
+"afwiki": "php-1.30.0-wmf.9",
 "afwikibooks": "php-1.30.0-wmf.9",
 "afwikiquote": "php-1.30.0-wmf.9",
 "afwiktionary": "php-1.30.0-wmf.9",
-"akwiki": "php-1.30.0-wmf.7",
+"akwiki": "php-1.30.0-wmf.9",
 "akwikibooks": "php-1.30.0-wmf.9",
 "akwiktionary": "php-1.30.0-wmf.9",
-"alswiki": "php-1.30.0-wmf.7",
+"alswiki": "php-1.30.0-wmf.9",
 "alswikibooks": "php-1.30.0-wmf.9",
 "alswikiquote": "php-1.30.0-wmf.9",
 "alswiktionary": "php-1.30.0-wmf.9",
-"amwiki": "php-1.30.0-wmf.7",
+"amwiki": "php-1.30.0-wmf.9",
 "amwikiquote": "php-1.30.0-wmf.9",
 "amwiktionary": "php-1.30.0-wmf.9",
-"angwiki": "php-1.30.0-wmf.7",
+"angwiki": "php-1.30.0-wmf.9",
 "angwikibooks": "php-1.30.0-wmf.9",
 "angwikiquote": "php-1.30.0-wmf.9",
 "angwikisource": "php-1.30.0-wmf.9",
 "angwiktionary": "php-1.30.0-wmf.9",
-"anwiki": "php-1.30.0-wmf.7",
+"anwiki": "php-1.30.0-wmf.9",
 "anwiktionary": "php-1.30.0-wmf.9",
-"arbcom_cswiki": "php-1.30.0-wmf.7",
-"arbcom_dewiki": "php-1.30.0-wmf.7",
-"arbcom_enwiki": "php-1.30.0-wmf.7",
-"arbcom_fiwiki": "php-1.30.0-wmf.7",
-"arbcom_nlwiki": "php-1.30.0-wmf.7",
-"arcwiki": "php-1.30.0-wmf.7",
-"arwiki": "php-1.30.0-wmf.7",
+"arbcom_cswiki": "php-1.30.0-wmf.9",
+"arbcom_dewiki": "php-1.30.0-wmf.9",
+"arbcom_enwiki": "php-1.30.0-wmf.9",
+"arbcom_fiwiki": "php-1.30.0-wmf.9",
+"arbcom_nlwiki": "php-1.30.0-wmf.9",
+"arcwiki": "php-1.30.0-wmf.9",
+"arwiki": "php-1.30.0-wmf.9",
 "arwikibooks": "php-1.30.0-wmf.9",
 "arwikimedia": "php-1.30.0-wmf.9",
 "arwikinews": "php-1.30.0-wmf.9",
@@ -42,81 +42,81 @@
 "arwikisource": "php-1.30.0-wmf.9",
 "arwikiversity": "php-1.30.0-wmf.9",
 "arwiktionary": "php-1.30.0-wmf.9",
-"arzwiki": "php-1.30.0-wmf.7",
-"astwiki": "php-1.30.0-wmf.7",
+"arzwiki": "php-1.30.0-wmf.9",
+"astwiki": "php-1.30.0-wmf.9",
 "astwikibooks": "php-1.30.0-wmf.9",
 "astwikiquote": "php-1.30.0-wmf.9",
 "astwiktionary": "php-1.30.0-wmf.9",
-"aswiki": "php-1.30.0-wmf.7",
+"aswiki": "php-1.30.0-wmf.9",
 "aswikibooks": "php-1.30.0-wmf.9",
 "aswikisource": "php-1.30.0-wmf.9",
 "aswiktionary": "php-1.30.0-wmf.9",
-"atjwiki": "php-1.30.0-wmf.7",
+"atjwiki": "php-1.30.0-wmf.9",
 "auditcomwiki": "php-1.30.0-wmf.9",
-"avwiki": "php-1.30.0-wmf.7",
+"avwiki": "php-1.30.0-wmf.9",
 "avwiktionary": "php-1.30.0-wmf.9",
-"aywiki": "php-1.30.0-wmf.7",
+"aywiki": "php-1.30.0-wmf.9",
 "aywikibooks": "php-1.30.0-wmf.9",
 "aywiktionary": "php-1.30.0-wmf.9",
-"azbwiki": "php-1.30.0-wmf.7",
-"azwiki": "php-1.30.0-wmf.7",
+"azbwiki": "php-1.30.0-wmf.9",
+"azwiki": "php-1.30.0-wmf.9",
 "azwikibooks": "php-1.30.0-wmf.9",
 "azwikiquote": "php-1.30.0-wmf.9",
 "azwikisource": "php-1.30.0-wmf.9",
 "azwiktionary": "php-1.30.0-wmf.9",
-"barwiki": "php-1.30.0-wmf.7",
-"bat_smgwiki": "php-1.30.0-wmf.7",
-"bawiki": "php-1.30.0-wmf.7",
+"barwiki": "php-1.30.0-wmf.9",
+"bat_smgwiki": "php-1.30.0-wmf.9",
+"bawiki": "php-1.30.0-wmf.9",
 "bawikibooks": "php-1.30.0-wmf.9",
-"bclwiki": "php-1.30.0-wmf.7",
+"bclwiki": "php-1.30.0-wmf.9",
 "bdwikimedia": "php-1.30.0-wmf.9",
-"be_x_oldwiki": "php-1.30.0-wmf.7",
+"be_x_oldwiki": "php-1.30.0-wmf.9",
 "betawikiversity": "php-1.30.0-wmf.9",
-"bewiki": "php-1.30.0-wmf.7",
+"bewiki": "php-1.30.0-wmf.9",
 "bewikibooks": "php-1.30.0-wmf.9",
 "bewikimedia": "php-1.30.0-wmf.9",
 "bewikiquote": "php-1.30.0-wmf.9",
 "bewikisource": "php-1.30.0-wmf.9",
 "bewiktionary": "php-1.30.0-wmf.9",
-"bgwiki": "php-1.30.0-wmf.7",
+"bgwiki": "php-1.30.0-wmf.9",
 "bgwikibooks": "php-1.30.0-wmf.9",
 "bgwikinews": "php-1.30.0-wmf.9",
 "bgwikiquote":

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: all wikis to 1.30.0-wmf.9

2017-07-13 Thread Thcipriani (Code Review)

Thcipriani has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/365189 )

Change subject: all wikis to 1.30.0-wmf.9
..

all wikis to 1.30.0-wmf.9

Change-Id: If49d9b407cb790275bd3d45da28eeaae1ab5e38b
---
M wikiversions.json
1 file changed, 304 insertions(+), 304 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/89/365189/1

diff --git a/wikiversions.json b/wikiversions.json
index 1a15c6a..e3a0cbd 100644
--- a/wikiversions.json
+++ b/wikiversions.json
@@ -1,40 +1,40 @@
 {
-"aawiki": "php-1.30.0-wmf.7",
+"aawiki": "php-1.30.0-wmf.9",
 "aawikibooks": "php-1.30.0-wmf.9",
 "aawiktionary": "php-1.30.0-wmf.9",
-"abwiki": "php-1.30.0-wmf.7",
+"abwiki": "php-1.30.0-wmf.9",
 "abwiktionary": "php-1.30.0-wmf.9",
-"acewiki": "php-1.30.0-wmf.7",
+"acewiki": "php-1.30.0-wmf.9",
 "advisorywiki": "php-1.30.0-wmf.9",
-"adywiki": "php-1.30.0-wmf.7",
-"afwiki": "php-1.30.0-wmf.7",
+"adywiki": "php-1.30.0-wmf.9",
+"afwiki": "php-1.30.0-wmf.9",
 "afwikibooks": "php-1.30.0-wmf.9",
 "afwikiquote": "php-1.30.0-wmf.9",
 "afwiktionary": "php-1.30.0-wmf.9",
-"akwiki": "php-1.30.0-wmf.7",
+"akwiki": "php-1.30.0-wmf.9",
 "akwikibooks": "php-1.30.0-wmf.9",
 "akwiktionary": "php-1.30.0-wmf.9",
-"alswiki": "php-1.30.0-wmf.7",
+"alswiki": "php-1.30.0-wmf.9",
 "alswikibooks": "php-1.30.0-wmf.9",
 "alswikiquote": "php-1.30.0-wmf.9",
 "alswiktionary": "php-1.30.0-wmf.9",
-"amwiki": "php-1.30.0-wmf.7",
+"amwiki": "php-1.30.0-wmf.9",
 "amwikiquote": "php-1.30.0-wmf.9",
 "amwiktionary": "php-1.30.0-wmf.9",
-"angwiki": "php-1.30.0-wmf.7",
+"angwiki": "php-1.30.0-wmf.9",
 "angwikibooks": "php-1.30.0-wmf.9",
 "angwikiquote": "php-1.30.0-wmf.9",
 "angwikisource": "php-1.30.0-wmf.9",
 "angwiktionary": "php-1.30.0-wmf.9",
-"anwiki": "php-1.30.0-wmf.7",
+"anwiki": "php-1.30.0-wmf.9",
 "anwiktionary": "php-1.30.0-wmf.9",
-"arbcom_cswiki": "php-1.30.0-wmf.7",
-"arbcom_dewiki": "php-1.30.0-wmf.7",
-"arbcom_enwiki": "php-1.30.0-wmf.7",
-"arbcom_fiwiki": "php-1.30.0-wmf.7",
-"arbcom_nlwiki": "php-1.30.0-wmf.7",
-"arcwiki": "php-1.30.0-wmf.7",
-"arwiki": "php-1.30.0-wmf.7",
+"arbcom_cswiki": "php-1.30.0-wmf.9",
+"arbcom_dewiki": "php-1.30.0-wmf.9",
+"arbcom_enwiki": "php-1.30.0-wmf.9",
+"arbcom_fiwiki": "php-1.30.0-wmf.9",
+"arbcom_nlwiki": "php-1.30.0-wmf.9",
+"arcwiki": "php-1.30.0-wmf.9",
+"arwiki": "php-1.30.0-wmf.9",
 "arwikibooks": "php-1.30.0-wmf.9",
 "arwikimedia": "php-1.30.0-wmf.9",
 "arwikinews": "php-1.30.0-wmf.9",
@@ -42,81 +42,81 @@
 "arwikisource": "php-1.30.0-wmf.9",
 "arwikiversity": "php-1.30.0-wmf.9",
 "arwiktionary": "php-1.30.0-wmf.9",
-"arzwiki": "php-1.30.0-wmf.7",
-"astwiki": "php-1.30.0-wmf.7",
+"arzwiki": "php-1.30.0-wmf.9",
+"astwiki": "php-1.30.0-wmf.9",
 "astwikibooks": "php-1.30.0-wmf.9",
 "astwikiquote": "php-1.30.0-wmf.9",
 "astwiktionary": "php-1.30.0-wmf.9",
-"aswiki": "php-1.30.0-wmf.7",
+"aswiki": "php-1.30.0-wmf.9",
 "aswikibooks": "php-1.30.0-wmf.9",
 "aswikisource": "php-1.30.0-wmf.9",
 "aswiktionary": "php-1.30.0-wmf.9",
-"atjwiki": "php-1.30.0-wmf.7",
+"atjwiki": "php-1.30.0-wmf.9",
 "auditcomwiki": "php-1.30.0-wmf.9",
-"avwiki": "php-1.30.0-wmf.7",
+"avwiki": "php-1.30.0-wmf.9",
 "avwiktionary": "php-1.30.0-wmf.9",
-"aywiki": "php-1.30.0-wmf.7",
+"aywiki": "php-1.30.0-wmf.9",
 "aywikibooks": "php-1.30.0-wmf.9",
 "aywiktionary": "php-1.30.0-wmf.9",
-"azbwiki": "php-1.30.0-wmf.7",
-"azwiki": "php-1.30.0-wmf.7",
+"azbwiki": "php-1.30.0-wmf.9",
+"azwiki": "php-1.30.0-wmf.9",
 "azwikibooks": "php-1.30.0-wmf.9",
 "azwikiquote": "php-1.30.0-wmf.9",
 "azwikisource": "php-1.30.0-wmf.9",
 "azwiktionary": "php-1.30.0-wmf.9",
-"barwiki": "php-1.30.0-wmf.7",
-"bat_smgwiki": "php-1.30.0-wmf.7",
-"bawiki": "php-1.30.0-wmf.7",
+"barwiki": "php-1.30.0-wmf.9",
+"bat_smgwiki": "php-1.30.0-wmf.9",
+"bawiki": "php-1.30.0-wmf.9",
 "bawikibooks": "php-1.30.0-wmf.9",
-"bclwiki": "php-1.30.0-wmf.7",
+"bclwiki": "php-1.30.0-wmf.9",
 "bdwikimedia": "php-1.30.0-wmf.9",
-"be_x_oldwiki": "php-1.30.0-wmf.7",
+"be_x_oldwiki": "php-1.30.0-wmf.9",
 "betawikiversity": "php-1.30.0-wmf.9",
-"bewiki": "php-1.30.0-wmf.7",
+"bewiki": "php-1.30.0-wmf.9",
 "bewikibooks": "php-1.30.0-wmf.9",
 "bewikimedia": "php-1.30.0-wmf.9",
 "bewikiquote": "php-1.30.0-wmf.9",
 "bewikisource": "php-1.30.0-wmf.9",
 "bewiktionary": "php-1.30.0-wmf.9",
-"bgwiki": "php-1.30.0-wmf.7",
+"bgwiki": "php-1.30.0-wmf.9",
 "bgwikibooks": "php-1.30.0-wmf.9",
 "bgwikinews": "php-1.30.0-wmf.9",

[MediaWiki-commits] [Gerrit] mediawiki...MinervaNeue[wmf/1.30.0-wmf.9]: Revert "Give MinervaNeue control of the minerva skin name"

2017-07-13 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/365187 )

Change subject: Revert "Give MinervaNeue control of the minerva skin name"
..


Revert "Give MinervaNeue control of the minerva skin name"

This reverts commit 6ce6d6f48addcd04175849624f7161a11407b00a.

Change-Id: Ic4e31db657745459a0d9e485b9b9deb6de2a26ae
---
M includes/Minerva.hooks.php
M skin.json
2 files changed, 3 insertions(+), 7 deletions(-)

Approvals:
  Thcipriani: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/Minerva.hooks.php b/includes/Minerva.hooks.php
index dcb2894..ea58ee7 100644
--- a/includes/Minerva.hooks.php
+++ b/includes/Minerva.hooks.php
@@ -11,7 +11,6 @@
  * Hook handler method names should be in the form of:
  * on()
  */
-use MediaWiki\MediaWikiServices;
 
 class MinervaHooks {
/**
@@ -23,9 +22,8 @@
 * @param array &$lessVars Variables already added
 */
public static function onResourceLoaderGetLessVars( &$lessVars ) {
-   $config = MediaWikiServices::getInstance()->getService( 
'ConfigFactory' )
-   ->makeConfig( 'minerva' );
-
+   // FIXME: Load from Minerva.Config when MobileFrontend and 
Minerva are separated
+   $config = MobileContext::singleton()->getMFConfig();
$lessVars = array_merge( $lessVars,
[
'wgMinervaApplyKnownTemplateHacks' => 
"{$config->get( 'MinervaApplyKnownTemplateHacks' )}",
diff --git a/skin.json b/skin.json
index addfeff..c08d450 100644
--- a/skin.json
+++ b/skin.json
@@ -507,9 +507,7 @@
}
},
"ValidSkinNames": {
-   "minervaneue": "MinervaNeue",
-   "minerva-neue": "MinervaNeue",
-   "minerva": "Minerva"
+   "minerva-neue": "MinervaNeue"
},
"author": [],
"config": {

-- 
To view, visit https://gerrit.wikimedia.org/r/365187
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic4e31db657745459a0d9e485b9b9deb6de2a26ae
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/MinervaNeue
Gerrit-Branch: wmf/1.30.0-wmf.9
Gerrit-Owner: Thcipriani 
Gerrit-Reviewer: Chad 
Gerrit-Reviewer: Jdlrobson 
Gerrit-Reviewer: Niedzielski 
Gerrit-Reviewer: Thcipriani 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[wmf/1.30.0-wmf.7]: Revert "Fixups prior to Minerva/MobileFrontend separation"

2017-07-13 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/365183 )

Change subject: Revert "Fixups prior to Minerva/MobileFrontend separation"
..


Revert "Fixups prior to Minerva/MobileFrontend separation"

This reverts commit 85b56aa6e4ed4e89e7996f849e205f1028a7919c.

Change-Id: I1e544177b7f34493d312ac633ca708ef023a4b7a
---
M extension.json
M i18n/en.json
M i18n/qqq.json
M jsduck.json
M resources/skins.minerva.talk/init.js
5 files changed, 26 insertions(+), 13 deletions(-)

Approvals:
  Thcipriani: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/extension.json b/extension.json
index c9201fc..2186a1d 100644
--- a/extension.json
+++ b/extension.json
@@ -504,17 +504,11 @@
"mobile-frontend-overlay-continue",

"mobile-frontend-last-modified-with-user-seconds",

"mobile-frontend-last-modified-with-user-minutes",
+   "mobile-frontend-last-modified-with-user-hours",
"mobile-frontend-last-modified-with-user-days",

"mobile-frontend-last-modified-with-user-months",
"mobile-frontend-last-modified-with-user-years",

"mobile-frontend-last-modified-with-user-just-now",
-   "mobile-frontend-joined-just-now",
-   "mobile-frontend-joined-seconds",
-   "mobile-frontend-joined-minutes",
-   "mobile-frontend-joined-hours",
-   "mobile-frontend-joined-days",
-   "mobile-frontend-joined-months",
-   "mobile-frontend-joined-years",
"mobile-frontend-loading-message",
"mobile-frontend-editor-licensing",
"mobile-frontend-editor-licensing-with-terms",
@@ -914,6 +908,7 @@
"desktop"
],
"dependencies": [
+   "skins.minerva.icons.images.variants",
"mobile.startup"
],
"styles": [
@@ -1363,6 +1358,20 @@
"mobile-frontend-meta-data-issues-header",
"mobile-frontend-meta-data-issues-header-talk",
"mobile-frontend-languages-not-available",
+   
"mobile-frontend-last-modified-with-user-seconds",
+   
"mobile-frontend-last-modified-with-user-minutes",
+   "mobile-frontend-last-modified-with-user-hours",
+   "mobile-frontend-last-modified-with-user-days",
+   
"mobile-frontend-last-modified-with-user-months",
+   "mobile-frontend-last-modified-with-user-years",
+   
"mobile-frontend-last-modified-with-user-just-now",
+   "mobile-frontend-joined-just-now",
+   "mobile-frontend-joined-seconds",
+   "mobile-frontend-joined-minutes",
+   "mobile-frontend-joined-hours",
+   "mobile-frontend-joined-days",
+   "mobile-frontend-joined-months",
+   "mobile-frontend-joined-years",
"mobile-frontend-cookies-required",
"mobile-frontend-console-recruit",
"mobile-frontend-redirected-from"
@@ -1510,14 +1519,13 @@
"resources/skins.minerva.talk/init.js"
],
"messages": [
-   "minerva-talk-add-topic"
+   "mobile-frontend-talk-add-overlay-submit"
]
},
"skins.minerva.toggling": {
"class": "MFResourceLoaderParsedMessageModule",
"dependencies": [
"mobile.toggle",
-   "skins.minerva.icons.images.variants",
"skins.minerva.scripts"
],
"scripts": [
@@ -1536,6 +1544,14 @@
],
"scripts": [
"resources/skins.minerva.watchstar/init.js"
+   ],
+   "messages": [
+   "watchthispage",
+   "unwatchthispage",
+

[MediaWiki-commits] [Gerrit] mediawiki...MinervaNeue[wmf/1.30.0-wmf.9]: Revert "Add missing Minerva skin description message key"

2017-07-13 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/365186 )

Change subject: Revert "Add missing Minerva skin description message key"
..


Revert "Add missing Minerva skin description message key"

This reverts commit 2d95a570308131d3078884331a2161d5bb1f83a7.

Change-Id: I35a28d538464f1c5d01563c09c97b812afc5bb97
---
M i18n/en.json
M i18n/qqq.json
2 files changed, 2 insertions(+), 4 deletions(-)

Approvals:
  Thcipriani: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/i18n/en.json b/i18n/en.json
index 49f64c7..ebaeadf 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -49,6 +49,5 @@
"mobile-frontend-user-page-member-since": "{{GENDER:$2|Joined}} $1",
"mobile-frontend-user-page-talk": "Talk",
"mobile-frontend-user-page-uploads": "Uploads",
-   "skinname-minerva": "Minerva",
-   "minerva-skin-desc": "A responsive mobile first skin."
+   "skinname-minerva": "Minerva"
 }
\ No newline at end of file
diff --git a/i18n/qqq.json b/i18n/qqq.json
index 16901ae..ae9283c 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -49,6 +49,5 @@
"mobile-frontend-user-page-member-since": "Message below the heading. 
$1 is the user registration date. $2 is the gender associated with the user 
account.",
"mobile-frontend-user-page-talk": "Text of the link to the user's talk 
page\n{{Identical|Talk}}",
"mobile-frontend-user-page-uploads": "Text of the link to the user's 
uploads page\n{{Identical|Upload}}",
-   "skinname-minerva": "{{optional}}",
-   "minerva-skin-desc": "{{optional}}"
+   "skinname-minerva": "{{optional}}"
 }
\ No newline at end of file

-- 
To view, visit https://gerrit.wikimedia.org/r/365186
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I35a28d538464f1c5d01563c09c97b812afc5bb97
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/MinervaNeue
Gerrit-Branch: wmf/1.30.0-wmf.9
Gerrit-Owner: Thcipriani 
Gerrit-Reviewer: Chad 
Gerrit-Reviewer: Jdlrobson 
Gerrit-Reviewer: Niedzielski 
Gerrit-Reviewer: Siebrand 
Gerrit-Reviewer: Thcipriani 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...MinervaNeue[wmf/1.30.0-wmf.7]: Revert "Add missing Minerva skin description message key"

2017-07-13 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/365185 )

Change subject: Revert "Add missing Minerva skin description message key"
..


Revert "Add missing Minerva skin description message key"

This reverts commit 4402710fdb85d54add2bc68317b944c9d221c810.

Change-Id: Ie10aab9a378d7edfc39e234d16e665bd75acbd88
---
M i18n/en.json
M i18n/qqq.json
2 files changed, 2 insertions(+), 4 deletions(-)

Approvals:
  Thcipriani: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/i18n/en.json b/i18n/en.json
index 49f64c7..ebaeadf 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -49,6 +49,5 @@
"mobile-frontend-user-page-member-since": "{{GENDER:$2|Joined}} $1",
"mobile-frontend-user-page-talk": "Talk",
"mobile-frontend-user-page-uploads": "Uploads",
-   "skinname-minerva": "Minerva",
-   "minerva-skin-desc": "A responsive mobile first skin."
+   "skinname-minerva": "Minerva"
 }
\ No newline at end of file
diff --git a/i18n/qqq.json b/i18n/qqq.json
index 16901ae..ae9283c 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -49,6 +49,5 @@
"mobile-frontend-user-page-member-since": "Message below the heading. 
$1 is the user registration date. $2 is the gender associated with the user 
account.",
"mobile-frontend-user-page-talk": "Text of the link to the user's talk 
page\n{{Identical|Talk}}",
"mobile-frontend-user-page-uploads": "Text of the link to the user's 
uploads page\n{{Identical|Upload}}",
-   "skinname-minerva": "{{optional}}",
-   "minerva-skin-desc": "{{optional}}"
+   "skinname-minerva": "{{optional}}"
 }
\ No newline at end of file

-- 
To view, visit https://gerrit.wikimedia.org/r/365185
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie10aab9a378d7edfc39e234d16e665bd75acbd88
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/MinervaNeue
Gerrit-Branch: wmf/1.30.0-wmf.7
Gerrit-Owner: Thcipriani 
Gerrit-Reviewer: Chad 
Gerrit-Reviewer: Jdlrobson 
Gerrit-Reviewer: Niedzielski 
Gerrit-Reviewer: Siebrand 
Gerrit-Reviewer: Thcipriani 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[wmf/1.30.0-wmf.9]: Revert "Fixups prior to Minerva/MobileFrontend separation"

2017-07-13 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/365182 )

Change subject: Revert "Fixups prior to Minerva/MobileFrontend separation"
..


Revert "Fixups prior to Minerva/MobileFrontend separation"

This reverts commit df35f71cd8045111d3ab8eeb3e11cc9c2df3d64f.

Change-Id: If2f36a88542df00926095eaa90633c9468e160f2
---
M extension.json
M i18n/en.json
M i18n/qqq.json
M jsduck.json
M resources/skins.minerva.talk/init.js
5 files changed, 26 insertions(+), 13 deletions(-)

Approvals:
  Thcipriani: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/extension.json b/extension.json
index 77901e6..95c150e 100644
--- a/extension.json
+++ b/extension.json
@@ -504,17 +504,11 @@
"mobile-frontend-overlay-continue",

"mobile-frontend-last-modified-with-user-seconds",

"mobile-frontend-last-modified-with-user-minutes",
+   "mobile-frontend-last-modified-with-user-hours",
"mobile-frontend-last-modified-with-user-days",

"mobile-frontend-last-modified-with-user-months",
"mobile-frontend-last-modified-with-user-years",

"mobile-frontend-last-modified-with-user-just-now",
-   "mobile-frontend-joined-just-now",
-   "mobile-frontend-joined-seconds",
-   "mobile-frontend-joined-minutes",
-   "mobile-frontend-joined-hours",
-   "mobile-frontend-joined-days",
-   "mobile-frontend-joined-months",
-   "mobile-frontend-joined-years",
"mobile-frontend-loading-message",
"mobile-frontend-editor-licensing",
"mobile-frontend-editor-licensing-with-terms",
@@ -914,6 +908,7 @@
"desktop"
],
"dependencies": [
+   "skins.minerva.icons.images.variants",
"mobile.startup"
],
"styles": [
@@ -1363,6 +1358,20 @@
"mobile-frontend-meta-data-issues-header",
"mobile-frontend-meta-data-issues-header-talk",
"mobile-frontend-languages-not-available",
+   
"mobile-frontend-last-modified-with-user-seconds",
+   
"mobile-frontend-last-modified-with-user-minutes",
+   "mobile-frontend-last-modified-with-user-hours",
+   "mobile-frontend-last-modified-with-user-days",
+   
"mobile-frontend-last-modified-with-user-months",
+   "mobile-frontend-last-modified-with-user-years",
+   
"mobile-frontend-last-modified-with-user-just-now",
+   "mobile-frontend-joined-just-now",
+   "mobile-frontend-joined-seconds",
+   "mobile-frontend-joined-minutes",
+   "mobile-frontend-joined-hours",
+   "mobile-frontend-joined-days",
+   "mobile-frontend-joined-months",
+   "mobile-frontend-joined-years",
"mobile-frontend-cookies-required",
"mobile-frontend-console-recruit",
"mobile-frontend-redirected-from"
@@ -1510,14 +1519,13 @@
"resources/skins.minerva.talk/init.js"
],
"messages": [
-   "minerva-talk-add-topic"
+   "mobile-frontend-talk-add-overlay-submit"
]
},
"skins.minerva.toggling": {
"class": "MFResourceLoaderParsedMessageModule",
"dependencies": [
"mobile.toggle",
-   "skins.minerva.icons.images.variants",
"skins.minerva.scripts"
],
"scripts": [
@@ -1536,6 +1544,14 @@
],
"scripts": [
"resources/skins.minerva.watchstar/init.js"
+   ],
+   "messages": [
+   "watchthispage",
+   "unwatchthispage",
+

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Revert "Move testwiki to MinervaNeue"

2017-07-13 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/365188 )

Change subject: Revert "Move testwiki to MinervaNeue"
..


Revert "Move testwiki to MinervaNeue"

This reverts commit 6e8886d956f4908def308a61f694afffe9a77ba8.

Change-Id: I8f191cb0caf17d04aacb116b38ccc7afb89e65d9
---
M wmf-config/InitialiseSettings.php
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
  Thcipriani: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/wmf-config/InitialiseSettings.php 
b/wmf-config/InitialiseSettings.php
index 7f8121d..5d21213 100644
--- a/wmf-config/InitialiseSettings.php
+++ b/wmf-config/InitialiseSettings.php
@@ -15012,7 +15012,6 @@
 
 'wmgMinervaNeue' => [
'default' => false,
-   'testwiki' => true,
 ],
 'wmgUseMobileApp' => [
'default' => true,

-- 
To view, visit https://gerrit.wikimedia.org/r/365188
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8f191cb0caf17d04aacb116b38ccc7afb89e65d9
Gerrit-PatchSet: 2
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Thcipriani 
Gerrit-Reviewer: Chad 
Gerrit-Reviewer: Florianschmidtwelzow 
Gerrit-Reviewer: Thcipriani 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Revert "Move testwiki to MinervaNeue"

2017-07-13 Thread Thcipriani (Code Review)

Hello Chad, Florianschmidtwelzow, jenkins-bot,

I'd like you to do a code review.  Please visit

https://gerrit.wikimedia.org/r/365188

to review the following change.


Change subject: Revert "Move testwiki to MinervaNeue"
..

Revert "Move testwiki to MinervaNeue"

This reverts commit 6e8886d956f4908def308a61f694afffe9a77ba8.

Change-Id: I8f191cb0caf17d04aacb116b38ccc7afb89e65d9
---
M wmf-config/InitialiseSettings.php
1 file changed, 0 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/88/365188/1

diff --git a/wmf-config/InitialiseSettings.php 
b/wmf-config/InitialiseSettings.php
index 7f8121d..5d21213 100644
--- a/wmf-config/InitialiseSettings.php
+++ b/wmf-config/InitialiseSettings.php
@@ -15012,7 +15012,6 @@
 
 'wmgMinervaNeue' => [
'default' => false,
-   'testwiki' => true,
 ],
 'wmgUseMobileApp' => [
'default' => true,

-- 
To view, visit https://gerrit.wikimedia.org/r/365188
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8f191cb0caf17d04aacb116b38ccc7afb89e65d9
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Thcipriani 
Gerrit-Reviewer: Chad 
Gerrit-Reviewer: Florianschmidtwelzow 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...MinervaNeue[wmf/1.30.0-wmf.9]: Revert "Give MinervaNeue control of the minerva skin name"

2017-07-13 Thread Thcipriani (Code Review)

Hello Chad, Niedzielski, jenkins-bot, Jdlrobson,

I'd like you to do a code review.  Please visit

https://gerrit.wikimedia.org/r/365187

to review the following change.


Change subject: Revert "Give MinervaNeue control of the minerva skin name"
..

Revert "Give MinervaNeue control of the minerva skin name"

This reverts commit 6ce6d6f48addcd04175849624f7161a11407b00a.

Change-Id: Ic4e31db657745459a0d9e485b9b9deb6de2a26ae
---
M includes/Minerva.hooks.php
M skin.json
2 files changed, 3 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/MinervaNeue 
refs/changes/87/365187/1

diff --git a/includes/Minerva.hooks.php b/includes/Minerva.hooks.php
index dcb2894..ea58ee7 100644
--- a/includes/Minerva.hooks.php
+++ b/includes/Minerva.hooks.php
@@ -11,7 +11,6 @@
  * Hook handler method names should be in the form of:
  * on()
  */
-use MediaWiki\MediaWikiServices;
 
 class MinervaHooks {
/**
@@ -23,9 +22,8 @@
 * @param array &$lessVars Variables already added
 */
public static function onResourceLoaderGetLessVars( &$lessVars ) {
-   $config = MediaWikiServices::getInstance()->getService( 
'ConfigFactory' )
-   ->makeConfig( 'minerva' );
-
+   // FIXME: Load from Minerva.Config when MobileFrontend and 
Minerva are separated
+   $config = MobileContext::singleton()->getMFConfig();
$lessVars = array_merge( $lessVars,
[
'wgMinervaApplyKnownTemplateHacks' => 
"{$config->get( 'MinervaApplyKnownTemplateHacks' )}",
diff --git a/skin.json b/skin.json
index addfeff..c08d450 100644
--- a/skin.json
+++ b/skin.json
@@ -507,9 +507,7 @@
}
},
"ValidSkinNames": {
-   "minervaneue": "MinervaNeue",
-   "minerva-neue": "MinervaNeue",
-   "minerva": "Minerva"
+   "minerva-neue": "MinervaNeue"
},
"author": [],
"config": {

-- 
To view, visit https://gerrit.wikimedia.org/r/365187
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic4e31db657745459a0d9e485b9b9deb6de2a26ae
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/MinervaNeue
Gerrit-Branch: wmf/1.30.0-wmf.9
Gerrit-Owner: Thcipriani 
Gerrit-Reviewer: Chad 
Gerrit-Reviewer: Jdlrobson 
Gerrit-Reviewer: Niedzielski 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...MinervaNeue[wmf/1.30.0-wmf.9]: Revert "Add missing Minerva skin description message key"

2017-07-13 Thread Thcipriani (Code Review)

Hello Chad, jenkins-bot, Jdlrobson,

I'd like you to do a code review.  Please visit

https://gerrit.wikimedia.org/r/365186

to review the following change.


Change subject: Revert "Add missing Minerva skin description message key"
..

Revert "Add missing Minerva skin description message key"

This reverts commit 2d95a570308131d3078884331a2161d5bb1f83a7.

Change-Id: I35a28d538464f1c5d01563c09c97b812afc5bb97
---
M i18n/en.json
M i18n/qqq.json
2 files changed, 2 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/MinervaNeue 
refs/changes/86/365186/1

diff --git a/i18n/en.json b/i18n/en.json
index 49f64c7..ebaeadf 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -49,6 +49,5 @@
"mobile-frontend-user-page-member-since": "{{GENDER:$2|Joined}} $1",
"mobile-frontend-user-page-talk": "Talk",
"mobile-frontend-user-page-uploads": "Uploads",
-   "skinname-minerva": "Minerva",
-   "minerva-skin-desc": "A responsive mobile first skin."
+   "skinname-minerva": "Minerva"
 }
\ No newline at end of file
diff --git a/i18n/qqq.json b/i18n/qqq.json
index 16901ae..ae9283c 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -49,6 +49,5 @@
"mobile-frontend-user-page-member-since": "Message below the heading. 
$1 is the user registration date. $2 is the gender associated with the user 
account.",
"mobile-frontend-user-page-talk": "Text of the link to the user's talk 
page\n{{Identical|Talk}}",
"mobile-frontend-user-page-uploads": "Text of the link to the user's 
uploads page\n{{Identical|Upload}}",
-   "skinname-minerva": "{{optional}}",
-   "minerva-skin-desc": "{{optional}}"
+   "skinname-minerva": "{{optional}}"
 }
\ No newline at end of file

-- 
To view, visit https://gerrit.wikimedia.org/r/365186
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I35a28d538464f1c5d01563c09c97b812afc5bb97
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/MinervaNeue
Gerrit-Branch: wmf/1.30.0-wmf.9
Gerrit-Owner: Thcipriani 
Gerrit-Reviewer: Chad 
Gerrit-Reviewer: Jdlrobson 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...MinervaNeue[wmf/1.30.0-wmf.7]: Revert "Add missing Minerva skin description message key"

2017-07-13 Thread Thcipriani (Code Review)

Hello Chad, jenkins-bot, Jdlrobson,

I'd like you to do a code review.  Please visit

https://gerrit.wikimedia.org/r/365185

to review the following change.


Change subject: Revert "Add missing Minerva skin description message key"
..

Revert "Add missing Minerva skin description message key"

This reverts commit 4402710fdb85d54add2bc68317b944c9d221c810.

Change-Id: Ie10aab9a378d7edfc39e234d16e665bd75acbd88
---
M i18n/en.json
M i18n/qqq.json
2 files changed, 2 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/MinervaNeue 
refs/changes/85/365185/1

diff --git a/i18n/en.json b/i18n/en.json
index 49f64c7..ebaeadf 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -49,6 +49,5 @@
"mobile-frontend-user-page-member-since": "{{GENDER:$2|Joined}} $1",
"mobile-frontend-user-page-talk": "Talk",
"mobile-frontend-user-page-uploads": "Uploads",
-   "skinname-minerva": "Minerva",
-   "minerva-skin-desc": "A responsive mobile first skin."
+   "skinname-minerva": "Minerva"
 }
\ No newline at end of file
diff --git a/i18n/qqq.json b/i18n/qqq.json
index 16901ae..ae9283c 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -49,6 +49,5 @@
"mobile-frontend-user-page-member-since": "Message below the heading. 
$1 is the user registration date. $2 is the gender associated with the user 
account.",
"mobile-frontend-user-page-talk": "Text of the link to the user's talk 
page\n{{Identical|Talk}}",
"mobile-frontend-user-page-uploads": "Text of the link to the user's 
uploads page\n{{Identical|Upload}}",
-   "skinname-minerva": "{{optional}}",
-   "minerva-skin-desc": "{{optional}}"
+   "skinname-minerva": "{{optional}}"
 }
\ No newline at end of file

-- 
To view, visit https://gerrit.wikimedia.org/r/365185
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie10aab9a378d7edfc39e234d16e665bd75acbd88
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/MinervaNeue
Gerrit-Branch: wmf/1.30.0-wmf.7
Gerrit-Owner: Thcipriani 
Gerrit-Reviewer: Chad 
Gerrit-Reviewer: Jdlrobson 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Swap SqliteInstaller::MINIMUM_VERSION for SqliteInstaller::$...

2017-07-13 Thread Reedy (Code Review)

Reedy has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/365184 )

Change subject: Swap SqliteInstaller::MINIMUM_VERSION for 
SqliteInstaller::$minimumVersion
..

Swap SqliteInstaller::MINIMUM_VERSION for SqliteInstaller::$minimumVersion

Makes it like the rest of the Installer classes

Change-Id: I940e71878f4e9454371c0e1da0ef5d6bfa51ebdd
---
M includes/installer/SqliteInstaller.php
1 file changed, 4 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/84/365184/1

diff --git a/includes/installer/SqliteInstaller.php 
b/includes/installer/SqliteInstaller.php
index 3943374..665f333 100644
--- a/includes/installer/SqliteInstaller.php
+++ b/includes/installer/SqliteInstaller.php
@@ -32,7 +32,8 @@
  * @since 1.17
  */
 class SqliteInstaller extends DatabaseInstaller {
-   const MINIMUM_VERSION = '3.3.7';
+
+   public $minimumVersion = '3.3.7';
 
/**
 * @var DatabaseSqlite
@@ -60,8 +61,8 @@
$result = Status::newGood();
// Bail out if SQLite is too old
$db = DatabaseSqlite::newStandaloneInstance( ':memory:' );
-   if ( version_compare( $db->getServerVersion(), 
self::MINIMUM_VERSION, '<' ) ) {
-   $result->fatal( 'config-outdated-sqlite', 
$db->getServerVersion(), self::MINIMUM_VERSION );
+   if ( version_compare( $db->getServerVersion(), 
self::$minimumVersion, '<' ) ) {
+   $result->fatal( 'config-outdated-sqlite', 
$db->getServerVersion(), self::$minimumVersion );
}
// Check for FTS3 full-text search module
if ( DatabaseSqlite::getFulltextSearchModule() != 'FTS3' ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/365184
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I940e71878f4e9454371c0e1da0ef5d6bfa51ebdd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Reedy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[wmf/1.30.0-wmf.9]: Revert "Fixups prior to Minerva/MobileFrontend separation"

2017-07-13 Thread Thcipriani (Code Review)

Hello Chad, Niedzielski, jenkins-bot, Siebrand, Jdlrobson,

I'd like you to do a code review.  Please visit

https://gerrit.wikimedia.org/r/365182

to review the following change.


Change subject: Revert "Fixups prior to Minerva/MobileFrontend separation"
..

Revert "Fixups prior to Minerva/MobileFrontend separation"

This reverts commit df35f71cd8045111d3ab8eeb3e11cc9c2df3d64f.

Change-Id: If2f36a88542df00926095eaa90633c9468e160f2
---
M extension.json
M i18n/en.json
M i18n/qqq.json
M jsduck.json
M resources/skins.minerva.talk/init.js
5 files changed, 26 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/82/365182/1

diff --git a/extension.json b/extension.json
index 77901e6..95c150e 100644
--- a/extension.json
+++ b/extension.json
@@ -504,17 +504,11 @@
"mobile-frontend-overlay-continue",

"mobile-frontend-last-modified-with-user-seconds",

"mobile-frontend-last-modified-with-user-minutes",
+   "mobile-frontend-last-modified-with-user-hours",
"mobile-frontend-last-modified-with-user-days",

"mobile-frontend-last-modified-with-user-months",
"mobile-frontend-last-modified-with-user-years",

"mobile-frontend-last-modified-with-user-just-now",
-   "mobile-frontend-joined-just-now",
-   "mobile-frontend-joined-seconds",
-   "mobile-frontend-joined-minutes",
-   "mobile-frontend-joined-hours",
-   "mobile-frontend-joined-days",
-   "mobile-frontend-joined-months",
-   "mobile-frontend-joined-years",
"mobile-frontend-loading-message",
"mobile-frontend-editor-licensing",
"mobile-frontend-editor-licensing-with-terms",
@@ -914,6 +908,7 @@
"desktop"
],
"dependencies": [
+   "skins.minerva.icons.images.variants",
"mobile.startup"
],
"styles": [
@@ -1363,6 +1358,20 @@
"mobile-frontend-meta-data-issues-header",
"mobile-frontend-meta-data-issues-header-talk",
"mobile-frontend-languages-not-available",
+   
"mobile-frontend-last-modified-with-user-seconds",
+   
"mobile-frontend-last-modified-with-user-minutes",
+   "mobile-frontend-last-modified-with-user-hours",
+   "mobile-frontend-last-modified-with-user-days",
+   
"mobile-frontend-last-modified-with-user-months",
+   "mobile-frontend-last-modified-with-user-years",
+   
"mobile-frontend-last-modified-with-user-just-now",
+   "mobile-frontend-joined-just-now",
+   "mobile-frontend-joined-seconds",
+   "mobile-frontend-joined-minutes",
+   "mobile-frontend-joined-hours",
+   "mobile-frontend-joined-days",
+   "mobile-frontend-joined-months",
+   "mobile-frontend-joined-years",
"mobile-frontend-cookies-required",
"mobile-frontend-console-recruit",
"mobile-frontend-redirected-from"
@@ -1510,14 +1519,13 @@
"resources/skins.minerva.talk/init.js"
],
"messages": [
-   "minerva-talk-add-topic"
+   "mobile-frontend-talk-add-overlay-submit"
]
},
"skins.minerva.toggling": {
"class": "MFResourceLoaderParsedMessageModule",
"dependencies": [
"mobile.toggle",
-   "skins.minerva.icons.images.variants",
"skins.minerva.scripts"
],
"scripts": [
@@ -1536,6 +1544,14 @@
],
"scripts": [
"resources/skins.minerva.watchstar/init.js"
+   ],
+   "messages": [
+

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[wmf/1.30.0-wmf.7]: Revert "Fixups prior to Minerva/MobileFrontend separation"

2017-07-13 Thread Thcipriani (Code Review)

Hello Chad, Niedzielski, jenkins-bot, Siebrand, Jdlrobson,

I'd like you to do a code review.  Please visit

https://gerrit.wikimedia.org/r/365183

to review the following change.


Change subject: Revert "Fixups prior to Minerva/MobileFrontend separation"
..

Revert "Fixups prior to Minerva/MobileFrontend separation"

This reverts commit 85b56aa6e4ed4e89e7996f849e205f1028a7919c.

Change-Id: I1e544177b7f34493d312ac633ca708ef023a4b7a
---
M extension.json
M i18n/en.json
M i18n/qqq.json
M jsduck.json
M resources/skins.minerva.talk/init.js
5 files changed, 26 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/83/365183/1

diff --git a/extension.json b/extension.json
index c9201fc..2186a1d 100644
--- a/extension.json
+++ b/extension.json
@@ -504,17 +504,11 @@
"mobile-frontend-overlay-continue",

"mobile-frontend-last-modified-with-user-seconds",

"mobile-frontend-last-modified-with-user-minutes",
+   "mobile-frontend-last-modified-with-user-hours",
"mobile-frontend-last-modified-with-user-days",

"mobile-frontend-last-modified-with-user-months",
"mobile-frontend-last-modified-with-user-years",

"mobile-frontend-last-modified-with-user-just-now",
-   "mobile-frontend-joined-just-now",
-   "mobile-frontend-joined-seconds",
-   "mobile-frontend-joined-minutes",
-   "mobile-frontend-joined-hours",
-   "mobile-frontend-joined-days",
-   "mobile-frontend-joined-months",
-   "mobile-frontend-joined-years",
"mobile-frontend-loading-message",
"mobile-frontend-editor-licensing",
"mobile-frontend-editor-licensing-with-terms",
@@ -914,6 +908,7 @@
"desktop"
],
"dependencies": [
+   "skins.minerva.icons.images.variants",
"mobile.startup"
],
"styles": [
@@ -1363,6 +1358,20 @@
"mobile-frontend-meta-data-issues-header",
"mobile-frontend-meta-data-issues-header-talk",
"mobile-frontend-languages-not-available",
+   
"mobile-frontend-last-modified-with-user-seconds",
+   
"mobile-frontend-last-modified-with-user-minutes",
+   "mobile-frontend-last-modified-with-user-hours",
+   "mobile-frontend-last-modified-with-user-days",
+   
"mobile-frontend-last-modified-with-user-months",
+   "mobile-frontend-last-modified-with-user-years",
+   
"mobile-frontend-last-modified-with-user-just-now",
+   "mobile-frontend-joined-just-now",
+   "mobile-frontend-joined-seconds",
+   "mobile-frontend-joined-minutes",
+   "mobile-frontend-joined-hours",
+   "mobile-frontend-joined-days",
+   "mobile-frontend-joined-months",
+   "mobile-frontend-joined-years",
"mobile-frontend-cookies-required",
"mobile-frontend-console-recruit",
"mobile-frontend-redirected-from"
@@ -1510,14 +1519,13 @@
"resources/skins.minerva.talk/init.js"
],
"messages": [
-   "minerva-talk-add-topic"
+   "mobile-frontend-talk-add-overlay-submit"
]
},
"skins.minerva.toggling": {
"class": "MFResourceLoaderParsedMessageModule",
"dependencies": [
"mobile.toggle",
-   "skins.minerva.icons.images.variants",
"skins.minerva.scripts"
],
"scripts": [
@@ -1536,6 +1544,14 @@
],
"scripts": [
"resources/skins.minerva.watchstar/init.js"
+   ],
+   "messages": [
+

[MediaWiki-commits] [Gerrit] operations/puppet[production]: labspuppetbackend: Include some more python dependencies fo...

2017-07-13 Thread Andrew Bogott (Code Review)

Andrew Bogott has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/365174 )

Change subject: labspuppetbackend:  Include some more python dependencies for 
jessie.
..


labspuppetbackend:  Include some more python dependencies for jessie.

Change-Id: I5eb4ffdf36ff95e0be30f86ca93c705a2fa7c3d4
---
M modules/labspuppetbackend/manifests/init.pp
1 file changed, 7 insertions(+), 0 deletions(-)

Approvals:
  Andrew Bogott: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/labspuppetbackend/manifests/init.pp 
b/modules/labspuppetbackend/manifests/init.pp
index a89c002..af24259 100644
--- a/modules/labspuppetbackend/manifests/init.pp
+++ b/modules/labspuppetbackend/manifests/init.pp
@@ -11,6 +11,13 @@
 'python3-flask',
 'python3-yaml')
 
+if os_version('debian >= jessie') {
+require_package('python-flask',
+'python-pymysql',
+'python-statsd',
+'python-yaml')
+}
+
 
 file { '/usr/local/lib/python3.4/dist-packages/labspuppetbackend.py':
 source => 'puppet:///modules/labspuppetbackend/labspuppetbackend.py',

-- 
To view, visit https://gerrit.wikimedia.org/r/365174
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5eb4ffdf36ff95e0be30f86ca93c705a2fa7c3d4
Gerrit-PatchSet: 3
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Andrew Bogott 
Gerrit-Reviewer: Andrew Bogott 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Update: consolidate dark mode

2017-07-13 Thread Niedzielski (Code Review)

Niedzielski has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/365180 )

Change subject: Update: consolidate dark mode
..

Update: consolidate dark mode

Change-Id: Ie5512ad19f729141af913b6098a412890a8ec4b0
---
D app/src/main/assets/dark.css
M scripts/make-css-assets.bash
2 files changed, 0 insertions(+), 44 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia 
refs/changes/80/365180/1

diff --git a/app/src/main/assets/dark.css b/app/src/main/assets/dark.css
deleted file mode 100644
index 6aff9aa..000
--- a/app/src/main/assets/dark.css
+++ /dev/null
@@ -1,43 +0,0 @@
-body {
-  color: #999;
-  background: #000;
-}
-a {
-  color: #2b6fb2;
-}
-a.external {
-  background-image: 
url(data:image/png;base64,iVBORw0KGgoNSUhEUgoKCAYAAACNMs+9AXNSR0IArs4c6QRnQU1BAACxjwv8YQUJcEhZcwAADsMAAA7DAcdvqGQadEVYdFNvZnR3YXJlAFBhaW50Lk5FVCB2My41LjEwMPRyoQAAAGJJREFUKFN1jdENgCAMBYmJn47Bak7DZrhTpc/XIm34OAjXA4qIgHI/dSBbLGTcOKjBryFlinGmjDQGiOF0MQkxI3v5wq6L38qR7SnsAx8ul37igPjAd+o5Oz2MRA+xY4ZSXuaW6wYouOLpAElFTkSuQmCC);
-  background-image: 
url(/w/extensions/MobileApp/images/external-link-ltr.png?36384)!ie;
-}
-/* Same specificity as in MFE/less/content/hacks.less */
-.stable .content table.infobox {
-  background: #000;
-}
-/* Same specificity as in MFE/less/content/hacks.less */
-.content table td,
-.content table th,
-.content table.infobox th,
-.content table.infobox td {
-  border-color: rgba(128, 128, 128, 0.12);
-}
-.app_table_container {
-  box-shadow: none;
-  border: 1px solid #202020;
-  background-color: #202020;
-}
-.app_table_collapsed_container {
-  background-color: #202020;
-}
-.app_table_collapsed_open {
-  border-radius: 0;
-}
-.app_table_collapse_close {
-  border-radius: 0;
-}
-.app_span_collapse_text {
-  color: #808080;
-}
-.app_table_collapsed_bottom {
-  background-color: #202020;
-  border-radius: 0;
-}
\ No newline at end of file
diff --git a/scripts/make-css-assets.bash b/scripts/make-css-assets.bash
index 2697aa1..69b71a9 100755
--- a/scripts/make-css-assets.bash
+++ b/scripts/make-css-assets.bash
@@ -8,4 +8,3 @@
 
 wget 
"$PREFIX/load.php?debug=true=en=skins.minerva.base.reset|skins.minerva.content.styles|ext.cite.style|ext.math.styles|ext.timeline.styles|mediawiki.page.gallery.styles|mobile.app.pagestyles.android|mediawiki.skinning.content.parsoid=styles=&*"
 -O "$BASE_PATH/app/src/main/assets/styles.css"
 wget 
"$PREFIX/load.php?debug=true=en=skins.minerva.base.reset|skins.minerva.content.styles|ext.cite.style|ext.math.styles|ext.timeline.styles|mediawiki.page.gallery.styles|mobile.app.preview.android|mobile.app.preview|mediawiki.skinning.content.parsoid=styles=&*"
 -O "$BASE_PATH/app/src/main/assets/preview.css"
-wget 
"$PREFIX/load.php?debug=true=en=mobile.app.pagestyles.android.night=styles=&*"
 -O "$BASE_PATH/app/src/main/assets/dark.css"

-- 
To view, visit https://gerrit.wikimedia.org/r/365180
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie5512ad19f729141af913b6098a412890a8ec4b0
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Niedzielski 
Gerrit-Reviewer: Sniedzielski 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Chore: update styles

2017-07-13 Thread Niedzielski (Code Review)

Niedzielski has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/365179 )

Change subject: Chore: update styles
..

Chore: update styles

Updates bundled CSS with the latest from MobileFrontend, MinervaNeue,
and extensions from scripts/make-css-assets.bash. MinervaNeue was
configured with MinervaApplyKnownTemplateHacks set to true.

Change-Id: Ia6d76492e025ec8ee2643f85ce51c724f1b7b7d6
---
M app/src/main/assets/preview.css
M app/src/main/assets/styles.css
2 files changed, 4 insertions(+), 14 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia 
refs/changes/79/365179/1

diff --git a/app/src/main/assets/preview.css b/app/src/main/assets/preview.css
index 72ab26b..ed30cb0 100644
--- a/app/src/main/assets/preview.css
+++ b/app/src/main/assets/preview.css
@@ -106,11 +106,6 @@
   color: #22;
   background: #fff;
 }
-.pre-content,
-.content,
-.post-content {
-  margin: 0 16px;
-}
 .content {
   line-height: 1.65;
   word-wrap: break-word;
@@ -329,9 +324,9 @@
 }
 a.external {
   background-image: 
url(data:image/png;base64,iVBORw0KGgoNSUhEUgoKCAYAAACNMs+9VElEQVR42n3PgQkAIAhEUXdqJ3dqJ3e6IoTPUSQcgj4EQ5IlUiLE0Jil3PECXhcHGBhZ8kg4hwxAu3MZeCGeyFnAXp4hqNQPnt7QL0nADpD6wHccLvnAKksq8iiaAElFTkSuQmCC);
-  background-image: 
url(/w/extensions/MobileFrontend/resources/skins.minerva.content.styles/images/external-link-ltr-icon.png?948bf)!ie;
+  background-image: 
url(/w/skins/MinervaNeue/resources/skins.minerva.content.styles/images/external-link-ltr-icon.png?948bf)!ie;
   background-image: linear-gradient(transparent, transparent), 
url(data:image/svg+xml,%3C%3Fxml%20version%3D%221.0%22%20encoding%3D%22UTF-8%22%20standalone%3D%22no%22%3F%3E%3Csvg%20xmlns%3D%22http%3A%2F%2Fwww.w3.org%2F2000%2Fsvg%22%20width%3D%2210%22%20height%3D%2210%22%3E%3Cpath%20fill%3D%22%23fff%22%20stroke%3D%22%2306c%22%20d%3D%22M.5%203.518h5.982V9.5H.5z%22%2F%3E%3Cpath%20d%3D%22M4.755-.16H9.99v5.39L8.417%206.774l-1.31-1.31L4.383%208.19%201.695%205.5l2.808-2.807-1.31-1.31z%22%20fill%3D%22%2306f%22%2F%3E%3Cpath%20d%3D%22M8.984.845l.022%204.884L7.19%203.91%204.308%206.79%203.08%205.567l2.882-2.88L4.112.833z%22%20fill%3D%22%23fff%22%2F%3E%3C%2Fsvg%3E);
-  background-image: -o-linear-gradient(transparent, transparent), 
url(/w/extensions/MobileFrontend/resources/skins.minerva.content.styles/images/external-link-ltr-icon.png?948bf);
+  background-image: -o-linear-gradient(transparent, transparent), 
url(/w/skins/MinervaNeue/resources/skins.minerva.content.styles/images/external-link-ltr-icon.png?948bf);
   background-repeat: no-repeat;
   background-position: center right;
   padding-right: 13px;
diff --git a/app/src/main/assets/styles.css b/app/src/main/assets/styles.css
index 66ffae8..104fd40 100644
--- a/app/src/main/assets/styles.css
+++ b/app/src/main/assets/styles.css
@@ -106,11 +106,6 @@
   color: #22;
   background: #fff;
 }
-.pre-content,
-.content,
-.post-content {
-  margin: 0 16px;
-}
 .content {
   line-height: 1.65;
   word-wrap: break-word;
@@ -329,9 +324,9 @@
 }
 a.external {
   background-image: 
url(data:image/png;base64,iVBORw0KGgoNSUhEUgoKCAYAAACNMs+9VElEQVR42n3PgQkAIAhEUXdqJ3dqJ3e6IoTPUSQcgj4EQ5IlUiLE0Jil3PECXhcHGBhZ8kg4hwxAu3MZeCGeyFnAXp4hqNQPnt7QL0nADpD6wHccLvnAKksq8iiaAElFTkSuQmCC);
-  background-image: 
url(/w/extensions/MobileFrontend/resources/skins.minerva.content.styles/images/external-link-ltr-icon.png?948bf)!ie;
+  background-image: 
url(/w/skins/MinervaNeue/resources/skins.minerva.content.styles/images/external-link-ltr-icon.png?948bf)!ie;
   background-image: linear-gradient(transparent, transparent), 
url(data:image/svg+xml,%3C%3Fxml%20version%3D%221.0%22%20encoding%3D%22UTF-8%22%20standalone%3D%22no%22%3F%3E%3Csvg%20xmlns%3D%22http%3A%2F%2Fwww.w3.org%2F2000%2Fsvg%22%20width%3D%2210%22%20height%3D%2210%22%3E%3Cpath%20fill%3D%22%23fff%22%20stroke%3D%22%2306c%22%20d%3D%22M.5%203.518h5.982V9.5H.5z%22%2F%3E%3Cpath%20d%3D%22M4.755-.16H9.99v5.39L8.417%206.774l-1.31-1.31L4.383%208.19%201.695%205.5l2.808-2.807-1.31-1.31z%22%20fill%3D%22%2306f%22%2F%3E%3Cpath%20d%3D%22M8.984.845l.022%204.884L7.19%203.91%204.308%206.79%203.08%205.567l2.882-2.88L4.112.833z%22%20fill%3D%22%23fff%22%2F%3E%3C%2Fsvg%3E);
-  background-image: -o-linear-gradient(transparent, transparent), 
url(/w/extensions/MobileFrontend/resources/skins.minerva.content.styles/images/external-link-ltr-icon.png?948bf);
+  background-image: -o-linear-gradient(transparent, transparent), 
url(/w/skins/MinervaNeue/resources/skins.minerva.content.styles/images/external-link-ltr-icon.png?948bf);
   background-repeat: no-repeat;
   background-position: center right;
   padding-right: 13px;

-- 
To view, visit https://gerrit.wikimedia.org/r/365179
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia6d76492e025ec8ee2643f85ce51c724f1b7b7d6
Gerrit-PatchSet: 1

[MediaWiki-commits] [Gerrit] labs...stashbot[master]: Update for ElasticSearch 5.x

2017-07-13 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/365178 )

Change subject: Update for ElasticSearch 5.x
..


Update for ElasticSearch 5.x

Bug: T164842
Change-Id: I2a23b5bd4d3038728b3b9d4c6ff37648193f55bb
---
M requirements.txt
M stashbot/es.py
2 files changed, 2 insertions(+), 3 deletions(-)

Approvals:
  BryanDavis: Checked; Looks good to me, approved
  jenkins-bot: Verified



diff --git a/requirements.txt b/requirements.txt
index 5767947..733e0c3 100644
--- a/requirements.txt
+++ b/requirements.txt
@@ -1,4 +1,4 @@
-elasticsearch>=1.0.0,<2.0.0
+elasticsearch>=5.0.0,<6.0.0
 ib3==0.1.0
 irc>=15.0.3
 ldap3==1.4.0
diff --git a/stashbot/es.py b/stashbot/es.py
index f84cf5c..fc78c62 100644
--- a/stashbot/es.py
+++ b/stashbot/es.py
@@ -47,8 +47,7 @@
 """Store a document in Elasticsearch."""
 try:
 return self.es.index(
-index=index, doc_type=doc_type, body=body,
-consistency="one")
+index=index, doc_type=doc_type, body=body)
 except elasticsearch.ConnectionError as e:
 self.logger.exception(
 'Failed to log to elasticsearch: %s', e.error)

-- 
To view, visit https://gerrit.wikimedia.org/r/365178
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2a23b5bd4d3038728b3b9d4c6ff37648193f55bb
Gerrit-PatchSet: 1
Gerrit-Project: labs/tools/stashbot
Gerrit-Branch: master
Gerrit-Owner: BryanDavis 
Gerrit-Reviewer: BryanDavis 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[wmf/1.30.0-wmf.9]: Revert "Minerva is its own skin"

2017-07-13 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/365176 )

Change subject: Revert "Minerva is its own skin"
..


Revert "Minerva is its own skin"

This reverts commit 7246d64e0909a9bd1b9e088b3763a4bfdbf7c691.

Minerva is not enabled yet so without this we get a
 wgMFDefaultSkinClass RuntimeException

Change-Id: I1413bd4faa47ae5165589bba73906eab257f2539
---
M extension.json
M i18n/ab.json
M i18n/ace.json
M i18n/ady-cyrl.json
M i18n/aeb-arab.json
M i18n/aeb-latn.json
M i18n/aeb.json
M i18n/af.json
M i18n/ak.json
M i18n/am.json
M i18n/an.json
M i18n/ang.json
M i18n/anp.json
M i18n/ar.json
M i18n/arc.json
M i18n/arn.json
M i18n/arq.json
M i18n/ary.json
M i18n/arz.json
M i18n/as.json
M i18n/ase.json
M i18n/ast.json
M i18n/atj.json
M i18n/av.json
M i18n/awa.json
M i18n/az.json
M i18n/azb.json
M i18n/ba.json
M i18n/bar.json
M i18n/bcl.json
M i18n/be-tarask.json
M i18n/be.json
M i18n/bg.json
M i18n/bgn.json
M i18n/bho.json
M i18n/bn.json
M i18n/bo.json
M i18n/bqi.json
M i18n/br.json
M i18n/brh.json
M i18n/brx.json
M i18n/bs.json
M i18n/ca.json
M i18n/cdo.json
M i18n/ce.json
M i18n/ceb.json
M i18n/cjy-hant.json
M i18n/ckb.json
M i18n/co.json
M i18n/crh-cyrl.json
M i18n/crh-latn.json
M i18n/cs.json
M i18n/csb.json
M i18n/cu.json
M i18n/cv.json
M i18n/cy.json
M i18n/da.json
M i18n/de-ch.json
M i18n/de-formal.json
M i18n/de.json
M i18n/din.json
M i18n/diq.json
M i18n/dsb.json
M i18n/dtp.json
M i18n/dty.json
M i18n/ee.json
M i18n/egl.json
M i18n/el.json
M i18n/eml.json
M i18n/en-gb.json
M i18n/en.json
M i18n/eo.json
M i18n/es-formal.json
M i18n/es.json
M i18n/et.json
M i18n/eu.json
M i18n/ext.json
M i18n/fa.json
M i18n/fi.json
M i18n/fo.json
M i18n/fr.json
M i18n/frc.json
M i18n/frp.json
M i18n/frr.json
M i18n/fur.json
M i18n/fy.json
M i18n/ga.json
M i18n/gcf.json
M i18n/gd.json
M i18n/gl.json
M i18n/glk.json
M i18n/gn.json
M i18n/gom-deva.json
M i18n/gom-latn.json
M i18n/gor.json
M i18n/grc.json
M i18n/gsw.json
M i18n/gu.json
M i18n/gv.json
M i18n/ha.json
M i18n/hak.json
M i18n/haw.json
M i18n/he.json
M i18n/hi.json
M i18n/hif-latn.json
M i18n/hil.json
M i18n/hr.json
M i18n/hrx.json
M i18n/hsb.json
M i18n/ht.json
M i18n/hu-formal.json
M i18n/hu.json
M i18n/hy.json
M i18n/ia.json
M i18n/id.json
M i18n/ie.json
M i18n/ig.json
M i18n/ilo.json
M i18n/inh.json
M i18n/io.json
M i18n/is.json
M i18n/it.json
M i18n/ja.json
M i18n/jam.json
M i18n/jbo.json
M i18n/jut.json
M i18n/jv.json
M i18n/ka.json
M i18n/kbd-cyrl.json
M i18n/kbp.json
M i18n/kea.json
M i18n/kg.json
M i18n/khw.json
M i18n/kiu.json
M i18n/kk-cyrl.json
M i18n/kl.json
M i18n/km.json
M i18n/kn.json
M i18n/ko.json
M i18n/krc.json
M i18n/kri.json
M i18n/krl.json
M i18n/ksh.json
M i18n/ku-latn.json
M i18n/ku.json
M i18n/kv.json
M i18n/kw.json
M i18n/ky.json
M i18n/la.json
M i18n/lad.json
M i18n/lag.json
M i18n/lb.json
M i18n/lez.json
M i18n/lfn.json
M i18n/li.json
M i18n/lij.json
M i18n/liv.json
M i18n/lki.json
M i18n/lmo.json
M i18n/ln.json
M i18n/lo.json
M i18n/lrc.json
M i18n/lt.json
M i18n/ltg.json
M i18n/lus.json
M i18n/luz.json
M i18n/lv.json
M i18n/lzh.json
M i18n/lzz.json
M i18n/mai.json
M i18n/map-bms.json
M i18n/mg.json
M i18n/mhr.json
M i18n/mi.json
M i18n/min.json
M i18n/mk.json
M i18n/ml.json
M i18n/mn.json
M i18n/mnc.json
M i18n/mo.json
M i18n/mr.json
M i18n/ms.json
M i18n/mt.json
M i18n/my.json
M i18n/myv.json
M i18n/mzn.json
M i18n/nah.json
M i18n/nan.json
M i18n/nap.json
M i18n/nb.json
M i18n/nds-nl.json
M i18n/nds.json
M i18n/ne.json
M i18n/nl-informal.json
M i18n/nl.json
M i18n/nn.json
M i18n/nqo.json
M i18n/nso.json
M i18n/oc.json
M i18n/olo.json
M i18n/om.json
M i18n/or.json
M i18n/os.json
M i18n/ovd.json
M i18n/pa.json
M i18n/pam.json
M i18n/pap.json
M i18n/pdc.json
M i18n/pfl.json
M i18n/pl.json
M i18n/pms.json
M i18n/pnb.json
M i18n/prs.json
M i18n/ps.json
M i18n/pt-br.json
M i18n/pt.json
M i18n/qqq.json
M i18n/qu.json
M i18n/rif.json
M i18n/rm.json
M i18n/ro.json
M i18n/roa-tara.json
M i18n/ru.json
M i18n/rue.json
M i18n/sa.json
M i18n/sah.json
M i18n/sat.json
M i18n/sc.json
M i18n/scn.json
M i18n/sco.json
M i18n/sd.json
M i18n/sdc.json
M i18n/sdh.json
M i18n/sgs.json
M i18n/sh.json
M i18n/shi.json
M i18n/shn.json
M i18n/shy-latn.json
M i18n/si.json
M i18n/sk.json
M i18n/sl.json
M i18n/so.json
M i18n/sq.json
M i18n/sr-ec.json
M i18n/sr-el.json
M i18n/ss.json
M i18n/sty.json
M i18n/su.json
M i18n/sv.json
M i18n/sw.json
M i18n/szl.json
M i18n/ta.json
M i18n/tay.json
M i18n/tcy.json
M i18n/te.json
M i18n/tet.json
M i18n/tg-cyrl.json
M i18n/tg-latn.json
M i18n/th.json
M i18n/tk.json
M i18n/tl.json
M i18n/tly.json
M i18n/tokipona.json
M i18n/tpi.json
M i18n/tr.json
M i18n/tru.json
M i18n/tt-cyrl.json
M i18n/tt-latn.json
M i18n/ttt.json
M i18n/tyv.json
M i18n/tzm.json
M i18n/udm.json
M i18n/ug-arab.json
M i18n/uk.json
M i18n/ur.json
M i18n/uz.json
M i18n/vec.json
M i18n/vep.json
M i18n/vi.json
M i18n/vmf.json
M i18n/vo.json
M i18n/vro.json

[MediaWiki-commits] [Gerrit] labs...stashbot[master]: Update for ElasticSearch 5.x

2017-07-13 Thread BryanDavis (Code Review)

BryanDavis has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/365178 )

Change subject: Update for ElasticSearch 5.x
..

Update for ElasticSearch 5.x

Bug: T164842
Change-Id: I2a23b5bd4d3038728b3b9d4c6ff37648193f55bb
---
M requirements.txt
M stashbot/es.py
2 files changed, 2 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/labs/tools/stashbot 
refs/changes/78/365178/1

diff --git a/requirements.txt b/requirements.txt
index 5767947..733e0c3 100644
--- a/requirements.txt
+++ b/requirements.txt
@@ -1,4 +1,4 @@
-elasticsearch>=1.0.0,<2.0.0
+elasticsearch>=5.0.0,<6.0.0
 ib3==0.1.0
 irc>=15.0.3
 ldap3==1.4.0
diff --git a/stashbot/es.py b/stashbot/es.py
index f84cf5c..fc78c62 100644
--- a/stashbot/es.py
+++ b/stashbot/es.py
@@ -47,8 +47,7 @@
 """Store a document in Elasticsearch."""
 try:
 return self.es.index(
-index=index, doc_type=doc_type, body=body,
-consistency="one")
+index=index, doc_type=doc_type, body=body)
 except elasticsearch.ConnectionError as e:
 self.logger.exception(
 'Failed to log to elasticsearch: %s', e.error)

-- 
To view, visit https://gerrit.wikimedia.org/r/365178
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2a23b5bd4d3038728b3b9d4c6ff37648193f55bb
Gerrit-PatchSet: 1
Gerrit-Project: labs/tools/stashbot
Gerrit-Branch: master
Gerrit-Owner: BryanDavis 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] pywikibot/core[master]: [bugfix] Fix ResourceWarning in wikimedia_sites.py with python3

2017-07-13 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/364976 )

Change subject: [bugfix] Fix ResourceWarning in wikimedia_sites.py with python3
..


[bugfix] Fix ResourceWarning in wikimedia_sites.py with python3

Bug: T166459
Change-Id: I8933eac547a02da14fd06e27e8c900d5c330680b
---
M scripts/maintenance/wikimedia_sites.py
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Mpaa: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/scripts/maintenance/wikimedia_sites.py 
b/scripts/maintenance/wikimedia_sites.py
index 38054ab..df3ac6a 100755
--- a/scripts/maintenance/wikimedia_sites.py
+++ b/scripts/maintenance/wikimedia_sites.py
@@ -83,8 +83,8 @@
 text += u']'
 pywikibot.output(text)
 family_file_name = 'pywikibot/families/%s_family.py' % family
-family_file = codecs.open(family_file_name, 'r', 'utf8')
-family_text = family_file.read()
+with codecs.open(family_file_name, 'r', 'utf8') as family_file:
+family_text = family_file.read()
 family_text = re.sub(r'(?msu)^ {8}self.languages_by_size.+?\]',
  text, family_text)
 with codecs.open(family_file_name, 'w', 'utf8') as family_file:

-- 
To view, visit https://gerrit.wikimedia.org/r/364976
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8933eac547a02da14fd06e27e8c900d5c330680b
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Xqt 
Gerrit-Reviewer: John Vandenberg 
Gerrit-Reviewer: Magul 
Gerrit-Reviewer: Mpaa 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...PageAssessments[master]: Fix DB timeout from API queries without project specified

2017-07-13 Thread Kaldari (Code Review)

Kaldari has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/365177 )

Change subject: Fix DB timeout from API queries without project specified
..

Fix DB timeout from API queries without project specified

Bug: T170638
Change-Id: I2c878f173b7f9ec353750b70ed1b19df019a47d9
---
M api/ApiQueryProjectPages.php
1 file changed, 6 insertions(+), 5 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/PageAssessments 
refs/changes/77/365177/1

diff --git a/api/ApiQueryProjectPages.php b/api/ApiQueryProjectPages.php
index b903cb4..4c4969d 100644
--- a/api/ApiQueryProjectPages.php
+++ b/api/ApiQueryProjectPages.php
@@ -42,8 +42,8 @@
 
$this->buildDbQuery( $params, $resultPageSet );
 
-   // If matching projects were found, or no specific projects 
were requested, run the query.
-   if ( $this->projectIds || !$params['projects'] ) {
+   // If matching projects were found, run the query.
+   if ( $this->projectIds ) {
$db_res = $this->select( __METHOD__ );
// Otherwise, just set the result to an empty array (still 
works with foreach).
} else {
@@ -157,8 +157,8 @@
$this->handleQueryContinuation( $params['continue'] );
}
 
-   // If more than 1 project is requested (or all projects), order 
by project first.
-   if ( count( $this->projectIds ) !== 1 ) {
+   // If more than 1 project is requested, order by project first.
+   if ( count( $this->projectIds ) > 1 ) {
$this->addOption( 'ORDER BY', 'pa_project_id, 
pa_page_id' );
} else {
$this->addOption( 'ORDER BY', 'pa_page_id' );
@@ -205,7 +205,8 @@
ApiBase::PARAM_TYPE => 'boolean',
],
'projects' => [
-   ApiBase::PARAM_ISMULTI => true
+   ApiBase::PARAM_ISMULTI => true,
+   ApiBase::PARAM_REQUIRED => true,
],
'limit' => [
ApiBase::PARAM_DFLT => '10',

-- 
To view, visit https://gerrit.wikimedia.org/r/365177
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2c878f173b7f9ec353750b70ed1b19df019a47d9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/PageAssessments
Gerrit-Branch: master
Gerrit-Owner: Kaldari 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...FundraiserLandingPage[master]: build: Updating mediawiki/mediawiki-codesniffer to 0.10.0

2017-07-13 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/363973 )

Change subject: build: Updating mediawiki/mediawiki-codesniffer to 0.10.0
..


build: Updating mediawiki/mediawiki-codesniffer to 0.10.0

Change-Id: I85ac8a333b8a6e2a4b378ae137c6acdd3a1ed7c8
---
M FundraiserLandingPage.body.php
M FundraiserLandingPage.hooks.php
M FundraiserRedirector.body.php
M composer.json
M phpcs.xml
5 files changed, 19 insertions(+), 16 deletions(-)

Approvals:
  jenkins-bot: Verified
  Ejegg: Looks good to me, approved



diff --git a/FundraiserLandingPage.body.php b/FundraiserLandingPage.body.php
index 07eaf8f..034326f 100644
--- a/FundraiserLandingPage.body.php
+++ b/FundraiserLandingPage.body.php
@@ -5,7 +5,7 @@
  *
  * @author Peter Gehres 
  */
-class FundraiserLandingPage extends UnlistedSpecialPage  {
+class FundraiserLandingPage extends UnlistedSpecialPage {
function __construct() {
parent::__construct( 'FundraiserLandingPage' );
}
@@ -17,7 +17,7 @@
 
if ( $wgContributionTrackingFundraiserMaintenance
|| $wgContributionTrackingFundraiserMaintenanceUnsched
-   ){
+   ) {
$this->getOutput()->redirect(
Title::newFromText( 
'Special:FundraiserMaintenance' )->getFullURL(), '302'
);
@@ -122,10 +122,10 @@
 * Country, Root. It is assumed that all parts of the title are 
separated
 * with '/'.
 *
-* @param Parser $parser   Reference to the WM parser object
-* @param string $page The template page root to load
+* @param Parser $parser Reference to the WM parser object
+* @param string $page The template page root to load
 * @param string $language The language to attempt to localize onto
-* @param string $country  The country to attempt to localize onto
+* @param string $country The country to attempt to localize onto
 *
 * @return string The wikitext template
 */
@@ -156,9 +156,9 @@
 * Language, Root. It is assumed that all parts of the title are 
separated
 * with '/'.
 *
-* @param Parser $parser   Reference to the WM parser object
-* @param string $page The template page root to load
-* @param string $country  The country to attempt to localize onto
+* @param Parser $parser Reference to the WM parser object
+* @param string $page The template page root to load
+* @param string $country The country to attempt to localize onto
 * @param string $language The language to attempt to localize onto
 *
 * @return string The wikitext template
diff --git a/FundraiserLandingPage.hooks.php b/FundraiserLandingPage.hooks.php
index dee6a63..25f6136 100644
--- a/FundraiserLandingPage.hooks.php
+++ b/FundraiserLandingPage.hooks.php
@@ -4,7 +4,7 @@
 * Register the parser function hooks 'switchlanguage' and 
'switchcountry'
 * with the MW backend.
 *
-* @param $parser Parser The MW parser object to hook into.
+* @param Parser &$parser The MW parser object to hook into.
 *
 * @return bool Always true
 */
diff --git a/FundraiserRedirector.body.php b/FundraiserRedirector.body.php
index f548e55..a1becd2 100644
--- a/FundraiserRedirector.body.php
+++ b/FundraiserRedirector.body.php
@@ -47,7 +47,8 @@
if ( in_array( $tryLanguage, $mwLanguages ) ) {
// use the language if it is supported 
in MediaWiki
$language = $tryLanguage;
-   break; // don't search further
+   // don't search further
+   break;
}
}
}
@@ -76,22 +77,22 @@
 
// if the country is covered by a payment-processing chapter, 
redirect
// the donor to the chapter's default landing page
-   if ( array_key_exists( $params['country'], 
$wgFundraiserLandingPageChapters ) ){
+   if ( array_key_exists( $params['country'], 
$wgFundraiserLandingPageChapters ) ) {
// Get the message key for the chapter's landing page
$message_key = $wgFundraiserLandingPageChapters[ 
$params['country'] ];
// Get the url for the chapter's landing page
$message = $this->msg( $message_key )->plain();
// if the message is not equal to the default message 
that is returned
// for a missing message, set the redirect URL to the 
message
-   if (

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[wmf/1.30.0-wmf.9]: Revert "Minerva is its own skin"

2017-07-13 Thread Jdlrobson (Code Review)

Hello Chad, Niedzielski, jenkins-bot, Siebrand,

I'd like you to do a code review.  Please visit

https://gerrit.wikimedia.org/r/365176

to review the following change.


Change subject: Revert "Minerva is its own skin"
..

Revert "Minerva is its own skin"

This reverts commit 7246d64e0909a9bd1b9e088b3763a4bfdbf7c691.

Minerva is not enabled yet so without this we get a
 wgMFDefaultSkinClass RuntimeException

Change-Id: I1413bd4faa47ae5165589bba73906eab257f2539
---
M extension.json
M i18n/ab.json
M i18n/ace.json
M i18n/ady-cyrl.json
M i18n/aeb-arab.json
M i18n/aeb-latn.json
M i18n/aeb.json
M i18n/af.json
M i18n/ak.json
M i18n/am.json
M i18n/an.json
M i18n/ang.json
M i18n/anp.json
M i18n/ar.json
M i18n/arc.json
M i18n/arn.json
M i18n/arq.json
M i18n/ary.json
M i18n/arz.json
M i18n/as.json
M i18n/ase.json
M i18n/ast.json
M i18n/atj.json
M i18n/av.json
M i18n/awa.json
M i18n/az.json
M i18n/azb.json
M i18n/ba.json
M i18n/bar.json
M i18n/bcl.json
M i18n/be-tarask.json
M i18n/be.json
M i18n/bg.json
M i18n/bgn.json
M i18n/bho.json
M i18n/bn.json
M i18n/bo.json
M i18n/bqi.json
M i18n/br.json
M i18n/brh.json
M i18n/brx.json
M i18n/bs.json
M i18n/ca.json
M i18n/cdo.json
M i18n/ce.json
M i18n/ceb.json
M i18n/cjy-hant.json
M i18n/ckb.json
M i18n/co.json
M i18n/crh-cyrl.json
M i18n/crh-latn.json
M i18n/cs.json
M i18n/csb.json
M i18n/cu.json
M i18n/cv.json
M i18n/cy.json
M i18n/da.json
M i18n/de-ch.json
M i18n/de-formal.json
M i18n/de.json
M i18n/din.json
M i18n/diq.json
M i18n/dsb.json
M i18n/dtp.json
M i18n/dty.json
M i18n/ee.json
M i18n/egl.json
M i18n/el.json
M i18n/eml.json
M i18n/en-gb.json
M i18n/en.json
M i18n/eo.json
M i18n/es-formal.json
M i18n/es.json
M i18n/et.json
M i18n/eu.json
M i18n/ext.json
M i18n/fa.json
M i18n/fi.json
M i18n/fo.json
M i18n/fr.json
M i18n/frc.json
M i18n/frp.json
M i18n/frr.json
M i18n/fur.json
M i18n/fy.json
M i18n/ga.json
M i18n/gcf.json
M i18n/gd.json
M i18n/gl.json
M i18n/glk.json
M i18n/gn.json
M i18n/gom-deva.json
M i18n/gom-latn.json
M i18n/gor.json
M i18n/grc.json
M i18n/gsw.json
M i18n/gu.json
M i18n/gv.json
M i18n/ha.json
M i18n/hak.json
M i18n/haw.json
M i18n/he.json
M i18n/hi.json
M i18n/hif-latn.json
M i18n/hil.json
M i18n/hr.json
M i18n/hrx.json
M i18n/hsb.json
M i18n/ht.json
M i18n/hu-formal.json
M i18n/hu.json
M i18n/hy.json
M i18n/ia.json
M i18n/id.json
M i18n/ie.json
M i18n/ig.json
M i18n/ilo.json
M i18n/inh.json
M i18n/io.json
M i18n/is.json
M i18n/it.json
M i18n/ja.json
M i18n/jam.json
M i18n/jbo.json
M i18n/jut.json
M i18n/jv.json
M i18n/ka.json
M i18n/kbd-cyrl.json
M i18n/kbp.json
M i18n/kea.json
M i18n/kg.json
M i18n/khw.json
M i18n/kiu.json
M i18n/kk-cyrl.json
M i18n/kl.json
M i18n/km.json
M i18n/kn.json
M i18n/ko.json
M i18n/krc.json
M i18n/kri.json
M i18n/krl.json
M i18n/ksh.json
M i18n/ku-latn.json
M i18n/ku.json
M i18n/kv.json
M i18n/kw.json
M i18n/ky.json
M i18n/la.json
M i18n/lad.json
M i18n/lag.json
M i18n/lb.json
M i18n/lez.json
M i18n/lfn.json
M i18n/li.json
M i18n/lij.json
M i18n/liv.json
M i18n/lki.json
M i18n/lmo.json
M i18n/ln.json
M i18n/lo.json
M i18n/lrc.json
M i18n/lt.json
M i18n/ltg.json
M i18n/lus.json
M i18n/luz.json
M i18n/lv.json
M i18n/lzh.json
M i18n/lzz.json
M i18n/mai.json
M i18n/map-bms.json
M i18n/mg.json
M i18n/mhr.json
M i18n/mi.json
M i18n/min.json
M i18n/mk.json
M i18n/ml.json
M i18n/mn.json
M i18n/mnc.json
M i18n/mo.json
M i18n/mr.json
M i18n/ms.json
M i18n/mt.json
M i18n/my.json
M i18n/myv.json
M i18n/mzn.json
M i18n/nah.json
M i18n/nan.json
M i18n/nap.json
M i18n/nb.json
M i18n/nds-nl.json
M i18n/nds.json
M i18n/ne.json
M i18n/nl-informal.json
M i18n/nl.json
M i18n/nn.json
M i18n/nqo.json
M i18n/nso.json
M i18n/oc.json
M i18n/olo.json
M i18n/om.json
M i18n/or.json
M i18n/os.json
M i18n/ovd.json
M i18n/pa.json
M i18n/pam.json
M i18n/pap.json
M i18n/pdc.json
M i18n/pfl.json
M i18n/pl.json
M i18n/pms.json
M i18n/pnb.json
M i18n/prs.json
M i18n/ps.json
M i18n/pt-br.json
M i18n/pt.json
M i18n/qqq.json
M i18n/qu.json
M i18n/rif.json
M i18n/rm.json
M i18n/ro.json
M i18n/roa-tara.json
M i18n/ru.json
M i18n/rue.json
M i18n/sa.json
M i18n/sah.json
M i18n/sat.json
M i18n/sc.json
M i18n/scn.json
M i18n/sco.json
M i18n/sd.json
M i18n/sdc.json
M i18n/sdh.json
M i18n/sgs.json
M i18n/sh.json
M i18n/shi.json
M i18n/shn.json
M i18n/shy-latn.json
M i18n/si.json
M i18n/sk.json
M i18n/sl.json
M i18n/so.json
M i18n/sq.json
M i18n/sr-ec.json
M i18n/sr-el.json
M i18n/ss.json
M i18n/sty.json
M i18n/su.json
M i18n/sv.json
M i18n/sw.json
M i18n/szl.json
M i18n/ta.json
M i18n/tay.json
M i18n/tcy.json
M i18n/te.json
M i18n/tet.json
M i18n/tg-cyrl.json
M i18n/tg-latn.json
M i18n/th.json
M i18n/tk.json
M i18n/tl.json
M i18n/tly.json
M i18n/tokipona.json
M i18n/tpi.json
M i18n/tr.json
M i18n/tru.json
M i18n/tt-cyrl.json
M i18n/tt-latn.json
M i18n/ttt.json
M i18n/tyv.json
M i18n/tzm.json
M i18n/udm.json
M i18n/ug-arab.json
M i18n/uk.json
M i18n/ur.json
M i18n/uz.json
M i18n/vec.json
M

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseMediaInfo[master]: Remove auto-generated "Constructor" documentation on constru...

2017-07-13 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/363363 )

Change subject: Remove auto-generated "Constructor" documentation on 
constructors
..


Remove auto-generated "Constructor" documentation on constructors

Having such comments is worse than not having them. They add zero
information. But you must read the text to understand there is
nothing you don't already know from the class and the method name.

Change-Id: I206d0749fbf98984813365966b57822efc7eec7e
---
M src/Content/MissingMediaInfoHandler.php
M src/Services/MediaInfoIdLookup.php
2 files changed, 0 insertions(+), 4 deletions(-)

Approvals:
  Addshore: Looks good to me, approved
  jenkins-bot: Verified
  Thiemo Mättig (WMDE): Looks good to me, approved



diff --git a/src/Content/MissingMediaInfoHandler.php 
b/src/Content/MissingMediaInfoHandler.php
index 6467079..d6f606e 100644
--- a/src/Content/MissingMediaInfoHandler.php
+++ b/src/Content/MissingMediaInfoHandler.php
@@ -34,8 +34,6 @@
private $outputGeneratorFactory;
 
/**
-* MissingMediaInfoHandler constructor.
-*
 * @param MediaInfoIdLookup $idLookup
 * @param FilePageLookup $filePageLookup
 * @param EntityParserOutputGeneratorFactory $outputGeneratorFactory
diff --git a/src/Services/MediaInfoIdLookup.php 
b/src/Services/MediaInfoIdLookup.php
index fbbba5d..91d93a3 100644
--- a/src/Services/MediaInfoIdLookup.php
+++ b/src/Services/MediaInfoIdLookup.php
@@ -21,8 +21,6 @@
private $mediaInfoNamespace;
 
/**
-* MediaInfoIdLookup constructor.
-*
 * @param int $mediaInfoNamespace numeric namespace ID of the namespace 
in which MediaInfo
 * entities reside.
 */

-- 
To view, visit https://gerrit.wikimedia.org/r/363363
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I206d0749fbf98984813365966b57822efc7eec7e
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/WikibaseMediaInfo
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) 
Gerrit-Reviewer: Addshore 
Gerrit-Reviewer: Thiemo Mättig (WMDE) 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Revert "Enable MinervaNeue everywhere"

2017-07-13 Thread Chad (Code Review)

Chad has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/365175 )

Change subject: Revert "Enable MinervaNeue everywhere"
..


Revert "Enable MinervaNeue everywhere"

Nope

This reverts commit 7ae4f9f9c94457ad81a0c0218f33b9672a07b0ce.

Change-Id: Ib4c9bccef022190137432adc0d799c10c845f087
---
M wmf-config/InitialiseSettings.php
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Chad: Verified; Looks good to me, approved



diff --git a/wmf-config/InitialiseSettings.php 
b/wmf-config/InitialiseSettings.php
index 9813f34..7f8121d 100644
--- a/wmf-config/InitialiseSettings.php
+++ b/wmf-config/InitialiseSettings.php
@@ -15011,7 +15011,8 @@
 ],
 
 'wmgMinervaNeue' => [
-   'default' => true,
+   'default' => false,
+   'testwiki' => true,
 ],
 'wmgUseMobileApp' => [
'default' => true,

-- 
To view, visit https://gerrit.wikimedia.org/r/365175
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib4c9bccef022190137432adc0d799c10c845f087
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Chad 
Gerrit-Reviewer: Chad 
Gerrit-Reviewer: Florianschmidtwelzow 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Revert "Enable MinervaNeue everywhere"

2017-07-13 Thread Chad (Code Review)

Hello Florianschmidtwelzow, jenkins-bot,

I'd like you to do a code review.  Please visit

https://gerrit.wikimedia.org/r/365175

to review the following change.


Change subject: Revert "Enable MinervaNeue everywhere"
..

Revert "Enable MinervaNeue everywhere"

Nope

This reverts commit 7ae4f9f9c94457ad81a0c0218f33b9672a07b0ce.

Change-Id: Ib4c9bccef022190137432adc0d799c10c845f087
---
M wmf-config/InitialiseSettings.php
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/75/365175/1

diff --git a/wmf-config/InitialiseSettings.php 
b/wmf-config/InitialiseSettings.php
index 9813f34..7f8121d 100644
--- a/wmf-config/InitialiseSettings.php
+++ b/wmf-config/InitialiseSettings.php
@@ -15011,7 +15011,8 @@
 ],
 
 'wmgMinervaNeue' => [
-   'default' => true,
+   'default' => false,
+   'testwiki' => true,
 ],
 'wmgUseMobileApp' => [
'default' => true,

-- 
To view, visit https://gerrit.wikimedia.org/r/365175
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib4c9bccef022190137432adc0d799c10c845f087
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Chad 
Gerrit-Reviewer: Florianschmidtwelzow 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: labweb100[12] install params

2017-07-13 Thread RobH (Code Review)

RobH has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/365173 )

Change subject: labweb100[12] install params
..


labweb100[12] install params

update to dhcp lease file as well as netboot.cfg

Bug:T167820
Change-Id: Id4de307ffea0720d4b63af8b09fd48d1b549a0ed
---
M modules/install_server/files/autoinstall/netboot.cfg
M modules/install_server/files/dhcpd/linux-host-entries.ttyS1-115200
2 files changed, 11 insertions(+), 1 deletion(-)

Approvals:
  RobH: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/install_server/files/autoinstall/netboot.cfg 
b/modules/install_server/files/autoinstall/netboot.cfg
index b39bc85..d9291ea 100755
--- a/modules/install_server/files/autoinstall/netboot.cfg
+++ b/modules/install_server/files/autoinstall/netboot.cfg
@@ -98,7 +98,7 @@
 labsdb100[67]) echo partman/raid5-gpt-lvm.cfg ;; \
 labsdb[1-3]|labsdb100[1-3]) echo partman/mw.cfg ;; \
 sodium) echo partman/lvm-ext-srv.cfg ;; \
-labpuppetmaster100[12]|labnodepool1002) echo 
partman/raid1-lvm-ext4-srv-noswap.cfg;; \
+labpuppetmaster100[12]|labnodepool1002|labweb100[12]) echo 
partman/raid1-lvm-ext4-srv-noswap.cfg;; \
 labstore200[1-4]) echo partman/labstore-lvm-noraid.cfg ;; \
 labtestneutron2001) echo partman/mw.cfg ;; \
 labtestnet2001) echo partman/raid1.cfg ;; \
diff --git a/modules/install_server/files/dhcpd/linux-host-entries.ttyS1-115200 
b/modules/install_server/files/dhcpd/linux-host-entries.ttyS1-115200
index 9f9b323..d358ca8 100644
--- a/modules/install_server/files/dhcpd/linux-host-entries.ttyS1-115200
+++ b/modules/install_server/files/dhcpd/linux-host-entries.ttyS1-115200
@@ -3013,6 +3013,16 @@
 filename "trusty-installer/ubuntu-installer/amd64/pxelinux.0";
 }
 
+host labweb1001 {
+hardware ethernet 18:66:DA:A5:0B:57;
+fixed-address labweb1001.wikimedia.org;
+}
+
+host labweb1002 {
+hardware ethernet 18:66:DA:A5:07:E1;
+fixed-address labweb1002.wikimedia.org;
+}
+
 host lithium {
 hardware ethernet C8:1F:66:BF:7F:EA;
 fixed-address lithium.eqiad.wmnet;

-- 
To view, visit https://gerrit.wikimedia.org/r/365173
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id4de307ffea0720d4b63af8b09fd48d1b549a0ed
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: RobH 
Gerrit-Reviewer: RobH 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: labspuppetbackend: Include some more python dependencies fo...

2017-07-13 Thread Andrew Bogott (Code Review)

Andrew Bogott has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/365174 )

Change subject: labspuppetbackend:  Include some more python dependencies for 
jessie.
..

labspuppetbackend:  Include some more python dependencies for jessie.

Change-Id: I5eb4ffdf36ff95e0be30f86ca93c705a2fa7c3d4
---
M modules/labspuppetbackend/manifests/init.pp
1 file changed, 6 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/74/365174/1

diff --git a/modules/labspuppetbackend/manifests/init.pp 
b/modules/labspuppetbackend/manifests/init.pp
index a89c002..cbb5dcd 100644
--- a/modules/labspuppetbackend/manifests/init.pp
+++ b/modules/labspuppetbackend/manifests/init.pp
@@ -11,6 +11,12 @@
 'python3-flask',
 'python3-yaml')
 
+if os_version('|| debian >= jessie') {
+require_package('python-flask',
+'python-pymysql',
+'python-statsd',
+'python-yaml')
+
 
 file { '/usr/local/lib/python3.4/dist-packages/labspuppetbackend.py':
 source => 'puppet:///modules/labspuppetbackend/labspuppetbackend.py',

-- 
To view, visit https://gerrit.wikimedia.org/r/365174
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5eb4ffdf36ff95e0be30f86ca93c705a2fa7c3d4
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Andrew Bogott 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Enable MinervaNeue everywhere

2017-07-13 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/365172 )

Change subject: Enable MinervaNeue everywhere
..


Enable MinervaNeue everywhere

Change-Id: I8303a131e5584900899743f45480e42e7e907e99
---
M wmf-config/InitialiseSettings.php
1 file changed, 1 insertion(+), 2 deletions(-)

Approvals:
  Chad: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/wmf-config/InitialiseSettings.php 
b/wmf-config/InitialiseSettings.php
index 7f8121d..9813f34 100644
--- a/wmf-config/InitialiseSettings.php
+++ b/wmf-config/InitialiseSettings.php
@@ -15011,8 +15011,7 @@
 ],
 
 'wmgMinervaNeue' => [
-   'default' => false,
-   'testwiki' => true,
+   'default' => true,
 ],
 'wmgUseMobileApp' => [
'default' => true,

-- 
To view, visit https://gerrit.wikimedia.org/r/365172
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8303a131e5584900899743f45480e42e7e907e99
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Chad 
Gerrit-Reviewer: Chad 
Gerrit-Reviewer: Florianschmidtwelzow 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: labweb100[12] install params

2017-07-13 Thread RobH (Code Review)

RobH has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/365173 )

Change subject: labweb100[12] install params
..

labweb100[12] install params

update to dhcp lease file as well as netboot.cfg

Bug:T167820
Change-Id: Id4de307ffea0720d4b63af8b09fd48d1b549a0ed
---
M modules/install_server/files/autoinstall/netboot.cfg
M modules/install_server/files/dhcpd/linux-host-entries.ttyS1-115200
2 files changed, 11 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/73/365173/1

diff --git a/modules/install_server/files/autoinstall/netboot.cfg 
b/modules/install_server/files/autoinstall/netboot.cfg
index b39bc85..d9291ea 100755
--- a/modules/install_server/files/autoinstall/netboot.cfg
+++ b/modules/install_server/files/autoinstall/netboot.cfg
@@ -98,7 +98,7 @@
 labsdb100[67]) echo partman/raid5-gpt-lvm.cfg ;; \
 labsdb[1-3]|labsdb100[1-3]) echo partman/mw.cfg ;; \
 sodium) echo partman/lvm-ext-srv.cfg ;; \
-labpuppetmaster100[12]|labnodepool1002) echo 
partman/raid1-lvm-ext4-srv-noswap.cfg;; \
+labpuppetmaster100[12]|labnodepool1002|labweb100[12]) echo 
partman/raid1-lvm-ext4-srv-noswap.cfg;; \
 labstore200[1-4]) echo partman/labstore-lvm-noraid.cfg ;; \
 labtestneutron2001) echo partman/mw.cfg ;; \
 labtestnet2001) echo partman/raid1.cfg ;; \
diff --git a/modules/install_server/files/dhcpd/linux-host-entries.ttyS1-115200 
b/modules/install_server/files/dhcpd/linux-host-entries.ttyS1-115200
index 9f9b323..d358ca8 100644
--- a/modules/install_server/files/dhcpd/linux-host-entries.ttyS1-115200
+++ b/modules/install_server/files/dhcpd/linux-host-entries.ttyS1-115200
@@ -3013,6 +3013,16 @@
 filename "trusty-installer/ubuntu-installer/amd64/pxelinux.0";
 }
 
+host labweb1001 {
+hardware ethernet 18:66:DA:A5:0B:57;
+fixed-address labweb1001.wikimedia.org;
+}
+
+host labweb1002 {
+hardware ethernet 18:66:DA:A5:07:E1;
+fixed-address labweb1002.wikimedia.org;
+}
+
 host lithium {
 hardware ethernet C8:1F:66:BF:7F:EA;
 fixed-address lithium.eqiad.wmnet;

-- 
To view, visit https://gerrit.wikimedia.org/r/365173
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id4de307ffea0720d4b63af8b09fd48d1b549a0ed
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: RobH 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Enable MinervaNeue everywhere

2017-07-13 Thread Chad (Code Review)

Chad has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/365172 )

Change subject: Enable MinervaNeue everywhere
..

Enable MinervaNeue everywhere

Change-Id: I8303a131e5584900899743f45480e42e7e907e99
---
M wmf-config/InitialiseSettings.php
1 file changed, 1 insertion(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/72/365172/1

diff --git a/wmf-config/InitialiseSettings.php 
b/wmf-config/InitialiseSettings.php
index 7f8121d..9813f34 100644
--- a/wmf-config/InitialiseSettings.php
+++ b/wmf-config/InitialiseSettings.php
@@ -15011,8 +15011,7 @@
 ],
 
 'wmgMinervaNeue' => [
-   'default' => false,
-   'testwiki' => true,
+   'default' => true,
 ],
 'wmgUseMobileApp' => [
'default' => true,

-- 
To view, visit https://gerrit.wikimedia.org/r/365172
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8303a131e5584900899743f45480e42e7e907e99
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Chad 
Gerrit-Reviewer: Chad 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...MinervaNeue[wmf/1.30.0-wmf.9]: Add missing Minerva skin description message key

2017-07-13 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/365165 )

Change subject: Add missing Minerva skin description message key
..


Add missing Minerva skin description message key

Change-Id: I61457e709caa0bfa94a627236f1d04a16f94a166
---
M i18n/en.json
M i18n/qqq.json
2 files changed, 4 insertions(+), 2 deletions(-)

Approvals:
  Chad: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/i18n/en.json b/i18n/en.json
index ebaeadf..49f64c7 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -49,5 +49,6 @@
"mobile-frontend-user-page-member-since": "{{GENDER:$2|Joined}} $1",
"mobile-frontend-user-page-talk": "Talk",
"mobile-frontend-user-page-uploads": "Uploads",
-   "skinname-minerva": "Minerva"
+   "skinname-minerva": "Minerva",
+   "minerva-skin-desc": "A responsive mobile first skin."
 }
\ No newline at end of file
diff --git a/i18n/qqq.json b/i18n/qqq.json
index ae9283c..16901ae 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -49,5 +49,6 @@
"mobile-frontend-user-page-member-since": "Message below the heading. 
$1 is the user registration date. $2 is the gender associated with the user 
account.",
"mobile-frontend-user-page-talk": "Text of the link to the user's talk 
page\n{{Identical|Talk}}",
"mobile-frontend-user-page-uploads": "Text of the link to the user's 
uploads page\n{{Identical|Upload}}",
-   "skinname-minerva": "{{optional}}"
+   "skinname-minerva": "{{optional}}",
+   "minerva-skin-desc": "{{optional}}"
 }
\ No newline at end of file

-- 
To view, visit https://gerrit.wikimedia.org/r/365165
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I61457e709caa0bfa94a627236f1d04a16f94a166
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/MinervaNeue
Gerrit-Branch: wmf/1.30.0-wmf.9
Gerrit-Owner: Chad 
Gerrit-Reviewer: Chad 
Gerrit-Reviewer: Jdlrobson 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...MinervaNeue[wmf/1.30.0-wmf.7]: Add missing Minerva skin description message key

2017-07-13 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/365167 )

Change subject: Add missing Minerva skin description message key
..


Add missing Minerva skin description message key

Change-Id: I61457e709caa0bfa94a627236f1d04a16f94a166
---
M i18n/en.json
M i18n/qqq.json
2 files changed, 4 insertions(+), 2 deletions(-)

Approvals:
  Chad: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/i18n/en.json b/i18n/en.json
index ebaeadf..49f64c7 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -49,5 +49,6 @@
"mobile-frontend-user-page-member-since": "{{GENDER:$2|Joined}} $1",
"mobile-frontend-user-page-talk": "Talk",
"mobile-frontend-user-page-uploads": "Uploads",
-   "skinname-minerva": "Minerva"
+   "skinname-minerva": "Minerva",
+   "minerva-skin-desc": "A responsive mobile first skin."
 }
\ No newline at end of file
diff --git a/i18n/qqq.json b/i18n/qqq.json
index ae9283c..16901ae 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -49,5 +49,6 @@
"mobile-frontend-user-page-member-since": "Message below the heading. 
$1 is the user registration date. $2 is the gender associated with the user 
account.",
"mobile-frontend-user-page-talk": "Text of the link to the user's talk 
page\n{{Identical|Talk}}",
"mobile-frontend-user-page-uploads": "Text of the link to the user's 
uploads page\n{{Identical|Upload}}",
-   "skinname-minerva": "{{optional}}"
+   "skinname-minerva": "{{optional}}",
+   "minerva-skin-desc": "{{optional}}"
 }
\ No newline at end of file

-- 
To view, visit https://gerrit.wikimedia.org/r/365167
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I61457e709caa0bfa94a627236f1d04a16f94a166
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/MinervaNeue
Gerrit-Branch: wmf/1.30.0-wmf.7
Gerrit-Owner: Chad 
Gerrit-Reviewer: Chad 
Gerrit-Reviewer: Jdlrobson 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: add mapped IPv6 address for labtestervices200x

2017-07-13 Thread Dzahn (Code Review)

Dzahn has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/365171 )

Change subject: add mapped IPv6 address for labtestervices200x
..

add mapped IPv6 address for labtestervices200x

When recently adding IPv6 records for labtestpuppetmaster2001
i noticed that, among others, labtestservices2001-2003 don't have
 records yet. They already have IPv6 IPs on the interface
but not the nice "mapped" address.

How would you feel about adding it? Ok for labtestservices*?

Maybe different for 2001 vs 2002/2003?

This would first add the mapped address on the interface, afterwards
i would add the DNS records.

Change-Id: Ia600c1d3c6af1803e1e23b10536759051c4c5264
---
M manifests/site.pp
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/71/365171/1

diff --git a/manifests/site.pp b/manifests/site.pp
index 5db5aa4..3724c95 100644
--- a/manifests/site.pp
+++ b/manifests/site.pp
@@ -1048,11 +1048,13 @@
 labs::dns_floating_ip_updater)
 include ::standard
 include ::base::firewall
+interface::add_ip6_mapped { 'main': }
 }
 
 node /labtestservices200[23]\.wikimedia\.org/ {
 include ::base::firewall
 include ::standard
+interface::add_ip6_mapped { 'main': }
 }
 
 # Primary graphite machines

-- 
To view, visit https://gerrit.wikimedia.org/r/365171
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia600c1d3c6af1803e1e23b10536759051c4c5264
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Dzahn 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Page move with same title shows generic error

2017-07-13 Thread Eugene233 (Code Review)

Eugene233 has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/365170 )

Change subject: Page move with same title shows generic error
..

Page move with same title shows generic error

The error shown when a page is to be moved (renamed) with the same title is not 
immediately obvious
to the user. It therefore has been update in the json file in 
languages/i18n/en.json to specify that
when the file is renamed with the same titled as the previous, then the user 
should be told that the titles
are the same, so that the user is aware.

Bug: T164987
Change-Id: I639c4ae27866234fed9bcc5f2afc4684155418f8
---
M languages/i18n/en.json
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/70/365170/1

diff --git a/languages/i18n/en.json b/languages/i18n/en.json
index 4d51c9e..c688eff 100644
--- a/languages/i18n/en.json
+++ b/languages/i18n/en.json
@@ -2632,7 +2632,7 @@
"delete_and_move_text": "The destination page \"[[:$1]]\" already 
exists.\nDo you want to delete it to make way for the move?",
"delete_and_move_confirm": "Yes, delete the page",
"delete_and_move_reason": "Deleted to make way for move from 
\"[[$1]]\"",
-   "selfmove": "Source and destination titles are the same;\ncannot move a 
page over itself.",
+   "selfmove": " The title is the same;\ncannot move a page over itself.",
"immobile-source-namespace": "Cannot move pages in namespace \"$1\".",
"immobile-target-namespace": "Cannot move pages into namespace \"$1\".",
"immobile-target-namespace-iw": "Interwiki link is not a valid target 
for page move.",

-- 
To view, visit https://gerrit.wikimedia.org/r/365170
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I639c4ae27866234fed9bcc5f2afc4684155418f8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Eugene233 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Update ExtensionDistributer versions

2017-07-13 Thread MacFan4000 (Code Review)

MacFan4000 has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/365137 )

Change subject: Update ExtensionDistributer versions
..

Update ExtensionDistributer versions

Change-Id: I09c13af2bb61438327b916e1d24f43e0e4c260c1
---
M wmf-config/CommonSettings.php
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/37/365137/3

diff --git a/wmf-config/CommonSettings.php b/wmf-config/CommonSettings.php
index fba23f6..d8ca22c 100644
--- a/wmf-config/CommonSettings.php
+++ b/wmf-config/CommonSettings.php
@@ -949,10 +949,10 @@
];
 
// Current stable release
-   $wgExtDistDefaultSnapshot = 'REL1_28';
+   $wgExtDistDefaultSnapshot = 'REL1_29';
 
// Current development snapshot
-   $wgExtDistCandidateSnapshot = 'REL1_29';
+#  $wgExtDistCandidateSnapshot = 'REL1_29';
 
// Available snapshots
$wgExtDistSnapshotRefs = [

-- 
To view, visit https://gerrit.wikimedia.org/r/365137
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I09c13af2bb61438327b916e1d24f43e0e4c260c1
Gerrit-PatchSet: 3
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: MacFan4000 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...MinervaNeue[master]: Add missing Minerva skin description message key

2017-07-13 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/365162 )

Change subject: Add missing Minerva skin description message key
..


Add missing Minerva skin description message key

Change-Id: I61457e709caa0bfa94a627236f1d04a16f94a166
---
M i18n/en.json
M i18n/qqq.json
2 files changed, 4 insertions(+), 2 deletions(-)

Approvals:
  Chad: Looks good to me, approved
  jenkins-bot: Verified
  Jdlrobson: Looks good to me, approved



diff --git a/i18n/en.json b/i18n/en.json
index fd13a79..7884bc9 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -52,5 +52,6 @@
"mobile-frontend-user-page-member-since": "{{GENDER:$2|Joined}} $1",
"mobile-frontend-user-page-talk": "Talk",
"mobile-frontend-user-page-uploads": "Uploads",
-   "skinname-minerva": "Minerva"
+   "skinname-minerva": "Minerva",
+   "minerva-skin-desc": "A responsive mobile first skin."
 }
\ No newline at end of file
diff --git a/i18n/qqq.json b/i18n/qqq.json
index 95d78d9..90583ec 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -52,5 +52,6 @@
"mobile-frontend-user-page-member-since": "Message below the heading. 
$1 is the user registration date. $2 is the gender associated with the user 
account.",
"mobile-frontend-user-page-talk": "Text of the link to the user's talk 
page\n{{Identical|Talk}}",
"mobile-frontend-user-page-uploads": "Text of the link to the user's 
uploads page\n{{Identical|Upload}}",
-   "skinname-minerva": "{{optional}}"
+   "skinname-minerva": "{{optional}}",
+   "minerva-skin-desc": "{{optional}}"
 }
\ No newline at end of file

-- 
To view, visit https://gerrit.wikimedia.org/r/365162
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I61457e709caa0bfa94a627236f1d04a16f94a166
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/MinervaNeue
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson 
Gerrit-Reviewer: Chad 
Gerrit-Reviewer: Jdlrobson 
Gerrit-Reviewer: Niedzielski 
Gerrit-Reviewer: Siebrand 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...MinervaNeue[wmf/1.30.0-wmf.7]: Add missing Minerva skin description message key

2017-07-13 Thread Chad (Code Review)

Chad has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/365167 )

Change subject: Add missing Minerva skin description message key
..

Add missing Minerva skin description message key

Change-Id: I61457e709caa0bfa94a627236f1d04a16f94a166
---
M i18n/en.json
M i18n/qqq.json
2 files changed, 4 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/MinervaNeue 
refs/changes/67/365167/1

diff --git a/i18n/en.json b/i18n/en.json
index ebaeadf..49f64c7 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -49,5 +49,6 @@
"mobile-frontend-user-page-member-since": "{{GENDER:$2|Joined}} $1",
"mobile-frontend-user-page-talk": "Talk",
"mobile-frontend-user-page-uploads": "Uploads",
-   "skinname-minerva": "Minerva"
+   "skinname-minerva": "Minerva",
+   "minerva-skin-desc": "A responsive mobile first skin."
 }
\ No newline at end of file
diff --git a/i18n/qqq.json b/i18n/qqq.json
index ae9283c..16901ae 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -49,5 +49,6 @@
"mobile-frontend-user-page-member-since": "Message below the heading. 
$1 is the user registration date. $2 is the gender associated with the user 
account.",
"mobile-frontend-user-page-talk": "Text of the link to the user's talk 
page\n{{Identical|Talk}}",
"mobile-frontend-user-page-uploads": "Text of the link to the user's 
uploads page\n{{Identical|Upload}}",
-   "skinname-minerva": "{{optional}}"
+   "skinname-minerva": "{{optional}}",
+   "minerva-skin-desc": "{{optional}}"
 }
\ No newline at end of file

-- 
To view, visit https://gerrit.wikimedia.org/r/365167
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I61457e709caa0bfa94a627236f1d04a16f94a166
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/MinervaNeue
Gerrit-Branch: wmf/1.30.0-wmf.7
Gerrit-Owner: Chad 
Gerrit-Reviewer: Jdlrobson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...MinervaNeue[wmf/1.30.0-wmf.9]: Add missing Minerva skin description message key

2017-07-13 Thread Chad (Code Review)

Chad has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/365165 )

Change subject: Add missing Minerva skin description message key
..

Add missing Minerva skin description message key

Change-Id: I61457e709caa0bfa94a627236f1d04a16f94a166
---
M i18n/en.json
M i18n/qqq.json
2 files changed, 4 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/MinervaNeue 
refs/changes/65/365165/1

diff --git a/i18n/en.json b/i18n/en.json
index ebaeadf..49f64c7 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -49,5 +49,6 @@
"mobile-frontend-user-page-member-since": "{{GENDER:$2|Joined}} $1",
"mobile-frontend-user-page-talk": "Talk",
"mobile-frontend-user-page-uploads": "Uploads",
-   "skinname-minerva": "Minerva"
+   "skinname-minerva": "Minerva",
+   "minerva-skin-desc": "A responsive mobile first skin."
 }
\ No newline at end of file
diff --git a/i18n/qqq.json b/i18n/qqq.json
index ae9283c..16901ae 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -49,5 +49,6 @@
"mobile-frontend-user-page-member-since": "Message below the heading. 
$1 is the user registration date. $2 is the gender associated with the user 
account.",
"mobile-frontend-user-page-talk": "Text of the link to the user's talk 
page\n{{Identical|Talk}}",
"mobile-frontend-user-page-uploads": "Text of the link to the user's 
uploads page\n{{Identical|Upload}}",
-   "skinname-minerva": "{{optional}}"
+   "skinname-minerva": "{{optional}}",
+   "minerva-skin-desc": "{{optional}}"
 }
\ No newline at end of file

-- 
To view, visit https://gerrit.wikimedia.org/r/365165
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I61457e709caa0bfa94a627236f1d04a16f94a166
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/MinervaNeue
Gerrit-Branch: wmf/1.30.0-wmf.9
Gerrit-Owner: Chad 
Gerrit-Reviewer: Jdlrobson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...MinervaNeue[master]: Add missing Minerva skin description message key

2017-07-13 Thread Jdlrobson (Code Review)

Jdlrobson has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/365162 )

Change subject: Add missing Minerva skin description message key
..

Add missing Minerva skin description message key

Change-Id: I61457e709caa0bfa94a627236f1d04a16f94a166
---
M i18n/en.json
M i18n/qqq.json
2 files changed, 4 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/MinervaNeue 
refs/changes/62/365162/1

diff --git a/i18n/en.json b/i18n/en.json
index fd13a79..7884bc9 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -52,5 +52,6 @@
"mobile-frontend-user-page-member-since": "{{GENDER:$2|Joined}} $1",
"mobile-frontend-user-page-talk": "Talk",
"mobile-frontend-user-page-uploads": "Uploads",
-   "skinname-minerva": "Minerva"
+   "skinname-minerva": "Minerva",
+   "minerva-skin-desc": "A responsive mobile first skin."
 }
\ No newline at end of file
diff --git a/i18n/qqq.json b/i18n/qqq.json
index 95d78d9..90583ec 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -52,5 +52,6 @@
"mobile-frontend-user-page-member-since": "Message below the heading. 
$1 is the user registration date. $2 is the gender associated with the user 
account.",
"mobile-frontend-user-page-talk": "Text of the link to the user's talk 
page\n{{Identical|Talk}}",
"mobile-frontend-user-page-uploads": "Text of the link to the user's 
uploads page\n{{Identical|Upload}}",
-   "skinname-minerva": "{{optional}}"
+   "skinname-minerva": "{{optional}}",
+   "minerva-skin-desc": "{{optional}}"
 }
\ No newline at end of file

-- 
To view, visit https://gerrit.wikimedia.org/r/365162
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I61457e709caa0bfa94a627236f1d04a16f94a166
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/MinervaNeue
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Move testwiki to MinervaNeue

2017-07-13 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/365093 )

Change subject: Move testwiki to MinervaNeue
..


Move testwiki to MinervaNeue

Change-Id: Id33e3b7dff7d104c51648670e6fc905686cd1173
---
M wmf-config/InitialiseSettings.php
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Chad: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/wmf-config/InitialiseSettings.php 
b/wmf-config/InitialiseSettings.php
index 5d21213..7f8121d 100644
--- a/wmf-config/InitialiseSettings.php
+++ b/wmf-config/InitialiseSettings.php
@@ -15012,6 +15012,7 @@
 
 'wmgMinervaNeue' => [
'default' => false,
+   'testwiki' => true,
 ],
 'wmgUseMobileApp' => [
'default' => true,

-- 
To view, visit https://gerrit.wikimedia.org/r/365093
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id33e3b7dff7d104c51648670e6fc905686cd1173
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Chad 
Gerrit-Reviewer: Chad 
Gerrit-Reviewer: Florianschmidtwelzow 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[wmf/1.30.0-wmf.9]: Minerva is its own skin

2017-07-13 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/365122 )

Change subject: Minerva is its own skin
..


Minerva is its own skin

This patch is the programmatic output of
Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce.

Additional changes:
* Bump version number to 2 as this is a breaking change
* Mark module definitions with resource-modules-disable-line that
will be unused by MobileFrontend after the separation. In future we will
consider whether these modules should be ported to the Minerva skin.

Note: The browser tests will temporarily fail due to the fact
the new MinervaSkin doesn't define Minerva as a valid skin name and
cannot until MobileFrontend (in this patch) releases its definition.
This will be fixed promptly by I7f004b43e11d88492b205a3584c29f72d26bad57

Bug: T166748
Depends-On: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
Change-Id: I985c4e3a88b59461d471945ccf74cd291db45a61
---
M extension.json
M i18n/ab.json
M i18n/ace.json
M i18n/ady-cyrl.json
M i18n/aeb-arab.json
M i18n/aeb-latn.json
M i18n/aeb.json
M i18n/af.json
M i18n/ak.json
M i18n/am.json
M i18n/an.json
M i18n/ang.json
M i18n/anp.json
M i18n/ar.json
M i18n/arc.json
M i18n/arn.json
M i18n/arq.json
M i18n/ary.json
M i18n/arz.json
M i18n/as.json
M i18n/ase.json
M i18n/ast.json
M i18n/atj.json
M i18n/av.json
M i18n/awa.json
M i18n/az.json
M i18n/azb.json
M i18n/ba.json
M i18n/bar.json
M i18n/bcl.json
M i18n/be-tarask.json
M i18n/be.json
M i18n/bg.json
M i18n/bgn.json
M i18n/bho.json
M i18n/bn.json
M i18n/bo.json
M i18n/bqi.json
M i18n/br.json
M i18n/brh.json
M i18n/brx.json
M i18n/bs.json
M i18n/ca.json
M i18n/cdo.json
M i18n/ce.json
M i18n/ceb.json
M i18n/cjy-hant.json
M i18n/ckb.json
M i18n/co.json
M i18n/crh-cyrl.json
M i18n/crh-latn.json
M i18n/cs.json
M i18n/csb.json
M i18n/cu.json
M i18n/cv.json
M i18n/cy.json
M i18n/da.json
M i18n/de-ch.json
M i18n/de-formal.json
M i18n/de.json
M i18n/din.json
M i18n/diq.json
M i18n/dsb.json
M i18n/dtp.json
M i18n/dty.json
M i18n/ee.json
M i18n/egl.json
M i18n/el.json
M i18n/eml.json
M i18n/en-gb.json
M i18n/en.json
M i18n/eo.json
M i18n/es-formal.json
M i18n/es.json
M i18n/et.json
M i18n/eu.json
M i18n/ext.json
M i18n/fa.json
M i18n/fi.json
M i18n/fo.json
M i18n/fr.json
M i18n/frc.json
M i18n/frp.json
M i18n/frr.json
M i18n/fur.json
M i18n/fy.json
M i18n/ga.json
M i18n/gcf.json
M i18n/gd.json
M i18n/gl.json
M i18n/glk.json
M i18n/gn.json
M i18n/gom-deva.json
M i18n/gom-latn.json
M i18n/gor.json
M i18n/grc.json
M i18n/gsw.json
M i18n/gu.json
M i18n/gv.json
M i18n/ha.json
M i18n/hak.json
M i18n/haw.json
M i18n/he.json
M i18n/hi.json
M i18n/hif-latn.json
M i18n/hil.json
M i18n/hr.json
M i18n/hrx.json
M i18n/hsb.json
M i18n/ht.json
M i18n/hu-formal.json
M i18n/hu.json
M i18n/hy.json
M i18n/ia.json
M i18n/id.json
M i18n/ie.json
M i18n/ig.json
M i18n/ilo.json
M i18n/inh.json
M i18n/io.json
M i18n/is.json
M i18n/it.json
M i18n/ja.json
M i18n/jam.json
M i18n/jbo.json
M i18n/jut.json
M i18n/jv.json
M i18n/ka.json
M i18n/kbd-cyrl.json
M i18n/kbp.json
M i18n/kea.json
M i18n/kg.json
M i18n/khw.json
M i18n/kiu.json
M i18n/kk-cyrl.json
M i18n/kl.json
M i18n/km.json
M i18n/kn.json
M i18n/ko.json
M i18n/krc.json
M i18n/kri.json
M i18n/krl.json
M i18n/ksh.json
M i18n/ku-latn.json
M i18n/ku.json
M i18n/kv.json
M i18n/kw.json
M i18n/ky.json
M i18n/la.json
M i18n/lad.json
M i18n/lag.json
M i18n/lb.json
M i18n/lez.json
M i18n/lfn.json
M i18n/li.json
M i18n/lij.json
M i18n/liv.json
M i18n/lki.json
M i18n/lmo.json
M i18n/ln.json
M i18n/lo.json
M i18n/lrc.json
M i18n/lt.json
M i18n/ltg.json
M i18n/lus.json
M i18n/luz.json
M i18n/lv.json
M i18n/lzh.json
M i18n/lzz.json
M i18n/mai.json
M i18n/map-bms.json
M i18n/mg.json
M i18n/mhr.json
M i18n/mi.json
M i18n/min.json
M i18n/mk.json
M i18n/ml.json
M i18n/mn.json
M i18n/mnc.json
M i18n/mo.json
M i18n/mr.json
M i18n/ms.json
M i18n/mt.json
M i18n/my.json
M i18n/myv.json
M i18n/mzn.json
M i18n/nah.json
M i18n/nan.json
M i18n/nap.json
M i18n/nb.json
M i18n/nds-nl.json
M i18n/nds.json
M i18n/ne.json
M i18n/nl-informal.json
M i18n/nl.json
M i18n/nn.json
M i18n/nqo.json
M i18n/nso.json
M i18n/oc.json
M i18n/olo.json
M i18n/om.json
M i18n/or.json
M i18n/os.json
M i18n/ovd.json
M i18n/pa.json
M i18n/pam.json
M i18n/pap.json
M i18n/pdc.json
M i18n/pfl.json
M i18n/pl.json
M i18n/pms.json
M i18n/pnb.json
M i18n/prs.json
M i18n/ps.json
M i18n/pt-br.json
M i18n/pt.json
M i18n/qqq.json
M i18n/qu.json
M i18n/rif.json
M i18n/rm.json
M i18n/ro.json
M i18n/roa-tara.json
M i18n/ru.json
M i18n/rue.json
M i18n/sa.json
M i18n/sah.json
M i18n/sat.json
M i18n/sc.json
M i18n/scn.json
M i18n/sco.json
M i18n/sd.json
M i18n/sdc.json
M i18n/sdh.json
M i18n/sgs.json
M i18n/sh.json
M i18n/shi.json
M i18n/shn.json
M i18n/shy-latn.json
M i18n/si.json
M i18n/sk.json
M i18n/sl.json
M i18n/so.json
M i18n/sq.json
M i18n/sr-ec.json
M i18n/sr-el.json
M i18n/ss.json
M i18n/sty.json
M i18n/su.json
M i18n/sv.json
M

[MediaWiki-commits] [Gerrit] mediawiki...MinervaNeue[wmf/1.30.0-wmf.9]: Give MinervaNeue control of the minerva skin name

2017-07-13 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/364921 )

Change subject: Give MinervaNeue control of the minerva skin name
..


Give MinervaNeue control of the minerva skin name

Change-Id: I7f004b43e11d88492b205a3584c29f72d26bad57
Depends-On: I985c4e3a88b59461d471945ccf74cd291db45a61
Bug: T166748
(cherry picked from commit b0df6367c26d3aee454d0fa1a76ca32244697bcb)
---
M includes/Minerva.hooks.php
M skin.json
2 files changed, 7 insertions(+), 3 deletions(-)

Approvals:
  Chad: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/Minerva.hooks.php b/includes/Minerva.hooks.php
index ea58ee7..dcb2894 100644
--- a/includes/Minerva.hooks.php
+++ b/includes/Minerva.hooks.php
@@ -11,6 +11,7 @@
  * Hook handler method names should be in the form of:
  * on()
  */
+use MediaWiki\MediaWikiServices;
 
 class MinervaHooks {
/**
@@ -22,8 +23,9 @@
 * @param array &$lessVars Variables already added
 */
public static function onResourceLoaderGetLessVars( &$lessVars ) {
-   // FIXME: Load from Minerva.Config when MobileFrontend and 
Minerva are separated
-   $config = MobileContext::singleton()->getMFConfig();
+   $config = MediaWikiServices::getInstance()->getService( 
'ConfigFactory' )
+   ->makeConfig( 'minerva' );
+
$lessVars = array_merge( $lessVars,
[
'wgMinervaApplyKnownTemplateHacks' => 
"{$config->get( 'MinervaApplyKnownTemplateHacks' )}",
diff --git a/skin.json b/skin.json
index c08d450..addfeff 100644
--- a/skin.json
+++ b/skin.json
@@ -507,7 +507,9 @@
}
},
"ValidSkinNames": {
-   "minerva-neue": "MinervaNeue"
+   "minervaneue": "MinervaNeue",
+   "minerva-neue": "MinervaNeue",
+   "minerva": "Minerva"
},
"author": [],
"config": {

-- 
To view, visit https://gerrit.wikimedia.org/r/364921
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7f004b43e11d88492b205a3584c29f72d26bad57
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/MinervaNeue
Gerrit-Branch: wmf/1.30.0-wmf.9
Gerrit-Owner: Chad 
Gerrit-Reviewer: Chad 
Gerrit-Reviewer: Jdlrobson 
Gerrit-Reviewer: Niedzielski 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/dns[master]: fix IPv6 reverse record for kraz.wikimedia.org

2017-07-13 Thread Dzahn (Code Review)

Dzahn has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/364904 )

Change subject: fix IPv6 reverse record for kraz.wikimedia.org
..


fix IPv6 reverse record for kraz.wikimedia.org

This was in the wrong network. 208.80.153.x vs 208.80.154.x.

Bug:T105422
Change-Id: I45f57e25290d5aa8ab11fd0dd912677b80784e20
---
M templates/0.6.8.0.0.0.0.0.0.2.6.2.ip6.arpa
M templates/1.6.8.0.0.0.0.0.0.2.6.2.ip6.arpa
2 files changed, 1 insertion(+), 1 deletion(-)

Approvals:
  jenkins-bot: Verified
  Dzahn: Looks good to me, approved



diff --git a/templates/0.6.8.0.0.0.0.0.0.2.6.2.ip6.arpa 
b/templates/0.6.8.0.0.0.0.0.0.2.6.2.ip6.arpa
index d8d9d0b..0bda955 100644
--- a/templates/0.6.8.0.0.0.0.0.0.2.6.2.ip6.arpa
+++ b/templates/0.6.8.0.0.0.0.0.0.2.6.2.ip6.arpa
@@ -36,6 +36,7 @@
 2.0.0.0.0.0.0.0.0.0.0.0.0.0.e.f 1H IN PTR   ae2-2002.cr2-codfw.wikimedia.org.
 2.4.0.0.3.5.1.0.0.8.0.0.8.0.2.0 1H IN PTR   achernar.wikimedia.org.
 5.4.0.0.3.5.1.0.0.8.0.0.8.0.2.0 1H IN PTR   mx2001.wikimedia.org.
+4.4.0.0.3.5.1.0.0.8.0.0.8.0.2.0 1H IN PTR   kraz.wikimedia.org.
 6.4.0.0.3.5.1.0.0.8.0.0.8.0.2.0 1H IN PTR   wiki-mail-codfw.wikimedia.org.
 0.5.0.0.3.5.1.0.0.8.0.0.8.0.2.0 1H IN PTR   alsafi.wikimedia.org.
 2.5.0.0.3.5.1.0.0.8.0.0.8.0.2.0 1H IN PTR   dbmonitor2001.wikimedia.org.
diff --git a/templates/1.6.8.0.0.0.0.0.0.2.6.2.ip6.arpa 
b/templates/1.6.8.0.0.0.0.0.0.2.6.2.ip6.arpa
index a13a9d5..246d26d 100644
--- a/templates/1.6.8.0.0.0.0.0.0.2.6.2.ip6.arpa
+++ b/templates/1.6.8.0.0.0.0.0.0.2.6.2.ip6.arpa
@@ -54,7 +54,6 @@
 6.3.1.0.4.5.1.0.0.8.0.0.8.0.2.0 1H IN PTR   silver.wikimedia.org.
 9.4.1.0.4.5.1.0.0.8.0.0.8.0.2.0 1H IN PTR   bast1001.wikimedia.org.
 1.5.1.0.4.5.1.0.0.8.0.0.8.0.2.0 1H IN PTR   iron.wikimedia.org.
-4.4.0.0.3.5.1.0.0.8.0.0.8.0.2.0 1H IN PTR   kraz.wikimedia.org.
 9.5.1.0.4.5.1.0.0.8.0.0.8.0.2.0 1H IN PTR   netmon1001.wikimedia.org.
 
 1.0.0.0.0.0.0.0.0.0.0.0.0.0.e.f 1H IN PTR   ae2-1002.cr1-eqiad.wikimedia.org.

-- 
To view, visit https://gerrit.wikimedia.org/r/364904
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I45f57e25290d5aa8ab11fd0dd912677b80784e20
Gerrit-PatchSet: 4
Gerrit-Project: operations/dns
Gerrit-Branch: master
Gerrit-Owner: Dzahn 
Gerrit-Reviewer: Dzahn 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[wmf/1.30.0-wmf.9]: Fixups prior to Minerva/MobileFrontend separation

2017-07-13 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/365110 )

Change subject: Fixups prior to Minerva/MobileFrontend separation
..


Fixups prior to Minerva/MobileFrontend separation

* Correct dependency tree - a MobileFrontend module should not
depend on a Minerva module - move "skins.minerva.icons.images.variants"
dependency to Minerva entry point
* Update jsduck config so that MainMenu is a global (MainMenu will
become an abstract concept and the code defined in Minerva)
* Messages are defined twice inside mobile.startup and skins.minerva.scripts
since the latter depends on the former, remove the messages from it
* skins.minerva.watchstar should not double define watchstar messages
that are already defined in mobile.watchstar module
* skins.minerva.talk module should not reuse a message key meant for another
purpose. Give it its own message.

Change-Id: I598e9230fc27aae46d8d55c63fb18d5e4aedf939
(cherry picked from commit 30348b80395d99330fd1375c10200f9795671f0f)
---
M extension.json
M i18n/en.json
M i18n/qqq.json
M jsduck.json
M resources/skins.minerva.talk/init.js
5 files changed, 13 insertions(+), 26 deletions(-)

Approvals:
  Chad: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/extension.json b/extension.json
index 95c150e..77901e6 100644
--- a/extension.json
+++ b/extension.json
@@ -504,11 +504,17 @@
"mobile-frontend-overlay-continue",

"mobile-frontend-last-modified-with-user-seconds",

"mobile-frontend-last-modified-with-user-minutes",
-   "mobile-frontend-last-modified-with-user-hours",
"mobile-frontend-last-modified-with-user-days",

"mobile-frontend-last-modified-with-user-months",
"mobile-frontend-last-modified-with-user-years",

"mobile-frontend-last-modified-with-user-just-now",
+   "mobile-frontend-joined-just-now",
+   "mobile-frontend-joined-seconds",
+   "mobile-frontend-joined-minutes",
+   "mobile-frontend-joined-hours",
+   "mobile-frontend-joined-days",
+   "mobile-frontend-joined-months",
+   "mobile-frontend-joined-years",
"mobile-frontend-loading-message",
"mobile-frontend-editor-licensing",
"mobile-frontend-editor-licensing-with-terms",
@@ -908,7 +914,6 @@
"desktop"
],
"dependencies": [
-   "skins.minerva.icons.images.variants",
"mobile.startup"
],
"styles": [
@@ -1358,20 +1363,6 @@
"mobile-frontend-meta-data-issues-header",
"mobile-frontend-meta-data-issues-header-talk",
"mobile-frontend-languages-not-available",
-   
"mobile-frontend-last-modified-with-user-seconds",
-   
"mobile-frontend-last-modified-with-user-minutes",
-   "mobile-frontend-last-modified-with-user-hours",
-   "mobile-frontend-last-modified-with-user-days",
-   
"mobile-frontend-last-modified-with-user-months",
-   "mobile-frontend-last-modified-with-user-years",
-   
"mobile-frontend-last-modified-with-user-just-now",
-   "mobile-frontend-joined-just-now",
-   "mobile-frontend-joined-seconds",
-   "mobile-frontend-joined-minutes",
-   "mobile-frontend-joined-hours",
-   "mobile-frontend-joined-days",
-   "mobile-frontend-joined-months",
-   "mobile-frontend-joined-years",
"mobile-frontend-cookies-required",
"mobile-frontend-console-recruit",
"mobile-frontend-redirected-from"
@@ -1519,13 +1510,14 @@
"resources/skins.minerva.talk/init.js"
],
"messages": [
-   "mobile-frontend-talk-add-overlay-submit"
+   "minerva-talk-add-topic"
]
},
"skins.minerva.toggling": {
"class":

[MediaWiki-commits] [Gerrit] operations/puppet[production]: admin: Remove deployers from restricted group

2017-07-13 Thread Dzahn (Code Review)

Dzahn has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/364469 )

Change subject: admin: Remove deployers from restricted group
..


admin: Remove deployers from restricted group

The `restricted` group offers an access to the production servers,
allowing for example to run maintenance scripts.

These permissions are already included in the `deployment` group.

Removes the following users: hoo khorn ssastry nuria legoktm addshore

They are all already in deployment group.

Bug: T104671
Change-Id: I34d245e7758fce56c217de35eee342e15a702e19
---
M modules/admin/data/data.yaml
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Muehlenhoff: Looks good to me, but someone else must approve
  Addshore: Looks good to me, but someone else must approve
  Legoktm: Looks good to me, but someone else must approve
  jenkins-bot: Verified
  Dzahn: Looks good to me, approved



diff --git a/modules/admin/data/data.yaml b/modules/admin/data/data.yaml
index 3c4ad01..3552e41 100644
--- a/modules/admin/data/data.yaml
+++ b/modules/admin/data/data.yaml
@@ -74,8 +74,8 @@
 description: access to terbium, mwlog hosts (private data) and bastion 
hosts
  restricted folks use sudo to access apache / www-data 
resources
 members: [daniel, dartar, ellery, bearloga,
-  ezachte, hoo, jamesur, jdlrobson, khorn, tparscal, ssastry, 
smalyshev,
-  nuria, leila, santhosh, amire80, legoktm, addshore, foks, 
chelsyx]
+  ezachte, jamesur, jdlrobson, tparscal, smalyshev,
+  leila, santhosh, amire80, foks, chelsyx]
 privileges: ['ALL = (www-data,apache) NOPASSWD: ALL']
   cassandra-test-roots:
 gid: 708

-- 
To view, visit https://gerrit.wikimedia.org/r/364469
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I34d245e7758fce56c217de35eee342e15a702e19
Gerrit-PatchSet: 5
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Dereckson 
Gerrit-Reviewer: Addshore 
Gerrit-Reviewer: Alex Monk 
Gerrit-Reviewer: Dzahn 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: Muehlenhoff 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[wmf/1.30.0-wmf.7]: Fixups prior to Minerva/MobileFrontend separation

2017-07-13 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/365108 )

Change subject: Fixups prior to Minerva/MobileFrontend separation
..


Fixups prior to Minerva/MobileFrontend separation

* Correct dependency tree - a MobileFrontend module should not
depend on a Minerva module - move "skins.minerva.icons.images.variants"
dependency to Minerva entry point
* Update jsduck config so that MainMenu is a global (MainMenu will
become an abstract concept and the code defined in Minerva)
* Messages are defined twice inside mobile.startup and skins.minerva.scripts
since the latter depends on the former, remove the messages from it
* skins.minerva.watchstar should not double define watchstar messages
that are already defined in mobile.watchstar module
* skins.minerva.talk module should not reuse a message key meant for another
purpose. Give it its own message.

Change-Id: I598e9230fc27aae46d8d55c63fb18d5e4aedf939
(cherry picked from commit 30348b80395d99330fd1375c10200f9795671f0f)
---
M extension.json
M i18n/en.json
M i18n/qqq.json
M jsduck.json
M resources/skins.minerva.talk/init.js
5 files changed, 13 insertions(+), 26 deletions(-)

Approvals:
  Chad: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/extension.json b/extension.json
index 2186a1d..c9201fc 100644
--- a/extension.json
+++ b/extension.json
@@ -504,11 +504,17 @@
"mobile-frontend-overlay-continue",

"mobile-frontend-last-modified-with-user-seconds",

"mobile-frontend-last-modified-with-user-minutes",
-   "mobile-frontend-last-modified-with-user-hours",
"mobile-frontend-last-modified-with-user-days",

"mobile-frontend-last-modified-with-user-months",
"mobile-frontend-last-modified-with-user-years",

"mobile-frontend-last-modified-with-user-just-now",
+   "mobile-frontend-joined-just-now",
+   "mobile-frontend-joined-seconds",
+   "mobile-frontend-joined-minutes",
+   "mobile-frontend-joined-hours",
+   "mobile-frontend-joined-days",
+   "mobile-frontend-joined-months",
+   "mobile-frontend-joined-years",
"mobile-frontend-loading-message",
"mobile-frontend-editor-licensing",
"mobile-frontend-editor-licensing-with-terms",
@@ -908,7 +914,6 @@
"desktop"
],
"dependencies": [
-   "skins.minerva.icons.images.variants",
"mobile.startup"
],
"styles": [
@@ -1358,20 +1363,6 @@
"mobile-frontend-meta-data-issues-header",
"mobile-frontend-meta-data-issues-header-talk",
"mobile-frontend-languages-not-available",
-   
"mobile-frontend-last-modified-with-user-seconds",
-   
"mobile-frontend-last-modified-with-user-minutes",
-   "mobile-frontend-last-modified-with-user-hours",
-   "mobile-frontend-last-modified-with-user-days",
-   
"mobile-frontend-last-modified-with-user-months",
-   "mobile-frontend-last-modified-with-user-years",
-   
"mobile-frontend-last-modified-with-user-just-now",
-   "mobile-frontend-joined-just-now",
-   "mobile-frontend-joined-seconds",
-   "mobile-frontend-joined-minutes",
-   "mobile-frontend-joined-hours",
-   "mobile-frontend-joined-days",
-   "mobile-frontend-joined-months",
-   "mobile-frontend-joined-years",
"mobile-frontend-cookies-required",
"mobile-frontend-console-recruit",
"mobile-frontend-redirected-from"
@@ -1519,13 +1510,14 @@
"resources/skins.minerva.talk/init.js"
],
"messages": [
-   "mobile-frontend-talk-add-overlay-submit"
+   "minerva-talk-add-topic"
]
},
"skins.minerva.toggling": {
"class":

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[wmf/1.30.0-wmf.9]: Minerva is its own skin

2017-07-13 Thread Jdlrobson (Code Review)

Jdlrobson has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/365122 )

Change subject: Minerva is its own skin
..

Minerva is its own skin

This patch is the programmatic output of
Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce.

Additional changes:
* Bump version number to 2 as this is a breaking change
* Mark module definitions with resource-modules-disable-line that
will be unused by MobileFrontend after the separation. In future we will
consider whether these modules should be ported to the Minerva skin.

Note: The browser tests will temporarily fail due to the fact
the new MinervaSkin doesn't define Minerva as a valid skin name and
cannot until MobileFrontend (in this patch) releases its definition.
This will be fixed promptly by I7f004b43e11d88492b205a3584c29f72d26bad57

Bug: T166748
Depends-On: Iff1f7e63e796cc5d4a6d2ab0370e0c33248d2fce
Change-Id: I985c4e3a88b59461d471945ccf74cd291db45a61
---
M extension.json
M i18n/ab.json
M i18n/ace.json
M i18n/ady-cyrl.json
M i18n/aeb-arab.json
M i18n/aeb-latn.json
M i18n/aeb.json
M i18n/af.json
M i18n/ak.json
M i18n/am.json
M i18n/an.json
M i18n/ang.json
M i18n/anp.json
M i18n/ar.json
M i18n/arc.json
M i18n/arn.json
M i18n/arq.json
M i18n/ary.json
M i18n/arz.json
M i18n/as.json
M i18n/ase.json
M i18n/ast.json
M i18n/atj.json
M i18n/av.json
M i18n/awa.json
M i18n/az.json
M i18n/azb.json
M i18n/ba.json
M i18n/bar.json
M i18n/bcl.json
M i18n/be-tarask.json
M i18n/be.json
M i18n/bg.json
M i18n/bgn.json
M i18n/bho.json
M i18n/bn.json
M i18n/bo.json
M i18n/bqi.json
M i18n/br.json
M i18n/brh.json
M i18n/brx.json
M i18n/bs.json
M i18n/ca.json
M i18n/cdo.json
M i18n/ce.json
M i18n/ceb.json
M i18n/cjy-hant.json
M i18n/ckb.json
M i18n/co.json
M i18n/crh-cyrl.json
M i18n/crh-latn.json
M i18n/cs.json
M i18n/csb.json
M i18n/cu.json
M i18n/cv.json
M i18n/cy.json
M i18n/da.json
M i18n/de-ch.json
M i18n/de-formal.json
M i18n/de.json
M i18n/din.json
M i18n/diq.json
M i18n/dsb.json
M i18n/dtp.json
M i18n/dty.json
M i18n/ee.json
M i18n/egl.json
M i18n/el.json
M i18n/eml.json
M i18n/en-gb.json
M i18n/en.json
M i18n/eo.json
M i18n/es-formal.json
M i18n/es.json
M i18n/et.json
M i18n/eu.json
M i18n/ext.json
M i18n/fa.json
M i18n/fi.json
M i18n/fo.json
M i18n/fr.json
M i18n/frc.json
M i18n/frp.json
M i18n/frr.json
M i18n/fur.json
M i18n/fy.json
M i18n/ga.json
M i18n/gcf.json
M i18n/gd.json
M i18n/gl.json
M i18n/glk.json
M i18n/gn.json
M i18n/gom-deva.json
M i18n/gom-latn.json
M i18n/gor.json
M i18n/grc.json
M i18n/gsw.json
M i18n/gu.json
M i18n/gv.json
M i18n/ha.json
M i18n/hak.json
M i18n/haw.json
M i18n/he.json
M i18n/hi.json
M i18n/hif-latn.json
M i18n/hil.json
M i18n/hr.json
M i18n/hrx.json
M i18n/hsb.json
M i18n/ht.json
M i18n/hu-formal.json
M i18n/hu.json
M i18n/hy.json
M i18n/ia.json
M i18n/id.json
M i18n/ie.json
M i18n/ig.json
M i18n/ilo.json
M i18n/inh.json
M i18n/io.json
M i18n/is.json
M i18n/it.json
M i18n/ja.json
M i18n/jam.json
M i18n/jbo.json
M i18n/jut.json
M i18n/jv.json
M i18n/ka.json
M i18n/kbd-cyrl.json
M i18n/kbp.json
M i18n/kea.json
M i18n/kg.json
M i18n/khw.json
M i18n/kiu.json
M i18n/kk-cyrl.json
M i18n/kl.json
M i18n/km.json
M i18n/kn.json
M i18n/ko.json
M i18n/krc.json
M i18n/kri.json
M i18n/krl.json
M i18n/ksh.json
M i18n/ku-latn.json
M i18n/ku.json
M i18n/kv.json
M i18n/kw.json
M i18n/ky.json
M i18n/la.json
M i18n/lad.json
M i18n/lag.json
M i18n/lb.json
M i18n/lez.json
M i18n/lfn.json
M i18n/li.json
M i18n/lij.json
M i18n/liv.json
M i18n/lki.json
M i18n/lmo.json
M i18n/ln.json
M i18n/lo.json
M i18n/lrc.json
M i18n/lt.json
M i18n/ltg.json
M i18n/lus.json
M i18n/luz.json
M i18n/lv.json
M i18n/lzh.json
M i18n/lzz.json
M i18n/mai.json
M i18n/map-bms.json
M i18n/mg.json
M i18n/mhr.json
M i18n/mi.json
M i18n/min.json
M i18n/mk.json
M i18n/ml.json
M i18n/mn.json
M i18n/mnc.json
M i18n/mo.json
M i18n/mr.json
M i18n/ms.json
M i18n/mt.json
M i18n/my.json
M i18n/myv.json
M i18n/mzn.json
M i18n/nah.json
M i18n/nan.json
M i18n/nap.json
M i18n/nb.json
M i18n/nds-nl.json
M i18n/nds.json
M i18n/ne.json
M i18n/nl-informal.json
M i18n/nl.json
M i18n/nn.json
M i18n/nqo.json
M i18n/nso.json
M i18n/oc.json
M i18n/olo.json
M i18n/om.json
M i18n/or.json
M i18n/os.json
M i18n/ovd.json
M i18n/pa.json
M i18n/pam.json
M i18n/pap.json
M i18n/pdc.json
M i18n/pfl.json
M i18n/pl.json
M i18n/pms.json
M i18n/pnb.json
M i18n/prs.json
M i18n/ps.json
M i18n/pt-br.json
M i18n/pt.json
M i18n/qqq.json
M i18n/qu.json
M i18n/rif.json
M i18n/rm.json
M i18n/ro.json
M i18n/roa-tara.json
M i18n/ru.json
M i18n/rue.json
M i18n/sa.json
M i18n/sah.json
M i18n/sat.json
M i18n/sc.json
M i18n/scn.json
M i18n/sco.json
M i18n/sd.json
M i18n/sdc.json
M i18n/sdh.json
M i18n/sgs.json
M i18n/sh.json
M i18n/shi.json
M i18n/shn.json
M i18n/shy-latn.json
M i18n/si.json
M i18n/sk.json
M i18n/sl.json
M i18n/so.json
M i18n/sq.json
M i18n/sr-ec.json
M i18n/sr-el.json
M i18n/ss.json
M i18n/sty.json
M i18n/su.json
M i18n/sv.json
M i18n/sw.json

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Disable ferm check if base::firewall ensure => absent

2017-07-13 Thread Ottomata (Code Review)

Ottomata has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/365120 )

Change subject: Disable ferm check if base::firewall ensure => absent
..

Disable ferm check if base::firewall ensure => absent

Change-Id: I54643e13d6ee28a8b57a2f6318456bd7c9faa51f
---
M modules/base/manifests/firewall.pp
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/20/365120/1

diff --git a/modules/base/manifests/firewall.pp 
b/modules/base/manifests/firewall.pp
index b0da5e2..7418d44 100644
--- a/modules/base/manifests/firewall.pp
+++ b/modules/base/manifests/firewall.pp
@@ -84,7 +84,7 @@
 }
 
 nrpe::monitor_service { 'ferm_active':
-ensure=> 'present',
+ensure=> $ensure,
 description   => 'Check whether ferm is active by checking the default 
input chain',
 nrpe_command  => '/usr/bin/sudo /usr/lib/nagios/plugins/check_ferm',
 require   =>  [File['/usr/lib/nagios/plugins/check_ferm'], 
Sudo::User['nagios_check_ferm']],

-- 
To view, visit https://gerrit.wikimedia.org/r/365120
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I54643e13d6ee28a8b57a2f6318456bd7c9faa51f
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Ottomata 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...BlueSpiceSubPageTree[REL1_27]: RELEASE 2.27.2

2017-07-13 Thread Mglaser (Code Review)

Mglaser has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/365006 )

Change subject: RELEASE 2.27.2
..


RELEASE 2.27.2

This is the current state of master branch

Version numbers have been adjusted

Change-Id: Id81c828c4967265bbeb552e0607fec723e84c6b2
---
M .gitreview
M extension.json
2 files changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Robert Vogel: Looks good to me, approved
  Mglaser: Verified; Looks good to me, approved



diff --git a/.gitreview b/.gitreview
index 5d0721f..88a6147 100644
--- a/.gitreview
+++ b/.gitreview
@@ -2,5 +2,5 @@
 host=gerrit.wikimedia.org
 port=29418
 project=mediawiki/extensions/BlueSpiceSubPageTree.git
-defaultbranch=master
+defaultbranch=REL1_27
 defaultrebase=0
diff --git a/extension.json b/extension.json
index e9fa388..ac76af8 100644
--- a/extension.json
+++ b/extension.json
@@ -1,6 +1,6 @@
 {
"name": "BlueSpiceSubPageTree",
-   "version": "2.27.1-alpha",
+   "version": "2.27.2",
"url": "https://help.bluespice.com/index.php/BlueSpiceSubPageTree;,
"author": "Leonid Verhovskij",
"type": "bluespice",

-- 
To view, visit https://gerrit.wikimedia.org/r/365006
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id81c828c4967265bbeb552e0607fec723e84c6b2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BlueSpiceSubPageTree
Gerrit-Branch: REL1_27
Gerrit-Owner: Robert Vogel 
Gerrit-Reviewer: Ljonka 
Gerrit-Reviewer: Mglaser 
Gerrit-Reviewer: Pwirth 
Gerrit-Reviewer: Robert Vogel 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[wmf/1.30.0-wmf.9]: Fixups prior to Minerva/MobileFrontend separation

2017-07-13 Thread Jdlrobson (Code Review)

Jdlrobson has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/365110 )

Change subject: Fixups prior to Minerva/MobileFrontend separation
..

Fixups prior to Minerva/MobileFrontend separation

* Correct dependency tree - a MobileFrontend module should not
depend on a Minerva module - move "skins.minerva.icons.images.variants"
dependency to Minerva entry point
* Update jsduck config so that MainMenu is a global (MainMenu will
become an abstract concept and the code defined in Minerva)
* Messages are defined twice inside mobile.startup and skins.minerva.scripts
since the latter depends on the former, remove the messages from it
* skins.minerva.watchstar should not double define watchstar messages
that are already defined in mobile.watchstar module
* skins.minerva.talk module should not reuse a message key meant for another
purpose. Give it its own message.

Change-Id: I598e9230fc27aae46d8d55c63fb18d5e4aedf939
(cherry picked from commit 30348b80395d99330fd1375c10200f9795671f0f)
---
M extension.json
M i18n/en.json
M i18n/qqq.json
M jsduck.json
M resources/skins.minerva.talk/init.js
5 files changed, 13 insertions(+), 26 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/10/365110/1

diff --git a/extension.json b/extension.json
index 95c150e..77901e6 100644
--- a/extension.json
+++ b/extension.json
@@ -504,11 +504,17 @@
"mobile-frontend-overlay-continue",

"mobile-frontend-last-modified-with-user-seconds",

"mobile-frontend-last-modified-with-user-minutes",
-   "mobile-frontend-last-modified-with-user-hours",
"mobile-frontend-last-modified-with-user-days",

"mobile-frontend-last-modified-with-user-months",
"mobile-frontend-last-modified-with-user-years",

"mobile-frontend-last-modified-with-user-just-now",
+   "mobile-frontend-joined-just-now",
+   "mobile-frontend-joined-seconds",
+   "mobile-frontend-joined-minutes",
+   "mobile-frontend-joined-hours",
+   "mobile-frontend-joined-days",
+   "mobile-frontend-joined-months",
+   "mobile-frontend-joined-years",
"mobile-frontend-loading-message",
"mobile-frontend-editor-licensing",
"mobile-frontend-editor-licensing-with-terms",
@@ -908,7 +914,6 @@
"desktop"
],
"dependencies": [
-   "skins.minerva.icons.images.variants",
"mobile.startup"
],
"styles": [
@@ -1358,20 +1363,6 @@
"mobile-frontend-meta-data-issues-header",
"mobile-frontend-meta-data-issues-header-talk",
"mobile-frontend-languages-not-available",
-   
"mobile-frontend-last-modified-with-user-seconds",
-   
"mobile-frontend-last-modified-with-user-minutes",
-   "mobile-frontend-last-modified-with-user-hours",
-   "mobile-frontend-last-modified-with-user-days",
-   
"mobile-frontend-last-modified-with-user-months",
-   "mobile-frontend-last-modified-with-user-years",
-   
"mobile-frontend-last-modified-with-user-just-now",
-   "mobile-frontend-joined-just-now",
-   "mobile-frontend-joined-seconds",
-   "mobile-frontend-joined-minutes",
-   "mobile-frontend-joined-hours",
-   "mobile-frontend-joined-days",
-   "mobile-frontend-joined-months",
-   "mobile-frontend-joined-years",
"mobile-frontend-cookies-required",
"mobile-frontend-console-recruit",
"mobile-frontend-redirected-from"
@@ -1519,13 +1510,14 @@
"resources/skins.minerva.talk/init.js"
],
"messages": [
-   "mobile-frontend-talk-add-overlay-submit"
+   "minerva-talk-add-topic"
]
},
"skins.minerva.toggling": {

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[wmf/1.30.0-wmf.7]: Fixups prior to Minerva/MobileFrontend separation

2017-07-13 Thread Jdlrobson (Code Review)

Jdlrobson has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/365108 )

Change subject: Fixups prior to Minerva/MobileFrontend separation
..

Fixups prior to Minerva/MobileFrontend separation

* Correct dependency tree - a MobileFrontend module should not
depend on a Minerva module - move "skins.minerva.icons.images.variants"
dependency to Minerva entry point
* Update jsduck config so that MainMenu is a global (MainMenu will
become an abstract concept and the code defined in Minerva)
* Messages are defined twice inside mobile.startup and skins.minerva.scripts
since the latter depends on the former, remove the messages from it
* skins.minerva.watchstar should not double define watchstar messages
that are already defined in mobile.watchstar module
* skins.minerva.talk module should not reuse a message key meant for another
purpose. Give it its own message.

Change-Id: I598e9230fc27aae46d8d55c63fb18d5e4aedf939
(cherry picked from commit 30348b80395d99330fd1375c10200f9795671f0f)
---
M extension.json
M i18n/en.json
M i18n/qqq.json
M jsduck.json
M resources/skins.minerva.talk/init.js
5 files changed, 13 insertions(+), 26 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/08/365108/1

diff --git a/extension.json b/extension.json
index 2186a1d..c9201fc 100644
--- a/extension.json
+++ b/extension.json
@@ -504,11 +504,17 @@
"mobile-frontend-overlay-continue",

"mobile-frontend-last-modified-with-user-seconds",

"mobile-frontend-last-modified-with-user-minutes",
-   "mobile-frontend-last-modified-with-user-hours",
"mobile-frontend-last-modified-with-user-days",

"mobile-frontend-last-modified-with-user-months",
"mobile-frontend-last-modified-with-user-years",

"mobile-frontend-last-modified-with-user-just-now",
+   "mobile-frontend-joined-just-now",
+   "mobile-frontend-joined-seconds",
+   "mobile-frontend-joined-minutes",
+   "mobile-frontend-joined-hours",
+   "mobile-frontend-joined-days",
+   "mobile-frontend-joined-months",
+   "mobile-frontend-joined-years",
"mobile-frontend-loading-message",
"mobile-frontend-editor-licensing",
"mobile-frontend-editor-licensing-with-terms",
@@ -908,7 +914,6 @@
"desktop"
],
"dependencies": [
-   "skins.minerva.icons.images.variants",
"mobile.startup"
],
"styles": [
@@ -1358,20 +1363,6 @@
"mobile-frontend-meta-data-issues-header",
"mobile-frontend-meta-data-issues-header-talk",
"mobile-frontend-languages-not-available",
-   
"mobile-frontend-last-modified-with-user-seconds",
-   
"mobile-frontend-last-modified-with-user-minutes",
-   "mobile-frontend-last-modified-with-user-hours",
-   "mobile-frontend-last-modified-with-user-days",
-   
"mobile-frontend-last-modified-with-user-months",
-   "mobile-frontend-last-modified-with-user-years",
-   
"mobile-frontend-last-modified-with-user-just-now",
-   "mobile-frontend-joined-just-now",
-   "mobile-frontend-joined-seconds",
-   "mobile-frontend-joined-minutes",
-   "mobile-frontend-joined-hours",
-   "mobile-frontend-joined-days",
-   "mobile-frontend-joined-months",
-   "mobile-frontend-joined-years",
"mobile-frontend-cookies-required",
"mobile-frontend-console-recruit",
"mobile-frontend-redirected-from"
@@ -1519,13 +1510,14 @@
"resources/skins.minerva.talk/init.js"
],
"messages": [
-   "mobile-frontend-talk-add-overlay-submit"
+   "minerva-talk-add-topic"
]
},
"skins.minerva.toggling": {

[MediaWiki-commits] [Gerrit] operations/puppet[production]: ensure => absent for base::firewall in statistics::private p...

2017-07-13 Thread Ottomata (Code Review)

Ottomata has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/365096 )

Change subject: ensure => absent for base::firewall in statistics::private 
profile
..


ensure => absent for base::firewall in statistics::private profile

Instead of just removing the class include.

Bug: T170496
Change-Id: I92c9b8db1435eccf774ee441a627548971266370
---
M modules/profile/manifests/statistics/private.pp
1 file changed, 6 insertions(+), 0 deletions(-)

Approvals:
  Ottomata: Verified; Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/profile/manifests/statistics/private.pp 
b/modules/profile/manifests/statistics/private.pp
index dae8a69..f91d7ac 100644
--- a/modules/profile/manifests/statistics/private.pp
+++ b/modules/profile/manifests/statistics/private.pp
@@ -4,6 +4,12 @@
 $statistics_servers = hiera('statistics_servers'),
 ) {
 include ::standard
+# Can't include base firewall on statistics private boxes.
+# Hadoop clients (like spark) can start up CLIs that interact
+# with Hadoop via ephemeral ports.
+class { '::base::firewall':
+ensure => 'absent'
+}
 
 include ::deployment::umask_wikidev
 

-- 
To view, visit https://gerrit.wikimedia.org/r/365096
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I92c9b8db1435eccf774ee441a627548971266370
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Ottomata 
Gerrit-Reviewer: Ottomata 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: ensure => absent for base::firewall in statistics::private p...

2017-07-13 Thread Ottomata (Code Review)

Ottomata has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/365096 )

Change subject: ensure => absent for base::firewall in statistics::private 
profile
..

ensure => absent for base::firewall in statistics::private profile

Instead of just removing the class include.

Bug: T170496
Change-Id: I92c9b8db1435eccf774ee441a627548971266370
---
M modules/profile/manifests/statistics/private.pp
1 file changed, 6 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/96/365096/1

diff --git a/modules/profile/manifests/statistics/private.pp 
b/modules/profile/manifests/statistics/private.pp
index dae8a69..f91d7ac 100644
--- a/modules/profile/manifests/statistics/private.pp
+++ b/modules/profile/manifests/statistics/private.pp
@@ -4,6 +4,12 @@
 $statistics_servers = hiera('statistics_servers'),
 ) {
 include ::standard
+# Can't include base firewall on statistics private boxes.
+# Hadoop clients (like spark) can start up CLIs that interact
+# with Hadoop via ephemeral ports.
+class { '::base::firewall':
+ensure => 'absent'
+}
 
 include ::deployment::umask_wikidev
 

-- 
To view, visit https://gerrit.wikimedia.org/r/365096
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I92c9b8db1435eccf774ee441a627548971266370
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Ottomata 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Remove base::firewall from stat private boxes

2017-07-13 Thread Ottomata (Code Review)

Ottomata has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/365095 )

Change subject: Remove base::firewall from stat private boxes
..


Remove base::firewall from stat private boxes

This was never applied before, and breaks the use of spark, since spark
listens on ephemeral ports for each new session.

Bug: T170496
Change-Id: I9b0b38fb5b3be0f4ee6909370da5954dc6de
---
M modules/profile/manifests/statistics/private.pp
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
  Ottomata: Verified; Looks good to me, approved



diff --git a/modules/profile/manifests/statistics/private.pp 
b/modules/profile/manifests/statistics/private.pp
index 7e1734b..dae8a69 100644
--- a/modules/profile/manifests/statistics/private.pp
+++ b/modules/profile/manifests/statistics/private.pp
@@ -4,7 +4,6 @@
 $statistics_servers = hiera('statistics_servers'),
 ) {
 include ::standard
-include ::base::firewall
 
 include ::deployment::umask_wikidev
 

-- 
To view, visit https://gerrit.wikimedia.org/r/365095
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9b0b38fb5b3be0f4ee6909370da5954dc6de
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Ottomata 
Gerrit-Reviewer: Ottomata 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Remove base::firewall from stat private boxes

2017-07-13 Thread Ottomata (Code Review)

Ottomata has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/365095 )

Change subject: Remove base::firewall from stat private boxes
..

Remove base::firewall from stat private boxes

This was never applied before, and breaks the use of spark, since spark
listens on ephemeral ports for each new session.

Bug: T170496
Change-Id: I9b0b38fb5b3be0f4ee6909370da5954dc6de
---
M modules/profile/manifests/statistics/private.pp
1 file changed, 0 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/95/365095/1

diff --git a/modules/profile/manifests/statistics/private.pp 
b/modules/profile/manifests/statistics/private.pp
index 7e1734b..dae8a69 100644
--- a/modules/profile/manifests/statistics/private.pp
+++ b/modules/profile/manifests/statistics/private.pp
@@ -4,7 +4,6 @@
 $statistics_servers = hiera('statistics_servers'),
 ) {
 include ::standard
-include ::base::firewall
 
 include ::deployment::umask_wikidev
 

-- 
To view, visit https://gerrit.wikimedia.org/r/365095
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9b0b38fb5b3be0f4ee6909370da5954dc6de
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Ottomata 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] translatewiki[master]: [MobileFrontend] Remove deleted key

2017-07-13 Thread Raimond Spekking (Code Review)

Raimond Spekking has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/365094 )

Change subject: [MobileFrontend] Remove deleted key
..


[MobileFrontend] Remove deleted key

Change-Id: I9ac73961486a723207c22da208523200ffd00ff7
---
M groups/MediaWiki/mediawiki-extensions.txt
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
  Raimond Spekking: Verified; Looks good to me, approved



diff --git a/groups/MediaWiki/mediawiki-extensions.txt 
b/groups/MediaWiki/mediawiki-extensions.txt
index 365065b..bcaa4b2 100644
--- a/groups/MediaWiki/mediawiki-extensions.txt
+++ b/groups/MediaWiki/mediawiki-extensions.txt
@@ -1591,7 +1591,6 @@
 descmsg = mobile-frontend-desc
 aliasfile = MobileFrontend/MobileFrontend.alias.php
 optional = mobile.js, mobile.css, mobile-frontend-diffview-comma
-optional = mobile-frontend-footer-sitename
 ignored = mobile-frontend-page-menu-language, mobile-frontend-terms-url
 
 Model

-- 
To view, visit https://gerrit.wikimedia.org/r/365094
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9ac73961486a723207c22da208523200ffd00ff7
Gerrit-PatchSet: 1
Gerrit-Project: translatewiki
Gerrit-Branch: master
Gerrit-Owner: Raimond Spekking 
Gerrit-Reviewer: Raimond Spekking 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] translatewiki[master]: [MobileFrontend] Remove deleted key

2017-07-13 Thread Raimond Spekking (Code Review)

Raimond Spekking has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/365094 )

Change subject: [MobileFrontend] Remove deleted key
..

[MobileFrontend] Remove deleted key

Change-Id: I9ac73961486a723207c22da208523200ffd00ff7
---
M groups/MediaWiki/mediawiki-extensions.txt
1 file changed, 0 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/translatewiki 
refs/changes/94/365094/1

diff --git a/groups/MediaWiki/mediawiki-extensions.txt 
b/groups/MediaWiki/mediawiki-extensions.txt
index 365065b..bcaa4b2 100644
--- a/groups/MediaWiki/mediawiki-extensions.txt
+++ b/groups/MediaWiki/mediawiki-extensions.txt
@@ -1591,7 +1591,6 @@
 descmsg = mobile-frontend-desc
 aliasfile = MobileFrontend/MobileFrontend.alias.php
 optional = mobile.js, mobile.css, mobile-frontend-diffview-comma
-optional = mobile-frontend-footer-sitename
 ignored = mobile-frontend-page-menu-language, mobile-frontend-terms-url
 
 Model

-- 
To view, visit https://gerrit.wikimedia.org/r/365094
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9ac73961486a723207c22da208523200ffd00ff7
Gerrit-PatchSet: 1
Gerrit-Project: translatewiki
Gerrit-Branch: master
Gerrit-Owner: Raimond Spekking 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Move testwiki to MinervaNeue

2017-07-13 Thread Chad (Code Review)

Chad has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/365093 )

Change subject: Move testwiki to MinervaNeue
..

Move testwiki to MinervaNeue

Change-Id: Id33e3b7dff7d104c51648670e6fc905686cd1173
---
M wmf-config/InitialiseSettings.php
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/93/365093/1

diff --git a/wmf-config/InitialiseSettings.php 
b/wmf-config/InitialiseSettings.php
index 5d21213..7f8121d 100644
--- a/wmf-config/InitialiseSettings.php
+++ b/wmf-config/InitialiseSettings.php
@@ -15012,6 +15012,7 @@
 
 'wmgMinervaNeue' => [
'default' => false,
+   'testwiki' => true,
 ],
 'wmgUseMobileApp' => [
'default' => true,

-- 
To view, visit https://gerrit.wikimedia.org/r/365093
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id33e3b7dff7d104c51648670e6fc905686cd1173
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Chad 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] analytics/refinery[master]: Corrected quotes in create syntax for webrequest

2017-07-13 Thread Ottomata (Code Review)

Ottomata has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/365089 )

Change subject: Corrected quotes in create syntax for webrequest
..


Corrected quotes in create syntax for webrequest

Bug: T164021
Change-Id: I6673fbc63296c69c9d9a94170fbb070f2681ea1f
---
M hive/webrequest/create_webrequest_table.hql
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Ottomata: Verified; Looks good to me, approved



diff --git a/hive/webrequest/create_webrequest_table.hql 
b/hive/webrequest/create_webrequest_table.hql
index b9b8ca6..0973eca 100644
--- a/hive/webrequest/create_webrequest_table.hql
+++ b/hive/webrequest/create_webrequest_table.hql
@@ -55,7 +55,7 @@
 `pageview_info` map  COMMENT 'map containing project, 
language_variant and page_title values only when is_pageview = TRUE.',
 `page_id`   bigint  COMMENT 'MediaWiki page_id for this page 
title. For redirects this could be the page_id of the redirect or the page_id 
of the target. This may not always be set, even if the page is actually a 
pageview.',
 `namespace_id`  int COMMENT 'MediaWiki namespace_id for this page 
title. This may not always be set, even if the page is actually a pageview.',
-`tags`  array COMMENT 'List containing tags qualifying 
the request, ex: ['portal', 'wikidata']. Will be used to split webrequest into 
smaller subsets.'
+`tags`  array COMMENT 'List containing tags qualifying 
the request, ex: [portal, wikidata]. Will be used to split webrequest into 
smaller subsets.'
 
 )
 PARTITIONED BY (

-- 
To view, visit https://gerrit.wikimedia.org/r/365089
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6673fbc63296c69c9d9a94170fbb070f2681ea1f
Gerrit-PatchSet: 1
Gerrit-Project: analytics/refinery
Gerrit-Branch: master
Gerrit-Owner: Nuria 
Gerrit-Reviewer: Mforns 
Gerrit-Reviewer: Nuria 
Gerrit-Reviewer: Ottomata 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Add HD logos for several Wiktionaries

2017-07-13 Thread Urbanecm (Code Review)

Urbanecm has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/365092 )

Change subject: Add HD logos for several Wiktionaries
..

Add HD logos for several Wiktionaries

Bug: T150618
Change-Id: Ic900236c520dbb679928e66091cc51110eda7858
---
A static/images/project-logos/amwiktionary-1.5x.png
A static/images/project-logos/amwiktionary-2x.png
A static/images/project-logos/arwiktionary-1.5x.png
A static/images/project-logos/arwiktionary-2x.png
A static/images/project-logos/azwiktionary-1.5x.png
A static/images/project-logos/azwiktionary-2x.png
A static/images/project-logos/bewiktionary-1.5x.png
A static/images/project-logos/bewiktionary-2x.png
A static/images/project-logos/bnwiktionary-1.5x.png
A static/images/project-logos/bnwiktionary-2x.png
A static/images/project-logos/cowiktionary-1.5x.png
A static/images/project-logos/cowiktionary-2x.png
A static/images/project-logos/csbwiktionary-1.5x.png
A static/images/project-logos/csbwiktionary-2x.png
A static/images/project-logos/dawiktionary-1.5x.png
A static/images/project-logos/dawiktionary-2x.png
A static/images/project-logos/eowiktionary-1.5x.png
A static/images/project-logos/eowiktionary-2x.png
A static/images/project-logos/etwiktionary-1.5x.png
A static/images/project-logos/etwiktionary-2x.png
A static/images/project-logos/fiwiktionary-1.5x.png
A static/images/project-logos/fiwiktionary-2x.png
A static/images/project-logos/fowiktionary-1.5x.png
A static/images/project-logos/fowiktionary-2x.png
A static/images/project-logos/fywiktionary-1.5x.png
A static/images/project-logos/fywiktionary-2x.png
A static/images/project-logos/gdwiktionary-1.5x.png
A static/images/project-logos/gdwiktionary-2x.png
A static/images/project-logos/guwiktionary-1.5x.png
A static/images/project-logos/guwiktionary-2x.png
A static/images/project-logos/gvwiktionary-1.5x.png
A static/images/project-logos/gvwiktionary-2x.png
A static/images/project-logos/hewiktionary-1.5x.png
A static/images/project-logos/hewiktionary-2x.png
A static/images/project-logos/hiwiktionary-1.5x.png
A static/images/project-logos/hiwiktionary-2x.png
A static/images/project-logos/hsbwiktionary-1.5x.png
A static/images/project-logos/hsbwiktionary-2x.png
A static/images/project-logos/huwiktionary-1.5x.png
A static/images/project-logos/huwiktionary-2x.png
A static/images/project-logos/hywiktionary-1.5x.png
A static/images/project-logos/hywiktionary-2x.png
A static/images/project-logos/iawiktionary-1.5x.png
A static/images/project-logos/iawiktionary-2x.png
A static/images/project-logos/idwiktionary-1.5x.png
A static/images/project-logos/idwiktionary-2x.png
A static/images/project-logos/iewiktionary-1.5x.png
A static/images/project-logos/iewiktionary-2x.png
A static/images/project-logos/ikwiktionary-1.5x.png
A static/images/project-logos/ikwiktionary-2x.png
A static/images/project-logos/itwiktionary-1.5x.png
A static/images/project-logos/itwiktionary-2x.png
A static/images/project-logos/jawiktionary-1.5x.png
A static/images/project-logos/jawiktionary-2x.png
A static/images/project-logos/jbowiktionary-1.5x.png
A static/images/project-logos/jbowiktionary-2x.png
A static/images/project-logos/jvwiktionary-1.5x.png
A static/images/project-logos/jvwiktionary-2x.png
A static/images/project-logos/kkwiktionary-1.5x.png
A static/images/project-logos/kkwiktionary-2x.png
A static/images/project-logos/kmwiktionary-1.5x.png
A static/images/project-logos/kmwiktionary-2x.png
A static/images/project-logos/knwiktionary-1.5x.png
A static/images/project-logos/knwiktionary-2x.png
A static/images/project-logos/kowiktionary-1.5x.png
A static/images/project-logos/kowiktionary-2x.png
A static/images/project-logos/kuwiktionary-1.5x.png
A static/images/project-logos/kuwiktionary-2x.png
A static/images/project-logos/kwwiktionary-1.5x.png
A static/images/project-logos/kwwiktionary-2x.png
A static/images/project-logos/kywiktionary-1.5x.png
A static/images/project-logos/kywiktionary-2x.png
A static/images/project-logos/liwiktionary-1.5x.png
A static/images/project-logos/liwiktionary-2x.png
A static/images/project-logos/ltwiktionary-1.5x.png
A static/images/project-logos/ltwiktionary-2x.png
A static/images/project-logos/lvwiktionary-1.5x.png
A static/images/project-logos/lvwiktionary-2x.png
A static/images/project-logos/mgwiktionary-1.5x.png
A static/images/project-logos/mgwiktionary-2x.png
A static/images/project-logos/miwiktionary-1.5x.png
A static/images/project-logos/miwiktionary-2x.png
A static/images/project-logos/mkwiktionary-1.5x.png
A static/images/project-logos/mkwiktionary-2x.png
A static/images/project-logos/mlwiktionary-1.5x.png
A static/images/project-logos/mlwiktionary-2x.png
A static/images/project-logos/mnwiktionary-1.5x.png
A static/images/project-logos/mnwiktionary-2x.png
A static/images/project-logos/mrwiktionary-1.5x.png
A static/images/project-logos/mrwiktionary-2x.png
A static/images/project-logos/mswiktionary-1.5x.png
A

[MediaWiki-commits] [Gerrit] mediawiki...Cargo[master]: Work in progress Add support for hierarchy fields in Drilldown

2017-07-13 Thread Fz-29 (Code Review)

Fz-29 has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/365091 )

Change subject: Work in progress Add support for hierarchy fields in Drilldown
..

Work in progress
Add support for hierarchy fields in Drilldown

Change-Id: Ic465b978a1f40f00c66fbdf1b29f8ebe71f2fc55
---
M CargoHierarchy.php
M CargoUtils.php
M drilldown/CargoSpecialDrilldown.php
3 files changed, 172 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Cargo 
refs/changes/91/365091/1

diff --git a/CargoHierarchy.php b/CargoHierarchy.php
index 983008c..8a41eba 100644
--- a/CargoHierarchy.php
+++ b/CargoHierarchy.php
@@ -13,6 +13,10 @@
public $mLeft = 0;
public $mRight = 0;
 
+   // Helper class member for Drilldown
+   public $mPageCount = 0;
+   public $mExclusivePageCount = 0;
+
function __construct( $curTitle = '__pseudo_root__' ) {
$this->mTitle = $curTitle;
$this->mChildren = array();
@@ -42,6 +46,7 @@
$curParentNode = $fullTree->getLastNodeForLevel( 
$numBullets );
$curParentNode->addChild( new CargoHierarchy( $lineText 
) );
}
+   $fullTree->computeLeftRight();
return $fullTree;
}
 
@@ -55,7 +60,6 @@
 
function generateHierarchyStructureTableData() {
$tableData = array();
-   $this->computeLeftRight();
//  Preorder traversal using Stack data structure
$stack = new SplStack();
$stack->push( $this );
@@ -83,4 +87,63 @@
$this->mRight = $counter;
$counter += 1;
}
+
+   function computeNodeCountByFilter( $f, $fullTextSearchTerm, 
$appliedFilters ) {
+   $cdb = CargoUtils::getDB();
+   $countArg = "";
+
+   list( $tableNames, $conds, $joinConds ) = $f->getQueryParts( 
$fullTextSearchTerm, $appliedFilters );
+   if ( $f->fieldDescription->mIsList ) {
+   $countArg = "_rowID";
+   $fieldTableName = $f->tableName . '__' . $f->name;
+   $tableNames[] = $fieldTableName;
+   // $fieldName = CargoUtils::escapedFieldName( $cdb, 
$fieldTableName, '_value' );
+   $fieldName = '_value';
+   $joinConds[$fieldTableName] = 
CargoUtils::joinOfMainAndFieldTable( $cdb, $f->tableName, $fieldTableName );
+   } else {
+   $countArg = "_ID";
+   $fieldName = $f->name;
+   $fieldTableName = $f->tableName;
+   }
+
+   // Join hierarchy structure table __hierarchy with the main 
table
+   $hierarchyTableName = $f->tableName . '__' . $f->name . 
'__hierarchy';
+   $tableNames[] = $hierarchyTableName;
+
+   $joinConds[$hierarchyTableName] = 
CargoUtils::joinOfSingleFieldAndHierarchyTable( $cdb, 
+   $fieldTableName, $fieldName, $hierarchyTableName );
+
+   // Need of following?
+   // if ( $f->searchableFiles ) {
+   //  $countClause = "COUNT(DISTINCT 
cargo__{$f->tableName}._pageID) AS total";
+   // } else {
+   //  $countClause = "COUNT(*) AS total";
+   // }
+
+   $countClause = "COUNT(DISTINCT($countArg)) AS total";
+   $hierarchyConds = array();
+   $exclusiveHierarchyConds = array();
+   $hierarchyConds[] = "_left >= $this->mLeft";
+   $hierarchyConds[] = "_right <= $this->mRight";
+   $exclusiveHierarchyConds[] = "_left = $this->mLeft";
+
+   // Hierarchy Node Count
+   $res = $cdb->select( $tableNames, array( $countClause ), 
array_merge( $conds, $hierarchyConds ),
+   null, null, $joinConds );
+   $count = 0;
+   while ( $row = $cdb->fetchRow( $res ) ) {
+   $count = $row['total'];
+   }
+   $this->mPageCount = $count;
+   $cdb->freeResult( $res );
+   // Exclusive Node Count 
+   $res = $cdb->select( $tableNames, array( $countClause ), 
array_merge( $conds, $exclusiveHierarchyConds ),
+   null, null, $joinConds );
+   $count = 0;
+   while ( $row = $cdb->fetchRow( $res ) ) {
+   $count = $row['total'];
+   }
+   $this->mExclusivePageCount = $count;
+   $cdb->freeResult( $res );
+   }
 }
\ No newline at end of file
diff --git a/CargoUtils.php b/CargoUtils.php
index eaf1392..a1686be 100644
--- a/CargoUtils.php
+++ b/CargoUtils.php
@@ -908,6 +908,15 @@
);
}
 
+   public static function

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseQualityConstraints[master]: Fix exception thrown from ConnectionCheckerHelper

2017-07-13 Thread Lucas Werkmeister (WMDE) (Code Review)

Lucas Werkmeister (WMDE) has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/365090 )

Change subject: Fix exception thrown from ConnectionCheckerHelper
..

Fix exception thrown from ConnectionCheckerHelper

The values parsed in parseItemIdSnakValues can come from constraint
parameters and should therefore, for now, be treated like arbitrary user
input that’s not necessarily valid.

This is just a quick fix for T170599, not a proper solution for the
underlying problem.

Bug: T170599
Change-Id: I6bc6711e0061d0f28b26a5de97be689fa7ee3d28
---
M includes/ConstraintCheck/Helper/ConnectionCheckerHelper.php
M tests/phpunit/Checker/ConnectionChecker/ConnectionCheckerHelperTest.php
2 files changed, 9 insertions(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikibaseQualityConstraints
 refs/changes/90/365090/1

diff --git a/includes/ConstraintCheck/Helper/ConnectionCheckerHelper.php 
b/includes/ConstraintCheck/Helper/ConnectionCheckerHelper.php
index 9113385..f832dde 100644
--- a/includes/ConstraintCheck/Helper/ConnectionCheckerHelper.php
+++ b/includes/ConstraintCheck/Helper/ConnectionCheckerHelper.php
@@ -107,7 +107,11 @@
$ret[] = ItemIdSnakValue::noValue();
break;
default:
-   $ret[] = ItemIdSnakValue::fromItemId( 
new ItemId( strtoupper( $value ) ) );
+   try {
+   $ret[] = 
ItemIdSnakValue::fromItemId( new ItemId( strtoupper( $value ) ) );
+   } catch ( InvalidArgumentException $e ) 
{
+   // ignore
+   }
break;
}
}
diff --git 
a/tests/phpunit/Checker/ConnectionChecker/ConnectionCheckerHelperTest.php 
b/tests/phpunit/Checker/ConnectionChecker/ConnectionCheckerHelperTest.php
index 78706c6..22ac73b 100644
--- a/tests/phpunit/Checker/ConnectionChecker/ConnectionCheckerHelperTest.php
+++ b/tests/phpunit/Checker/ConnectionChecker/ConnectionCheckerHelperTest.php
@@ -85,4 +85,8 @@
$this->assertNotNull( 
$this->connectionCheckerHelper->findStatement( $this->statementList, 'P2', 
'novalue' ) );
}
 
+   public function testHasClaimInvalidValue() {
+   $this->assertNull( 
$this->connectionCheckerHelper->findStatement( $this->statementList, 'P1', 
'invalid' ) );
+   }
+
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/365090
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6bc6711e0061d0f28b26a5de97be689fa7ee3d28
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseQualityConstraints
Gerrit-Branch: master
Gerrit-Owner: Lucas Werkmeister (WMDE) 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] analytics/refinery[master]: Corrected quotes in create syntax for webrequest

2017-07-13 Thread Nuria (Code Review)

Nuria has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/365089 )

Change subject: Corrected quotes in create syntax for webrequest
..

Corrected quotes in create syntax for webrequest

Bug: T164021
Change-Id: I6673fbc63296c69c9d9a94170fbb070f2681ea1f
---
M hive/webrequest/create_webrequest_table.hql
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/analytics/refinery 
refs/changes/89/365089/1

diff --git a/hive/webrequest/create_webrequest_table.hql 
b/hive/webrequest/create_webrequest_table.hql
index b9b8ca6..0973eca 100644
--- a/hive/webrequest/create_webrequest_table.hql
+++ b/hive/webrequest/create_webrequest_table.hql
@@ -55,7 +55,7 @@
 `pageview_info` map  COMMENT 'map containing project, 
language_variant and page_title values only when is_pageview = TRUE.',
 `page_id`   bigint  COMMENT 'MediaWiki page_id for this page 
title. For redirects this could be the page_id of the redirect or the page_id 
of the target. This may not always be set, even if the page is actually a 
pageview.',
 `namespace_id`  int COMMENT 'MediaWiki namespace_id for this page 
title. This may not always be set, even if the page is actually a pageview.',
-`tags`  array COMMENT 'List containing tags qualifying 
the request, ex: ['portal', 'wikidata']. Will be used to split webrequest into 
smaller subsets.'
+`tags`  array COMMENT 'List containing tags qualifying 
the request, ex: [portal, wikidata]. Will be used to split webrequest into 
smaller subsets.'
 
 )
 PARTITIONED BY (

-- 
To view, visit https://gerrit.wikimedia.org/r/365089
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6673fbc63296c69c9d9a94170fbb070f2681ea1f
Gerrit-PatchSet: 1
Gerrit-Project: analytics/refinery
Gerrit-Branch: master
Gerrit-Owner: Nuria 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Set labs_puppet_master for labtestpuppetmaster2001

2017-07-13 Thread Andrew Bogott (Code Review)

Andrew Bogott has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/365088 )

Change subject: Set labs_puppet_master for labtestpuppetmaster2001
..


Set labs_puppet_master for labtestpuppetmaster2001

Otherwise it tries to talk to the encapi on labtestcontrol.

Change-Id: Idf7a338d0fe87f1cb84b9fee4791aa49c271881a
---
M hieradata/hosts/labtestpuppetmaster2001.yaml
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Andrew Bogott: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/hieradata/hosts/labtestpuppetmaster2001.yaml 
b/hieradata/hosts/labtestpuppetmaster2001.yaml
index 43bd79f..0dee198 100644
--- a/hieradata/hosts/labtestpuppetmaster2001.yaml
+++ b/hieradata/hosts/labtestpuppetmaster2001.yaml
@@ -17,3 +17,5 @@
 puppetmaster::servers:
   labtestpuppetmaster2001.wikimedia.org:
 - { worker: labtestpuppetmaster2001.wikimedia.org, loadfactor: 10 }
+
+labs_puppet_master: labtestpuppetmaster2001.wikimedia.org

-- 
To view, visit https://gerrit.wikimedia.org/r/365088
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idf7a338d0fe87f1cb84b9fee4791aa49c271881a
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Andrew Bogott 
Gerrit-Reviewer: Andrew Bogott 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Re-enable MediaWiki.Commenting.FunctionComment.MissingDocume...

2017-07-13 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/364850 )

Change subject: Re-enable 
MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic sniff
..


Re-enable MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic sniff

Bug: T168384
Change-Id: I4d4681121df974a8471d7c4c8df8a6158f8df22a
---
M includes/EventLogging/EventLogger.php
M includes/EventLogging/EventLoggerFactory.php
M includes/EventLogging/MWEventLogger.php
M includes/EventLogging/NullLogger.php
M includes/PopupsHooks.php
M phpcs.xml
6 files changed, 37 insertions(+), 3 deletions(-)

Approvals:
  jenkins-bot: Verified
  Jdlrobson: Looks good to me, approved



diff --git a/includes/EventLogging/EventLogger.php 
b/includes/EventLogging/EventLogger.php
index 659f4dc..378afe9 100644
--- a/includes/EventLogging/EventLogger.php
+++ b/includes/EventLogging/EventLogger.php
@@ -27,6 +27,11 @@
 */
const PREVIEWS_SCHEMA_NAME = 'Popups';
 
+   /**
+* Log event
+*
+* @param array $event An associative array containing event data
+*/
public function log( array $event );
 
 }
diff --git a/includes/EventLogging/EventLoggerFactory.php 
b/includes/EventLogging/EventLoggerFactory.php
index c458d20..c1f91f1 100644
--- a/includes/EventLogging/EventLoggerFactory.php
+++ b/includes/EventLogging/EventLoggerFactory.php
@@ -31,16 +31,24 @@
private $registry;
 
/**
-* @var \Config
+* @var Config
 */
private $config;
 
+   /**
+* EventLoggerFactory constructor
+*
+* @param Config $config MediaWiki config
+* @param ExtensionRegistry $registry MediaWiki extension registry
+*/
public function __construct( Config $config, ExtensionRegistry 
$registry ) {
$this->registry = $registry;
$this->config = $config;
}
 
/**
+* Get the EventLogger instance
+*
 * @return EventLogger
 */
public function get() {
diff --git a/includes/EventLogging/MWEventLogger.php 
b/includes/EventLogging/MWEventLogger.php
index 88eda95..86fd4b4 100644
--- a/includes/EventLogging/MWEventLogger.php
+++ b/includes/EventLogging/MWEventLogger.php
@@ -58,9 +58,14 @@
return (float)wfRandom() <= (float)$samplingRate;
}
 
+   /**
+* Log event
+*
+* @param array $event An associative array containing event data
+*/
public function log( array $event ) {
if ( !$this->shouldLog() ) {
-   return false;
+   return;
}
$eventLoggingSchemas = $this->registry->getAttribute( 
'EventLoggingSchemas' );
 
diff --git a/includes/EventLogging/NullLogger.php 
b/includes/EventLogging/NullLogger.php
index 0ce828a..85cf35a 100644
--- a/includes/EventLogging/NullLogger.php
+++ b/includes/EventLogging/NullLogger.php
@@ -22,6 +22,11 @@
 
 class NullLogger implements EventLogger {
 
+   /**
+* Log event
+*
+* @param array $event An associative array containing event data
+*/
public function log( array $event ) {
// just do nothing
}
diff --git a/includes/PopupsHooks.php b/includes/PopupsHooks.php
index aa280fa..9a7807e 100644
--- a/includes/PopupsHooks.php
+++ b/includes/PopupsHooks.php
@@ -33,6 +33,11 @@
 class PopupsHooks {
const PREVIEWS_PREFERENCES_SECTION = 'rendering/reading';
 
+   /**
+* Hook executed on retrieving User beta preferences
+* @param User $user User whose beta preferences are retrieved
+* @param array &$prefs An associative array of all beta preferences
+*/
static function onGetBetaPreferences( User $user, array &$prefs ) {
global $wgExtensionAssetsPath;
if ( PopupsContext::getInstance()->isBetaFeatureEnabled() !== 
true ) {
@@ -95,6 +100,13 @@
}
}
 
+   /**
+* Allows last minute changes to the output page, e.g. adding of CSS or 
JavaScript by extensions.
+*
+* @param OutputPage &$out The Output page object
+* @param Skin &$skin  object that will be used to generate the 
page
+* @return bool
+*/
public static function onBeforePageDisplay( OutputPage &$out, Skin 
&$skin ) {
$module = PopupsContext::getInstance();
$user = $out->getUser();
diff --git a/phpcs.xml b/phpcs.xml
index d3778ad..7255308 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -1,7 +1,6 @@
 
 

-   

.


-- 
To view, visit https://gerrit.wikimedia.org/r/364850
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4d4681121df974a8471d7c4c8df8a6158f8df22a
Gerrit-PatchSet: 3

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Set labs_puppet_master for labtestpuppetmaster2001

2017-07-13 Thread Andrew Bogott (Code Review)

Andrew Bogott has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/365088 )

Change subject: Set labs_puppet_master for labtestpuppetmaster2001
..

Set labs_puppet_master for labtestpuppetmaster2001

Otherwise it tries to talk to the encapi on labtestcontrol.

Change-Id: Idf7a338d0fe87f1cb84b9fee4791aa49c271881a
---
M hieradata/hosts/labtestpuppetmaster2001.yaml
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/88/365088/1

diff --git a/hieradata/hosts/labtestpuppetmaster2001.yaml 
b/hieradata/hosts/labtestpuppetmaster2001.yaml
index 43bd79f..0dee198 100644
--- a/hieradata/hosts/labtestpuppetmaster2001.yaml
+++ b/hieradata/hosts/labtestpuppetmaster2001.yaml
@@ -17,3 +17,5 @@
 puppetmaster::servers:
   labtestpuppetmaster2001.wikimedia.org:
 - { worker: labtestpuppetmaster2001.wikimedia.org, loadfactor: 10 }
+
+labs_puppet_master: labtestpuppetmaster2001.wikimedia.org

-- 
To view, visit https://gerrit.wikimedia.org/r/365088
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Idf7a338d0fe87f1cb84b9fee4791aa49c271881a
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Andrew Bogott 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseQualityConstraints[master]: Fix “Target required claim” error message

2017-07-13 Thread Lucas Werkmeister (WMDE) (Code Review)

Lucas Werkmeister (WMDE) has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/365087 )

Change subject: Fix “Target required claim” error message
..

Fix “Target required claim” error message

The entity that is required to have a claim can be a property, so we
should not assume that its ID is an item ID. Since $targetEntityId is an
EntityId object, not a string, we should directly use formatEntityId()
anyways (formatItemId() optionally parses a string argument into an
ItemId, but we know we have an EntityId object).

Bug: T170597
Change-Id: Ic662eb7f7c46e278e4543051ccc9496042f0f759
---
M includes/ConstraintCheck/Checker/TargetRequiredClaimChecker.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikibaseQualityConstraints
 refs/changes/87/365087/1

diff --git a/includes/ConstraintCheck/Checker/TargetRequiredClaimChecker.php 
b/includes/ConstraintCheck/Checker/TargetRequiredClaimChecker.php
index aa12e52..659d007 100644
--- a/includes/ConstraintCheck/Checker/TargetRequiredClaimChecker.php
+++ b/includes/ConstraintCheck/Checker/TargetRequiredClaimChecker.php
@@ -134,7 +134,7 @@
} else {
$message = wfMessage( 
'wbqc-violation-message-target-required-claim' );
$message->rawParams(
-   
$this->constraintParameterRenderer->formatItemId( $targetEntityId ),
+   
$this->constraintParameterRenderer->formatEntityId( $targetEntityId ),

$this->constraintParameterRenderer->formatEntityId( $propertyId )
);
$message->numParams( count( $items ) );

-- 
To view, visit https://gerrit.wikimedia.org/r/365087
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic662eb7f7c46e278e4543051ccc9496042f0f759
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseQualityConstraints
Gerrit-Branch: master
Gerrit-Owner: Lucas Werkmeister (WMDE) 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Provide HD logos for several Wikiversities

2017-07-13 Thread Urbanecm (Code Review)

Urbanecm has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/365086 )

Change subject: Provide HD logos for several Wikiversities
..

Provide HD logos for several Wikiversities

Change-Id: Ie49e3d700b8de5b6ebc0c4ac0259bc59523ab694
---
A static/images/project-logos/dewikiversity-1.5x.png
A static/images/project-logos/dewikiversity-2x.png
A static/images/project-logos/elwikiversity-1.5x.png
A static/images/project-logos/elwikiversity-2x.png
A static/images/project-logos/enwikiversity-1.5x.png
A static/images/project-logos/enwikiversity-2x.png
A static/images/project-logos/fiwikiversity-1.5x.png
A static/images/project-logos/fiwikiversity-2x.png
A static/images/project-logos/frwikiversity-1.5x.png
A static/images/project-logos/frwikiversity-2x.png
A static/images/project-logos/itwikiversity-1.5x.png
A static/images/project-logos/itwikiversity-2x.png
A static/images/project-logos/kowikiversity-1.5x.png
A static/images/project-logos/kowikiversity-2x.png
A static/images/project-logos/ptwikiversity-1.5x.png
A static/images/project-logos/ptwikiversity-2x.png
A static/images/project-logos/ruwikiversity-1.5x.png
A static/images/project-logos/ruwikiversity-2x.png
A static/images/project-logos/slwikiversity-1.5x.png
A static/images/project-logos/slwikiversity-2x.png
M wmf-config/InitialiseSettings.php
21 files changed, 10 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/86/365086/1

diff --git a/static/images/project-logos/dewikiversity-1.5x.png 
b/static/images/project-logos/dewikiversity-1.5x.png
new file mode 100644
index 000..624958f
--- /dev/null
+++ b/static/images/project-logos/dewikiversity-1.5x.png
Binary files differ
diff --git a/static/images/project-logos/dewikiversity-2x.png 
b/static/images/project-logos/dewikiversity-2x.png
new file mode 100644
index 000..04c1224
--- /dev/null
+++ b/static/images/project-logos/dewikiversity-2x.png
Binary files differ
diff --git a/static/images/project-logos/elwikiversity-1.5x.png 
b/static/images/project-logos/elwikiversity-1.5x.png
new file mode 100644
index 000..2efe944
--- /dev/null
+++ b/static/images/project-logos/elwikiversity-1.5x.png
Binary files differ
diff --git a/static/images/project-logos/elwikiversity-2x.png 
b/static/images/project-logos/elwikiversity-2x.png
new file mode 100644
index 000..3db1b40
--- /dev/null
+++ b/static/images/project-logos/elwikiversity-2x.png
Binary files differ
diff --git a/static/images/project-logos/enwikiversity-1.5x.png 
b/static/images/project-logos/enwikiversity-1.5x.png
new file mode 100644
index 000..65249a5
--- /dev/null
+++ b/static/images/project-logos/enwikiversity-1.5x.png
Binary files differ
diff --git a/static/images/project-logos/enwikiversity-2x.png 
b/static/images/project-logos/enwikiversity-2x.png
new file mode 100644
index 000..2dc0e17
--- /dev/null
+++ b/static/images/project-logos/enwikiversity-2x.png
Binary files differ
diff --git a/static/images/project-logos/fiwikiversity-1.5x.png 
b/static/images/project-logos/fiwikiversity-1.5x.png
new file mode 100644
index 000..ea82ff3
--- /dev/null
+++ b/static/images/project-logos/fiwikiversity-1.5x.png
Binary files differ
diff --git a/static/images/project-logos/fiwikiversity-2x.png 
b/static/images/project-logos/fiwikiversity-2x.png
new file mode 100644
index 000..1c06570
--- /dev/null
+++ b/static/images/project-logos/fiwikiversity-2x.png
Binary files differ
diff --git a/static/images/project-logos/frwikiversity-1.5x.png 
b/static/images/project-logos/frwikiversity-1.5x.png
new file mode 100644
index 000..75c8a2e
--- /dev/null
+++ b/static/images/project-logos/frwikiversity-1.5x.png
Binary files differ
diff --git a/static/images/project-logos/frwikiversity-2x.png 
b/static/images/project-logos/frwikiversity-2x.png
new file mode 100644
index 000..05546a0
--- /dev/null
+++ b/static/images/project-logos/frwikiversity-2x.png
Binary files differ
diff --git a/static/images/project-logos/itwikiversity-1.5x.png 
b/static/images/project-logos/itwikiversity-1.5x.png
new file mode 100644
index 000..86466fc
--- /dev/null
+++ b/static/images/project-logos/itwikiversity-1.5x.png
Binary files differ
diff --git a/static/images/project-logos/itwikiversity-2x.png 
b/static/images/project-logos/itwikiversity-2x.png
new file mode 100644
index 000..b914572
--- /dev/null
+++ b/static/images/project-logos/itwikiversity-2x.png
Binary files differ
diff --git a/static/images/project-logos/kowikiversity-1.5x.png 
b/static/images/project-logos/kowikiversity-1.5x.png
new file mode 100644
index 000..67dff3f
--- /dev/null
+++ b/static/images/project-logos/kowikiversity-1.5x.png
Binary files differ
diff --git a/static/images/project-logos/kowikiversity-2x.png 
b/static/images/project-logos/kowikiversity-2x.png
new file mode 100644
index 000..ce558ec
--- /dev/null
+++

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Advise users when they are reading an article from an offlin...

2017-07-13 Thread Mholloway (Code Review)

Mholloway has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/365085 )

Change subject: Advise users when they are reading an article from an offline 
compilation
..

Advise users when they are reading an article from an offline compilation

* Shows a toast with the date downloaded upon loading the article
* Substitutes the footer "last modified" HTML with a download date string

Bug: T166652
Change-Id: I7b95f830224023493c860b8099f1563daf53
---
M app/src/main/java/org/wikipedia/offline/Compilation.java
M app/src/main/java/org/wikipedia/offline/OfflineManager.java
M app/src/main/java/org/wikipedia/page/Page.java
M app/src/main/java/org/wikipedia/page/PageFragmentLoadState.java
M app/src/main/java/org/wikipedia/page/bottomcontent/BottomContentHandler.java
M app/src/main/java/org/wikipedia/util/DateUtil.java
M app/src/main/res/values-qq/strings.xml
M app/src/main/res/values/strings.xml
M app/src/test/java/org/wikipedia/offline/OfflineManagerTest.java
9 files changed, 88 insertions(+), 14 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia 
refs/changes/85/365085/1

diff --git a/app/src/main/java/org/wikipedia/offline/Compilation.java 
b/app/src/main/java/org/wikipedia/offline/Compilation.java
index 03d7c9a..ec354dd 100644
--- a/app/src/main/java/org/wikipedia/offline/Compilation.java
+++ b/app/src/main/java/org/wikipedia/offline/Compilation.java
@@ -57,6 +57,10 @@
 return "";
 }
 
+public long timestamp() {
+return file.lastModified();
+}
+
 @NonNull public String description() {
 try {
 return reader.getZimDescription();
diff --git a/app/src/main/java/org/wikipedia/offline/OfflineManager.java 
b/app/src/main/java/org/wikipedia/offline/OfflineManager.java
index 6aeb69b..b6dd4e7 100644
--- a/app/src/main/java/org/wikipedia/offline/OfflineManager.java
+++ b/app/src/main/java/org/wikipedia/offline/OfflineManager.java
@@ -98,11 +98,11 @@
 return null;
 }
 
-@NonNull public String getHtmlForTitle(@NonNull String title) throws 
IOException {
+@NonNull public HtmlResult getHtmlForTitle(@NonNull String title) throws 
IOException {
 for (Compilation c : compilations) {
 ByteArrayOutputStream stream = c.getDataForTitle(title);
 if (stream != null) {
-return stream.toString("utf-8");
+return new HtmlResult(stream.toString("utf-8"), c.timestamp());
 }
 }
 throw new IOException("Content not found in any compilation for " + 
title);
@@ -135,6 +135,24 @@
 this.compilations = compilations;
 }
 
+public static class HtmlResult {
+@NonNull private String html;
+private long timestamp;
+
+public HtmlResult(@NonNull String html, long timestamp) {
+this.html = html;
+this.timestamp = timestamp;
+}
+
+public String html() {
+return html;
+}
+
+public long timestamp() {
+return timestamp;
+}
+}
+
 private OfflineManager() {
 }
 }
diff --git a/app/src/main/java/org/wikipedia/page/Page.java 
b/app/src/main/java/org/wikipedia/page/Page.java
index e3db2fd..a3f9a28 100755
--- a/app/src/main/java/org/wikipedia/page/Page.java
+++ b/app/src/main/java/org/wikipedia/page/Page.java
@@ -6,6 +6,7 @@
 
 import org.wikipedia.settings.RbSwitch;
 
+import java.util.Date;
 import java.util.List;
 
 /**
@@ -18,6 +19,8 @@
 @NonNull private final PageTitle title;
 @NonNull private final List sections;
 @NonNull private final PageProperties pageProperties;
+
+@Nullable private Date zimDownloadDate;
 
 /**
  * An indicator what payload version the page content was originally 
retrieved from.
@@ -90,6 +93,18 @@
 return !isMainPage() && getTitle().namespace() == Namespace.MAIN;
 }
 
+public boolean isFromZimCompilation() {
+return zimDownloadDate != null;
+}
+
+@Nullable public Date getZimDownloadDate() {
+return zimDownloadDate;
+}
+
+public void setZimDownloadDate(@NonNull Date date) {
+this.zimDownloadDate = date;
+}
+
 /** For old PHP API */
 public void addRemainingSections(List remainingSections) {
 sections.addAll(remainingSections);
diff --git a/app/src/main/java/org/wikipedia/page/PageFragmentLoadState.java 
b/app/src/main/java/org/wikipedia/page/PageFragmentLoadState.java
index 6cdd65d..f06ddd0 100644
--- a/app/src/main/java/org/wikipedia/page/PageFragmentLoadState.java
+++ b/app/src/main/java/org/wikipedia/page/PageFragmentLoadState.java
@@ -54,6 +54,7 @@
 import java.text.ParseException;
 import java.util.ArrayList;
 import java.util.Collections;
+import java.util.Date;
 import java.util.List;
 import java.util.Locale;
 import java.util.Map;
@@ -435,9 +436,13 @@
 try {
 Page page = model.getPage();

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Provide HD logos for several projects

2017-07-13 Thread Urbanecm (Code Review)

Urbanecm has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/365084 )

Change subject: Provide HD logos for several projects
..

Provide HD logos for several projects

Bug: T150618
Change-Id: I6d0ecffadf85a4d7e8370ae6cb27a788c92782e5
---
A static/images/project-logos/anwiki-1.5x.png
A static/images/project-logos/anwiki-2x.png
A static/images/project-logos/arcwiki-1.5x.png
A static/images/project-logos/arcwiki-2x.png
A static/images/project-logos/arwiki-1.5x.png
A static/images/project-logos/arwiki-2x.png
A static/images/project-logos/arzwiki-1.5x.png
A static/images/project-logos/arzwiki-2x.png
A static/images/project-logos/astwiki-1.5x.png
A static/images/project-logos/astwiki-2x.png
A static/images/project-logos/aswiki-1.5x.png
A static/images/project-logos/aswiki-2x.png
A static/images/project-logos/azbwiki-1.5x.png
A static/images/project-logos/azbwiki-2x.png
A static/images/project-logos/barwiki-1.5x.png
A static/images/project-logos/barwiki-2x.png
A static/images/project-logos/bewiki-1.5x.png
A static/images/project-logos/bewiki-2x.png
A static/images/project-logos/bjnwiki-1.5x.png
A static/images/project-logos/bjnwiki-2x.png
A static/images/project-logos/bowiki-1.5x.png
A static/images/project-logos/bowiki-2x.png
A static/images/project-logos/bpywiki-1.5x.png
A static/images/project-logos/bpywiki-2x.png
A static/images/project-logos/cawiki-1.5x.png
A static/images/project-logos/cawiki-2x.png
A static/images/project-logos/chrwiki-1.5x.png
A static/images/project-logos/chrwiki-2x.png
A static/images/project-logos/chywiki-1.5x.png
A static/images/project-logos/chywiki-2x.png
A static/images/project-logos/ckbwiki-1.5x.png
A static/images/project-logos/ckbwiki-2x.png
A static/images/project-logos/crhwiki-1.5x.png
A static/images/project-logos/crhwiki-2x.png
A static/images/project-logos/crwiki-1.5x.png
A static/images/project-logos/crwiki-2x.png
A static/images/project-logos/csbwiki-1.5x.png
A static/images/project-logos/csbwiki-2x.png
A static/images/project-logos/cvwiki-1.5x.png
A static/images/project-logos/cvwiki-2x.png
A static/images/project-logos/dvwiki-1.5x.png
A static/images/project-logos/dvwiki-2x.png
A static/images/project-logos/dzwiki-1.5x.png
A static/images/project-logos/dzwiki-2x.png
A static/images/project-logos/eewiki-1.5x.png
A static/images/project-logos/eewiki-2x.png
A static/images/project-logos/elwiki-1.5x.png
A static/images/project-logos/elwiki-2x.png
A static/images/project-logos/eowiki-1.5x.png
A static/images/project-logos/eowiki-2x.png
A static/images/project-logos/etwiki-1.5x.png
A static/images/project-logos/etwiki-2x.png
A static/images/project-logos/extwiki-1.5x.png
A static/images/project-logos/extwiki-2x.png
A static/images/project-logos/fiwiki-1.5x.png
A static/images/project-logos/fiwiki-2x.png
A static/images/project-logos/fjwiki-1.5x.png
A static/images/project-logos/fjwiki-2x.png
A static/images/project-logos/ganwiki-1.5x.png
A static/images/project-logos/ganwiki-2x.png
A static/images/project-logos/gawiki-1.5x.png
A static/images/project-logos/gawiki-2x.png
A static/images/project-logos/glkwiki-1.5x.png
A static/images/project-logos/glkwiki-2x.png
A static/images/project-logos/gomwiki-1.5x.png
A static/images/project-logos/gomwiki-2x.png
A static/images/project-logos/guwiki-1.5x.png
A static/images/project-logos/guwiki-2x.png
A static/images/project-logos/hiwiki-1.5x.png
A static/images/project-logos/hiwiki-2x.png
A static/images/project-logos/huwiki-1.5x.png
A static/images/project-logos/huwiki-2x.png
A static/images/project-logos/iswiki-1.5x.png
A static/images/project-logos/iswiki-2x.png
A static/images/project-logos/kawiki-1.5x.png
A static/images/project-logos/kawiki-2x.png
A static/images/project-logos/kbdwiki-1.5x.png
A static/images/project-logos/kbdwiki-2x.png
A static/images/project-logos/kgwiki-1.5x.png
A static/images/project-logos/kgwiki-2x.png
A static/images/project-logos/kkwiki-1.5x.png
A static/images/project-logos/kkwiki-2x.png
A static/images/project-logos/klwiki-1.5x.png
A static/images/project-logos/klwiki-2x.png
A static/images/project-logos/kmwiki-1.5x.png
A static/images/project-logos/kmwiki-2x.png
A static/images/project-logos/krcwiki-1.5x.png
A static/images/project-logos/krcwiki-2x.png
A static/images/project-logos/kswiki-1.5x.png
A static/images/project-logos/kswiki-2x.png
A static/images/project-logos/kwwiki-1.5x.png
A static/images/project-logos/kwwiki-2x.png
A static/images/project-logos/lbewiki-1.5x.png
A static/images/project-logos/lbewiki-2x.png
A static/images/project-logos/lowiki-1.5x.png
A static/images/project-logos/lowiki-2x.png
A static/images/project-logos/lrcwiki-1.5x.png
A static/images/project-logos/lrcwiki-2x.png
A static/images/project-logos/lvwiki-1.5x.png
A static/images/project-logos/lvwiki-2x.png
A static/images/project-logos/minwiki-1.5x.png
A static/images/project-logos/minwiki-2x.png
A

[MediaWiki-commits] [Gerrit] analytics/refinery[master]: Adding "tags" column to webrequest

2017-07-13 Thread Ottomata (Code Review)

Ottomata has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/362310 )

Change subject: Adding "tags" column to webrequest
..


Adding "tags" column to webrequest

This column will hold an array of strings we call tags.
It will be populated by a UDF
that understands webrequest data and can classify
requests into types like "portal", "wikidata" and others.

Tags are used by a job that splits webrequest into
smaller subsets.

Bug: T164021
Change-Id: Ie855d6b3a2d12921a4a89de3f84ec5ff5d1fe01a
---
M hive/webrequest/create_webrequest_table.hql
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Ottomata: Verified; Looks good to me, approved



diff --git a/hive/webrequest/create_webrequest_table.hql 
b/hive/webrequest/create_webrequest_table.hql
index bb6c0b0..b9b8ca6 100644
--- a/hive/webrequest/create_webrequest_table.hql
+++ b/hive/webrequest/create_webrequest_table.hql
@@ -54,7 +54,9 @@
 `normalized_host`   struct, tld: String>  COMMENT 'struct containing 
project_class (such as wikipedia or wikidata for instance), project (such as en 
or commons), qualifiers (a list of in-between values, such as m and/or zero) 
and tld (org most often)',
 `pageview_info` map  COMMENT 'map containing project, 
language_variant and page_title values only when is_pageview = TRUE.',
 `page_id`   bigint  COMMENT 'MediaWiki page_id for this page 
title. For redirects this could be the page_id of the redirect or the page_id 
of the target. This may not always be set, even if the page is actually a 
pageview.',
-`namespace_id`  int COMMENT 'MediaWiki namespace_id for this page 
title. This may not always be set, even if the page is actually a pageview.'
+`namespace_id`  int COMMENT 'MediaWiki namespace_id for this page 
title. This may not always be set, even if the page is actually a pageview.',
+`tags`  array COMMENT 'List containing tags qualifying 
the request, ex: ['portal', 'wikidata']. Will be used to split webrequest into 
smaller subsets.'
+
 )
 PARTITIONED BY (
 `webrequest_source` string  COMMENT 'Source cluster',

-- 
To view, visit https://gerrit.wikimedia.org/r/362310
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie855d6b3a2d12921a4a89de3f84ec5ff5d1fe01a
Gerrit-PatchSet: 5
Gerrit-Project: analytics/refinery
Gerrit-Branch: master
Gerrit-Owner: Nuria 
Gerrit-Reviewer: Joal 
Gerrit-Reviewer: Mforns 
Gerrit-Reviewer: Nuria 
Gerrit-Reviewer: Ottomata 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Make autosuggest wordmatch bold without underline

2017-07-13 Thread Pmiazga (Code Review)

Pmiazga has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/365083 )

Change subject: Make autosuggest wordmatch bold without underline
..

Make autosuggest wordmatch bold without underline

Changes:
 - removed bolding from h3 element
 - removed text-decoration: underline from h3 strong element

Bug: T168034
Change-Id: I49b809244849aff60d2d2c5235b3859f68c0d221
---
M resources/mobile.search/SearchOverlay.less
1 file changed, 7 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/83/365083/1

diff --git a/resources/mobile.search/SearchOverlay.less 
b/resources/mobile.search/SearchOverlay.less
index 3503b95..35bebaf 100644
--- a/resources/mobile.search/SearchOverlay.less
+++ b/resources/mobile.search/SearchOverlay.less
@@ -101,7 +101,14 @@
}
h3 {
margin: 0;
+   font-weight: normal;
+
+   strong {
+   text-decoration: none;
+   }
}
+
+
.wikidata-description {
font-size: 0.8em;
margin-top: 0.5em;

-- 
To view, visit https://gerrit.wikimedia.org/r/365083
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I49b809244849aff60d2d2c5235b3859f68c0d221
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Pmiazga 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] wikidata...gui[master]: Add icon to example button in header toolbar

2017-07-13 Thread Jonas Kress (WMDE) (Code Review)

Jonas Kress (WMDE) has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/365082 )

Change subject: Add icon to example button in header toolbar
..

Add icon to example button in header toolbar

Change-Id: I97f237f68f5b98e42d85595f5a288f317226af54
---
M index.html
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/wikidata/query/gui 
refs/changes/82/365082/1

diff --git a/index.html b/index.html
index 7e3e6ca..4fab6e6 100644
--- a/index.html
+++ b/index.html
@@ -52,7 +52,8 @@



-   
+   
+




-- 
To view, visit https://gerrit.wikimedia.org/r/365082
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I97f237f68f5b98e42d85595f5a288f317226af54
Gerrit-PatchSet: 1
Gerrit-Project: wikidata/query/gui
Gerrit-Branch: master
Gerrit-Owner: Jonas Kress (WMDE) 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

1 2 3 4 >

1 - 100 of 350 matches

Mail list logo