date:20171021

[MediaWiki-commits] [Gerrit] mediawiki...AbuseFilter[master]: Use Equivset library intead of AntiSpoof

2017-10-21 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/383717 )

Change subject: Use Equivset library intead of AntiSpoof
..


Use Equivset library intead of AntiSpoof

Use the new equivset library instead of AntiSpoof.

Bug: T175413
Change-Id: I439387deeba99543e194c210953ac73ff98bc5b7
Depends-On: I977d3498b2084a426e2ab4d85c000d1b9dcfe824
---
M .phpcs.xml
M composer.json
M includes/parser/AbuseFilterParser.php
M tests/phpunit/parserTest.php
4 files changed, 14 insertions(+), 17 deletions(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/.phpcs.xml b/.phpcs.xml
index 01df36b..aabe27c 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -16,5 +16,4 @@
.


-   ^extensions
 
diff --git a/composer.json b/composer.json
index f408584..54aaf64 100644
--- a/composer.json
+++ b/composer.json
@@ -6,7 +6,7 @@
"license": "GPL-2.0+",
"require": {
"php": ">=5.4",
-   "composer/installers": "1.*,>=1.0.1"
+   "wikimedia/equivset": "^1.0"
},
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
@@ -16,7 +16,7 @@
"scripts": {
"fix": "phpcbf",
"test": [
-   "parallel-lint . --exclude extensions --exclude 
node_modules --exclude vendor",
+   "parallel-lint . --exclude node_modules --exclude 
vendor",
"phpcs -p -s"
]
}
diff --git a/includes/parser/AbuseFilterParser.php 
b/includes/parser/AbuseFilterParser.php
index df98722..b866f81 100644
--- a/includes/parser/AbuseFilterParser.php
+++ b/includes/parser/AbuseFilterParser.php
@@ -1,5 +1,7 @@
 normalize( $s );
}
 
/**
diff --git a/tests/phpunit/parserTest.php b/tests/phpunit/parserTest.php
index 6d7322a..ab5ac91 100644
--- a/tests/phpunit/parserTest.php
+++ b/tests/phpunit/parserTest.php
@@ -55,11 +55,6 @@
 * @dataProvider readTests
 */
public function testParser( $testName, $rule, $expected ) {
-   if ( !class_exists( 'AntiSpoof' ) && preg_match( 
'/(?:cc)?norm(?:\(|_)/i', $rule ) ) {
-   // The norm and ccnorm parser functions aren't working 
correctly without AntiSpoof
-   $this->markTestSkipped( 'Parser test ' . $testName . ' 
requires the AntiSpoof extension' );
-   }
-
foreach ( self::getParsers() as $parser ) {
$actual = $parser->parse( $rule );
$this->assertEquals( $expected, $actual, 'Running 
parser test ' . $testName );

-- 
To view, visit https://gerrit.wikimedia.org/r/383717
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I439387deeba99543e194c210953ac73ff98bc5b7
Gerrit-PatchSet: 9
Gerrit-Project: mediawiki/extensions/AbuseFilter
Gerrit-Branch: master
Gerrit-Owner: Dbarratt 
Gerrit-Reviewer: Dbarratt 
Gerrit-Reviewer: Dmaza 
Gerrit-Reviewer: Huji 
Gerrit-Reviewer: Jackmcbarn 
Gerrit-Reviewer: Kaldari 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: MaxSem 
Gerrit-Reviewer: Reedy 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...AntiSpoof[master]: Remove equivset from AntiSpoof and use new Equivset library.

2017-10-21 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/383948 )

Change subject: Remove equivset from AntiSpoof and use new Equivset library.
..


Remove equivset from AntiSpoof and use new Equivset library.

Equivset is now an external library that should be used.

Bug: T177983
Change-Id: Ia8ed5edce08a8e0fe44ffba02072cc4fbd80dc61
Depends-On: I977d3498b2084a426e2ab4d85c000d1b9dcfe824
---
M .phpcs.xml
M AntiSpoof_body.php
M composer.json
D equivset.php
D equivset.ser
D maintenance/Makefile
D maintenance/equivset.head
D maintenance/equivset.in
D maintenance/equivset.txt
D maintenance/generateEquivset.php
10 files changed, 11 insertions(+), 15,263 deletions(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified




-- 
To view, visit https://gerrit.wikimedia.org/r/383948
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia8ed5edce08a8e0fe44ffba02072cc4fbd80dc61
Gerrit-PatchSet: 6
Gerrit-Project: mediawiki/extensions/AntiSpoof
Gerrit-Branch: master
Gerrit-Owner: Dbarratt 
Gerrit-Reviewer: Dbarratt 
Gerrit-Reviewer: Dmaza 
Gerrit-Reviewer: Kaldari 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: MaxSem 
Gerrit-Reviewer: Reedy 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] pywikibot/core[master]: [doc] Fix doc string in a way not to break the options tables

2017-10-21 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/385799 )

Change subject: [doc] Fix doc string in a way not to break the options tables
..


[doc] Fix doc string in a way not to break the options tables

See:

https://doc.wikimedia.org/pywikibot/api_ref/pywikibot.html#generator-options

Change-Id: Iab02d9f55ba6e6a734bad65d9fccbdda9769409e
---
M pywikibot/pagegenerators.py
1 file changed, 224 insertions(+), 215 deletions(-)

Approvals:
  Dalba: Looks good to me, approved
  jenkins-bot: Verified
  Zoranzoki21: Looks good to me, but someone else must approve



diff --git a/pywikibot/pagegenerators.py b/pywikibot/pagegenerators.py
index b0c6dab..abd8469 100644
--- a/pywikibot/pagegenerators.py
+++ b/pywikibot/pagegenerators.py
@@ -69,291 +69,300 @@
 GENERATOR OPTIONS
 =
 
--cat  Work on all pages which are in a specific category.
-  Argument can also be given as "-cat:categoryname" or
-  as "-cat:categoryname|fromtitle" (using # instead of |
-  is also allowed in this one and the following)
+-catWork on all pages which are in a specific category.
+Argument can also be given as "-cat:categoryname" or
+as "-cat:categoryname|fromtitle" (using # instead of |
+is also allowed in this one and the following)
 
--catr Like -cat, but also recursively includes pages in
-  subcategories, sub-subcategories etc. of the
-  given category.
-  Argument can also be given as "-catr:categoryname" or
-  as "-catr:categoryname|fromtitle".
+-catr   Like -cat, but also recursively includes pages in
+subcategories, sub-subcategories etc. of the
+given category.
+Argument can also be given as "-catr:categoryname" or
+as "-catr:categoryname|fromtitle".
 
--subcats  Work on all subcategories of a specific category.
-  Argument can also be given as "-subcats:categoryname" or
-  as "-subcats:categoryname|fromtitle".
+-subcatsWork on all subcategories of a specific category.
+Argument can also be given as "-subcats:categoryname" or
+as "-subcats:categoryname|fromtitle".
 
--subcatsr Like -subcats, but also includes sub-subcategories etc. of
-  the given category.
-  Argument can also be given as "-subcatsr:categoryname" or
-  as "-subcatsr:categoryname|fromtitle".
+-subcatsr   Like -subcats, but also includes sub-subcategories etc. of
+the given category.
+Argument can also be given as "-subcatsr:categoryname" or
+as "-subcatsr:categoryname|fromtitle".
 
--uncatWork on all pages which are not categorised.
+-uncat  Work on all pages which are not categorised.
 
--uncatcat Work on all categories which are not categorised.
+-uncatcat   Work on all categories which are not categorised.
 
--uncatfiles   Work on all files which are not categorised.
+-uncatfiles Work on all files which are not categorised.
 
--file Read a list of pages to treat from the named text file.
-  Page titles in the file may be either enclosed with
-  [[brackets]], or be separated by new lines.
-  Argument can also be given as "-file:filename".
+-file   Read a list of pages to treat from the named text file.
+Page titles in the file may be either enclosed with
+[[brackets]], or be separated by new lines.
+Argument can also be given as "-file:filename".
 
--filelinksWork on all pages that use a certain image/media file.
-  Argument can also be given as "-filelinks:filename".
+-filelinks  Work on all pages that use a certain image/media file.
+Argument can also be given as "-filelinks:filename".
 
--search   Work on all pages that are found in a MediaWiki search
-  across all namespaces.
+-search Work on all pages that are found in a MediaWiki search
+across all namespaces.
 
--logeventsWork on articles that were on a specified Special:Log.
-  The value may be a comma separated list of these values:
+-logevents  Work on articles that were on a specified Special:Log.
+The value may be a comma separated list of these values:
 
-  logevent,username,start,end
+logevent,username,start,end
 
-  or for backward compatibility:
+

[MediaWiki-commits] [Gerrit] mediawiki...Timeless[master]: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0

2017-10-21 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/385775 )

Change subject: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
..


build: Updating mediawiki/mediawiki-codesniffer to 14.1.0

And moved phpcs.xml to .phpcs.xml (T177256).

Change-Id: I02f392fabe71a0425467a88f63fe9f6e18a98f5a
---
R .phpcs.xml
M TimelessTemplate.php
M composer.json
3 files changed, 12 insertions(+), 12 deletions(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/phpcs.xml b/.phpcs.xml
similarity index 100%
rename from phpcs.xml
rename to .phpcs.xml
diff --git a/TimelessTemplate.php b/TimelessTemplate.php
index bee568c..d035e3b 100644
--- a/TimelessTemplate.php
+++ b/TimelessTemplate.php
@@ -119,16 +119,16 @@
 * @param string $name
 * @param array|string $content array of links for use with 
makeListItem, or a block of text
 *Expected array format:
-*  [
-*  $name => [
-*  'links' => [ '0' =>
-*  [ 'href' => ..., 'single-id' => ..., 
'text' => ... ]
-*  ],
-*  'id' => ...,
-*  'active' => ...
-*  ],
-*  ...
-*  ]
+*  [
+*  $name => [
+*  'links' => [ '0' =>
+*  [ 'href' => ..., 'single-id' => ..., 
'text' => ... ]
+*  ],
+*  'id' => ...,
+*  'active' => ...
+*  ],
+*  ...
+*  ]
 * @param null|string|array|bool $msg
 *
 * @return string html
@@ -393,7 +393,7 @@
 * Page tools in sidebar
 *
 * @return string html
-**/
+*/
protected function getPageToolSidebar() {
$pageTools = '';
if ( count( $this->pileOfTools['page-secondary'] ) > 0 ) {
diff --git a/composer.json b/composer.json
index 3ec375d..95bdb5f 100644
--- a/composer.json
+++ b/composer.json
@@ -1,7 +1,7 @@
 {
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
-   "mediawiki/mediawiki-codesniffer": "13.0.0",
+   "mediawiki/mediawiki-codesniffer": "14.1.0",
"jakub-onderka/php-console-highlighter": "0.3.2"
},
"scripts": {

-- 
To view, visit https://gerrit.wikimedia.org/r/385775
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I02f392fabe71a0425467a88f63fe9f6e18a98f5a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Timeless
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 
Gerrit-Reviewer: Jack Phoenix 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: Umherirrender 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...UserStatus[master]: Add missing qqq message documentation

2017-10-21 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/385398 )

Change subject: Add missing qqq message documentation
..


Add missing qqq message documentation

Activate banana checker

Change-Id: I2afd372aaffd3900d8b3417c1f71231ad308f1bd
---
M Gruntfile.js
M i18n/qqq.json
2 files changed, 34 insertions(+), 1 deletion(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/Gruntfile.js b/Gruntfile.js
index 1c2a4a1..dc2f66e 100644
--- a/Gruntfile.js
+++ b/Gruntfile.js
@@ -24,6 +24,6 @@
}
} );
 
-   grunt.registerTask( 'test', [ 'jshint', 'jsonlint', /** 'banana' **/] );
+   grunt.registerTask( 'test', [ 'jshint', 'jsonlint', 'banana' ] );
grunt.registerTask( 'default', 'test' );
 };
diff --git a/i18n/qqq.json b/i18n/qqq.json
index 186aa6c..bff56bc 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -3,6 +3,39 @@
"authors": []
},
"userstatus-desc": 
"{{desc|name=UserStatus|url=https://www.mediawiki.org/wiki/Extension:UserStatus}};,
+   "userstatus-network-thoughts": "A page title on [[Special:FanUpdates]]",
+   "userstatus-back-to-network": "A link text",
+   "userstatus-showing-thoughts": "A navigation link text",
+   "userstatus-prev": "A navigation link text",
+   "userstatus-next": "A navigation link text",
+   "userstatus-btn-add": "A button text",
+   "userstatus-view-all-updates": "A link text",
+   "userstatus-delete": "A button text",
+   "userstatus-ago": "Phrase for indicating how long ago something 
happened.",
+   "userstatus-time-days": "Phrase for indicating how long ago something 
happened.",
+   "userstatus-time-hours": "Phrase for indicating how long ago something 
happened.",
+   "userstatus-time-minutes": "Phrase for indicating how long ago 
something happened.",
+   "userstatus-time-seconds": "Phrase for indicating how long ago 
something happened.",
+   "userstatus-no-updates": "A hint about a empty result",
+   "userstatus-woops": "A page title",
+   "userstatus-no-user": "An error message",
+   "userstatus-your-thoughts": "A page title",
+   "userstatus-user-thoughts": "A page title",
+   "userstatus-user-profile": "A link text",
+   "userstatus-back-your-profile": "A link text",
+   "userstatus-back-user-profile": "A link text",
+   "userstatus-all-team-updates": "A link text",
+   "userstatus-delete-thought-text": "A link text",
+   "userstatus-num-agree": "Make count readable",
+   "userstatus-agree": "A link text",
+   "userstatus-see-who-agrees": "A link text",
+   "userstatus-invalid-link": "An error message",
+   "userstatus-who-agrees": "A header",
+   "userstatus-nobody-agrees": "A hint about a empty result",
+   "userstatus-no-new-thoughts": "A hint about a empty result",
+   "userstatus-just-added": "Phrase for indicating how long ago something 
happened.",
+   "userstatus-confirm-delete": "A button text used in javascript",
+   "right-delete-status-updates": "{{doc-right|delete-status-updates}}",
"apihelp-userstatus-description": 
"{{doc-apihelp-description|userstatus}}",
"apihelp-userstatus-summary": "{{doc-apihelp-summary|userstatus}}",
"apihelp-userstatus-param-what": 
"{{doc-apihelp-param|userstatus|what}}",

-- 
To view, visit https://gerrit.wikimedia.org/r/385398
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2afd372aaffd3900d8b3417c1f71231ad308f1bd
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/UserStatus
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: Nikerabbit 
Gerrit-Reviewer: Raimond Spekking 
Gerrit-Reviewer: Siebrand 
Gerrit-Reviewer: Umherirrender 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...EditAccount[master]: Add missing qqq message documentation

2017-10-21 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/385464 )

Change subject: Add missing qqq message documentation
..


Add missing qqq message documentation

Activate banana checker

Change-Id: I5186c5f220c91c69fb081da18396331907c52b08
---
M Gruntfile.js
M i18n/qqq.json
M package.json
3 files changed, 68 insertions(+), 14 deletions(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/Gruntfile.js b/Gruntfile.js
index 182da15..a45071e 100644
--- a/Gruntfile.js
+++ b/Gruntfile.js
@@ -1,20 +1,21 @@
 /*jshint node:true */
 module.exports = function ( grunt ) {
grunt.loadNpmTasks( 'grunt-jsonlint' );
-   // grunt.loadNpmTasks( 'grunt-banana-checker' );
+   grunt.loadNpmTasks( 'grunt-banana-checker' );
 
grunt.initConfig( {
-   /* banana: {
+   banana: {
all: 'i18n/'
-   }, */
+   },
jsonlint: {
all: [
'**/*.json',
-   '!node_modules/**'
+   '!node_modules/**',
+   '!vendor/**'
]
}
} );
 
-   grunt.registerTask( 'test', [ 'jsonlint', /* 'banana' */ ] );
+   grunt.registerTask( 'test', [ 'jsonlint', 'banana' ] );
grunt.registerTask( 'default', 'test' );
 };
diff --git a/i18n/qqq.json b/i18n/qqq.json
index 9b374b9..c8f8492 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -8,18 +8,70 @@
"Umherirrender"
]
},
-   "editaccount-desc": "{{desc}}",
-   "editaccount-success-disable": "Parameters:\n* $1 is a username.",
-   "editaccount-success-toggleadopt": "Indicates that a user has been 
successfully verified as an adopter of a wiki. Parameters:\n* $1 is a plain 
text username.",
-   "editaccount-status-realuser": "This is the status of the account in 
the UserLogin system – a \"real user\" means an active account, while a 
\"temporary user\" means it's an inactive account. Accounts are activated once 
the user clicks on a link in an e-mail we send them.",
-   "editaccount-status-tempuser": "\"Temporary user\" indicates an account 
that is inactive. An account is activated and becomes a \"real user\" once the 
user clicks on a link in an e-mail we send them.",
-   "right-editaccount": "{{doc-right|editaccount}}",
+   "editaccount": "{{doc-special}}",
+   "editaccount-general-description": "A description message",
+   "editaccount-user-id": "A label message",
+   "editaccount-user-reg-date": "A label message",
+   "editaccount-return": "A linktext message",
+   "editaccount-desc": 
"{{desc|name=EditAccount|url=https://www.mediawiki.org/wiki/Extension:EditAccount}};,
+   "editaccount-frame-manage": "A legend message",
+   "editaccount-frame-usage": "Label for note field. In this context, 
\"note\" refers to extra information about the extension and its functionality",
+   "editaccount-usage": "A description message",
+   "editaccount-label-select": "A label message",
+   "editaccount-submit-account": "A tooltip message",
+   "editaccount-frame-account": "A legend message",
+   "editaccount-frame-close": "A legend message",
+   "editaccount-label-email": "A label message",
+   "editaccount-label-pass": "A label message",
+   "editaccount-label-realname": "A label message",
+   "editaccount-label-clearunsub": "A label message",
"editaccount-label-toggleadopt": "Label for option to toggle whether or 
not the user is allowed to automatically adopt a wiki.",
"editaccount-label-toggleadopt-prevent": "Label for option to prevent 
user from automatically adopting a wiki.",
"editaccount-label-toggleadopt-allow": "Label for option to allow user 
to automatically adopting a wiki.",
-   "editaccount-submit-button": "Text of the submission button.",
"editaccount-label-reason": "Label for reason field.",
-   "action-editaccount": "{{doc-action|editaccount}}",
+   "editaccount-submit-email": "A button text",
+   "editaccount-submit-pass": "A button text",
+   "editaccount-submit-realname": "A button text",
+   "editaccount-submit-clearunsub": "A button text",
+   "editaccount-submit-cleardisable": "A button text",
+   "editaccount-submit-close": "A button text",
+   "editaccount-submit-button": "Text of the submission button.",
+   "editaccount-usage-close": "A description message",
+   "editaccount-warning-close": "A description message",
+   "editaccount-status": "A legend message",
+   "editaccount-success-email": "A status message",
+   "editaccount-success-email-blank": "A status message",
+   "editaccount-success-pass": "A status message",
+

[MediaWiki-commits] [Gerrit] mediawiki/vendor[master]: Adding Equivset for AbuseFilter & AntiSpoof

2017-10-21 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/383970 )

Change subject: Adding Equivset for AbuseFilter & AntiSpoof
..


Adding Equivset for AbuseFilter & AntiSpoof

The Equivset has been remove from AntiSpoof and a new library has
been created from it. Both AbuseFiler & AntiSpoof now require this
library.

Bug: T178537
Change-Id: I977d3498b2084a426e2ab4d85c000d1b9dcfe824
---
M composer.json
M composer.lock
M composer/autoload_classmap.php
M composer/autoload_psr4.php
M composer/autoload_static.php
M composer/installed.json
A wikimedia/equivset/COPYING
A wikimedia/equivset/README
A wikimedia/equivset/bin/console
A wikimedia/equivset/data/equivset.in
A wikimedia/equivset/dist/equivset.json
A wikimedia/equivset/dist/equivset.ser
A wikimedia/equivset/dist/equivset.txt
A wikimedia/equivset/phpunit.xml
A wikimedia/equivset/src/Command/GenerateEquivset.php
A wikimedia/equivset/src/Equivset.php
A wikimedia/equivset/src/Exception/EquivsetException.php
17 files changed, 15,765 insertions(+), 1 deletion(-)

Approvals:
  Huji: Looks good to me, but someone else must approve
  Dmaza: Looks good to me, but someone else must approve
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified




-- 
To view, visit https://gerrit.wikimedia.org/r/383970
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I977d3498b2084a426e2ab4d85c000d1b9dcfe824
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/vendor
Gerrit-Branch: master
Gerrit-Owner: Dbarratt 
Gerrit-Reviewer: BryanDavis 
Gerrit-Reviewer: Dbarratt 
Gerrit-Reviewer: Dmaza 
Gerrit-Reviewer: Huji 
Gerrit-Reviewer: Kaldari 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: MaxSem 
Gerrit-Reviewer: Reedy 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...TopLists[master]: Add missing qqq message documentation

2017-10-21 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/385417 )

Change subject: Add missing qqq message documentation
..


Add missing qqq message documentation

Change-Id: I8a988eddeae41afa08cfc4c44aecc9f2acc45956
---
M i18n/qqq.json
1 file changed, 56 insertions(+), 6 deletions(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/i18n/qqq.json b/i18n/qqq.json
index 5772cc2..0681558 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -2,26 +2,76 @@
"@metadata": {
"authors": []
},
-   "toplists-desc": "{{desc}}",
+   "toplists-desc": 
"{{desc|name=TopLists|url=https://www.mediawiki.org/wiki/Extension:TopLists}};,
"right-toplists-create-edit-list": 
"{{doc-right|toplists-create-edit-list}}",
"right-toplists-create-item": "{{doc-right|toplists-create-item}}",
"right-toplists-edit-item": "{{doc-right|toplists-edit-item}}",
"right-toplists-delete-item": "{{doc-right|toplists-delete-item}}",
+   "createtoplist": "{{doc-special}}",
+   "edittoplist": "{{doc-special}}",
"toplists-category": "The name for the category that lists all the Top 
10 Lists on a wiki",
+   "toplists-error-invalid-title": "An error message",
+   "toplists-error-invalid-picture": "An error message",
+   "toplists-error-title-exists": "An error message",
+   "toplists-error-title-spam": "An error message",
+   "toplists-error-article-blocked": "An error message",
+   "toplists-error-article-not-exists": "An error message",
+   "toplists-error-picture-not-exists": "An error message",
+   "toplists-error-duplicated-entry": "An error message",
+   "toplists-error-empty-item-name": "An error message",
+   "toplists-item-cannot-delete": "An error message",
+   "toplists-error-image-already-exists": "An error message",
+   "toplists-error-add-item-anon": "An error message",
+   "toplists-error-add-item-permission": "An error message",
+   "toplists-error-add-item-list-not-exists": "An error message",
+   "toplists-upload-error-unknown": "An error occurred while processing 
the upload request. Please try again.",
"action-toplists-create-edit-list": 
"{{doc-action|toplists-create-edit}}",
-   "toplists-editor-remove-item-tooltip": "{{Identical|Remove item}}",
-   "toplists-create-button": "{{Identical|Create list}}",
-   "toplists-cancel-button": "{{Identical|Cancel}}",
-   "toplists-image-browser-selected-picture": "$1 is the title of the 
image page.",
-   "toplists-image-browser-upload-btn": "{{Identical|Choose}}",
+   "toplists-editor-title-label": "A label message",
+   "toplists-editor-title-placeholder": "A placeholder text",
+   "toplists-editor-related-article-label": "A label message",
+   "toplists-editor-related-article-placeholder": "A placeholder text",
+   "toplists-editor-description-label": "A label message",
+   "toplists-editor-description-placeholder": "A placeholder text",
+   "toplists-editor-image-browser-tooltip": "A tooltip message",
+   "toplists-editor-remove-item-tooltip": "A tooltip 
message\n{{Identical|Remove item}}",
+   "toplists-editor-drag-item-tooltip": "A tooltip message",
+   "toplists-editor-add-item-label": "A tooltip message",
+   "toplists-editor-add-item-tooltip": "A tooltip message",
+   "toplists-create-button": "A button text\n{{Identical|Create list}}",
+   "toplists-update-button": "A button text",
+   "toplists-cancel-button": "A button text\n{{Identical|Cancel}}",
+   "toplists-items-removed": "A status message",
+   "toplists-items-created": "A status message",
+   "toplists-items-updated": "A status message",
+   "toplists-items-nochange": "A status message",
+   "toplists-image-browser-no-picture-selected": "A tooltip message",
+   "toplists-image-browser-clear-picture": "A tooltip message",
+   "toplists-image-browser-selected-picture": "A tooltip message",
+   "toplists-image-browser-upload-btn": "A button 
text\n{{Identical|Choose}}",
+   "toplists-image-browser-upload-label": "A label text",
+   "toplists-list-creation-summary": "Used as edit summary",
+   "toplists-list-update-summary": "Used as edit summary",
+   "toplists-item-creation-summary": "Used as edit summary",
+   "toplists-item-update-summary": "Used as edit summary",
+   "toplists-item-remove-summary": "Used as edit summary",
+   "toplists-item-restored": "A undelete reason",
+   "toplists-list-related-to": "A label",
"toplists-list-votes-num": "{{Identical|Vote}}",
"toplists-list-created-by": "{{Identical|By}}",
"toplists-list-vote-up": "Keep this as short as possible. Everything 
exceeding allowed lenght will be cutted out!",
+   "toplists-list-hotitem-count": "A hint

[MediaWiki-commits] [Gerrit] mediawiki...Video[master]: Add missing qqq message documentation

2017-10-21 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/385397 )

Change subject: Add missing qqq message documentation
..


Add missing qqq message documentation

Change-Id: I28bd4497f787bb776efc52c8a9ce2d2276fe260b
---
M i18n/qqq.json
1 file changed, 33 insertions(+), 1 deletion(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/i18n/qqq.json b/i18n/qqq.json
index c161f6c..91dfa03 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -5,11 +5,43 @@
]
},
"video-desc": 
"{{desc|name=Video|url=https://www.mediawiki.org/wiki/Extension:Video}};,
+   "addvideo": "{{doc-special}}",
+   "newvideos": "{{doc-special}}",
"video-upload-new-version": "Like 
[[MediaWiki:Uploadnewversion-linktext]], but \"file\" changed to \"video\".",
"video-newvideos-showfrom": "Like [[MediaWiki:Sp-newimages-showfrom]], 
but \"file\" changed to \"video\".",
"video-newvideos-list-text": "Like [[MediaWiki:Imagelisttext]], but 
\"file\" changed to \"video\".",
"video-addvideo-watchlist": "Like [[MediaWiki:Watchthisupload]], just 
reworded for clarity and \"file\" changed to \"video\".",
+   "video-addvideo-title": "Used as title for a legend",
+   "video-addvideo-dest": "Used as subtitle",
+   "video-addvideo-button": "A button text",
+   "video-provider-list": "{{ignore}}",
+   "video-addvideo-instructions": "A description",
+   "video-addvideo-invalidcode": "Error message",
+   "video-addvideo-exists": "Error message",
+   "video-addvideo-title-label": "A label",
+   "video-addvideo-embed-label": "A label",
+   "video-no-videos": "Used as hint on [[Special:NewVideos]]",
+   "log-name-video": "Used for the logging system on [[Special:Log]]",
+   "log-description-video": "{{doc-logpage}}",
+   "logentry-video-add": "Used for the logging system on [[Special:Log]]",
+   "logentry-video-update": "Used for the logging system on 
[[Special:Log]]",
+   "category-video-header": "Used on category pages",
+   "category-video-count": "Used on category pages",
+   "video-novideo-linktext": "Linktext used in error message 
{{msg-mw|video-novideo}}",
+   "video-novideo": "Error message when no video was found\n*$1 - 
{{msg-mw|video-novideo-linktext}}",
+   "video-embed": "A label",
+   "video-history": "A header",
+   "video-revert": "Used as link text",
+   "video-histlegend": "A legend",
+   "video-revert-success": "Success message after revert of a video",
"video-revert-legend": "Legend of the fieldset for the revert form",
"video-revert-intro": "Message displayed when you try to revert a 
version of a video.\n* $1 is the name of the media\n* $2 is a date\n* $3 is a 
hour\n* $4 is a URL and must follow square bracket: [$4\n{{Identical|Revert}}",
-   "video-showhidebots": "This is shown on the special page 
[[Special:NewVideos]]. The format is 
\"{{int:video-showhidebots|[[MediaWiki:Hide/{{SUBPAGENAME}}|{{int:hide}}]]}}\" 
or 
\"{{int:showhidebots|[[MediaWiki:Show/{{SUBPAGENAME}}|{{int:show}}]]}}\"\n\n{{Identical|$1
 bots}}"
+   "video-category-name": "Name of a category",
+   "video-links": "Used as header",
+   "video-links-to-video": "Used as label for a list",
+   "video-no-links-to-video": "Used as hint for a empty list",
+   "video-more-links-to-video": "Used as label to show more results",
+   "video-showhidebots": "This is shown on the special page 
[[Special:NewVideos]]. The format is 
\"{{int:video-showhidebots|[[MediaWiki:Hide/{{SUBPAGENAME}}|{{int:hide}}]]}}\" 
or 
\"{{int:showhidebots|[[MediaWiki:Show/{{SUBPAGENAME}}|{{int:show}}]]}}\"\n\n{{Identical|$1
 bots}}",
+   "action-addvideo": "{{doc-action|addvideo}}",
+   "right-addvideo": "{{doc-right|addvideo}}"
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/385397
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I28bd4497f787bb776efc52c8a9ce2d2276fe260b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Video
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: Nikerabbit 
Gerrit-Reviewer: Raimond Spekking 
Gerrit-Reviewer: Siebrand 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Contest[master]: Add missing qqq message documentation

2017-10-21 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/385430 )

Change subject: Add missing qqq message documentation
..


Add missing qqq message documentation

Activate banana checker

Change-Id: I506c8916c610483b8ff728e959773692f8f64132
---
M Gruntfile.js
M i18n/qqq.json
M package.json
3 files changed, 60 insertions(+), 6 deletions(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/Gruntfile.js b/Gruntfile.js
index b60f79e..98b1cfd 100644
--- a/Gruntfile.js
+++ b/Gruntfile.js
@@ -2,7 +2,7 @@
 module.exports = function ( grunt ) {
grunt.loadNpmTasks( 'grunt-contrib-jshint' );
grunt.loadNpmTasks( 'grunt-jsonlint' );
-   // grunt.loadNpmTasks( 'grunt-banana-checker' );
+   grunt.loadNpmTasks( 'grunt-banana-checker' );
 
grunt.initConfig( {
jshint: {
@@ -12,21 +12,23 @@
all: [
'**/*.js',
'!node_modules/**',
+   '!vendor/**',
'!resources/jquery.ui.timepicker.js',
'!resources/fancybox/**'
]
},
-   /* banana: {
+   banana: {
all: 'i18n/'
-   }, */
+   },
jsonlint: {
all: [
'**/*.json',
-   '!node_modules/**'
+   '!node_modules/**',
+   '!vendor/**'
]
}
} );
 
-   grunt.registerTask( 'test', [ 'jshint', 'jsonlint' /* 'banana' */ ] );
+   grunt.registerTask( 'test', [ 'jshint', 'jsonlint', 'banana' ] );
grunt.registerTask( 'default', 'test' );
 };
diff --git a/i18n/qqq.json b/i18n/qqq.json
index 7bf36e2..b9d9a96 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -14,7 +14,8 @@
"Umherirrender"
]
},
-   "contest-desc": "{{desc}}",
+   "contest-desc": 
"{{desc|name=Contest|url=https://www.mediawiki.org/wiki/Extension:Contest}};,
+   "contest-toplink": "A label",
"right-contestadmin": "{{doc-right|contestadmin}}",
"right-contestant": "{{doc-right|contestant}}",
"right-contestjudge": "{{doc-right|contestjudge}}",
@@ -36,21 +37,38 @@
"group-contestant.js": "{{doc-group|contestant|js}}",
"group-contestjudge.css": "{{doc-group|contestjudge|css}}",
"group-contestjudge.js": "{{doc-group|contestjudge|js}}",
+   "prefs-contest": "A preference label",
+   "contest-prefs-showtoplink": "A label message",
"contest-status-draft": "Describes the status of the contest.",
"contest-status-active": "Describes the status of the contest.",
"contest-status-expired": "Describes the status of the contest.",
"contest-status-finished": "Describes the status of the contest.",
+   "special-contest": "A page header",
"special-contests": "A page header 
([[:File:Contest-contests.png|screenshot]])",
+   "special-contestsignup": "A page header",
+   "special-contestwelcome": "A page header",
"special-editcontest": "Page header 
([[:File:Contest-editcontest.png|screenshot]])",
+   "special-mycontests": "A page header",
+   "specialpages-group-contest": "{{doc-special-group}}",
+   "contest-nav-contests": "A navigation link label",
"contest-nav-editcontest": "A navigation link label 
([[:File:Contest-contestant-judging.png|screenshot]])",
+   "contest-nav-contest": "A navigation link label",
+   "contest-nav-contestwelcome": "A navigation link label",
+   "contest-nav-contestsignup": "A navigation link label",
"contest-special-addnew": "A form header 
([[:File:Contest-contests.png|screenshot]])",
+   "contest-special-namedoc": "A description",
+   "contest-special-newname": "A label text",
"contest-special-add": "A button text 
([[:File:Contest-contests.png|screenshot]])",
+   "contest-special-existing": "A header",
"contest-special-name": "Table column header.\n{{Identical|Name}}",
"contest-special-status": "Table column header.\n{{Identical|Status}}",
"contest-special-submissioncount": "Table column header",
"contest-special-edit": "Table column header.\n{{Identical|Edit}}",
"contest-special-delete": "Table column header.\n{{Identical|Delete}}",
+   "contest-special-confirm-delete": "Used as confirm message\nUsed with 
javascript",
+   "contest-special-delete-failed": "Used as confirm message\nUsed with 
javascript",
"editcontest-text": "Short text displayed at the top of the page 
notifying the user they are editing a contest",
+   "editcontest-legend": "A

[MediaWiki-commits] [Gerrit] mediawiki...SimpleChanges[master]: Remove unused i18n shim

2017-10-21 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/385241 )

Change subject: Remove unused i18n shim
..


Remove unused i18n shim

Change-Id: Id639fd00031ba80ea59466ba9fac90d2fef7ee76
---
D SimpleChanges.i18n.php
1 file changed, 0 insertions(+), 35 deletions(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/SimpleChanges.i18n.php b/SimpleChanges.i18n.php
deleted file mode 100644
index c4c7e50..000
--- a/SimpleChanges.i18n.php
+++ /dev/null
@@ -1,35 +0,0 @@
-https://git.wikimedia.org/blob/mediawiki%2Fcore.git/HEAD/maintenance%2FgenerateJsonI18n.php
- *
- * Beginning with MediaWiki 1.23, translation strings are stored in json files,
- * and the EXTENSION.i18n.php file only exists to provide compatibility with
- * older releases of MediaWiki. For more information about this migration, see:
- * https://www.mediawiki.org/wiki/Requests_for_comment/Localisation_format
- *
- * This shim maintains compatibility back to MediaWiki 1.17.
- */
-$messages = array();
-if ( !function_exists( 'wfJsonI18nShimcf75270484933c9b' ) ) {
-   function wfJsonI18nShimcf75270484933c9b( $cache, $code, &$cachedData ) {
-   $codeSequence = array_merge( array( $code ), 
$cachedData['fallbackSequence'] );
-   foreach ( $codeSequence as $csCode ) {
-   $fileName = dirname( __FILE__ ) . "/i18n/$csCode.json";
-   if ( is_readable( $fileName ) ) {
-   $data = FormatJson::decode( file_get_contents( 
$fileName ), true );
-   foreach ( array_keys( $data ) as $key ) {
-   if ( $key === '' || $key[0] === '@' ) {
-   unset( $data[$key] );
-   }
-   }
-   $cachedData['messages'] = array_merge( $data, 
$cachedData['messages'] );
-   }
-
-   $cachedData['deps'][] = new FileDependency( $fileName );
-   }
-   return true;
-   }
-
-   $GLOBALS['wgHooks']['LocalisationCacheRecache'][] = 
'wfJsonI18nShimcf75270484933c9b';
-}

-- 
To view, visit https://gerrit.wikimedia.org/r/385241
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id639fd00031ba80ea59466ba9fac90d2fef7ee76
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SimpleChanges
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: Siebrand 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Equivset[master]: Fix indentation of COPYING

2017-10-21 Thread Legoktm (Code Review)

Legoktm has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/385823 )

Change subject: Fix indentation of COPYING
..

Fix indentation of COPYING

Synced with .

Change-Id: If45adcec47be034b35ad115ef80b46db75c182c9
---
M COPYING
1 file changed, 86 insertions(+), 86 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/libs/Equivset 
refs/changes/23/385823/1

diff --git a/COPYING b/COPYING
index 35faf3a..d159169 100644
--- a/COPYING
+++ b/COPYING
@@ -1,14 +1,14 @@
-GNU GENERAL PUBLIC LICENSE
-Version 2, June 1991
+GNU GENERAL PUBLIC LICENSE
+   Version 2, June 1991
 
-Copyright (C) 1989, 1991 Free Software Foundation, Inc.,
-51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
-Everyone is permitted to copy and distribute verbatim copies
-of this license document, but changing it is not allowed.
+ Copyright (C) 1989, 1991 Free Software Foundation, Inc.,
+ 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
+ Everyone is permitted to copy and distribute verbatim copies
+ of this license document, but changing it is not allowed.
 
-   Preamble
+Preamble
 
-The licenses for most software are designed to take away your
+  The licenses for most software are designed to take away your
 freedom to share and change it.  By contrast, the GNU General Public
 License is intended to guarantee your freedom to share and change free
 software--to make sure the software is free for all its users.  This
@@ -18,48 +18,48 @@
 the GNU Lesser General Public License instead.)  You can apply it to
 your programs, too.
 
-When we speak of free software, we are referring to freedom, not
+  When we speak of free software, we are referring to freedom, not
 price.  Our General Public Licenses are designed to make sure that you
 have the freedom to distribute copies of free software (and charge for
 this service if you wish), that you receive source code or can get it
 if you want it, that you can change the software or use pieces of it
 in new free programs; and that you know you can do these things.
 
-To protect your rights, we need to make restrictions that forbid
+  To protect your rights, we need to make restrictions that forbid
 anyone to deny you these rights or to ask you to surrender the rights.
 These restrictions translate to certain responsibilities for you if you
 distribute copies of the software, or if you modify it.
 
-For example, if you distribute copies of such a program, whether
+  For example, if you distribute copies of such a program, whether
 gratis or for a fee, you must give the recipients all the rights that
 you have.  You must make sure that they, too, receive or can get the
 source code.  And you must show them these terms so they know their
 rights.
 
-We protect your rights with two steps: (1) copyright the software, and
+  We protect your rights with two steps: (1) copyright the software, and
 (2) offer you this license which gives you legal permission to copy,
 distribute and/or modify the software.
 
-Also, for each author's protection and ours, we want to make certain
+  Also, for each author's protection and ours, we want to make certain
 that everyone understands that there is no warranty for this free
 software.  If the software is modified by someone else and passed on, we
 want its recipients to know that what they have is not the original, so
 that any problems introduced by others will not reflect on the original
 authors' reputations.
 
-Finally, any free program is threatened constantly by software
+  Finally, any free program is threatened constantly by software
 patents.  We wish to avoid the danger that redistributors of a free
 program will individually obtain patent licenses, in effect making the
 program proprietary.  To prevent this, we have made it clear that any
 patent must be licensed for everyone's free use or not licensed at all.
 
-The precise terms and conditions for copying, distribution and
+  The precise terms and conditions for copying, distribution and
 modification follow.
 
-GNU GENERAL PUBLIC LICENSE
-TERMS AND CONDITIONS FOR COPYING, DISTRIBUTION AND MODIFICATION
+GNU GENERAL PUBLIC LICENSE
+   TERMS AND CONDITIONS FOR COPYING, DISTRIBUTION AND MODIFICATION
 
-0. This License applies to any program or other work which contains
+  0. This License applies to any program or other work which contains
 a notice placed by the copyright holder saying it may be distributed
 under the terms of this General Public License.  The "Program", below,
 refers to any such program or work, and a "work based on the Program"
@@ -76,7 +76,7 @@
 Program (independent of having been made by running the Program).
 Whether that is true depends on what the Program does.
 
-1. You may copy and distribute verbatim

[MediaWiki-commits] [Gerrit] mediawiki...Equivset[master]: Move phpunit.xml to phpunit.xml.dist

2017-10-21 Thread Legoktm (Code Review)

Legoktm has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/385822 )

Change subject: Move phpunit.xml to phpunit.xml.dist
..

Move phpunit.xml to phpunit.xml.dist

To match other libraries and .gitattributes

Change-Id: Ie4d216bcc51a642b4dab6b3d686214509ff1d337
---
R phpunit.xml.dist
1 file changed, 0 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/libs/Equivset 
refs/changes/22/385822/1

diff --git a/phpunit.xml b/phpunit.xml.dist
similarity index 100%
rename from phpunit.xml
rename to phpunit.xml.dist

-- 
To view, visit https://gerrit.wikimedia.org/r/385822
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie4d216bcc51a642b4dab6b3d686214509ff1d337
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/libs/Equivset
Gerrit-Branch: master
Gerrit-Owner: Legoktm 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...AbuseFilter[REL1_30]: Restore accidentally deleted code

2017-10-21 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/385821 )

Change subject: Restore accidentally deleted code
..


Restore accidentally deleted code

I have noticed I accidentally dropped this code during
Iec237b288 (apologize!).

Change-Id: Ifbd53575ddf8dd1014de19afea395d0eb537c6ee
(cherry picked from commit 5839b7c412fb18f1f3ac00959e6b940f55148780)
---
M includes/AbuseFilter.hooks.php
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/AbuseFilter.hooks.php b/includes/AbuseFilter.hooks.php
index 93fe208..9ad8e07 100644
--- a/includes/AbuseFilter.hooks.php
+++ b/includes/AbuseFilter.hooks.php
@@ -677,6 +677,9 @@
 
if ( $user && !$updater->updateRowExists( 'create 
abusefilter-blocker-user' ) ) {
$user = User::newSystemUser( $username, [ 'steal' => 
true ] );
+   $updater->insertUpdateRow( 'create 
abusefilter-blocker-user' );
+   # Promote user so it doesn't look too crazy.
+   $user->addGroup( 'sysop' );
}
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/385821
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifbd53575ddf8dd1014de19afea395d0eb537c6ee
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/AbuseFilter
Gerrit-Branch: REL1_30
Gerrit-Owner: Legoktm 
Gerrit-Reviewer: Jackmcbarn 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: Matěj Suchánek 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...AbuseFilter[REL1_30]: Restore accidentally deleted code

2017-10-21 Thread Legoktm (Code Review)

Legoktm has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/385821 )

Change subject: Restore accidentally deleted code
..

Restore accidentally deleted code

I have noticed I accidentally dropped this code during
Iec237b288 (apologize!).

Change-Id: Ifbd53575ddf8dd1014de19afea395d0eb537c6ee
(cherry picked from commit 5839b7c412fb18f1f3ac00959e6b940f55148780)
---
M includes/AbuseFilter.hooks.php
1 file changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/AbuseFilter 
refs/changes/21/385821/1

diff --git a/includes/AbuseFilter.hooks.php b/includes/AbuseFilter.hooks.php
index 93fe208..9ad8e07 100644
--- a/includes/AbuseFilter.hooks.php
+++ b/includes/AbuseFilter.hooks.php
@@ -677,6 +677,9 @@
 
if ( $user && !$updater->updateRowExists( 'create 
abusefilter-blocker-user' ) ) {
$user = User::newSystemUser( $username, [ 'steal' => 
true ] );
+   $updater->insertUpdateRow( 'create 
abusefilter-blocker-user' );
+   # Promote user so it doesn't look too crazy.
+   $user->addGroup( 'sysop' );
}
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/385821
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifbd53575ddf8dd1014de19afea395d0eb537c6ee
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/AbuseFilter
Gerrit-Branch: REL1_30
Gerrit-Owner: Legoktm 
Gerrit-Reviewer: Matěj Suchánek 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...AbuseFilter[master]: Restore accidentally deleted code

2017-10-21 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/385769 )

Change subject: Restore accidentally deleted code
..


Restore accidentally deleted code

I have noticed I accidentally dropped this code during
Iec237b288 (apologize!).

Change-Id: Ifbd53575ddf8dd1014de19afea395d0eb537c6ee
---
M includes/AbuseFilter.hooks.php
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Huji: Looks good to me, but someone else must approve
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/AbuseFilter.hooks.php b/includes/AbuseFilter.hooks.php
index 8c5de14..2641de6 100644
--- a/includes/AbuseFilter.hooks.php
+++ b/includes/AbuseFilter.hooks.php
@@ -676,6 +676,9 @@
 
if ( $user && !$updater->updateRowExists( 'create 
abusefilter-blocker-user' ) ) {
$user = User::newSystemUser( $username, [ 'steal' => 
true ] );
+   $updater->insertUpdateRow( 'create 
abusefilter-blocker-user' );
+   # Promote user so it doesn't look too crazy.
+   $user->addGroup( 'sysop' );
}
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/385769
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifbd53575ddf8dd1014de19afea395d0eb537c6ee
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/AbuseFilter
Gerrit-Branch: master
Gerrit-Owner: Matěj Suchánek 
Gerrit-Reviewer: Bartosz Dziewoński 
Gerrit-Reviewer: Huji 
Gerrit-Reviewer: Jackmcbarn 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...AbuseFilter[master]: Pass LinkRenderer instance to AbuseFilter::addNavigationLinks

2017-10-21 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/372792 )

Change subject: Pass LinkRenderer instance to AbuseFilter::addNavigationLinks
..


Pass LinkRenderer instance to AbuseFilter::addNavigationLinks

Change-Id: I1de60955344d06e5b55f4d2cfdfa8f2d13df831a
---
M includes/AbuseFilter.class.php
M includes/special/SpecialAbuseFilter.php
M includes/special/SpecialAbuseLog.php
3 files changed, 11 insertions(+), 4 deletions(-)

Approvals:
  Huji: Looks good to me, but someone else must approve
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/AbuseFilter.class.php b/includes/AbuseFilter.class.php
index 4b1418f..5dc4870 100644
--- a/includes/AbuseFilter.class.php
+++ b/includes/AbuseFilter.class.php
@@ -1,5 +1,6 @@
  'Special:AbuseFilter',
'recentchanges' => 'Special:AbuseFilter/history',
@@ -175,7 +181,6 @@
];
 
$links = [];
-   $linkRenderer = 
MediaWikiServices::getInstance()->getLinkRenderer();
 
foreach ( $linkDefs as $name => $page ) {
// Give grep a chance to find the usages:
diff --git a/includes/special/SpecialAbuseFilter.php 
b/includes/special/SpecialAbuseFilter.php
index 04d5819..c419410 100644
--- a/includes/special/SpecialAbuseFilter.php
+++ b/includes/special/SpecialAbuseFilter.php
@@ -108,7 +108,8 @@
}
 
// Links at the top
-   AbuseFilter::addNavigationLinks( $this->getContext(), $pageType 
);
+   AbuseFilter::addNavigationLinks(
+   $this->getContext(), $pageType, 
$this->getLinkRenderer() );
 
/** @var AbuseFilterView $v */
$v = new $view( $this, $params );
diff --git a/includes/special/SpecialAbuseLog.php 
b/includes/special/SpecialAbuseLog.php
index bac89fe..617262d 100644
--- a/includes/special/SpecialAbuseLog.php
+++ b/includes/special/SpecialAbuseLog.php
@@ -29,7 +29,8 @@
$out = $this->getOutput();
$request = $this->getRequest();
 
-   AbuseFilter::addNavigationLinks( $this->getContext(), 'log' );
+   AbuseFilter::addNavigationLinks(
+   $this->getContext(), 'log', $this->getLinkRenderer() );
 
$this->setHeaders();
$this->outputHeader( 'abusefilter-log-summary' );

-- 
To view, visit https://gerrit.wikimedia.org/r/372792
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1de60955344d06e5b55f4d2cfdfa8f2d13df831a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/AbuseFilter
Gerrit-Branch: master
Gerrit-Owner: Matěj Suchánek 
Gerrit-Reviewer: Bartosz Dziewoński 
Gerrit-Reviewer: Huji 
Gerrit-Reviewer: Jackmcbarn 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...AbuseFilter[master]: Normalize IPv6 addresses in Special:AbuseFilter/test

2017-10-21 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/379235 )

Change subject: Normalize IPv6 addresses in Special:AbuseFilter/test
..


Normalize IPv6 addresses in Special:AbuseFilter/test

Forcing user namespace will handle IPv6 correctly as well
as possible "User:" prefix supported by the former code.

Bug: T176045
Change-Id: I0b4a5468ca44799cade0b0774d749e05d4ff5865
---
M includes/Views/AbuseFilterViewTestBatch.php
1 file changed, 2 insertions(+), 10 deletions(-)

Approvals:
  Huji: Looks good to me, but someone else must approve
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/Views/AbuseFilterViewTestBatch.php 
b/includes/Views/AbuseFilterViewTestBatch.php
index abc33fc..e039c61 100644
--- a/includes/Views/AbuseFilterViewTestBatch.php
+++ b/includes/Views/AbuseFilterViewTestBatch.php
@@ -176,15 +176,7 @@
}
 
// Normalise username
-   $userTitle = Title::newFromText( $testUsername );
-
-   if ( $userTitle && $userTitle->getNamespace() == NS_USER ) {
-   $this->mTestUser = $userTitle->getText(); // Allow 
User:Blah syntax.
-   } elseif ( $userTitle ) {
-   // Not sure of the value of prefixedText over text, but 
no need to munge unnecessarily.
-   $this->mTestUser = $userTitle->getPrefixedText();
-   } else {
-   $this->mTestUser = null; // No user specified.
-   }
+   $userTitle = Title::newFromText( $testUsername, NS_USER );
+   $this->mTestUser = $userTitle ? $userTitle->getText() : null;
}
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/379235
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0b4a5468ca44799cade0b0774d749e05d4ff5865
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/AbuseFilter
Gerrit-Branch: master
Gerrit-Owner: Matěj Suchánek 
Gerrit-Reviewer: Bartosz Dziewoński 
Gerrit-Reviewer: Huji 
Gerrit-Reviewer: Jackmcbarn 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: Matěj Suchánek 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...FileImporter[master]: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0

2017-10-21 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/385779 )

Change subject: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
..


build: Updating mediawiki/mediawiki-codesniffer to 14.1.0

And moved phpcs.xml to .phpcs.xml (T177256).

Change-Id: I74c3c70441fefb849e2457559e132cd9d6aeb4bc
---
R .phpcs.xml
M composer.json
2 files changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/phpcs.xml b/.phpcs.xml
similarity index 100%
rename from phpcs.xml
rename to .phpcs.xml
diff --git a/composer.json b/composer.json
index c5ef5fc..f31d942 100644
--- a/composer.json
+++ b/composer.json
@@ -1,7 +1,7 @@
 {
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
-   "mediawiki/mediawiki-codesniffer": "13.0.0",
+   "mediawiki/mediawiki-codesniffer": "14.1.0",
"jakub-onderka/php-console-highlighter": "0.3.2"
},
"scripts": {

-- 
To view, visit https://gerrit.wikimedia.org/r/385779
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I74c3c70441fefb849e2457559e132cd9d6aeb4bc
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/FileImporter
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 
Gerrit-Reviewer: Addshore 
Gerrit-Reviewer: Andrew-WMDE 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: Tobias Gritschacher 
Gerrit-Reviewer: Umherirrender 
Gerrit-Reviewer: WMDE-Fisch 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...FileImporter[master]: Don't use deprecated OOUI MediaWiki theme class

2017-10-21 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/385819 )

Change subject: Don't use deprecated OOUI MediaWiki theme class
..


Don't use deprecated OOUI MediaWiki theme class

It was removed in e355040db.

Change-Id: Ibc02e67d4a6d64ca0a91e29e82afb0c0728163a4
---
M tests/phpunit/Html/ChangeFileInfoFormTest.php
M tests/phpunit/Html/ChangeFileNameFormTest.php
2 files changed, 4 insertions(+), 4 deletions(-)

Approvals:
  jenkins-bot: Verified
  VolkerE: Looks good to me, approved



diff --git a/tests/phpunit/Html/ChangeFileInfoFormTest.php 
b/tests/phpunit/Html/ChangeFileInfoFormTest.php
index 105bba5..38436c7 100644
--- a/tests/phpunit/Html/ChangeFileInfoFormTest.php
+++ b/tests/phpunit/Html/ChangeFileInfoFormTest.php
@@ -9,8 +9,8 @@
 use FileImporter\Data\TextRevision;
 use FileImporter\Data\TextRevisions;
 use FileImporter\Html\ChangeFileNameForm;
-use OOUI\MediaWikiTheme;
 use OOUI\Theme;
+use OOUI\WikimediaUITheme;
 use PHPUnit_Framework_TestCase;
 use SpecialPage;
 use Title;
@@ -19,7 +19,7 @@
 
public function setUp() {
parent::setUp();
-   Theme::setSingleton( new MediaWikiTheme );
+   Theme::setSingleton( new WikimediaUITheme() );
}
 
private function getMockSpecialPage() {
diff --git a/tests/phpunit/Html/ChangeFileNameFormTest.php 
b/tests/phpunit/Html/ChangeFileNameFormTest.php
index df3c7c4..cffbff0 100644
--- a/tests/phpunit/Html/ChangeFileNameFormTest.php
+++ b/tests/phpunit/Html/ChangeFileNameFormTest.php
@@ -9,8 +9,8 @@
 use FileImporter\Data\TextRevision;
 use FileImporter\Data\TextRevisions;
 use FileImporter\Html\ChangeFileNameForm;
-use OOUI\MediaWikiTheme;
 use OOUI\Theme;
+use OOUI\WikimediaUITheme;
 use PHPUnit_Framework_TestCase;
 use SpecialPage;
 use Title;
@@ -19,7 +19,7 @@
 
public function setUp() {
parent::setUp();
-   Theme::setSingleton( new MediaWikiTheme );
+   Theme::setSingleton( new WikimediaUITheme() );
}
 
private function getMockSpecialPage() {

-- 
To view, visit https://gerrit.wikimedia.org/r/385819
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibc02e67d4a6d64ca0a91e29e82afb0c0728163a4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/FileImporter
Gerrit-Branch: master
Gerrit-Owner: Legoktm 
Gerrit-Reviewer: Addshore 
Gerrit-Reviewer: Andrew-WMDE 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: Tobias Gritschacher 
Gerrit-Reviewer: VolkerE 
Gerrit-Reviewer: WMDE-Fisch 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseLexeme[master]: Don't use deprecated OOUI MediaWiki theme class

2017-10-21 Thread Legoktm (Code Review)

Legoktm has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/385820 )

Change subject: Don't use deprecated OOUI MediaWiki theme class
..

Don't use deprecated OOUI MediaWiki theme class

It was removed in e355040db.

Change-Id: Ibc02e67d4a6d64ca0a91e29e82afb0c0728163a4
---
M tests/phpunit/mediawiki/Specials/HTMLForm/ItemSelectorWidgetFieldTest.php
M tests/phpunit/mediawiki/Specials/HTMLForm/ItemSelectorWidgetTest.php
2 files changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikibaseLexeme 
refs/changes/20/385820/1

diff --git 
a/tests/phpunit/mediawiki/Specials/HTMLForm/ItemSelectorWidgetFieldTest.php 
b/tests/phpunit/mediawiki/Specials/HTMLForm/ItemSelectorWidgetFieldTest.php
index e6a83b3..59da6f3 100644
--- a/tests/phpunit/mediawiki/Specials/HTMLForm/ItemSelectorWidgetFieldTest.php
+++ b/tests/phpunit/mediawiki/Specials/HTMLForm/ItemSelectorWidgetFieldTest.php
@@ -2,8 +2,8 @@
 
 namespace Wikibase\Lexeme\Tests\MediaWiki\Specials\HTMLForm;
 
-use OOUI\MediaWikiTheme;
 use OOUI\Theme;
+use OOUI\WikimediaUITheme;
 use ReflectionClass;
 use Wikibase\DataModel\Entity\ItemIdParser;
 use Wikibase\DataModel\Services\Lookup\LabelDescriptionLookup;
@@ -20,7 +20,7 @@
 
public function setUp() {
parent::setUp();
-   Theme::setSingleton( new MediaWikiTheme() );
+   Theme::setSingleton( new WikimediaUITheme() );
}
 
public function tearDown() {
diff --git 
a/tests/phpunit/mediawiki/Specials/HTMLForm/ItemSelectorWidgetTest.php 
b/tests/phpunit/mediawiki/Specials/HTMLForm/ItemSelectorWidgetTest.php
index 84fbbc4..8f27fd8 100644
--- a/tests/phpunit/mediawiki/Specials/HTMLForm/ItemSelectorWidgetTest.php
+++ b/tests/phpunit/mediawiki/Specials/HTMLForm/ItemSelectorWidgetTest.php
@@ -2,8 +2,8 @@
 
 namespace Wikibase\Lexeme\Tests\MediaWiki\Specials\HTMLForm;
 
-use OOUI\MediaWikiTheme;
 use OOUI\Theme;
+use OOUI\WikimediaUITheme;
 use Wikibase\Lexeme\Specials\HTMLForm\ItemSelectorWidget;
 
 /**
@@ -15,7 +15,7 @@
 
public function setUp() {
parent::setUp();
-   Theme::setSingleton( new MediaWikiTheme() );
+   Theme::setSingleton( new WikimediaUITheme() );
}
 
public function tearDown() {

-- 
To view, visit https://gerrit.wikimedia.org/r/385820
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibc02e67d4a6d64ca0a91e29e82afb0c0728163a4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseLexeme
Gerrit-Branch: master
Gerrit-Owner: Legoktm 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...FileImporter[master]: Don't use deprecated OOUI MediaWiki theme class

2017-10-21 Thread Legoktm (Code Review)

Legoktm has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/385819 )

Change subject: Don't use deprecated OOUI MediaWiki theme class
..

Don't use deprecated OOUI MediaWiki theme class

It was removed in e355040db.

Change-Id: Ibc02e67d4a6d64ca0a91e29e82afb0c0728163a4
---
M tests/phpunit/Html/ChangeFileInfoFormTest.php
M tests/phpunit/Html/ChangeFileNameFormTest.php
2 files changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/FileImporter 
refs/changes/19/385819/1

diff --git a/tests/phpunit/Html/ChangeFileInfoFormTest.php 
b/tests/phpunit/Html/ChangeFileInfoFormTest.php
index 105bba5..38436c7 100644
--- a/tests/phpunit/Html/ChangeFileInfoFormTest.php
+++ b/tests/phpunit/Html/ChangeFileInfoFormTest.php
@@ -9,8 +9,8 @@
 use FileImporter\Data\TextRevision;
 use FileImporter\Data\TextRevisions;
 use FileImporter\Html\ChangeFileNameForm;
-use OOUI\MediaWikiTheme;
 use OOUI\Theme;
+use OOUI\WikimediaUITheme;
 use PHPUnit_Framework_TestCase;
 use SpecialPage;
 use Title;
@@ -19,7 +19,7 @@
 
public function setUp() {
parent::setUp();
-   Theme::setSingleton( new MediaWikiTheme );
+   Theme::setSingleton( new WikimediaUITheme() );
}
 
private function getMockSpecialPage() {
diff --git a/tests/phpunit/Html/ChangeFileNameFormTest.php 
b/tests/phpunit/Html/ChangeFileNameFormTest.php
index df3c7c4..cffbff0 100644
--- a/tests/phpunit/Html/ChangeFileNameFormTest.php
+++ b/tests/phpunit/Html/ChangeFileNameFormTest.php
@@ -9,8 +9,8 @@
 use FileImporter\Data\TextRevision;
 use FileImporter\Data\TextRevisions;
 use FileImporter\Html\ChangeFileNameForm;
-use OOUI\MediaWikiTheme;
 use OOUI\Theme;
+use OOUI\WikimediaUITheme;
 use PHPUnit_Framework_TestCase;
 use SpecialPage;
 use Title;
@@ -19,7 +19,7 @@
 
public function setUp() {
parent::setUp();
-   Theme::setSingleton( new MediaWikiTheme );
+   Theme::setSingleton( new WikimediaUITheme() );
}
 
private function getMockSpecialPage() {

-- 
To view, visit https://gerrit.wikimedia.org/r/385819
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibc02e67d4a6d64ca0a91e29e82afb0c0728163a4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/FileImporter
Gerrit-Branch: master
Gerrit-Owner: Legoktm 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] pywikibot/core[master]: [doc] Fix options documentation

2017-10-21 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/385800 )

Change subject: [doc] Fix options documentation
..


[doc] Fix options documentation

Change-Id: I92164d19116b10e65596c3feb7d10e9f3b3f3e93
---
M scripts/maintenance/compat2core.py
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Dalba: Looks good to me, approved
  jenkins-bot: Verified
  Zoranzoki21: Looks good to me, but someone else must approve



diff --git a/scripts/maintenance/compat2core.py 
b/scripts/maintenance/compat2core.py
index 854d224..4e62b64 100755
--- a/scripts/maintenance/compat2core.py
+++ b/scripts/maintenance/compat2core.py
@@ -12,8 +12,8 @@
 The scripts asks for the .py file and converts it to
 -core.py in the same directory. The following option is supported:
 
-- warnonly: Do not convert the source but show warning messages. This is good
-to check already merged scripts.
+-warnonly  Do not convert the source but show warning messages. This is good
+   to check already merged scripts.
 
 usage
 

-- 
To view, visit https://gerrit.wikimedia.org/r/385800
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I92164d19116b10e65596c3feb7d10e9f3b3f3e93
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Xqt 
Gerrit-Reviewer: Dalba 
Gerrit-Reviewer: John Vandenberg 
Gerrit-Reviewer: Magul 
Gerrit-Reviewer: Zoranzoki21 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Set 'watchcreations' preference to true by default on Commons

2017-10-21 Thread GeoffreyT2000 (Code Review)

GeoffreyT2000 has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/385818 )

Change subject: Set 'watchcreations' preference to true by default on Commons
..

Set 'watchcreations' preference to true by default on Commons

This will set the 'watchcreations' preference to true by default on Commons. 
There is no reason why Commons should be any different.

Bug: T178750
Change-Id: Ieb2c16d58c43282f82dee27aeb2226fa73800402
---
M wmf-config/CommonSettings.php
1 file changed, 1 insertion(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/18/385818/1

diff --git a/wmf-config/CommonSettings.php b/wmf-config/CommonSettings.php
index d60dccb..836681c 100644
--- a/wmf-config/CommonSettings.php
+++ b/wmf-config/CommonSettings.php
@@ -2012,11 +2012,7 @@
 $wgDefaultUserOptions['thumbsize'] = $wmgThumbsizeIndex;
 $wgDefaultUserOptions['showhiddencats'] = $wmgShowHiddenCats;
 
-if ( $wgDBname === 'commonswiki' ) {
-   $wgDefaultUserOptions['watchcreations'] = 0;
-} else {
-   $wgDefaultUserOptions['watchcreations'] = 1;
-}
+$wgDefaultUserOptions['watchcreations'] = 1;
 
 // Temporary override: WMF is not hardcore enough to enable this.
 // See T37785, T38316, T47022 about it.

-- 
To view, visit https://gerrit.wikimedia.org/r/385818
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieb2c16d58c43282f82dee27aeb2226fa73800402
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: GeoffreyT2000 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...ORES[master]: Fix merge strategy in $wgOresDraftQualityNS

2017-10-21 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/385803 )

Change subject: Fix merge strategy in $wgOresDraftQualityNS
..


Fix merge strategy in $wgOresDraftQualityNS

Bug: T176183
Change-Id: Ifc10d8a8fe10d3675cc176f616f2804f7e392111
---
M extension.json
1 file changed, 4 insertions(+), 1 deletion(-)

Approvals:
  jenkins-bot: Verified
  Awight: Looks good to me, approved



diff --git a/extension.json b/extension.json
index d6b1f1e..00fe46a 100644
--- a/extension.json
+++ b/extension.json
@@ -183,7 +183,10 @@
"_merge_strategy": "array_plus_2d"
},
"OresEnabledNamespaces": {},
-   "OresDraftQualityNS": { "0": true },
+   "OresDraftQualityNS": {
+   "0": true,
+   "_merge_strategy": "array_plus"
+   },
"OresWikiId": null,
"@OresRevisionsPerBatch": "Number of revisions to fetch scores 
for from the ORES API per request when the MediaWiki API is asked to score 
revisions which are not cached. Set to 0 to disable fetching (scores will still 
be fetched for new edits).",
"OresRevisionsPerBatch": 30,

-- 
To view, visit https://gerrit.wikimedia.org/r/385803
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifc10d8a8fe10d3675cc176f616f2804f7e392111
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ORES
Gerrit-Branch: master
Gerrit-Owner: Ladsgroup 
Gerrit-Reviewer: Adamw 
Gerrit-Reviewer: Awight 
Gerrit-Reviewer: Kaldari 
Gerrit-Reviewer: Thiemo Mättig (WMDE) 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] labs...stewardbots[master]: Update composer.json to use MediaWiki CodeSniffer 14.1.0

2017-10-21 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/385816 )

Change subject: Update composer.json to use MediaWiki CodeSniffer 14.1.0
..


Update composer.json to use MediaWiki CodeSniffer 14.1.0

Change-Id: Ia731afff153b99071485d8765af33e2e59442de1
---
R .phpcs.xml
M composer.json
2 files changed, 1 insertion(+), 1 deletion(-)

Approvals:
  MarcoAurelio: Verified; Looks good to me, approved
  jenkins-bot: Verified



diff --git a/phpcs.xml b/.phpcs.xml
similarity index 100%
rename from phpcs.xml
rename to .phpcs.xml
diff --git a/composer.json b/composer.json
index 55009db..137703e 100644
--- a/composer.json
+++ b/composer.json
@@ -10,7 +10,7 @@
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
"jakub-onderka/php-console-highlighter": "0.3.2",
-   "mediawiki/mediawiki-codesniffer": "13.0.0"
+   "mediawiki/mediawiki-codesniffer": "14.1.0"
},
"scripts": {
"test": [

-- 
To view, visit https://gerrit.wikimedia.org/r/385816
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia731afff153b99071485d8765af33e2e59442de1
Gerrit-PatchSet: 2
Gerrit-Project: labs/tools/stewardbots
Gerrit-Branch: master
Gerrit-Owner: MarcoAurelio 
Gerrit-Reviewer: BryanDavis 
Gerrit-Reviewer: MarcoAurelio 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] integration/config[master]: Add tox-jessie tests for mediawiki/tools/cookiecutter-library

2017-10-21 Thread MarcoAurelio (Code Review)

MarcoAurelio has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/385817 )

Change subject: Add tox-jessie tests for mediawiki/tools/cookiecutter-library
..

Add tox-jessie tests for mediawiki/tools/cookiecutter-library

Bug: T178727
Change-Id: I7efe62b4e1f5c3b0b0b2d1b7ae3e42c4732b136d
---
0 files changed, 0 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/integration/config 
refs/changes/17/385817/1


-- 
To view, visit https://gerrit.wikimedia.org/r/385817
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7efe62b4e1f5c3b0b0b2d1b7ae3e42c4732b136d
Gerrit-PatchSet: 1
Gerrit-Project: integration/config
Gerrit-Branch: master
Gerrit-Owner: MarcoAurelio 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] labs...stewardbots[master]: Update composer.json to use MediaWiki CodeSniffer 14.1.0

2017-10-21 Thread MarcoAurelio (Code Review)

MarcoAurelio has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/385816 )

Change subject: Update composer.json to use MediaWiki CodeSniffer 14.1.0
..

Update composer.json to use MediaWiki CodeSniffer 14.1.0

Change-Id: Ia731afff153b99071485d8765af33e2e59442de1
---
0 files changed, 0 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/labs/tools/stewardbots 
refs/changes/16/385816/1


-- 
To view, visit https://gerrit.wikimedia.org/r/385816
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia731afff153b99071485d8765af33e2e59442de1
Gerrit-PatchSet: 1
Gerrit-Project: labs/tools/stewardbots
Gerrit-Branch: master
Gerrit-Owner: MarcoAurelio 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...LinkedWiki[master]: Fix SparqlParser

2017-10-21 Thread Karima Rafes (Code Review)

Karima Rafes has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/385815 )

Change subject: Fix SparqlParser
..


Fix SparqlParser

Change-Id: I4a98cd772a84fa28fafc20ec15c3f82af13660b6
---
M parser/SparqlParser.php
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Karima Rafes: Verified; Looks good to me, approved



diff --git a/parser/SparqlParser.php b/parser/SparqlParser.php
index c727925..9fbde13 100644
--- a/parser/SparqlParser.php
+++ b/parser/SparqlParser.php
@@ -127,8 +127,8 @@
 $configEndpoint = isset($configs[$config])? $configs[$config] : 
null;
 if(!EMPTY($configEndpoint)){
 $endpointSg = $configEndpoint["endpointRead"];
-$methodSg = $configEndpoint["HTTPMethodForRead"];
-$parameterSg = $configEndpoint["nameParameterRead"];
+$methodSg = isset($configEndpoint["HTTPMethodForRead"])? 
$configEndpoint["HTTPMethodForRead"] : "GET";
+$parameterSg = isset($configEndpoint["nameParameterRead"])? 
$configEndpoint["nameParameterRead"] : "query";
 }
 }else{
 $endpointSg = $endpoint;

-- 
To view, visit https://gerrit.wikimedia.org/r/385815
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4a98cd772a84fa28fafc20ec15c3f82af13660b6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/LinkedWiki
Gerrit-Branch: master
Gerrit-Owner: Karima Rafes 
Gerrit-Reviewer: Karima Rafes 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...LinkedWiki[master]: Fix SparqlParser

2017-10-21 Thread Karima Rafes (Code Review)

Karima Rafes has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/385815 )

Change subject: Fix SparqlParser
..

Fix SparqlParser

Change-Id: I4a98cd772a84fa28fafc20ec15c3f82af13660b6
---
M parser/SparqlParser.php
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/LinkedWiki 
refs/changes/15/385815/1

diff --git a/parser/SparqlParser.php b/parser/SparqlParser.php
index c727925..9fbde13 100644
--- a/parser/SparqlParser.php
+++ b/parser/SparqlParser.php
@@ -127,8 +127,8 @@
 $configEndpoint = isset($configs[$config])? $configs[$config] : 
null;
 if(!EMPTY($configEndpoint)){
 $endpointSg = $configEndpoint["endpointRead"];
-$methodSg = $configEndpoint["HTTPMethodForRead"];
-$parameterSg = $configEndpoint["nameParameterRead"];
+$methodSg = isset($configEndpoint["HTTPMethodForRead"])? 
$configEndpoint["HTTPMethodForRead"] : "GET";
+$parameterSg = isset($configEndpoint["nameParameterRead"])? 
$configEndpoint["nameParameterRead"] : "query";
 }
 }else{
 $endpointSg = $endpoint;

-- 
To view, visit https://gerrit.wikimedia.org/r/385815
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4a98cd772a84fa28fafc20ec15c3f82af13660b6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/LinkedWiki
Gerrit-Branch: master
Gerrit-Owner: Karima Rafes 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] analytics...WDCM[master]: fix Labels to UTF-8

2017-10-21 Thread GoranSMilovanovic (Code Review)

GoranSMilovanovic has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/385809 )

Change subject: fix Labels to UTF-8
..


fix Labels to UTF-8

Change-Id: Ib59933f7be1658039dc3aaf21c3ab289982958f0
---
M WDCM_OverviewDashboard/server.R
M WDCM_UsageDashboard/server.R
2 files changed, 10 insertions(+), 0 deletions(-)

Approvals:
  GoranSMilovanovic: Verified; Looks good to me, approved



diff --git a/WDCM_OverviewDashboard/server.R b/WDCM_OverviewDashboard/server.R
index 21afbfe..b66201b 100644
--- a/WDCM_OverviewDashboard/server.R
+++ b/WDCM_OverviewDashboard/server.R
@@ -59,6 +59,11 @@
 dbClearResult(res)
 colnames(st) <- "tables"
 
+### --- SET CHARACTER SET utf8
+q <- "SET CHARACTER SET utf8;"
+res <- dbSendQuery(con, q)
+dbClearResult(res)
+
 ### --- fetch wdcm2_project
 q <- "SELECT * FROM wdcm2_project;"
 res <- dbSendQuery(con, q)
diff --git a/WDCM_UsageDashboard/server.R b/WDCM_UsageDashboard/server.R
index be1df87..db927a5 100644
--- a/WDCM_UsageDashboard/server.R
+++ b/WDCM_UsageDashboard/server.R
@@ -52,6 +52,11 @@
 dbClearResult(res)
 colnames(st) <- "tables"
 
+### --- SET CHARACTER SET utf8
+q <- "SET CHARACTER SET utf8;"
+res <- dbSendQuery(con, q)
+dbClearResult(res)
+
 ### --- fetch wdcm2_project
 q <- "SELECT * FROM wdcm2_project;"
 res <- dbSendQuery(con, q)

-- 
To view, visit https://gerrit.wikimedia.org/r/385809
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib59933f7be1658039dc3aaf21c3ab289982958f0
Gerrit-PatchSet: 1
Gerrit-Project: analytics/wmde/WDCM
Gerrit-Branch: master
Gerrit-Owner: GoranSMilovanovic 
Gerrit-Reviewer: GoranSMilovanovic 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] analytics...WDCM[master]: fix Labels to UTF-8

2017-10-21 Thread GoranSMilovanovic (Code Review)

GoranSMilovanovic has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/385809 )

Change subject: fix Labels to UTF-8
..

fix Labels to UTF-8

Change-Id: Ib59933f7be1658039dc3aaf21c3ab289982958f0
---
M WDCM_OverviewDashboard/server.R
M WDCM_UsageDashboard/server.R
2 files changed, 10 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/analytics/wmde/WDCM 
refs/changes/09/385809/1

diff --git a/WDCM_OverviewDashboard/server.R b/WDCM_OverviewDashboard/server.R
index 21afbfe..b66201b 100644
--- a/WDCM_OverviewDashboard/server.R
+++ b/WDCM_OverviewDashboard/server.R
@@ -59,6 +59,11 @@
 dbClearResult(res)
 colnames(st) <- "tables"
 
+### --- SET CHARACTER SET utf8
+q <- "SET CHARACTER SET utf8;"
+res <- dbSendQuery(con, q)
+dbClearResult(res)
+
 ### --- fetch wdcm2_project
 q <- "SELECT * FROM wdcm2_project;"
 res <- dbSendQuery(con, q)
diff --git a/WDCM_UsageDashboard/server.R b/WDCM_UsageDashboard/server.R
index be1df87..db927a5 100644
--- a/WDCM_UsageDashboard/server.R
+++ b/WDCM_UsageDashboard/server.R
@@ -52,6 +52,11 @@
 dbClearResult(res)
 colnames(st) <- "tables"
 
+### --- SET CHARACTER SET utf8
+q <- "SET CHARACTER SET utf8;"
+res <- dbSendQuery(con, q)
+dbClearResult(res)
+
 ### --- fetch wdcm2_project
 q <- "SELECT * FROM wdcm2_project;"
 res <- dbSendQuery(con, q)

-- 
To view, visit https://gerrit.wikimedia.org/r/385809
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib59933f7be1658039dc3aaf21c3ab289982958f0
Gerrit-PatchSet: 1
Gerrit-Project: analytics/wmde/WDCM
Gerrit-Branch: master
Gerrit-Owner: GoranSMilovanovic 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] analytics...WDCM[master]: fix DT width

2017-10-21 Thread GoranSMilovanovic (Code Review)

GoranSMilovanovic has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/385808 )

Change subject: fix DT width
..


fix DT width

Change-Id: I6184b4eaae1cf89fdf2621109e70b2c13ed4701d
---
M WDCM_OverviewDashboard/server.R
M WDCM_UsageDashboard/server.R
2 files changed, 14 insertions(+), 14 deletions(-)

Approvals:
  GoranSMilovanovic: Verified; Looks good to me, approved



diff --git a/WDCM_OverviewDashboard/server.R b/WDCM_OverviewDashboard/server.R
index fd1d5fe..21afbfe 100644
--- a/WDCM_OverviewDashboard/server.R
+++ b/WDCM_OverviewDashboard/server.R
@@ -372,10 +372,10 @@
 datatable(wdcmProjectCategory,
 options = list(
   pageLength = 20,
-  autoWidth = TRUE,
+  width = '100%',
   columnDefs = list(list(className = 'dt-center', targets = "_all"))
   ),
-rownames= FALSE
+rownames = FALSE
 )
   }) %>% withProgress(message = 'Generating data',
   min = 0,
@@ -389,10 +389,10 @@
 datatable(dataSet,
   options = list(
 pageLength = 20,
-autoWidth = TRUE,
+width = '100%',
 columnDefs = list(list(className = 'dt-center', targets = 
"_all"))
   ),
-  rownames= FALSE
+  rownames = FALSE
 )
   }) %>% withProgress(message = 'Generating data',
   min = 0,
diff --git a/WDCM_UsageDashboard/server.R b/WDCM_UsageDashboard/server.R
index 8cded77..be1df87 100644
--- a/WDCM_UsageDashboard/server.R
+++ b/WDCM_UsageDashboard/server.R
@@ -915,10 +915,10 @@
 datatable(wdcmProject,
   options = list(
 pageLength = 20,
-autoWidth = TRUE,
+width = '100%',
 columnDefs = list(list(className = 'dt-center', targets = 
"_all"))
   ),
-  rownames= FALSE
+  rownames = FALSE
 )
   }) %>% withProgress(message = 'Generating data',
   min = 0,
@@ -930,10 +930,10 @@
 datatable(wdcmCategory,
   options = list(
 pageLength = 20,
-autoWidth = TRUE,
+width = '100%',
 columnDefs = list(list(className = 'dt-center', targets = 
"_all"))
   ),
-  rownames= FALSE
+  rownames = FALSE
 )
   }) %>% withProgress(message = 'Generating data',
   min = 0,
@@ -945,10 +945,10 @@
 datatable(wdcmProjectCategory,
   options = list(
 pageLength = 20,
-autoWidth = TRUE,
+width = '100%',
 columnDefs = list(list(className = 'dt-center', targets = 
"_all"))
   ),
-  rownames= FALSE
+  rownames = FALSE
 )
   }) %>% withProgress(message = 'Generating data',
   min = 0,
@@ -960,10 +960,10 @@
 datatable(wdcmProjectType,
   options = list(
 pageLength = 20,
-autoWidth = TRUE,
+width = '100%',
 columnDefs = list(list(className = 'dt-center', targets = 
"_all"))
   ),
-  rownames= FALSE
+  rownames = FALSE
 )
   }) %>% withProgress(message = 'Generating data',
   min = 0,
@@ -975,10 +975,10 @@
 datatable(wdcmProjectTypeCategory,
   options = list(
 pageLength = 20,
-autoWidth = TRUE,
+width = '100%',
 columnDefs = list(list(className = 'dt-center', targets = 
"_all"))
   ),
-  rownames= FALSE
+  rownames = FALSE
 )
   }) %>% withProgress(message = 'Generating data',
   min = 0,

-- 
To view, visit https://gerrit.wikimedia.org/r/385808
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6184b4eaae1cf89fdf2621109e70b2c13ed4701d
Gerrit-PatchSet: 1
Gerrit-Project: analytics/wmde/WDCM
Gerrit-Branch: master
Gerrit-Owner: GoranSMilovanovic 
Gerrit-Reviewer: GoranSMilovanovic 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] analytics...WDCM[master]: fix DT width

2017-10-21 Thread GoranSMilovanovic (Code Review)

GoranSMilovanovic has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/385808 )

Change subject: fix DT width
..

fix DT width

Change-Id: I6184b4eaae1cf89fdf2621109e70b2c13ed4701d
---
M WDCM_OverviewDashboard/server.R
M WDCM_UsageDashboard/server.R
2 files changed, 14 insertions(+), 14 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/analytics/wmde/WDCM 
refs/changes/08/385808/1

diff --git a/WDCM_OverviewDashboard/server.R b/WDCM_OverviewDashboard/server.R
index fd1d5fe..21afbfe 100644
--- a/WDCM_OverviewDashboard/server.R
+++ b/WDCM_OverviewDashboard/server.R
@@ -372,10 +372,10 @@
 datatable(wdcmProjectCategory,
 options = list(
   pageLength = 20,
-  autoWidth = TRUE,
+  width = '100%',
   columnDefs = list(list(className = 'dt-center', targets = "_all"))
   ),
-rownames= FALSE
+rownames = FALSE
 )
   }) %>% withProgress(message = 'Generating data',
   min = 0,
@@ -389,10 +389,10 @@
 datatable(dataSet,
   options = list(
 pageLength = 20,
-autoWidth = TRUE,
+width = '100%',
 columnDefs = list(list(className = 'dt-center', targets = 
"_all"))
   ),
-  rownames= FALSE
+  rownames = FALSE
 )
   }) %>% withProgress(message = 'Generating data',
   min = 0,
diff --git a/WDCM_UsageDashboard/server.R b/WDCM_UsageDashboard/server.R
index 8cded77..be1df87 100644
--- a/WDCM_UsageDashboard/server.R
+++ b/WDCM_UsageDashboard/server.R
@@ -915,10 +915,10 @@
 datatable(wdcmProject,
   options = list(
 pageLength = 20,
-autoWidth = TRUE,
+width = '100%',
 columnDefs = list(list(className = 'dt-center', targets = 
"_all"))
   ),
-  rownames= FALSE
+  rownames = FALSE
 )
   }) %>% withProgress(message = 'Generating data',
   min = 0,
@@ -930,10 +930,10 @@
 datatable(wdcmCategory,
   options = list(
 pageLength = 20,
-autoWidth = TRUE,
+width = '100%',
 columnDefs = list(list(className = 'dt-center', targets = 
"_all"))
   ),
-  rownames= FALSE
+  rownames = FALSE
 )
   }) %>% withProgress(message = 'Generating data',
   min = 0,
@@ -945,10 +945,10 @@
 datatable(wdcmProjectCategory,
   options = list(
 pageLength = 20,
-autoWidth = TRUE,
+width = '100%',
 columnDefs = list(list(className = 'dt-center', targets = 
"_all"))
   ),
-  rownames= FALSE
+  rownames = FALSE
 )
   }) %>% withProgress(message = 'Generating data',
   min = 0,
@@ -960,10 +960,10 @@
 datatable(wdcmProjectType,
   options = list(
 pageLength = 20,
-autoWidth = TRUE,
+width = '100%',
 columnDefs = list(list(className = 'dt-center', targets = 
"_all"))
   ),
-  rownames= FALSE
+  rownames = FALSE
 )
   }) %>% withProgress(message = 'Generating data',
   min = 0,
@@ -975,10 +975,10 @@
 datatable(wdcmProjectTypeCategory,
   options = list(
 pageLength = 20,
-autoWidth = TRUE,
+width = '100%',
 columnDefs = list(list(className = 'dt-center', targets = 
"_all"))
   ),
-  rownames= FALSE
+  rownames = FALSE
 )
   }) %>% withProgress(message = 'Generating data',
   min = 0,

-- 
To view, visit https://gerrit.wikimedia.org/r/385808
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6184b4eaae1cf89fdf2621109e70b2c13ed4701d
Gerrit-PatchSet: 1
Gerrit-Project: analytics/wmde/WDCM
Gerrit-Branch: master
Gerrit-Owner: GoranSMilovanovic 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Wikisource[master]: Move phpcs.xml to .phpcs.xml

2017-10-21 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/385789 )

Change subject: Move phpcs.xml to .phpcs.xml
..


Move phpcs.xml to .phpcs.xml

See T177256

Change-Id: I45f8fa0790d81c647865bf35e3fb1dfdb6724c5e
---
R .phpcs.xml
1 file changed, 0 insertions(+), 0 deletions(-)

Approvals:
  Hashar: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/phpcs.xml b/.phpcs.xml
similarity index 100%
rename from phpcs.xml
rename to .phpcs.xml

-- 
To view, visit https://gerrit.wikimedia.org/r/385789
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I45f8fa0790d81c647865bf35e3fb1dfdb6724c5e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikisource
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 
Gerrit-Reviewer: Hashar 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...ArticleCreationWorkflow[master]: Move phpcs.xml to .phpcs.xml

2017-10-21 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/385782 )

Change subject: Move phpcs.xml to .phpcs.xml
..


Move phpcs.xml to .phpcs.xml

See T177256

Change-Id: I6797b82345b30ca9a2ecd436132991bc0a49cd6d
---
R .phpcs.xml
1 file changed, 0 insertions(+), 0 deletions(-)

Approvals:
  Hashar: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/phpcs.xml b/.phpcs.xml
similarity index 100%
rename from phpcs.xml
rename to .phpcs.xml

-- 
To view, visit https://gerrit.wikimedia.org/r/385782
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6797b82345b30ca9a2ecd436132991bc0a49cd6d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ArticleCreationWorkflow
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 
Gerrit-Reviewer: Hashar 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Move phpcs.xml to .phpcs.xml

2017-10-21 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/385788 )

Change subject: Move phpcs.xml to .phpcs.xml
..


Move phpcs.xml to .phpcs.xml

See T177256

Change-Id: I6830e5f4d7e3fa11b95fc0d12b57b48ffbc362fd
---
R .phpcs.xml
1 file changed, 0 insertions(+), 0 deletions(-)

Approvals:
  Hashar: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/phpcs.xml b/.phpcs.xml
similarity index 100%
rename from phpcs.xml
rename to .phpcs.xml

-- 
To view, visit https://gerrit.wikimedia.org/r/385788
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6830e5f4d7e3fa11b95fc0d12b57b48ffbc362fd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 
Gerrit-Reviewer: Hashar 
Gerrit-Reviewer: Pmiazga 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...OpenLayers[master]: Move phpcs.xml to .phpcs.xml

2017-10-21 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/385787 )

Change subject: Move phpcs.xml to .phpcs.xml
..


Move phpcs.xml to .phpcs.xml

See T177256

Change-Id: I358a4407d16ccac4a27ce5545d382f1f6402d71a
---
R .phpcs.xml
1 file changed, 0 insertions(+), 0 deletions(-)

Approvals:
  Hashar: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/phpcs.xml b/.phpcs.xml
similarity index 100%
rename from phpcs.xml
rename to .phpcs.xml

-- 
To view, visit https://gerrit.wikimedia.org/r/385787
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I358a4407d16ccac4a27ce5545d382f1f6402d71a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/OpenLayers
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 
Gerrit-Reviewer: Hashar 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...MixedNamespaceSearchSuggestions[master]: Move phpcs.xml to .phpcs.xml

2017-10-21 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/385786 )

Change subject: Move phpcs.xml to .phpcs.xml
..


Move phpcs.xml to .phpcs.xml

See T177256

Change-Id: Ia45a0bb9fbc7d0c6d55ab60c136f16e1de0a4f46
---
R .phpcs.xml
1 file changed, 0 insertions(+), 0 deletions(-)

Approvals:
  Hashar: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/phpcs.xml b/.phpcs.xml
similarity index 100%
rename from phpcs.xml
rename to .phpcs.xml

-- 
To view, visit https://gerrit.wikimedia.org/r/385786
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia45a0bb9fbc7d0c6d55ab60c136f16e1de0a4f46
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MixedNamespaceSearchSuggestions
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 
Gerrit-Reviewer: Hashar 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...GlobalPreferences[master]: Move phpcs.xml to .phpcs.xml

2017-10-21 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/385785 )

Change subject: Move phpcs.xml to .phpcs.xml
..


Move phpcs.xml to .phpcs.xml

See T177256

Change-Id: Ice1f2ea590c8d405348b754c974a8340752ffe90
---
R .phpcs.xml
1 file changed, 0 insertions(+), 0 deletions(-)

Approvals:
  Hashar: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/phpcs.xml b/.phpcs.xml
similarity index 100%
rename from phpcs.xml
rename to .phpcs.xml

-- 
To view, visit https://gerrit.wikimedia.org/r/385785
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ice1f2ea590c8d405348b754c974a8340752ffe90
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/GlobalPreferences
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 
Gerrit-Reviewer: Hashar 
Gerrit-Reviewer: Samwilson 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...BoilerPlate[master]: Move phpcs.xml to .phpcs.xml

2017-10-21 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/385783 )

Change subject: Move phpcs.xml to .phpcs.xml
..


Move phpcs.xml to .phpcs.xml

See T177256

Change-Id: I290706a9f642dbbf98928b9045e88bd02a44a949
---
R .phpcs.xml
1 file changed, 0 insertions(+), 0 deletions(-)

Approvals:
  Hashar: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/phpcs.xml b/.phpcs.xml
similarity index 100%
rename from phpcs.xml
rename to .phpcs.xml

-- 
To view, visit https://gerrit.wikimedia.org/r/385783
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I290706a9f642dbbf98928b9045e88bd02a44a949
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BoilerPlate
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 
Gerrit-Reviewer: Hashar 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Genealogy[master]: Move phpcs.xml to .phpcs.xml

2017-10-21 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/385784 )

Change subject: Move phpcs.xml to .phpcs.xml
..


Move phpcs.xml to .phpcs.xml

See T177256

Change-Id: I513c33e2c845813aaae31d11250fc9a3f9acdf5a
---
R .phpcs.xml
1 file changed, 0 insertions(+), 0 deletions(-)

Approvals:
  Hashar: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/phpcs.xml b/.phpcs.xml
similarity index 100%
rename from phpcs.xml
rename to .phpcs.xml

-- 
To view, visit https://gerrit.wikimedia.org/r/385784
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I513c33e2c845813aaae31d11250fc9a3f9acdf5a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Genealogy
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 
Gerrit-Reviewer: Hashar 
Gerrit-Reviewer: Samwilson 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] analytics...WDCM[master]: rm - minor

2017-10-21 Thread GoranSMilovanovic (Code Review)

GoranSMilovanovic has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/385807 )

Change subject: rm - minor
..


rm - minor

Change-Id: I68976257eed326eec9f36ef00b426f902b030b2f
---
D creds.csv
1 file changed, 0 insertions(+), 2 deletions(-)

Approvals:
  GoranSMilovanovic: Verified; Looks good to me, approved



diff --git a/creds.csv b/creds.csv
deleted file mode 100644
index 7f4f901..000
--- a/creds.csv
+++ /dev/null
@@ -1,2 +0,0 @@
-username,password
-research,Kfj%5M$d134DEwxa6098!!33

-- 
To view, visit https://gerrit.wikimedia.org/r/385807
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I68976257eed326eec9f36ef00b426f902b030b2f
Gerrit-PatchSet: 1
Gerrit-Project: analytics/wmde/WDCM
Gerrit-Branch: master
Gerrit-Owner: GoranSMilovanovic 
Gerrit-Reviewer: GoranSMilovanovic 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] analytics...WDCM[master]: rm - minor

2017-10-21 Thread GoranSMilovanovic (Code Review)

GoranSMilovanovic has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/385807 )

Change subject: rm - minor
..

rm - minor

Change-Id: I68976257eed326eec9f36ef00b426f902b030b2f
---
D creds.csv
1 file changed, 0 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/analytics/wmde/WDCM 
refs/changes/07/385807/1

diff --git a/creds.csv b/creds.csv
deleted file mode 100644
index 7f4f901..000
--- a/creds.csv
+++ /dev/null
@@ -1,2 +0,0 @@
-username,password
-research,Kfj%5M$d134DEwxa6098!!33

-- 
To view, visit https://gerrit.wikimedia.org/r/385807
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I68976257eed326eec9f36ef00b426f902b030b2f
Gerrit-PatchSet: 1
Gerrit-Project: analytics/wmde/WDCM
Gerrit-Branch: master
Gerrit-Owner: GoranSMilovanovic 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...SportsTeams[master]: Add missing qqq message documentation

2017-10-21 Thread Umherirrender (Code Review)

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/385806 )

Change subject: Add missing qqq message documentation
..

Add missing qqq message documentation

Change-Id: I86db2916271bfe688684baef70da35c7056cfa49
---
M i18n/qqq.json
1 file changed, 131 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SportsTeams 
refs/changes/06/385806/1

diff --git a/i18n/qqq.json b/i18n/qqq.json
index fda111f..f5fd12e 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -3,6 +3,137 @@
"authors": []
},
"sportsteams-desc": 
"{{desc|name=SportsTeams|url=https://www.mediawiki.org/wiki/Extension:SportsTeams}};,
+   "topnetworks": "{{doc-special}}",
+   "similarfans": "{{doc-special}}",
+   "sportsteamsmanager": "{{doc-special}}",
+   "sportsteams-add-button": "A button text",
+   "sportsteams-articles-votes": "A item text",
+   "sportsteams-no-articles": "A hint message for no results",
+   "sportsteams-count-fans": "A item text",
+   "sportsteams-similar-fans": "A item text",
+   "sportsteams-num-similar": "A item text",
+   "sportsteams-invite-friends": "A button text",
+   "sportsteams-your-friend": "A hint message",
+   "sportsteams-your-foe": "A hint message",
+   "sportsteams-add-as-friend": "A link text",
+   "sportsteams-remove-as-friend": "A link text",
+   "sportsteams-add-as-foe": "A link text",
+   "sportsteams-remove-as-foe": "A link text",
+   "sportsteams-give-a-gift": "A link text",
+   "sportsteams-prev": "A navigation link",
+   "sportsteams-next": "A navigation link",
+   "sportsteams-woops": "An error message",
+   "sportsteams-network-woops-title": "A page title",
+   "sportsteams-network-woops-text": "A description text",
+   "sportsteams-network-fan-network": "A page title",
+   "sportsteams-network-you-are-fan": "A hint message",
+   "sportsteams-network-leave-network": "A link text",
+   "sportsteams-network-join-network": "A link text",
+   "sportsteams-network-info": "A header info",
+   "sportsteams-network-logo": "A hint text",
+   "sportsteams-network-fans-col": "A hint message",
+   "sportsteams-network-friends-col": "A hint message",
+   "sportsteams-network-fans": "A header message",
+   "sportsteams-network-fan": "A header message",
+   "sportsteams-network-fan-display": "A hint message",
+   "sportsteams-network-latest-thoughts": "A header message",
+   "sportsteams-network-all-thoughts": "A header message",
+   "sportsteams-network-fan-locations": "A header message",
+   "sportsteams-network-top-fans": "A header message",
+   "sportsteams-network-top-fans-week": "A link text",
+   "sportsteams-network-complete-list": "A link text",
+   "sportsteams-network-articles": "A header message",
+   "sportsteams-network-write-article": "A link text",
+   "sportsteams-network-main-page": "A button text",
+   "sportsteams-network-your-profile": "A button text",
+   "sportsteams-network-points": "A item message",
+   "sportsteams-network-newest": "A hint message",
+   "sportsteams-network-clicktozoom": "A button text",
+   "sportsteams-network-now-member": "A page title",
+   "sportsteams-network-invite-more": "A button text",
+   "sportsteams-network-find-other": "A button text",
+   "sportsteams-network-already-member": "A hint message",
+   "sportsteams-network-no-need-join": "A hint message",
+   "sportsteams-network-join-named-network": "A page title",
+   "sportsteams-network-join-are-you-sure": "A confirmation text",
+   "sportsteams-network-alt-logo": "A label text",
+   "sportsteams-network-network-fans": "A page title",
+   "sportsteams-network-back-to-network": "A navigation link",
+   "sportsteams-network-num-fans": "A alt image text",
+   "sportsteams-network-num-fans-sport": "A alt image text",
+   "sportsteams-network-no-longer-member": "A success message",
+   "sportsteams-network-not-member": "A page title",
+   "sportsteams-network-leave": "A page title",
+   "sportsteams-network-leave-are-you-sure": "A confirmation message",
+   "sportsteams-network-remove-me": "A button text",
+   "sportsteams-top-network-sports": "A link text",
+   "sportsteams-top-network-teams": "A link text",
+   "sportsteams-top-network-least": "A link text",
+   "sportsteams-top-network-most": "A link text",
+   "sportsteams-top-network-team-title-least-sports": "A page title",
+   "sportsteams-top-network-team-title-least-teams": "A page title",
+   "sportsteams-top-network-team-title-most-sports": "A page title",
+   "sportsteams-top-network-team-title-most-teams": "A page title",
+   "sportsteams-top-network-most-popular": "A header message",
+

[MediaWiki-commits] [Gerrit] labs...ZppixBot[master]: Fix links per https://github.com/wikimedia/labs-tools-ZppixB...

2017-10-21 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/385804 )

Change subject: Fix links per 
https://github.com/wikimedia/labs-tools-ZppixBot/pull/1/
..


Fix links per https://github.com/wikimedia/labs-tools-ZppixBot/pull/1/

Change-Id: I50c00f3decf2e19e1756bdf46c71b08c91e30cd1
---
M public_html/contribs.php
M public_html/index.php
2 files changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Zppix: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/public_html/contribs.php b/public_html/contribs.php
index 359f449..b771902 100644
--- a/public_html/contribs.php
+++ b/public_html/contribs.php
@@ -2,4 +2,4 @@
 Zppix- Operator
 tom29739- Release version bot operator, developer
 SwisterTwister- Zppixbot web design, and friend.
-https://meta.miraheze.org/wiki/User:Reception123;>Reception123 - 
Helps with new features
+https://meta.miraheze.org/wiki/User:Reception123;>Reception123 - 
Helps with new features
diff --git a/public_html/index.php b/public_html/index.php
index c8495f7..3bb0cfb 100644
--- a/public_html/index.php
+++ b/public_html/index.php
@@ -1,10 +1,10 @@
 For more information, click here. 
 List of contributors, click here 
 
-If you need ZppixBot in your channel, please contact Zppix or https://meta.miraheze.org/wiki/User:Reception123;>Reception123 
+If you need ZppixBot in your channel, please contact Zppix or https://meta.miraheze.org/wiki/User:Reception123;>Reception123 
 
  The second release of ZppixBot is now here! 
  For more information please check out https://github.com/Pix1234/ZppixBot-Source/releases/tag/v2;>the release 
tag !!!
 
 Previous releases:
-https://github.com/Pix1234/ZppixBot-Source/releases/tag/v1;>v1 (30 
July 2017)
+https://github.com/Pix1234/ZppixBot-Source/releases/tag/v1;>v1 (30 
July 2017)

-- 
To view, visit https://gerrit.wikimedia.org/r/385804
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I50c00f3decf2e19e1756bdf46c71b08c91e30cd1
Gerrit-PatchSet: 2
Gerrit-Project: labs/tools/ZppixBot
Gerrit-Branch: master
Gerrit-Owner: MacFan4000 
Gerrit-Reviewer: Zppix 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...HAWelcome[master]: Rework and improve HAWelcome

2017-10-21 Thread Mainframe98 (Code Review)

Mainframe98 has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/385805 )

Change subject: Rework and improve HAWelcome
..

Rework and improve HAWelcome

As noted by Jack Phoenix in ca43438211d194749715fc541334ed9c030f098c,
there are still some outstanding TODO's. This patch attempts to
address those.
* The hardcoded welcomer name has been changed to use a configuration
variable, $wgHAWelcomeUserName, with the previously hardcoded value
as default.
* The global_user_groups table will only be queried if the
GlobalUserrights extension is installed, and the dependency on that
extension has been dropped.
* Expiring user rights are now taken in account for both local and
global user rights, which means only users with a valid group
membership will be used as welcomer.
* Two patches to HAWelcome from the Wikia codebase have been
incorporated:
** If the last active sysop has their groups changed, they will be
removed from cache. This has been adjusted to only remove the user
from cache when the sysop group is removed.
** Instead of checking against a list of hardcoded groups whose
members should never be welcomed, a user right welcomeexempt has
been introduced. Granted to the groups bureaucrat, sysop, staff
and bot, users with this right will not have their user page created
nor will a message be left on their talk page.

Other improvements include the removal of deprecated globals such as
$wgUser, $wgTitle and $wgRequest, i18n of the extension name and
description adding message documentation, adding a LICENSE file and
dedicated selection of staff users when the fallback has been activated.

Bug: T178605
Change-Id: Iea20bad42abf2e1f966b835c6965aa1fd67fa92d
---
M HAWelcome.class.php
A HAWelcome.hooks.php
A LICENSE
A README
M extension.json
M i18n/en.json
A i18n/qqq.json
7 files changed, 712 insertions(+), 272 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/HAWelcome 
refs/changes/05/385805/1

diff --git a/HAWelcome.class.php b/HAWelcome.class.php
index fbf7478..ef3d344 100644
--- a/HAWelcome.class.php
+++ b/HAWelcome.class.php
@@ -21,17 +21,14 @@
$mAnon,
$mSysop;
 
-   const WELCOMEUSER = 'ShoutWiki';
-
/**
 * Construct a job
 *
 * @param Title $title The title linked to
 * @param array $params Job parameters (table, start and end page_ids)
-* @param int $id job_id, 0 by default
 */
-   public function __construct( $title, $params, $id = 0 ) {
-   parent::__construct( 'HAWelcome', $title, $params, $id );
+   public function __construct( $title, $params ) {
+   parent::__construct( 'HAWelcome', $title, $params );
 
$this->mUserId   = $params['user_id'];
$this->mUserIP   = $params['user_ip'];
@@ -45,9 +42,7 @@
$this->mUser = User::newFromId( $this->mUserId );
}
 
-   /**
-* fallback
-*/
+   // Fallback
if ( !$this->mUser ) {
$this->mUser = User::newFromName( $this->mUserName );
}
@@ -57,91 +52,88 @@
 * Main entry point
 */
public function run() {
-   global $wgUser, $wgTitle, $wgLanguageCode;
+   global $wgLanguageCode, $wgHAWelcomeWelcomeUsername;
 
-   /**
-* overwrite $wgUser for  expanding
-*/
$sysop = trim( wfMessage( 'welcome-user' )->plain() );
-   if ( !in_array( $sysop, [ '@disabled', '-' ] ) ) {
-   $tmpUser = $wgUser;
-   $wgUser = User::newFromName( self::WELCOMEUSER );
-   $flags = 0;
-   if ( $wgUser && $wgUser->isBot() ) {
-   $flags = EDIT_FORCE_BOT;
-   }
+   if ( in_array( $sysop, [ '@disabled', '-' ] ) ) {
+   return true;
+   }
 
-   if ( $this->mUser && $this->mUser->getName() !== 
self::WELCOMEUSER && !$wgUser->isBlocked() ) {
-   /**
-* check again if talk page exists
-*/
-   $talkPage = 
$this->mUser->getUserPage()->getTalkPage();
+   $welcomeUser = User::newFromName( $wgHAWelcomeWelcomeUsername );
+   $flags = 0;
+   if ( $welcomeUser && $welcomeUser->isBot() ) {
+   $flags = EDIT_FORCE_BOT;
+   }
 
-   if ( $talkPage ) {
-   $this->mSysop = $this->getLastSysop();
-   $tmpTitle = $wgTitle;
-   $sysopPage=

[MediaWiki-commits] [Gerrit] labs...ZppixBot[master]: Fix links per https://github.com/wikimedia/labs-tools-ZppixB...

2017-10-21 Thread MacFan4000 (Code Review)

MacFan4000 has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/385804 )

Change subject: Fix links per 
https://github.com/wikimedia/labs-tools-ZppixBot/pull/1/
..

Fix links per https://github.com/wikimedia/labs-tools-ZppixBot/pull/1/

Change-Id: I50c00f3decf2e19e1756bdf46c71b08c91e30cd1
---
M public_html/contribs.php
M public_html/index.php
2 files changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/labs/tools/ZppixBot 
refs/changes/04/385804/2

diff --git a/public_html/contribs.php b/public_html/contribs.php
index 359f449..b771902 100644
--- a/public_html/contribs.php
+++ b/public_html/contribs.php
@@ -2,4 +2,4 @@
 Zppix- Operator
 tom29739- Release version bot operator, developer
 SwisterTwister- Zppixbot web design, and friend.
-https://meta.miraheze.org/wiki/User:Reception123;>Reception123 - 
Helps with new features
+https://meta.miraheze.org/wiki/User:Reception123;>Reception123 - 
Helps with new features
diff --git a/public_html/index.php b/public_html/index.php
index c8495f7..3bb0cfb 100644
--- a/public_html/index.php
+++ b/public_html/index.php
@@ -1,10 +1,10 @@
 For more information, click here. 
 List of contributors, click here 
 
-If you need ZppixBot in your channel, please contact Zppix or https://meta.miraheze.org/wiki/User:Reception123;>Reception123 
+If you need ZppixBot in your channel, please contact Zppix or https://meta.miraheze.org/wiki/User:Reception123;>Reception123 
 
  The second release of ZppixBot is now here! 
  For more information please check out https://github.com/Pix1234/ZppixBot-Source/releases/tag/v2;>the release 
tag !!!
 
 Previous releases:
-https://github.com/Pix1234/ZppixBot-Source/releases/tag/v1;>v1 (30 
July 2017)
+https://github.com/Pix1234/ZppixBot-Source/releases/tag/v1;>v1 (30 
July 2017)

-- 
To view, visit https://gerrit.wikimedia.org/r/385804
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I50c00f3decf2e19e1756bdf46c71b08c91e30cd1
Gerrit-PatchSet: 2
Gerrit-Project: labs/tools/ZppixBot
Gerrit-Branch: master
Gerrit-Owner: MacFan4000 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...ORES[master]: Fix merge strategy in $wgOresDraftQualityNS

2017-10-21 Thread Ladsgroup (Code Review)

Ladsgroup has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/385803 )

Change subject: Fix merge strategy in $wgOresDraftQualityNS
..

Fix merge strategy in $wgOresDraftQualityNS

Bug: T176183
Change-Id: Ifc10d8a8fe10d3675cc176f616f2804f7e392111
---
M extension.json
1 file changed, 4 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ORES 
refs/changes/03/385803/1

diff --git a/extension.json b/extension.json
index d6b1f1e..00fe46a 100644
--- a/extension.json
+++ b/extension.json
@@ -183,7 +183,10 @@
"_merge_strategy": "array_plus_2d"
},
"OresEnabledNamespaces": {},
-   "OresDraftQualityNS": { "0": true },
+   "OresDraftQualityNS": {
+   "0": true,
+   "_merge_strategy": "array_plus"
+   },
"OresWikiId": null,
"@OresRevisionsPerBatch": "Number of revisions to fetch scores 
for from the ORES API per request when the MediaWiki API is asked to score 
revisions which are not cached. Set to 0 to disable fetching (scores will still 
be fetched for new edits).",
"OresRevisionsPerBatch": 30,

-- 
To view, visit https://gerrit.wikimedia.org/r/385803
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifc10d8a8fe10d3675cc176f616f2804f7e392111
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ORES
Gerrit-Branch: master
Gerrit-Owner: Ladsgroup 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...PictureGame[master]: Add missing qqq message documentation

2017-10-21 Thread Umherirrender (Code Review)

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/385802 )

Change subject: Add missing qqq message documentation
..

Add missing qqq message documentation

Activate banana checker

Change-Id: I0e121da3a54ffd0aedee1a98a53fd49c97022b3c
---
M Gruntfile.js
M i18n/qqq.json
2 files changed, 85 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/PictureGame 
refs/changes/02/385802/1

diff --git a/Gruntfile.js b/Gruntfile.js
index b7fa05b..dc2f66e 100644
--- a/Gruntfile.js
+++ b/Gruntfile.js
@@ -24,6 +24,6 @@
}
} );
 
-   grunt.registerTask( 'test', [ 'jshint', 'jsonlint', /** 'banana' */ ] );
+   grunt.registerTask( 'test', [ 'jshint', 'jsonlint', 'banana' ] );
grunt.registerTask( 'default', 'test' );
 };
diff --git a/i18n/qqq.json b/i18n/qqq.json
index 1f7cba1..e1d6581 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -2,9 +2,89 @@
"@metadata": {
"authors": []
},
-   "picturegame-adminpanelunflag-confirm": "Confirmation message shown in 
the un-flag dialog.",
-   "picturegame-adminpaneldelete-confirm": "Confirmation message shown in 
the delete dialog.",
-   "picturegame-flagimgconfirm": "Confirmation message shown in the report 
dialog.",
+   "picturegame-desc": 
"{{desc|name=PictureGame|url=https://www.mediawiki.org/wiki/Extension:PictureGame}};,
+   "picturegame-signup": "A button text",
+   "picturegame-login": "A button text",
+   "picturegame-submittedby": "A header text",
+   "picturegame-reportimages": "A link text",
+   "picturegame-permalink": "A link text",
+   "picturegame-adminpanel": "A link text",
+   "picturegame-protectimages": "A link text",
"picturegame-error-socialprofile": "Error message shown when 
SocialProfle extension is not installed.",
-   "picturegame-error-socialprofile-title": "Title for 
quizgame-error-socialprofile."
+   "picturegame-error-socialprofile-title": "Title for 
quizgame-error-socialprofile.",
+   "picturegame-createlink": "A link text",
+   "picturegame-skipbutton": "A navigation link",
+   "picturegame-backbutton": "A navigation link",
+   "picturegame-previousgame": "A navigation link",
+   "picturegame-adminpaneltitle": "A page title",
+   "picturegame-adminpanelreason": "A label message",
+   "picturegame-adminpanelflagged": "A hint message",
+   "picturegame-adminpanelprotected": "A hint message",
+   "picturegame-adminpanelunflag": "A page title",
+   "picturegame-adminpanelunflag-confirm": "Confirmation message shown in 
the un-flag dialog.",
+   "picturegame-adminpaneldelete": "A page title",
+   "picturegame-adminpaneldelete-confirm": "Confirmation message shown in 
the delete dialog.",
+   "picturegame-adminpanelunprotect": "A link text",
+   "picturegame-adminpanelbacktogame": "A navigation link",
+   "picturegame-creategametitle": "A page title",
+   "picturegame-creategamenotloggedin": "An error message",
+   "picturegame-creategamewelcome": "A description message",
+   "picturegame-creategameplayinstead": "A button text",
+   "picturegame-creategamegametitle": "A header message",
+   "picturegame-creategamecaptiontext": "A label message",
+   "picturegame-creategamefiletext": "A label message",
+   "picturegame-creategamecreateplay": "A button message",
+   "picturegame-createeditfirstimage": "A header message",
+   "picturegame-createeditsecondimage": "A header message",
+   "picturegame-editgameediting": "A label message",
+   "picturegame-editgame-editing-title": "A page title",
+   "picturegame-editgamegametitle": "A header message",
+   "picturegame-editgameuploadtext": "A link text",
+   "picturegame-flagimgconfirm": "Confirmation message shown in the report 
dialog.",
+   "picturegame-protectimgconfirm": "A confirmation message",
+   "picturegame-buttonupload": "A button text",
+   "picturegame-buttonsubmit": "A button text",
+   "picturegame-buttonplaygame": "A button text",
+   "picturegame-permalinkflagged": "A link text",
+   "picturegame-sysmsg-unauthorized": "An error message",
+   "picturegame-sysmsg-blocked": "An error message",
+   "picturegame-sysmsg-badkey": "An error message",
+   "picturegame-sysmsg-successfuldelete": "A success message",
+   "picturegame-sysmsg-unsuccessfuldelete": "An error message",
+   "picturegame-sysmsg-unflag": "A success message",
+   "picturegame-sysmsg-flag": "A success message",
+   "picturegame-sysmsg-unprotect": "A success message",
+   "picturegame-sysmsg-protect": "A success message",
+   "picturegame-least": "A header message",
+   "picturegame-leastheat": "A link text",
+   "picturegame-leastvotes": "A link text",
+

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseQualityConstraints[master]: Remove support for old API output format

2017-10-21 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/385388 )

Change subject: Remove support for old API output format
..


Remove support for old API output format

Bug: T168532
Change-Id: Idc30ec9ea01101c6a4baaa609eca34bb9c6832a6
---
M extension.json
M includes/ConstraintCheck/Context/ApiV2Context.php
D includes/ConstraintCheck/Context/StatementContext.php
M includes/ConstraintCheck/DelegatingConstraintChecker.php
M includes/ConstraintReportFactory.php
M tests/phpunit/Checker/CommonsLinkChecker/CommonsLinkCheckerTest.php
M tests/phpunit/Checker/ConnectionChecker/ConflictsWithCheckerTest.php
M tests/phpunit/Checker/ConnectionChecker/InverseCheckerTest.php
M tests/phpunit/Checker/ConnectionChecker/ItemCheckerTest.php
M tests/phpunit/Checker/ConnectionChecker/SymmetricCheckerTest.php
M tests/phpunit/Checker/ConnectionChecker/TargetRequiredClaimCheckerTest.php
M tests/phpunit/Checker/FormatChecker/FormatCheckerTest.php
M tests/phpunit/Checker/OneOfChecker/OneOfCheckerTest.php
M tests/phpunit/Checker/QualifierChecker/MandatoryQualifiersCheckerTest.php
M tests/phpunit/Checker/QualifierChecker/QualifierCheckerTest.php
M tests/phpunit/Checker/QualifierChecker/QualifiersCheckerTest.php
M tests/phpunit/Checker/RangeChecker/DiffWithinRangeCheckerTest.php
M tests/phpunit/Checker/RangeChecker/RangeCheckerTest.php
M tests/phpunit/Checker/ReferenceCheckerTest.php
M tests/phpunit/Checker/TypeChecker/TypeCheckerTest.php
M tests/phpunit/Checker/TypeChecker/ValueTypeCheckerTest.php
M tests/phpunit/Checker/ValueCountChecker/MultiValueCheckerTest.php
M tests/phpunit/Checker/ValueCountChecker/SingleValueCheckerTest.php
M tests/phpunit/Checker/ValueCountChecker/UniqueValueCheckerTest.php
M tests/phpunit/Checker/ValueOnlyCheckerTest.php
D tests/phpunit/Context/StatementContextTest.php
M tests/phpunit/Helper/ConstraintParameterParserTest.php
M tests/phpunit/Helper/LoggingHelperTest.php
28 files changed, 117 insertions(+), 357 deletions(-)

Approvals:
  Jonas Kress (WMDE): Looks good to me, approved
  jenkins-bot: Verified



diff --git a/extension.json b/extension.json
index 7dbb153..eb3ba73 100644
--- a/extension.json
+++ b/extension.json
@@ -124,19 +124,14 @@
"description": "Whether to import property constraint 
statements into the constraint database or not.",
"public": true
},
-   "WBQualityConstraintsNewApiOutputFormat": {
-   "value": true,
-   "description": "Whether to use the new API output 
format, based on the Wikibase entity JSON format, which can accommodate 
constraint results on qualifiers and references.",
-   "public": true
-   },
"WBQualityConstraintsCheckQualifiers": {
"value": false,
-   "description": "Whether to check constraints on 
qualifiers. Requires the new API output format (otherwise ignored).",
+   "description": "Whether to check constraints on 
qualifiers.",
"public": true
},
"WBQualityConstraintsCheckReferences": {
"value": false,
-   "description": "Whether to check constraints on 
references. Requires the new API output format (otherwise ignored).",
+   "description": "Whether to check constraints on 
references.",
"public": true
},
"WBQualityConstraintsSparqlEndpoint": {
diff --git a/includes/ConstraintCheck/Context/ApiV2Context.php 
b/includes/ConstraintCheck/Context/ApiV2Context.php
index 5ac66e9..b693b10 100644
--- a/includes/ConstraintCheck/Context/ApiV2Context.php
+++ b/includes/ConstraintCheck/Context/ApiV2Context.php
@@ -4,6 +4,7 @@
 
 /**
  * Abstract superclass of all contexts for the second version of the API 
output format.
+ * (This is currently the only supported format.)
  *
  * This output format is modeled after the Wikibase entity JSON format,
  * where an object with the members 'hash' and a list of 'reports' can appear
diff --git a/includes/ConstraintCheck/Context/StatementContext.php 
b/includes/ConstraintCheck/Context/StatementContext.php
deleted file mode 100644
index 2968a0d..000
--- a/includes/ConstraintCheck/Context/StatementContext.php
+++ /dev/null
@@ -1,76 +0,0 @@
-getMainSnak() );
-   $this->statement = $statement;
-   }
-
-   public function getType() {
-   return self::TYPE_STATEMENT;
-   }
-
-   public function getSnakRank() {
-   return $this->statement->getRank();
-   }
-
-   public function getSnakStatement() {
-   return $this->statement;
-   }
-
-   /**
-* The $container is keyed by entity ID, then by property ID,
-* then by claim ID, and then contains the

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseQualityConstraints[master]: Use new API output format by default

2017-10-21 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/385387 )

Change subject: Use new API output format by default
..


Use new API output format by default

Bug: T168532
Change-Id: I1e1057622cb53ab64e68114be1b7c7df91b5a5c8
---
M extension.json
M tests/phpunit/Api/CheckConstraintsTest.php
2 files changed, 11 insertions(+), 5 deletions(-)

Approvals:
  Jonas Kress (WMDE): Looks good to me, approved
  jenkins-bot: Verified



diff --git a/extension.json b/extension.json
index d24e514..7dbb153 100644
--- a/extension.json
+++ b/extension.json
@@ -125,7 +125,7 @@
"public": true
},
"WBQualityConstraintsNewApiOutputFormat": {
-   "value": false,
+   "value": true,
"description": "Whether to use the new API output 
format, based on the Wikibase entity JSON format, which can accommodate 
constraint results on qualifiers and references.",
"public": true
},
diff --git a/tests/phpunit/Api/CheckConstraintsTest.php 
b/tests/phpunit/Api/CheckConstraintsTest.php
index 9cc8490..280760b 100644
--- a/tests/phpunit/Api/CheckConstraintsTest.php
+++ b/tests/phpunit/Api/CheckConstraintsTest.php
@@ -129,7 +129,7 @@
LoggerFactory::getInstance( 
'WikibaseQualityConstraints' ),
$config
),
-   false,
+   true,
false,
false
);
@@ -191,7 +191,9 @@
$result = $this->doRequest( [ CheckConstraints::PARAM_ID => 
'Q1' ] );
 
$this->assertCount( 1, $result['wbcheckconstraints'] );
-   $resultsForItem = 
$result['wbcheckconstraints']['Q1']['P1']['Q1$46fc8ec9-4903-4592-9a0e-afdd1fa03183'];
+   $resultStatement = 
$result['wbcheckconstraints']['Q1']['claims']['P1'][0];
+   $this->assertSame( 'Q1$46fc8ec9-4903-4592-9a0e-afdd1fa03183', 
$resultStatement['id'] );
+   $resultsForItem = $resultStatement['mainsnak']['results'];
$this->assertCount( 1, $resultsForItem );
$this->assertEquals( CheckResult::STATUS_WARNING, 
$resultsForItem[0]['status'] );
$this->assertEquals( 'P1', $resultsForItem[0]['property'] );
@@ -208,7 +210,9 @@
$result = $this->doRequest( [ CheckConstraints::PARAM_CLAIM_ID 
=> 'Q1$46fc8ec9-4903-4592-9a0e-afdd1fa03183' ] );
 
$this->assertCount( 1, $result['wbcheckconstraints'] );
-   $resultsForItem = 
$result['wbcheckconstraints']['Q1']['P1']['Q1$46fc8ec9-4903-4592-9a0e-afdd1fa03183'];
+   $resultStatement = 
$result['wbcheckconstraints']['Q1']['claims']['P1'][0];
+   $this->assertSame( 'Q1$46fc8ec9-4903-4592-9a0e-afdd1fa03183', 
$resultStatement['id'] );
+   $resultsForItem = $resultStatement['mainsnak']['results'];
$this->assertCount( 1, $resultsForItem );
$this->assertEquals( CheckResult::STATUS_WARNING, 
$resultsForItem[0]['status'] );
$this->assertEquals( 'P1', $resultsForItem[0]['property'] );
@@ -228,7 +232,9 @@
$result = $this->doRequest( [ CheckConstraints::PARAM_CLAIM_ID 
=> $guid ] );
 
$this->assertCount( 1, $result['wbcheckconstraints'] );
-   $resultsForItem = 
$result['wbcheckconstraints'][$itemId][$propertyId][$guid];
+   $resultStatement = 
$result['wbcheckconstraints']['Q1']['claims']['P1'][0];
+   $this->assertSame( $guid, $resultStatement['id'] );
+   $resultsForItem = $resultStatement['mainsnak']['results'];
$this->assertCount( 1, $resultsForItem );
$this->assertEquals( CheckResult::STATUS_WARNING, 
$resultsForItem[0]['status'] );
$this->assertEquals( $propertyId, 
$resultsForItem[0]['property'] );

-- 
To view, visit https://gerrit.wikimedia.org/r/385387
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1e1057622cb53ab64e68114be1b7c7df91b5a5c8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseQualityConstraints
Gerrit-Branch: master
Gerrit-Owner: Lucas Werkmeister (WMDE) 
Gerrit-Reviewer: Jonas Kress (WMDE) 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] translatewiki[master]: Enable Sandbox on translatewiki

2017-10-21 Thread Zoranzoki21 (Code Review)

Zoranzoki21 has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/385801 )

Change subject: Enable Sandbox on translatewiki
..

Enable Sandbox on translatewiki

Bug: T130488
Change-Id: I7e591966ff0f1be9a4ec9017e26f365fe124512c
---
M TranslatewikiSettings.php
1 file changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/translatewiki 
refs/changes/01/385801/1

diff --git a/TranslatewikiSettings.php b/TranslatewikiSettings.php
index a029074..a3cd031 100644
--- a/TranslatewikiSettings.php
+++ b/TranslatewikiSettings.php
@@ -426,3 +426,7 @@
 $wgHooks['BeforePageDisplay'][] = function ( $out ) {
$out->addModules( 'twn.jserrorlog' );
 };
+
+'$wgUseTemplateSandbox'=> array(
+   'default' => true,
+),
\ No newline at end of file

-- 
To view, visit https://gerrit.wikimedia.org/r/385801
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7e591966ff0f1be9a4ec9017e26f365fe124512c
Gerrit-PatchSet: 1
Gerrit-Project: translatewiki
Gerrit-Branch: master
Gerrit-Owner: Zoranzoki21 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] pywikibot/core[master]: [doc] Fix options documentation

2017-10-21 Thread Xqt (Code Review)

Xqt has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/385800 )

Change subject: [doc] Fix options documentation
..

[doc] Fix options documentation

Change-Id: I92164d19116b10e65596c3feb7d10e9f3b3f3e93
---
M scripts/maintenance/compat2core.py
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core 
refs/changes/00/385800/1

diff --git a/scripts/maintenance/compat2core.py 
b/scripts/maintenance/compat2core.py
index 854d224..4e62b64 100755
--- a/scripts/maintenance/compat2core.py
+++ b/scripts/maintenance/compat2core.py
@@ -12,8 +12,8 @@
 The scripts asks for the .py file and converts it to
 -core.py in the same directory. The following option is supported:
 
-- warnonly: Do not convert the source but show warning messages. This is good
-to check already merged scripts.
+-warnonly  Do not convert the source but show warning messages. This is good
+   to check already merged scripts.
 
 usage
 

-- 
To view, visit https://gerrit.wikimedia.org/r/385800
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I92164d19116b10e65596c3feb7d10e9f3b3f3e93
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Xqt 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] pywikibot/core[master]: [doc] Fix doc string in a way not to break the options tables

2017-10-21 Thread Xqt (Code Review)

Xqt has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/385799 )

Change subject: [doc] Fix doc string in a way not to break the options tables
..

[doc] Fix doc string in a way not to break the options tables

See:

https://doc.wikimedia.org/pywikibot/api_ref/pywikibot.html#generator-options

Change-Id: Iab02d9f55ba6e6a734bad65d9fccbdda9769409e
---
M pywikibot/pagegenerators.py
1 file changed, 224 insertions(+), 215 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core 
refs/changes/99/385799/1

diff --git a/pywikibot/pagegenerators.py b/pywikibot/pagegenerators.py
index b0c6dab..9111a1d 100644
--- a/pywikibot/pagegenerators.py
+++ b/pywikibot/pagegenerators.py
@@ -69,291 +69,300 @@
 GENERATOR OPTIONS
 =
 
--cat  Work on all pages which are in a specific category.
-  Argument can also be given as "-cat:categoryname" or
-  as "-cat:categoryname|fromtitle" (using # instead of |
-  is also allowed in this one and the following)
+-catWork on all pages which are in a specific category.
+Argument can also be given as "-cat:categoryname" or
+as "-cat:categoryname|fromtitle" (using # instead of |
+is also allowed in this one and the following)
 
--catr Like -cat, but also recursively includes pages in
-  subcategories, sub-subcategories etc. of the
-  given category.
-  Argument can also be given as "-catr:categoryname" or
-  as "-catr:categoryname|fromtitle".
+-catr   Like -cat, but also recursively includes pages in
+subcategories, sub-subcategories etc. of the
+given category.
+Argument can also be given as "-catr:categoryname" or
+as "-catr:categoryname|fromtitle".
 
--subcats  Work on all subcategories of a specific category.
-  Argument can also be given as "-subcats:categoryname" or
-  as "-subcats:categoryname|fromtitle".
+-subcatsWork on all subcategories of a specific category.
+Argument can also be given as "-subcats:categoryname" or
+as "-subcats:categoryname|fromtitle".
 
--subcatsr Like -subcats, but also includes sub-subcategories etc. of
-  the given category.
-  Argument can also be given as "-subcatsr:categoryname" or
-  as "-subcatsr:categoryname|fromtitle".
+-subcatsr   Like -subcats, but also includes sub-subcategories etc. of
+the given category.
+Argument can also be given as "-subcatsr:categoryname" or
+as "-subcatsr:categoryname|fromtitle".
 
--uncatWork on all pages which are not categorised.
+-uncat  Work on all pages which are not categorised.
 
--uncatcat Work on all categories which are not categorised.
+-uncatcat   Work on all categories which are not categorised.
 
--uncatfiles   Work on all files which are not categorised.
+-uncatfiles Work on all files which are not categorised.
 
--file Read a list of pages to treat from the named text file.
-  Page titles in the file may be either enclosed with
-  [[brackets]], or be separated by new lines.
-  Argument can also be given as "-file:filename".
+-file   Read a list of pages to treat from the named text file.
+Page titles in the file may be either enclosed with
+[[brackets]], or be separated by new lines.
+Argument can also be given as "-file:filename".
 
--filelinksWork on all pages that use a certain image/media file.
-  Argument can also be given as "-filelinks:filename".
+-filelinks  Work on all pages that use a certain image/media file.
+Argument can also be given as "-filelinks:filename".
 
--search   Work on all pages that are found in a MediaWiki search
-  across all namespaces.
+-search Work on all pages that are found in a MediaWiki search
+across all namespaces.
 
--logeventsWork on articles that were on a specified Special:Log.
-  The value may be a comma separated list of these values:
+-logevents  Work on articles that were on a specified Special:Log.
+The value may be a comma separated list of these values:
 
-  logevent,username,start,end
+logevent,username,start,end
 
-  or for backward compatibility:
+or for backward compatibility:
 
-

[MediaWiki-commits] [Gerrit] mediawiki...FanBoxes[master]: Add missing qqq message documentation

2017-10-21 Thread Umherirrender (Code Review)

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/385798 )

Change subject: Add missing qqq message documentation
..

Add missing qqq message documentation

Activate banana checker

Change-Id: Ia06f77edde664ba7d0c327cd605e63b516679562
---
M Gruntfile.js
M i18n/qqq.json
M package.json
3 files changed, 75 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/FanBoxes 
refs/changes/98/385798/1

diff --git a/Gruntfile.js b/Gruntfile.js
index 2ea9e32..36b6671 100644
--- a/Gruntfile.js
+++ b/Gruntfile.js
@@ -2,7 +2,7 @@
 module.exports = function ( grunt ) {
grunt.loadNpmTasks( 'grunt-contrib-jshint' );
grunt.loadNpmTasks( 'grunt-jsonlint' );
-   // grunt.loadNpmTasks( 'grunt-banana-checker' );
+   grunt.loadNpmTasks( 'grunt-banana-checker' );
 
grunt.initConfig( {
jshint: {
@@ -14,9 +14,9 @@
'!node_modules/**'
]
},
-   /* banana: {
+   banana: {
all: 'i18n/'
-   }, */
+   },
jsonlint: {
all: [
'**/*.json',
@@ -25,6 +25,6 @@
}
} );
 
-   grunt.registerTask( 'test', [ 'jshint', 'jsonlint' /* 'banana' */ ] );
+   grunt.registerTask( 'test', [ 'jshint', 'jsonlint', 'banana' ] );
grunt.registerTask( 'default', 'test' );
 };
diff --git a/i18n/qqq.json b/i18n/qqq.json
index 22f100e..62d244a 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -4,6 +4,76 @@
]
},
"fanbox-desc": 
"{{desc|name=FanBoxes|url=https://www.mediawiki.org/wiki/Extension:FanBoxes}};,
+   "fanbox-add": "A button text",
+   "fanbox-addtext": "A button text",
+   "fanbox-categories-help": "A help text",
+   "fanbox-categories-label": "A label message",
+   "fanbox-choose-another": "An error message",
+   "fanbox-create-button": "A button text",
+   "fanbox-created-by": "A label message",
+   "fanbox-hash": "An error message",
+   "fanbox-members": "A description message",
+   "fanbox-mustenter-left": "An error message",
+   "fanbox-mustenter-right": "An error message",
+   "fanbox-mustenter-right-or": "An error message",
+   "fanbox-mustenter-title": "An error message",
+   "fanbox-perma": "A navigation link",
+   "fanbox-prev": "A navigation link",
+   "fanbox-next": "A navigation link",
+   "fan-addfan-title": "A page title",
+   "fan-createfor": "A page title",
+   "fan-createfannotloggedin": "An error message",
+   "fan-updatefan": "A page title",
+   "fanbox-instructions": "A description message",
+   "fanbox-title": "A header text",
+   "fanbox-leftsidetext": "A help message",
+   "fanbox-display-image": "A link text",
+   "fanbox-close-image": "A link text",
+   "fanbox-leftsideinstructions": "A help message",
+   "fanbox-rightsidetext": "A help message",
+   "fanbox-rightsideinstructions": "A help message",
+   "fanbox-charsleft": "A hint message",
+   "fanbox-leftbg-color": "A label message",
+   "fanbox-lefttext-color": "A label message",
+   "fanbox-rightbg-color": "A label message",
+   "fanbox-righttext-color": "A label message",
+   "fanbox-leftsideimage": "A help message",
+   "fanbox-leftsideimageinstructions": "A help message",
+   "fanboxes-maxchars-sixty": "A hint message",
+   "fanbox-upload-image-button": "A button text",
+   "fanbox-upload-new-image": "A button text",
+   "fanbox-update-button": "A button text",
+   "fanbox-userdoesnotexist": "An error message",
+   "fanbox-woops": "An error message",
+   "fanbox-userbox-category": "A category name",
+   "fanbox-summary-new": "An edit summary",
+   "fanbox-summary-update": "An edit summary",
+   "fan-addfan-exists": "Right text",
+   "f-list-title": "A page title",
+   "f-back-link": "A navigation link",
+   "f-count": "A description text",
+   "fan-embed": "A link text",
+   "fan-add-colors": "A link text",
+   "fanbox-remove": "A link text",
+   "fanbox-remove-fanbox": "A confirm message",
+   "fanbox-add-fanbox": "A confirm message",
+   "fanbox-add-fanbox-login": "A message shown to anon",
+   "fanbox-nav-header": "A header text",
+   "top-fanboxes-link": "A link text",
+   "most-recent-fanboxes-link": "A page title",
+   "fanbox-successful-add": "A success message",
+   "fanbox-successful-remove": "A success message",
+   "fanbox-users-with-fanbox": "A header text",
+   "fanbox-users-with-fanbox-message": "A description text",
+   "fanbox-woops-title": "A page title",
+   "user-fanbox-title": "A page title",
+   "topuserboxes": "{{doc-special}}",
+

[MediaWiki-commits] [Gerrit] translatewiki[master]: Re-enable Special:AdvancedTranslate on translatewiki.net

2017-10-21 Thread Zoranzoki21 (Code Review)

Hello Mjbmr, jenkins-bot, Siebrand, Nikerabbit,

I'd like you to do a code review.  Please visit

https://gerrit.wikimedia.org/r/385797

to review the following change.


Change subject: Re-enable Special:AdvancedTranslate on translatewiki.net
..

Re-enable Special:AdvancedTranslate on translatewiki.net

Bug: T109235
This reverts commit 63c90e2932b562a6ffa7ccca5f74698359dacd4b.

Change-Id: I7c024621545fcbce29228fc762c62e10e5fe1072
---
M TranslateSettings.php
1 file changed, 1 insertion(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/translatewiki 
refs/changes/97/385797/1

diff --git a/TranslateSettings.php b/TranslateSettings.php
index 0effbde..26fb806 100644
--- a/TranslateSettings.php
+++ b/TranslateSettings.php
@@ -4,8 +4,7 @@
 
 $GROUPS = __DIR__ . '/groups';
 
-// 2015-05-18 Really broken now. Disabled.
-//$wgSpecialPages['Magic'] = 'SpecialMagic';
+$wgSpecialPages['Magic'] = 'SpecialMagic';
 $wgTranslateNewsletterPreference = true;
 
 $wgTranslateCacheDirectory = "/resources/caches/translatewiki.net";

-- 
To view, visit https://gerrit.wikimedia.org/r/385797
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7c024621545fcbce29228fc762c62e10e5fe1072
Gerrit-PatchSet: 1
Gerrit-Project: translatewiki
Gerrit-Branch: master
Gerrit-Owner: Zoranzoki21 
Gerrit-Reviewer: Mjbmr 
Gerrit-Reviewer: Nikerabbit 
Gerrit-Reviewer: Siebrand 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...parsoid[master]: Linter: Provide accurate DSR offsets for issues in extension...

2017-10-21 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/384198 )

Change subject: Linter: Provide accurate DSR offsets for issues in extension 
content
..


Linter: Provide accurate DSR offsets for issues in extension content

* DSR info was being blindly updated to entire extension range
  instead of looking inside the extension content.

* If looking inside the extension content doesn't yield a valid dsr,
  it falls back to the currently existing mode of returning DSR for
  the extension use.

* Simplified some code structure as well.

* Updated mocha test that now has updated DSR offsets.

Bug: T178217
Change-Id: I7d99c1771fb4d55866d296ecd283202bfc62a8ed
---
M lib/wt2html/pp/handlers/linter.js
M tests/mocha/linter.js
2 files changed, 66 insertions(+), 97 deletions(-)

Approvals:
  jenkins-bot: Verified
  Arlolra: Looks good to me, approved



diff --git a/lib/wt2html/pp/handlers/linter.js 
b/lib/wt2html/pp/handlers/linter.js
index fbd4d24..87d1ba0 100644
--- a/lib/wt2html/pp/handlers/linter.js
+++ b/lib/wt2html/pp/handlers/linter.js
@@ -145,6 +145,10 @@
  * @return {string}
  */
 function findEnclosingTemplateName(env, tplInfo) {
+   if (!tplInfo) {
+   return undefined;
+   }
+
var typeOf = tplInfo.first.getAttribute('typeof');
if (!/(?:^|\s)mw:Transclusion(?=$|\s)/.test(typeOf)) {
return undefined;
@@ -161,6 +165,14 @@
return { name: name };
} else {
return { multiPartTemplateBlock: true };
+   }
+}
+
+function findLintDSR(tplLintInfo, tplInfo, nodeDSR, updateNodeDSR) {
+   if (tplLintInfo || (tplInfo && !Util.isValidDSR(nodeDSR))) {
+   return tplInfo.dsr;
+   } else {
+   return updateNodeDSR ? updateNodeDSR(nodeDSR) : nodeDSR;
}
 }
 
@@ -223,22 +235,13 @@
return;
}
 
-   var cNodeName = c.nodeName.toLowerCase();
-   var dsr = dp.dsr;
+   var templateInfo = findEnclosingTemplateName(env, tplInfo);
+   // During DSR computation, stripped meta tags
+   // surrender their width to its previous sibling.
+   // We record the original DSR in the tmp attribute
+   // for that reason.
+   var dsr = findLintDSR(templateInfo, tplInfo, dp.tmp.origDSR || dp.dsr);
var lintObj;
-   var templateInfo;
-
-   if (tplInfo) {
-   dsr = tplInfo.dsr;
-   templateInfo = findEnclosingTemplateName(env, tplInfo);
-   } else if (dp.tmp.origDSR) {
-   // During DSR computation, stripped meta tags
-   // surrender their width to its previous sibling.
-   // We record the original DSR in the tmp attribute
-   // for that reason.
-   dsr = dp.tmp.origDSR;
-   }
-
if (DU.isMarkerMeta(c, 'mw:Placeholder/StrippedTag')) {
lintObj = { dsr: dsr, templateInfo: templateInfo, params: { 
name: dp.name } };
env.log('lint/stripped-tag', lintObj);
@@ -254,6 +257,7 @@
// 3. c is not a HTML element (unless they are i/b quotes)
//
// 4. c doesn't have DSR info and doesn't come from a template either
+   var cNodeName = c.nodeName.toLowerCase();
if (!Util.isVoidElement(cNodeName) &&
cNodeName !== 'tbody' &&
(DU.hasLiteralHTMLMarker(dp) || DU.isQuoteElt(c)) &&
@@ -347,8 +351,6 @@
  * Comment out this whole thing to satisfy eslint
  *
 function logIgnoredTableAttr(env, node, dp, tplInfo) {
-   var dsr;
-   var templateInfo;
if (!node.nodeName === 'TABLE') {
return;
}
@@ -365,13 +367,8 @@
if (!re.test(key) || 
!re.test(dp.sa[key])) {
// FIXME: This is incorrect.
// We need to check if the key 
is absent in dp.a / in the node's attribute
-   if (tplInfo) {
-   dsr = tplInfo.dsr;
-   templateInfo = 
findEnclosingTemplateName(env, tplInfo);
-   } else {
-   dsr = dp.dsr;
-   }
-   var lintObj = { dsr: dsr, 
templateInfo: templateInfo };
+   var templateInfo = 
findEnclosingTemplateName(env, tplInfo);
+   var lintObj = { dsr: 
findLintDSR(templateInfo, tplInfo, dp.dsr), templateInfo: templateInfo };

env.log('lint/ignored-table-attr', lintObj);
}
}

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Use LogFormatter::getLinkRenderer in LogFormatter extensions

2017-10-21 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/364111 )

Change subject: Use LogFormatter::getLinkRenderer in LogFormatter extensions
..


Use LogFormatter::getLinkRenderer in LogFormatter extensions

And additionally, migrate another two usages of deprecated
Linker methods.

Bug: T149346
Change-Id: I222da144a37f7d77eaf4bdde901b58c992f1af85
---
M includes/logging/BlockLogFormatter.php
M includes/logging/ContentModelLogFormatter.php
M includes/logging/DeleteLogFormatter.php
M includes/logging/LogFormatter.php
M includes/logging/MergeLogFormatter.php
M includes/logging/MoveLogFormatter.php
M includes/logging/PatrolLogFormatter.php
M includes/logging/ProtectLogFormatter.php
8 files changed, 14 insertions(+), 22 deletions(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/logging/BlockLogFormatter.php 
b/includes/logging/BlockLogFormatter.php
index a0bfb59..25589de 100644
--- a/includes/logging/BlockLogFormatter.php
+++ b/includes/logging/BlockLogFormatter.php
@@ -22,8 +22,6 @@
  * @since 1.25
  */
 
-use MediaWiki\MediaWikiServices;
-
 /**
  * This class formats block log entries.
  *
@@ -99,7 +97,7 @@
 
public function getActionLinks() {
$subtype = $this->entry->getSubtype();
-   $linkRenderer = 
MediaWikiServices::getInstance()->getLinkRenderer();
+   $linkRenderer = $this->getLinkRenderer();
if ( $this->entry->isDeleted( LogPage::DELETED_ACTION ) // 
Action is hidden
|| !( $subtype === 'block' || $subtype === 'reblock' )
|| !$this->context->getUser()->isAllowed( 'block' )
diff --git a/includes/logging/ContentModelLogFormatter.php 
b/includes/logging/ContentModelLogFormatter.php
index 861ea30..e05357c 100644
--- a/includes/logging/ContentModelLogFormatter.php
+++ b/includes/logging/ContentModelLogFormatter.php
@@ -1,7 +1,5 @@
 context->getLanguage();
@@ -20,7 +18,7 @@
}
 
$params = $this->extractParameters();
-   $revert = 
MediaWikiServices::getInstance()->getLinkRenderer()->makeKnownLink(
+   $revert = $this->getLinkRenderer()->makeKnownLink(
SpecialPage::getTitleFor( 'ChangeContentModel' ),
$this->msg( 'logentry-contentmodel-change-revertlink' 
)->text(),
[],
diff --git a/includes/logging/DeleteLogFormatter.php 
b/includes/logging/DeleteLogFormatter.php
index ceb0052..ef00634 100644
--- a/includes/logging/DeleteLogFormatter.php
+++ b/includes/logging/DeleteLogFormatter.php
@@ -23,8 +23,6 @@
  * @since 1.22
  */
 
-use MediaWiki\MediaWikiServices;
-
 /**
  * This class formats delete log entries.
  *
@@ -135,7 +133,7 @@
 
public function getActionLinks() {
$user = $this->context->getUser();
-   $linkRenderer = 
MediaWikiServices::getInstance()->getLinkRenderer();
+   $linkRenderer = $this->getLinkRenderer();
if ( !$user->isAllowed( 'deletedhistory' )
|| $this->entry->isDeleted( LogPage::DELETED_ACTION )
) {
diff --git a/includes/logging/LogFormatter.php 
b/includes/logging/LogFormatter.php
index 2a47943..ed65af8 100644
--- a/includes/logging/LogFormatter.php
+++ b/includes/logging/LogFormatter.php
@@ -644,12 +644,13 @@
 * @return string
 */
protected function makePageLink( Title $title = null, $parameters = [], 
$html = null ) {
+   if ( !$title instanceof Title ) {
+   throw new MWException( 'Expected title, got null' );
+   }
if ( !$this->plaintext ) {
-   $link = Linker::link( $title, $html, [], $parameters );
+   $html = $html !== null ? new HtmlArmor( $html ) : $html;
+   $link = $this->getLinkRenderer()->makeLink( $title, 
$html, [], $parameters );
} else {
-   if ( !$title instanceof Title ) {
-   throw new MWException( "Expected title, got 
null" );
-   }
$link = '[[' . $title->getPrefixedText() . ']]';
}
 
diff --git a/includes/logging/MergeLogFormatter.php 
b/includes/logging/MergeLogFormatter.php
index b0edd4c..8775097 100644
--- a/includes/logging/MergeLogFormatter.php
+++ b/includes/logging/MergeLogFormatter.php
@@ -54,9 +54,9 @@
 
// Show unmerge link
$params = $this->extractParameters();
-   $revert = Linker::linkKnown(
+   $revert = $this->getLinkRenderer()->makeKnownLink(
SpecialPage::getTitleFor( 'MergeHistory' ),
-   $this->msg( 'revertmerge' )->escaped(),
+   $this->msg( 'revertmerge' )->text(),

[MediaWiki-commits] [Gerrit] mediawiki...FileExporter[master]: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0

2017-10-21 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/385778 )

Change subject: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
..


build: Updating mediawiki/mediawiki-codesniffer to 14.1.0

And moved phpcs.xml to .phpcs.xml (T177256).

Change-Id: I4835f31e9844028f3a1815f8a4154b4db3eed675
---
R .phpcs.xml
M composer.json
2 files changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/phpcs.xml b/.phpcs.xml
similarity index 100%
rename from phpcs.xml
rename to .phpcs.xml
diff --git a/composer.json b/composer.json
index c5ef5fc..f31d942 100644
--- a/composer.json
+++ b/composer.json
@@ -1,7 +1,7 @@
 {
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
-   "mediawiki/mediawiki-codesniffer": "13.0.0",
+   "mediawiki/mediawiki-codesniffer": "14.1.0",
"jakub-onderka/php-console-highlighter": "0.3.2"
},
"scripts": {

-- 
To view, visit https://gerrit.wikimedia.org/r/385778
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4835f31e9844028f3a1815f8a4154b4db3eed675
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/FileExporter
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 
Gerrit-Reviewer: Addshore 
Gerrit-Reviewer: Andrew-WMDE 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: Tobias Gritschacher 
Gerrit-Reviewer: WMDE-Fisch 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: labs: Disable reverted and wp10 in enwiki

2017-10-21 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/385794 )

Change subject: labs: Disable reverted and wp10 in enwiki
..


labs: Disable reverted and wp10 in enwiki

Change-Id: I424c56b36876ba268178b3c285040be2a2e84591
---
M wmf-config/InitialiseSettings-labs.php
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Ladsgroup: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/wmf-config/InitialiseSettings-labs.php 
b/wmf-config/InitialiseSettings-labs.php
index adc0951..6d234ef 100644
--- a/wmf-config/InitialiseSettings-labs.php
+++ b/wmf-config/InitialiseSettings-labs.php
@@ -667,6 +667,8 @@
'damaging' => true,
'goodfaith' => true,
'draftquality' => true,
+   'reverted' => false,
+   'wp10' => false,
],
],
'wgOresDraftQualityNS' => [

-- 
To view, visit https://gerrit.wikimedia.org/r/385794
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I424c56b36876ba268178b3c285040be2a2e84591
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Ladsgroup 
Gerrit-Reviewer: Ladsgroup 
Gerrit-Reviewer: Urbanecm 
Gerrit-Reviewer: Zoranzoki21 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...ParserMigration[master]: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0

2017-10-21 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/385777 )

Change subject: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
..


build: Updating mediawiki/mediawiki-codesniffer to 14.1.0

And moved phpcs.xml to .phpcs.xml (T177256).

Change-Id: I407aa7f71e20fe0bc1135f45f3dea3b348363102
---
R .phpcs.xml
M composer.json
2 files changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/phpcs.xml b/.phpcs.xml
similarity index 100%
rename from phpcs.xml
rename to .phpcs.xml
diff --git a/composer.json b/composer.json
index d980e06..8976ec9 100644
--- a/composer.json
+++ b/composer.json
@@ -1,7 +1,7 @@
 {
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
-   "mediawiki/mediawiki-codesniffer": "13.0.0",
+   "mediawiki/mediawiki-codesniffer": "14.1.0",
"jakub-onderka/php-console-highlighter": "0.3.2"
},
"scripts": {

-- 
To view, visit https://gerrit.wikimedia.org/r/385777
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I407aa7f71e20fe0bc1135f45f3dea3b348363102
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ParserMigration
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...FileAnnotations[master]: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0

2017-10-21 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/385781 )

Change subject: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
..


build: Updating mediawiki/mediawiki-codesniffer to 14.1.0

And moved phpcs.xml to .phpcs.xml (T177256).

Change-Id: Ib72d6c6d39cf3a4eb1686e682ce3e842740302d9
---
R .phpcs.xml
M composer.json
2 files changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/phpcs.xml b/.phpcs.xml
similarity index 100%
rename from phpcs.xml
rename to .phpcs.xml
diff --git a/composer.json b/composer.json
index d980e06..8976ec9 100644
--- a/composer.json
+++ b/composer.json
@@ -1,7 +1,7 @@
 {
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
-   "mediawiki/mediawiki-codesniffer": "13.0.0",
+   "mediawiki/mediawiki-codesniffer": "14.1.0",
"jakub-onderka/php-console-highlighter": "0.3.2"
},
"scripts": {

-- 
To view, visit https://gerrit.wikimedia.org/r/385781
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib72d6c6d39cf3a4eb1686e682ce3e842740302d9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/FileAnnotations
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...AdminLinks[master]: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0

2017-10-21 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/385780 )

Change subject: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
..


build: Updating mediawiki/mediawiki-codesniffer to 14.1.0

And moved phpcs.xml to .phpcs.xml (T177256).

Change-Id: I5659186a5031c379183d4b3cc4dbe27a5daea339
---
R .phpcs.xml
M composer.json
2 files changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/phpcs.xml b/.phpcs.xml
similarity index 100%
rename from phpcs.xml
rename to .phpcs.xml
diff --git a/composer.json b/composer.json
index 7575813..e1ff922 100644
--- a/composer.json
+++ b/composer.json
@@ -26,7 +26,7 @@
},
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
-   "mediawiki/mediawiki-codesniffer": "13.0.0",
+   "mediawiki/mediawiki-codesniffer": "14.1.0",
"jakub-onderka/php-console-highlighter": "0.3.2"
},
"scripts": {

-- 
To view, visit https://gerrit.wikimedia.org/r/385780
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5659186a5031c379183d4b3cc4dbe27a5daea339
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/AdminLinks
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Newsletter[master]: Refactor newsletter create-udpate codebase

2017-10-21 Thread 01tonythomas (Code Review)

01tonythomas has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/385796 )

Change subject: Refactor newsletter create-udpate codebase
..

Refactor newsletter create-udpate codebase

* Avoid code repition
* Cut down huge ugly functions

Bug: T178743

Change-Id: I067c52036cb20b7a35f7530b1aac0807b2e6ecdb
---
M includes/Newsletter.php
M includes/NewsletterEditPage.php
M includes/content/NewsletterDataUpdate.php
3 files changed, 88 insertions(+), 65 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Newsletter 
refs/changes/96/385796/1

diff --git a/includes/Newsletter.php b/includes/Newsletter.php
index 7c19753..c9bebcb 100644
--- a/includes/Newsletter.php
+++ b/includes/Newsletter.php
@@ -248,4 +248,25 @@
public function canRestore( User $user ) {
return $this->isPublisher( $user ) || $user->isAllowed( 
'newsletter-restore' );
}
+
+   /**
+* Notify new publishers
+*
+* @param array $added
+* @param User $addedBy
+*
+*/
+   public function notifyNewPublishers( array $added, User $addedBy ) {
+   EchoEvent::create(
+   [
+   'type' => 'newsletter-newpublisher',
+   'extra' => [
+   'newsletter-name' => $this->getName(),
+   'new-publishers-id' => $added,
+   'newsletter-id' => $this->getId()
+   ],
+   'agent' => $addedBy
+   ]
+   );
+   }
 }
diff --git a/includes/NewsletterEditPage.php b/includes/NewsletterEditPage.php
index 8cb8793..d39a25c 100644
--- a/includes/NewsletterEditPage.php
+++ b/includes/NewsletterEditPage.php
@@ -96,6 +96,7 @@
 * @param int $undoId
 * @param int $oldId
 * @return HTMLForm
+* @throws BadRequestError
 */
protected function getManageForm( $revId, $undoId, $oldId ) {
$publishers = UserArray::newFromIDs( 
$this->newsletter->getPublishers() );
@@ -416,17 +417,7 @@
}
 
if ( $added ) {
-   EchoEvent::create(
-   [
-   'type' => 'newsletter-newpublisher',
-   'extra' => [
-   'newsletter-name' => 
$this->newsletter->getName(),
-   'new-publishers-id' => $added,
-   'newsletter-id' => $newsletterId
-   ],
-   'agent' => $user
-   ]
-   );
+   $this->newsletter->notifyNewPublishers( $added, $user );
}
 
foreach ( $removed as $ruId ) {
diff --git a/includes/content/NewsletterDataUpdate.php 
b/includes/content/NewsletterDataUpdate.php
index 945f00f..61c84d8 100644
--- a/includes/content/NewsletterDataUpdate.php
+++ b/includes/content/NewsletterDataUpdate.php
@@ -26,64 +26,85 @@
$this->title = $title;
}
 
-   function doUpdate() {
-   $logger = LoggerFactory::getInstance( 'newsletter' );
+   private function getNewsletterLogger() {
+   return LoggerFactory::getInstance( 'newsletter' );
+   }
 
+   protected function getNewslettersWithNewsletterMainPage( 
$newNewsletterName ) {
+   $dbr = wfGetDB( DB_REPLICA );
+   return $dbr->selectRowCount(
+   'nl_newsletters',
+   [ 'nl_name', 'nl_main_page_id', 'nl_active' ],
+   $dbr->makeList( [
+   'nl_name' => $newNewsletterName,
+   $dbr->makeList(
+   [
+   'nl_main_page_id' => 
$this->content->getMainPage()->getArticleID(),
+   'nl_active' => 1
+   ], LIST_AND )
+   ], LIST_OR )
+   );
+   }
+
+   protected function createANewNewsletterWithData( NewsletterStore 
$store, $formData ) {
+   $newNewsletterName = $formData['Name'];
+   if ( $this->getNewslettersWithNewsletterMainPage( 
$newNewsletterName ) ) {
+   return false;
+   }
+
+   $validator = new NewsletterValidator( $formData );
+   $validation = $validator->validate( true );
+
+   if ( !$validation->isGood() ) {
+   // Invalid input was entered
+   return $validation;
+

[MediaWiki-commits] [Gerrit] mediawiki...apex[master]: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0

2017-10-21 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/385774 )

Change subject: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
..


build: Updating mediawiki/mediawiki-codesniffer to 14.1.0

And moved phpcs.xml to .phpcs.xml (T177256).

Change-Id: Ic2c4c5a02844ca0f56fe9ca79b7020abceb64ec5
---
R .phpcs.xml
M composer.json
2 files changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/phpcs.xml b/.phpcs.xml
similarity index 100%
rename from phpcs.xml
rename to .phpcs.xml
diff --git a/composer.json b/composer.json
index 3ec375d..95bdb5f 100644
--- a/composer.json
+++ b/composer.json
@@ -1,7 +1,7 @@
 {
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
-   "mediawiki/mediawiki-codesniffer": "13.0.0",
+   "mediawiki/mediawiki-codesniffer": "14.1.0",
"jakub-onderka/php-console-highlighter": "0.3.2"
},
"scripts": {

-- 
To view, visit https://gerrit.wikimedia.org/r/385774
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic2c4c5a02844ca0f56fe9ca79b7020abceb64ec5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/apex
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: Umherirrender 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...BlogPage[master]: Add missing qqq message documentation

2017-10-21 Thread Umherirrender (Code Review)

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/385795 )

Change subject: Add missing qqq message documentation
..

Add missing qqq message documentation

Activate banana checker


Change-Id: I6adafe44f838bff9f3e50e19cd5eb7c2ebbf1888
---
M Gruntfile.js
M i18n/qqq.json
M package.json
3 files changed, 76 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/BlogPage 
refs/changes/95/385795/1

diff --git a/Gruntfile.js b/Gruntfile.js
index 265c39e..16c4c55 100644
--- a/Gruntfile.js
+++ b/Gruntfile.js
@@ -2,6 +2,7 @@
 module.exports = function ( grunt ) {
grunt.loadNpmTasks( 'grunt-contrib-jshint' );
grunt.loadNpmTasks( 'grunt-jsonlint' );
+   grunt.loadNpmTasks( 'grunt-banana-checker' );
 
grunt.initConfig( {
jshint: {
@@ -12,6 +13,9 @@
'**/*.js'
]
},
+   banana: {
+   all: 'i18n/'
+   },
jsonlint: {
all: [
'**/*.json',
@@ -21,6 +25,6 @@
}
} );
 
-   grunt.registerTask( 'test', [ 'jsonlint', 'jshint' ] );
+   grunt.registerTask( 'test', [ 'jsonlint', 'jshint', 'banana' ] );
grunt.registerTask( 'default', 'test' );
 };
diff --git a/i18n/qqq.json b/i18n/qqq.json
index 49621f1..2877b18 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -2,5 +2,73 @@
"@metadata": {
"authors": []
},
-   "blogpage-desc": 
"{{desc|name=BlogPage|url=https://www.mediawiki.org/wiki/Extension:BlogPage}};
-}
\ No newline at end of file
+   "blogpage-desc": 
"{{desc|name=BlogPage|url=https://www.mediawiki.org/wiki/Extension:BlogPage}};,
+   "apihelp-blogpage-description": "{{doc-apihelp-description|blogpage}}",
+   "apihelp-blogpage-summary": "{{doc-apihelp-summary|blogpage}}",
+   "apihelp-blogpage-param-pageName": 
"{{doc-apihelp-param|blogpage|pageName}}",
+   "apihelp-blogpage-example-1": "{{doc-apihelp-example}}",
+   "blog-and": "A word combination word",
+   "blog-anonymous-name": "A user name",
+   "blog-author-comments": "A list item",
+   "blog-author-more-by": "A header text",
+   "blog-author-points": "May unused",
+   "blog-author-title": "A header text",
+   "blog-author-votes": "A list item",
+   "blog-by": "A word combination word",
+   "blog-by-user-category": "A category name",
+   "blog-comments-of-day": "A header text",
+   "blog-created": "A text with date and time of last edit",
+   "blog-created-ago": "A text with date and time of last edit",
+   "blog-in-the-news": "A header text",
+   "blog-last-edited": "A text with date and time of last edit",
+   "blog-login": "Shown for anon user",
+   "blog-login-edit": "Shown for anon user",
+   "blog-new-articles": "A header text",
+   "blog-permission-required": "An error message",
+   "blog-popular-articles": "A header text",
+   "blog-multiple-authors": "A hint text when there are more results",
+   "blog-recent-editors": "A header text",
+   "blog-recent-editors-message": "A description message",
+   "blog-recent-voters": "A header text",
+   "blog-recent-voters-message": "A description message",
+   "blog-view-archive-link": "A link text",
+   "game-unit-quiz-title": "A page header",
+   "game-unit-poll-title": "A page header",
+   "game-unit-picturegame-title": "A page header",
+   "articlelists": "{{doc-special}}",
+   "ah-no-results": "A hint for an empty result",
+   "ah-popular-articles": "A page title",
+   "ah-new-articles": "A page title",
+   "ah-rss-feed": "A link text",
+   "ah-write-article": "A link text",
+   "ah-todays-articles": "A link text",
+   "ah-most-votes": "A header text",
+   "ah-what-talking-about": "A header text",
+   "articleshome": "{{doc-special}}",
+   "createblogpost": "{{doc-special}}",
+   "blog-create-rules": "{{ignore}}",
+   "blog-tagcloud-blacklist": "{{ignore}}",
+   "blog-create-category-help": "A help text",
+   "blog-create-title": "A page header",
+   "blog-create-text": "A description text",
+   "blog-create-categories": "A title text",
+   "blog-create-button": "A button text",
+   "blog-create-summary": "An edit summary",
+   "blog-create-error-need-content": "An error message",
+   "blog-create-error-need-title": "An error message",
+   "blog-create-error-page-exists": "An error message",
+   "blog-js-create-error-need-content": "An error message",
+   "blog-js-create-error-need-title": "An error message",
+   "blog-js-create-error-page-exists": "An error message",
+   "blog-more": "A link text",
+   "blog-time-ago": "Phrase for

[MediaWiki-commits] [Gerrit] mediawiki...MassMessage[master]: Fix typo in message key names for log-action-filter-*

2017-10-21 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/384949 )

Change subject: Fix typo in message key names for log-action-filter-*
..


Fix typo in message key names for log-action-filter-*

Bug: T169824
Change-Id: I657e0c07a8f9b777daf3176484cef623d47bb60b
---
M i18n/en.json
M i18n/qqq.json
2 files changed, 10 insertions(+), 10 deletions(-)

Approvals:
  D3r1ck01: Looks good to me, but someone else must approve
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/i18n/en.json b/i18n/en.json
index cfa08ca..6ad3369 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -131,9 +131,9 @@
"tag-massmessage-delivery": "MassMessage delivery",
"tag-massmessage-delivery-description": "Message delivery using 
[[:mw:Extension:MassMessage|Extension:MassMessage]]",
"log-action-filter-massmessage": "Type of log entry",
-   "log-action-filter-massmassage-send": "Mass message submission",
-   "log-action-filter-massmassage-failure": "Mass message delivery 
failure",
-   "log-action-filter-massmassage-skipoptout": "Target skip because of 
opt-out",
-   "log-action-filter-massmassage-skipnouser": "Target skip because of 
non-existing target user",
-   "log-action-filter-massmassage-skipbadns": "Target skip because of 
forbidden namespace"
+   "log-action-filter-massmessage-send": "Mass message submission",
+   "log-action-filter-massmessage-failure": "Mass message delivery 
failure",
+   "log-action-filter-massmessage-skipoptout": "Target skip because of 
opt-out",
+   "log-action-filter-massmessage-skipnouser": "Target skip because of 
non-existing target user",
+   "log-action-filter-massmessage-skipbadns": "Target skip because of 
forbidden namespace"
 }
diff --git a/i18n/qqq.json b/i18n/qqq.json
index 862539d..0f9bef5 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -137,9 +137,9 @@
"tag-massmessage-delivery": "Change tag for MassMessage delivery edits",
"tag-massmessage-delivery-description": "Description for MassMessage 
delivery change tag",
"log-action-filter-massmessage": 
"{{doc-log-action-filter-type|massmessage}}",
-   "log-action-filter-massmassage-send": 
"{{doc-log-action-filter-type|massmessage|send}}",
-   "log-action-filter-massmassage-failure": 
"{{doc-log-action-filter-type|massmessage|failure}}",
-   "log-action-filter-massmassage-skipoptout": 
"{{doc-log-action-filter-type|massmessage|skipoptout}}",
-   "log-action-filter-massmassage-skipnouser": 
"{{doc-log-action-filter-type|massmessage|skipnouser}}",
-   "log-action-filter-massmassage-skipbadns": 
"{{doc-log-action-filter-type|massmessage|skipbadns}}"
+   "log-action-filter-massmessage-send": 
"{{doc-log-action-filter-type|massmessage|send}}",
+   "log-action-filter-massmessage-failure": 
"{{doc-log-action-filter-type|massmessage|failure}}",
+   "log-action-filter-massmessage-skipoptout": 
"{{doc-log-action-filter-type|massmessage|skipoptout}}",
+   "log-action-filter-massmessage-skipnouser": 
"{{doc-log-action-filter-type|massmessage|skipnouser}}",
+   "log-action-filter-massmessage-skipbadns": 
"{{doc-log-action-filter-type|massmessage|skipbadns}}"
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/384949
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I657e0c07a8f9b777daf3176484cef623d47bb60b
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/MassMessage
Gerrit-Branch: master
Gerrit-Owner: Noella94 
Gerrit-Reviewer: D3r1ck01 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: Siebrand 
Gerrit-Reviewer: Wctaiwan 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...LinkedWiki[master]: Fix RDFunit special page

2017-10-21 Thread Karima Rafes (Code Review)

Karima Rafes has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/385793 )

Change subject: Fix RDFunit special page
..


Fix RDFunit special page

Change-Id: I56e4a75986b5885c720d03a41cd7228a6a48ca2b
---
M specialpages/SpecialRDFUnit.php
1 file changed, 3 insertions(+), 2 deletions(-)

Approvals:
  Karima Rafes: Verified; Looks good to me, approved
  jenkins-bot: Checked



diff --git a/specialpages/SpecialRDFUnit.php b/specialpages/SpecialRDFUnit.php
index c7c00c6..6367070 100644
--- a/specialpages/SpecialRDFUnit.php
+++ b/specialpages/SpecialRDFUnit.php
@@ -242,10 +242,11 @@
 $graphOfDataset = $configDefaultSaveData;
 $graphOfDatasetFileForRDFUnit = "";
 if (preg_match("#//(.*)#", $graphOfDataset, $matches)) {
-$graphOfDatasetFileForRDFUnit = str_replace("/","_",$matches[1]);
+$removeChars = array("/", ":", "#");
+$graphOfDatasetFileForRDFUnit = 
str_replace($removeChars,"_",$matches[1]);
 }
 
-$resultTestCase = 
"/RDFUnit/data/results/".$graphOfDatasetFileForRDFUnit.".shaclFullTestCaseResult.html";
+$resultTestCase = 
"/RDFUnit/data/results/".$graphOfDatasetFileForRDFUnit.".shaclTestCaseResult.html";
 $dbTestCase = 
"/RDFUnit/cache/sparql/".$graphOfDatasetFileForRDFUnit.".mv.db";
 $endpointOfDatasetPublic = 
$configSaveData->getInstanceEndpoint()->getEndpointRead();
 $endpointOfDataset = 
$configSaveData->getInstanceEndpoint()->getEndpointRead();

-- 
To view, visit https://gerrit.wikimedia.org/r/385793
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I56e4a75986b5885c720d03a41cd7228a6a48ca2b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/LinkedWiki
Gerrit-Branch: master
Gerrit-Owner: Karima Rafes 
Gerrit-Reviewer: Karima Rafes 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: labs: Disable reverted and wp10 in enwiki

2017-10-21 Thread Ladsgroup (Code Review)

Ladsgroup has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/385794 )

Change subject: labs: Disable reverted and wp10 in enwiki
..

labs: Disable reverted and wp10 in enwiki

Change-Id: I424c56b36876ba268178b3c285040be2a2e84591
---
M wmf-config/InitialiseSettings-labs.php
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/94/385794/1

diff --git a/wmf-config/InitialiseSettings-labs.php 
b/wmf-config/InitialiseSettings-labs.php
index adc0951..6d234ef 100644
--- a/wmf-config/InitialiseSettings-labs.php
+++ b/wmf-config/InitialiseSettings-labs.php
@@ -667,6 +667,8 @@
'damaging' => true,
'goodfaith' => true,
'draftquality' => true,
+   'reverted' => false,
+   'wp10' => false,
],
],
'wgOresDraftQualityNS' => [

-- 
To view, visit https://gerrit.wikimedia.org/r/385794
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I424c56b36876ba268178b3c285040be2a2e84591
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Ladsgroup 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...LinkedWiki[master]: Fix RDFunit special page

2017-10-21 Thread Karima Rafes (Code Review)

Karima Rafes has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/385793 )

Change subject: Fix RDFunit special page
..

Fix RDFunit special page

Change-Id: I56e4a75986b5885c720d03a41cd7228a6a48ca2b
---
M specialpages/SpecialRDFUnit.php
1 file changed, 3 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/LinkedWiki 
refs/changes/93/385793/1

diff --git a/specialpages/SpecialRDFUnit.php b/specialpages/SpecialRDFUnit.php
index c7c00c6..6367070 100644
--- a/specialpages/SpecialRDFUnit.php
+++ b/specialpages/SpecialRDFUnit.php
@@ -242,10 +242,11 @@
 $graphOfDataset = $configDefaultSaveData;
 $graphOfDatasetFileForRDFUnit = "";
 if (preg_match("#//(.*)#", $graphOfDataset, $matches)) {
-$graphOfDatasetFileForRDFUnit = str_replace("/","_",$matches[1]);
+$removeChars = array("/", ":", "#");
+$graphOfDatasetFileForRDFUnit = 
str_replace($removeChars,"_",$matches[1]);
 }
 
-$resultTestCase = 
"/RDFUnit/data/results/".$graphOfDatasetFileForRDFUnit.".shaclFullTestCaseResult.html";
+$resultTestCase = 
"/RDFUnit/data/results/".$graphOfDatasetFileForRDFUnit.".shaclTestCaseResult.html";
 $dbTestCase = 
"/RDFUnit/cache/sparql/".$graphOfDatasetFileForRDFUnit.".mv.db";
 $endpointOfDatasetPublic = 
$configSaveData->getInstanceEndpoint()->getEndpointRead();
 $endpointOfDataset = 
$configSaveData->getInstanceEndpoint()->getEndpointRead();

-- 
To view, visit https://gerrit.wikimedia.org/r/385793
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I56e4a75986b5885c720d03a41cd7228a6a48ca2b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/LinkedWiki
Gerrit-Branch: master
Gerrit-Owner: Karima Rafes 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...codesniffer[master]: Move phpcs.xml to .phpcs.xml

2017-10-21 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/385770 )

Change subject: Move phpcs.xml to .phpcs.xml
..


Move phpcs.xml to .phpcs.xml

Bug: T177256
Change-Id: I1eb15198bf57f81573f7b415d9186130c9f60658
---
M .gitattributes
R .phpcs.xml
M README.md
M utils/bootstrap-ci.php
4 files changed, 5 insertions(+), 5 deletions(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/.gitattributes b/.gitattributes
index 842b122..1c4de30 100644
--- a/.gitattributes
+++ b/.gitattributes
@@ -2,7 +2,7 @@
 .gitignore export-ignore
 .gitreview export-ignore
 composer.json export-ignore
-phpcs.xml export-ignore
+.phpcs.xml export-ignore
 phpunit.bootstrap.php export-ignore
 phpunit.xml.dist export-ignore
 TestHelper.php export-ignore
diff --git a/phpcs.xml b/.phpcs.xml
similarity index 100%
rename from phpcs.xml
rename to .phpcs.xml
diff --git a/README.md b/README.md
index e8e05fe..3f370c2 100644
--- a/README.md
+++ b/README.md
@@ -25,7 +25,7 @@
}
 }
 ```
-2. Create a phpcs.xml with our configuration:
+2. Create a .phpcs.xml with our configuration:
 
 ```
 
diff --git a/utils/bootstrap-ci.php b/utils/bootstrap-ci.php
index e2fdd6c..1ab6920 100644
--- a/utils/bootstrap-ci.php
+++ b/utils/bootstrap-ci.php
@@ -41,8 +41,8 @@
return;
 }
 
-# Changes to phpcs.xml affect all files
-if ( in_array( 'phpcs.xml', $_head_files ) ) {
+# Changes to phpcs.xml or .phpcs.xml affect all files
+if ( in_array( 'phpcs.xml', $_head_files ) || in_array( '.phpcs.xml', 
$_head_files ) ) {
unset( $_head_files );
unset( $_return );
return;
@@ -72,7 +72,7 @@
}
 }
 
-# Only keep files out of git head that matches phpcs.xml extensions.
+# Only keep files out of git head that matches phpcs.xml/.phpcs.xml extensions.
 $_extensions = array_keys( $this->config->extensions );
 $this->config->files = array_filter(
$_head_files,

-- 
To view, visit https://gerrit.wikimedia.org/r/385770
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1eb15198bf57f81573f7b415d9186130c9f60658
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/tools/codesniffer
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 
Gerrit-Reviewer: Addshore 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] pywikibot/core[master]: [DOC] Fix header and change sorting order

2017-10-21 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/370176 )

Change subject: [DOC] Fix header and change sorting order
..


[DOC] Fix header and change sorting order

Change-Id: I26b2b3fdb9b7f70f0d9b7d7b4a708781ab1044ee
---
M docs/api_ref/pywikibot.comms.rst
1 file changed, 6 insertions(+), 6 deletions(-)

Approvals:
  jenkins-bot: Verified
  Xqt: Looks good to me, approved
  Zoranzoki21: Looks good to me, but someone else must approve



diff --git a/docs/api_ref/pywikibot.comms.rst b/docs/api_ref/pywikibot.comms.rst
index 39ccc28..e4aeccb 100644
--- a/docs/api_ref/pywikibot.comms.rst
+++ b/docs/api_ref/pywikibot.comms.rst
@@ -9,18 +9,18 @@
 Submodules
 --
 
-pywikibot.comms.http module

+pywikibot.comms.eventstreams module
+---
 
-.. automodule:: pywikibot.comms.http
+.. automodule:: pywikibot.comms.eventstreams
 :members:
 :undoc-members:
 :show-inheritance:
 
-pywikibot.comms.eventstreams module

+pywikibot.comms.http module
+---
 
-.. automodule:: pywikibot.comms.eventstreams
+.. automodule:: pywikibot.comms.http
 :members:
 :undoc-members:
 :show-inheritance:

-- 
To view, visit https://gerrit.wikimedia.org/r/370176
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I26b2b3fdb9b7f70f0d9b7d7b4a708781ab1044ee
Gerrit-PatchSet: 3
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Xqt 
Gerrit-Reviewer: John Vandenberg 
Gerrit-Reviewer: Magul 
Gerrit-Reviewer: Xqt 
Gerrit-Reviewer: Zoranzoki21 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...ORES[master]: Fix CheckModelVersions maintenance script

2017-10-21 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/385790 )

Change subject: Fix CheckModelVersions maintenance script
..


Fix CheckModelVersions maintenance script

$wgOresWikiId can be null, using the proper method to get wiki id

Change-Id: Ic4a49b176da6c6551ddaf79215ad62e5af1032e3
---
M maintenance/CheckModelVersions.php
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  jenkins-bot: Verified
  Halfak: Looks good to me, approved



diff --git a/maintenance/CheckModelVersions.php 
b/maintenance/CheckModelVersions.php
index f9b9c04..c5f365d 100644
--- a/maintenance/CheckModelVersions.php
+++ b/maintenance/CheckModelVersions.php
@@ -61,16 +61,16 @@
 * @throws \RuntimeException
 */
protected function getModels() {
-   global $wgOresWikiId;
+   $wikiId = Api::getWikiID();
$timestamp = \wfTimestampNow();
$api = new Api();
// Bypass the varnish cache
$modelData = $api->request( [ $timestamp => true ] );
-   if ( !isset( $modelData[$wgOresWikiId] ) || empty( 
$modelData[$wgOresWikiId]['models'] ) ) {
+   if ( !isset( $modelData[$wikiId] ) || empty( 
$modelData[$wikiId]['models'] ) ) {
throw new \RuntimeException( 'Bad response from ORES 
when requesting models: '
. json_encode( $modelData ) );
}
-   return $modelData[$wgOresWikiId]['models'];
+   return $modelData[$wikiId]['models'];
}
 
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/385790
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic4a49b176da6c6551ddaf79215ad62e5af1032e3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ORES
Gerrit-Branch: master
Gerrit-Owner: Ladsgroup 
Gerrit-Reviewer: Halfak 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...LinkedWiki[master]: Fix RDFunit special page

2017-10-21 Thread Karima Rafes (Code Review)

Karima Rafes has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/385792 )

Change subject: Fix RDFunit special page
..


Fix RDFunit special page

Change-Id: I71f63e92dd282bab79fc7fe906dccd3d81075f43
---
M specialpages/SpecialRDFUnit.php
1 file changed, 4 insertions(+), 4 deletions(-)

Approvals:
  Karima Rafes: Verified; Looks good to me, approved
  jenkins-bot: Checked



diff --git a/specialpages/SpecialRDFUnit.php b/specialpages/SpecialRDFUnit.php
index ff45bd3..c7c00c6 100644
--- a/specialpages/SpecialRDFUnit.php
+++ b/specialpages/SpecialRDFUnit.php
@@ -40,7 +40,7 @@
 * @param array $query associative array of query string parameters
 * @param string $prefix top level prefix
 * @param string $arg_separator argument separator to use (by default 
the INI setting arg_separator.output will be used, or "&" if neither is set
-* @return string Returns the built query as string on success or FALSE 
on failure. 
+* @return string Returns the built query as string on success or FALSE 
on failure.
 */
function http_build_str(array $query, $prefix = '', $arg_separator = 
null)
{
@@ -247,10 +247,10 @@
 
 $resultTestCase = 
"/RDFUnit/data/results/".$graphOfDatasetFileForRDFUnit.".shaclFullTestCaseResult.html";
 $dbTestCase = 
"/RDFUnit/cache/sparql/".$graphOfDatasetFileForRDFUnit.".mv.db";
-$endpointOfDatasetPublic = 
$configSaveData->getInstanceEndpoint()->getEndpointQuery();
-$endpointOfDataset = 
$configSaveData->getInstanceEndpoint()->getEndpointQuery();
+$endpointOfDatasetPublic = 
$configSaveData->getInstanceEndpoint()->getEndpointRead();
+$endpointOfDataset = 
$configSaveData->getInstanceEndpoint()->getEndpointRead();
if (! EMPTY($configSaveData->getInstanceEndpoint()->getLogin())){
-   $endpointOfDataset = 
http_build_url($configSaveData->getInstanceEndpoint()->getEndpointQuery(),
+   $endpointOfDataset = 
http_build_url($configSaveData->getInstanceEndpoint()->getEndpointRead(),
array(
"user" => 
$configSaveData->getInstanceEndpoint()->getLogin(),
"pass" => 
$configSaveData->getInstanceEndpoint()->getPassword()

-- 
To view, visit https://gerrit.wikimedia.org/r/385792
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I71f63e92dd282bab79fc7fe906dccd3d81075f43
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/LinkedWiki
Gerrit-Branch: master
Gerrit-Owner: Karima Rafes 
Gerrit-Reviewer: Karima Rafes 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...LinkedWiki[master]: Fix RDFunit special page

2017-10-21 Thread Karima Rafes (Code Review)

Karima Rafes has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/385792 )

Change subject: Fix RDFunit special page
..

Fix RDFunit special page

Change-Id: I71f63e92dd282bab79fc7fe906dccd3d81075f43
---
M specialpages/SpecialRDFUnit.php
1 file changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/LinkedWiki 
refs/changes/92/385792/1

diff --git a/specialpages/SpecialRDFUnit.php b/specialpages/SpecialRDFUnit.php
index ff45bd3..c7c00c6 100644
--- a/specialpages/SpecialRDFUnit.php
+++ b/specialpages/SpecialRDFUnit.php
@@ -40,7 +40,7 @@
 * @param array $query associative array of query string parameters
 * @param string $prefix top level prefix
 * @param string $arg_separator argument separator to use (by default 
the INI setting arg_separator.output will be used, or "&" if neither is set
-* @return string Returns the built query as string on success or FALSE 
on failure. 
+* @return string Returns the built query as string on success or FALSE 
on failure.
 */
function http_build_str(array $query, $prefix = '', $arg_separator = 
null)
{
@@ -247,10 +247,10 @@
 
 $resultTestCase = 
"/RDFUnit/data/results/".$graphOfDatasetFileForRDFUnit.".shaclFullTestCaseResult.html";
 $dbTestCase = 
"/RDFUnit/cache/sparql/".$graphOfDatasetFileForRDFUnit.".mv.db";
-$endpointOfDatasetPublic = 
$configSaveData->getInstanceEndpoint()->getEndpointQuery();
-$endpointOfDataset = 
$configSaveData->getInstanceEndpoint()->getEndpointQuery();
+$endpointOfDatasetPublic = 
$configSaveData->getInstanceEndpoint()->getEndpointRead();
+$endpointOfDataset = 
$configSaveData->getInstanceEndpoint()->getEndpointRead();
if (! EMPTY($configSaveData->getInstanceEndpoint()->getLogin())){
-   $endpointOfDataset = 
http_build_url($configSaveData->getInstanceEndpoint()->getEndpointQuery(),
+   $endpointOfDataset = 
http_build_url($configSaveData->getInstanceEndpoint()->getEndpointRead(),
array(
"user" => 
$configSaveData->getInstanceEndpoint()->getLogin(),
"pass" => 
$configSaveData->getInstanceEndpoint()->getPassword()

-- 
To view, visit https://gerrit.wikimedia.org/r/385792
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I71f63e92dd282bab79fc7fe906dccd3d81075f43
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/LinkedWiki
Gerrit-Branch: master
Gerrit-Owner: Karima Rafes 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] wikidata/build-resources[master]: Do not load ValueView extension

2017-10-21 Thread WMDE-leszek (Code Review)

WMDE-leszek has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/385791 )

Change subject: Do not load ValueView extension
..

Do not load ValueView extension

It is no longer an extension, but a lib, which is included
by Wikibase extension.

Bug: T178739
Depends-On: I4ac2518123148699173a45c18693494d63a200bb
Change-Id: Ia93147c1ec94278bb6c25d2480e87b0d8b143f40
---
M Wikidata.localisation.php
1 file changed, 0 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/wikidata/build-resources 
refs/changes/91/385791/1

diff --git a/Wikidata.localisation.php b/Wikidata.localisation.php
index e166629..b005d15 100644
--- a/Wikidata.localisation.php
+++ b/Wikidata.localisation.php
@@ -19,6 +19,5 @@
 require_once "$wgWikidataBaseDir/extensions/Quality/WikibaseQuality.php";
 require_once 
"$wgWikidataBaseDir/extensions/Constraints/WikibaseQualityConstraints.php";
 require_once 
"$wgWikidataBaseDir/extensions/ArticlePlaceholder/ArticlePlaceholder.php";
-require_once "$wgWikidataBaseDir/extensions/ValueView/ValueView.php";
 
 require_once "$wgWikidataBaseDir/Wikidata.credits.php";

-- 
To view, visit https://gerrit.wikimedia.org/r/385791
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia93147c1ec94278bb6c25d2480e87b0d8b143f40
Gerrit-PatchSet: 1
Gerrit-Project: wikidata/build-resources
Gerrit-Branch: master
Gerrit-Owner: WMDE-leszek 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...ORES[master]: Fix CheckModelVersions maintenance script

2017-10-21 Thread Ladsgroup (Code Review)

Ladsgroup has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/385790 )

Change subject: Fix CheckModelVersions maintenance script
..

Fix CheckModelVersions maintenance script

$wgOresWikiId can be null, using the proper method to get wiki id

Change-Id: Ic4a49b176da6c6551ddaf79215ad62e5af1032e3
---
M maintenance/CheckModelVersions.php
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ORES 
refs/changes/90/385790/1

diff --git a/maintenance/CheckModelVersions.php 
b/maintenance/CheckModelVersions.php
index f9b9c04..c5f365d 100644
--- a/maintenance/CheckModelVersions.php
+++ b/maintenance/CheckModelVersions.php
@@ -61,16 +61,16 @@
 * @throws \RuntimeException
 */
protected function getModels() {
-   global $wgOresWikiId;
+   $wikiId = Api::getWikiID();
$timestamp = \wfTimestampNow();
$api = new Api();
// Bypass the varnish cache
$modelData = $api->request( [ $timestamp => true ] );
-   if ( !isset( $modelData[$wgOresWikiId] ) || empty( 
$modelData[$wgOresWikiId]['models'] ) ) {
+   if ( !isset( $modelData[$wikiId] ) || empty( 
$modelData[$wikiId]['models'] ) ) {
throw new \RuntimeException( 'Bad response from ORES 
when requesting models: '
. json_encode( $modelData ) );
}
-   return $modelData[$wgOresWikiId]['models'];
+   return $modelData[$wikiId]['models'];
}
 
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/385790
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic4a49b176da6c6551ddaf79215ad62e5af1032e3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ORES
Gerrit-Branch: master
Gerrit-Owner: Ladsgroup 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] css-sanitizer[master]: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0

2017-10-21 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/385528 )

Change subject: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
..


build: Updating mediawiki/mediawiki-codesniffer to 14.1.0

And moved phpcs.xml to .phpcs.xml (T177256).

Change-Id: I11dae8308f1c49d576efb6dd29e5ec477da9
---
R .phpcs.xml
M composer.json
M src/Grammar/BlockMatcher.php
M src/Grammar/FunctionMatcher.php
M src/Grammar/Match.php
M src/Grammar/NothingMatcher.php
M src/Objects/Rule.php
M src/Objects/Stylesheet.php
M src/Parser/Parser.php
M src/Sanitizer/FontFeatureValueAtRuleSanitizer.php
M src/Sanitizer/ImportAtRuleSanitizer.php
M src/Sanitizer/MediaAtRuleSanitizer.php
M src/Sanitizer/PropertySanitizer.php
M tests/Grammar/CheckedMatcherTest.php
M tests/Grammar/UrlMatcherTest.php
M tests/Parser/ParserTest.php
M tests/Sanitizer/PropertySanitizerTest.php
M tests/Sanitizer/RuleSanitizerTestBase.php
M tests/Sanitizer/StylePropertySanitizerTest.php
19 files changed, 1 insertion(+), 21 deletions(-)

Approvals:
  Umherirrender: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/phpcs.xml b/.phpcs.xml
similarity index 100%
rename from phpcs.xml
rename to .phpcs.xml
diff --git a/composer.json b/composer.json
index ddf4a21..45a716a 100644
--- a/composer.json
+++ b/composer.json
@@ -28,7 +28,7 @@
},
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
-   "mediawiki/mediawiki-codesniffer": "0.12.0",
+   "mediawiki/mediawiki-codesniffer": "14.1.0",
"phpunit/phpunit": "4.8.31",
"wikimedia/testing-access-wrapper": "1.0.0"
},
diff --git a/src/Grammar/BlockMatcher.php b/src/Grammar/BlockMatcher.php
index 7126e7b..8126736 100644
--- a/src/Grammar/BlockMatcher.php
+++ b/src/Grammar/BlockMatcher.php
@@ -8,7 +8,6 @@
 
 use Wikimedia\CSS\Objects\ComponentValueList;
 use Wikimedia\CSS\Objects\SimpleBlock;
-use Wikimedia\CSS\Objects\Token;
 
 /**
  * Matcher that matches a SimpleBlock
diff --git a/src/Grammar/FunctionMatcher.php b/src/Grammar/FunctionMatcher.php
index c9584f0..cc03ad7 100644
--- a/src/Grammar/FunctionMatcher.php
+++ b/src/Grammar/FunctionMatcher.php
@@ -8,7 +8,6 @@
 
 use Wikimedia\CSS\Objects\ComponentValueList;
 use Wikimedia\CSS\Objects\CSSFunction;
-use Wikimedia\CSS\Objects\Token;
 
 /**
  * Matcher that matches a CSSFunction
diff --git a/src/Grammar/Match.php b/src/Grammar/Match.php
index c51b784..dc61bb6 100644
--- a/src/Grammar/Match.php
+++ b/src/Grammar/Match.php
@@ -8,8 +8,6 @@
 
 use Wikimedia\CSS\Objects\ComponentValue;
 use Wikimedia\CSS\Objects\ComponentValueList;
-use Wikimedia\CSS\Objects\CSSFunction;
-use Wikimedia\CSS\Objects\SimpleBlock;
 use Wikimedia\CSS\Objects\Token;
 use Wikimedia\CSS\Util;
 
diff --git a/src/Grammar/NothingMatcher.php b/src/Grammar/NothingMatcher.php
index 029cbff..8963aa5 100644
--- a/src/Grammar/NothingMatcher.php
+++ b/src/Grammar/NothingMatcher.php
@@ -6,7 +6,6 @@
 
 namespace Wikimedia\CSS\Grammar;
 
-use Wikimedia\CSS\Objects\ComponentValue;
 use Wikimedia\CSS\Objects\ComponentValueList;
 
 /**
diff --git a/src/Objects/Rule.php b/src/Objects/Rule.php
index cffe8cc..72e6350 100644
--- a/src/Objects/Rule.php
+++ b/src/Objects/Rule.php
@@ -6,8 +6,6 @@
 
 namespace Wikimedia\CSS\Objects;
 
-use Wikimedia\CSS\Util;
-
 /**
  * Represent an abstract CSS rule
  */
diff --git a/src/Objects/Stylesheet.php b/src/Objects/Stylesheet.php
index f8b9692..d99ed12 100644
--- a/src/Objects/Stylesheet.php
+++ b/src/Objects/Stylesheet.php
@@ -7,7 +7,6 @@
 namespace Wikimedia\CSS\Objects;
 
 use Wikimedia\CSS\Util;
-use Wikimedia\CSS\Sanitizer\Sanitizer;
 
 /**
  * Represent a stylesheet
diff --git a/src/Parser/Parser.php b/src/Parser/Parser.php
index 55368a4..f7d133c 100644
--- a/src/Parser/Parser.php
+++ b/src/Parser/Parser.php
@@ -19,7 +19,6 @@
 use Wikimedia\CSS\Objects\SimpleBlock;
 use Wikimedia\CSS\Objects\Stylesheet;
 use Wikimedia\CSS\Objects\Token;
-use Wikimedia\CSS\Sanitizer\Sanitizer;
 
 // Note: While reading the code below, you might find that my calls to
 // consumeToken() don't match what the spec says and I don't ever "reconsume" a
diff --git a/src/Sanitizer/FontFeatureValueAtRuleSanitizer.php 
b/src/Sanitizer/FontFeatureValueAtRuleSanitizer.php
index a9207fa..1be4ae7 100644
--- a/src/Sanitizer/FontFeatureValueAtRuleSanitizer.php
+++ b/src/Sanitizer/FontFeatureValueAtRuleSanitizer.php
@@ -9,7 +9,6 @@
 use Wikimedia\CSS\Grammar\Matcher;
 use Wikimedia\CSS\Objects\AtRule;
 use Wikimedia\CSS\Objects\CSSObject;
-use Wikimedia\CSS\Objects\ComponentValueList;
 use Wikimedia\CSS\Objects\DeclarationList;
 use Wikimedia\CSS\Objects\Rule;
 use Wikimedia\CSS\Parser\Parser;
diff --git a/src/Sanitizer/ImportAtRuleSanitizer.php 
b/src/Sanitizer/ImportAtRuleSanitizer.php
index c3360c3..b8ab1c6 100644
--- a/src/Sanitizer/ImportAtRuleSanitizer.php
+++

[MediaWiki-commits] [Gerrit] mediawiki...Wikisource[master]: Move phpcs.xml to .phpcs.xml

2017-10-21 Thread Umherirrender (Code Review)

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/385789 )

Change subject: Move phpcs.xml to .phpcs.xml
..

Move phpcs.xml to .phpcs.xml

See T177256

Change-Id: I45f8fa0790d81c647865bf35e3fb1dfdb6724c5e
---
R .phpcs.xml
1 file changed, 0 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikisource 
refs/changes/89/385789/1

diff --git a/phpcs.xml b/.phpcs.xml
similarity index 100%
rename from phpcs.xml
rename to .phpcs.xml

-- 
To view, visit https://gerrit.wikimedia.org/r/385789
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I45f8fa0790d81c647865bf35e3fb1dfdb6724c5e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikisource
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Move phpcs.xml to .phpcs.xml

2017-10-21 Thread Umherirrender (Code Review)

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/385788 )

Change subject: Move phpcs.xml to .phpcs.xml
..

Move phpcs.xml to .phpcs.xml

See T177256

Change-Id: I6830e5f4d7e3fa11b95fc0d12b57b48ffbc362fd
---
R .phpcs.xml
1 file changed, 0 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups 
refs/changes/88/385788/1

diff --git a/phpcs.xml b/.phpcs.xml
similarity index 100%
rename from phpcs.xml
rename to .phpcs.xml

-- 
To view, visit https://gerrit.wikimedia.org/r/385788
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6830e5f4d7e3fa11b95fc0d12b57b48ffbc362fd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...OpenLayers[master]: Move phpcs.xml to .phpcs.xml

2017-10-21 Thread Umherirrender (Code Review)

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/385787 )

Change subject: Move phpcs.xml to .phpcs.xml
..

Move phpcs.xml to .phpcs.xml

See T177256

Change-Id: I358a4407d16ccac4a27ce5545d382f1f6402d71a
---
R .phpcs.xml
1 file changed, 0 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/OpenLayers 
refs/changes/87/385787/1

diff --git a/phpcs.xml b/.phpcs.xml
similarity index 100%
rename from phpcs.xml
rename to .phpcs.xml

-- 
To view, visit https://gerrit.wikimedia.org/r/385787
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I358a4407d16ccac4a27ce5545d382f1f6402d71a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/OpenLayers
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...MixedNamespaceSearchSuggestions[master]: Move phpcs.xml to .phpcs.xml

2017-10-21 Thread Umherirrender (Code Review)

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/385786 )

Change subject: Move phpcs.xml to .phpcs.xml
..

Move phpcs.xml to .phpcs.xml

See T177256

Change-Id: Ia45a0bb9fbc7d0c6d55ab60c136f16e1de0a4f46
---
R .phpcs.xml
1 file changed, 0 insertions(+), 0 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MixedNamespaceSearchSuggestions
 refs/changes/86/385786/1

diff --git a/phpcs.xml b/.phpcs.xml
similarity index 100%
rename from phpcs.xml
rename to .phpcs.xml

-- 
To view, visit https://gerrit.wikimedia.org/r/385786
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia45a0bb9fbc7d0c6d55ab60c136f16e1de0a4f46
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MixedNamespaceSearchSuggestions
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...GlobalPreferences[master]: Move phpcs.xml to .phpcs.xml

2017-10-21 Thread Umherirrender (Code Review)

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/385785 )

Change subject: Move phpcs.xml to .phpcs.xml
..

Move phpcs.xml to .phpcs.xml

See T177256

Change-Id: Ice1f2ea590c8d405348b754c974a8340752ffe90
---
R .phpcs.xml
1 file changed, 0 insertions(+), 0 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/GlobalPreferences 
refs/changes/85/385785/1

diff --git a/phpcs.xml b/.phpcs.xml
similarity index 100%
rename from phpcs.xml
rename to .phpcs.xml

-- 
To view, visit https://gerrit.wikimedia.org/r/385785
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ice1f2ea590c8d405348b754c974a8340752ffe90
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/GlobalPreferences
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Genealogy[master]: Move phpcs.xml to .phpcs.xml

2017-10-21 Thread Umherirrender (Code Review)

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/385784 )

Change subject: Move phpcs.xml to .phpcs.xml
..

Move phpcs.xml to .phpcs.xml

See T177256

Change-Id: I513c33e2c845813aaae31d11250fc9a3f9acdf5a
---
R .phpcs.xml
1 file changed, 0 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Genealogy 
refs/changes/84/385784/1

diff --git a/phpcs.xml b/.phpcs.xml
similarity index 100%
rename from phpcs.xml
rename to .phpcs.xml

-- 
To view, visit https://gerrit.wikimedia.org/r/385784
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I513c33e2c845813aaae31d11250fc9a3f9acdf5a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Genealogy
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...BoilerPlate[master]: Move phpcs.xml to .phpcs.xml

2017-10-21 Thread Umherirrender (Code Review)

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/385783 )

Change subject: Move phpcs.xml to .phpcs.xml
..

Move phpcs.xml to .phpcs.xml

See T177256

Change-Id: I290706a9f642dbbf98928b9045e88bd02a44a949
---
R .phpcs.xml
1 file changed, 0 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/BoilerPlate 
refs/changes/83/385783/1

diff --git a/phpcs.xml b/.phpcs.xml
similarity index 100%
rename from phpcs.xml
rename to .phpcs.xml

-- 
To view, visit https://gerrit.wikimedia.org/r/385783
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I290706a9f642dbbf98928b9045e88bd02a44a949
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BoilerPlate
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...ArticleCreationWorkflow[master]: Move phpcs.xml to .phpcs.xml

2017-10-21 Thread Umherirrender (Code Review)

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/385782 )

Change subject: Move phpcs.xml to .phpcs.xml
..

Move phpcs.xml to .phpcs.xml

See T177256

Change-Id: I6797b82345b30ca9a2ecd436132991bc0a49cd6d
---
R .phpcs.xml
1 file changed, 0 insertions(+), 0 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ArticleCreationWorkflow 
refs/changes/82/385782/1

diff --git a/phpcs.xml b/.phpcs.xml
similarity index 100%
rename from phpcs.xml
rename to .phpcs.xml

-- 
To view, visit https://gerrit.wikimedia.org/r/385782
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6797b82345b30ca9a2ecd436132991bc0a49cd6d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ArticleCreationWorkflow
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...FileAnnotations[master]: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0

2017-10-21 Thread Umherirrender (Code Review)

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/385781 )

Change subject: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
..

build: Updating mediawiki/mediawiki-codesniffer to 14.1.0

And moved phpcs.xml to .phpcs.xml (T177256).

Change-Id: Ib72d6c6d39cf3a4eb1686e682ce3e842740302d9
---
R .phpcs.xml
M composer.json
2 files changed, 1 insertion(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/FileAnnotations 
refs/changes/81/385781/1

diff --git a/phpcs.xml b/.phpcs.xml
similarity index 100%
rename from phpcs.xml
rename to .phpcs.xml
diff --git a/composer.json b/composer.json
index d980e06..8976ec9 100644
--- a/composer.json
+++ b/composer.json
@@ -1,7 +1,7 @@
 {
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
-   "mediawiki/mediawiki-codesniffer": "13.0.0",
+   "mediawiki/mediawiki-codesniffer": "14.1.0",
"jakub-onderka/php-console-highlighter": "0.3.2"
},
"scripts": {

-- 
To view, visit https://gerrit.wikimedia.org/r/385781
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib72d6c6d39cf3a4eb1686e682ce3e842740302d9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/FileAnnotations
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...AdminLinks[master]: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0

2017-10-21 Thread Umherirrender (Code Review)

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/385780 )

Change subject: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
..

build: Updating mediawiki/mediawiki-codesniffer to 14.1.0

And moved phpcs.xml to .phpcs.xml (T177256).

Change-Id: I5659186a5031c379183d4b3cc4dbe27a5daea339
---
R .phpcs.xml
M composer.json
2 files changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/AdminLinks 
refs/changes/80/385780/1

diff --git a/phpcs.xml b/.phpcs.xml
similarity index 100%
rename from phpcs.xml
rename to .phpcs.xml
diff --git a/composer.json b/composer.json
index 7575813..e1ff922 100644
--- a/composer.json
+++ b/composer.json
@@ -26,7 +26,7 @@
},
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
-   "mediawiki/mediawiki-codesniffer": "13.0.0",
+   "mediawiki/mediawiki-codesniffer": "14.1.0",
"jakub-onderka/php-console-highlighter": "0.3.2"
},
"scripts": {

-- 
To view, visit https://gerrit.wikimedia.org/r/385780
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5659186a5031c379183d4b3cc4dbe27a5daea339
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/AdminLinks
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...FileImporter[master]: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0

2017-10-21 Thread Umherirrender (Code Review)

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/385779 )

Change subject: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
..

build: Updating mediawiki/mediawiki-codesniffer to 14.1.0

And moved phpcs.xml to .phpcs.xml (T177256).

Change-Id: I74c3c70441fefb849e2457559e132cd9d6aeb4bc
---
R .phpcs.xml
M composer.json
2 files changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/FileImporter 
refs/changes/79/385779/1

diff --git a/phpcs.xml b/.phpcs.xml
similarity index 100%
rename from phpcs.xml
rename to .phpcs.xml
diff --git a/composer.json b/composer.json
index c5ef5fc..f31d942 100644
--- a/composer.json
+++ b/composer.json
@@ -1,7 +1,7 @@
 {
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
-   "mediawiki/mediawiki-codesniffer": "13.0.0",
+   "mediawiki/mediawiki-codesniffer": "14.1.0",
"jakub-onderka/php-console-highlighter": "0.3.2"
},
"scripts": {

-- 
To view, visit https://gerrit.wikimedia.org/r/385779
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I74c3c70441fefb849e2457559e132cd9d6aeb4bc
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/FileImporter
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...FileExporter[master]: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0

2017-10-21 Thread Umherirrender (Code Review)

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/385778 )

Change subject: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
..

build: Updating mediawiki/mediawiki-codesniffer to 14.1.0

And moved phpcs.xml to .phpcs.xml (T177256).

Change-Id: I4835f31e9844028f3a1815f8a4154b4db3eed675
---
R .phpcs.xml
M composer.json
2 files changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/FileExporter 
refs/changes/78/385778/1

diff --git a/phpcs.xml b/.phpcs.xml
similarity index 100%
rename from phpcs.xml
rename to .phpcs.xml
diff --git a/composer.json b/composer.json
index c5ef5fc..f31d942 100644
--- a/composer.json
+++ b/composer.json
@@ -1,7 +1,7 @@
 {
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
-   "mediawiki/mediawiki-codesniffer": "13.0.0",
+   "mediawiki/mediawiki-codesniffer": "14.1.0",
"jakub-onderka/php-console-highlighter": "0.3.2"
},
"scripts": {

-- 
To view, visit https://gerrit.wikimedia.org/r/385778
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4835f31e9844028f3a1815f8a4154b4db3eed675
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/FileExporter
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...ParserMigration[master]: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0

2017-10-21 Thread Umherirrender (Code Review)

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/385777 )

Change subject: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
..

build: Updating mediawiki/mediawiki-codesniffer to 14.1.0

And moved phpcs.xml to .phpcs.xml (T177256).

Change-Id: I407aa7f71e20fe0bc1135f45f3dea3b348363102
---
R .phpcs.xml
M composer.json
2 files changed, 1 insertion(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ParserMigration 
refs/changes/77/385777/1

diff --git a/phpcs.xml b/.phpcs.xml
similarity index 100%
rename from phpcs.xml
rename to .phpcs.xml
diff --git a/composer.json b/composer.json
index d980e06..8976ec9 100644
--- a/composer.json
+++ b/composer.json
@@ -1,7 +1,7 @@
 {
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
-   "mediawiki/mediawiki-codesniffer": "13.0.0",
+   "mediawiki/mediawiki-codesniffer": "14.1.0",
"jakub-onderka/php-console-highlighter": "0.3.2"
},
"scripts": {

-- 
To view, visit https://gerrit.wikimedia.org/r/385777
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I407aa7f71e20fe0bc1135f45f3dea3b348363102
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ParserMigration
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Compilation Detail screen : should be scrollable only when r...

2017-10-21 Thread Yashasvi (Code Review)

Yashasvi has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/385776 )

Change subject: Compilation Detail screen : should be scrollable only when 
required
..

Compilation Detail screen : should be scrollable only when required

Bug: T174446
Change-Id: I61e03095858c8bbab9b6b3ad8a931416d909c38c
---
M app/src/main/res/layout/fragment_compilation_detail.xml
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia 
refs/changes/76/385776/1

diff --git a/app/src/main/res/layout/fragment_compilation_detail.xml 
b/app/src/main/res/layout/fragment_compilation_detail.xml
index 35ad49e..dbde3b1 100644
--- a/app/src/main/res/layout/fragment_compilation_detail.xml
+++ b/app/src/main/res/layout/fragment_compilation_detail.xml
@@ -60,13 +60,13 @@
 
 
 
 
 

-- 
To view, visit https://gerrit.wikimedia.org/r/385776
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I61e03095858c8bbab9b6b3ad8a931416d909c38c
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Yashasvi 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Wikidata[master]: New Wikidata Build - 2017-10-21T10:00:01+0000

2017-10-21 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/385772 )

Change subject: New Wikidata Build - 2017-10-21T10:00:01+
..


New Wikidata Build - 2017-10-21T10:00:01+

Change-Id: I75c1eb2e460c29c5f152bc62cd4be8eba1ec1279
---
M composer.lock
M extensions/Constraints/i18n/cs.json
M extensions/Wikibase/lib/i18n/cy.json
M extensions/Wikibase/repo/i18n/it.json
M vendor/composer/installed.json
5 files changed, 43 insertions(+), 15 deletions(-)

Approvals:
  WMDE-leszek: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/composer.lock b/composer.lock
index bc1df58..19af775 100644
--- a/composer.lock
+++ b/composer.lock
@@ -971,7 +971,7 @@
 "source": {
 "type": "git",
 "url": 
"https://gerrit.wikimedia.org/r/mediawiki/extensions/WikibaseQualityConstraints;,
-"reference": "0b42b96d328b7a2d7abcd168702b1d4e51b9794e"
+"reference": "01ab10567fe9260935b745a58f77edd60508f64b"
 },
 "require": {
 "php": ">=5.5.9",
@@ -1031,7 +1031,7 @@
 "support": {
 "issues": 
"https://phabricator.wikimedia.org/project/profile/1202/;
 },
-"time": "2017-10-19 21:29:54"
+"time": "2017-10-20 20:58:32"
 },
 {
 "name": "wikibase/data-model",
@@ -1542,12 +1542,12 @@
 "source": {
 "type": "git",
 "url": 
"https://github.com/wikimedia/mediawiki-extensions-Wikibase.git;,
-"reference": "e2397f95e4a71965f1bc60aa4a1e6d1e584819e4"
+"reference": "112d3c27c42fd9e8e50eb84e51a1864f1013f6e7"
 },
 "dist": {
 "type": "zip",
-"url": 
"https://api.github.com/repos/wikimedia/mediawiki-extensions-Wikibase/zipball/e2397f95e4a71965f1bc60aa4a1e6d1e584819e4;,
-"reference": "e2397f95e4a71965f1bc60aa4a1e6d1e584819e4",
+"url": 
"https://api.github.com/repos/wikimedia/mediawiki-extensions-Wikibase/zipball/112d3c27c42fd9e8e50eb84e51a1864f1013f6e7;,
+"reference": "112d3c27c42fd9e8e50eb84e51a1864f1013f6e7",
 "shasum": ""
 },
 "require": {
@@ -1626,7 +1626,7 @@
 "wikibaserepo",
 "wikidata"
 ],
-"time": "2017-10-20 09:32:04"
+"time": "2017-10-20 20:58:07"
 },
 {
 "name": "wikibase/wikimedia-badges",
diff --git a/extensions/Constraints/i18n/cs.json 
b/extensions/Constraints/i18n/cs.json
index 3d82d0e..62bf7ba 100644
--- a/extensions/Constraints/i18n/cs.json
+++ b/extensions/Constraints/i18n/cs.json
@@ -24,16 +24,24 @@
"wbqc-constraintreport-status-exception": "Výjimka",
"wbqc-constraintreport-status-todo": "Chybí",
"wbqc-constraintreport-status-bad-parameters": "Nesprávné parametry",
+   "wbqc-constraintreport-status-deprecated": "Zavržené",
+   "wbqc-constraintreport-status-warning": "Upozornění",
"wbqc-constraintreport-result-table-header-status": "Stav",
"wbqc-constraintreport-result-table-header-claim": "Tvrzení",
"wbqc-constraintreport-result-table-header-constraint": "Omezení",
"wbqc-constraintreport-result-link-to-claim": "přejít na tvrzení",
"wbqc-constraintreport-result-link-to-constraint": "přejít na omezení",
"wbqc-constraintreport-no-parameter": "není",
+   "wbqc-issues-short": "Problémy",
+   "wbqc-issues-long": "Tento výrok má určité problémy.",
"wbqc-potentialissues-short": "Možné problémy",
"wbqc-potentialissues-long": "Toto tvrzení může mít určité problémy.",
"wbqc-badparameters-short": "Chybné parametry",
"wbqc-badparameters-long": "Některé parametry tohoto tvrzení o omezení 
jsou neplatné.",
+   "wbqc-parameterissues-short": "Pokročilé nedostatky",
+   "wbqc-parameterissues-long": "Tyto nedostatky jsou problémy definice 
omezení na vlastnosti, nikoli tohoto výroku.",
+   "wbqc-constrainttypehelp-short": "Nápověda",
+   "wbqc-constrainttypehelp-long": "Stránka s nápovědou pro tento typ 
omezení",
"wbq-subextension-name-wbqc": "Omezení",
"wbqc-violation-header-parameters": "Parametry:",
"wbqc-violations-group": "Omezení",
@@ -52,10 +60,14 @@
"wbqc-violation-message-parameter-item": "Hodnota parametru „$1“ musí 
být položka, ne „$2“.",
"wbqc-violation-message-parameter-property": "Hodnota parametru „$1“ 
musí být vlastnost, nikoliv „$2“.",
"wbqc-violation-message-parameter-string": "Hodnota parametru „$1“ musí 
být řetězec, ne „$2“.",
+   "wbqc-violation-message-parameter-monolingualtext": "Hodnota parametru 
„$1“ musí být jednojazyčný text, nikoli „$2“.",
"wbqc-violation-message-parameter-single": "Parametr „$1“ může mít

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0

2017-10-21 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/385499 )

Change subject: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
..


build: Updating mediawiki/mediawiki-codesniffer to 14.1.0

And moved phpcs.xml to .phpcs.xml (T177256).

Change-Id: Idaa1fe006a528c25ce34abd0a857c657c26e8b0f
---
R .phpcs.xml
M composer.json
M includes/widget/search/InterwikiSearchResultSetWidget.php
M maintenance/language/transstat.php
4 files changed, 5 insertions(+), 3 deletions(-)

Approvals:
  Umherirrender: Looks good to me, approved
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/phpcs.xml b/.phpcs.xml
similarity index 96%
rename from phpcs.xml
rename to .phpcs.xml
index 4be45b1..3170381 100644
--- a/phpcs.xml
+++ b/.phpcs.xml
@@ -25,6 +25,8 @@



+   
+   



diff --git a/composer.json b/composer.json
index 7364506..a0fe9a2 100644
--- a/composer.json
+++ b/composer.json
@@ -54,7 +54,7 @@
"jakub-onderka/php-parallel-lint": "0.9.2",
"jetbrains/phpstorm-stubs": 
"dev-master#1b9906084d6635456fcf3f3a01f0d7d5b99a578a",
"justinrainbow/json-schema": "~5.2",
-   "mediawiki/mediawiki-codesniffer": "13.0.0",
+   "mediawiki/mediawiki-codesniffer": "14.1.0",
"monolog/monolog": "~1.22.1",
"nikic/php-parser": "2.1.0",
"nmred/kafka-php": "0.1.5",
diff --git a/includes/widget/search/InterwikiSearchResultSetWidget.php 
b/includes/widget/search/InterwikiSearchResultSetWidget.php
index 81a1a43..b4e3414 100644
--- a/includes/widget/search/InterwikiSearchResultSetWidget.php
+++ b/includes/widget/search/InterwikiSearchResultSetWidget.php
@@ -168,7 +168,7 @@
 *
 * @param string $iwPrefix Interwiki prefix
 * @return OOUI\IconWidget
-**/
+*/
protected function iwIcon( $iwPrefix ) {
$interwiki = $this->iwLookup->fetch( $iwPrefix );
$parsed = wfParseUrl( wfExpandUrl( $interwiki ? 
$interwiki->getURL() : '/' ) );
diff --git a/maintenance/language/transstat.php 
b/maintenance/language/transstat.php
index 7202952..986fa62 100644
--- a/maintenance/language/transstat.php
+++ b/maintenance/language/transstat.php
@@ -42,7 +42,7 @@
$options['output'] = 'wiki';
 }
 
-/** Print a usage message*/
+/** Print a usage message */
 function showUsage() {
print <
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: Paladox 
Gerrit-Reviewer: Reedy 
Gerrit-Reviewer: Umherirrender 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Timeless[master]: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0

2017-10-21 Thread Umherirrender (Code Review)

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/385775 )

Change subject: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
..

build: Updating mediawiki/mediawiki-codesniffer to 14.1.0

And moved phpcs.xml to .phpcs.xml (T177256).

Change-Id: I02f392fabe71a0425467a88f63fe9f6e18a98f5a
---
R .phpcs.xml
M TimelessTemplate.php
M composer.json
3 files changed, 12 insertions(+), 12 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/Timeless 
refs/changes/75/385775/1

diff --git a/phpcs.xml b/.phpcs.xml
similarity index 100%
rename from phpcs.xml
rename to .phpcs.xml
diff --git a/TimelessTemplate.php b/TimelessTemplate.php
index bee568c..d035e3b 100644
--- a/TimelessTemplate.php
+++ b/TimelessTemplate.php
@@ -119,16 +119,16 @@
 * @param string $name
 * @param array|string $content array of links for use with 
makeListItem, or a block of text
 *Expected array format:
-*  [
-*  $name => [
-*  'links' => [ '0' =>
-*  [ 'href' => ..., 'single-id' => ..., 
'text' => ... ]
-*  ],
-*  'id' => ...,
-*  'active' => ...
-*  ],
-*  ...
-*  ]
+*  [
+*  $name => [
+*  'links' => [ '0' =>
+*  [ 'href' => ..., 'single-id' => ..., 
'text' => ... ]
+*  ],
+*  'id' => ...,
+*  'active' => ...
+*  ],
+*  ...
+*  ]
 * @param null|string|array|bool $msg
 *
 * @return string html
@@ -393,7 +393,7 @@
 * Page tools in sidebar
 *
 * @return string html
-**/
+*/
protected function getPageToolSidebar() {
$pageTools = '';
if ( count( $this->pileOfTools['page-secondary'] ) > 0 ) {
diff --git a/composer.json b/composer.json
index 3ec375d..95bdb5f 100644
--- a/composer.json
+++ b/composer.json
@@ -1,7 +1,7 @@
 {
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
-   "mediawiki/mediawiki-codesniffer": "13.0.0",
+   "mediawiki/mediawiki-codesniffer": "14.1.0",
"jakub-onderka/php-console-highlighter": "0.3.2"
},
"scripts": {

-- 
To view, visit https://gerrit.wikimedia.org/r/385775
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I02f392fabe71a0425467a88f63fe9f6e18a98f5a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Timeless
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...apex[master]: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0

2017-10-21 Thread Umherirrender (Code Review)

Umherirrender has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/385774 )

Change subject: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
..

build: Updating mediawiki/mediawiki-codesniffer to 14.1.0

And moved phpcs.xml to .phpcs.xml (T177256).

Change-Id: Ic2c4c5a02844ca0f56fe9ca79b7020abceb64ec5
---
R .phpcs.xml
M composer.json
2 files changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/apex 
refs/changes/74/385774/1

diff --git a/phpcs.xml b/.phpcs.xml
similarity index 100%
rename from phpcs.xml
rename to .phpcs.xml
diff --git a/composer.json b/composer.json
index 3ec375d..95bdb5f 100644
--- a/composer.json
+++ b/composer.json
@@ -1,7 +1,7 @@
 {
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
-   "mediawiki/mediawiki-codesniffer": "13.0.0",
+   "mediawiki/mediawiki-codesniffer": "14.1.0",
"jakub-onderka/php-console-highlighter": "0.3.2"
},
"scripts": {

-- 
To view, visit https://gerrit.wikimedia.org/r/385774
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic2c4c5a02844ca0f56fe9ca79b7020abceb64ec5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/apex
Gerrit-Branch: master
Gerrit-Owner: Umherirrender 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...TimedMediaHandler[master]: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0

2017-10-21 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/385723 )

Change subject: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
..


build: Updating mediawiki/mediawiki-codesniffer to 14.1.0

And moved phpcs.xml to .phpcs.xml (T177256).

Change-Id: If0c670d31b525e969333df331edaae8cbfcb3fbb
---
R .phpcs.xml
M WebVideoTranscode/WebVideoTranscode.php
M WebVideoTranscode/WebVideoTranscodeJob.php
M composer.json
M handlers/OggHandler/OggHandler.php
M tests/phpunit/ApiTestCaseVideoUpload.php
M tests/phpunit/TestTimeParsing.php
7 files changed, 15 insertions(+), 15 deletions(-)

Approvals:
  Umherirrender: Looks good to me, approved
  Hashar: Looks good to me, approved
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/phpcs.xml b/.phpcs.xml
similarity index 100%
rename from phpcs.xml
rename to .phpcs.xml
diff --git a/WebVideoTranscode/WebVideoTranscode.php 
b/WebVideoTranscode/WebVideoTranscode.php
index b444c08..ce0a1f7 100644
--- a/WebVideoTranscode/WebVideoTranscode.php
+++ b/WebVideoTranscode/WebVideoTranscode.php
@@ -642,7 +642,7 @@
 * Grabs sources from the remote repo via ApiQueryVideoInfo.php entry 
point.
 *
 * TODO: This method could use some rethinking. See comments on PS1 of
-*   
+*   
 *
 * Because this works with commons regardless of whether 
TimedMediaHandler is installed or not
 * @param File &$file
diff --git a/WebVideoTranscode/WebVideoTranscodeJob.php 
b/WebVideoTranscode/WebVideoTranscodeJob.php
index cec23b2..6cfd250 100644
--- a/WebVideoTranscode/WebVideoTranscodeJob.php
+++ b/WebVideoTranscode/WebVideoTranscodeJob.php
@@ -954,11 +954,11 @@
}
 
/**
-   * Kill Application PID
-   *
-   * @param int $pid
-   * @return bool
-   */
+* Kill Application PID
+*
+* @param int $pid
+* @return bool
+*/
public static function killProcess( $pid ) {
exec( "kill -9 $pid" );
exec( "ps $pid", $processState );
diff --git a/composer.json b/composer.json
index 1ba520c..cf7b3d5 100644
--- a/composer.json
+++ b/composer.json
@@ -4,7 +4,7 @@
},
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
-   "mediawiki/mediawiki-codesniffer": "13.0.0",
+   "mediawiki/mediawiki-codesniffer": "14.1.0",
"jakub-onderka/php-console-highlighter": "0.3.2"
},
"scripts": {
diff --git a/handlers/OggHandler/OggHandler.php 
b/handlers/OggHandler/OggHandler.php
index 583c415..d2d0712 100644
--- a/handlers/OggHandler/OggHandler.php
+++ b/handlers/OggHandler/OggHandler.php
@@ -260,11 +260,11 @@
}
 
/**
-   * Get useful response headers for GET/HEAD requests for a file with the 
given metadata
-   * @param array $metadata Contains this handler's unserialized 
getMetadata() for a file
-   * @return Array
-   * @since 1.30
-   */
+* Get useful response headers for GET/HEAD requests for a file with 
the given metadata
+* @param array $metadata Contains this handler's unserialized 
getMetadata() for a file
+* @return Array
+* @since 1.30
+*/
public function getContentHeaders( $metadata ) {
$packedMetadata = $metadata;
$result = [];
diff --git a/tests/phpunit/ApiTestCaseVideoUpload.php 
b/tests/phpunit/ApiTestCaseVideoUpload.php
index 211bc4c..4cf98e1 100644
--- a/tests/phpunit/ApiTestCaseVideoUpload.php
+++ b/tests/phpunit/ApiTestCaseVideoUpload.php
@@ -51,7 +51,7 @@
 * Fixture -- run after every test
 * Clean up temporary files etc.
 *
-   */
+*/
protected function tearDown() {
parent::tearDown();
 
diff --git a/tests/phpunit/TestTimeParsing.php 
b/tests/phpunit/TestTimeParsing.php
index 3e6b558..968c8be 100644
--- a/tests/phpunit/TestTimeParsing.php
+++ b/tests/phpunit/TestTimeParsing.php
@@ -10,7 +10,7 @@
 class TestTimeParsing extends PHPUnit_Framework_TestCase {
/**
 * Test time string to np2
-   */
+*/
function testSeconds2NptFormat() {
// Some time conversions:
$this->assertEquals( TimedMediaHandler::seconds2npt( 100 ), 
'00:01:40' );
@@ -26,7 +26,7 @@
 
/**
 * Test time parsing to seconds
-   */
+*/
function testParseTimeString() {
// Some time conversions:
$this->assertEquals( TimedMediaHandler::parseTimeString( 100 ), 
100 );

-- 
To view, visit https://gerrit.wikimedia.org/r/385723
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...ProofreadPage[master]: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0

2017-10-21 Thread jenkins-bot (Code Review)

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/385690 )

Change subject: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
..


build: Updating mediawiki/mediawiki-codesniffer to 14.1.0

And moved phpcs.xml to .phpcs.xml (T177256).

Change-Id: I89e2403f7f8145188f0c008869c00e88618b345f
---
R .phpcs.xml
M composer.json
M includes/index/CustomIndexFieldsParser.php
3 files changed, 10 insertions(+), 10 deletions(-)

Approvals:
  Umherirrender: Looks good to me, approved
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/phpcs.xml b/.phpcs.xml
similarity index 100%
rename from phpcs.xml
rename to .phpcs.xml
diff --git a/composer.json b/composer.json
index a6aa35f..86524f0 100644
--- a/composer.json
+++ b/composer.json
@@ -9,7 +9,7 @@
},
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
-   "mediawiki/mediawiki-codesniffer": "13.0.0",
+   "mediawiki/mediawiki-codesniffer": "14.1.0",
"jakub-onderka/php-console-highlighter": "0.3.2"
},
"scripts": {
diff --git a/includes/index/CustomIndexFieldsParser.php 
b/includes/index/CustomIndexFieldsParser.php
index aabcab7..c7673b0 100644
--- a/includes/index/CustomIndexFieldsParser.php
+++ b/includes/index/CustomIndexFieldsParser.php
@@ -25,20 +25,20 @@
 * The configuration is a list of properties like this :
 * array(
 *  'ID' => array( //the property id
-*  'type' => 'string', //the property type (for 
compatibility reasons the values have not
+*  'type' => 'string', //the property type (for 
compatibility reasons the values have not
 *   //to be of this type). Possible values: string, 
number, page
-*  'size' => 1, //for type = string : the size of the form 
input
-*  'default' => '', //the default value
-*  'label' => 'ID', //the label of the property
-*  'help' => '', //a short help text
-*  'values' => null, //an array value => label that list 
the possible values
+*  'size' => 1, //for type = string : the size of the form 
input
+*  'default' => '', //the default value
+*  'label' => 'ID', //the label of the property
+*  'help' => '', //a short help text
+*  'values' => null, //an array value => label that list 
the possible values
 *   //(for compatibility reasons the stored values have 
not to be one of these)
-*  'header' => false, //give the content of this property 
to
+*  'header' => false, //give the content of this property 
to
 *   //Mediawiki:Proofreadpage_header_template as template 
parameter
-*  'hidden' => false //don't show the property in the 
index pages form. Useful for data
+*  'hidden' => false //don't show the property in the 
index pages form. Useful for data
 *   //that have always the same value (as language=en for 
en Wikisource) or are
 *   //only set at the  tag level.
-*  )
+*  )
 * );
 *  NB: The values set are the default values
 */

-- 
To view, visit https://gerrit.wikimedia.org/r/385690
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I89e2403f7f8145188f0c008869c00e88618b345f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ProofreadPage
Gerrit-Branch: master
Gerrit-Owner: Libraryupgrader 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: Umherirrender 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] pywikibot/core[master]: [bugfix] Use grnfilterredir for random pages

2017-10-21 Thread Xqt (Code Review)

Xqt has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/385773 )

Change subject: [bugfix] Use grnfilterredir for random pages
..

[bugfix] Use grnfilterredir for random pages

Bug: T178732
Change-Id: I0763cf99fd113cd25a0048d8a760b16fc4828346
---
M pywikibot/site.py
M tests/site_tests.py
2 files changed, 47 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core 
refs/changes/73/385773/1

diff --git a/pywikibot/site.py b/pywikibot/site.py
index 2e0895e..1a08666 100644
--- a/pywikibot/site.py
+++ b/pywikibot/site.py
@@ -4925,7 +4925,7 @@
 return usgen
 
 @deprecated('Site.randompages(total=1)')
-def randompage(self, redirect=False):
+def randompage(self, redirect=None):
 """
 DEPRECATED.
 
@@ -4934,18 +4934,18 @@
 """
 return self.randompages(total=1, redirects=redirect)
 
-@deprecated('Site.randompages(total=1, redirects=True)')
+@deprecated("Site.randompages(total=1, redirects='redirects')")
 def randomredirectpage(self):
 """
 DEPRECATED: Use Site.randompages() instead.
 
 @return: Return a random redirect page
 """
-return self.randompages(total=1, redirects=True)
+return self.randompages(total=1, redirects='redirects')
 
 @deprecated_args(step=None)
 def randompages(self, total=None, namespaces=None,
-redirects=False, content=False):
+redirects=None, content=False):
 """Iterate a number of random pages.
 
 Pages are listed in a fixed sequence, only the starting point is
@@ -4956,17 +4956,38 @@
 @type namespaces: iterable of basestring or Namespace key,
 or a single instance of those types. May be a '|' separated
 list of namespace identifiers.
-@param redirects: if True, include only redirect pages in results
-(default: include only non-redirects)
+@param redirects: if 'redirects, include only redirect pages in
+results, 'nonredirects' does not include redirects and 'all'
+include both types. (default: 'nonredirects')
+@type redirects: str (one of 'nonredirects', 'redirects', 'all')
 @param content: if True, load the current content of each iterated page
 (default False)
 @raises KeyError: a namespace identifier was not resolved
 @raises TypeError: a namespace identifier has an inappropriate
 type such as NoneType or bool
+@raises AssertError: unsupported redirects parameter
 """
+filteritems = ('nonredirects', 'redirects', 'all')
+if isinstance(redirects, bool):
+issue_deprecation_warning(
+'Parameter redirects={0}'.format(redirects),
+"redirects='{0}'".format(filteritems[redirects]) +
+('' if redirects else ' or redirects=None'), 2)
+redirects = filteritems[redirects]
+params = {}
+if redirects is not None:
+assert(redirects in filteritems)
+if MediaWikiVersion(self.version()) < MediaWikiVersion('1.26'):
+if redirects == 'all':
+warn("parameter redirects='all' is not supported by mw "
+ 'version {0}. Ignoring it.'.format(self.version()),
+ UserWarning)
+params['grnredirect'] = redirects == 'redirects'
+else:
+params['grnfilterredir'] = redirects
 rngen = self._generator(api.PageGenerator, type_arg="random",
 namespaces=namespaces, total=total,
-g_content=content, grnredirect=redirects)
+g_content=content, **params)
 return rngen
 
 # Catalog of editpage error codes, for use in generating messages.
diff --git a/tests/site_tests.py b/tests/site_tests.py
index 1b45692..3f1788d 100644
--- a/tests/site_tests.py
+++ b/tests/site_tests.py
@@ -28,6 +28,7 @@
 PY2,
 StringTypes as basestring,
 UnicodeType as unicode,
+suppress_warnings,
 )
 
 from tests import unittest_print
@@ -2002,10 +2003,27 @@
 def test_redirects(self):
 """Test site.randompages() with redirects."""
 mysite = self.get_site()
-for rndpage in mysite.randompages(total=5, redirects=True):
+for rndpage in mysite.randompages(total=5, redirects='redirects'):
 self.assertIsInstance(rndpage, pywikibot.Page)
 self.assertTrue(rndpage.isRedirectPage())
 
+def test_all(self):
+"""Test site.randompages() with 'all'."""
+mysite = self.get_site()
+for rndpage in mysite.randompages(total=5, redirects='all'):
+self.assertIsInstance(rndpage, pywikibot.Page)
+
+def test_deprecated_params(self):
+"""Test

1 2 3 >

1 - 100 of 280 matches

Mail list logo