[MediaWiki-commits] [Gerrit] Replace usage of SpecialPage::getTitle with getPageTitle - change (mediawiki...CommunityTwitter)
FastLizard4 has submitted this change and it was merged. Change subject: Replace usage of SpecialPage::getTitle with getPageTitle .. Replace usage of SpecialPage::getTitle with getPageTitle Was deprecated in 1.23, see Icdcf5d5295ef5e7f08b1d403e0c123f78738fd40 Change-Id: Icb4359c67abbf41d8c46881a6bd67e7c25f010f8 --- M CommunityTwitter_body.php 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: FastLizard4: Verified; Looks good to me, approved diff --git a/CommunityTwitter_body.php b/CommunityTwitter_body.php index c6eeecb..200c7cc 100755 --- a/CommunityTwitter_body.php +++ b/CommunityTwitter_body.php @@ -47,7 +47,7 @@ $output = $this-getOutput(); $user = $this-getUser(); $request = $this-getRequest(); - $title = $this-getTitle(); + $title = $this-getPageTitle(); $language = $this-getLanguage(); // Get extension configuration variables @@ -91,7 +91,7 @@ // Not logged in $tLogin = SpecialPage::getTitleFor( 'UserLogin' ); - $ctPrefixedText = $this-getTitle()-getPrefixedText(); + $ctPrefixedText = $this-getPageTitle()-getPrefixedText(); $loginLink = $tLogin-getFullURL( array( 'returnto' = $ctPrefixedText ) ); $nologinMsg = $this-msg( 'communitytwitter-nologin', $loginLink, $rightsLink, $groupsList, count( $groups ) ); -- To view, visit https://gerrit.wikimedia.org/r/103919 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icb4359c67abbf41d8c46881a6bd67e7c25f010f8 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/CommunityTwitter Gerrit-Branch: master Gerrit-Owner: Legoktm legoktm.wikipe...@gmail.com Gerrit-Reviewer: FastLizard4 fastlizard4-git-comm...@fastlizard4.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fixed communitytwitter-logged-in-as message. - change (mediawiki...CommunityTwitter)
FastLizard4 has submitted this change and it was merged. Change subject: Fixed communitytwitter-logged-in-as message. .. Fixed communitytwitter-logged-in-as message. Reduced patchworking in communitytwitter-logged-in-as message as per: https://translatewiki.net/wiki/Thread:Support/About_MediaWiki:Communitytwitter-logged-in-as/en Change-Id: I5b9329c44a5d0256243dd74ea8812108d037d269 --- M CommunityTwitter.i18n.php M CommunityTwitter_body.php 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: FastLizard4: Verified; Looks good to me, approved diff --git a/CommunityTwitter.i18n.php b/CommunityTwitter.i18n.php index e52a848..524f720 100755 --- a/CommunityTwitter.i18n.php +++ b/CommunityTwitter.i18n.php @@ -48,7 +48,7 @@ In case you think you should have access, please contact an administrator.', 'communitytwitter-connection-failure' = 'Connection to Twitter could not be established.', 'communitytwitter-tweet-section-title' = 'Tweet!', - 'communitytwitter-logged-in-as' = 'Logged in as user', + 'communitytwitter-logged-in-as' = Logged in as user '''$1'''., 'communitytwitter-update-success' = 'Status successfully updated', 'communitytwitter-check-tweet' = 'see', 'communitytwitter-unknown-error-request' = 'An error occurred during the communication with Twitter. Please contact your MediaWiki administrator for assistance.', diff --git a/CommunityTwitter_body.php b/CommunityTwitter_body.php index 8c12512..c6eeecb 100755 --- a/CommunityTwitter_body.php +++ b/CommunityTwitter_body.php @@ -149,7 +149,7 @@ // Tweet section $output-addWikiText(==.wfMsg(communitytwitter-tweet-section-title).==); - $output-addHTML(wfMsg(communitytwitter-logged-in-as). b.$user-getName()./b.\nbr/\n. + $output-addHTML( $this-msg( 'communitytwitter-logged-in-as', $user-getName() )-parse() . \nbr/\n. table class=\wikitable ct-tweet-section\trtd class=\ct-tweet-section\\n); // Process update/deletion/retweet -- To view, visit https://gerrit.wikimedia.org/r/73137 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5b9329c44a5d0256243dd74ea8812108d037d269 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/CommunityTwitter Gerrit-Branch: master Gerrit-Owner: RAN1 r...@fastlizard4.org Gerrit-Reviewer: FastLizard4 fastlizard4-git-comm...@fastlizard4.org Gerrit-Reviewer: Siebrand siebr...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Remove globals from special page execution - change (mediawiki...CommunityTwitter)
FastLizard4 has submitted this change and it was merged.
Change subject: Remove globals from special page execution
..
Remove globals from special page execution
Finally, all of the globals in the CommunityTwitter special page are
gone, replaced with variables retrieved from ContextSource. With that
done, we should be able to move on to improving the extension's
functionality instead of improving what's already there.
Change-Id: Id7d2984e66bdf998bdd11249abae5824c8a23591
---
M CommunityTwitter_body.php
1 file changed, 51 insertions(+), 56 deletions(-)
Approvals:
RAN1: Verified; Looks good to me, approved
diff --git a/CommunityTwitter_body.php b/CommunityTwitter_body.php
index 257cbd5..8c12512 100755
--- a/CommunityTwitter_body.php
+++ b/CommunityTwitter_body.php
@@ -32,33 +32,31 @@
class CommunityTwitter extends SpecialPage {
- function CommunityTwitter() {
- global $wgUser;
- global $individualAccs;
+ // Variable to keep track of whether individual accounts are used by
each user
+ private $individualAccs;
- $individualAccs = true;
+ function __construct() {
+ $this-individualAccs = true;
// In case you want to change the name of the special page, you
have to edit CommunityTwitter_body.php and CommunityTwitter.php
- SpecialPage::SpecialPage('CommunityTwitter', 'twitter');
- $this-skin = $wgUser-getSkin();
+ SpecialPage::__construct('CommunityTwitter', 'twitter');
}
function execute($query) {
- global $wgOut;
- global $wgUser;
- global $wgScriptPath;
- global $wgRequest;
- global $wgDBserver;
- global $wgDBuser;
- global $wgDBpassword;
- global $wgDBname;
+ // Get context variables
+ $output = $this-getOutput();
+ $user = $this-getUser();
+ $request = $this-getRequest();
+ $title = $this-getTitle();
+ $language = $this-getLanguage();
+
+ // Get extension configuration variables
global $ctTableName;
global $ctDefaultAccount;
global $ctDisplayCoordinates;
global $ctLat;
global $ctLong;
global $ctAllowedGroup;
- global $individualAccs;
if (!isset($ctTableName) || !isset($ctDefaultAccount) ||
!isset($ctDisplayCoordinates)) die (Configure LocalSettings.php first.);
@@ -67,7 +65,7 @@
$this-setHeaders();
// Grant access to users with twitter right only. All others
receive error pages.
- if ( !$this-userCanExecute( $wgUser ) ) {
+ if ( !$this-userCanExecute( $user ) ) {
// User does not have rights or is not logged in
$tGroupRights = SpecialPage::getTitleFor(
'ListGroupRights' );
@@ -77,10 +75,10 @@
array( 'User', 'makeGroupLinkWiki' ),
User::getGroupsWithPermission( 'twitter' )
);
- $groupsList = $this-getLanguage()-commaList( $groups
);
+ $groupsList = $language-commaList( $groups );
- if ( !$wgUser-isAnon() )
+ if ( !$user-isAnon() )
{
// Logged in, but no rights
@@ -102,9 +100,9 @@
}
- } else if ( $wgUser-isBlocked() ) {
+ } else if ( $user-isBlocked() ) {
// isBlocked is not checked in userCanExecute, make
sure blocked users aren't tweeting.
- throw new UserBlockedError( $wgUser-getBlock() );
+ throw new UserBlockedError( $user-getBlock() );
} else {
// Presumably the user is allowed
@@ -121,16 +119,16 @@
// Query for individual account(s)
$sql_individual = sprintf(SELECT app_name,
consumer_key, consumer_secret, access_token, access_token_secret FROM %s
NATURAL JOIN %s .
JOIN %s ON (user_id=ug_user) WHERE `ug_group` = '%s' AND `active` = 1
AND (`user_id` = %d OR `user_id` = 0);,
-
$dbr-tableName(user), $ctTableName, $dbr-tableName(user_groups),
$ctAllowedGroup, $wgUser-getId());
+
$dbr-tableName(user), $ctTableName, $dbr-tableName(user_groups),
$ctAllowedGroup, $user-getId());
[MediaWiki-commits] [Gerrit] Update twitteroauth for API v1.1, minor fixes - change (mediawiki...CommunityTwitter)
FastLizard4 has submitted this change and it was merged.
Change subject: Update twitteroauth for API v1.1, minor fixes
..
Update twitteroauth for API v1.1, minor fixes
Recently Twitter discontinued version 1.0 of its API in favor of version 1.1.
This commit introduces
the patches made at https://github.com/abraham/twitteroauth to allow tweeting
again.
In patchset 2, minor edits were made to CommunityTwitter_body.php to improve
functionality. Proper
deletion POSTs and deleted tweet splicing were introduced, along with better
handling of form URLs.
Change-Id: Ie7f2aa7a5875c1e9636f40156d314d6d4c420d0e
---
M CommunityTwitter_body.php
M includes/OAuth.php
M includes/TWITTEROAUTH-LICENSE
M includes/twitteroauth.php
4 files changed, 30 insertions(+), 28 deletions(-)
Approvals:
FastLizard4: Verified; Looks good to me, approved
RAN1: Verified; Looks good to me, but someone else must approve
diff --git a/CommunityTwitter_body.php b/CommunityTwitter_body.php
index 6a20363..257cbd5 100755
--- a/CommunityTwitter_body.php
+++ b/CommunityTwitter_body.php
@@ -141,7 +141,7 @@
if
(!communitytwitter::checkConnections($connections)) {
$wgOut-addHTML(strong
class=\ct-error\.wfMsg(communitytwitter-connection-failure)./strong);
} else {
-
+
// Get Twitter timeline from default
account
$timeline =
$connections[$ctDefaultAccount]-get(statuses/user_timeline,
array(include_rts = true));
$twitterStatuses =
array_values(array_filter(array_map(array(CommunityTwitter, getOwnTweets),
$timeline)));
@@ -203,17 +203,17 @@
$currTimeline = array_values(array_filter(array_map(array(CommunityTwitter,
getOwnTweets), $currTimeline)));
$hashId
= communitytwitter::hashIds($twitterStatuses, $currTimeline);
if
(array_key_exists($wgRequest-getText(deleteId), $hashId)) {
-
$responses[$appName] = $connections[$appName]-post(statuses/destroy,
array(id = $hashId[$wgRequest-getText(deleteId)]));
+
$responses[$appName] = $connections[$appName]-post(statuses/destroy/ .
$hashId[$wgRequest-getText(deleteId)]);
}
}
// Delete Tweet
via OAuth
-
$responses[$ctDefaultAccount] =
$connections[$ctDefaultAccount]-post(statuses/destroy, array(id =
$wgRequest-getText(deleteId)));
+
$responses[$ctDefaultAccount] =
$connections[$ctDefaultAccount]-post(statuses/destroy/ .
$wgRequest-getText(deleteId));
if
(communitytwitter::checkResponses($responses)) {
$wgOut-addHTML(strong
class=\ct-success\.wfMsg(communitytwitter-deletion-success)./strong\n);
//
Update timeline array to display updated your last tweets section
-
unset($twitterStatuses[$i]);
+
array_splice($twitterStatuses, $i, 1);
} else {
$wgOut-addHTML(strong
class=\ct-error\.wfMsg(communitytwitter-unknown-error-request)./strong\n);
}
@@ -241,13 +241,13 @@
} else {
// Tweet textarea; javascript
ResourceLoader module enables an updating counter with button disabling if
tweet is too long (for convenience, Twitter won't allow a 140 char post
anyways)
$wgOut-addModules(
'ext.CommunityTwitter.updatecount' );
- $wgOut-addHTML(form
action=\.$wgScriptPath./../wiki/Special:CommunityTwitter\ method=\post\
id=\status_update_form\\n.
+ $wgOut-addHTML(form
action=\.$wgOut-getTitle()-getLinkURL().\ method=\post\
[MediaWiki-commits] [Gerrit] Divide access-error into sub-messages, add block check - change (mediawiki...CommunityTwitter)
FastLizard4 has submitted this change and it was merged.
Change subject: Divide access-error into sub-messages, add block check
..
Divide access-error into sub-messages, add block check
The communitytwitter-access-error message is problematic. First of all, it
includes links encoded in
plain HTML, which is not good since it mixes raw code with messages. It also
makes the messages harder
to translate. This is reflected in how only half of the 18 languages that
CommunityTwitter has
translations for actually have the communitytwitter-access-error message
translated. The mixing of
HTML code with messages also obscures the need to translate the titles of each
link. This translation
is absent in about half of the 9 languages where a translation for the message
has been submitted.
With a full translation rate of 25%, the communitytwitter-access-error message
has to be split up so
HTML does not obfuscate translation.
In patchset #3, the error page has been split into two different pages, one
with a nologin error
(communitytwitter-nologin), and a second with an access error
(communitytwitter-access-error). Links
have been converted to the appropriate wikitext. In patchset 1, the titles were
given their own messages,
but this was dropped in patchset 3 for translation convenience.
In patchset #5, the 'twitter' right restriction is now passed to SpecialPage's
constructor and the
userCanExecute() method is now used to determine whether an access/login error
has not occurred.
In patchset #6, proper user rights error handling was introduced using the
communitytwitter-nologin and
communitytwitter-access-error messages, accompanying additional text in these
messages that elaborated
on group rights. User block checking was also added. This removed the need for
the communitytwitter-
unknown-error message to bring up the possibility of a user block; blocked
users no longer have access
to the special page. Patchset #7 introduces message plural checks on the groups
allowed to tweet.
Change-Id: I4fc3f17879b30bd5bc36b64e317ec56c9ab24ec2
---
M CommunityTwitter.i18n.php
M CommunityTwitter_body.php
2 files changed, 47 insertions(+), 11 deletions(-)
Approvals:
FastLizard4: Verified; Looks good to me, approved
RAN1: Verified; Looks good to me, but someone else must approve
Raimond Spekking: Looks good to me, but someone else must approve
diff --git a/CommunityTwitter.i18n.php b/CommunityTwitter.i18n.php
index a841ead..dc4f265 100755
--- a/CommunityTwitter.i18n.php
+++ b/CommunityTwitter.i18n.php
@@ -43,7 +43,7 @@
'communitytwitter-desc' = 'Provides a special page, where authorized
users are able to twitter via a community account without the need of giving
away login credentials',
'communitytwitter-no-db-connection' = 'No database connection
possible.',
'communitytwitter-no-db' = 'Database does not exist.',
- 'communitytwitter-unknown-error' = 'Either you were blocked/your
account is not set up or an unknown error occurred.
+ 'communitytwitter-unknown-error' = 'Your account is not set up or an
unknown error occurred.
In case you think you should have access, please contact an administrator',
'communitytwitter-connection-failure' = 'Connection to Twitter could
not be established.',
@@ -62,9 +62,8 @@
'communitytwitter-no-last-tweets' = 'No tweets available',
'communitytwitter-description-template' = 'CommunityTwitter
description',
'communitytwitter-advice-template' = 'CommunityTwitter advice',
- 'communitytwitter-access-error' = You have to be span
class=\plainlinks\a href=\/wiki/Special:UserLogin\ class=\external
text\ title=\log in\ rel=\nofollow\logged in/a/span and \n.
-
span class=\plainlinks\a
href=\/wiki/Special:ListGroupRights\ class=\external text\ title=\See
group rights\ \n.
-
rel=\nofollow\allowed/a/span to access
this page.,
+ 'communitytwitter-nologin' = 'You must span class=plainlinks[$1
log in]/span, and be [[$2|allowed]], to use Community Twitter. Note that use
of Community Twitter is limited to users in {{PLURAL:$4|the group|one of the
following groups}}: $3.',
+ 'communitytwitter-access-error' = 'You do not have the necessary
permissions to use Community Twitter. Use of Community Twitter is limited to
users in {{PLURAL:$2|the group|one of the following groups}}: $1. See the
[[$3|list of group rights]] or contact your MediaWiki administrator for more
information.',
'communitytwitter-userlinks-name' = 'Twitter',
'right-twitter' = 'Use Twitter special page',
);
diff --git a/CommunityTwitter_body.php b/CommunityTwitter_body.php
index fbdb310..6a20363 100755
---
[MediaWiki-commits] [Gerrit] Remove unnecessary closure from JS module - change (mediawiki...CommunityTwitter)
FastLizard4 has submitted this change and it was merged.
Change subject: Remove unnecessary closure from JS module
..
Remove unnecessary closure from JS module
As it so turns out, ResourceLoader already provides closures for JavaScript
modules, eliminating the
need for a closure since one is already provided. Therefore, the self-invoked
function code has been
removed, with the enclosed code unchanged. A note has been added in the JS file
to explain this to
prevent future goof-ups.
Change-Id: I45b4a110defd9b102adcadbae1215c25e450facf
---
M js/ext.CommunityTwitter.updatecount.js
1 file changed, 25 insertions(+), 24 deletions(-)
Approvals:
FastLizard4: Verified; Looks good to me, approved
diff --git a/js/ext.CommunityTwitter.updatecount.js
b/js/ext.CommunityTwitter.updatecount.js
index 588c31e..5c3d795 100644
--- a/js/ext.CommunityTwitter.updatecount.js
+++ b/js/ext.CommunityTwitter.updatecount.js
@@ -1,37 +1,38 @@
/**
- * A simple self-invoked function that updates the characters remaining count
for tweeters so that they
- * don't end up going over the 140-character limit. Adds some colors to grab
the user's attention too.
+ * A simple function that updates the characters remaining count for tweeters
so that they don't
+ * end up going over the 140-character limit. Adds some colors to grab the
user's attention too.
*
* Notes for the gets: 'status_update_form' refers to the form element that
contains all relevant
* elements for updating the Twitter status, the textarea element is the
textbox for inputting the status
* update, the strong element encloses the number of characters remaining
output (140 by default),
* and the input element is the Tweet button.
+ *
+ * Notes about scope: ResourceLoader already provides a closure for JavaScript
modules, so the variables
+ * which are defined below are not actually in the global scope. There is no
need to rewrite them in
+ * a closure to keep them outside of the global scope.
**/
-(function() {
+// get the text box, count output, and tweet button via DOM and store as
variables
- // get the text box, count output, and tweet button via DOM and store
as variables
+var ctStatusForm = document.getElementById( 'status_update_form' );
+var ctStatusTextarea = ctStatusForm.getElementsByTagName( 'textarea' )[0];
+var ctCountOutput = ctStatusForm.getElementsByTagName( 'strong' )[0];
+var ctTweetButton = ctStatusForm.getElementsByTagName( 'input' )[0];
+ctStatusTextarea.onkeyup = function () {
+ var ctCharsLeft = 140 - ctStatusTextarea.value.length; // get the
number of characters left from the text box
- var ctStatusForm = document.getElementById('status_update_form');
- var ctStatusTextarea = ctStatusForm.getElementsByTagName('textarea')[0];
- var ctCountOutput = ctStatusForm.getElementsByTagName('strong')[0];
- var ctTweetButton = ctStatusForm.getElementsByTagName('input')[0];
- ctStatusTextarea.onkeyup = function () {
- var ctCharsLeft = 140 - ctStatusTextarea.value.length; // get
the number of characters left from the text box
+ // using the number of chars, change count output color and
disable/enable tweet button as needed
- // using the number of chars, change count output color and
disable/enable tweet button as needed
-
- if ( ctCharsLeft 0 ) {
- ctCountOutput.style.color = 'red'; // red means bad
- ctTweetButton.setAttribute( 'disabled', 'disabled' );
// disables Tweet button
+ if ( ctCharsLeft 0 ) {
+ ctCountOutput.style.color = 'red'; // red means bad
+ ctTweetButton.setAttribute( 'disabled', 'disabled' ); //
disables Tweet button
+ } else {
+ ctTweetButton.removeAttribute( 'disabled' ); // enables Tweet
button
+ if ( ctCharsLeft 25 ) {
+ ctCountOutput.style.color = '#CC0'; // yellow
} else {
- ctTweetButton.removeAttribute( 'disabled' ); // enables
Tweet button
- if ( ctCharsLeft 25 ) {
- ctCountOutput.style.color = '#CC0'; // yellow
- } else {
- ctCountOutput.style.color = 'inherit'; //
default
- }
+ ctCountOutput.style.color = 'inherit'; // default
}
- ctCountOutput.innerHTML = ctCharsLeft; // output the count
- };
-})();
+ }
+ ctCountOutput.innerHTML = ctCharsLeft; // output the count
+};
--
To view, visit https://gerrit.wikimedia.org/r/68613
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I45b4a110defd9b102adcadbae1215c25e450facf
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CommunityTwitter
Gerrit-Branch: master
[MediaWiki-commits] [Gerrit] Optimize JS, move JS ResLoad module, bump to 0.3.3 - change (mediawiki...CommunityTwitter)
FastLizard4 has submitted this change and it was merged.
Change subject: Optimize JS, move JS ResLoad module, bump to 0.3.3
..
Optimize JS, move JS ResLoad module, bump to 0.3.3
This commit introduces a major change in the structure of
js/ext.CommunityTwitter.updatecount.js and
a minor change in the code for CommunityTwitter_body.php. The JS code for
updating the characters
remaining counter proved to be a source of lag on mobile devices such as the
fifth-generation iPod
Touch, with much greater lag time expected for devices which are less powerful.
The source of this
lag was identified to be the relatively-expensive recursion of
document.getElementById three times
per character input, once for the textarea element to grab the number of
characters used, the strong
element for the counter output, and the input element for disabling/re-enabling
the Tweet button.
Two methods were used to optimize the JS, implemented in chronological order:
(1) A global variable,
ctStatusForm, was defined to get the form element for the tweet box using
document.getElementById.
Using ctStatusForm.getElementsByTagName, the user's JavaScript engine only
needed to search within
just the form element to get the three Element objects every time a character
was input,
significantly reducing lag time. (2) A self-invoked, anonymous function now
contains the 4 element-
getting variables, as well as the attachment of the counter update function to
ctStatusTextarea.onkeyup. This effectively creates a closure, eliminating the
need for true global
variables while also eliminating the need to re-get the elements every time a
character is input.
This makes the update counter's resource expense negligible, reducing it to
minor on-load lag.
As for the PHP code, the loading of the JavaScript ResourceLoader module was
moved to inside the
if-else branch containing the status update box so that it is only loaded when
the status update box
is loaded. Finally, the version was bumped to 0.3.3 since the restructuring of
the JS code is major.
Change-Id: I0f96a57c63553ca1618d75bca2bb67187cdde7e6
---
M CommunityTwitter.php
M CommunityTwitter_body.php
M js/ext.CommunityTwitter.updatecount.js
3 files changed, 31 insertions(+), 28 deletions(-)
Approvals:
FastLizard4: Verified; Looks good to me, approved
diff --git a/CommunityTwitter.php b/CommunityTwitter.php
index cd43ebd..e95dfb3 100755
--- a/CommunityTwitter.php
+++ b/CommunityTwitter.php
@@ -34,7 +34,7 @@
$wgExtensionCredits['specialpage'][] = array(
'path' = __FILE__,
'name' = 'Community Twitter',
- 'version' = '0.3.2',
+ 'version' = '0.3.3',
'author' = array( '[https://www.mediawiki.org/wiki/User:Basti2342
Basti]', '[https://www.mediawiki.org/wiki/User:FastLizard4 Andrew FastLizard4
Adams]', '[https://www.mediawiki.org/wiki/User:RAN1 RAN1]',
'[https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/CommunityTwitter.git;a=log
others]' ),
'url' = 'https://www.mediawiki.org/wiki/Extension:Community_Twitter',
'descriptionmsg' = 'communitytwitter-desc',
diff --git a/CommunityTwitter_body.php b/CommunityTwitter_body.php
index 89f76b4..fbdb310 100755
--- a/CommunityTwitter_body.php
+++ b/CommunityTwitter_body.php
@@ -89,9 +89,8 @@
if ($dbr-numRows($res) != 0) {
- // Load ResourceLoader modules, CSS with
addModuleStyles since functionality will work without JS
+ // Load CSS ResourceLoader module with
addModuleStyles since most functionality does not require JS
$wgOut-addModuleStyles(
'ext.CommunityTwitter.styles' );
- $wgOut-addModules(
'ext.CommunityTwitter.updatecount' );
// Establish Twitter-connections
$connections = array();
@@ -200,7 +199,8 @@
}
} else {
- // Tweet textarea with
javascript counter (disables the button, if tweet is too long (comfort feature,
no security feature)
+ // Tweet textarea; javascript
ResourceLoader module enables an updating counter with button disabling if
tweet is too long (for convenience, Twitter won't allow a 140 char post
anyways)
+ $wgOut-addModules(
'ext.CommunityTwitter.updatecount' );
$wgOut-addHTML(form
action=\.$wgScriptPath./../wiki/Special:CommunityTwitter\ method=\post\
id=\status_update_form\\n.
span class=\ct-tweet\.wfMsg(communitytwitter-remaining-chars).:
strong id=\stringlength\140/strongbr/\n.
[MediaWiki-commits] [Gerrit] Fix whitespace error - change (mediawiki...CommunityTwitter)
FastLizard4 has submitted this change and it was merged. Change subject: Fix whitespace error .. Fix whitespace error Change-Id: I00f860ea7800a2f641bd165762b078543bac6f42 --- M js/ext.CommunityTwitter.updatecount.js 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: FastLizard4: Verified; Looks good to me, approved diff --git a/js/ext.CommunityTwitter.updatecount.js b/js/ext.CommunityTwitter.updatecount.js index 9c9a20c..588c31e 100644 --- a/js/ext.CommunityTwitter.updatecount.js +++ b/js/ext.CommunityTwitter.updatecount.js @@ -1,7 +1,7 @@ /** * A simple self-invoked function that updates the characters remaining count for tweeters so that they * don't end up going over the 140-character limit. Adds some colors to grab the user's attention too. - * + * * Notes for the gets: 'status_update_form' refers to the form element that contains all relevant * elements for updating the Twitter status, the textarea element is the textbox for inputting the status * update, the strong element encloses the number of characters remaining output (140 by default), -- To view, visit https://gerrit.wikimedia.org/r/65874 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I00f860ea7800a2f641bd165762b078543bac6f42 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/CommunityTwitter Gerrit-Branch: master Gerrit-Owner: FastLizard4 fastlizard4-git-comm...@fastlizard4.org Gerrit-Reviewer: FastLizard4 fastlizard4-git-comm...@fastlizard4.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fix whitespace error - change (mediawiki...CommunityTwitter)
FastLizard4 has uploaded a new change for review. https://gerrit.wikimedia.org/r/65874 Change subject: Fix whitespace error .. Fix whitespace error Change-Id: I00f860ea7800a2f641bd165762b078543bac6f42 --- M js/ext.CommunityTwitter.updatecount.js 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CommunityTwitter refs/changes/74/65874/1 diff --git a/js/ext.CommunityTwitter.updatecount.js b/js/ext.CommunityTwitter.updatecount.js index 9c9a20c..588c31e 100644 --- a/js/ext.CommunityTwitter.updatecount.js +++ b/js/ext.CommunityTwitter.updatecount.js @@ -1,7 +1,7 @@ /** * A simple self-invoked function that updates the characters remaining count for tweeters so that they * don't end up going over the 140-character limit. Adds some colors to grab the user's attention too. - * + * * Notes for the gets: 'status_update_form' refers to the form element that contains all relevant * elements for updating the Twitter status, the textarea element is the textbox for inputting the status * update, the strong element encloses the number of characters remaining output (140 by default), -- To view, visit https://gerrit.wikimedia.org/r/65874 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I00f860ea7800a2f641bd165762b078543bac6f42 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/CommunityTwitter Gerrit-Branch: master Gerrit-Owner: FastLizard4 fastlizard4-git-comm...@fastlizard4.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Minor edits, obsessing over whitespace - change (mediawiki...CommunityTwitter)
FastLizard4 has submitted this change and it was merged.
Change subject: Minor edits, obsessing over whitespace
..
Minor edits, obsessing over whitespace
A minor edit to the JavaScript for updating the character count residing at
js/ext.CommunityTwitter.updatecount.js that gets to the point and attaches the
updateCount function
to the onkeyup event without function declaring/calling convoluting. This
commit also adds more whitespace
in and also includes some comments to aid in reading the JavaScript function.
Additionally,
a braceless if-statement in CommunityTwitter.php was rewritten with braces for
safety.
Furthermore, whitespace has been converted to tabs where appropriate in the
extension and
extraneous spaces have been removed. Tldr: To-may-to, to-mah-to.
Change-Id: I8b51ba617508d4303cfa12d0d5e8a1ae86144d16
---
M CommunityTwitter.i18n.php
M CommunityTwitter.php
M CommunityTwitter_body.php
M css/ext.CommunityTwitter.css
M js/ext.CommunityTwitter.updatecount.js
5 files changed, 65 insertions(+), 51 deletions(-)
Approvals:
FastLizard4: Verified; Looks good to me, approved
diff --git a/CommunityTwitter.i18n.php b/CommunityTwitter.i18n.php
index 0e145ae..e60dbde 100755
--- a/CommunityTwitter.i18n.php
+++ b/CommunityTwitter.i18n.php
@@ -11,18 +11,18 @@
*
* Integration in personal Menu by Yaron Koren (Admin Links,
* http://www.mediawiki.org/wiki/Extension:Admin_Links).
- *
+ *
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License
* as published by the Free Software Foundation; either version 2
* of the License, or (at your option) any later version.
- *
+ *
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
- *
+ *
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301,
USA.
diff --git a/CommunityTwitter.php b/CommunityTwitter.php
index d42265b..a3fa3e3 100755
--- a/CommunityTwitter.php
+++ b/CommunityTwitter.php
@@ -11,18 +11,18 @@
*
* Integration in personal Menu by Yaron Koren (Admin Links,
* http://www.mediawiki.org/wiki/Extension:Admin_Links).
- *
+ *
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License
* as published by the Free Software Foundation; either version 2
* of the License, or (at your option) any later version.
- *
+ *
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
- *
+ *
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301,
USA.
@@ -71,7 +71,8 @@
$wgHooks['PersonalUrls'][] = 'CommunityTwitter::addURLToUserLinks';
$wgAvailableRights[] = 'twitter';
// Only members of defined group see the link to the twitter special page
-if(isset($ctAllowedGroup) === false)
+if(isset($ctAllowedGroup) === false) {
$ctAllowedGroup = 'sysop';
+}
$wgGroupPermissions[$ctAllowedGroup]['twitter'] = true;
$wgAutoloadClasses['CommunityTwitter'] = $wgtwitterIP .
'CommunityTwitter_body.php';
diff --git a/CommunityTwitter_body.php b/CommunityTwitter_body.php
index 7b6b1ce..3b9a9d0 100755
--- a/CommunityTwitter_body.php
+++ b/CommunityTwitter_body.php
@@ -11,18 +11,18 @@
*
* Integration in personal Menu by Yaron Koren (Admin Links,
* http://www.mediawiki.org/wiki/Extension:Admin_Links).
- *
+ *
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License
* as published by the Free Software Foundation; either version 2
* of the License, or (at your option) any later version.
- *
+ *
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
- *
+ *
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301,
USA.
@@ -92,7 +92,7 @@
// Load ResourceLoader modules, CSS with
addModuleStyles since functionality will work without JS
[MediaWiki-commits] [Gerrit] Add RAN1 to authors list, since he's been a big help :D - change (mediawiki...CommunityTwitter)
FastLizard4 has uploaded a new change for review. https://gerrit.wikimedia.org/r/65311 Change subject: Add RAN1 to authors list, since he's been a big help :D .. Add RAN1 to authors list, since he's been a big help :D Change-Id: Ic20b6f13ef89b0c4d7c8cfbef5c9eaf8ecdafb12 --- M CommunityTwitter.php 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CommunityTwitter refs/changes/11/65311/1 diff --git a/CommunityTwitter.php b/CommunityTwitter.php index a3fa3e3..b2a7ad5 100755 --- a/CommunityTwitter.php +++ b/CommunityTwitter.php @@ -35,7 +35,7 @@ 'path' = __FILE__, 'name' = 'Community Twitter', 'version' = '0.3.1', - 'author' = array( '[https://www.mediawiki.org/wiki/User:Basti2342 Basti]', '[https://www.mediawiki.org/wiki/User:FastLizard4 Andrew FastLizard4 Adams]', '[https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/CommunityTwitter.git;a=log others]' ), + 'author' = array( '[https://www.mediawiki.org/wiki/User:Basti2342 Basti]', '[https://www.mediawiki.org/wiki/User:FastLizard4 Andrew FastLizard4 Adams]', '[https://www.mediawiki.org/wiki/User:RAN1 RAN1]', '[https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/CommunityTwitter.git;a=log others]' ), 'url' = 'https://www.mediawiki.org/wiki/Extension:Community_Twitter', 'descriptionmsg' = 'communitytwitter-desc', ); -- To view, visit https://gerrit.wikimedia.org/r/65311 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic20b6f13ef89b0c4d7c8cfbef5c9eaf8ecdafb12 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/CommunityTwitter Gerrit-Branch: master Gerrit-Owner: FastLizard4 fastlizard4-git-comm...@fastlizard4.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add RAN1 to authors list, since he's been a big help :D - change (mediawiki...CommunityTwitter)
FastLizard4 has submitted this change and it was merged. Change subject: Add RAN1 to authors list, since he's been a big help :D .. Add RAN1 to authors list, since he's been a big help :D Change-Id: Ic20b6f13ef89b0c4d7c8cfbef5c9eaf8ecdafb12 --- M CommunityTwitter.php 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: FastLizard4: Verified; Looks good to me, approved diff --git a/CommunityTwitter.php b/CommunityTwitter.php index a3fa3e3..b2a7ad5 100755 --- a/CommunityTwitter.php +++ b/CommunityTwitter.php @@ -35,7 +35,7 @@ 'path' = __FILE__, 'name' = 'Community Twitter', 'version' = '0.3.1', - 'author' = array( '[https://www.mediawiki.org/wiki/User:Basti2342 Basti]', '[https://www.mediawiki.org/wiki/User:FastLizard4 Andrew FastLizard4 Adams]', '[https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/CommunityTwitter.git;a=log others]' ), + 'author' = array( '[https://www.mediawiki.org/wiki/User:Basti2342 Basti]', '[https://www.mediawiki.org/wiki/User:FastLizard4 Andrew FastLizard4 Adams]', '[https://www.mediawiki.org/wiki/User:RAN1 RAN1]', '[https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/CommunityTwitter.git;a=log others]' ), 'url' = 'https://www.mediawiki.org/wiki/Extension:Community_Twitter', 'descriptionmsg' = 'communitytwitter-desc', ); -- To view, visit https://gerrit.wikimedia.org/r/65311 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic20b6f13ef89b0c4d7c8cfbef5c9eaf8ecdafb12 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/CommunityTwitter Gerrit-Branch: master Gerrit-Owner: FastLizard4 fastlizard4-git-comm...@fastlizard4.org Gerrit-Reviewer: FastLizard4 fastlizard4-git-comm...@fastlizard4.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add twitteroauth library into the repository - change (mediawiki...CommunityTwitter)
FastLizard4 has uploaded a new change for review.
https://gerrit.wikimedia.org/r/65334
Change subject: Add twitteroauth library into the repository
..
Add twitteroauth library into the repository
This commit adds the twitteroauth PHP library to the repository's code, so
installers of the extension no longer need to download the needed files
themselves, and it's more appropriate for the files to be here rather than the
MediaWiki includes folder. Links and license files have been included to
fulfill the terms of the license twitteroauth is distributed under.
Unfortunately, it was impractical to include the library as a git submodule,
as most of the repository was unnecessary. The files were instead simply
copied into /includes, and will need to be manually updated as needed.
Change-Id: I6d25b511b637a4cf96d4caca11a1b9d4150f101e
---
M CommunityTwitter.php
M CommunityTwitter_body.php
A includes/OAuth.php
A includes/TWITTEROAUTH-LICENSE
A includes/twitteroauth.php
5 files changed, 1,137 insertions(+), 3 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CommunityTwitter
refs/changes/34/65334/1
diff --git a/CommunityTwitter.php b/CommunityTwitter.php
index b2a7ad5..cd43ebd 100755
--- a/CommunityTwitter.php
+++ b/CommunityTwitter.php
@@ -34,7 +34,7 @@
$wgExtensionCredits['specialpage'][] = array(
'path' = __FILE__,
'name' = 'Community Twitter',
- 'version' = '0.3.1',
+ 'version' = '0.3.2',
'author' = array( '[https://www.mediawiki.org/wiki/User:Basti2342
Basti]', '[https://www.mediawiki.org/wiki/User:FastLizard4 Andrew FastLizard4
Adams]', '[https://www.mediawiki.org/wiki/User:RAN1 RAN1]',
'[https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/CommunityTwitter.git;a=log
others]' ),
'url' = 'https://www.mediawiki.org/wiki/Extension:Community_Twitter',
'descriptionmsg' = 'communitytwitter-desc',
diff --git a/CommunityTwitter_body.php b/CommunityTwitter_body.php
index 3b9a9d0..89f76b4 100755
--- a/CommunityTwitter_body.php
+++ b/CommunityTwitter_body.php
@@ -59,7 +59,6 @@
global $ctLong;
global $ctAllowedGroup;
global $individualAccs;
- global $IP;
if (!isset($ctTableName) || !isset($ctDefaultAccount) ||
!isset($ctDisplayCoordinates)) die (Configure LocalSettings.php first.);
@@ -70,7 +69,7 @@
// Grant access to defined group only
if ($wgUser-getId() != 0 in_array($ctAllowedGroup,
$wgUser-getEffectiveGroups())) {
-
require_once({$IP}/includes/twitteroauth/twitteroauth.php);
+ require_once(includes/twitteroauth.php);
// Query for joint account(s)
$sql_joint = sprintf(SELECT app_name, consumer_key,
consumer_secret, access_token, access_token_secret FROM %s .
diff --git a/includes/OAuth.php b/includes/OAuth.php
new file mode 100644
index 000..e763041
--- /dev/null
+++ b/includes/OAuth.php
@@ -0,0 +1,872 @@
+?php
+// vim: foldmethod=marker
+
+/* Generic exception class
+ */
+class OAuthException extends Exception {
+ // pass
+}
+
+class OAuthConsumer {
+ public $key;
+ public $secret;
+
+ function __construct($key, $secret, $callback_url=NULL) {
+$this-key = $key;
+$this-secret = $secret;
+$this-callback_url = $callback_url;
+ }
+
+ function __toString() {
+return OAuthConsumer[key=$this-key,secret=$this-secret];
+ }
+}
+
+class OAuthToken {
+ // access tokens and request tokens
+ public $key;
+ public $secret;
+
+ /**
+ * key = the token
+ * secret = the token secret
+ */
+ function __construct($key, $secret) {
+$this-key = $key;
+$this-secret = $secret;
+ }
+
+ /**
+ * generates the basic string serialization of a token that a server
+ * would respond to request_token and access_token calls with
+ */
+ function to_string() {
+return oauth_token= .
+ OAuthUtil::urlencode_rfc3986($this-key) .
+ oauth_token_secret= .
+ OAuthUtil::urlencode_rfc3986($this-secret);
+ }
+
+ function __toString() {
+return $this-to_string();
+ }
+}
+
+/**
+ * A class for implementing a Signature Method
+ * See section 9 (Signing Requests) in the spec
+ */
+abstract class OAuthSignatureMethod {
+ /**
+ * Needs to return the name of the Signature Method (ie HMAC-SHA1)
+ * @return string
+ */
+ abstract public function get_name();
+
+ /**
+ * Build up the signature
+ * NOTE: The output of this function MUST NOT be urlencoded.
+ * the encoding is handled in OAuthRequest when the final
+ * request is serialized
+ * @param OAuthRequest $request
+ * @param OAuthConsumer $consumer
+ * @param OAuthToken $token
+ * @return string
+ */
+ abstract public function build_signature($request, $consumer, $token);
+
+ /**
+ * Verifies that a given
[MediaWiki-commits] [Gerrit] Add twitteroauth library into the repository - change (mediawiki...CommunityTwitter)
FastLizard4 has submitted this change and it was merged.
Change subject: Add twitteroauth library into the repository
..
Add twitteroauth library into the repository
This commit adds the twitteroauth PHP library to the repository's code, so
installers of the extension no longer need to download the needed files
themselves, and it's more appropriate for the files to be here rather than the
MediaWiki includes folder. Links and license files have been included to
fulfill the terms of the license twitteroauth is distributed under.
Unfortunately, it was impractical to include the library as a git submodule,
as most of the repository was unnecessary. The files were instead simply
copied into /includes, and will need to be manually updated as needed.
Patchsets 2 and 3 removes some whitespacing errors (trailing whitespace and
ends-of-lines).
Change-Id: I6d25b511b637a4cf96d4caca11a1b9d4150f101e
---
M CommunityTwitter.php
M CommunityTwitter_body.php
A includes/OAuth.php
A includes/TWITTEROAUTH-LICENSE
A includes/twitteroauth.php
5 files changed, 1,137 insertions(+), 3 deletions(-)
Approvals:
FastLizard4: Verified; Looks good to me, approved
diff --git a/CommunityTwitter.php b/CommunityTwitter.php
index b2a7ad5..cd43ebd 100755
--- a/CommunityTwitter.php
+++ b/CommunityTwitter.php
@@ -34,7 +34,7 @@
$wgExtensionCredits['specialpage'][] = array(
'path' = __FILE__,
'name' = 'Community Twitter',
- 'version' = '0.3.1',
+ 'version' = '0.3.2',
'author' = array( '[https://www.mediawiki.org/wiki/User:Basti2342
Basti]', '[https://www.mediawiki.org/wiki/User:FastLizard4 Andrew FastLizard4
Adams]', '[https://www.mediawiki.org/wiki/User:RAN1 RAN1]',
'[https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/CommunityTwitter.git;a=log
others]' ),
'url' = 'https://www.mediawiki.org/wiki/Extension:Community_Twitter',
'descriptionmsg' = 'communitytwitter-desc',
diff --git a/CommunityTwitter_body.php b/CommunityTwitter_body.php
index 3b9a9d0..89f76b4 100755
--- a/CommunityTwitter_body.php
+++ b/CommunityTwitter_body.php
@@ -59,7 +59,6 @@
global $ctLong;
global $ctAllowedGroup;
global $individualAccs;
- global $IP;
if (!isset($ctTableName) || !isset($ctDefaultAccount) ||
!isset($ctDisplayCoordinates)) die (Configure LocalSettings.php first.);
@@ -70,7 +69,7 @@
// Grant access to defined group only
if ($wgUser-getId() != 0 in_array($ctAllowedGroup,
$wgUser-getEffectiveGroups())) {
-
require_once({$IP}/includes/twitteroauth/twitteroauth.php);
+ require_once(includes/twitteroauth.php);
// Query for joint account(s)
$sql_joint = sprintf(SELECT app_name, consumer_key,
consumer_secret, access_token, access_token_secret FROM %s .
diff --git a/includes/OAuth.php b/includes/OAuth.php
new file mode 100644
index 000..22f8816
--- /dev/null
+++ b/includes/OAuth.php
@@ -0,0 +1,872 @@
+?php
+// vim: foldmethod=marker
+
+/* Generic exception class
+ */
+class OAuthException extends Exception {
+ // pass
+}
+
+class OAuthConsumer {
+ public $key;
+ public $secret;
+
+ function __construct($key, $secret, $callback_url=NULL) {
+$this-key = $key;
+$this-secret = $secret;
+$this-callback_url = $callback_url;
+ }
+
+ function __toString() {
+return OAuthConsumer[key=$this-key,secret=$this-secret];
+ }
+}
+
+class OAuthToken {
+ // access tokens and request tokens
+ public $key;
+ public $secret;
+
+ /**
+ * key = the token
+ * secret = the token secret
+ */
+ function __construct($key, $secret) {
+$this-key = $key;
+$this-secret = $secret;
+ }
+
+ /**
+ * generates the basic string serialization of a token that a server
+ * would respond to request_token and access_token calls with
+ */
+ function to_string() {
+return oauth_token= .
+ OAuthUtil::urlencode_rfc3986($this-key) .
+ oauth_token_secret= .
+ OAuthUtil::urlencode_rfc3986($this-secret);
+ }
+
+ function __toString() {
+return $this-to_string();
+ }
+}
+
+/**
+ * A class for implementing a Signature Method
+ * See section 9 (Signing Requests) in the spec
+ */
+abstract class OAuthSignatureMethod {
+ /**
+ * Needs to return the name of the Signature Method (ie HMAC-SHA1)
+ * @return string
+ */
+ abstract public function get_name();
+
+ /**
+ * Build up the signature
+ * NOTE: The output of this function MUST NOT be urlencoded.
+ * the encoding is handled in OAuthRequest when the final
+ * request is serialized
+ * @param OAuthRequest $request
+ * @param OAuthConsumer $consumer
+ * @param OAuthToken $token
+ * @return string
+ */
+ abstract public function build_signature($request, $consumer, $token);
+
+ /**
+ * Verifies
[MediaWiki-commits] [Gerrit] Bump to version 0.3.1, add others to the author credits. - change (mediawiki...CommunityTwitter)
FastLizard4 has uploaded a new change for review. https://gerrit.wikimedia.org/r/65011 Change subject: Bump to version 0.3.1, add others to the author credits. .. Bump to version 0.3.1, add others to the author credits. Others currently links to the Git log of the extension. Change-Id: I69f3efe74b27b93801dd6e949f0a5d2735aeaad6 --- M CommunityTwitter.php 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CommunityTwitter refs/changes/11/65011/1 diff --git a/CommunityTwitter.php b/CommunityTwitter.php index 136c885..d42265b 100755 --- a/CommunityTwitter.php +++ b/CommunityTwitter.php @@ -34,8 +34,8 @@ $wgExtensionCredits['specialpage'][] = array( 'path' = __FILE__, 'name' = 'Community Twitter', - 'version' = '0.3.0', - 'author' = array( '[https://www.mediawiki.org/wiki/User:Basti2342 Basti]', '[https://www.mediawiki.org/wiki/User:FastLizard4 Andrew FastLizard4 Adams]' ), + 'version' = '0.3.1', + 'author' = array( '[https://www.mediawiki.org/wiki/User:Basti2342 Basti]', '[https://www.mediawiki.org/wiki/User:FastLizard4 Andrew FastLizard4 Adams]', '[https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/CommunityTwitter.git;a=log others]' ), 'url' = 'https://www.mediawiki.org/wiki/Extension:Community_Twitter', 'descriptionmsg' = 'communitytwitter-desc', ); -- To view, visit https://gerrit.wikimedia.org/r/65011 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I69f3efe74b27b93801dd6e949f0a5d2735aeaad6 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/CommunityTwitter Gerrit-Branch: master Gerrit-Owner: FastLizard4 fastlizard4-git-comm...@fastlizard4.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Bump to version 0.3.1, add others to the author credits. - change (mediawiki...CommunityTwitter)
FastLizard4 has submitted this change and it was merged. Change subject: Bump to version 0.3.1, add others to the author credits. .. Bump to version 0.3.1, add others to the author credits. Others currently links to the Git log of the extension. Change-Id: I69f3efe74b27b93801dd6e949f0a5d2735aeaad6 --- M CommunityTwitter.php 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: FastLizard4: Verified; Looks good to me, approved diff --git a/CommunityTwitter.php b/CommunityTwitter.php index 136c885..d42265b 100755 --- a/CommunityTwitter.php +++ b/CommunityTwitter.php @@ -34,8 +34,8 @@ $wgExtensionCredits['specialpage'][] = array( 'path' = __FILE__, 'name' = 'Community Twitter', - 'version' = '0.3.0', - 'author' = array( '[https://www.mediawiki.org/wiki/User:Basti2342 Basti]', '[https://www.mediawiki.org/wiki/User:FastLizard4 Andrew FastLizard4 Adams]' ), + 'version' = '0.3.1', + 'author' = array( '[https://www.mediawiki.org/wiki/User:Basti2342 Basti]', '[https://www.mediawiki.org/wiki/User:FastLizard4 Andrew FastLizard4 Adams]', '[https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/CommunityTwitter.git;a=log others]' ), 'url' = 'https://www.mediawiki.org/wiki/Extension:Community_Twitter', 'descriptionmsg' = 'communitytwitter-desc', ); -- To view, visit https://gerrit.wikimedia.org/r/65011 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I69f3efe74b27b93801dd6e949f0a5d2735aeaad6 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/CommunityTwitter Gerrit-Branch: master Gerrit-Owner: FastLizard4 fastlizard4-git-comm...@fastlizard4.org Gerrit-Reviewer: FastLizard4 fastlizard4-git-comm...@fastlizard4.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add myself to extension authors array, bump version to 0.3.0 - change (mediawiki...CommunityTwitter)
FastLizard4 has uploaded a new change for review. https://gerrit.wikimedia.org/r/64378 Change subject: Add myself to extension authors array, bump version to 0.3.0 .. Add myself to extension authors array, bump version to 0.3.0 0.3.0 will encompass all updates to make this extension compatible with TranslateWiki. Change-Id: Iaf6a7b77697d6aafe5fb7c1a1e38ed1d51c08f10 --- M Twitter.php 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CommunityTwitter refs/changes/78/64378/1 diff --git a/Twitter.php b/Twitter.php index 6fce0f9..c310d4e 100755 --- a/Twitter.php +++ b/Twitter.php @@ -34,8 +34,8 @@ $wgExtensionCredits['specialpage'][] = array( 'path' = __FILE__, 'name' = 'Community Twitter', - 'version' = '0.2', - 'author' = 'Basti', + 'version' = '0.3.0', + 'author' = array( '[https://www.mediawiki.org/w/index.php?title=User:Basti2342action=editredlink=1 Basti]', '[https://www.mediawiki.org/wiki/User:FastLizard4 Andrew FastLizard4 Adams]' ), 'url' = 'https://www.mediawiki.org/wiki/Extension:Community_Twitter', 'descriptionmsg' = 'communitytwitter-desc', ); -- To view, visit https://gerrit.wikimedia.org/r/64378 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iaf6a7b77697d6aafe5fb7c1a1e38ed1d51c08f10 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/CommunityTwitter Gerrit-Branch: master Gerrit-Owner: FastLizard4 fastlizard4-git-comm...@fastlizard4.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add myself to extension authors array, bump version to 0.3.0 - change (mediawiki...CommunityTwitter)
FastLizard4 has submitted this change and it was merged. Change subject: Add myself to extension authors array, bump version to 0.3.0 .. Add myself to extension authors array, bump version to 0.3.0 0.3.0 will encompass all updates to make this extension compatible with TranslateWiki. Change-Id: Iaf6a7b77697d6aafe5fb7c1a1e38ed1d51c08f10 --- M Twitter.php 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: FastLizard4: Verified; Looks good to me, approved diff --git a/Twitter.php b/Twitter.php index 6fce0f9..ee7cacb 100755 --- a/Twitter.php +++ b/Twitter.php @@ -34,8 +34,8 @@ $wgExtensionCredits['specialpage'][] = array( 'path' = __FILE__, 'name' = 'Community Twitter', - 'version' = '0.2', - 'author' = 'Basti', + 'version' = '0.3.0', + 'author' = array( '[https://www.mediawiki.org/wiki/User:Basti2342 Basti]', '[https://www.mediawiki.org/wiki/User:FastLizard4 Andrew FastLizard4 Adams]' ), 'url' = 'https://www.mediawiki.org/wiki/Extension:Community_Twitter', 'descriptionmsg' = 'communitytwitter-desc', ); -- To view, visit https://gerrit.wikimedia.org/r/64378 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaf6a7b77697d6aafe5fb7c1a1e38ed1d51c08f10 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/CommunityTwitter Gerrit-Branch: master Gerrit-Owner: FastLizard4 fastlizard4-git-comm...@fastlizard4.org Gerrit-Reviewer: FastLizard4 fastlizard4-git-comm...@fastlizard4.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] I18n review in preparation for adding extension to translate... - change (mediawiki...CommunityTwitter)
FastLizard4 has submitted this change and it was merged. Change subject: I18n review in preparation for adding extension to translatewiki.net .. I18n review in preparation for adding extension to translatewiki.net i18 file: * Use single ' instead of where possible in i18n file * Add description message * Add user right message * In German section: Use UTF-8 * Add some FIXME's FIXME's: * Define default values for globals like $ctAllowedGroup * Use 'communitytwitter-' as message key prefix to avoid conflicts with other Twitter extensions * Add message documentation, see https://www.mediawiki.org/wiki/I18n#Message_documentation Once this is done, I will add extension to translatewiki.net Change-Id: I5e2e1350ab486814cb93fb9740abb4ad9aa7ddd2 --- M Twitter.i18n.php M Twitter.php 2 files changed, 63 insertions(+), 49 deletions(-) Approvals: FastLizard4: Verified; Looks good to me, approved diff --git a/Twitter.i18n.php b/Twitter.i18n.php index d04191b..cbb3346 100755 --- a/Twitter.i18n.php +++ b/Twitter.i18n.php @@ -38,57 +38,69 @@ $messages = array(); +# FIXME's: +## Use 'communitytwitter-' as message key prefix to avoid conflicts with other Twitter extensions +## Add message documentation, see https://www.mediawiki.org/wiki/I18n#Message_documentation + // English -$messages[en] = array( - twitter = Twitter, - twitter_no_db_connection = No DB connection possible., - twitter_no_db = DB does not exist., - twitter_unknown_error = Either you were blocked/your account not set up or an unknown error occurred.br /br /In case you think you should have access, please contact a href=\./Benutzer:Basti\Basti/a., - twitter_connection_failure = Connection to Twitter could not be established., - twitter_tweet_section_title = Tweet!, - twitter_logged_in_as = Logged in as user, - twitter_update_success = Status successfully updated, - twitter_check_tweet = see, - twitter_unknown_error_request = An error occurred during the communication with Twitter. You can contact a href=\./Benutzer:Basti\Basti/a if this happens repeatedly., - twitter_tweet_too_long = Tweets are limited to 140 characters., - twitter_deletion_success = Tweet successfully deleted., - twitter_deletion_tweet_not_found = A Tweet with the given ID does not exist., - twitter_remaining_chars = Characters left, - twitter_your_last_tweets = Your last tweets, - twitter_delete_tweet_title_tag = Delete tweet, - twitter_delete_tweet_link_name = delete, - twitter_no_last_tweets = No tweets available, - twitter_description_template = Hickernews-Beschreibung, - twitter_advice_template = Hickernews-Hinweise, - twitter_access_error = You have to be span class=\plainlinks\a href=\/wiki/Spezial:UserLogin\ class=\external text\ title=\log in\ rel=\nofollow\logged in/a/span and \n. - span class=\plainlinks\a href=\/wiki/Spezial:Gruppenrechte\ class=\external text\ title=\See group rights\ \n. +$messages['en'] = array( + 'twitter' = 'Twitter', + 'communitytwitter-desc' = 'Provides a special page, where authorized users are able to twitter via a community account without the need of giving away login credentials', + 'twitter_no_db_connection' = 'No database connection possible.', + 'twitter_no_db' = 'Database does not exist.', + 'twitter_unknown_error' = 'Either you were blocked/your account is not set up or an unknown error occurred. + +In case you think you should have access, please contact a href=\'./Benutzer:Basti\'Basti/a.', # FIXME: Replace username with a more generic link. + 'twitter_connection_failure' = 'Connection to Twitter could not be established.', + 'twitter_tweet_section_title' = 'Tweet!', + 'twitter_logged_in_as' = 'Logged in as user', + 'twitter_update_success' = 'Status successfully updated', + 'twitter_check_tweet' = 'see', + 'twitter_unknown_error_request' = 'An error occurred during the communication with Twitter. You can contact a href=\'./Benutzer:Basti\'Basti/a if this happens repeatedly.', + 'twitter_tweet_too_long' = 'Tweets are limited to 140 characters.', + 'twitter_deletion_success' = 'Tweet successfully deleted.', + 'twitter_deletion_tweet_not_found' = 'A Tweet with the given ID does not exist.', + 'twitter_remaining_chars' = 'Characters left', + 'twitter_your_last_tweets' = 'Your last tweets', + 'twitter_delete_tweet_title_tag' = 'Delete tweet', + 'twitter_delete_tweet_link_name' = 'delete', + 'twitter_no_last_tweets' = 'No tweets available', + 'twitter_description_template' = 'Hickernews-Beschreibung', # FIXME: German - English + 'twitter_advice_template' = 'Hickernews-Hinweise', #
[MediaWiki-commits] [Gerrit] Fix minor syntax error introduced in last commit - change (mediawiki...CommunityTwitter)
FastLizard4 has uploaded a new change for review. https://gerrit.wikimedia.org/r/64260 Change subject: Fix minor syntax error introduced in last commit .. Fix minor syntax error introduced in last commit Change-ID of patchset of last commit is: I5e2e1350ab486814cb93fb9740abb4ad9aa7ddd2 Change-Id: Ibde80e87915a83d795bbbe631cce3a49ee8384b8 --- M Twitter.i18n.php 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CommunityTwitter refs/changes/60/64260/1 diff --git a/Twitter.i18n.php b/Twitter.i18n.php index cbb3346..8140e87 100755 --- a/Twitter.i18n.php +++ b/Twitter.i18n.php @@ -69,7 +69,7 @@ 'twitter_advice_template' = 'Hickernews-Hinweise', # FIXME: German - English 'twitter_access_error' = You have to be span class=\plainlinks\a href=\/wiki/Special:UserLogin\ class=\external text\ title=\log in\ rel=\nofollow\logged in/a/span and \n. span class=\plainlinks\a href=\/wiki/Special:ListGroupRights\ class=\external text\ title=\See group rights\ \n. - rel=\nofollow\allowed/a/span to access this page. + rel=\nofollow\allowed/a/span to access this page., 'rights-twitter' = 'Use Twitter special page', ); -- To view, visit https://gerrit.wikimedia.org/r/64260 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ibde80e87915a83d795bbbe631cce3a49ee8384b8 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/CommunityTwitter Gerrit-Branch: master Gerrit-Owner: FastLizard4 fastlizard4-git-comm...@fastlizard4.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fix minor syntax error introduced in last commit - change (mediawiki...CommunityTwitter)
FastLizard4 has submitted this change and it was merged. Change subject: Fix minor syntax error introduced in last commit .. Fix minor syntax error introduced in last commit Change-ID of patchset of last commit is: I5e2e1350ab486814cb93fb9740abb4ad9aa7ddd2 Change-Id: Ibde80e87915a83d795bbbe631cce3a49ee8384b8 --- M Twitter.i18n.php 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: FastLizard4: Verified; Looks good to me, approved diff --git a/Twitter.i18n.php b/Twitter.i18n.php index cbb3346..8140e87 100755 --- a/Twitter.i18n.php +++ b/Twitter.i18n.php @@ -69,7 +69,7 @@ 'twitter_advice_template' = 'Hickernews-Hinweise', # FIXME: German - English 'twitter_access_error' = You have to be span class=\plainlinks\a href=\/wiki/Special:UserLogin\ class=\external text\ title=\log in\ rel=\nofollow\logged in/a/span and \n. span class=\plainlinks\a href=\/wiki/Special:ListGroupRights\ class=\external text\ title=\See group rights\ \n. - rel=\nofollow\allowed/a/span to access this page. + rel=\nofollow\allowed/a/span to access this page., 'rights-twitter' = 'Use Twitter special page', ); -- To view, visit https://gerrit.wikimedia.org/r/64260 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibde80e87915a83d795bbbe631cce3a49ee8384b8 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/CommunityTwitter Gerrit-Branch: master Gerrit-Owner: FastLizard4 fastlizard4-git-comm...@fastlizard4.org Gerrit-Reviewer: FastLizard4 fastlizard4-git-comm...@fastlizard4.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Update URLs to point to the extension's proper location - change (mediawiki...TwoFactorAuthentication)
FastLizard4 has uploaded a new change for review. https://gerrit.wikimedia.org/r/62783 Change subject: Update URLs to point to the extension's proper location .. Update URLs to point to the extension's proper location Update URLs to MediaWiki Wiki Change-Id: I44929fd353f738b29369b8f741d64f49c72635ae --- M TwoFactorAuth.hooks.php M TwoFactorAuth.php 2 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TwoFactorAuthentication refs/changes/83/62783/1 diff --git a/TwoFactorAuth.hooks.php b/TwoFactorAuth.hooks.php index 7b6d504..ca90420 100644 --- a/TwoFactorAuth.hooks.php +++ b/TwoFactorAuth.hooks.php @@ -3,7 +3,7 @@ /** * TwoFactorAuth extension - Support for TOTP two-factor authentication * - * For more info see http://mediawiki.org/wiki/Extension:TwoFactorAuth + * For more info see http://mediawiki.org/wiki/Extension:TwoFactorAuthentication * * @file * @ingroup Extensions diff --git a/TwoFactorAuth.php b/TwoFactorAuth.php index 7560397..c325f01 100644 --- a/TwoFactorAuth.php +++ b/TwoFactorAuth.php @@ -2,7 +2,7 @@ /** * TwoFactorAuth extension - Support for TOTP two-factor authentication * - * For more info see http://mediawiki.org/wiki/Extension:TwoFactorAuth + * For more info see http://mediawiki.org/wiki/Extension:TwoFactorAuthentication * * @file * @ingroup Extensions @@ -22,7 +22,7 @@ 'name' = 'TwoFactorAuth', 'author' = 'Tyler Romeo', 'version' = '0.2', - 'url' = 'http://mediawiki.org/wiki/Extension:TwoFactorAuth', + 'url' = 'http://mediawiki.org/wiki/Extension:TwoFactorAuthentication', 'descriptionmsg' = 'twofactorauth-desc', ); -- To view, visit https://gerrit.wikimedia.org/r/62783 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I44929fd353f738b29369b8f741d64f49c72635ae Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/TwoFactorAuthentication Gerrit-Branch: master Gerrit-Owner: FastLizard4 fastlizard4-git-comm...@fastlizard4.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Rm errant backslash in XRDS preamble. - change (mediawiki...OpenID)
FastLizard4 has uploaded a new change for review. https://gerrit.wikimedia.org/r/52756 Change subject: Rm errant backslash in XRDS preamble. .. Rm errant backslash in XRDS preamble. This bit me when I was trying to get Extension:OpenID to work with OpenID auth on my Gerrit installation. Since removing this backslash made it work, I'm assuming that it may fix other bugs elsewhere too. Change-Id: Ida19d8f554b7ce7f5ed2b979cc6221f1de7217e4 --- M SpecialOpenIDXRDS.body.php 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/OpenID refs/changes/56/52756/1 diff --git a/SpecialOpenIDXRDS.body.php b/SpecialOpenIDXRDS.body.php index 37ca596..f45bd82 100644 --- a/SpecialOpenIDXRDS.body.php +++ b/SpecialOpenIDXRDS.body.php @@ -53,7 +53,7 @@ // XRDS preamble XML. $xml_template = array( '?xml version=1.0 encoding=UTF-8?' . '', - 'xrds:XRDS xmlns:xrds=xri://\$xrds xmlns:openid=http://openid.net/xmlns/1.0; xmlns=xri://$xrd*($v*2.0)', + 'xrds:XRDS xmlns:xrds=xri://$xrds xmlns:openid=http://openid.net/xmlns/1.0; xmlns=xri://$xrd*($v*2.0)', 'XRD', ); -- To view, visit https://gerrit.wikimedia.org/r/52756 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ida19d8f554b7ce7f5ed2b979cc6221f1de7217e4 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/OpenID Gerrit-Branch: master Gerrit-Owner: FastLizard4 fastlizard4-git-comm...@fastlizard4.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Allow override of the MySQL server bind address through the ... - change (operations/puppet)
FastLizard4 has uploaded a new change for review. Change subject: Allow override of the MySQL server bind address through the mysql_server_bind_address puppet variable. The default will still be 127.0.0.1 (end result: Instance administrators may now set their MySQL server's bind address in their NovaInstance configurat .. Allow override of the MySQL server bind address through the mysql_server_bind_address puppet variable. The default will still be 127.0.0.1 (end result: Instance administrators may now set their MySQL server's bind address in their NovaInstance configuration). Change-Id: I33cef6cf78df4102d0508df4683e84fcc9579aae --- M manifests/mysql.pp 1 file changed, 16 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/operations/puppet refs/changes/85/48585/1 -- To view, visit https://gerrit.wikimedia.org/r/48585 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I33cef6cf78df4102d0508df4683e84fcc9579aae Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: FastLizard4 fastlizard4-git-comm...@fastlizard4.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
