[MediaWiki-commits] [Gerrit] Implementation of snakformatted property table in Lua - change (mediawiki...Wikibase)
Jens Ohlig has uploaded a new change for review.
https://gerrit.wikimedia.org/r/101201
Change subject: Implementation of snakformatted property table in Lua
..
Implementation of snakformatted property table in Lua
Change-Id: I6db8dfcc999f05630ee9a82a67dfabc6f1693b06
---
M client/includes/scribunto/Scribunto_LuaWikibaseLibrary.php
M client/includes/scribunto/Scribunto_LuaWikibaseLibraryImplementation.php
M client/includes/scribunto/mw.wikibase.lua
M
client/tests/phpunit/includes/scribunto/Scribunto_LuaWikibaseLibraryImplementationTest.php
4 files changed, 100 insertions(+), 7 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/01/101201/1
diff --git a/client/includes/scribunto/Scribunto_LuaWikibaseLibrary.php
b/client/includes/scribunto/Scribunto_LuaWikibaseLibrary.php
index b95df46..37d6105 100644
--- a/client/includes/scribunto/Scribunto_LuaWikibaseLibrary.php
+++ b/client/includes/scribunto/Scribunto_LuaWikibaseLibrary.php
@@ -1,7 +1,10 @@
?php
+use ValueFormatters\FormatterOptions;
use ValueParsers\ParseException;
use Wikibase\Client\WikibaseClient;
+use Wikibase\DataModel\Entity\EntityId;
+use Wikibase\Lib\SnakFormatter;
/**
* Registers and defines functions to access Wikibase through the Scribunto
extension
@@ -28,10 +31,12 @@
// See Scribunto_LuaLanguageLibrary::getContLangCode().
global $wgContLang;
$language = $wgContLang;
+ $formatterOptions = new FormatterOptions( array( language =
$language ) );
$this-wbLibrary = new
Scribunto_LuaWikibaseLibraryImplementation(
WikibaseClient::getDefaultInstance()-getEntityIdParser(), // EntityIdParser
WikibaseClient::getDefaultInstance()-getStore()-getEntityLookup(), //
EntityLookup
WikibaseClient::getDefaultInstance()-getEntityIdFormatter(), //
EntityIdFormatter
+
WikibaseClient::getDefaultInstance()-getSnakFormatterFactory()-getSnakFormatter(
SnakFormatter::FORMAT_WIKI, $formatterOptions ), // SnakFormatter
WikibaseClient::getDefaultInstance()-getStore()-getSiteLinkTable(), //
SiteLinkLookup
$language, // language
WikibaseClient::getDefaultInstance()-getSettings()-getSetting( 'siteGlobalID'
) // siteId
@@ -48,7 +53,8 @@
$lib = array(
'getEntity' = array( $this, 'getEntity' ),
'getEntityId' = array( $this, 'getEntityId' ),
- 'getGlobalSiteId' = array( $this, 'getGlobalSiteId' )
+ 'getGlobalSiteId' = array( $this, 'getGlobalSiteId' ),
+ 'renderForEntityId' = array( $this,
'renderForEntityId' )
);
$this-getEngine()-registerInterface( dirname( __FILE__ ) .
'/mw.wikibase.lua', $lib, array() );
}
@@ -92,6 +98,15 @@
}
/**
+* Wrapper for renderForEntityId in
Scribunto_LuaWikibaseLibraryImplementation
+*
+* @since 0.5
+*
+*/
+ public function renderForEntityId( $entityId, $propertyId ) {
+ return $this-wbLibrary-renderForEntityId( $entityId,
$propertyId );
+ }
+ /**
* Wrapper for getGlobalSiteId in
Scribunto_LuaWikibaseLibraryImplementation
*
* @since 0.5
diff --git
a/client/includes/scribunto/Scribunto_LuaWikibaseLibraryImplementation.php
b/client/includes/scribunto/Scribunto_LuaWikibaseLibraryImplementation.php
index 302619e..cf87a2b 100644
--- a/client/includes/scribunto/Scribunto_LuaWikibaseLibraryImplementation.php
+++ b/client/includes/scribunto/Scribunto_LuaWikibaseLibraryImplementation.php
@@ -2,6 +2,9 @@
use Wikibase\Item;
use Wikibase\DataModel\Entity\EntityId;
+use Wikibase\Claims;
+use Wikibase\Entity;
+use Wikibase\Snak;
use Wikibase\EntityLookup;
use Wikibase\SiteLinkLookup;
use Wikibase\Lib\Serializers\SerializationOptions;
@@ -10,7 +13,8 @@
use Wikibase\Lib\EntityIdParser;
use Wikibase\LanguageFallbackChainFactory;
use Wikibase\Utils;
-use \Language;
+use Wikibase\Lib\SnakFormatter;
+
/**
* Actual implementations of the functions to access Wikibase through the
Scribunto extension
@@ -40,6 +44,8 @@
/* @var mixed */
protected $siteId;
+ /* @var SnakFormatter */
+ protected $snaksFormatter;
/**
* @param EntityIdParser $entityIdParser
@@ -47,6 +53,7 @@
public function __construct( EntityIdParser $entityIdParser,
EntityLookup
$entityLookup,
EntityIdFormatter $entityIdFormatter,
+SnakFormatter
$snakFormatter,
[MediaWiki-commits] [Gerrit] Add mw.wikibase.properties as a Lua function - change (mediawiki...Wikibase)
Jens Ohlig has uploaded a new change for review.
https://gerrit.wikimedia.org/r/100577
Change subject: Add mw.wikibase.properties as a Lua function
..
Add mw.wikibase.properties as a Lua function
Change-Id: I5e1bbe0fd8586ebda123a5aafe73292234b23978
---
M client/includes/scribunto/Scribunto_LuaWikibaseLibrary.php
M client/includes/scribunto/Scribunto_LuaWikibaseLibraryImplementation.php
M client/includes/scribunto/mw.wikibase.lua
M
client/tests/phpunit/includes/scribunto/Scribunto_LuaWikibaseLibraryImplementationTest.php
4 files changed, 60 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/77/100577/1
diff --git a/client/includes/scribunto/Scribunto_LuaWikibaseLibrary.php
b/client/includes/scribunto/Scribunto_LuaWikibaseLibrary.php
index 007d5ef..b95df46 100644
--- a/client/includes/scribunto/Scribunto_LuaWikibaseLibrary.php
+++ b/client/includes/scribunto/Scribunto_LuaWikibaseLibrary.php
@@ -1,6 +1,5 @@
?php
-use Wikibase\Settings;
use ValueParsers\ParseException;
use Wikibase\Client\WikibaseClient;
@@ -35,7 +34,7 @@
WikibaseClient::getDefaultInstance()-getEntityIdFormatter(), //
EntityIdFormatter
WikibaseClient::getDefaultInstance()-getStore()-getSiteLinkTable(), //
SiteLinkLookup
$language, // language
- Settings::get( 'siteGlobalID' ) // SiteID
+
WikibaseClient::getDefaultInstance()-getSettings()-getSetting( 'siteGlobalID'
) // siteId
);
parent::__construct( $engine );
}
@@ -46,7 +45,11 @@
* @since 0.4
*/
public function register() {
- $lib = array( 'getEntity' = array( $this, 'getEntity' ),
'getEntityId' = array( $this, 'getEntityId' ), 'getGlobalSiteId' = array(
$this, 'getGlobalSiteId' ) );
+ $lib = array(
+ 'getEntity' = array( $this, 'getEntity' ),
+ 'getEntityId' = array( $this, 'getEntityId' ),
+ 'getGlobalSiteId' = array( $this, 'getGlobalSiteId' )
+ );
$this-getEngine()-registerInterface( dirname( __FILE__ ) .
'/mw.wikibase.lua', $lib, array() );
}
diff --git
a/client/includes/scribunto/Scribunto_LuaWikibaseLibraryImplementation.php
b/client/includes/scribunto/Scribunto_LuaWikibaseLibraryImplementation.php
index f46bb38..302619e 100644
--- a/client/includes/scribunto/Scribunto_LuaWikibaseLibraryImplementation.php
+++ b/client/includes/scribunto/Scribunto_LuaWikibaseLibraryImplementation.php
@@ -55,7 +55,7 @@
$this-entityIdFormatter = $entityIdFormatter;
$this-siteLinkTable = $siteLinkTable;
$this-language = $language;
- $this-siteId;
+ $this-siteId = $siteId;
}
diff --git a/client/includes/scribunto/mw.wikibase.lua
b/client/includes/scribunto/mw.wikibase.lua
index 721da00..f42b98f 100644
--- a/client/includes/scribunto/mw.wikibase.lua
+++ b/client/includes/scribunto/mw.wikibase.lua
@@ -28,12 +28,14 @@
function wikibase.setupInterface()
local php = mw_interface
mw_interface = nil
+
wikibase.getEntity = function ()
local id = php.getEntityId( tostring(
mw.title.getCurrentTitle().prefixedText ) )
if id == nil then return nil end
local entity = php.getEntity( id )
return entity
end
+
wikibase.label = function ( id )
local code = mw.language.getContentLanguage():getCode()
if code == nil then return nil end
@@ -43,6 +45,7 @@
if label == nil then return nil end
return label.value
end
+
wikibase.sitelink = function ( id )
local entity = php.getEntity( id )
if entity == nil or entity.sitelinks == nil then return nil end
@@ -52,6 +55,44 @@
if sitelink == nil then return nil end
return sitelink.title
end
+
+ wikibase.properties = function ()
+local entity = {}
+entity = wikibase.getEntity()
+local properties = {}
+local n=0
+if entity.claims == nil then return {} end
+for k,v in pairs( entity.claims ) do
+ n=n+1
+ properties[n]=k
+end
+local filter = function( func, xs )
+ local table= {}
+ for i,v in pairs( xs ) do
+ if func( v ) then
+table[i]=v
+ end
+ end
+ return table
+ end
+ local is_capital_property = function( x )
+return ( string.match( x, '^%u%d+' ) ~= nil )
+ end
+ properties = filter( is_capital_property, properties )
+ n = 0
+ local p = {}
+ for k,v in pairs( properties ) do
+ n=n+1
+ p[n]=v
+ end
+ properties = p
+ p = {}
+ for i,v in pairs( properties ) do
+p[v] = { [label] = wikibase.label( v ) }
+ end
+ return p
+ end
+
mw = mw or {}
[MediaWiki-commits] [Gerrit] (Bug 54324) Sequences in Lua should start with 1 - change (mediawiki...Wikibase)
Jens Ohlig has uploaded a new change for review.
https://gerrit.wikimedia.org/r/96232
Change subject: (Bug 54324) Sequences in Lua should start with 1
..
(Bug 54324) Sequences in Lua should start with 1
Change-Id: I26c2526cc6258c18ccd83c6e1404eb9269802178
---
M client/includes/scribunto/Scribunto_LuaWikibaseLibraryImplementation.php
1 file changed, 21 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/32/96232/1
diff --git
a/client/includes/scribunto/Scribunto_LuaWikibaseLibraryImplementation.php
b/client/includes/scribunto/Scribunto_LuaWikibaseLibraryImplementation.php
index 077f4c7..8644699 100644
--- a/client/includes/scribunto/Scribunto_LuaWikibaseLibraryImplementation.php
+++ b/client/includes/scribunto/Scribunto_LuaWikibaseLibraryImplementation.php
@@ -45,6 +45,25 @@
$this-siteLinkTable = $siteLinkTable;
}
+ /**
+* Recursively renumber a serialized array in place, so it is indexed
at 1, not 0.
+* Just like Lua wants it.
+*
+* @since 0.5
+*
+* @param array $entityArr
+*/
+ public function renumber( $entityArr ) {
+ foreach( $entityArr as $key = $value ) {
+ if ( is_array( $value ) ) {
+ if ( array_key_exists( 0, $value ) ) {
+ $value = array_combine( range( 1,
count( $value ) ), array_values( $value ) );
+ }
+ $this-renumber( $value );
+ }
+ }
+ }
+
/**
* Get entity from prefixed ID (e.g. Q23) and return it as serialized
array.
@@ -94,6 +113,8 @@
$serializer = $serializerFactory-newSerializerForObject(
$entityObject, $opt );
$entityArr = $serializer-getSerialized( $entityObject );
+ $this-renumber( $entityArr ); // Renumber the array
+
return array( $entityArr );
}
--
To view, visit https://gerrit.wikimedia.org/r/96232
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I26c2526cc6258c18ccd83c6e1404eb9269802178
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jens Ohlig jens.oh...@wikimedia.de
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Refactored Wikibase Lua library code to make everything test... - change (mediawiki...Wikibase)
Jens Ohlig has uploaded a new change for review.
https://gerrit.wikimedia.org/r/95598
Change subject: Refactored Wikibase Lua library code to make everything
testable.
..
Refactored Wikibase Lua library code to make everything testable.
Change-Id: Ifab855fa635ad096fcdb94d3cad1e0c4784a6f92
---
M client/WikibaseClient.classes.php
D client/includes/WikibaseLibrary.php
A client/includes/scribunto/Scribunto_LuaWikibaseLibrary.php
A client/includes/scribunto/Scribunto_LuaWikibaseLibraryImplementation.php
R client/includes/scribunto/mw.wikibase.lua
A
client/tests/phpunit/includes/scribunto/Scribunto_LuaWikibaseLibraryImplementationTest.php
6 files changed, 310 insertions(+), 156 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/98/95598/1
diff --git a/client/WikibaseClient.classes.php
b/client/WikibaseClient.classes.php
index ad69ac6..5140f44 100644
--- a/client/WikibaseClient.classes.php
+++ b/client/WikibaseClient.classes.php
@@ -22,7 +22,6 @@
'Wikibase\RepoItemLinkGenerator' =
'includes/RepoItemLinkGenerator.php',
'Wikibase\RepoLinker' = 'includes/RepoLinker.php',
'Wikibase\Client\WikibaseClient' =
'includes/WikibaseClient.php',
- 'Scribunto_LuaWikibaseLibrary' =
'includes/WikibaseLibrary.php',
'Wikibase\PageUpdater' = 'includes/PageUpdater.php',
'Wikibase\SiteLinkCommentCreator' =
'includes/SiteLinkCommentCreator.php',
'Wikibase\WikiPageUpdater' = 'includes/WikiPageUpdater.php',
@@ -61,6 +60,10 @@
'Wikibase\DirectSqlStore' =
'includes/store/sql/DirectSqlStore.php',
'Wikibase\EntityCacheTable' =
'includes/store/sql/EntityCacheTable.php',
+ // includes/scribunto
+ 'Scribunto_LuaWikibaseLibrary' =
'includes/scribunto/Scribunto_LuaWikibaseLibrary.php',
+ 'Scribunto_LuaWikibaseLibraryImplementation' =
'includes/scribunto/Scribunto_LuaWikibaseLibraryImplementation.php',
+
// test
'Wikibase\Test\MockPageUpdater' =
'tests/phpunit/MockPageUpdater.php'
diff --git a/client/includes/WikibaseLibrary.php
b/client/includes/WikibaseLibrary.php
deleted file mode 100644
index 91be67b..000
--- a/client/includes/WikibaseLibrary.php
+++ /dev/null
@@ -1,155 +0,0 @@
-?php
-
-/**
- * Registers and defines functions to access Wikibase through the Scribunto
extension
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License along
- * with this program; if not, write to the Free Software Foundation, Inc.,
- * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
- * http://www.gnu.org/copyleft/gpl.html
- *
- * @since 0.4
- *
- * @licence GNU GPL v2+
- * @author Jens Ohlig jens.oh...@wikimedia.de
- */
-
-use ValueParsers\ParseException;
-use Wikibase\Client\WikibaseClient;
-use Wikibase\Lib\Serializers\SerializationOptions;
-use Wikibase\Lib\Serializers\SerializerFactory;
-use Wikibase\LanguageFallbackChainFactory;
-use Wikibase\Utils;
-
-class Scribunto_LuaWikibaseLibrary extends Scribunto_LuaLibraryBase {
-
- /**
-* Register mw.wikibase.lua library
-*
-* @since 0.4
-*/
- public function register() {
- $lib = array(
- 'getEntity' = array( $this, 'getEntity' ),
- 'getEntityId' = array( $this, 'getEntityId' ),
- 'getGlobalSiteId' = array( $this, 'getGlobalSiteId' )
- );
- $this-getEngine()-registerInterface( dirname( __FILE__ ) .
'/../resources/' . 'mw.wikibase.lua', $lib, array() );
- }
-
- /**
-* Get entity from prefixed ID (e.g. Q23) and return it as serialized
array.
-*
-* @since 0.4
-*
-* @param string $prefixedEntityId
-*
-* @throws ScribuntoException
-* @return array $entityArr
-*/
- public function getEntity( $prefixedEntityId = null ) {
- $this-checkType( 'getEntity', 1, $prefixedEntityId, 'string' );
- $prefixedEntityId = trim( $prefixedEntityId );
-
- $entityIdParser =
WikibaseClient::getDefaultInstance()-getEntityIdParser();
-
- try {
- $entityId = $entityIdParser-parse( $prefixedEntityId );
- }
-
[MediaWiki-commits] [Gerrit] (bug 54324) sequence in Lua should start with 1 - change (mediawiki...Wikibase)
Jens Ohlig has uploaded a new change for review.
https://gerrit.wikimedia.org/r/94909
Change subject: (bug 54324) sequence in Lua should start with 1
..
(bug 54324) sequence in Lua should start with 1
Change-Id: Ieeaca61a027e7461bb91477243c9bce76e221f97
---
M client/includes/WikibaseLibrary.php
1 file changed, 22 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/09/94909/1
diff --git a/client/includes/WikibaseLibrary.php
b/client/includes/WikibaseLibrary.php
index 91be67b..a2203b4 100644
--- a/client/includes/WikibaseLibrary.php
+++ b/client/includes/WikibaseLibrary.php
@@ -45,7 +45,26 @@
'getGlobalSiteId' = array( $this, 'getGlobalSiteId' )
);
$this-getEngine()-registerInterface( dirname( __FILE__ ) .
'/../resources/' . 'mw.wikibase.lua', $lib, array() );
- }
+}
+
+ /**
+ * Recursively renumber a serialized array in place, so it is indexed at
1, not 0.
+ * Just like Lua wants it.
+*
+* @since 0.5
+*
+* @param array $entityArr
+ */
+public function renumber( $entityArr ) {
+foreach( $entityArr as $key = $value ) {
+if ( is_array( $value ) ) {
+if ( array_key_exists( 0, $value ) ) {
+$value = array_combine( range( 1, count( $value ) ),
array_values( $value ) );
+}
+$this-renumber( $value );
+}
+}
+}
/**
* Get entity from prefixed ID (e.g. Q23) and return it as serialized
array.
@@ -104,7 +123,8 @@
try {
$entityArr = $serializer-getSerialized( $entityObject
);
- return array( $entityArr );
+$this-renumber( $entityArr ); // Renumber the array
+return array( $entityArr );
} catch ( \Exception $e ) {
throw $this-getEngine()-newException(
'wikibase-error-serialize-error' );
}
--
To view, visit https://gerrit.wikimedia.org/r/94909
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieeaca61a027e7461bb91477243c9bce76e221f97
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jens Ohlig jens.oh...@wikimedia.de
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fix an error in the lua api when the entity has no label or ... - change (mediawiki...Wikibase)
Jens Ohlig has submitted this change and it was merged. Change subject: Fix an error in the lua api when the entity has no label or sitelink .. Fix an error in the lua api when the entity has no label or sitelink If an entity has no label the entry labels doesn't exists in the table and made the script fail. Idem for sitelinks. Change-Id: I220996203ac88890ea8a2c50193e0932a907ddcd --- M client/resources/mw.wikibase.lua 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jens Ohlig: Verified; Looks good to me, approved Daniel Kinzler: Looks good to me, but someone else must approve jenkins-bot: Checked diff --git a/client/resources/mw.wikibase.lua b/client/resources/mw.wikibase.lua index a696ce8..721da00 100644 --- a/client/resources/mw.wikibase.lua +++ b/client/resources/mw.wikibase.lua @@ -38,14 +38,14 @@ local code = mw.language.getContentLanguage():getCode() if code == nil then return nil end local entity = php.getEntity( id ) -if entity == nil then return nil end +if entity == nil or entity.labels == nil then return nil end local label = entity.labels[code] if label == nil then return nil end return label.value end wikibase.sitelink = function ( id ) local entity = php.getEntity( id ) -if entity == nil then return nil end +if entity == nil or entity.sitelinks == nil then return nil end local globalSiteId = php.getGlobalSiteId() if globalSiteId == nil then return nil end local sitelink = entity.sitelinks[globalSiteId] -- To view, visit https://gerrit.wikimedia.org/r/56737 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I220996203ac88890ea8a2c50193e0932a907ddcd Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Tpt thoma...@hotmail.fr Gerrit-Reviewer: Aude aude.w...@gmail.com Gerrit-Reviewer: Daniel Kinzler daniel.kinz...@wikimedia.de Gerrit-Reviewer: Jens Ohlig jens.oh...@wikimedia.de Gerrit-Reviewer: Tobias Gritschacher tobias.gritschac...@wikimedia.de Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fixes problem with items that have no sitelinks as reported ... - change (mediawiki...Wikibase)
Jens Ohlig has uploaded a new change for review. https://gerrit.wikimedia.org/r/57903 Change subject: Fixes problem with items that have no sitelinks as reported in http://www.mediawiki.org/wiki/Extension_talk:WikibaseClient/Lua#Troble_while_accessing_personalia .. Fixes problem with items that have no sitelinks as reported in http://www.mediawiki.org/wiki/Extension_talk:WikibaseClient/Lua#Troble_while_accessing_personalia Change-Id: I7971c77a91928948a6015b9bf9ea28eb4a87c0c4 --- M client/resources/mw.wikibase.lua 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/03/57903/1 diff --git a/client/resources/mw.wikibase.lua b/client/resources/mw.wikibase.lua index a696ce8..fb15a9c 100644 --- a/client/resources/mw.wikibase.lua +++ b/client/resources/mw.wikibase.lua @@ -48,6 +48,7 @@ if entity == nil then return nil end local globalSiteId = php.getGlobalSiteId() if globalSiteId == nil then return nil end +if entity.sitelinks == nil then return nil end local sitelink = entity.sitelinks[globalSiteId] if sitelink == nil then return nil end return sitelink.title -- To view, visit https://gerrit.wikimedia.org/r/57903 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7971c77a91928948a6015b9bf9ea28eb4a87c0c4 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jens Ohlig jens.oh...@wikimedia.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (#46125) Lua function label(id) that takes an ID and returns... - change (mediawiki...Wikibase)
Jens Ohlig has uploaded a new change for review.
https://gerrit.wikimedia.org/r/54647
Change subject: (#46125) Lua function label(id) that takes an ID and returns
the label in the language of the client Wiki
..
(#46125) Lua function label(id) that takes an ID and returns the label in the
language of the client Wiki
Change-Id: Iecc7cf51ced432d25fb161f3639f791029979f7e
---
M client/resources/mw.wikibase.lua
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/47/54647/1
diff --git a/client/resources/mw.wikibase.lua b/client/resources/mw.wikibase.lua
index 533fb4d..5d7c481 100644
--- a/client/resources/mw.wikibase.lua
+++ b/client/resources/mw.wikibase.lua
@@ -28,6 +28,7 @@
function wikibase.setupInterface()
local title = require('mw.title')
local site = require('mw.site')
+ local language = require('mw.language')
local php = mw_interface
mw_interface = nil
wikibase.getEntity = function()
@@ -36,6 +37,10 @@
entity = php.getEntity(id)
return entity
end
+ wikibase.label = function(id)
+code = language.getContentLanguage().code
+return php.getEntity(id).labels[code].value
+ end
mw = mw or {}
mw.wikibase = wikibase
package.loaded['mw.wikibase'] = wikibase
--
To view, visit https://gerrit.wikimedia.org/r/54647
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iecc7cf51ced432d25fb161f3639f791029979f7e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jens Ohlig jens.oh...@wikimedia.de
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (#46126) Lua function sitelink(id) that returns the link wit... - change (mediawiki...Wikibase)
Jens Ohlig has uploaded a new change for review.
https://gerrit.wikimedia.org/r/54666
Change subject: (#46126) Lua function sitelink(id) that returns the link with
the element
..
(#46126) Lua function sitelink(id) that returns the link with the element
Change-Id: I675ad7072572c25569da41332ae4e9c2c3a3aaea
---
M client/includes/WikibaseLibrary.php
M client/resources/mw.wikibase.lua
2 files changed, 21 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/66/54666/1
diff --git a/client/includes/WikibaseLibrary.php
b/client/includes/WikibaseLibrary.php
index 5cb8fe8..517331f 100644
--- a/client/includes/WikibaseLibrary.php
+++ b/client/includes/WikibaseLibrary.php
@@ -35,6 +35,7 @@
$lib = array(
'getEntity' = array( $this, 'getEntity' ),
'getEntityId' = array( $this, 'getEntityId' )
+ 'getGlobalSiteId' = array( $this, 'getGlobalSiteId' )
);
$this-getEngine()-registerInterface( dirname( __FILE__ ) .
'/../resources/' . 'mw.wikibase.lua', $lib, array() );
}
@@ -103,4 +104,15 @@
return array( $id-getPrefixedId() );
}
+/**
+ * Get global site ID (e.g. enwiki)
+ * This is basically a helper function.
+ * I can see this becoming part of mw.site in the Scribunto extension.
+ *
+ * @since 0.4
+ *
+ */
+public function getGlobalSiteId() {
+return array( \Wikibase\Settings::get( 'siteGlobalID' ) );
+}
}
diff --git a/client/resources/mw.wikibase.lua b/client/resources/mw.wikibase.lua
index 7139ab8..850325b 100644
--- a/client/resources/mw.wikibase.lua
+++ b/client/resources/mw.wikibase.lua
@@ -43,6 +43,15 @@
if label == nil then return nil end
return label.value
end
+ wikibase.sitelink = function ( id )
+local entity = php.getEntity( id )
+if entity == nil then return nil end
+local globalSiteId = php.getGlobalSiteId()
+if globalSiteId == nil then return nil end
+local sitelink = entity.sitelinks[globalSiteId]
+if sitelink == nil then return nil end
+return sitelink.value
+ end
mw = mw or {}
mw.wikibase = wikibase
package.loaded['mw.wikibase'] = wikibase
--
To view, visit https://gerrit.wikimedia.org/r/54666
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I675ad7072572c25569da41332ae4e9c2c3a3aaea
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jens Ohlig jens.oh...@wikimedia.de
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Stopgap to avoid excessively long string values (backport) - change (mediawiki...DataValues)
Jens Ohlig has submitted this change and it was merged.
Change subject: Stopgap to avoid excessively long string values (backport)
..
Stopgap to avoid excessively long string values (backport)
Change-Id: I9b20d0d4bad5f68cd0cc440ee1995193ecec9abd
---
M DataValues/includes/values/StringValue.php
1 file changed, 12 insertions(+), 0 deletions(-)
Approvals:
Jens Ohlig: Verified; Looks good to me, approved
jenkins-bot: Checked
diff --git a/DataValues/includes/values/StringValue.php
b/DataValues/includes/values/StringValue.php
index caacbe5..e23cab1 100644
--- a/DataValues/includes/values/StringValue.php
+++ b/DataValues/includes/values/StringValue.php
@@ -53,6 +53,18 @@
throw new InvalidArgumentException( 'Can only construct
StringValue from strings' );
}
+ // This is backporting the very evil hack I added for the last
deployment as can be found
+ // here:
+ //
https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/DataValues.git;a=commitdiff;h=8a980bc893824dcf86be51350ede893fe950bce2
+ //
https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/DataValues.git;a=commitdiff;h=f049d35c3fd8cd69969396238a89e4dc31701f39
+ // It is still very evil. Last time I pledged that I would be
loosing karma for a week.
+ // Since the following I had the unfortunate incident of a
pulled hamstring - which, by
+ // the way, hurts a lot - I will refrain from committing any
new karma this time. I hope
+ // that by the next deployment or two we can get rid of this
terrible hack.
+ if ( mb_strlen( $value ) 400 ) {
+ throw new InvalidArgumentException( 'String length
exceeds limit of 400 characters' );
+ }
+
$this-value = $value;
}
--
To view, visit https://gerrit.wikimedia.org/r/54674
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9b20d0d4bad5f68cd0cc440ee1995193ecec9abd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DataValues
Gerrit-Branch: mw1.21-wmf12
Gerrit-Owner: Denny Vrandecic denny.vrande...@wikimedia.de
Gerrit-Reviewer: Jens Ohlig jens.oh...@wikimedia.de
Gerrit-Reviewer: jenkins-bot
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (#46124) Restrict getEntity to connected entity only - change (mediawiki...Wikibase)
Jens Ohlig has uploaded a new change for review.
https://gerrit.wikimedia.org/r/54471
Change subject: (#46124) Restrict getEntity to connected entity only
..
(#46124) Restrict getEntity to connected entity only
Change-Id: Ie916bad460f0f42ac220c6e74edfe9105b9b4e8e
---
M client/includes/WikibaseLibrary.php
M client/resources/mw.wikibase.lua
2 files changed, 32 insertions(+), 6 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/71/54471/1
diff --git a/client/includes/WikibaseLibrary.php
b/client/includes/WikibaseLibrary.php
index 3b276fe..a4ccfbc 100644
--- a/client/includes/WikibaseLibrary.php
+++ b/client/includes/WikibaseLibrary.php
@@ -32,7 +32,10 @@
* @since 0.4
*/
public function register() {
- $lib = array( 'getEntity' = array( $this, 'getEntity' ) );
+$lib = array(
+'getEntity' = array( $this, 'getEntity' ),
+'getEntityByTitle' = array( $this, 'getEntityByTitle' )
+);
$this-getEngine()-registerInterface( dirname( __FILE__ ) .
'/../resources/' . 'mw.wikibase.lua', $lib, array() );
}
/**
@@ -58,7 +61,7 @@
Wikibase\EntityId::newFromPrefixedId( $prefixedEntityId
)
);
if ( $entityObject == null ) {
- return null;
+ return ( null );
}
$serializerFactory = new
\Wikibase\Lib\Serializers\SerializerFactory();
$serializer = $serializerFactory-newSerializerForObject(
$entityObject );
@@ -69,4 +72,21 @@
$entityArr = $serializer-getSerialized( $entityObject );
return array( $entityArr );
}
+public function getEntityByTitle( $pageTitle = null ) {
+ $this-checkType( 'getEntityByTitle', 1, $pageTitle, 'string' );
+$globalSiteId = \Wikibase\Settings::get(siteGlobalID);
+$table = \Wikibase\ClientStoreFactory::getStore( 'sqlstore'
)-newSiteLinkTable();
+if ( $table == null ) {
+return array( null );
+}
+$numericId = $table-getItemIdForLink( $globalSiteId, $pageTitle );
+if ( !is_int( $numericId ) ) {
+return array( null );
+}
+$id = new Wikibase\EntityId( \Wikibase\Item::ENTITY_TYPE, $numericId );
+if ( $id == null ) {
+return array( null );
+}
+return array( $id-getPrefixedId() );
+}
}
diff --git a/client/resources/mw.wikibase.lua b/client/resources/mw.wikibase.lua
index 65bfb68..b4347de 100644
--- a/client/resources/mw.wikibase.lua
+++ b/client/resources/mw.wikibase.lua
@@ -26,14 +26,20 @@
local wikibase = {}
function wikibase.setupInterface()
- for k, v in pairs( mw_interface ) do
-wikibase[k] = v
+ local title = require('mw.title')
+ local site = require('mw.site')
+ local php = mw_interface
+ mw_interface = nil
+ wikibase.getEntity = function()
+id = php.getEntityByTitle(tostring(title.getCurrentTitle()))
+if (id == nil) then return nil end
+entity = php.getEntity(id)
+return entity
end
mw = mw or {}
mw.wikibase = wikibase
package.loaded['mw.wikibase'] = wikibase
- mw_interface = nil
wikibase.setupInterface = nil
-end
+end
return wikibase
--
To view, visit https://gerrit.wikimedia.org/r/54471
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie916bad460f0f42ac220c6e74edfe9105b9b4e8e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jens Ohlig jens.oh...@wikimedia.de
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Portable DIRECTORY_SEPARATOR :) - change (mediawiki...Scribunto)
Jens Ohlig has uploaded a new change for review.
https://gerrit.wikimedia.org/r/53754
Change subject: Portable DIRECTORY_SEPARATOR :)
..
Portable DIRECTORY_SEPARATOR :)
Change-Id: I61d2ddc5367c2ffacd68c12bf9b6037cfc39d487
---
M engines/LuaCommon/LuaCommon.php
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Scribunto
refs/changes/54/53754/1
diff --git a/engines/LuaCommon/LuaCommon.php b/engines/LuaCommon/LuaCommon.php
index cbf15d2..10f126c 100644
--- a/engines/LuaCommon/LuaCommon.php
+++ b/engines/LuaCommon/LuaCommon.php
@@ -135,7 +135,7 @@
* @return string
*/
protected function normalizeModuleFileName( $fileName ) {
- return $fileName[0] !== '/' ?
{$this-getLuaLibDir()}/{$fileName} : $fileName;
+ return $fileName[0] !== DIRECTORY_SEPARATOR ?
{$this-getLuaLibDir()}/{$fileName} : $fileName;
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/53754
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I61d2ddc5367c2ffacd68c12bf9b6037cfc39d487
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Scribunto
Gerrit-Branch: master
Gerrit-Owner: Jens Ohlig jens.oh...@wikimedia.de
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Lua support to access the repo data and implement getEntity - change (mediawiki...Wikibase)
Jens Ohlig has uploaded a new change for review.
https://gerrit.wikimedia.org/r/53570
Change subject: Lua support to access the repo data and implement getEntity
..
Lua support to access the repo data and implement getEntity
Change-Id: I9fd05c36f32bffdeb15fb793e7c3332032b3541e
---
M client/WikibaseClient.hooks.php
M client/WikibaseClient.php
A client/includes/WikibaseLibrary.php
A client/resources/mw.wikibase.lua
4 files changed, 47 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/70/53570/1
diff --git a/client/WikibaseClient.hooks.php b/client/WikibaseClient.hooks.php
index f2b005e..7538650 100644
--- a/client/WikibaseClient.hooks.php
+++ b/client/WikibaseClient.hooks.php
@@ -398,6 +398,16 @@
return true;
}
+/**
+ * External library for Scribunto
+ *
+ * @return bool
+ */
+public static function onScribuntoExternalLibraries ( $engine, array
$extraLibraries ) {
+$extraLibraries['mw.wikibase'] = 'Scribunto_LuaWikibaseLibrary';
+return true;
+}
+
/**
* Hook for modifying the query for fetching recent changes
* @see
https://www.mediawiki.org/wiki/Manual:Hooks/SpecialRecentChangesQuery
diff --git a/client/WikibaseClient.php b/client/WikibaseClient.php
index 2345169..e86ac06 100644
--- a/client/WikibaseClient.php
+++ b/client/WikibaseClient.php
@@ -65,6 +65,7 @@
$wgAutoloadClasses['Wikibase\LangLinkHandler'] = $dir .
'includes/LangLinkHandler.php';
$wgAutoloadClasses['Wikibase\ChangeHandler'] = $dir .
'includes/ChangeHandler.php';
$wgAutoloadClasses['Wikibase\NamespaceChecker']= $dir .
'includes/NamespaceChecker.php';
+$wgAutoloadClasses['Scribunto_LuaWikibaseLibrary'] = $dir .
'includes/WikibaseLibrary.php';
// includes/api
$wgAutoloadClasses['Wikibase\ApiClientInfo'] = $dir .
'includes/api/ApiClientInfo.php';
@@ -114,7 +115,7 @@
$wgHooks['GetPreferences'][] =
'\Wikibase\ClientHooks::onGetPreferences';
$wgHooks['BeforePageDisplay'][]=
'\Wikibase\ClientHooks::onBeforePageDisplay';
$wgHooks['SpecialPageBeforeExecute'][] =
'\Wikibase\ClientHooks::onSpecialPageBeforeExecute';
-
+$wgHooks['ScribuntoExternalLibraries'][] =
'\Wikibase\ClientHooks::onScribuntoExternalLibraries';
// extension hooks
$wgHooks['WikibasePollHandle'][]=
'\Wikibase\ClientHooks::onWikibasePollHandle';
$wgHooks['WikibaseDeleteData'][] =
'\Wikibase\ClientHooks::onWikibaseDeleteData';
diff --git a/client/includes/WikibaseLibrary.php
b/client/includes/WikibaseLibrary.php
new file mode 100644
index 000..4e2cfe1
--- /dev/null
+++ b/client/includes/WikibaseLibrary.php
@@ -0,0 +1,23 @@
+?php
+class Scribunto_LuaWikibaseLibrary extends Scribunto_LuaLibraryBase {
+protected static $moduleName = 'wikibase';
+public function register() {
+$lib = array( 'getEntity' = array( $this, 'getEntity' ) );
+$this-getEngine()-registerInterface( dirname( __FILE__ ) .
'/../resources/' . 'mw.wikibase.lua', $lib, array() );
+}
+
+ public function getEntity( $entity ) {
+ $this-checkType( 'getEntity', 1, $entity, 'string' );
+$entityObject =
Wikibase\ClientStoreFactory::getStore()-newEntityLookup()-getEntity(
Wikibase\EntityId::newFromPrefixedId( $entity ) );
+
+$serializerFactory = new \Wikibase\Lib\Serializers\SerializerFactory();
+$serializer =$serializerFactory-newSerializerForObject( $entityObject
);
+
+$opt = new \Wikibase\Lib\Serializers\EntitySerializationOptions();
+$serializer-setOptions( $opt );
+
+$entityArr = $serializer-getSerialized( $entityObject );
+MWDebug::log( serialize($entityArr) );
+ return array( $entityArr );
+}
+}
diff --git a/client/resources/mw.wikibase.lua b/client/resources/mw.wikibase.lua
new file mode 100644
index 000..4c54835
--- /dev/null
+++ b/client/resources/mw.wikibase.lua
@@ -0,0 +1,12 @@
+wikibase = {}
+
+function wikibase.setupInterface()
+ for k, v in pairs( mw_interface ) do
+wikibase[k] = v
+ end
+ mw = mw or {}
+ mw.wikibase = wikibase
+ package.loaded['mw.wikibase'] = wikibase
+end
+
+return wikibase
--
To view, visit https://gerrit.wikimedia.org/r/53570
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9fd05c36f32bffdeb15fb793e7c3332032b3541e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jens Ohlig jens.oh...@wikimedia.de
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
[MediaWiki-commits] [Gerrit] Lua support to access the repo data (DO NOT MERGE) - change (mediawiki...Wikibase)
Jens Ohlig has uploaded a new change for review.
https://gerrit.wikimedia.org/r/52784
Change subject: Lua support to access the repo data (DO NOT MERGE)
..
Lua support to access the repo data (DO NOT MERGE)
Change-Id: Iaa0c98832c3be1409d2389dc0f3d1b296ba0662f
---
M client/WikibaseClient.hooks.php
M client/WikibaseClient.php
A client/includes/WikibaseLibrary.php
A client/resources/mw.wikibase.lua
M lib/WikibaseLib.php
5 files changed, 47 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/84/52784/1
diff --git a/client/WikibaseClient.hooks.php b/client/WikibaseClient.hooks.php
index 0a59dc4..75d1934 100644
--- a/client/WikibaseClient.hooks.php
+++ b/client/WikibaseClient.hooks.php
@@ -398,6 +398,20 @@
return true;
}
+/**
+ * Hooks for Scribunto
+ *
+ * @return bool
+ */
+public static function onScribuntoExternalLibraries ( string $engine,
array $extraLibraries ) {
+$extraLibraries[] = array( mw.wikibase.lua );
+return true;
+}
+
+public static function onScribuntoExternalLibraryPaths ( string $engine,
array $extraLibraryPaths ) {
+$extraLibraryPath[] = array( $dir . 'resources/' );
+return true;
+}
/**
* Hook for modifying the query for fetching recent changes
* @see
https://www.mediawiki.org/wiki/Manual:Hooks/SpecialRecentChangesQuery
diff --git a/client/WikibaseClient.php b/client/WikibaseClient.php
index 597a8a5..f08709c 100644
--- a/client/WikibaseClient.php
+++ b/client/WikibaseClient.php
@@ -94,6 +94,9 @@
// test
$wgAutoloadClasses['Wikibase\Test\MockRepository'] = $dir .
'tests/phpunit/MockRepository.php';
+// Scribunto
+$wgAutoloadClasses['Scribunto_LuaWikibaseLibrary'] = $dir .
'includes/WikibaseLibrary.php';
+
// Hooks
$wgHooks['UnitTestsList'][]=
'\Wikibase\ClientHooks::registerUnitTests';
$wgHooks['LoadExtensionSchemaUpdates'][] =
'\Wikibase\ClientHooks::onSchemaUpdate';
@@ -111,7 +114,8 @@
$wgHooks['GetPreferences'][] =
'\Wikibase\ClientHooks::onGetPreferences';
$wgHooks['BeforePageDisplay'][]=
'\Wikibase\ClientHooks::onBeforePageDisplay';
$wgHooks['SpecialPageBeforeExecute'][] =
'\Wikibase\ClientHooks::onSpecialPageBeforeExecute';
-
+$wgHooks['ScribuntoExternalLibraryPaths'][] =
'\Wikibase\ClientHooks::onScribuntoExternalLibraryPaths';
+$wgHooks['ScribuntoExternalLibraries'][] =
'\Wikibase\ClientHooks::onScribuntoExternalLibraries';
// extension hooks
$wgHooks['WikibasePollHandle'][]=
'\Wikibase\ClientHooks::onWikibasePollHandle';
$wgHooks['WikibaseDeleteData'][] =
'\Wikibase\ClientHooks::onWikibaseDeleteData';
diff --git a/client/includes/WikibaseLibrary.php
b/client/includes/WikibaseLibrary.php
new file mode 100644
index 000..c1c9eec
--- /dev/null
+++ b/client/includes/WikibaseLibrary.php
@@ -0,0 +1,15 @@
+?php
+class Scribunto_LuaWikibaseLibrary extends Scribunto_LuaLibraryBase {
+ function register() {
+$this-getEngine()-registerInterface( 'mw.wikibase.lua',
+array( 'getEntity' = $this-getEntity ),
+array()
+);
+ }
+
+ public function getEntity( $entity ) {
+ $this-checkType( 'getEntity', 1, $entity, 'string' );
+$content = \Wikibase\EntityContentFactory::singleton()-newFromEntity(
$entity );
+ return array( $content-getEntity() );
+}
+}
diff --git a/client/resources/mw.wikibase.lua b/client/resources/mw.wikibase.lua
new file mode 100644
index 000..02e36d4
--- /dev/null
+++ b/client/resources/mw.wikibase.lua
@@ -0,0 +1,12 @@
+wikibase = {}
+
+function wikibase.setupInterface()
+-- mw = mw or {}
+-- mw.wikibase = wikibase
+-- for k, v in pairs( mw_interface ) do
+--wikibase[k] = v
+-- end
+-- package.loaded['mw.wikibase'] = wikibase
+end
+
+return wikibase
diff --git a/lib/WikibaseLib.php b/lib/WikibaseLib.php
index 2955626..87e3ef5 100644
--- a/lib/WikibaseLib.php
+++ b/lib/WikibaseLib.php
@@ -119,7 +119,7 @@
$wgAutoloadClasses['Wikibase\Term']= $dir
. 'includes/Term.php';
$wgAutoloadClasses['Wikibase\Utils'] = $dir
. 'includes/Utils.php';
$wgAutoloadClasses['Wikibase\WikibaseDiffOpFactory'] = $dir .
'includes/WikibaseDiffOpFactory.php';
-
+$wgAutoloadClasses['Scribunto_LuaWikibaseLibrary'] = $dir .
'includes/WikibaseLibrary.php';
// includes/changes
$wgAutoloadClasses['Wikibase\Change'] = $dir .
'includes/changes/Change.php';
$wgAutoloadClasses['Wikibase\ChangeRow'] = $dir .
'includes/changes/ChangeRow.php';
--
To view, visit
[MediaWiki-commits] [Gerrit] (Bug 43066) Replace search box with item selector - change (mediawiki...Wikibase)
Jens Ohlig has uploaded a new change for review.
https://gerrit.wikimedia.org/r/49263
Change subject: (Bug 43066) Replace search box with item selector
..
(Bug 43066) Replace search box with item selector
Change-Id: Ic70e323c118ed066c7846de57651076865106b2d
---
M repo/Wikibase.hooks.php
M repo/Wikibase.php
M repo/resources/Resources.php
A repo/resources/wikibase.ui.entityselector.js
4 files changed, 22 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/63/49263/1
diff --git a/repo/Wikibase.hooks.php b/repo/Wikibase.hooks.php
index 6ad7768..a056272 100644
--- a/repo/Wikibase.hooks.php
+++ b/repo/Wikibase.hooks.php
@@ -961,4 +961,9 @@
return false;
}
+public static function onBeforePageDisplay( \OutputPage $out, \Skin
$skin ) {
+$out-addModules( 'wikibase.ui.entityselector' );
+return true;
+}
+
}
diff --git a/repo/Wikibase.php b/repo/Wikibase.php
index 9657c0d..7b534dd 100644
--- a/repo/Wikibase.php
+++ b/repo/Wikibase.php
@@ -268,7 +268,7 @@
$wgHooks['ShowSearchHit'][]=
'Wikibase\RepoHooks::onShowSearchHit';
$wgHooks['TitleGetRestrictionTypes'][] =
'Wikibase\RepoHooks::onTitleGetRestrictionTypes';
$wgHooks['AbuseFilter-contentToString'][] =
'Wikibase\RepoHooks::onAbuseFilterContentToString';
-
+$wgHooks['BeforePageDisplay'][] =
'Wikibase\RepoHooks::onBeforePageDisplay';
// Resource Loader Modules:
$wgResourceModules = array_merge( $wgResourceModules, include(
$dir/resources/Resources.php ) );
diff --git a/repo/resources/Resources.php b/repo/resources/Resources.php
index b230b1f..fb1f729 100644
--- a/repo/resources/Resources.php
+++ b/repo/resources/Resources.php
@@ -39,7 +39,8 @@
return array(
'wikibase.ui.entityViewInit' = $moduleTemplate + array(
'scripts' = array(
- 'wikibase.ui.entityViewInit.js' // should
probably be adjusted for more modularity
+'wikibase.ui.entityViewInit.js',
+ 'wikibase.ui.entityselector.js'
),
'dependencies' = array(
'mediawiki.user',
@@ -48,12 +49,13 @@
'wikibase.datamodel',
'jquery.json',
'jquery.cookie',
+ 'jquery.ui.entityselector',
),
'messages' = array(
'wikibase-sitelinks',
'wikibase-statements',
'wikibase-copyrighttooltip-acknowledge',
- )
+),
),
/* Wikibase special pages */
diff --git a/repo/resources/wikibase.ui.entityselector.js
b/repo/resources/wikibase.ui.entityselector.js
new file mode 100644
index 000..90554db
--- /dev/null
+++ b/repo/resources/wikibase.ui.entityselector.js
@@ -0,0 +1,12 @@
+( function( $, mw ) {
+ 'use strict';
+ $( document ).ready( function() {
+$( '#searchInput' ).removeData( 'suggestionsContext' )
+mw.loader.using( ['jquery.ui.entityselector'], function () {
+ $( '#searchInput' ).entityselector( {
+url: mw.config.get( 'wgServer' ) + mw.config.get( 'wgScriptPath' ) +
'/api.php',
+language: mw.config.get( 'wgUserLanguage' )
+ } )
+} );
+ } )
+}( jQuery, mediaWiki ) );
--
To view, visit https://gerrit.wikimedia.org/r/49263
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic70e323c118ed066c7846de57651076865106b2d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jens Ohlig jens.oh...@wikimedia.de
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (minor) move Wikibase special pages into right group - change (mediawiki...Wikibase[master])
Jens Ohlig has submitted this change and it was merged. Change subject: (minor) move Wikibase special pages into right group .. (minor) move Wikibase special pages into right group NewProperty and EntityData special pages are displayed in Wikibase Repo group now. Change-Id: I351ddc649369485368c8307c61fda46a48500f5e --- M repo/Wikibase.php 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Jens Ohlig: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/46477 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I351ddc649369485368c8307c61fda46a48500f5e Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Daniel Werner daniel.wer...@wikimedia.de Gerrit-Reviewer: Jens Ohlig jens.oh...@wikimedia.de Gerrit-Reviewer: John Erling Blad john.b...@wikimedia.de Gerrit-Reviewer: Tobias Gritschacher tobias.gritschac...@wikimedia.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (testing) method to exclude certain browsers in selenium tes... - change (mediawiki...Wikibase[master])
Jens Ohlig has submitted this change and it was merged. Change subject: (testing) method to exclude certain browsers in selenium tests .. (testing) method to exclude certain browsers in selenium tests - this adds the possibility to exclude tests from beeing executed in specific browsers - e.g. a test can be marked as exclude_firefox if it should not be run under firefox Change-Id: Ie6f892d82358252a7118563027706789cf18f088 --- M selenium/spec/spec_helper.rb 1 file changed, 23 insertions(+), 9 deletions(-) Approvals: Jens Ohlig: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/44638 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie6f892d82358252a7118563027706789cf18f088 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Tobias Gritschacher tobias.gritschac...@wikimedia.de Gerrit-Reviewer: Anja Jentzsch anja.jentz...@wikimedia.de Gerrit-Reviewer: Henning Snater henning.sna...@wikimedia.de Gerrit-Reviewer: Jens Ohlig jens.oh...@wikimedia.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Prefix and fuzzy search implemented - change (mediawiki...WikibaseSolr[master])
Jens Ohlig has submitted this change and it was merged. Change subject: Prefix and fuzzy search implemented .. Prefix and fuzzy search implemented Change-Id: I66472469e5a5a361e80155bcbdf8bf8b2a252d2e --- M includes/TermSolrCache.php M schema.solr3.xml 2 files changed, 141 insertions(+), 8 deletions(-) Approvals: Jens Ohlig: Verified; Looks good to me, approved Denny Vrandecic: Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/43850 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I66472469e5a5a361e80155bcbdf8bf8b2a252d2e Gerrit-PatchSet: 8 Gerrit-Project: mediawiki/extensions/WikibaseSolr Gerrit-Branch: master Gerrit-Owner: Jens Ohlig jens.oh...@wikimedia.de Gerrit-Reviewer: Denny Vrandecic denny.vrande...@wikimedia.de Gerrit-Reviewer: Jens Ohlig jens.oh...@wikimedia.de Gerrit-Reviewer: Jeroen De Dauw jeroended...@gmail.com Gerrit-Reviewer: Nikerabbit niklas.laxst...@gmail.com Gerrit-Reviewer: Platonides platoni...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] More to ignore - change (mediawiki...WikibaseSolr[master])
Jens Ohlig has submitted this change and it was merged. Change subject: More to ignore .. More to ignore Change-Id: Ic83e351d91edf1f83d19c72ef7e9df404e015a97 --- M .gitignore 1 file changed, 78 insertions(+), 0 deletions(-) Approvals: Jens Ohlig: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/43853 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic83e351d91edf1f83d19c72ef7e9df404e015a97 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/WikibaseSolr Gerrit-Branch: master Gerrit-Owner: Jens Ohlig jens.oh...@wikimedia.de Gerrit-Reviewer: Jens Ohlig jens.oh...@wikimedia.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Addresses various problems pointed out by Nikerabbit in http... - change (mediawiki...WikibaseSolr[master])
Jens Ohlig has uploaded a new change for review. Change subject: Addresses various problems pointed out by Nikerabbit in https://gerrit.wikimedia.org/r/#/c/43850/ .. Addresses various problems pointed out by Nikerabbit in https://gerrit.wikimedia.org/r/#/c/43850/ Change-Id: Ib6ad4531f5e2372e183931690fea044dd52a4d8f --- M includes/TermSolrCache.php 1 file changed, 9 insertions(+), 6 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikibaseSolr refs/changes/02/44402/1 -- To view, visit https://gerrit.wikimedia.org/r/44402 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib6ad4531f5e2372e183931690fea044dd52a4d8f Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/WikibaseSolr Gerrit-Branch: master Gerrit-Owner: Jens Ohlig jens.oh...@wikimedia.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] El Cheapo prefix search implemented - change (mediawiki...WikibaseSolr[master])
Jens Ohlig has uploaded a new change for review. Change subject: El Cheapo prefix search implemented .. El Cheapo prefix search implemented Change-Id: I66472469e5a5a361e80155bcbdf8bf8b2a252d2e --- M includes/TermSolrCache.php 1 file changed, 63 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikibaseSolr refs/changes/50/43850/1 -- To view, visit https://gerrit.wikimedia.org/r/43850 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I66472469e5a5a361e80155bcbdf8bf8b2a252d2e Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/WikibaseSolr Gerrit-Branch: master Gerrit-Owner: Jens Ohlig jens.oh...@wikimedia.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] More to ignore - change (mediawiki...WikibaseSolr[master])
Jens Ohlig has uploaded a new change for review. Change subject: More to ignore .. More to ignore Change-Id: Ic83e351d91edf1f83d19c72ef7e9df404e015a97 --- M .gitignore 1 file changed, 78 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikibaseSolr refs/changes/53/43853/1 -- To view, visit https://gerrit.wikimedia.org/r/43853 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic83e351d91edf1f83d19c72ef7e9df404e015a97 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/WikibaseSolr Gerrit-Branch: master Gerrit-Owner: Jens Ohlig jens.oh...@wikimedia.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Add i18n file - change (mediawiki...WikibaseSolr[master])
Jens Ohlig has submitted this change and it was merged. Change subject: Add i18n file .. Add i18n file Change-Id: Ica9903a59914b1f48b76e54413b65bc8ce116a27 --- A WikibaseSolr.i18n.php M WikibaseSolr.php 2 files changed, 22 insertions(+), 1 deletion(-) Approvals: Jens Ohlig: Verified; Looks good to me, approved Denny Vrandecic: Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/32831 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ica9903a59914b1f48b76e54413b65bc8ce116a27 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/WikibaseSolr Gerrit-Branch: master Gerrit-Owner: Raimond Spekking raimond.spekk...@gmail.com Gerrit-Reviewer: Daniel Friesen dan...@nadir-seen-fire.com Gerrit-Reviewer: Denny Vrandecic denny.vrande...@wikimedia.de Gerrit-Reviewer: Jens Ohlig jens.oh...@wikimedia.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Corrected installation documentation and cleaned up SpecialS... - change (mediawiki...WikibaseSolr[master])
Jens Ohlig has submitted this change and it was merged. Change subject: Corrected installation documentation and cleaned up SpecialSolrTest.php .. Corrected installation documentation and cleaned up SpecialSolrTest.php Change-Id: Iad422dea9334565334be1a4673128e505806f403 --- M README M includes/SpecialSolrTest.php 2 files changed, 9 insertions(+), 101 deletions(-) Approvals: Jens Ohlig: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/42765 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iad422dea9334565334be1a4673128e505806f403 Gerrit-PatchSet: 4 Gerrit-Project: mediawiki/extensions/WikibaseSolr Gerrit-Branch: master Gerrit-Owner: Jens Ohlig jens.oh...@wikimedia.de Gerrit-Reviewer: Denny Vrandecic denny.vrande...@wikimedia.de Gerrit-Reviewer: Jens Ohlig jens.oh...@wikimedia.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] i18n - change (mediawiki...WikibaseSolr[master])
Jens Ohlig has submitted this change and it was merged. Change subject: i18n .. i18n Change-Id: I545d54652f3bb2c9070cce3f8e5a9b0874816045 --- M WikibaseSolr.i18n.php M WikibaseSolr.php 2 files changed, 14 insertions(+), 4 deletions(-) Approvals: Jens Ohlig: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/42783 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I545d54652f3bb2c9070cce3f8e5a9b0874816045 Gerrit-PatchSet: 4 Gerrit-Project: mediawiki/extensions/WikibaseSolr Gerrit-Branch: master Gerrit-Owner: Jens Ohlig jens.oh...@wikimedia.de Gerrit-Reviewer: Denny Vrandecic denny.vrande...@wikimedia.de Gerrit-Reviewer: Jens Ohlig jens.oh...@wikimedia.de Gerrit-Reviewer: Nikerabbit niklas.laxst...@gmail.com Gerrit-Reviewer: Siebrand siebr...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] More to ignore. - change (mediawiki...WikibaseSolr[master])
Jens Ohlig has uploaded a new change for review. Change subject: More to ignore. .. More to ignore. Change-Id: Idd16e7b08be6c9953e16dc412f14e6d76020adfa --- M .gitignore 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikibaseSolr refs/changes/65/42965/1 -- To view, visit https://gerrit.wikimedia.org/r/42965 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Idd16e7b08be6c9953e16dc412f14e6d76020adfa Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/WikibaseSolr Gerrit-Branch: master Gerrit-Owner: Jens Ohlig jens.oh...@wikimedia.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Corrected installation documentation and cleaned up SpecialS... - change (mediawiki...WikibaseSolr[master])
Jens Ohlig has uploaded a new change for review. Change subject: Corrected installation documentation and cleaned up SpecialSolrTest.php .. Corrected installation documentation and cleaned up SpecialSolrTest.php Change-Id: Iad422dea9334565334be1a4673128e505806f403 --- M README M includes/SpecialSolrTest.php 2 files changed, 9 insertions(+), 101 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikibaseSolr refs/changes/65/42765/1 -- To view, visit https://gerrit.wikimedia.org/r/42765 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iad422dea9334565334be1a4673128e505806f403 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/WikibaseSolr Gerrit-Branch: master Gerrit-Owner: Jens Ohlig jens.oh...@wikimedia.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] change Entity Data to Entity data, more consistent - change (mediawiki...Wikibase[master])
Jens Ohlig has submitted this change and it was merged. Change subject: change Entity Data to Entity data, more consistent .. change Entity Data to Entity data, more consistent Change-Id: Ic29affa72a89cddcd9863a3c46d77a57e8556622 --- M repo/Wikibase.i18n.php 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Jens Ohlig: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/37011 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic29affa72a89cddcd9863a3c46d77a57e8556622 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Aude aude.w...@gmail.com Gerrit-Reviewer: Jens Ohlig jens.oh...@wikimedia.de Gerrit-Reviewer: John Erling Blad john.b...@wikimedia.de Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (no bug) add template engine qunit tests to selenium - change (mediawiki...Wikibase[master])
Jens Ohlig has submitted this change and it was merged. Change subject: (no bug) add template engine qunit tests to selenium .. (no bug) add template engine qunit tests to selenium Change-Id: I27e0a76683a7792f761b532fd8d1ecca222629e2 --- M repo/tests/selenium/qunit/qunit_spec.rb 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: Jens Ohlig: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/36565 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I27e0a76683a7792f761b532fd8d1ecca222629e2 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Tobias Gritschacher tobias.gritschac...@wikimedia.de Gerrit-Reviewer: Anja Jentzsch anja.jentz...@wikimedia.de Gerrit-Reviewer: Aude aude.w...@gmail.com Gerrit-Reviewer: Henning Snater henning.sna...@wikimedia.de Gerrit-Reviewer: Jens Ohlig jens.oh...@wikimedia.de Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (no bug) make selenium tests independent from ULS - change (mediawiki...Wikibase[master])
Jens Ohlig has submitted this change and it was merged. Change subject: (no bug) make selenium tests independent from ULS .. (no bug) make selenium tests independent from ULS - selenium tests now use the uselang-parameter as fallback for switching language when ULS is not activated Change-Id: I4db33b13eeb6139f49b1e7d2ac13ae711be109a2 --- M repo/tests/selenium/language_selector/language_selector_spec.rb M repo/tests/selenium/special/create_item_spec.rb M repo/tests/selenium/special/create_property_spec.rb M repo/tests/selenium/special/entities_without_label_spec.rb M repo/tests/selenium/special/item_disambiguation_spec.rb M repo/tests/selenium/special/set_label_spec.rb M selenium/lib/modules/uls_module.rb 7 files changed, 37 insertions(+), 21 deletions(-) Approvals: Jens Ohlig: Verified; Looks good to me, approved Anja Jentzsch: Verified; Looks good to me, but someone else must approve -- To view, visit https://gerrit.wikimedia.org/r/36562 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4db33b13eeb6139f49b1e7d2ac13ae711be109a2 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Tobias Gritschacher tobias.gritschac...@wikimedia.de Gerrit-Reviewer: Anja Jentzsch anja.jentz...@wikimedia.de Gerrit-Reviewer: Henning Snater henning.sna...@wikimedia.de Gerrit-Reviewer: Jens Ohlig jens.oh...@wikimedia.de Gerrit-Reviewer: Tobias Gritschacher tobias.gritschac...@wikimedia.de Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 42681) check if the site table exists and site code is ... - change (mediawiki...Wikibase[master])
Jens Ohlig has submitted this change and it was merged. Change subject: (bug 42681) check if the site table exists and site code is valid .. (bug 42681) check if the site table exists and site code is valid Change-Id: I6324dc1f6448bba7f7ee6eb1b046f5d0018c9c92 --- M client/WikibaseClient.hooks.php M client/includes/ClientChangeHandler.php 2 files changed, 14 insertions(+), 0 deletions(-) Approvals: Tobias Gritschacher: Looks good to me, but someone else must approve Jens Ohlig: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/36756 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6324dc1f6448bba7f7ee6eb1b046f5d0018c9c92 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Aude aude.w...@gmail.com Gerrit-Reviewer: Aude aude.w...@gmail.com Gerrit-Reviewer: Jens Ohlig jens.oh...@wikimedia.de Gerrit-Reviewer: Tobias Gritschacher tobias.gritschac...@wikimedia.de Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] clear wikibase client recent changes when using deleteAllDat... - change (mediawiki...Wikibase[master])
Jens Ohlig has submitted this change and it was merged. Change subject: clear wikibase client recent changes when using deleteAllData .. clear wikibase client recent changes when using deleteAllData Change-Id: I3fd7cbe2bfa69b61a736e57abac116c49aebc95e --- M client/WikibaseClient.hooks.php 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: Jens Ohlig: Verified; Looks good to me, approved Objections: Jeroen De Dauw: There's a problem with this change, please improve -- To view, visit https://gerrit.wikimedia.org/r/33558 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3fd7cbe2bfa69b61a736e57abac116c49aebc95e Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Aude aude.w...@gmail.com Gerrit-Reviewer: Aude aude.w...@gmail.com Gerrit-Reviewer: Jens Ohlig jens.oh...@wikimedia.de Gerrit-Reviewer: Jeroen De Dauw jeroended...@gmail.com Gerrit-Reviewer: John Erling Blad john.b...@wikimedia.de Gerrit-Reviewer: Tobias Gritschacher tobias.gritschac...@wikimedia.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (Bug #42475) Hide anons and logged in users filters with Wik... - change (mediawiki...Wikibase[master])
Jens Ohlig has uploaded a new change for review. Change subject: (Bug #42475) Hide anons and logged in users filters with Wikidata changes .. (Bug #42475) Hide anons and logged in users filters with Wikidata changes Change-Id: I4b49a0c2c717d803170735f89204fec0253adf07 --- M client/WikibaseClient.hooks.php 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/70/36770/1 -- To view, visit https://gerrit.wikimedia.org/r/36770 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4b49a0c2c717d803170735f89204fec0253adf07 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jens Ohlig jens.oh...@wikimedia.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (no bug) Correct singular form in output of pollForChanges.p... - change (mediawiki...Wikibase[master])
Jens Ohlig has uploaded a new change for review. Change subject: (no bug) Correct singular form in output of pollForChanges.php .. (no bug) Correct singular form in output of pollForChanges.php Change-Id: I295e2d599951e069db30fed24e024c3fdbbf2150 --- M lib/maintenance/pollForChanges.php 1 file changed, 5 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/83/36783/1 -- To view, visit https://gerrit.wikimedia.org/r/36783 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I295e2d599951e069db30fed24e024c3fdbbf2150 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jens Ohlig jens.oh...@wikimedia.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (no bug) use const to toggle experimental features. - change (mediawiki...Wikibase[master])
Jens Ohlig has submitted this change and it was merged. Change subject: (no bug) use const to toggle experimental features. .. (no bug) use const to toggle experimental features. Use the constant WB_EXPERIMENTAL_FEATURES instead of the setting 'experimentalFeatures' to control experiemental features. Since the features also depends on code modules only included when Wikibase*.experimental.php is used, a constant indicating whether the experimental modules are present seems more appropriate than a separate setting. Change-Id: I8f740d77badf653924d375f7fdfadf6075895a6d --- M lib/WikibaseLib.experimental.php M repo/ExampleSettings.php M repo/includes/EntityView.php 3 files changed, 3 insertions(+), 8 deletions(-) Approvals: Jens Ohlig: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/35934 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8f740d77badf653924d375f7fdfadf6075895a6d Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Daniel Kinzler daniel.kinz...@wikimedia.de Gerrit-Reviewer: Anja Jentzsch anja.jentz...@wikimedia.de Gerrit-Reviewer: Aude aude.w...@gmail.com Gerrit-Reviewer: Jens Ohlig jens.oh...@wikimedia.de Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Make displaying statements in HTML interface switchable. - change (mediawiki...Wikibase[master])
Jens Ohlig has uploaded a new change for review. Change subject: Make displaying statements in HTML interface switchable. .. Make displaying statements in HTML interface switchable. Change-Id: I6ab874de66ff10c7d504f6bb039dad789d1143f1 --- M repo/ExampleSettings.php M repo/includes/EntityView.php 2 files changed, 9 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/85/35885/1 -- To view, visit https://gerrit.wikimedia.org/r/35885 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6ab874de66ff10c7d504f6bb039dad789d1143f1 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jens Ohlig jens.oh...@wikimedia.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Moved API methods with claims to experimental. - change (mediawiki...Wikibase[master])
Jens Ohlig has uploaded a new change for review. Change subject: Moved API methods with claims to experimental. .. Moved API methods with claims to experimental. Change-Id: I0568616763bf178500384a66e7f417f2e372b0fd --- M repo/Wikibase.experimental.php M repo/Wikibase.php 2 files changed, 11 insertions(+), 11 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/89/35889/1 -- To view, visit https://gerrit.wikimedia.org/r/35889 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0568616763bf178500384a66e7f417f2e372b0fd Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jens Ohlig jens.oh...@wikimedia.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Added setstatementrank API module - change (mediawiki...Wikibase[master])
Jens Ohlig has submitted this change and it was merged. Change subject: Added setstatementrank API module .. Added setstatementrank API module Change-Id: Ibb9c6773d1b3ca4368a6f3bd33237fcdff31409c --- M lib/includes/serializers/ClaimSerializer.php M lib/tests/phpunit/serializers/ClaimSerializerTest.php M repo/Wikibase.hooks.php M repo/Wikibase.php M repo/includes/api/ApiSetReference.php M repo/includes/api/RemoveReferences.php A repo/includes/api/SetStatementRank.php A repo/tests/phpunit/includes/api/SetStatementRankTest.php 8 files changed, 493 insertions(+), 10 deletions(-) Approvals: Jens Ohlig: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/35397 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibb9c6773d1b3ca4368a6f3bd33237fcdff31409c Gerrit-PatchSet: 7 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw jeroended...@gmail.com Gerrit-Reviewer: Jens Ohlig jens.oh...@wikimedia.de Gerrit-Reviewer: Jeroen De Dauw jeroended...@gmail.com Gerrit-Reviewer: John Erling Blad john.b...@wikimedia.de Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Updated @ingroup for repo tests - change (mediawiki...Wikibase[master])
Jens Ohlig has submitted this change and it was merged. Change subject: Updated @ingroup for repo tests .. Updated @ingroup for repo tests Change-Id: Ie879922764916fe1e339d8a8fb2549b666a18a79 --- M repo/Wikibase.php M repo/includes/api/RemoveReferences.php M repo/includes/api/SetStatementRank.php M repo/tests/phpunit/TestItemContents.php M repo/tests/phpunit/includes/AutocommentTest.php M repo/tests/phpunit/includes/EditEntityTest.php M repo/tests/phpunit/includes/ItemContentDiffViewTest.php M repo/tests/phpunit/includes/ItemMoveTest.php M repo/tests/phpunit/includes/ItemViewTest.php M repo/tests/phpunit/includes/actions/ActionTestCase.php M repo/tests/phpunit/includes/actions/EditEntityActionTest.php M repo/tests/phpunit/includes/api/ApiBotEditTest.php M repo/tests/phpunit/includes/api/ApiCreateClaimTest.php M repo/tests/phpunit/includes/api/ApiDescriptionTest.php M repo/tests/phpunit/includes/api/ApiEditEntityTest.php M repo/tests/phpunit/includes/api/ApiEditPageTest.php M repo/tests/phpunit/includes/api/ApiGetClaimsTest.php M repo/tests/phpunit/includes/api/ApiGetEntitiesTest.php M repo/tests/phpunit/includes/api/ApiLabelTest.php M repo/tests/phpunit/includes/api/ApiLangAttributeBase.php M repo/tests/phpunit/includes/api/ApiLinkTitlesTest.php M repo/tests/phpunit/includes/api/ApiModifyItemBase.php M repo/tests/phpunit/includes/api/ApiPermissionsTest.php M repo/tests/phpunit/includes/api/ApiRemoveClaimsTest.php M repo/tests/phpunit/includes/api/ApiSetAliasesTest.php M repo/tests/phpunit/includes/api/ApiSetClaimValueTest.php M repo/tests/phpunit/includes/api/ApiSetReferenceTest.php M repo/tests/phpunit/includes/api/ApiSetSiteLinkTest.php M repo/tests/phpunit/includes/api/RemoveReferencesTest.php M repo/tests/phpunit/includes/api/SetStatementRankTest.php M repo/tests/phpunit/includes/content/EntityContentFactoryTest.php M repo/tests/phpunit/includes/content/EntityContentTest.php M repo/tests/phpunit/includes/content/EntityHandlerTest.php M repo/tests/phpunit/includes/content/ItemContentTest.php M repo/tests/phpunit/includes/content/ItemHandlerTest.php M repo/tests/phpunit/includes/content/PropertyContentTest.php M repo/tests/phpunit/includes/content/PropertyHandlerTest.php M repo/tests/phpunit/includes/content/QueryContentTest.php M repo/tests/phpunit/includes/content/QueryHandlerTest.php M repo/tests/phpunit/includes/specials/SpecialCreateItemTest.php M repo/tests/phpunit/includes/specials/SpecialEntityDataTest.php M repo/tests/phpunit/includes/specials/SpecialItemByTitleTest.php M repo/tests/phpunit/includes/specials/SpecialItemDisambiguationTest.php M repo/tests/phpunit/includes/specials/SpecialPageTestBase.php M repo/tests/phpunit/includes/store/IdGeneratorTest.php M repo/tests/phpunit/includes/store/StoreFactoryTest.php M repo/tests/phpunit/includes/store/StoreTest.php M repo/tests/phpunit/includes/store/TermCacheTest.php M repo/tests/phpunit/includes/store/sql/SqlIdGeneratorTest.php M repo/tests/phpunit/includes/store/sql/TermSqlCacheTest.php M repo/tests/phpunit/includes/updates/ItemDeletionUpdateTest.php M repo/tests/phpunit/includes/updates/ItemModificationUpdateTest.php 52 files changed, 59 insertions(+), 53 deletions(-) Approvals: Jens Ohlig: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/35398 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie879922764916fe1e339d8a8fb2549b666a18a79 Gerrit-PatchSet: 5 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw jeroended...@gmail.com Gerrit-Reviewer: Aude aude.w...@gmail.com Gerrit-Reviewer: Jens Ohlig jens.oh...@wikimedia.de Gerrit-Reviewer: John Erling Blad john.b...@wikimedia.de Gerrit-Reviewer: Tobias Gritschacher tobias.gritschac...@wikimedia.de Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 42539) Move more stuff to experimental setup. - change (mediawiki...Wikibase[master])
Jens Ohlig has submitted this change and it was merged. Change subject: (bug 42539) Move more stuff to experimental setup. .. (bug 42539) Move more stuff to experimental setup. Move remaining phase 2 API modules and some special pages to the experimental setup, so they are not available in production. Change-Id: Ibb7188c0374cbab16ecd82f62b789662d1c9bbb0 --- M repo/Wikibase.experimental.php M repo/Wikibase.hooks.php M repo/Wikibase.php 3 files changed, 12 insertions(+), 11 deletions(-) Approvals: Jens Ohlig: Verified; Looks good to me, approved Anja Jentzsch: Looks good to me, but someone else must approve -- To view, visit https://gerrit.wikimedia.org/r/35899 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibb7188c0374cbab16ecd82f62b789662d1c9bbb0 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Daniel Kinzler daniel.kinz...@wikimedia.de Gerrit-Reviewer: Anja Jentzsch anja.jentz...@wikimedia.de Gerrit-Reviewer: Jens Ohlig jens.oh...@wikimedia.de Gerrit-Reviewer: John Erling Blad john.b...@wikimedia.de Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Revert (bug 42539) Move more stuff to experimental setup. - change (mediawiki...Wikibase[master])
Jens Ohlig has submitted this change and it was merged. Change subject: Revert (bug 42539) Move more stuff to experimental setup. .. Revert (bug 42539) Move more stuff to experimental setup. This reverts commit 005a3cc0bd7a18192564b9df9c77aa34df0d97f3 --- M repo/Wikibase.experimental.php M repo/Wikibase.hooks.php M repo/Wikibase.php 3 files changed, 11 insertions(+), 12 deletions(-) Approvals: Jens Ohlig: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/35902 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2dbe65d1345193d6904e0bed14ce67d4815a8f66 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jens Ohlig jens.oh...@wikimedia.de Gerrit-Reviewer: Jens Ohlig jens.oh...@wikimedia.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (no bug) selenium tests for client watchlist - change (mediawiki...Wikibase[master])
Jens Ohlig has submitted this change and it was merged. Change subject: (no bug) selenium tests for client watchlist .. (no bug) selenium tests for client watchlist - moved existing tests for watchlist from client_repo to new test - added more test for watchlist - renamed recent_changes to client_rc_and_wl - some variable renaming for consistancy Change-Id: Iffb3c84d25aea6bcbe25ed753cb34c4037efa6d0 --- A client/tests/selenium/special/client_rc_and_wl_spec.rb D client/tests/selenium/special/recent_changes_spec.rb M repo/tests/selenium/client/client_repo_spec.rb M selenium/Rakefile M selenium/lib/pages/client_recent_changes_page.rb M selenium/lib/pages/watchlist_page.rb 6 files changed, 211 insertions(+), 164 deletions(-) Approvals: Jens Ohlig: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/35390 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iffb3c84d25aea6bcbe25ed753cb34c4037efa6d0 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Tobias Gritschacher tobias.gritschac...@wikimedia.de Gerrit-Reviewer: Anja Jentzsch anja.jentz...@wikimedia.de Gerrit-Reviewer: Aude aude.w...@gmail.com Gerrit-Reviewer: Henning Snater henning.sna...@wikimedia.de Gerrit-Reviewer: Jens Ohlig jens.oh...@wikimedia.de Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (no bug) added missing QUnit tests to selenium - change (mediawiki...Wikibase[master])
Jens Ohlig has submitted this change and it was merged. Change subject: (no bug) added missing QUnit tests to selenium .. (no bug) added missing QUnit tests to selenium - dataValues, dataTypes and jQuery.ui groups were not executed automatically by selenium when running the wikibase group Change-Id: Ic5dcffad46aca288f6ea3c8c83588b730bd82351 --- M repo/tests/selenium/qunit/qunit_spec.rb M selenium/lib/pages/qunit_page.rb 2 files changed, 33 insertions(+), 6 deletions(-) Approvals: Jens Ohlig: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/35618 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic5dcffad46aca288f6ea3c8c83588b730bd82351 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Tobias Gritschacher tobias.gritschac...@wikimedia.de Gerrit-Reviewer: Anja Jentzsch anja.jentz...@wikimedia.de Gerrit-Reviewer: Aude aude.w...@gmail.com Gerrit-Reviewer: Henning Snater henning.sna...@wikimedia.de Gerrit-Reviewer: Jens Ohlig jens.oh...@wikimedia.de Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] check if cache tables exist in pollforchanges rebuild option - change (mediawiki...Wikibase[master])
Jens Ohlig has submitted this change and it was merged. Change subject: check if cache tables exist in pollforchanges rebuild option .. check if cache tables exist in pollforchanges rebuild option Change-Id: I5b8761b45629913c2025653dcf85c23f004be06b --- M lib/maintenance/pollForChanges.php 1 file changed, 5 insertions(+), 3 deletions(-) Approvals: Jens Ohlig: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/35627 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5b8761b45629913c2025653dcf85c23f004be06b Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Aude aude.w...@gmail.com Gerrit-Reviewer: Aude aude.w...@gmail.com Gerrit-Reviewer: Jens Ohlig jens.oh...@wikimedia.de Gerrit-Reviewer: Jeroen De Dauw jeroended...@gmail.com Gerrit-Reviewer: Tobias Gritschacher tobias.gritschac...@wikimedia.de Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Added composer package definition file - change (mediawiki...Wikibase[master])
Jens Ohlig has submitted this change and it was merged. Change subject: Added composer package definition file .. Added composer package definition file Change-Id: I79078e2598e7f591be4b6a9e3d5c3e47540d8b09 --- A composer.json 1 file changed, 20 insertions(+), 0 deletions(-) Approvals: Jens Ohlig: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/35296 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I79078e2598e7f591be4b6a9e3d5c3e47540d8b09 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw jeroended...@gmail.com Gerrit-Reviewer: Jens Ohlig jens.oh...@wikimedia.de Gerrit-Reviewer: Jeroen De Dauw jeroended...@gmail.com Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fixed @ingroup inconsistencies (mainly in lib and client), r... - change (mediawiki...Wikibase[master])
Jens Ohlig has submitted this change and it was merged. Change subject: Fixed @ingroup inconsistencies (mainly in lib and client), renamed Wikibase group to WikibaseRepo and made all groups part of new group Wikibase .. Fixed @ingroup inconsistencies (mainly in lib and client), renamed Wikibase group to WikibaseRepo and made all groups part of new group Wikibase Change-Id: I48a3ad28a78d55475f06f2e4b4ccbab2f6c3514a --- M client/WikibaseClient.i18n.magic.php M client/WikibaseClient.i18n.php M client/WikibaseClient.php M lib/WikibaseLib.php M lib/includes/ByPropertyIdArray.php M lib/includes/DiffView.php M lib/includes/HashArray.php M lib/includes/HashableObjectStorage.php M lib/includes/MapHasher.php M lib/includes/MapValueHasher.php M lib/includes/ObjectComparer.php M lib/includes/TemplateStore.php M lib/includes/Term.php M lib/includes/Utils.php M lib/includes/claim/Claim.php M lib/includes/claim/ClaimAggregate.php M lib/includes/claim/ClaimList.php M lib/includes/claim/ClaimListAccess.php M lib/includes/claim/ClaimObject.php M lib/includes/claim/Claims.php M lib/includes/entity/EntityDiff.php M lib/includes/entity/EntityDiffObject.php M lib/includes/entity/EntityDiffView.php M lib/includes/entity/EntityFactory.php M lib/includes/entity/EntityId.php M lib/includes/item/ItemDiff.php M lib/includes/item/ItemDiffView.php M lib/includes/modules/SitesModule.php M lib/includes/modules/TemplateModule.php M lib/includes/property/PropertyDiff.php M lib/includes/property/PropertyDiffView.php M lib/includes/reference/Reference.php M lib/includes/reference/ReferenceList.php M lib/includes/reference/ReferenceObject.php M lib/includes/reference/References.php M lib/includes/serializers/ByPropertyListSerializer.php M lib/includes/serializers/ClaimSerializer.php M lib/includes/serializers/ClaimsSerializer.php M lib/includes/serializers/EntitySerializer.php M lib/includes/serializers/ItemSerializer.php M lib/includes/serializers/PropertySerializer.php M lib/includes/serializers/SerializationOptions.php M lib/includes/serializers/Serializer.php M lib/includes/serializers/SerializerObject.php M lib/includes/serializers/SnakSerializer.php M lib/includes/snak/PropertyNoValueSnak.php M lib/includes/snak/PropertySnak.php M lib/includes/snak/PropertySomeValueSnak.php M lib/includes/snak/PropertyValueSnak.php M lib/includes/snak/Snak.php M lib/includes/snak/SnakList.php M lib/includes/snak/SnakObject.php M lib/includes/snak/Snaks.php M lib/includes/statement/Statement.php M lib/includes/statement/StatementObject.php M lib/includes/store/SiteLinkCache.php M lib/maintenance/deleteAllData.php M lib/maintenance/pollForChanges.php M lib/maintenance/populateSitesTable.php M lib/maintenance/rebuildAllData.php M lib/resources/Resources.php M lib/resources/jquery.ui/jquery.ui.entityselector.js M lib/resources/jquery.wikibase/jquery.wikibase.claimview.js M lib/resources/jquery.wikibase/jquery.wikibase.entityview.js M lib/resources/jquery.wikibase/jquery.wikibase.siteselector.js M lib/resources/jquery.wikibase/jquery.wikibase.snakview.js M lib/resources/jquery/jquery.eachchange.js M lib/resources/templates.js M lib/resources/templates.php M lib/resources/wikibase.RevisionStore.js M lib/resources/wikibase.Site.js M lib/resources/wikibase.css M lib/resources/wikibase.datamodel/wikibase.Claim.js M lib/resources/wikibase.datamodel/wikibase.PropertyNoValueSnak.js M lib/resources/wikibase.datamodel/wikibase.PropertySomeValueSnak.js M lib/resources/wikibase.datamodel/wikibase.PropertyValueSnak.js M lib/resources/wikibase.datamodel/wikibase.Reference.js M lib/resources/wikibase.datamodel/wikibase.Snak.js M lib/resources/wikibase.datamodel/wikibase.Statement.js M lib/resources/wikibase.js M lib/resources/wikibase.store/wikibase.Api.js M lib/resources/wikibase.store/wikibase.EntityStore.js M lib/resources/wikibase.ui.AliasesEditTool.js M lib/resources/wikibase.ui.Base.js M lib/resources/wikibase.ui.DescriptionEditTool.js M lib/resources/wikibase.ui.LabelEditTool.js M lib/resources/wikibase.ui.PropertyEditTool.EditableAliases.js M lib/resources/wikibase.ui.PropertyEditTool.EditableDescription.js M lib/resources/wikibase.ui.PropertyEditTool.EditableLabel.js M lib/resources/wikibase.ui.PropertyEditTool.EditableSiteLink.js M lib/resources/wikibase.ui.PropertyEditTool.EditableValue.AliasesInterface.js M lib/resources/wikibase.ui.PropertyEditTool.EditableValue.AutocompleteInterface.js M lib/resources/wikibase.ui.PropertyEditTool.EditableValue.Interface.js M lib/resources/wikibase.ui.PropertyEditTool.EditableValue.ListInterface.js M lib/resources/wikibase.ui.PropertyEditTool.EditableValue.SiteIdInterface.js M lib/resources/wikibase.ui.PropertyEditTool.EditableValue.SitePageInterface.js M lib/resources/wikibase.ui.PropertyEditTool.EditableValue.js M lib/resources/wikibase.ui.PropertyEditTool.css M lib/resources/wikibase.ui.PropertyEditTool.js M
[MediaWiki-commits] [Gerrit] Fix link to repo entity in client recent changes - change (mediawiki...Wikibase[master])
Jens Ohlig has submitted this change and it was merged. Change subject: Fix link to repo entity in client recent changes .. Fix link to repo entity in client recent changes Change-Id: Ia5a1727a1fa5284bb301605689e68c9eba99ca68 --- M client/includes/ExternalChangesList.php 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jens Ohlig: Verified; Looks good to me, approved Nikerabbit: Looks good to me, but someone else must approve -- To view, visit https://gerrit.wikimedia.org/r/34533 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia5a1727a1fa5284bb301605689e68c9eba99ca68 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Aude aude.w...@gmail.com Gerrit-Reviewer: Jens Ohlig jens.oh...@wikimedia.de Gerrit-Reviewer: Nikerabbit niklas.laxst...@gmail.com Gerrit-Reviewer: Tobias Gritschacher tobias.gritschac...@wikimedia.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Typo. - change (mediawiki...Wikibase[master])
Jens Ohlig has uploaded a new change for review. Change subject: Typo. .. Typo. Change-Id: I2876c4b43d78abcf00da16d446b9c57b42c2a305 --- M repo/includes/store/sql/EntityPerPageTable.php 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/74/34874/1 -- To view, visit https://gerrit.wikimedia.org/r/34874 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2876c4b43d78abcf00da16d446b9c57b42c2a305 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jens Ohlig jens.oh...@wikimedia.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (Bug 42150) Write script that queries the database for entit... - change (mediawiki...Wikibase[master])
Jens Ohlig has uploaded a new change for review. Change subject: (Bug 42150) Write script that queries the database for entity artifacts .. (Bug 42150) Write script that queries the database for entity artifacts Change-Id: I1b7bdf820c10af3ba1bc5b29e9376ce9ac24d567 --- A repo/maintenance/searchEntityArtefacts.php 1 file changed, 109 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/81/34881/1 -- To view, visit https://gerrit.wikimedia.org/r/34881 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1b7bdf820c10af3ba1bc5b29e9376ce9ac24d567 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jens Ohlig jens.oh...@wikimedia.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Use \Wikibase\Utils::makePidFilename and \Wikibase\Utils::is... - change (mediawiki...Wikibase[master])
Jens Ohlig has uploaded a new change for review. Change subject: Use \Wikibase\Utils::makePidFilename and \Wikibase\Utils::isAlreadyRunning in pollForChanges .. Use \Wikibase\Utils::makePidFilename and \Wikibase\Utils::isAlreadyRunning in pollForChanges Change-Id: I28739a1dafb87a33d63d30312ab394da29af423c --- M lib/maintenance/pollForChanges.php 1 file changed, 4 insertions(+), 21 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/12/34512/1 -- To view, visit https://gerrit.wikimedia.org/r/34512 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I28739a1dafb87a33d63d30312ab394da29af423c Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jens Ohlig jens.oh...@wikimedia.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] flag for show/hide Wikidata entries on client recent changes - change (mediawiki...Wikibase[master])
Jens Ohlig has submitted this change and it was merged. Change subject: flag for show/hide Wikidata entries on client recent changes .. flag for show/hide Wikidata entries on client recent changes - added a flag to toggle changes from Wikidata in the client recent changes - this partly refers to bug 40568. not sure if we really need a user preference for that or if this filter is sufficient Change-Id: Id094b743915457c6a68b69098a2d63d1d247b4e9 --- M client/WikibaseClient.hooks.php M client/WikibaseClient.i18n.php M client/WikibaseClient.php 3 files changed, 16 insertions(+), 1 deletion(-) Approvals: Jens Ohlig: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/34285 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id094b743915457c6a68b69098a2d63d1d247b4e9 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Tobias Gritschacher tobias.gritschac...@wikimedia.de Gerrit-Reviewer: Aude aude.w...@gmail.com Gerrit-Reviewer: Denny Vrandecic denny.vrande...@wikimedia.de Gerrit-Reviewer: Jens Ohlig jens.oh...@wikimedia.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Move serializers from repo to lib - change (mediawiki...Wikibase[master])
Jens Ohlig has submitted this change and it was merged. Change subject: Move serializers from repo to lib .. Move serializers from repo to lib Already found out that they are not API specific (luckily we split it up in time :) since we need them in the entityview. Now realized we will very likely have similar use for it on the client when we create intrefaces for editing factboxes and the like, so moving this to lib. Since it's clear this is not API specific, it needs some renaming, which will be made in a follow up Change-Id: I1fdc8c28b8df0ea831f0689461693a68b6214597 --- M lib/WikibaseLib.hooks.php M lib/WikibaseLib.php R lib/includes/serializers/ApiSerializationOptions.php R lib/includes/serializers/ApiSerializer.php R lib/includes/serializers/ApiSerializerObject.php R lib/includes/serializers/ByPropertyListSerializer.php R lib/includes/serializers/ClaimSerializer.php R lib/includes/serializers/ClaimsSerializer.php R lib/includes/serializers/EntitySerializer.php R lib/includes/serializers/ItemSerializer.php R lib/includes/serializers/PropertySerializer.php R lib/includes/serializers/SnakSerializer.php R lib/tests/phpunit/serializers/ApiSerializationOptionsTest.php R lib/tests/phpunit/serializers/ApiSerializerBaseTest.php R lib/tests/phpunit/serializers/ApiSerializerTest.php R lib/tests/phpunit/serializers/ByPropertyListSerializerTest.php R lib/tests/phpunit/serializers/ClaimSerializerTest.php R lib/tests/phpunit/serializers/ClaimsSerializerTest.php R lib/tests/phpunit/serializers/EntitySerializerBaseTest.php R lib/tests/phpunit/serializers/ItemSerializerTest.php R lib/tests/phpunit/serializers/PropertySerializerTest.php R lib/tests/phpunit/serializers/SnakSerializerTest.php M repo/Wikibase.hooks.php M repo/Wikibase.php 24 files changed, 33 insertions(+), 34 deletions(-) Approvals: Jens Ohlig: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/34089 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1fdc8c28b8df0ea831f0689461693a68b6214597 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw jeroended...@gmail.com Gerrit-Reviewer: Aude aude.w...@gmail.com Gerrit-Reviewer: Daniel Werner daniel.wer...@wikimedia.de Gerrit-Reviewer: Jens Ohlig jens.oh...@wikimedia.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Follow-up to Jeroen's comments on Change I9f55d082 - change (mediawiki...Wikibase[master])
Jens Ohlig has uploaded a new change for review. Change subject: Follow-up to Jeroen's comments on Change I9f55d082 .. Follow-up to Jeroen's comments on Change I9f55d082 Change-Id: I88865a64d0b3787652ca81c5bb2307aec8a9c1d8 --- M repo/includes/store/sql/SqlStore.php 1 file changed, 24 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/09/33709/1 -- To view, visit https://gerrit.wikimedia.org/r/33709 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I88865a64d0b3787652ca81c5bb2307aec8a9c1d8 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jens Ohlig jens.oh...@wikimedia.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] refactored editconflict selenium tests - change (mediawiki...Wikibase[master])
Jens Ohlig has submitted this change and it was merged. Change subject: refactored editconflict selenium tests .. refactored editconflict selenium tests - according to changes made to the edit conflict handling done in bug 39836 Change-Id: Ia74391c8f663627e46bf6baeb3246b32302370c1 --- M repo/tests/selenium/item/edit_conflict_spec.rb 1 file changed, 24 insertions(+), 62 deletions(-) Approvals: Jens Ohlig: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/33547 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia74391c8f663627e46bf6baeb3246b32302370c1 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Tobias Gritschacher tobias.gritschac...@wikimedia.de Gerrit-Reviewer: Aude aude.w...@gmail.com Gerrit-Reviewer: Daniel Kinzler daniel.kinz...@wikimedia.de Gerrit-Reviewer: Henning Snater henning.sna...@wikimedia.de Gerrit-Reviewer: Jens Ohlig jens.oh...@wikimedia.de Gerrit-Reviewer: Tobias Gritschacher tobias.gritschac...@wikimedia.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Rename parameter back to what it was as per mailinglist disc... - change (mediawiki...Wikibase[master])
Jens Ohlig has submitted this change and it was merged. Change subject: Rename parameter back to what it was as per mailinglist discussion .. Rename parameter back to what it was as per mailinglist discussion Change-Id: I0acb84501aefae0538874ff513566def2208f7a5 --- M repo/includes/api/ApiCreateClaim.php 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Jens Ohlig: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/33573 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0acb84501aefae0538874ff513566def2208f7a5 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw jeroended...@gmail.com Gerrit-Reviewer: Daniel Kinzler daniel.kinz...@wikimedia.de Gerrit-Reviewer: Denny Vrandecic denny.vrande...@wikimedia.de Gerrit-Reviewer: Jens Ohlig jens.oh...@wikimedia.de Gerrit-Reviewer: John Erling Blad john.b...@wikimedia.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Provide arguments for constructor test - change (mediawiki...Diff[master])
Jens Ohlig has submitted this change and it was merged. Change subject: Provide arguments for constructor test .. Provide arguments for constructor test Also improved registration of exception class so myIDE does not go mad :) Change-Id: I24f925aa47590c722a34ddd8c682bc8cc6106e2e --- M Diff.php M includes/MapDiff.php M tests/ListDiffTest.php M tests/MapDiffTest.php 4 files changed, 131 insertions(+), 63 deletions(-) Approvals: Jens Ohlig: Verified; Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/33184 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I24f925aa47590c722a34ddd8c682bc8cc6106e2e Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/Diff Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw jeroended...@gmail.com Gerrit-Reviewer: Jens Ohlig jens.oh...@wikimedia.de Gerrit-Reviewer: Jeroen De Dauw jeroended...@gmail.com Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] add wikivoyage to site group map - change (mediawiki...Wikibase[master])
Jens Ohlig has submitted this change and it was merged. Change subject: add wikivoyage to site group map .. add wikivoyage to site group map Change-Id: Iafed9e46c22f9f5121fedc05a2fee82a518f70fd --- M lib/includes/Utils.php 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Jens Ohlig: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/33060 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iafed9e46c22f9f5121fedc05a2fee82a518f70fd Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Aude aude.w...@gmail.com Gerrit-Reviewer: Daniel Werner daniel.wer...@wikimedia.de Gerrit-Reviewer: Jens Ohlig jens.oh...@wikimedia.de Gerrit-Reviewer: Jeroen De Dauw jeroended...@gmail.com Gerrit-Reviewer: Silke Meyer silke.me...@wikimedia.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] use \pZ (separator) and \pC (control) to squash whitespace i... - change (mediawiki...Wikibase[master])
Jens Ohlig has submitted this change and it was merged. Change subject: use \pZ (separator) and \pC (control) to squash whitespace instead of \s .. use \pZ (separator) and \pC (control) to squash whitespace instead of \s - \s doesn't work 100% of the time and failing with some test cases for me - see http://www.unicode.org/reports/tr18/#Categories for details - this fixes annoying bug! Change-Id: Ia157c3f4fb41e59da09a233f8b64d10ffdd88e96 --- M lib/includes/Utils.php 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Jens Ohlig: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/32580 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia157c3f4fb41e59da09a233f8b64d10ffdd88e96 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Aude aude.w...@gmail.com Gerrit-Reviewer: Aude aude.w...@gmail.com Gerrit-Reviewer: Daniel Kinzler daniel.kinz...@wikimedia.de Gerrit-Reviewer: Jens Ohlig jens.oh...@wikimedia.de Gerrit-Reviewer: Jeroen De Dauw jeroended...@gmail.com Gerrit-Reviewer: John Erling Blad john.b...@wikimedia.de Gerrit-Reviewer: Nikerabbit niklas.laxst...@gmail.com Gerrit-Reviewer: Tobias Gritschacher tobias.gritschac...@wikimedia.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Removed static method from interface as this is not allowed ... - change (mediawiki...Diff[master])
Jens Ohlig has submitted this change and it was merged. Change subject: Removed static method from interface as this is not allowed in strict mode .. Removed static method from interface as this is not allowed in strict mode Change-Id: I6632f674505d62a02e6f8846cc54180d7af397e3 --- M includes/IDiff.php 1 file changed, 0 insertions(+), 9 deletions(-) Approvals: Jens Ohlig: Verified; Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/33179 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6632f674505d62a02e6f8846cc54180d7af397e3 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/Diff Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw jeroended...@gmail.com Gerrit-Reviewer: Aude aude.w...@gmail.com Gerrit-Reviewer: Daniel Werner daniel.wer...@wikimedia.de Gerrit-Reviewer: Henning Snater henning.sna...@wikimedia.de Gerrit-Reviewer: Jens Ohlig jens.oh...@wikimedia.de Gerrit-Reviewer: Reedy re...@wikimedia.org Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (Bug 40238) Add dir=auto to sitelinks - change (mediawiki...Wikibase[master])
Jens Ohlig has submitted this change and it was merged. Change subject: (Bug 40238) Add dir=auto to sitelinks .. (Bug 40238) Add dir=auto to sitelinks Change-Id: I47337650ac53c518d8278d4bb99255fc1de5e1c5 --- M lib/resources/templates.php 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jens Ohlig: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/33046 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I47337650ac53c518d8278d4bb99255fc1de5e1c5 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: John Erling Blad john.b...@wikimedia.de Gerrit-Reviewer: Jens Ohlig jens.oh...@wikimedia.de Gerrit-Reviewer: Jeroen De Dauw jeroended...@gmail.com Gerrit-Reviewer: John Erling Blad john.b...@wikimedia.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] change rebuildrc option to rebuild and also clear entity cac... - change (mediawiki...Wikibase[master])
Jens Ohlig has submitted this change and it was merged. Change subject: change rebuildrc option to rebuild and also clear entity cache and items per site .. change rebuildrc option to rebuild and also clear entity cache and items per site Change-Id: I69a3b3bd5d99e304cf961f7d5efdf3f3cd67cdbe --- M lib/maintenance/pollForChanges.php 1 file changed, 8 insertions(+), 4 deletions(-) Approvals: Jens Ohlig: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/33070 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I69a3b3bd5d99e304cf961f7d5efdf3f3cd67cdbe Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Aude aude.w...@gmail.com Gerrit-Reviewer: Jens Ohlig jens.oh...@wikimedia.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Do not interpret spaces as underscores when doing /langcode/... - change (mediawiki...Wikibase[master])
Jens Ohlig has submitted this change and it was merged. Change subject: Do not interpret spaces as underscores when doing /langcode/text-with-spaces .. Do not interpret spaces as underscores when doing /langcode/text-with-spaces Change-Id: I18ee8abcf7093fc0c4c57819679382c8ba833215 --- M repo/includes/specials/SpecialItemByTitle.php M repo/includes/specials/SpecialItemDisambiguation.php 2 files changed, 7 insertions(+), 6 deletions(-) Approvals: Jens Ohlig: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/33108 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I18ee8abcf7093fc0c4c57819679382c8ba833215 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw jeroended...@gmail.com Gerrit-Reviewer: Aude aude.w...@gmail.com Gerrit-Reviewer: Daniel Werner daniel.wer...@wikimedia.de Gerrit-Reviewer: Henning Snater henning.sna...@wikimedia.de Gerrit-Reviewer: Jens Ohlig jens.oh...@wikimedia.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Removed unused use statements - change (mediawiki...DataValues[master])
Jens Ohlig has submitted this change and it was merged. Change subject: Removed unused use statements .. Removed unused use statements Change-Id: I7ebb52d934f8da43d437b70028b3519a73f09293 --- M ValueParsers/includes/ValueParserFactory.php M ValueParsers/tests/includes/ValueParserFactoryTest.php 2 files changed, 1 insertion(+), 2 deletions(-) Approvals: Jens Ohlig: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/33175 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7ebb52d934f8da43d437b70028b3519a73f09293 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/DataValues Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw jeroended...@gmail.com Gerrit-Reviewer: Aude aude.w...@gmail.com Gerrit-Reviewer: Daniel Werner daniel.wer...@wikimedia.de Gerrit-Reviewer: Henning Snater henning.sna...@wikimedia.de Gerrit-Reviewer: Jens Ohlig jens.oh...@wikimedia.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] wbsearchentity continuation fixed. - change (mediawiki...Wikibase[master])
Jens Ohlig has submitted this change and it was merged. Change subject: wbsearchentity continuation fixed. .. wbsearchentity continuation fixed. patchset 5: rebased fixed conflicts patchset 6: fixed error introduced during rebase patchset 7: fixed remaining issues Change-Id: I77022b81270b8144f77cf3b4f7480670e914c27d --- M repo/includes/api/ApiSearchEntities.php 1 file changed, 22 insertions(+), 25 deletions(-) Approvals: Jens Ohlig: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/31837 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I77022b81270b8144f77cf3b4f7480670e914c27d Gerrit-PatchSet: 8 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jens Ohlig jens.oh...@wikimedia.de Gerrit-Reviewer: Jens Ohlig jens.oh...@wikimedia.de Gerrit-Reviewer: Jeroen De Dauw jeroended...@gmail.com Gerrit-Reviewer: John Erling Blad john.b...@wikimedia.de Gerrit-Reviewer: Tobias Gritschacher tobias.gritschac...@wikimedia.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Added TermMatchScoreCalculator - change (mediawiki...Wikibase[master])
Jens Ohlig has uploaded a new change for review. Change subject: Added TermMatchScoreCalculator .. Added TermMatchScoreCalculator Change-Id: I337cb4ef0d469e849f9da817facd2f79e1c81cfe --- M repo/Wikibase.php M repo/includes/api/ApiSearchEntities.php A repo/includes/store/TermMatchScoreCalculator.php 3 files changed, 66 insertions(+), 9 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/20/32020/1 -- To view, visit https://gerrit.wikimedia.org/r/32020 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I337cb4ef0d469e849f9da817facd2f79e1c81cfe Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jens Ohlig jens.oh...@wikimedia.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] improved array param documentation - change (mediawiki...DataValues[master])
Jens Ohlig has submitted this change and it was merged. Change subject: improved array param documentation .. improved array param documentation Change-Id: If5211d327a4678bee3f299c89d63d3e6e3e8 --- M DataTypes/includes/DataTypeFactory.php M DataTypes/includes/DataTypeObject.php M DataValues/includes/values/MultilingualTextValue.php M ValueParsers/includes/ValueParserFactory.php M ValueValidators/includes/ResultObject.php M ValueValidators/includes/ValueValidatorObject.php 6 files changed, 19 insertions(+), 22 deletions(-) Approvals: Jens Ohlig: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/31841 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: If5211d327a4678bee3f299c89d63d3e6e3e8 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/DataValues Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw jeroended...@gmail.com Gerrit-Reviewer: Aude aude.w...@gmail.com Gerrit-Reviewer: Daniel Werner daniel.wer...@wikimedia.de Gerrit-Reviewer: Denny Vrandecic denny.vrande...@wikimedia.de Gerrit-Reviewer: Jens Ohlig jens.oh...@wikimedia.de Gerrit-Reviewer: Reedy re...@wikimedia.org Gerrit-Reviewer: Tpt thoma...@hotmail.fr ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 41816) fixed reporting of aliases in wbserachentities - change (mediawiki...Wikibase[master])
Jens Ohlig has submitted this change and it was merged. Change subject: (bug 41816) fixed reporting of aliases in wbserachentities .. (bug 41816) fixed reporting of aliases in wbserachentities aliases were reported as object instead of array when the search hit an alias other than the first one. Change-Id: Iea5e866a99fd52a9eec69dd0741b8c865ef35daa --- M repo/includes/api/ApiSearchEntities.php 1 file changed, 11 insertions(+), 5 deletions(-) Approvals: Jens Ohlig: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/32031 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iea5e866a99fd52a9eec69dd0741b8c865ef35daa Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Tobias Gritschacher tobias.gritschac...@wikimedia.de Gerrit-Reviewer: Anja Jentzsch anja.jentz...@wikimedia.de Gerrit-Reviewer: Jens Ohlig jens.oh...@wikimedia.de Gerrit-Reviewer: Jeroen De Dauw jeroended...@gmail.com Gerrit-Reviewer: John Erling Blad john.b...@wikimedia.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (Bug 41580) Show item description in search results. - change (mediawiki...Wikibase[master])
Jens Ohlig has submitted this change and it was merged. Change subject: (Bug 41580) Show item description in search results. .. (Bug 41580) Show item description in search results. Shows the item descriptions in the search result. This requires core patch I9158684b to be merged. Change-Id: I75a782933ebee5532a902f3d6599f8dd91f00762 --- M repo/Wikibase.hooks.php M repo/Wikibase.php 2 files changed, 32 insertions(+), 0 deletions(-) Approvals: Jens Ohlig: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/32041 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I75a782933ebee5532a902f3d6599f8dd91f00762 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Daniel Kinzler daniel.kinz...@wikimedia.de Gerrit-Reviewer: Daniel Kinzler daniel.kinz...@wikimedia.de Gerrit-Reviewer: Jens Ohlig jens.oh...@wikimedia.de Gerrit-Reviewer: Tobias Gritschacher tobias.gritschac...@wikimedia.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (Bug 41214) Changes to use variant length prefixes and fragm... - change (mediawiki...Wikibase[master])
Jens Ohlig has submitted this change and it was merged. Change subject: (Bug 41214) Changes to use variant length prefixes and fragments .. (Bug 41214) Changes to use variant length prefixes and fragments There is also additional tests Patchset 2: Additional docs and changes, also a rebase Patchset 3: Changed a few typos and comments Patchset 4: Added reference to bug Patchset 5: Removed reference, wrong patchset Patchset 6: Rebased Patchset 7: Changed a method to protected static Patchset 8: Rebased Change-Id: I313fb6b9c21ad97bc4bbed71cdf517cf2bcf3ded --- M lib/WikibaseLib.hooks.php M lib/WikibaseLib.php M lib/includes/entity/EntityFactory.php D lib/tests/phpunit/entity/EntityFactoryIsPrefixedIdTest.php M lib/tests/phpunit/entity/EntityFactoryTest.php 5 files changed, 221 insertions(+), 96 deletions(-) Approvals: Jens Ohlig: Verified; Looks good to me, approved Jeroen De Dauw: Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/28527 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I313fb6b9c21ad97bc4bbed71cdf517cf2bcf3ded Gerrit-PatchSet: 8 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: John Erling Blad john.b...@wikimedia.de Gerrit-Reviewer: Jens Ohlig jens.oh...@wikimedia.de Gerrit-Reviewer: Jeroen De Dauw jeroended...@gmail.com Gerrit-Reviewer: John Erling Blad john.b...@wikimedia.de Gerrit-Reviewer: Tobias Gritschacher tobias.gritschac...@wikimedia.de Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] update dataProvider and add testGetClassForType for ChangesT... - change (mediawiki...Wikibase[master])
Jens Ohlig has submitted this change and it was merged. Change subject: update dataProvider and add testGetClassForType for ChangesTableTest .. update dataProvider and add testGetClassForType for ChangesTableTest Change-Id: I1ffda1bccdcdafae79a3b5cb18b13329db1aff19 --- M lib/tests/phpunit/ChangesTableTest.php 1 file changed, 15 insertions(+), 5 deletions(-) Approvals: Jens Ohlig: Verified; Looks good to me, approved Anja Jentzsch: Verified; Looks good to me, but someone else must approve -- To view, visit https://gerrit.wikimedia.org/r/32028 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1ffda1bccdcdafae79a3b5cb18b13329db1aff19 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Aude aude.w...@gmail.com Gerrit-Reviewer: Anja Jentzsch anja.jentz...@wikimedia.de Gerrit-Reviewer: Jens Ohlig jens.oh...@wikimedia.de Gerrit-Reviewer: John Erling Blad john.b...@wikimedia.de Gerrit-Reviewer: Tobias Gritschacher tobias.gritschac...@wikimedia.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (Bug 41580) Supress extracts in search result. - change (mediawiki...Wikibase[master])
Jens Ohlig has submitted this change and it was merged. Change subject: (Bug 41580) Supress extracts in search result. .. (Bug 41580) Supress extracts in search result. The extracts generated by SearchEngine are useless for wikibase entities, because they are based on Content::getTextForSearchIndex. Just hide them. This is a follow-up to I75a78293. Change-Id: I29074acf5fcd20494d44edfe7189bf0254047ac5 --- M repo/Wikibase.hooks.php 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jens Ohlig: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/32045 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I29074acf5fcd20494d44edfe7189bf0254047ac5 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Daniel Kinzler daniel.kinz...@wikimedia.de Gerrit-Reviewer: Jens Ohlig jens.oh...@wikimedia.de Gerrit-Reviewer: Tobias Gritschacher tobias.gritschac...@wikimedia.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fix strict standards warning in TestChanges. - change (mediawiki...Wikibase[master])
Jens Ohlig has submitted this change and it was merged. Change subject: Fix strict standards warning in TestChanges. .. Fix strict standards warning in TestChanges. TestChanges::getItem was missing the static keyword. Please make sure you are using error_reporting( E_ALL | E_STRICT ) in the LocalSettings of your development environment. Change-Id: Ida5fd768ee8241cd98d1f753a0ced5f7885df28c --- M lib/tests/phpunit/changes/TestChanges.php 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jens Ohlig: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/32046 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ida5fd768ee8241cd98d1f753a0ced5f7885df28c Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Daniel Kinzler daniel.kinz...@wikimedia.de Gerrit-Reviewer: Aude aude.w...@gmail.com Gerrit-Reviewer: Jens Ohlig jens.oh...@wikimedia.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Reorganized wbsearchentities - change (mediawiki...Wikibase[master])
Jens Ohlig has uploaded a new change for review. Change subject: Reorganized wbsearchentities .. Reorganized wbsearchentities Change-Id: Ibfa4f3b9725d5b49db0bed8e166c00c224580173 --- M repo/includes/api/ApiSearchEntities.php 1 file changed, 65 insertions(+), 51 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/24/31824/1 -- To view, visit https://gerrit.wikimedia.org/r/31824 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ibfa4f3b9725d5b49db0bed8e166c00c224580173 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jens Ohlig jens.oh...@wikimedia.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] wbsearchentity continuation fixed. - change (mediawiki...Wikibase[master])
Jens Ohlig has uploaded a new change for review. Change subject: wbsearchentity continuation fixed. .. wbsearchentity continuation fixed. Change-Id: I77022b81270b8144f77cf3b4f7480670e914c27d --- M repo/includes/api/ApiSearchEntities.php 1 file changed, 13 insertions(+), 17 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/37/31837/1 -- To view, visit https://gerrit.wikimedia.org/r/31837 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I77022b81270b8144f77cf3b4f7480670e914c27d Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jens Ohlig jens.oh...@wikimedia.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] wbsearchentities to use prefixed ID - change (mediawiki...Wikibase[master])
Jens Ohlig has uploaded a new change for review. Change subject: wbsearchentities to use prefixed ID .. wbsearchentities to use prefixed ID Change-Id: Ic093103f0571dee572ab837d2d8017673a7d003b --- M repo/includes/api/ApiSearchEntities.php 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/15/31215/1 -- To view, visit https://gerrit.wikimedia.org/r/31215 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic093103f0571dee572ab837d2d8017673a7d003b Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jens Ohlig jens.oh...@wikimedia.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (Bug 40561) Rename wbsetitem to wbeditentity - change (mediawiki...Wikibase[master])
Jens Ohlig has submitted this change and it was merged. Change subject: (Bug 40561) Rename wbsetitem to wbeditentity .. (Bug 40561) Rename wbsetitem to wbeditentity There is also a minor but necessary change to make the module handle different types of entities. It will altough not handle other content than sitelinks, and it will try to add this no matter which type of entity is available. This needs fixing in later changestes. Change-Id: I7990922d192a6bda047c9b8ea82ef3c3aef8af1d --- M lib/resources/wikibase.ui.PropertyEditTool.EditableDescription.js M lib/resources/wikibase.ui.PropertyEditTool.EditableLabel.js M lib/tests/phpunit/AutocommentTest.php M repo/Wikibase.hooks.php M repo/Wikibase.i18n.php M repo/Wikibase.php R repo/includes/api/ApiEditEntity.php M repo/tests/phpunit/includes/api/ApiBotEditTest.php R repo/tests/phpunit/includes/api/ApiEditEntityTest.php M repo/tests/phpunit/includes/api/ApiModifyItemBase.php M repo/tests/phpunit/includes/api/ApiPermissionsTest.php 11 files changed, 121 insertions(+), 106 deletions(-) Approvals: Jens Ohlig: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/31221 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7990922d192a6bda047c9b8ea82ef3c3aef8af1d Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: John Erling Blad john.b...@wikimedia.de Gerrit-Reviewer: Jens Ohlig jens.oh...@wikimedia.de Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Introducing maintenance/populateSitesTable.php - change (mediawiki...Wikibase[master])
Jens Ohlig has submitted this change and it was merged. Change subject: Introducing maintenance/populateSitesTable.php .. Introducing maintenance/populateSitesTable.php NOTE: this requires a core change to work, see I7e22cc3c Change-Id: I1ec863c5eb5d9a882023b4cf7b4235e6653c0d15 --- M lib/includes/Utils.php A lib/maintenance/populateSitesTable.php 2 files changed, 97 insertions(+), 8 deletions(-) Approvals: Jens Ohlig: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/31065 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1ec863c5eb5d9a882023b4cf7b4235e6653c0d15 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Daniel Kinzler daniel.kinz...@wikimedia.de Gerrit-Reviewer: Daniel Kinzler daniel.kinz...@wikimedia.de Gerrit-Reviewer: Jens Ohlig jens.oh...@wikimedia.de Gerrit-Reviewer: Jeroen De Dauw jeroended...@gmail.com Gerrit-Reviewer: Reedy re...@wikimedia.org Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (Bug 40561) Fix so sitelinks isn't used any places than in i... - change (mediawiki...Wikibase[master])
Jens Ohlig has submitted this change and it was merged. Change subject: (Bug 40561) Fix so sitelinks isn't used any places than in items .. (Bug 40561) Fix so sitelinks isn't used any places than in items Note that this is a temporary fix. Change-Id: I4d9ab9dfabf146712a1e3c7fe40cedc821041af5 --- M repo/includes/api/ApiEditEntity.php 1 file changed, 12 insertions(+), 1 deletion(-) Approvals: Jens Ohlig: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/31242 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4d9ab9dfabf146712a1e3c7fe40cedc821041af5 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: John Erling Blad john.b...@wikimedia.de Gerrit-Reviewer: Jens Ohlig jens.oh...@wikimedia.de Gerrit-Reviewer: Tobias Gritschacher tobias.gritschac...@wikimedia.de Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Little fix for wbsearchentities with empty result list - change (mediawiki...Wikibase[master])
Jens Ohlig has uploaded a new change for review. Change subject: Little fix for wbsearchentities with empty result list .. Little fix for wbsearchentities with empty result list Change-Id: I20a06a7b4e9c11ee80182feb7e5413ca362e8636 --- M repo/includes/api/ApiSearchEntities.php 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/90/30790/1 -- To view, visit https://gerrit.wikimedia.org/r/30790 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I20a06a7b4e9c11ee80182feb7e5413ca362e8636 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jens Ohlig jens.oh...@wikimedia.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Added testGetSortKey - change (mediawiki...DataValues[master])
Jens Ohlig has submitted this change and it was merged. Change subject: Added testGetSortKey .. Added testGetSortKey Change-Id: I4fc403a3866f92d71c8c662a0ad6d97dc9a484bc --- M DataValues/tests/qunit/DataValue.tests.js 1 file changed, 42 insertions(+), 8 deletions(-) Approvals: Jens Ohlig: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/30584 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4fc403a3866f92d71c8c662a0ad6d97dc9a484bc Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/DataValues Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw jeroended...@gmail.com Gerrit-Reviewer: Aude aude.w...@gmail.com Gerrit-Reviewer: Daniel Werner daniel.wer...@wikimedia.de Gerrit-Reviewer: Henning Snater henning.sna...@wikimedia.de Gerrit-Reviewer: Jens Ohlig jens.oh...@wikimedia.de Gerrit-Reviewer: John Erling Blad john.b...@wikimedia.de Gerrit-Reviewer: Tobias Gritschacher tobias.gritschac...@wikimedia.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] added toJSON and equals tests and fixed broken test method :... - change (mediawiki...DataValues[master])
Jens Ohlig has submitted this change and it was merged. Change subject: added toJSON and equals tests and fixed broken test method :) .. added toJSON and equals tests and fixed broken test method :) Change-Id: Ie0d22bacc02dca06218fc537c972b852e2699b69 --- M DataValues/resources/values/StringValue.js M DataValues/tests/qunit/DataValue.tests.js M DataValues/tests/qunit/values/StringValue.tests.js 3 files changed, 70 insertions(+), 17 deletions(-) Approvals: Jens Ohlig: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/30587 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie0d22bacc02dca06218fc537c972b852e2699b69 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/DataValues Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw jeroended...@gmail.com Gerrit-Reviewer: Aude aude.w...@gmail.com Gerrit-Reviewer: Daniel Werner daniel.wer...@wikimedia.de Gerrit-Reviewer: Henning Snater henning.sna...@wikimedia.de Gerrit-Reviewer: Jens Ohlig jens.oh...@wikimedia.de Gerrit-Reviewer: John Erling Blad john.b...@wikimedia.de Gerrit-Reviewer: Tobias Gritschacher tobias.gritschac...@wikimedia.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (Bug #40391) Add continuation to wbsearchentities and return... - change (mediawiki...Wikibase[master])
Jens Ohlig has uploaded a new change for review. Change subject: (Bug #40391) Add continuation to wbsearchentities and return only matching aliases .. (Bug #40391) Add continuation to wbsearchentities and return only matching aliases Change-Id: I03991a2921d3ac3c50cf7378acbe131abcd3777f --- M repo/includes/api/ApiSearchEntities.php 1 file changed, 37 insertions(+), 9 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/56/29956/1 -- To view, visit https://gerrit.wikimedia.org/r/29956 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I03991a2921d3ac3c50cf7378acbe131abcd3777f Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jens Ohlig jens.oh...@wikimedia.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] First version of a special page for setting a label. (DO NOT... - change (mediawiki...Wikibase[master])
Jens Ohlig has uploaded a new change for review. Change subject: First version of a special page for setting a label. (DO NOT MERGE!) .. First version of a special page for setting a label. (DO NOT MERGE!) In preparation for AJAX less UI. Has still a number of todos. Once this is stable, we can move on for descriptions and sitelinks. Patchset 3: Removed messages to get rid of a pesky merge conflict, will be added back after a rebase Patchset 4: One line in the alias file Patchset 5: Rebase Patchset 6: Added back i18n-stuff Change-Id: I3da75f00d1d71e4c6976444f30d669b9024e5bd4 --- M repo/Wikibase.i18n.alias.php M repo/Wikibase.i18n.php M repo/Wikibase.php A repo/includes/specials/SpecialSetLabel.php 4 files changed, 208 insertions(+), 4 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/11/28511/1 -- To view, visit https://gerrit.wikimedia.org/r/28511 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3da75f00d1d71e4c6976444f30d669b9024e5bd4 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jens Ohlig jens.oh...@wikimedia.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] PHPUnit test for PropertyDiff -- now running under phpunit -... - change (mediawiki...Wikibase[master])
Jens Ohlig has uploaded a new change for review. Change subject: PHPUnit test for PropertyDiff -- now running under phpunit --strict .. PHPUnit test for PropertyDiff -- now running under phpunit --strict Change-Id: I4d915776caff9b42013a51fbe7973d5547276ae5 --- M lib/WikibaseLib.hooks.php A lib/tests/phpunit/entity/EntityDiffTest.php M lib/tests/phpunit/item/ItemDiffTest.php A lib/tests/phpunit/property/PropertyDiffTest.php 4 files changed, 236 insertions(+), 97 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/26/28426/1 -- To view, visit https://gerrit.wikimedia.org/r/28426 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4d915776caff9b42013a51fbe7973d5547276ae5 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jens Ohlig jens.oh...@wikimedia.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Merge Fix handling of prefixed IDs in API and tests. - change (mediawiki...Wikibase[master])
Jens Ohlig has uploaded a new change for review. Change subject: Merge Fix handling of prefixed IDs in API and tests. .. Merge Fix handling of prefixed IDs in API and tests. Change-Id: I4d63ff9af9864a016a84a4a2388d86bfaf59a2be --- 0 files changed, 0 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/29/28429/1 -- To view, visit https://gerrit.wikimedia.org/r/28429 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4d63ff9af9864a016a84a4a2388d86bfaf59a2be Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jens Ohlig jens.oh...@wikimedia.de Gerrit-Reviewer: Jeroen De Dauw jeroended...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Cleanup of entity serialization in the API - change (mediawiki...Wikibase[master])
Jens Ohlig has submitted this change and it was merged. Change subject: Cleanup of entity serialization in the API .. Cleanup of entity serialization in the API * Serialization in ApiGetEntities now happens via a dedicated serialization object rather then methods in the base Api class * Setup to work with all types of entities and will not fatal when not an item * Unchanged output except for the id now being prefixed Change-Id: I97104232a3492b0d89400723007cf7ad48ea7c0e --- M lib/includes/entity/Entity.php M lib/includes/entity/EntityObject.php M repo/Wikibase.php M repo/includes/api/Api.php M repo/includes/api/ApiGetEntities.php M repo/includes/api/serializers/ApiSerializationOptions.php M repo/includes/api/serializers/EntitySerializer.php 7 files changed, 480 insertions(+), 134 deletions(-) Approvals: Jens Ohlig: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/28068 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I97104232a3492b0d89400723007cf7ad48ea7c0e Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw jeroended...@gmail.com Gerrit-Reviewer: Aude aude.w...@gmail.com Gerrit-Reviewer: Daniel Werner daniel.wer...@wikimedia.de Gerrit-Reviewer: Jens Ohlig jens.oh...@wikimedia.de Gerrit-Reviewer: John Erling Blad john.b...@wikimedia.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (Bug #40522) Fix diff on properties - change (mediawiki...Wikibase[master])
Jens Ohlig has uploaded a new change for review. Change subject: (Bug #40522) Fix diff on properties .. (Bug #40522) Fix diff on properties Change-Id: Id24a2448187e0eaa1be85380f7d36426ee8a9905 --- M lib/WikibaseLib.php A lib/includes/property/PropertyDiff.php A lib/includes/property/PropertyDiffView.php M lib/includes/property/PropertyObject.php M repo/includes/content/PropertyHandler.php 5 files changed, 116 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/05/28205/1 -- To view, visit https://gerrit.wikimedia.org/r/28205 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id24a2448187e0eaa1be85380f7d36426ee8a9905 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jens Ohlig jens.oh...@wikimedia.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 40238) Apply correct lang and dir to language names - change (mediawiki...Wikibase[master])
Jens Ohlig has submitted this change and it was merged. Change subject: (bug 40238) Apply correct lang and dir to language names .. (bug 40238) Apply correct lang and dir to language names This is a partial fix for bug 40238. It applies appropriate lang and dir attributes to elements that display the language name. Change-Id: I3b4cab01d04ecb84933836b0402d6fc8ac3c3b32 --- M lib/resources/wikibase.ui.PropertyEditTool.EditableValue.SiteIdInterface.js M repo/includes/ItemView.php 2 files changed, 12 insertions(+), 4 deletions(-) Approvals: Jens Ohlig: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/27873 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3b4cab01d04ecb84933836b0402d6fc8ac3c3b32 Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Amire80 amir.ahar...@mail.huji.ac.il Gerrit-Reviewer: Amire80 amir.ahar...@mail.huji.ac.il Gerrit-Reviewer: Aude aude.w...@gmail.com Gerrit-Reviewer: Daniel Werner daniel.wer...@wikimedia.de Gerrit-Reviewer: Henning Snater henning.sna...@wikimedia.de Gerrit-Reviewer: Jens Ohlig jens.oh...@wikimedia.de Gerrit-Reviewer: Jeroen De Dauw jeroended...@gmail.com Gerrit-Reviewer: Tobias Gritschacher tobias.gritschac...@wikimedia.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (bug 41005) Define tag editor direction - change (mediawiki...Wikibase[master])
Jens Ohlig has submitted this change and it was merged. Change subject: (bug 41005) Define tag editor direction .. (bug 41005) Define tag editor direction Change-Id: I0a3132a99737e0e1d1dab3f130aa9d41d9c78320 --- M lib/resources/wikibase.utilities/wikibase.utilities.jQuery.ui.tagadata/wikibase.utilities.jQuery.ui.tagadata.css 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jens Ohlig: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/27876 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0a3132a99737e0e1d1dab3f130aa9d41d9c78320 Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Amire80 amir.ahar...@mail.huji.ac.il Gerrit-Reviewer: Amire80 amir.ahar...@mail.huji.ac.il Gerrit-Reviewer: Aude aude.w...@gmail.com Gerrit-Reviewer: Daniel Werner daniel.wer...@wikimedia.de Gerrit-Reviewer: Henning Snater henning.sna...@wikimedia.de Gerrit-Reviewer: Jens Ohlig jens.oh...@wikimedia.de Gerrit-Reviewer: Jeroen De Dauw jeroended...@gmail.com Gerrit-Reviewer: Tobias Gritschacher tobias.gritschac...@wikimedia.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] PHPUnit test for PropertyDiff - change (mediawiki...Wikibase[master])
Jens Ohlig has uploaded a new change for review. Change subject: PHPUnit test for PropertyDiff .. PHPUnit test for PropertyDiff Change-Id: I6009b8caea6de79f981f216f224f8c0fd2a138e2 --- A lib/tests/phpunit/property/PropertyDiffTest.php 1 file changed, 112 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/15/28215/1 -- To view, visit https://gerrit.wikimedia.org/r/28215 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6009b8caea6de79f981f216f224f8c0fd2a138e2 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jens Ohlig jens.oh...@wikimedia.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] kill duplicate test, same as DiffChangeTest - change (mediawiki...Wikibase[master])
Jens Ohlig has submitted this change and it was merged. Change subject: kill duplicate test, same as DiffChangeTest .. kill duplicate test, same as DiffChangeTest this is not registered in WikibaseLib.hooks.php as a test Change-Id: Id3cf24df345e255a65edc8aa690c2dd4dcfa51ab --- D lib/tests/phpunit/changes/ChangeTest.php 1 file changed, 0 insertions(+), 72 deletions(-) Approvals: Jens Ohlig: Verified; Looks good to me, approved Jeroen De Dauw: Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/28003 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id3cf24df345e255a65edc8aa690c2dd4dcfa51ab Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Aude aude.w...@gmail.com Gerrit-Reviewer: Jens Ohlig jens.oh...@wikimedia.de Gerrit-Reviewer: Jeroen De Dauw jeroended...@gmail.com Gerrit-Reviewer: Tobias Gritschacher tobias.gritschac...@wikimedia.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Create test script to create properties - change (mediawiki...Wikibase[master])
Jens Ohlig has uploaded a new change for review. Change subject: Create test script to create properties .. Create test script to create properties Change-Id: I319d535aeeebabfc9156ca0ea5ace6332cb7e7bc --- A en-elements-properties.csv A importProperties.php 2 files changed, 180 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/20/27720/1 -- To view, visit https://gerrit.wikimedia.org/r/27720 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I319d535aeeebabfc9156ca0ea5ace6332cb7e7bc Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jens Ohlig jens.oh...@wikimedia.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] This maintenance script really belongs in the client, not in... - change (mediawiki...Wikibase[master])
Jens Ohlig has uploaded a new change for review. Change subject: This maintenance script really belongs in the client, not in lib. .. This maintenance script really belongs in the client, not in lib. Change-Id: Icd527f1e789d50c3f21d2a6ada942ab137bfe9b9 --- R client/maintenance/pollForChanges.php 1 file changed, 0 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/75/27275/1 -- To view, visit https://gerrit.wikimedia.org/r/27275 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Icd527f1e789d50c3f21d2a6ada942ab137bfe9b9 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jens Ohlig jens.oh...@wikimedia.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Added adittional tests for the ApiSerializers - change (mediawiki...Wikibase[master])
Jens Ohlig has submitted this change and it was merged. Change subject: Added adittional tests for the ApiSerializers .. Added adittional tests for the ApiSerializers Change-Id: Ie670dce4f40ad8e757f676fbd9e9ca4fa313e200 --- M repo/includes/api/serializers/StatementSerializer.php M repo/tests/phpunit/includes/api/serializers/SnakSerializerTest.php M repo/tests/phpunit/includes/api/serializers/StatementSerializerTest.php M repo/tests/phpunit/includes/api/serializers/StatementsSerializerTest.php 4 files changed, 56 insertions(+), 9 deletions(-) Approvals: Jens Ohlig: Verified; Looks good to me, approved John Erling Blad: Verified; Looks good to me, but someone else must approve Objections: Nikerabbit: There's a problem with this change, please improve -- To view, visit https://gerrit.wikimedia.org/r/27208 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie670dce4f40ad8e757f676fbd9e9ca4fa313e200 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw jeroended...@gmail.com Gerrit-Reviewer: Jens Ohlig jens.oh...@wikimedia.de Gerrit-Reviewer: Jeroen De Dauw jeroended...@gmail.com Gerrit-Reviewer: John Erling Blad john.b...@wikimedia.de Gerrit-Reviewer: Nikerabbit niklas.laxst...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Ignore selenium/configuration.yml - change (mediawiki...Wikibase[master])
Jens Ohlig has uploaded a new change for review. Change subject: Ignore selenium/configuration.yml .. Ignore selenium/configuration.yml Change-Id: Ic2e4dcb846cf49725f6043813f1fead16b197924 --- M .gitignore 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/96/27296/1 -- To view, visit https://gerrit.wikimedia.org/r/27296 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic2e4dcb846cf49725f6043813f1fead16b197924 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jens Ohlig jens.oh...@wikimedia.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Added base for ValueFormatters - change (mediawiki...DataValues[master])
Jens Ohlig has submitted this change and it was merged. Change subject: Added base for ValueFormatters .. Added base for ValueFormatters Change-Id: I04933b16d8ff0aa59a0a91c50d07f6738e1294fa --- M DataValues.php A ValueFormatters/COPYING A ValueFormatters/INSTALL A ValueFormatters/README A ValueFormatters/RELEASE-NOTES A ValueFormatters/ValueFormatters.classes.php A ValueFormatters/ValueFormatters.i18n.php A ValueFormatters/ValueFormatters.mw.php A ValueFormatters/ValueFormatters.php M ValueParsers/ValueParsers.i18n.php 10 files changed, 609 insertions(+), 2 deletions(-) Approvals: Jens Ohlig: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/27047 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I04933b16d8ff0aa59a0a91c50d07f6738e1294fa Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/DataValues Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw jeroended...@gmail.com Gerrit-Reviewer: Anja Jentzsch anja.jentz...@wikimedia.de Gerrit-Reviewer: Aude aude.w...@gmail.com Gerrit-Reviewer: Daniel Kinzler daniel.kinz...@wikimedia.de Gerrit-Reviewer: Daniel Werner daniel.wer...@wikimedia.de Gerrit-Reviewer: Jens Ohlig jens.oh...@wikimedia.de Gerrit-Reviewer: Jeroen De Dauw jeroended...@gmail.com Gerrit-Reviewer: John Erling Blad john.b...@wikimedia.de Gerrit-Reviewer: Tobias Gritschacher tobias.gritschac...@wikimedia.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (Bug #40563) Rebuilding the store on the client when repo is... - change (mediawiki...Wikibase[master])
Jens Ohlig has uploaded a new change for review. Change subject: (Bug #40563) Rebuilding the store on the client when repo is rebuilt (DO NOT MERGE) .. (Bug #40563) Rebuilding the store on the client when repo is rebuilt (DO NOT MERGE) Change-Id: If1d1841a0247180668e061c32d36112b53451801 --- M client/WikibaseClient.hooks.php M client/WikibaseClient.php 2 files changed, 30 insertions(+), 9 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/77/27177/1 -- To view, visit https://gerrit.wikimedia.org/r/27177 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If1d1841a0247180668e061c32d36112b53451801 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jens Ohlig jens.oh...@wikimedia.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] update default settings to sort by code order - change (mediawiki...Wikibase[master])
Jens Ohlig has submitted this change and it was merged. Change subject: update default settings to sort by code order .. update default settings to sort by code order Nearly all Wikipedias sort the links by code order This can be a default setting, which still can be overridden in cases where another sort order is used. Change-Id: Ie7e23f2621a76c282b013c3a2ef5c248f58ed912 --- M client/WikibaseClient.hooks.php 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jens Ohlig: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/27152 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie7e23f2621a76c282b013c3a2ef5c248f58ed912 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Aude aude.w...@gmail.com Gerrit-Reviewer: Jens Ohlig jens.oh...@wikimedia.de Gerrit-Reviewer: Tobias Gritschacher tobias.gritschac...@wikimedia.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (Bug #40563) Rebuilding the store on the client when repo is... - change (mediawiki...Wikibase[master])
Jens Ohlig has submitted this change and it was merged. Change subject: (Bug #40563) Rebuilding the store on the client when repo is rebuilt (DO NOT MERGE) .. (Bug #40563) Rebuilding the store on the client when repo is rebuilt (DO NOT MERGE) Change-Id: If1d1841a0247180668e061c32d36112b53451801 --- M client/WikibaseClient.hooks.php M client/WikibaseClient.php 2 files changed, 30 insertions(+), 9 deletions(-) -- To view, visit https://gerrit.wikimedia.org/r/27177 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: If1d1841a0247180668e061c32d36112b53451801 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jens Ohlig jens.oh...@wikimedia.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] (Bug #40563) Rebuilding the store on the client when repo is... - change (mediawiki...Wikibase[master])
Jens Ohlig has uploaded a new change for review. Change subject: (Bug #40563) Rebuilding the store on the client when repo is rebuilt (DO NOT MERGE) .. (Bug #40563) Rebuilding the store on the client when repo is rebuilt (DO NOT MERGE) Change-Id: Ieffa844bbc871345a9daf87f25a1f3496d7c385e --- M client/includes/store/ClientStore.php M client/includes/store/EntityCache.php M client/includes/store/sql/ClientSqlStore.php M client/includes/store/sql/EntityCacheTable.php 4 files changed, 30 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/86/27186/1 -- To view, visit https://gerrit.wikimedia.org/r/27186 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ieffa844bbc871345a9daf87f25a1f3496d7c385e Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jens Ohlig jens.oh...@wikimedia.de ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
