[MediaWiki-commits] [Gerrit] mediawiki...BiblioPlus[master]: Changed all NCBI urls from http to https.

2016-09-20 Thread KarenEddy (Code Review)
KarenEddy has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/311894

Change subject: Changed all NCBI urls from http to https.
..

Changed all NCBI urls from http to https.

Change-Id: I36f0bb65337b24735ffde74680cd9af2f96bbc02
---
M BiblioPlus.body.php
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/BiblioPlus 
refs/changes/94/311894/1

diff --git a/BiblioPlus.body.php b/BiblioPlus.body.php
index 034dc8f..3c988d6 100644
--- a/BiblioPlus.body.php
+++ b/BiblioPlus.body.php
@@ -148,7 +148,7 @@
 function eSummary( $pmids ) {
 if ( count( $pmids ) > 0 ) {
 global $wgSitename, $wgEmergencyContact;
-define( 'EUTILS_ROOT', 
"http://eutils.ncbi.nlm.nih.gov/entrez/eutils/; );
+define( 'EUTILS_ROOT', 
"https://eutils.ncbi.nlm.nih.gov/entrez/eutils/; );
 define( 'ESUMMARY_URL', EUTILS_ROOT . 'esummary.fcgi' );
 
wfSuppressWarnings();
@@ -266,7 +266,7 @@
$doi, "DOI: $doi" ) . ' |';
 } elseif ( $pmid != '' ) {
 $title = 'title="' .wfMessage( 'biblioplus-pmid-tooltip' 
)->escaped() . '"';
-$result = "http://eutils.ncbi.nlm.nih.gov/entrez/eutils/elink.fcgi?cmd=prlinks=pubmed=ref=$pmid\;
 $title $style>$result";
+$result = "https://eutils.ncbi.nlm.nih.gov/entrez/eutils/elink.fcgi?cmd=prlinks=pubmed=ref=$pmid\;
 $title $style>$result";
 } elseif ( $isbn != '' ) {
 $title = 'title="' . wfMessage( 'biblioplus-isbn-tooltip' 
)->escaped() . '"';
 $result = "http://isbndb.com/d/book/$isbndbref.html\; 
$title $style>$result";
@@ -309,7 +309,7 @@
*/
 function pubMedUrl( $pmids ) {
 $listUids = implode( ',', $pmids );
-return 
"http://www.ncbi.nlm.nih.gov/entrez/query.fcgi?cmd=Retrieve=pubmed=Abstract_uids=$listUids;;
+return 
"https://www.ncbi.nlm.nih.gov/entrez/query.fcgi?cmd=Retrieve=pubmed=Abstract_uids=$listUids;;
 }
 
/**

-- 
To view, visit https://gerrit.wikimedia.org/r/311894
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I36f0bb65337b24735ffde74680cd9af2f96bbc02
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BiblioPlus
Gerrit-Branch: master
Gerrit-Owner: KarenEddy 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Critical Update: Fixes an infinite loop in an xml parsing fu... - change (mediawiki...BiblioPlus)

2013-07-15 Thread KarenEddy (Code Review)
KarenEddy has submitted this change and it was merged.

Change subject: Critical Update: Fixes an infinite loop in an xml parsing 
function.
..


Critical Update:
Fixes an infinite loop in an xml parsing function.

Change-Id: I54303300c0442cf1beefc391a182e68b6485ad04
(cherry picked from commit 1f077732a1267c44104985ba3f10132811bbc249)
---
M BiblioPlus.body.php
1 file changed, 16 insertions(+), 16 deletions(-)

Approvals:
  KarenEddy: Verified; Looks good to me, approved



diff --git a/BiblioPlus.body.php b/BiblioPlus.body.php
index 88ebdfb..f77d592 100644
--- a/BiblioPlus.body.php
+++ b/BiblioPlus.body.php
@@ -182,17 +182,14 @@
*/
 function parsePubMed( $pmXml ) {
 $formattedRefs = array();
-
 $xml = simplexml_load_string( $pmXml );
 
 if ( $xml ) {
 // find the document summary tags
 $docSums = $xml;
-while ( $docSums-getName() != 'DocumentSummary' ) {
-$docSums = $docSums-children();
-}
+   $docSums = $docSums-xpath('//DocumentSummary');
 
-// extract required information from each document summary
+   // extract required information from each document summary
 foreach ( $docSums as $docSum ) {
 $authors = array();
 
@@ -200,10 +197,12 @@
 $pmid = ( string )$docSum['uid'];
 
 // get the list of authors
-foreach ( $docSum-Authors-children() as $author ) {
-$authors[] = $author-Name;
-}
-$authors = $this-concatAuthors( $authors );
+   if ( $docSum-Authors ) {
+   foreach ( $docSum-Authors-children() 
as $author ) {
+   $authors[] = $author-Name;
+   }
+   $authors = $this-concatAuthors( 
$authors );
+   }
 
 // get the other attributes
 $title = $docSum-Title;
@@ -214,13 +213,14 @@
 $pages = $docSum-Pages;
 $doi = '';
 
-foreach ( $docSum-ArticleIds-children() as $articleId ) {
-if ( $articleId-IdType == 'doi' ) {
-$doi = $articleId-Value;
-break;
-}
-}
-
+   if ( $docSum-ArticleIds ) {
+   foreach ( 
$docSum-ArticleIds-children() as $articleId ) {
+   if ( $articleId-IdType == 
'doi' ) {
+   $doi = 
$articleId-Value;
+   break;
+   }
+   }
+   }
 // format for output to page
 $origin = $source $pubDate;
 $origin .= $volume == '' ? '' : ;$volume;

-- 
To view, visit https://gerrit.wikimedia.org/r/72685
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I54303300c0442cf1beefc391a182e68b6485ad04
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/BiblioPlus
Gerrit-Branch: master
Gerrit-Owner: KarenEddy kfe...@msn.com
Gerrit-Reviewer: Acrida francescf...@gmail.com
Gerrit-Reviewer: KarenEddy kfe...@msn.com
Gerrit-Reviewer: Owora mireiafabre...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Critical Update: Fixes an infinite loop in an xml parsing fu... - change (mediawiki...BiblioPlus)

2013-07-08 Thread KarenEddy (Code Review)
KarenEddy has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/72685


Change subject: Critical Update: Fixes an infinite loop in an xml parsing 
function.
..

Critical Update:
Fixes an infinite loop in an xml parsing function.

Change-Id: I54303300c0442cf1beefc391a182e68b6485ad04
---
M BiblioPlus.body.php
1 file changed, 16 insertions(+), 16 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/BiblioPlus 
refs/changes/85/72685/1

diff --git a/BiblioPlus.body.php b/BiblioPlus.body.php
index 88ebdfb..f77d592 100644
--- a/BiblioPlus.body.php
+++ b/BiblioPlus.body.php
@@ -182,17 +182,14 @@
*/
 function parsePubMed( $pmXml ) {
 $formattedRefs = array();
-
 $xml = simplexml_load_string( $pmXml );
 
 if ( $xml ) {
 // find the document summary tags
 $docSums = $xml;
-while ( $docSums-getName() != 'DocumentSummary' ) {
-$docSums = $docSums-children();
-}
+   $docSums = $docSums-xpath('//DocumentSummary');
 
-// extract required information from each document summary
+   // extract required information from each document summary
 foreach ( $docSums as $docSum ) {
 $authors = array();
 
@@ -200,10 +197,12 @@
 $pmid = ( string )$docSum['uid'];
 
 // get the list of authors
-foreach ( $docSum-Authors-children() as $author ) {
-$authors[] = $author-Name;
-}
-$authors = $this-concatAuthors( $authors );
+   if ( $docSum-Authors ) {
+   foreach ( $docSum-Authors-children() 
as $author ) {
+   $authors[] = $author-Name;
+   }
+   $authors = $this-concatAuthors( 
$authors );
+   }
 
 // get the other attributes
 $title = $docSum-Title;
@@ -214,13 +213,14 @@
 $pages = $docSum-Pages;
 $doi = '';
 
-foreach ( $docSum-ArticleIds-children() as $articleId ) {
-if ( $articleId-IdType == 'doi' ) {
-$doi = $articleId-Value;
-break;
-}
-}
-
+   if ( $docSum-ArticleIds ) {
+   foreach ( 
$docSum-ArticleIds-children() as $articleId ) {
+   if ( $articleId-IdType == 
'doi' ) {
+   $doi = 
$articleId-Value;
+   break;
+   }
+   }
+   }
 // format for output to page
 $origin = $source $pubDate;
 $origin .= $volume == '' ? '' : ;$volume;

-- 
To view, visit https://gerrit.wikimedia.org/r/72685
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I54303300c0442cf1beefc391a182e68b6485ad04
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BiblioPlus
Gerrit-Branch: master
Gerrit-Owner: KarenEddy kfe...@msn.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Patch7: Modified code to meet coding conventions - change (mediawiki...BiblioPlus[master])

2013-01-14 Thread KarenEddy (Code Review)
KarenEddy has submitted this change and it was merged.

Change subject: Patch7: Modified code to meet coding conventions
..


Patch7: Modified code to meet coding conventions

Change-Id: I94f93b5bb76c28b8781ed46ac2e5815e7158f1ec
---
M BiblioPlus.body.php
M BiblioPlus.php
M BiblioXml.php
D QTips2/.gitignore
D QTips2/LICENSE-GPL
D QTips2/LICENSE-MIT
D QTips2/README.md
D QTips2/dist/basic/jquery.qtip.css
D QTips2/dist/basic/jquery.qtip.js
D QTips2/dist/basic/jquery.qtip.min.css
D QTips2/dist/basic/jquery.qtip.min.js
D QTips2/dist/jquery.qtip.css
D QTips2/dist/jquery.qtip.js
D QTips2/dist/jquery.qtip.min.css
D QTips2/docs/build.md
D QTips2/docs/content.md
D QTips2/docs/core.md
D QTips2/docs/events.md
D QTips2/docs/faq.md
D QTips2/docs/gettingstarted.md
D QTips2/docs/global.md
D QTips2/docs/guide-content.md
D QTips2/docs/hide.md
D QTips2/docs/plugins/ajax.md
D QTips2/docs/plugins/bgiframe.md
D QTips2/docs/plugins/imagemap.md
D QTips2/docs/plugins/modal.md
D QTips2/docs/plugins/svg.md
D QTips2/docs/plugins/tips.md
D QTips2/docs/plugins/viewport.md
D QTips2/docs/position.md
D QTips2/docs/show.md
D QTips2/docs/style.md
D QTips2/docs/toc.md
D QTips2/grunt.js
D QTips2/hooks/post-commit
D QTips2/hooks/pre-commit
D QTips2/libs/jquery-loader.js
D QTips2/libs/jquery/jquery.js
D QTips2/package.json
D QTips2/qtip2.jquery.json
D QTips2/src/ajax/ajax.js
D QTips2/src/basic.css
D QTips2/src/bgiframe/bgiframe.js
D QTips2/src/core.css
D QTips2/src/core.js
D QTips2/src/css3.css
D QTips2/src/imagemap/imagemap.js
D QTips2/src/intro.js
D QTips2/src/modal/modal.css
D QTips2/src/modal/modal.js
D QTips2/src/outro.js
D QTips2/src/svg/svg.js
D QTips2/src/tips/tips.css
D QTips2/src/tips/tips.js
D QTips2/src/viewport/viewport.js
M README
A resources/ext.biblioPlus.qtip.config.js
A resources/ext.biblioPlus.qtip/ext.biblioPlus.qtip.min.css
R resources/ext.biblioPlus.qtip/ext.biblioPlus.qtip.min.js
60 files changed, 934 insertions(+), 23,973 deletions(-)

Approvals:
  Siebrand: Looks good to me, approved
  KarenEddy: Verified


--
To view, visit https://gerrit.wikimedia.org/r/41914
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I94f93b5bb76c28b8781ed46ac2e5815e7158f1ec
Gerrit-PatchSet: 5
Gerrit-Project: mediawiki/extensions/BiblioPlus
Gerrit-Branch: master
Gerrit-Owner: KarenEddy kfe...@msn.com
Gerrit-Reviewer: KarenEddy kfe...@msn.com
Gerrit-Reviewer: Siebrand siebr...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Patch7: Modified code to meet coding conventions - change (mediawiki...BiblioPlus[master])

2013-01-01 Thread KarenEddy (Code Review)
KarenEddy has uploaded a new change for review.

Change subject: Patch7: Modified code to meet coding conventions
..

Patch7: Modified code to meet coding conventions

Change-Id: I94f93b5bb76c28b8781ed46ac2e5815e7158f1ec
---
M BiblioPlus.body.php
M BiblioPlus.i18n.php
M BiblioPlus.php
M BiblioXml.php
D QTips2/.gitignore
D QTips2/LICENSE-GPL
D QTips2/LICENSE-MIT
D QTips2/README.md
D QTips2/dist/basic/jquery.qtip.css
D QTips2/dist/basic/jquery.qtip.js
D QTips2/dist/basic/jquery.qtip.min.css
D QTips2/dist/basic/jquery.qtip.min.js
D QTips2/dist/jquery.qtip.css
D QTips2/dist/jquery.qtip.js
D QTips2/dist/jquery.qtip.min.css
D QTips2/docs/build.md
D QTips2/docs/content.md
D QTips2/docs/core.md
D QTips2/docs/events.md
D QTips2/docs/faq.md
D QTips2/docs/gettingstarted.md
D QTips2/docs/global.md
D QTips2/docs/guide-content.md
D QTips2/docs/hide.md
D QTips2/docs/plugins/ajax.md
D QTips2/docs/plugins/bgiframe.md
D QTips2/docs/plugins/imagemap.md
D QTips2/docs/plugins/modal.md
D QTips2/docs/plugins/svg.md
D QTips2/docs/plugins/tips.md
D QTips2/docs/plugins/viewport.md
D QTips2/docs/position.md
D QTips2/docs/show.md
D QTips2/docs/style.md
D QTips2/docs/toc.md
D QTips2/grunt.js
D QTips2/hooks/post-commit
D QTips2/hooks/pre-commit
D QTips2/libs/jquery-loader.js
D QTips2/libs/jquery/jquery.js
D QTips2/package.json
D QTips2/qtip2.jquery.json
D QTips2/src/ajax/ajax.js
D QTips2/src/basic.css
D QTips2/src/bgiframe/bgiframe.js
D QTips2/src/core.css
D QTips2/src/core.js
D QTips2/src/css3.css
D QTips2/src/imagemap/imagemap.js
D QTips2/src/intro.js
D QTips2/src/modal/modal.css
D QTips2/src/modal/modal.js
D QTips2/src/outro.js
D QTips2/src/svg/svg.js
D QTips2/src/tips/tips.css
D QTips2/src/tips/tips.js
D QTips2/src/viewport/viewport.js
M README
A resources/ext.biblioPlus.qtip.config.js
A resources/ext.biblioPlus.qtip/ext.biblioPlus.qtip.min.css
R resources/ext.biblioPlus.qtip/ext.biblioPlus.qtip.min.js
61 files changed, 860 insertions(+), 24,033 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/BiblioPlus 
refs/changes/14/41914/1
--
To view, visit https://gerrit.wikimedia.org/r/41914
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I94f93b5bb76c28b8781ed46ac2e5815e7158f1ec
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BiblioPlus
Gerrit-Branch: master
Gerrit-Owner: KarenEddy kfe...@msn.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Coding Convention Modifications - change (mediawiki...BiblioPlus[master])

2012-11-15 Thread KarenEddy (Code Review)
KarenEddy has uploaded a new change for review.

Change subject: Coding Convention Modifications
..

Coding Convention Modifications

Modified code to meet coding conventions
Changed javascript function to avoid possible error

Change-Id: I77fc87615f915fa5be34da8629a068cb66de7656
---
M BiblioPlus.body.php
M BiblioPlus.php
D QTips2/.gitignore
D QTips2/LICENSE-GPL
D QTips2/LICENSE-MIT
D QTips2/README.md
D QTips2/dist/basic/jquery.qtip.css
D QTips2/dist/basic/jquery.qtip.js
D QTips2/dist/basic/jquery.qtip.min.css
D QTips2/dist/basic/jquery.qtip.min.js
D QTips2/dist/jquery.qtip.css
D QTips2/dist/jquery.qtip.js
D QTips2/dist/jquery.qtip.min.css
D QTips2/docs/build.md
D QTips2/docs/content.md
D QTips2/docs/core.md
D QTips2/docs/events.md
D QTips2/docs/faq.md
D QTips2/docs/gettingstarted.md
D QTips2/docs/global.md
D QTips2/docs/guide-content.md
D QTips2/docs/hide.md
D QTips2/docs/plugins/ajax.md
D QTips2/docs/plugins/bgiframe.md
D QTips2/docs/plugins/imagemap.md
D QTips2/docs/plugins/modal.md
D QTips2/docs/plugins/svg.md
D QTips2/docs/plugins/tips.md
D QTips2/docs/plugins/viewport.md
D QTips2/docs/position.md
D QTips2/docs/show.md
D QTips2/docs/style.md
D QTips2/docs/toc.md
D QTips2/grunt.js
D QTips2/hooks/post-commit
D QTips2/hooks/pre-commit
D QTips2/libs/jquery-loader.js
D QTips2/libs/jquery/jquery.js
D QTips2/package.json
D QTips2/qtip2.jquery.json
D QTips2/src/ajax/ajax.js
D QTips2/src/basic.css
D QTips2/src/bgiframe/bgiframe.js
D QTips2/src/core.css
D QTips2/src/core.js
D QTips2/src/css3.css
D QTips2/src/imagemap/imagemap.js
D QTips2/src/intro.js
D QTips2/src/modal/modal.css
D QTips2/src/modal/modal.js
D QTips2/src/outro.js
D QTips2/src/svg/svg.js
D QTips2/src/tips/tips.css
D QTips2/src/tips/tips.js
D QTips2/src/viewport/viewport.js
A resources/ext.biblioPlus.qtip.config.js
A resources/ext.biblioPlus.qtip/ext.biblioPlus.qtip.min.css
R resources/ext.biblioPlus.qtip/ext.biblioPlus.qtip.min.js
D tooltipConfig.js
59 files changed, 737 insertions(+), 23,858 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/BiblioPlus 
refs/changes/88/33688/1
--
To view, visit https://gerrit.wikimedia.org/r/33688
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I77fc87615f915fa5be34da8629a068cb66de7656
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BiblioPlus
Gerrit-Branch: master
Gerrit-Owner: KarenEddy kfe...@msn.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Patch 5 Deleted tooltip-id reference, am using href attribut... - change (mediawiki...BiblioPlus[master])

2012-10-28 Thread KarenEddy (Code Review)
KarenEddy has uploaded a new change for review.

Change subject: Patch 5 Deleted tooltip-id reference, am using href attribute 
Fixed white space errors added space before rel attribute Moved QTip css  js 
files to resources folder Deleted unnecessary QTip files
..

Patch 5
Deleted tooltip-id reference, am using href attribute
Fixed white space errors
added space before rel attribute
Moved QTip css  js files to resources folder
Deleted unnecessary QTip files

Change-Id: Ibdfd970eea8ab7f77c9a4be297626bc0d27e7287
---
M BiblioPlus.body.php
M BiblioPlus.php
D QTips2/.gitignore
D QTips2/LICENSE-GPL
D QTips2/LICENSE-MIT
D QTips2/README.md
D QTips2/dist/basic/jquery.qtip.css
D QTips2/dist/basic/jquery.qtip.js
D QTips2/dist/basic/jquery.qtip.min.css
D QTips2/dist/basic/jquery.qtip.min.js
D QTips2/dist/jquery.qtip.css
D QTips2/dist/jquery.qtip.js
D QTips2/dist/jquery.qtip.min.css
D QTips2/docs/build.md
D QTips2/docs/content.md
D QTips2/docs/core.md
D QTips2/docs/events.md
D QTips2/docs/faq.md
D QTips2/docs/gettingstarted.md
D QTips2/docs/global.md
D QTips2/docs/guide-content.md
D QTips2/docs/hide.md
D QTips2/docs/plugins/ajax.md
D QTips2/docs/plugins/bgiframe.md
D QTips2/docs/plugins/imagemap.md
D QTips2/docs/plugins/modal.md
D QTips2/docs/plugins/svg.md
D QTips2/docs/plugins/tips.md
D QTips2/docs/plugins/viewport.md
D QTips2/docs/position.md
D QTips2/docs/show.md
D QTips2/docs/style.md
D QTips2/docs/toc.md
D QTips2/grunt.js
D QTips2/hooks/post-commit
D QTips2/hooks/pre-commit
D QTips2/libs/jquery-loader.js
D QTips2/libs/jquery/jquery.js
D QTips2/package.json
D QTips2/qtip2.jquery.json
D QTips2/src/ajax/ajax.js
D QTips2/src/basic.css
D QTips2/src/bgiframe/bgiframe.js
D QTips2/src/core.css
D QTips2/src/core.js
D QTips2/src/css3.css
D QTips2/src/imagemap/imagemap.js
D QTips2/src/intro.js
D QTips2/src/modal/modal.css
D QTips2/src/modal/modal.js
D QTips2/src/outro.js
D QTips2/src/svg/svg.js
D QTips2/src/tips/tips.css
D QTips2/src/tips/tips.js
D QTips2/src/viewport/viewport.js
A resources/ext.biblioPlus/ext.biblioPlus.qtip.min.css
R resources/ext.biblioPlus/ext.biblioPlus.qtip.min.js
R resources/ext.biblioPlus/ext.biblioPlus.qtipConfig.js
58 files changed, 48 insertions(+), 23,286 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/BiblioPlus 
refs/changes/55/30555/1
--
To view, visit https://gerrit.wikimedia.org/r/30555
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibdfd970eea8ab7f77c9a4be297626bc0d27e7287
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BiblioPlus
Gerrit-Branch: master
Gerrit-Owner: KarenEddy kfe...@msn.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Added an acknowlegement of funding for the extension. - change (mediawiki...BiblioPlus[master])

2012-09-11 Thread KarenEddy (Code Review)
KarenEddy has submitted this change and it was merged.

Change subject: Added an acknowlegement of funding for the extension.
..


Added an acknowlegement of funding for the extension.

Change-Id: Id7957dd5acd70baa96c9c99c5910c274f63a8da6
---
M BiblioPlus.php
M README
2 files changed, 27 insertions(+), 0 deletions(-)


--
To view, visit https://gerrit.wikimedia.org/r/23290
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id7957dd5acd70baa96c9c99c5910c274f63a8da6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BiblioPlus
Gerrit-Branch: master
Gerrit-Owner: KarenEddy kfe...@msn.com
Gerrit-Reviewer: KarenEddy kfe...@msn.com
Gerrit-Reviewer: saper sa...@saper.info

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Added tooltips to the in-text citations. - change (mediawiki...BiblioPlus[master])

2012-09-11 Thread KarenEddy (Code Review)
KarenEddy has uploaded a new change for review.

Change subject: Added tooltips to the in-text citations.
..

Added tooltips to the in-text citations.

The tooltip shows the reference corresponding to each citation.

Change-Id: Id4dffb5c637e3ae741508f7b9a2a95e439dcc36a
---
M BiblioPlus.body.php
M BiblioPlus.php
M README
A tooltipConfig.js
4 files changed, 63 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/BiblioPlus 
refs/changes/82/23482/1
--
To view, visit https://gerrit.wikimedia.org/r/23482
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id4dffb5c637e3ae741508f7b9a2a95e439dcc36a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BiblioPlus
Gerrit-Branch: master
Gerrit-Owner: KarenEddy kfe...@msn.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] Patch set 3: i18n modifications - prefixed each message key ... - change (mediawiki...BiblioPlus[master])

2012-08-24 Thread KarenEddy (Code Review)
KarenEddy has submitted this change and it was merged.

Change subject: Patch set 3: i18n modifications - prefixed each message key 
with biblioplus- - made all keys lowercase - changed keys in other files to 
match
..


Patch set 3: i18n modifications
- prefixed each message key with biblioplus-
- made all keys lowercase
- changed keys in other files to match

Change-Id: Ie52ca56ac8a048758a5c3d356707619e90f6bc4d
---
M BiblioPlus.body.php
M BiblioPlus.i18n.php
M BiblioPlus.php
3 files changed, 15 insertions(+), 22 deletions(-)

Objections:
  Raimond Spekking: There's a problem with this change, please improve


--
To view, visit https://gerrit.wikimedia.org/r/20914
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie52ca56ac8a048758a5c3d356707619e90f6bc4d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BiblioPlus
Gerrit-Branch: master
Gerrit-Owner: KarenEddy kfe...@msn.com
Gerrit-Reviewer: Raimond Spekking raimond.spekk...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] New extension - Formats references from PubMed and the ISBN ... - change (mediawiki...BiblioPlus[master])

2012-08-15 Thread KarenEddy (Code Review)
KarenEddy has submitted this change and it was merged.

Change subject: New extension - Formats references from PubMed and the ISBN 
database
..


New extension - Formats references from PubMed and the ISBN database

Change-Id: I21df53eb422c9c622c261d7f0203ee2956a973a9
---
A BiblioPlus.body.php
A BiblioPlus.i18n.php
A BiblioPlus.php
A BiblioXml.php
A README
5 files changed, 1,237 insertions(+), 0 deletions(-)

Objections:
  Nikerabbit: There's a problem with this change, please improve


--
To view, visit https://gerrit.wikimedia.org/r/16645
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I21df53eb422c9c622c261d7f0203ee2956a973a9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BiblioPlus
Gerrit-Branch: master
Gerrit-Owner: KarenEddy kfe...@msn.com
Gerrit-Reviewer: Nikerabbit niklas.laxst...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] New extension - Formats references from PubMed and the ISBN ... - change (mediawiki...BiblioPlus[master])

2012-07-25 Thread KarenEddy (Code Review)
KarenEddy has uploaded a new change for review.

Change subject: New extension - Formats references from PubMed and the ISBN 
database
..

New extension - Formats references from PubMed and the ISBN database

Change-Id: I21df53eb422c9c622c261d7f0203ee2956a973a9
---
A BiblioPlus.body.php
A BiblioPlus.i18n.php
A BiblioPlus.php
A BiblioXml.php
A README
5 files changed, 1,237 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/BiblioPlus 
refs/changes/45/16645/1
--
To view, visit https://gerrit.wikimedia.org/r/16645
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I21df53eb422c9c622c261d7f0203ee2956a973a9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BiblioPlus
Gerrit-Branch: master
Gerrit-Owner: KarenEddy kfe...@msn.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits