[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Update restbase to 85a4dc4

[Mobrovac (Code Review)]

Mobrovac has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/372072 )

Change subject: Update restbase to 85a4dc4
..

Update restbase to 85a4dc4

List of changes:
591e3d9 Remove references to old parsoid tables
834ea61 Removed the 'options.bucket_type' setting
85a4dc4 Commented out the data-mw bucket

Change-Id: Idbe53835644fb7f3fd8643f9c896b9e54f9c09f9
---
M restbase
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/restbase/deploy 
refs/changes/72/372072/1

diff --git a/restbase b/restbase
index 71baac4..85a4dc4 16
--- a/restbase
+++ b/restbase
@@ -1 +1 @@
-Subproject commit 71baac4b17422dfa2f27a03e54a17c8f670ee2b6
+Subproject commit 85a4dc44613fb156a791538d8175af51aa7035c3

-- 
To view, visit https://gerrit.wikimedia.org/r/372072
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Idbe53835644fb7f3fd8643f9c896b9e54f9c09f9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/restbase/deploy
Gerrit-Branch: master
Gerrit-Owner: Mobrovac 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Update restbase to 71baac4

[Mobrovac (Code Review)]

Mobrovac has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371969 )

Change subject: Update restbase to 71baac4
..


Update restbase to 71baac4

List of changes:
71baac4 Parsoid: Bug fix: Get all of the components from the old tables

Change-Id: I63929acee66ec54eca8271c04268cb9e301b9475
---
M restbase
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Mobrovac: Verified; Looks good to me, approved



diff --git a/restbase b/restbase
index 410c04d..71baac4 16
--- a/restbase
+++ b/restbase
@@ -1 +1 @@
-Subproject commit 410c04dfa913fd086f044213f23633641e8769c0
+Subproject commit 71baac4b17422dfa2f27a03e54a17c8f670ee2b6

-- 
To view, visit https://gerrit.wikimedia.org/r/371969
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I63929acee66ec54eca8271c04268cb9e301b9475
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/restbase/deploy
Gerrit-Branch: master
Gerrit-Owner: Mobrovac 
Gerrit-Reviewer: Mobrovac 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Update restbase to 71baac4

[Mobrovac (Code Review)]

Mobrovac has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371969 )

Change subject: Update restbase to 71baac4
..

Update restbase to 71baac4

List of changes:
71baac4 Parsoid: Bug fix: Get all of the components from the old tables

Change-Id: I63929acee66ec54eca8271c04268cb9e301b9475
---
M restbase
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/restbase/deploy 
refs/changes/69/371969/1

diff --git a/restbase b/restbase
index 410c04d..71baac4 16
--- a/restbase
+++ b/restbase
@@ -1 +1 @@
-Subproject commit 410c04dfa913fd086f044213f23633641e8769c0
+Subproject commit 71baac4b17422dfa2f27a03e54a17c8f670ee2b6

-- 
To view, visit https://gerrit.wikimedia.org/r/371969
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I63929acee66ec54eca8271c04268cb9e301b9475
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/restbase/deploy
Gerrit-Branch: master
Gerrit-Owner: Mobrovac 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Update restbase to 410c04d

[Mobrovac (Code Review)]

Mobrovac has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371959 )

Change subject: Update restbase to 410c04d
..


Update restbase to 410c04d

List of changes:
410c04d Assign proper TID when copying over the data to fallback buckets

Change-Id: Ife3291758fd1a55a021ea6857cbf06d0176276dc
---
M restbase
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Mobrovac: Verified; Looks good to me, approved



diff --git a/restbase b/restbase
index 43aad0a..410c04d 16
--- a/restbase
+++ b/restbase
@@ -1 +1 @@
-Subproject commit 43aad0a4cf6c0db9c5f8b83961b2051055176a53
+Subproject commit 410c04dfa913fd086f044213f23633641e8769c0

-- 
To view, visit https://gerrit.wikimedia.org/r/371959
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ife3291758fd1a55a021ea6857cbf06d0176276dc
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/restbase/deploy
Gerrit-Branch: master
Gerrit-Owner: Mobrovac 
Gerrit-Reviewer: Mobrovac 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Update restbase to 410c04d

[Mobrovac (Code Review)]

Mobrovac has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371959 )

Change subject: Update restbase to 410c04d
..

Update restbase to 410c04d

List of changes:
410c04d Assign proper TID when copying over the data to fallback buckets

Change-Id: Ife3291758fd1a55a021ea6857cbf06d0176276dc
---
M restbase
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/restbase/deploy 
refs/changes/59/371959/1

diff --git a/restbase b/restbase
index 43aad0a..410c04d 16
--- a/restbase
+++ b/restbase
@@ -1 +1 @@
-Subproject commit 43aad0a4cf6c0db9c5f8b83961b2051055176a53
+Subproject commit 410c04dfa913fd086f044213f23633641e8769c0

-- 
To view, visit https://gerrit.wikimedia.org/r/371959
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ife3291758fd1a55a021ea6857cbf06d0176276dc
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/restbase/deploy
Gerrit-Branch: master
Gerrit-Owner: Mobrovac 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: home/mobrovac: Add dir for temp vim files

[Mobrovac (Code Review)]

Mobrovac has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371647 )

Change subject: home/mobrovac: Add dir for temp vim files
..

home/mobrovac: Add dir for temp vim files

Change-Id: I525c0f6c09d432a342d55d860baeaf0d211cb40f
---
A modules/admin/files/home/mobrovac/tmp/vim/.gitignore
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/47/371647/1

diff --git a/modules/admin/files/home/mobrovac/tmp/vim/.gitignore 
b/modules/admin/files/home/mobrovac/tmp/vim/.gitignore
new file mode 100644
index 000..72e8ffc
--- /dev/null
+++ b/modules/admin/files/home/mobrovac/tmp/vim/.gitignore
@@ -0,0 +1 @@
+*

-- 
To view, visit https://gerrit.wikimedia.org/r/371647
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I525c0f6c09d432a342d55d860baeaf0d211cb40f
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Mobrovac 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Add /home/ files for mobrovac

[Mobrovac (Code Review)]

Mobrovac has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371644 )

Change subject: Add /home/ files for mobrovac
..

Add /home/ files for mobrovac

Change-Id: Ia236076f2acfd625822c2f20cf38549f4c854c1b
---
A modules/admin/files/home/mobrovac/.bashrc
A modules/admin/files/home/mobrovac/.profile
A modules/admin/files/home/mobrovac/.vim/.netrwhist
A modules/admin/files/home/mobrovac/.vim/.session
A modules/admin/files/home/mobrovac/.vim/Makefile
A modules/admin/files/home/mobrovac/.vim/Makefile.in
A modules/admin/files/home/mobrovac/.vim/after/ftplugin/yaml.vim
A modules/admin/files/home/mobrovac/.vim/after/syntax/yaml.vim
A modules/admin/files/home/mobrovac/.vim/autoload/pathogen.vim
A modules/admin/files/home/mobrovac/.vim/autoload/pythoncomplete.vim
A modules/admin/files/home/mobrovac/.vim/bundle/nerdtree/.gitignore
A modules/admin/files/home/mobrovac/.vim/bundle/nerdtree/README.markdown
A modules/admin/files/home/mobrovac/.vim/bundle/nerdtree/autoload/nerdtree.vim
A 
modules/admin/files/home/mobrovac/.vim/bundle/nerdtree/autoload/nerdtree/ui_glue.vim
A modules/admin/files/home/mobrovac/.vim/bundle/nerdtree/doc/NERD_tree.txt
A 
modules/admin/files/home/mobrovac/.vim/bundle/nerdtree/lib/nerdtree/bookmark.vim
A 
modules/admin/files/home/mobrovac/.vim/bundle/nerdtree/lib/nerdtree/creator.vim
A modules/admin/files/home/mobrovac/.vim/bundle/nerdtree/lib/nerdtree/event.vim
A 
modules/admin/files/home/mobrovac/.vim/bundle/nerdtree/lib/nerdtree/flag_set.vim
A 
modules/admin/files/home/mobrovac/.vim/bundle/nerdtree/lib/nerdtree/key_map.vim
A 
modules/admin/files/home/mobrovac/.vim/bundle/nerdtree/lib/nerdtree/menu_controller.vim
A 
modules/admin/files/home/mobrovac/.vim/bundle/nerdtree/lib/nerdtree/menu_item.vim
A 
modules/admin/files/home/mobrovac/.vim/bundle/nerdtree/lib/nerdtree/nerdtree.vim
A 
modules/admin/files/home/mobrovac/.vim/bundle/nerdtree/lib/nerdtree/notifier.vim
A modules/admin/files/home/mobrovac/.vim/bundle/nerdtree/lib/nerdtree/opener.vim
A modules/admin/files/home/mobrovac/.vim/bundle/nerdtree/lib/nerdtree/path.vim
A 
modules/admin/files/home/mobrovac/.vim/bundle/nerdtree/lib/nerdtree/tree_dir_node.vim
A 
modules/admin/files/home/mobrovac/.vim/bundle/nerdtree/lib/nerdtree/tree_file_node.vim
A modules/admin/files/home/mobrovac/.vim/bundle/nerdtree/lib/nerdtree/ui.vim
A 
modules/admin/files/home/mobrovac/.vim/bundle/nerdtree/nerdtree_plugin/exec_menuitem.vim
A 
modules/admin/files/home/mobrovac/.vim/bundle/nerdtree/nerdtree_plugin/fs_menu.vim
A modules/admin/files/home/mobrovac/.vim/bundle/nerdtree/plugin/NERD_tree.vim
A modules/admin/files/home/mobrovac/.vim/bundle/nerdtree/syntax/nerdtree.vim
A modules/admin/files/home/mobrovac/.vim/bundle/vim-nerdtree-tabs/.gitignore
A modules/admin/files/home/mobrovac/.vim/bundle/vim-nerdtree-tabs/CHANGELOG.md
A modules/admin/files/home/mobrovac/.vim/bundle/vim-nerdtree-tabs/LICENSE
A modules/admin/files/home/mobrovac/.vim/bundle/vim-nerdtree-tabs/README.md
A 
modules/admin/files/home/mobrovac/.vim/bundle/vim-nerdtree-tabs/doc/vim-nerdtree-tabs.txt
A 
modules/admin/files/home/mobrovac/.vim/bundle/vim-nerdtree-tabs/nerdtree_plugin/vim-nerdtree-tabs.vim
A modules/admin/files/home/mobrovac/.vim/colors/github.vim
A modules/admin/files/home/mobrovac/.vim/colors/tango.vim
A modules/admin/files/home/mobrovac/.vim/compiler/tex.vim
A modules/admin/files/home/mobrovac/.vim/doc/Makefile
A modules/admin/files/home/mobrovac/.vim/doc/Makefile.in
A modules/admin/files/home/mobrovac/.vim/doc/README
A modules/admin/files/home/mobrovac/.vim/doc/README.new
A modules/admin/files/home/mobrovac/.vim/doc/catalog.xml
A modules/admin/files/home/mobrovac/.vim/doc/imaps.txt
A modules/admin/files/home/mobrovac/.vim/doc/project.txt
A modules/admin/files/home/mobrovac/.vim/doc/taglist.txt
A modules/admin/files/home/mobrovac/.vim/doc/tags
A modules/admin/files/home/mobrovac/.vim/doc/vtreeexplorer.txt
A modules/admin/files/home/mobrovac/.vim/ftplugin/python_editing.vim
A modules/admin/files/home/mobrovac/.vim/indent/tex.vim
A modules/admin/files/home/mobrovac/.vim/plugin/SyntaxFolds.vim
A modules/admin/files/home/mobrovac/.vim/plugin/filebrowser.vim
A modules/admin/files/home/mobrovac/.vim/plugin/imaps.vim
A modules/admin/files/home/mobrovac/.vim/plugin/libList.vim
A modules/admin/files/home/mobrovac/.vim/plugin/project.vim
A modules/admin/files/home/mobrovac/.vim/plugin/remoteOpen.vim
A modules/admin/files/home/mobrovac/.vim/plugin/taglist.vim
A modules/admin/files/home/mobrovac/.vim/plugin/vtreeexplorer.vim
A modules/admin/files/home/mobrovac/.vim/spell/en.latin1.add
A modules/admin/files/home/mobrovac/.vim/spell/en.latin1.add.spl
A modules/admin/files/home/mobrovac/.vim/spell/en.utf-8.add
A modules/admin/files/home/mobrovac/.vim/spell/en.utf-8.add.spl
A modules/admin/files/home/mobrovac/.vim/syntax/puppet.vim
A modules/admin/files/home/mobrovac/.vim/syntax/python.vim
A 

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Cassandra metrics: Allow Scap3 to restart the service

[Mobrovac (Code Review)]

Mobrovac has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371159 )

Change subject: Cassandra metrics: Allow Scap3 to restart the service
..

Cassandra metrics: Allow Scap3 to restart the service

Bug: T137371
Change-Id: Ie6979529dc7def544cfcce32f6df27bdb9695c3e
---
M modules/cassandra/manifests/metrics.pp
1 file changed, 3 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/59/371159/1

diff --git a/modules/cassandra/manifests/metrics.pp 
b/modules/cassandra/manifests/metrics.pp
index dc9f7a4..3cb09f3 100644
--- a/modules/cassandra/manifests/metrics.pp
+++ b/modules/cassandra/manifests/metrics.pp
@@ -58,8 +58,9 @@
 }
 
 scap::target { 'cassandra/metrics-collector':
-deploy_user => 'deploy-service',
-manage_user => true,
+deploy_user  => 'deploy-service',
+manage_user  => true,
+service_name => 'cassandra-metrics-collector',
 }
 
 file { '/etc/cassandra-metrics-collector':

-- 
To view, visit https://gerrit.wikimedia.org/r/371159
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie6979529dc7def544cfcce32f6df27bdb9695c3e
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Mobrovac 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations...cassandra-metrics-collector[master]: Scap config: restart the service after a deploy

[Mobrovac (Code Review)]

Mobrovac has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/371127 )

Change subject: Scap config: restart the service after a deploy
..


Scap config: restart the service after a deploy

Bug: T137371
Change-Id: Ia23f5a41c086a11f9b350100bc45090a2023cd8c
---
A .gitreview
M scap/scap.cfg
2 files changed, 7 insertions(+), 0 deletions(-)

Approvals:
  Mobrovac: Verified; Looks good to me, approved



diff --git a/.gitreview b/.gitreview
new file mode 100644
index 000..32fc793
--- /dev/null
+++ b/.gitreview
@@ -0,0 +1,5 @@
+[gerrit]
+host=gerrit.wikimedia.org
+port=29418
+project=operations/software/cassandra-metrics-collector.git
+defaultbranch=master
diff --git a/scap/scap.cfg b/scap/scap.cfg
index ecc2299..05663a4 100644
--- a/scap/scap.cfg
+++ b/scap/scap.cfg
@@ -19,6 +19,8 @@
 canary_group_size: 1
 # we do not permit the canaries to fail
 canary_failure_limit: 0
+# the service name to restart
+service_name: cassandra-metrics-collector
 
 [deployment-prep.eqiad.wmflabs]
 environment: beta

-- 
To view, visit https://gerrit.wikimedia.org/r/371127
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia23f5a41c086a11f9b350100bc45090a2023cd8c
Gerrit-PatchSet: 1
Gerrit-Project: operations/software/cassandra-metrics-collector
Gerrit-Branch: master
Gerrit-Owner: Mobrovac 
Gerrit-Reviewer: Filippo Giunchedi 
Gerrit-Reviewer: Mobrovac 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations...cassandra-metrics-collector[master]: Scap config: restart the service after a deploy

[Mobrovac (Code Review)]

Mobrovac has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/371127 )

Change subject: Scap config: restart the service after a deploy
..

Scap config: restart the service after a deploy

Bug: T137371
Change-Id: Ia23f5a41c086a11f9b350100bc45090a2023cd8c
---
A .gitreview
M scap/scap.cfg
2 files changed, 7 insertions(+), 0 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/operations/software/cassandra-metrics-collector
 refs/changes/27/371127/1

diff --git a/.gitreview b/.gitreview
new file mode 100644
index 000..32fc793
--- /dev/null
+++ b/.gitreview
@@ -0,0 +1,5 @@
+[gerrit]
+host=gerrit.wikimedia.org
+port=29418
+project=operations/software/cassandra-metrics-collector.git
+defaultbranch=master
diff --git a/scap/scap.cfg b/scap/scap.cfg
index ecc2299..05663a4 100644
--- a/scap/scap.cfg
+++ b/scap/scap.cfg
@@ -19,6 +19,8 @@
 canary_group_size: 1
 # we do not permit the canaries to fail
 canary_failure_limit: 0
+# the service name to restart
+service_name: cassandra-metrics-collector
 
 [deployment-prep.eqiad.wmflabs]
 environment: beta

-- 
To view, visit https://gerrit.wikimedia.org/r/371127
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia23f5a41c086a11f9b350100bc45090a2023cd8c
Gerrit-PatchSet: 1
Gerrit-Project: operations/software/cassandra-metrics-collector
Gerrit-Branch: master
Gerrit-Owner: Mobrovac 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] labs/private[master]: Add certificates for restbase101[678]

[Mobrovac (Code Review)]

Mobrovac has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/370859 )

Change subject: Add certificates for restbase101[678]
..

Add certificates for restbase101[678]

Change-Id: I1281ef2aaca507137b81b6fa5624cf341f8140cf
---
M modules/secret/secrets/cassandra/services.yaml
A modules/secret/secrets/cassandra/services/restbase1016-a/restbase1016-a.crt
A modules/secret/secrets/cassandra/services/restbase1016-a/restbase1016-a.csr
A modules/secret/secrets/cassandra/services/restbase1016-a/restbase1016-a.kst
A modules/secret/secrets/cassandra/services/restbase1016-b/restbase1016-b.crt
A modules/secret/secrets/cassandra/services/restbase1016-b/restbase1016-b.csr
A modules/secret/secrets/cassandra/services/restbase1016-b/restbase1016-b.kst
A modules/secret/secrets/cassandra/services/restbase1016-c/restbase1016-c.crt
A modules/secret/secrets/cassandra/services/restbase1016-c/restbase1016-c.csr
A modules/secret/secrets/cassandra/services/restbase1016-c/restbase1016-c.kst
A modules/secret/secrets/cassandra/services/restbase1016/restbase1016.crt
A modules/secret/secrets/cassandra/services/restbase1016/restbase1016.csr
A modules/secret/secrets/cassandra/services/restbase1016/restbase1016.kst
A modules/secret/secrets/cassandra/services/restbase1017-a/restbase1017-a.crt
A modules/secret/secrets/cassandra/services/restbase1017-a/restbase1017-a.csr
A modules/secret/secrets/cassandra/services/restbase1017-a/restbase1017-a.kst
A modules/secret/secrets/cassandra/services/restbase1017-b/restbase1017-b.crt
A modules/secret/secrets/cassandra/services/restbase1017-b/restbase1017-b.csr
A modules/secret/secrets/cassandra/services/restbase1017-b/restbase1017-b.kst
A modules/secret/secrets/cassandra/services/restbase1017-c/restbase1017-c.crt
A modules/secret/secrets/cassandra/services/restbase1017-c/restbase1017-c.csr
A modules/secret/secrets/cassandra/services/restbase1017-c/restbase1017-c.kst
A modules/secret/secrets/cassandra/services/restbase1017/restbase1017.crt
A modules/secret/secrets/cassandra/services/restbase1017/restbase1017.csr
A modules/secret/secrets/cassandra/services/restbase1017/restbase1017.kst
A modules/secret/secrets/cassandra/services/restbase1018-a/restbase1018-a.crt
A modules/secret/secrets/cassandra/services/restbase1018-a/restbase1018-a.csr
A modules/secret/secrets/cassandra/services/restbase1018-a/restbase1018-a.kst
A modules/secret/secrets/cassandra/services/restbase1018-b/restbase1018-b.crt
A modules/secret/secrets/cassandra/services/restbase1018-b/restbase1018-b.csr
A modules/secret/secrets/cassandra/services/restbase1018-b/restbase1018-b.kst
A modules/secret/secrets/cassandra/services/restbase1018-c/restbase1018-c.crt
A modules/secret/secrets/cassandra/services/restbase1018-c/restbase1018-c.csr
A modules/secret/secrets/cassandra/services/restbase1018-c/restbase1018-c.kst
A modules/secret/secrets/cassandra/services/restbase1018/restbase1018.crt
A modules/secret/secrets/cassandra/services/restbase1018/restbase1018.csr
A modules/secret/secrets/cassandra/services/restbase1018/restbase1018.kst
37 files changed, 492 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/labs/private 
refs/changes/59/370859/1

diff --git a/modules/secret/secrets/cassandra/services.yaml 
b/modules/secret/secrets/cassandra/services.yaml
index 6ef60c8..4b133d1 100644
--- a/modules/secret/secrets/cassandra/services.yaml
+++ b/modules/secret/secrets/cassandra/services.yaml
@@ -158,6 +158,66 @@
   <<: *ca_cert
 password: placeholder
 
+  - name: restbase1016
+cert:
+  <<: *ca_cert
+password: placeholder
+
+  - name: restbase1016-a
+cert:
+  <<: *ca_cert
+password: placeholder
+
+  - name: restbase1016-b
+cert:
+  <<: *ca_cert
+password: placeholder
+
+  - name: restbase1016-c
+cert:
+  <<: *ca_cert
+password: placeholder
+
+  - name: restbase1017
+cert:
+  <<: *ca_cert
+password: placeholder
+
+  - name: restbase1017-a
+cert:
+  <<: *ca_cert
+password: placeholder
+
+  - name: restbase1017-b
+cert:
+  <<: *ca_cert
+password: placeholder
+
+  - name: restbase1017-c
+cert:
+  <<: *ca_cert
+password: placeholder
+
+  - name: restbase1018
+cert:
+  <<: *ca_cert
+password: placeholder
+
+  - name: restbase1018-a
+cert:
+  <<: *ca_cert
+password: placeholder
+
+  - name: restbase1018-b
+cert:
+  <<: *ca_cert
+password: placeholder
+
+  - name: restbase1018-c
+cert:
+  <<: *ca_cert
+password: placeholder
+
   - name: restbase2001
 cert: 
   <<: *ca_cert
diff --git 
a/modules/secret/secrets/cassandra/services/restbase1016-a/restbase1016-a.crt 
b/modules/secret/secrets/cassandra/services/restbase1016-a/restbase1016-a.crt
new file mode 100644
index 000..65d4b31
--- /dev/null
+++ 
b/modules/secret/secrets/cassandra/services/restbase1016-a/restbase1016-a.crt
@@ -0,0 +1,19 @@

[MediaWiki-commits] [Gerrit] operations/puppet[production]: [UGLY-FIX] EventStreams: Double-quote `false` to avoid `False`

[Mobrovac (Code Review)]

Mobrovac has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/370842 )

Change subject: [UGLY-FIX] EventStreams: Double-quote `false` to avoid `False`
..

[UGLY-FIX] EventStreams: Double-quote `false` to avoid `False`

Scap uses Jinja2 directly, which converts values in a Pythonic way. That
causes corner cases such as `None` and `False` to appear in the config,
which are treated as strings in YAML (and hence Node.JS). This is a
work-around for EventStreams' rdkafka config option.

Bug: T172681
Change-Id: Iae96ececeb32c09853169e8e3426bb9ce31fe97c
---
M hieradata/role/common/scb.yaml
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/42/370842/1

diff --git a/hieradata/role/common/scb.yaml b/hieradata/role/common/scb.yaml
index cad864c..ccf580d 100644
--- a/hieradata/role/common/scb.yaml
+++ b/hieradata/role/common/scb.yaml
@@ -85,7 +85,7 @@
   # Specify Kafka API version as workaround for Brokers < 0.10
   # https://github.com/edenhill/librdkafka/wiki/Broker-version-compatibility
   # This will not be necessary when the target Kafka cluster will be running 
0.10
-  api.version.request: 'false'
+  api.version.request: '"false"'
   broker.version.fallback: '0.9.0.1'
 
 changeprop::restbase_uri: http://restbase-async.discovery.wmnet:7231

-- 
To view, visit https://gerrit.wikimedia.org/r/370842
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iae96ececeb32c09853169e8e3426bb9ce31fe97c
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Mobrovac 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Update restbase to 43aad0a

[Mobrovac (Code Review)]

Mobrovac has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/370758 )

Change subject: Update restbase to 43aad0a
..


Update restbase to 43aad0a

List of changes:
43aad0a Temporary fallback to the new storage buckets in order to truncate the 
tables

Change-Id: Ic4f887d237e093dbd143e83f10320d39427f6b24
---
M restbase
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Mobrovac: Verified; Looks good to me, approved



diff --git a/restbase b/restbase
index 26f4515..43aad0a 16
--- a/restbase
+++ b/restbase
@@ -1 +1 @@
-Subproject commit 26f4515c2661459cd37fd41f8861865b4b0de965
+Subproject commit 43aad0a4cf6c0db9c5f8b83961b2051055176a53

-- 
To view, visit https://gerrit.wikimedia.org/r/370758
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic4f887d237e093dbd143e83f10320d39427f6b24
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/restbase/deploy
Gerrit-Branch: master
Gerrit-Owner: Mobrovac 
Gerrit-Reviewer: Mobrovac 
Gerrit-Reviewer: Ppchelko 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Update restbase to 43aad0a

[Mobrovac (Code Review)]

Mobrovac has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/370758 )

Change subject: Update restbase to 43aad0a
..

Update restbase to 43aad0a

List of changes:
43aad0a Temporary fallback to the new storage buckets in order to truncate the 
tables

Change-Id: Ic4f887d237e093dbd143e83f10320d39427f6b24
---
M restbase
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/restbase/deploy 
refs/changes/58/370758/1

diff --git a/restbase b/restbase
index 26f4515..43aad0a 16
--- a/restbase
+++ b/restbase
@@ -1 +1 @@
-Subproject commit 26f4515c2661459cd37fd41f8861865b4b0de965
+Subproject commit 43aad0a4cf6c0db9c5f8b83961b2051055176a53

-- 
To view, visit https://gerrit.wikimedia.org/r/370758
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic4f887d237e093dbd143e83f10320d39427f6b24
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/restbase/deploy
Gerrit-Branch: master
Gerrit-Owner: Mobrovac 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Cassandra: Do not include the main DNS in the list of seeds

[Mobrovac (Code Review)]

Mobrovac has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/370554 )

Change subject: Cassandra: Do not include the main DNS in the list of seeds
..

Cassandra: Do not include the main DNS in the list of seeds

Bug: T172610
Change-Id: I49313adaf5fb6c1028df21a2c18ca4385df734f5
---
M modules/cassandra/templates/cassandra.yaml-3.x.erb
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/54/370554/1

diff --git a/modules/cassandra/templates/cassandra.yaml-3.x.erb 
b/modules/cassandra/templates/cassandra.yaml-3.x.erb
index 5462ba6..7aa0ffc 100644
--- a/modules/cassandra/templates/cassandra.yaml-3.x.erb
+++ b/modules/cassandra/templates/cassandra.yaml-3.x.erb
@@ -401,7 +401,8 @@
   x != @hostname \
   && ! (x.start_with? 
"#{@hostname}-") \
   && x != @ipaddress \
-  && x != @fqdn
+  && x != @fqdn \
+  && /^.+-.\.\w+\.\w+$/ =~ 
x
   }.join(',') : 
@seeds.join(',') %>
  - seeds: <%= clean_seeds %>
 # For workloads with more data than can fit in memory, Cassandra's

-- 
To view, visit https://gerrit.wikimedia.org/r/370554
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I49313adaf5fb6c1028df21a2c18ca4385df734f5
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Mobrovac 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: [WIP] JobQueue: Add the RunSingleJob.php script

[Mobrovac (Code Review)]

Mobrovac has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/370004 )

Change subject: [WIP] JobQueue: Add the RunSingleJob.php script
..

[WIP] JobQueue: Add the RunSingleJob.php script

Depends-On: Ib1aaa58a730b20ee266a530150d684ae9782e6d2
Change-Id: I5d85a505b5fed83f3b357f4c446e6abbd118e174
---
A rpc/RunSingleJob.php
1 file changed, 90 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/04/370004/1

diff --git a/rpc/RunSingleJob.php b/rpc/RunSingleJob.php
new file mode 100755
index 000..ed3ccff
--- /dev/null
+++ b/rpc/RunSingleJob.php
@@ -0,0 +1,90 @@
+http://www.gnu.org/copyleft/gpl.html
+ *
+ * @file
+ * @author Aaron Schulz
+ * @author Marko Obrovac
+ */
+if ( $_SERVER['REQUEST_METHOD'] !== 'POST' ) {
+   die( "Request must use POST.\n" );
+}
+
+// get the info contained in the body
+$event = null;
+try {
+   // we do not need to use FormatJson::decode because it only wraps
+   // json_decode() and we haven't loaded any MW components at this
+   // point yet
+   $event = json_decode( file_get_contents( "php://input" ), true );
+} catch ( Exception $e ) {
+   // TODO: do this better
+   die( $e );
+}
+
+// check that we have the needed components of the event
+if ( !isset( $event['database'] )
+   || !isset( $event['type'] )
+   || !isset( $event['page_title'] )
+   || !isset( $event['params'] ) 
+) {
+   // TODO: do this better
+   die( 'Invalid event received!' );
+}
+
+
+define( 'MEDIAWIKI_JOB_RUNNER', 1 );
+
+require_once __DIR__ . '/../multiversion/MWMultiVersion.php';
+require MWMultiVersion::getMediaWiki( 'includes/WebStart.php', 
$event['database'] );
+
+error_reporting( E_ERROR ); // fatals but not random I/O warnings
+ini_set( 'display_errors', 1 );
+$wgShowExceptionDetails = true;
+
+// Session consistency is not helpful here and will slow things down in some 
cases
+wfGetLBFactory()->disableChronologyProtection();
+
+try {
+   $mediawiki = new MediaWiki();
+   $executor = new JobExecutor();
+   // check if there are any base64-encoded parameters and if so decode 
them
+   foreach ( $event['params'] as &$value ) {
+   if ( !is_string( $value ) ) {
+   continue;
+   }
+   if ( preg_match( 
'/^data:application/octet-stream;base64,([\s\S]+)$/', $value, $match ) ) {
+   $value = base64_decode( $match[1], true );
+   if ( $value === false ) {
+   throw new Exception( 'base64_decode() failed' );
+   }
+   }
+   }
+   unset( $value );
+   // execute the job
+   $response = $executor->execute( $event );
+   if ( $response['status'] === true ) {
+   http_response_code( 200 );
+   } else {
+   http_response_code( 500 );
+   }
+   $mediawiki->restInPeace();
+} catch ( Exception $e ) {
+   # Since output is logged to file, get MediaWiki to generate a raw error
+   $wgCommandLineMode = true;
+
+   MWExceptionHandler::handleException( $e );
+}

-- 
To view, visit https://gerrit.wikimedia.org/r/370004
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5d85a505b5fed83f3b357f4c446e6abbd118e174
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Mobrovac 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Config: Add the Recommendation API service's URI

[Mobrovac (Code Review)]

Mobrovac has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/369568 )

Change subject: Config: Add the Recommendation API service's URI
..


Config: Add the Recommendation API service's URI

Bug: T170877
Depends-On: If3941b4326e51dcd8740d1fa3eef29d16728da2c
Change-Id: I2dc1224633504c2d0e7adc93c6e672803af87cee
---
M scap/templates/config.yaml.j2
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Mobrovac: Verified; Looks good to me, approved



diff --git a/scap/templates/config.yaml.j2 b/scap/templates/config.yaml.j2
index 9012345..8e54af7 100644
--- a/scap/templates/config.yaml.j2
+++ b/scap/templates/config.yaml.j2
@@ -89,6 +89,8 @@
   host: <%= mobileapps_uri %>
 citoid:
   host: <%= citoid_uri %>
+recommendation:
+  host: <%= recommendation_uri %>
 events:
   uri: <%= eventlogging_service_uri %>
   topic: resource_change

-- 
To view, visit https://gerrit.wikimedia.org/r/369568
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2dc1224633504c2d0e7adc93c6e672803af87cee
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/services/restbase/deploy
Gerrit-Branch: master
Gerrit-Owner: Mobrovac 
Gerrit-Reviewer: Mobrovac 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Add hiwikiversity to restbase

[Mobrovac (Code Review)]

Mobrovac has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/369919 )

Change subject: Add hiwikiversity to restbase
..


Add hiwikiversity to restbase

Bug: T168765

Change-Id: I4f91a9f55fc46cc6e56a3daa20c917b4ba372231
---
M scap/vars.yaml
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Mobrovac: Verified; Looks good to me, approved



diff --git a/scap/vars.yaml b/scap/vars.yaml
index a144e56..9379c8e 100644
--- a/scap/vars.yaml
+++ b/scap/vars.yaml
@@ -745,6 +745,7 @@
 es.wikiversity.org: default_project
 fi.wikiversity.org: default_project
 fr.wikiversity.org: default_project
+hi.wikiversity.org: default_project
 it.wikiversity.org: default_project
 ja.wikiversity.org: default_project
 ko.wikiversity.org: default_project

-- 
To view, visit https://gerrit.wikimedia.org/r/369919
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4f91a9f55fc46cc6e56a3daa20c917b4ba372231
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/services/restbase/deploy
Gerrit-Branch: master
Gerrit-Owner: Reedy 
Gerrit-Reviewer: Mobrovac 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Update recommendation-api to 8ea8fa7

[Mobrovac (Code Review)]

Mobrovac has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/369698 )

Change subject: Update recommendation-api to 8ea8fa7
..


Update recommendation-api to 8ea8fa7

List of changes:
8ea8fa7 Return list of 'items' and make domain dynamic

Change-Id: Ic77dda59427c119eb6c2f7814767c4da7c5e33a1
---
M src
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Mobrovac: Verified; Looks good to me, approved



diff --git a/src b/src
index c11ff94..8ea8fa7 16
--- a/src
+++ b/src
@@ -1 +1 @@
-Subproject commit c11ff94b38024fdaac573d82f6124743cfcfcc6d
+Subproject commit 8ea8fa7d23481d3bb0f302e2fb19e694dcbaaa03

-- 
To view, visit https://gerrit.wikimedia.org/r/369698
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic77dda59427c119eb6c2f7814767c4da7c5e33a1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/recommendation-api/deploy
Gerrit-Branch: master
Gerrit-Owner: Mobrovac 
Gerrit-Reviewer: Mobrovac 
Gerrit-Reviewer: Nschaaf 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Update recommendation-api to 8ea8fa7

[Mobrovac (Code Review)]

Mobrovac has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/369698 )

Change subject: Update recommendation-api to 8ea8fa7
..

Update recommendation-api to 8ea8fa7

List of changes:
8ea8fa7 Return list of 'items' and make domain dynamic

Change-Id: Ic77dda59427c119eb6c2f7814767c4da7c5e33a1
---
M src
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/services/recommendation-api/deploy 
refs/changes/98/369698/1

diff --git a/src b/src
index c11ff94..8ea8fa7 16
--- a/src
+++ b/src
@@ -1 +1 @@
-Subproject commit c11ff94b38024fdaac573d82f6124743cfcfcc6d
+Subproject commit 8ea8fa7d23481d3bb0f302e2fb19e694dcbaaa03

-- 
To view, visit https://gerrit.wikimedia.org/r/369698
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic77dda59427c119eb6c2f7814767c4da7c5e33a1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/recommendation-api/deploy
Gerrit-Branch: master
Gerrit-Owner: Mobrovac 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...recommendation-api[master]: Return list of 'items' and make domain dynamic

[Mobrovac (Code Review)]

Mobrovac has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/369684 )

Change subject: Return list of 'items' and make domain dynamic
..


Return list of 'items' and make domain dynamic

Bug: T170877
Change-Id: I15874c8fe249521fb8dd2001e016e97112a757a2
---
M lib/translation.js
M routes/translation.js
2 files changed, 26 insertions(+), 17 deletions(-)

Approvals:
  Mobrovac: Verified; Looks good to me, approved



diff --git a/lib/translation.js b/lib/translation.js
index 87abf2c..2b53e9b 100644
--- a/lib/translation.js
+++ b/lib/translation.js
@@ -14,7 +14,7 @@
 // Set up the search by seed request
 if (!app.conf.queries.seed) {
 app.conf.queries.seed = {
-domain: '{{params.source}}.wikipedia.org',
+domain: '{{params.source}}.{{params.projectDomain}}',
 parameters: {
 format: 'json',
 action: 'query',
@@ -32,7 +32,7 @@
 // Set up the search by pageviews request
 if (!app.conf.queries.pageviews) {
 app.conf.queries.pageviews = {
-domain: '{{params.source}}.wikipedia.org',
+domain: '{{params.source}}.{{params.projectDomain}}',
 parameters: {
 format: 'json',
 action: 'query',
@@ -48,7 +48,7 @@
 // Set up the find article by seed request
 if (!app.conf.queries.article) {
 app.conf.queries.article = {
-domain: '{{params.source}}.wikipedia.org',
+domain: '{{params.source}}.{{params.projectDomain}}',
 parameters: {
 format: 'json',
 action: 'query',
@@ -140,13 +140,15 @@
  * Gets articles most closely related to seed
  * @param {Object} app the application object
  * @param {string} source the source language code
+ * @param {string} projectDomain the project domain
  * @param {string} seed the seed to search by
  * @return {Promise.}
  */
-function getArticlesBySeed(app, source, seed) {
+function getArticlesBySeed(app, source, projectDomain, seed) {
 const articleQuery = app.conf.queries.article_tpl.expand({
 params: {
 source,
+projectDomain,
 seed
 }
 });
@@ -159,6 +161,7 @@
 const seedQuery = app.conf.queries.seed_tpl.expand({
 params: {
 source,
+projectDomain,
 seed: seedTitle
 },
 });
@@ -176,12 +179,14 @@
  * Gets the most popular articles in source wikipedia
  * @param {Object} app the application object
  * @param {string} source the source language code
+ * @param {string} projectDomain the project domain
  * @return {Promise.}
  */
-function getArticlesByPageviews(app, source) {
+function getArticlesByPageviews(app, source, projectDomain) {
 const pageviewsQuery = app.conf.queries.pageviews_tpl.expand({
 params: {
-source
+source,
+projectDomain
 }
 });
 return getArticles(app, pageviewsQuery.domain, pageviewsQuery.parameters);
@@ -193,10 +198,11 @@
  * @param {Object} app the application object
  * @param {string} source the source language code
  * @param {string} target the target language code
+ * @param {string} projectDomain the project domain
  * @param {Object} candidates object with wikidata ids as keys and article 
titles as values
  * @return {Promise.}
  */
-function filter(app, source, target, candidates) {
+function filter(app, source, target, projectDomain, candidates) {
 const items = Object.keys(candidates).map((item) => {
 return `wd:${item}`;
 }).join(' ');
@@ -207,7 +213,7 @@
  OPTIONAL { ?sitelink schema:about ?item }
  FILTER NOT EXISTS {
?article schema:about ?item .
-   ?article schema:isPartOf 
 .
+   ?article schema:isPartOf 
 .
  }
} GROUP BY ?item`;
 
@@ -230,19 +236,20 @@
  * @param {Object} app the application object
  * @param {string} source the source language code
  * @param {string} target the target language code
+ * @param {string} projectDomain the project domain
  * @param {string} [seed=null] the seed to search by, if any
  * @return {Promise.}
  */
-function recommend(app, source, target, seed) {
+function recommend(app, source, target, projectDomain, seed) {
 let candidates;
 if (seed) {
-candidates = getArticlesBySeed(app, source, seed);
+candidates = getArticlesBySeed(app, source, projectDomain, seed);
 } else {
-candidates = getArticlesByPageviews(app, source);
+candidates = getArticlesByPageviews(app, source, projectDomain);
 }
 return candidates
 .then((candidates) => {
-return filter(app, 

[MediaWiki-commits] [Gerrit] mediawiki...recommendation-api[master]: Add source parameter validation

[Mobrovac (Code Review)]

Mobrovac has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/366222 )

Change subject: Add source parameter validation
..


Add source parameter validation

Bug: T169656
Change-Id: I07f7de1edc711a8aebb5bbaf1c732691b67b2662
---
M routes/translation.js
M spec.yaml
2 files changed, 22 insertions(+), 12 deletions(-)

Approvals:
  Mobrovac: Verified; Looks good to me, approved



diff --git a/routes/translation.js b/routes/translation.js
index 191bed9..713505e 100644
--- a/routes/translation.js
+++ b/routes/translation.js
@@ -15,8 +15,22 @@
  */
 let app;
 
+/**
+ * Regular expression used for validating the source parameter
+ * @type {RegExp}
+ */
+const sourceValidator = /^[a-zA-Z]+(-[a-zA-Z]+)*$/;
 
 function recommend(req, res, source, target, seed) {
+if (!sourceValidator.test(source)) {
+throw new sUtil.HTTPError({
+status: 400,
+type: 'bad_request',
+title: 'Bad request',
+detail: 'source parameter was invalid'
+});
+}
+
 let count = 24;
 if (req.query && req.query.count) {
 count = parseInt(req.query.count, 10);
@@ -40,22 +54,11 @@
 });
 }
 
-
-/**
- * GET /articles/{source}
- * Gets the articles existing in source but missing in domain.
- */
-router.get('/articles/:source', (req, res) => {
-const target = req.params.domain.split('.')[0];
-return recommend(req, res, req.params.source, target);
-});
-
-
 /**
  * GET /articles/{source}/{seed}
  * Gets the articles existing in source but missing in domain based on seed.
  */
-router.get('/articles/:source/:seed', (req, res) => {
+router.get('/articles/:source/:seed?', (req, res) => {
 const target = req.params.domain.split('.')[0];
 return recommend(req, res, req.params.source, target, req.params.seed);
 });
diff --git a/spec.yaml b/spec.yaml
index dfa7c22..aa4b31c 100644
--- a/spec.yaml
+++ b/spec.yaml
@@ -136,3 +136,10 @@
   count: -123
   response:
 status: 400
+- title: incorrectly formatted source
+  request:
+params:
+  source: en-
+  domain: de.wikipedia.org
+  response:
+status: 400

-- 
To view, visit https://gerrit.wikimedia.org/r/366222
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I07f7de1edc711a8aebb5bbaf1c732691b67b2662
Gerrit-PatchSet: 5
Gerrit-Project: mediawiki/services/recommendation-api
Gerrit-Branch: master
Gerrit-Owner: Nschaaf 
Gerrit-Reviewer: Brian Wolff 
Gerrit-Reviewer: Mobrovac 
Gerrit-Reviewer: Nschaaf 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Config: Add the Recommendation API service's URI

[Mobrovac (Code Review)]

Mobrovac has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/369568 )

Change subject: Config: Add the Recommendation API service's URI
..

Config: Add the Recommendation API service's URI

Bug: T170877
Depends-On: If3941b4326e51dcd8740d1fa3eef29d16728da2c
Change-Id: I2dc1224633504c2d0e7adc93c6e672803af87cee
---
M scap/templates/config.yaml.j2
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/restbase/deploy 
refs/changes/68/369568/1

diff --git a/scap/templates/config.yaml.j2 b/scap/templates/config.yaml.j2
index 9012345..8e54af7 100644
--- a/scap/templates/config.yaml.j2
+++ b/scap/templates/config.yaml.j2
@@ -89,6 +89,8 @@
   host: <%= mobileapps_uri %>
 citoid:
   host: <%= citoid_uri %>
+recommendation:
+  host: <%= recommendation_uri %>
 events:
   uri: <%= eventlogging_service_uri %>
   topic: resource_change

-- 
To view, visit https://gerrit.wikimedia.org/r/369568
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2dc1224633504c2d0e7adc93c6e672803af87cee
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/restbase/deploy
Gerrit-Branch: master
Gerrit-Owner: Mobrovac 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: RESTBase: Add the Recommendation API URI

[Mobrovac (Code Review)]

Mobrovac has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/369446 )

Change subject: RESTBase: Add the Recommendation API URI
..

RESTBase: Add the Recommendation API URI

Bug: T170877
Change-Id: If3941b4326e51dcd8740d1fa3eef29d16728da2c
---
M hieradata/labs/deployment-prep/common.yaml
M hieradata/role/common/restbase/dev_cluster.yaml
M hieradata/role/common/restbase/production.yaml
M hieradata/role/common/restbase/test_cluster.yaml
M modules/profile/manifests/restbase.pp
5 files changed, 10 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/46/369446/1

diff --git a/hieradata/labs/deployment-prep/common.yaml 
b/hieradata/labs/deployment-prep/common.yaml
index 71be5b1..9100395 100644
--- a/hieradata/labs/deployment-prep/common.yaml
+++ b/hieradata/labs/deployment-prep/common.yaml
@@ -113,6 +113,7 @@
 profile::restbase::citoid_uri: 
http://deployment-sca02.deployment-prep.eqiad.wmflabs:1970
 profile::restbase::trendingedits_uri: 
http://deployment-trending01.deployment-prep.eqiad.wmflabs:6699
 profile::restbase::cxserver_uri: 
http://deployment-sca02.deployment-prep.eqiad.wmflabs:8080
+profile::restbase::recommendation_uri: 
http://deployment-sca01.deployment-prep.eqiad.wmflabs:9632
 
 profile::restbase::cassandra_user: cassandra
 profile::restbase::cassandra_password: cassandra
diff --git a/hieradata/role/common/restbase/dev_cluster.yaml 
b/hieradata/role/common/restbase/dev_cluster.yaml
index b47652c..d1a5ee9 100644
--- a/hieradata/role/common/restbase/dev_cluster.yaml
+++ b/hieradata/role/common/restbase/dev_cluster.yaml
@@ -19,6 +19,7 @@
 profile::restbase::trendingedits_uri: 
"http://trendingedits.svc.%{::site}.wmnet:6699;
 profile::restbase::eventlogging_service_uri: 
"http://eventbus.discovery.wmnet:8085/v1/events;
 profile::restbase::cxserver_uri: "http://cxserver.discovery.wmnet:8080;
+profile::restbase::recommendation_uri: 
"http://recommendation-api.discovery.wmnet:9632;
 profile::restbase::cassandra_user: restb
 profile::restbase::cassandra_password: "%{passwords::cassandra::restbase}"
 profile::restbase::monitor_domain: en.wikipedia.org
diff --git a/hieradata/role/common/restbase/production.yaml 
b/hieradata/role/common/restbase/production.yaml
index 9bc84bb..82f3b2b 100644
--- a/hieradata/role/common/restbase/production.yaml
+++ b/hieradata/role/common/restbase/production.yaml
@@ -17,6 +17,7 @@
 profile::restbase::trendingedits_uri: 
"http://trendingedits.svc.%{::site}.wmnet:6699;
 profile::restbase::eventlogging_service_uri: 
"http://eventbus.discovery.wmnet:8085/v1/events;
 profile::restbase::cxserver_uri: "http://cxserver.discovery.wmnet:8080;
+profile::restbase::recommendation_uri: 
"http://recommendation-api.discovery.wmnet:9632;
 profile::restbase::cassandra_user: restb
 profile::restbase::cassandra_password: "%{passwords::cassandra::restbase}"
 profile::restbase::monitor_domain: en.wikipedia.org
diff --git a/hieradata/role/common/restbase/test_cluster.yaml 
b/hieradata/role/common/restbase/test_cluster.yaml
index f533e28..3a233be 100644
--- a/hieradata/role/common/restbase/test_cluster.yaml
+++ b/hieradata/role/common/restbase/test_cluster.yaml
@@ -17,6 +17,7 @@
 profile::restbase::trendingedits_uri: 
"http://trendingedits.svc.%{::site}.wmnet:6699;
 profile::restbase::eventlogging_service_uri: 
"http://eventbus.discovery.wmnet:8085/v1/events;
 profile::restbase::cxserver_uri: "http://cxserver.discovery.wmnet:8080;
+profile::restbase::recommendation_uri: 
"http://recommendation-api.discovery.wmnet:9632;
 profile::restbase::cassandra_user: restb
 profile::restbase::cassandra_password: "%{passwords::cassandra::restbase}"
 profile::restbase::monitor_domain: en.wikipedia.org
diff --git a/modules/profile/manifests/restbase.pp 
b/modules/profile/manifests/restbase.pp
index 8ddeebc..1df7ce3 100644
--- a/modules/profile/manifests/restbase.pp
+++ b/modules/profile/manifests/restbase.pp
@@ -64,6 +64,10 @@
 # [*cxserver_uri*]
 #   CXServer service uri. Format: http://cxserver.discovery.wmnet:8080
 #
+# [*recommendation_uri*]
+#   Recommendation API service URI. Format:
+#   http://recommendation-api.discovery.wmnet:9632
+#
 
 class profile::restbase(
 $cassandra_user = hiera('profile::restbase::cassandra_user'),
@@ -85,6 +89,7 @@
 $citoid_uri = hiera('profile::restbase::citoid_uri'),
 $trendingedits_uri = hiera('profile::restbase::trendingedits_uri'),
 $cxserver_uri   = hiera('profile::restbase::cxserver_uri'),
+$recommendation_uri = hiera('profile::restbase::recommendation_uri'),
 $monitor_domain = hiera('profile::restbase::monitor_domain'),
 ) {
 # Default values that need no overriding
@@ -123,6 +128,7 @@
 pdfrender_key=> $pdfrender_key,
 trendingedits_uri=> $trendingedits_uri,
 cxserver_uri => $cxserver_uri,
+recommendation_uri   => 

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Config: Do not always wait for PubMed requests to complete

[Mobrovac (Code Review)]

Mobrovac has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/368946 )

Change subject: Config: Do not always wait for PubMed requests to complete
..


Config: Do not always wait for PubMed requests to complete

Bug: T162886
Change-Id: I1a2c1c124de1aae3b915b741a63007381b38c63c
---
M scap/templates/config.yaml.j2
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Mobrovac: Verified; Looks good to me, approved



diff --git a/scap/templates/config.yaml.j2 b/scap/templates/config.yaml.j2
index d386000..5e4d328 100644
--- a/scap/templates/config.yaml.j2
+++ b/scap/templates/config.yaml.j2
@@ -75,6 +75,8 @@
   zoteroPort: <%= zotero_port %>
   # whether the proxy should be used to contact zotero
   zoteroUseProxy: false
+  # whether Citoid should always wait for the PubMed request to complete
+  pubmed: false
   # whether Citoid is allowed to scrape private IPs
   allowPrivateAddresses: false
   # maximum number of redirects allowed

-- 
To view, visit https://gerrit.wikimedia.org/r/368946
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1a2c1c124de1aae3b915b741a63007381b38c63c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/citoid/deploy
Gerrit-Branch: master
Gerrit-Owner: Mobrovac 
Gerrit-Reviewer: Mobrovac 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Config: Do not always wait for PubMed requests to complete

[Mobrovac (Code Review)]

Mobrovac has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/368946 )

Change subject: Config: Do not always wait for PubMed requests to complete
..

Config: Do not always wait for PubMed requests to complete

Bug: T162886
Change-Id: I1a2c1c124de1aae3b915b741a63007381b38c63c
---
M scap/templates/config.yaml.j2
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/citoid/deploy 
refs/changes/46/368946/1

diff --git a/scap/templates/config.yaml.j2 b/scap/templates/config.yaml.j2
index d386000..5e4d328 100644
--- a/scap/templates/config.yaml.j2
+++ b/scap/templates/config.yaml.j2
@@ -75,6 +75,8 @@
   zoteroPort: <%= zotero_port %>
   # whether the proxy should be used to contact zotero
   zoteroUseProxy: false
+  # whether Citoid should always wait for the PubMed request to complete
+  pubmed: false
   # whether Citoid is allowed to scrape private IPs
   allowPrivateAddresses: false
   # maximum number of redirects allowed

-- 
To view, visit https://gerrit.wikimedia.org/r/368946
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1a2c1c124de1aae3b915b741a63007381b38c63c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/citoid/deploy
Gerrit-Branch: master
Gerrit-Owner: Mobrovac 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Update electron-render-service to f3978ab

[Mobrovac (Code Review)]

Mobrovac has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/367732 )

Change subject: Update electron-render-service to f3978ab
..


Update electron-render-service to f3978ab

List of changes:
f3978ab Switch to Node v6.11
xxx Update node module dependencies

Change-Id: If525d070b0e75521b8c0006f19b4edd30a3ec1a0
---
A node_modules/@types/bluebird/LICENSE
M node_modules/@types/bluebird/index.d.ts
M node_modules/@types/bluebird/package.json
D node_modules/@types/bluebird/types-metadata.json
A node_modules/@types/express-serve-static-core/LICENSE
M node_modules/@types/express-serve-static-core/index.d.ts
M node_modules/@types/express-serve-static-core/package.json
A node_modules/@types/express/LICENSE
M node_modules/@types/express/index.d.ts
M node_modules/@types/express/package.json
D node_modules/@types/express/types-metadata.json
A node_modules/@types/mime/LICENSE
M node_modules/@types/mime/index.d.ts
M node_modules/@types/mime/package.json
D node_modules/@types/mime/types-metadata.json
A node_modules/@types/node/LICENSE
M node_modules/@types/node/index.d.ts
M node_modules/@types/node/package.json
M node_modules/ajv/dist/ajv.bundle.js
M node_modules/ajv/dist/ajv.min.js
M node_modules/ajv/dist/ajv.min.js.map
M node_modules/ajv/dist/nodent.min.js
M node_modules/ajv/dist/regenerator.min.js
M node_modules/ajv/lib/ajv.d.ts
M node_modules/ajv/lib/compile/formats.js
M node_modules/ajv/lib/dot/custom.jst
M node_modules/ajv/lib/dot/validate.jst
M node_modules/ajv/lib/dotjs/anyOf.js
M node_modules/ajv/lib/dotjs/constant.js
M node_modules/ajv/lib/dotjs/custom.js
M node_modules/ajv/lib/dotjs/dependencies.js
M node_modules/ajv/lib/dotjs/enum.js
M node_modules/ajv/lib/dotjs/format.js
M node_modules/ajv/lib/dotjs/items.js
M node_modules/ajv/lib/dotjs/multipleOf.js
M node_modules/ajv/lib/dotjs/not.js
M node_modules/ajv/lib/dotjs/oneOf.js
M node_modules/ajv/lib/dotjs/pattern.js
M node_modules/ajv/lib/dotjs/patternRequired.js
M node_modules/ajv/lib/dotjs/properties.js
M node_modules/ajv/lib/dotjs/ref.js
M node_modules/ajv/lib/dotjs/required.js
M node_modules/ajv/lib/dotjs/switch.js
M node_modules/ajv/lib/dotjs/uniqueItems.js
M node_modules/ajv/lib/dotjs/validate.js
M node_modules/ajv/package.json
M node_modules/ajv/scripts/compile-dots.js
M node_modules/ajv/scripts/travis-gh-pages
M node_modules/async/apply.js
M node_modules/async/applyEach.js
M node_modules/async/applyEachSeries.js
M node_modules/async/asyncify.js
M node_modules/async/auto.js
M node_modules/async/autoInject.js
M node_modules/async/cargo.js
M node_modules/async/compose.js
M node_modules/async/concat.js
A node_modules/async/concatLimit.js
M node_modules/async/concatSeries.js
M node_modules/async/constant.js
M node_modules/async/detect.js
M node_modules/async/detectLimit.js
M node_modules/async/detectSeries.js
M node_modules/async/dir.js
M node_modules/async/dist/async.js
M node_modules/async/dist/async.min.js
M node_modules/async/doDuring.js
M node_modules/async/doUntil.js
M node_modules/async/doWhilst.js
M node_modules/async/during.js
M node_modules/async/each.js
M node_modules/async/eachLimit.js
M node_modules/async/eachOf.js
M node_modules/async/eachOfLimit.js
M node_modules/async/eachOfSeries.js
M node_modules/async/eachSeries.js
M node_modules/async/ensureAsync.js
M node_modules/async/every.js
M node_modules/async/everyLimit.js
M node_modules/async/everySeries.js
M node_modules/async/forever.js
A node_modules/async/groupBy.js
A node_modules/async/groupByLimit.js
A node_modules/async/groupBySeries.js
M node_modules/async/index.js
M node_modules/async/internal/DoublyLinkedList.js
M node_modules/async/internal/applyEach.js
D node_modules/async/internal/concat.js
M node_modules/async/internal/consoleFunc.js
M node_modules/async/internal/doParallel.js
M node_modules/async/internal/doParallelLimit.js
D node_modules/async/internal/doSeries.js
M node_modules/async/internal/filter.js
M node_modules/async/internal/initialParams.js
M node_modules/async/internal/map.js
M node_modules/async/internal/parallel.js
M node_modules/async/internal/queue.js
D node_modules/async/internal/rest.js
M node_modules/async/internal/setImmediate.js
A node_modules/async/internal/slice.js
A node_modules/async/internal/wrapAsync.js
M node_modules/async/log.js
M node_modules/async/map.js
M node_modules/async/mapLimit.js
M node_modules/async/mapSeries.js
M node_modules/async/mapValues.js
M node_modules/async/mapValuesLimit.js
M node_modules/async/mapValuesSeries.js
M node_modules/async/memoize.js
M node_modules/async/package.json
M node_modules/async/parallel.js
M node_modules/async/parallelLimit.js
M node_modules/async/priorityQueue.js
M node_modules/async/queue.js
M node_modules/async/race.js
M node_modules/async/reduce.js
M node_modules/async/reduceRight.js
M node_modules/async/reflect.js
M node_modules/async/reflectAll.js
M node_modules/async/reject.js
M 

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Update mathoid to fab5c3998

[Mobrovac (Code Review)]

Mobrovac has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/367739 )

Change subject: Update mathoid to fab5c3998
..


Update mathoid to fab5c3998

List of changes:
8ccdd2abe Add the Dockerfile to be used in Kubernetes
de37e2184 Update readme node version, de-mention phantomjs
99f0a6bfa Add node version requirement >= 4
fab5c3998 Switch to Node v6.11; release v0.6.5
xxx Update node module dependencies

Change-Id: I9a936977846cb9adea54e422c35ff73bd9624198
---
M node_modules/ajv/dist/ajv.bundle.js
M node_modules/ajv/dist/ajv.min.js
M node_modules/ajv/dist/ajv.min.js.map
M node_modules/ajv/dist/nodent.min.js
M node_modules/ajv/dist/regenerator.min.js
M node_modules/ajv/lib/ajv.d.ts
M node_modules/ajv/lib/compile/formats.js
M node_modules/ajv/lib/dot/custom.jst
M node_modules/ajv/lib/dot/validate.jst
M node_modules/ajv/lib/dotjs/anyOf.js
M node_modules/ajv/lib/dotjs/constant.js
M node_modules/ajv/lib/dotjs/custom.js
M node_modules/ajv/lib/dotjs/dependencies.js
M node_modules/ajv/lib/dotjs/enum.js
M node_modules/ajv/lib/dotjs/format.js
M node_modules/ajv/lib/dotjs/items.js
M node_modules/ajv/lib/dotjs/multipleOf.js
M node_modules/ajv/lib/dotjs/not.js
M node_modules/ajv/lib/dotjs/oneOf.js
M node_modules/ajv/lib/dotjs/pattern.js
M node_modules/ajv/lib/dotjs/patternRequired.js
M node_modules/ajv/lib/dotjs/properties.js
M node_modules/ajv/lib/dotjs/ref.js
M node_modules/ajv/lib/dotjs/required.js
M node_modules/ajv/lib/dotjs/switch.js
M node_modules/ajv/lib/dotjs/uniqueItems.js
M node_modules/ajv/lib/dotjs/validate.js
M node_modules/ajv/package.json
M node_modules/ajv/scripts/compile-dots.js
M node_modules/ajv/scripts/travis-gh-pages
M node_modules/asap/package.json
M node_modules/balanced-match/index.js
M node_modules/balanced-match/package.json
M node_modules/bl/bl.js
M node_modules/bl/package.json
M node_modules/bl/test/test.js
M node_modules/body-parser/lib/read.js
M node_modules/body-parser/package.json
M node_modules/brace-expansion/index.js
M node_modules/brace-expansion/package.json
D node_modules/buffer-shims/index.js
D node_modules/buffer-shims/package.json
M node_modules/bunyan/bin/bunyan
M node_modules/bunyan/lib/bunyan.js
M node_modules/bunyan/package.json
M node_modules/clap/index.js
M node_modules/clap/package.json
A node_modules/coa/.nyc_output/1f2a0db5a6d6559149db56d397f47cfc.json
A node_modules/coa/.nyc_output/75b82d38f2186df930141082076e11c6.json
A node_modules/coa/coverage/base.css
A node_modules/coa/coverage/coa/index.html
A node_modules/coa/coverage/coa/index.js.html
A node_modules/coa/coverage/coa/lib/arg.js.html
A node_modules/coa/coverage/coa/lib/cmd.js.html
A node_modules/coa/coverage/coa/lib/coaobject.js.html
A node_modules/coa/coverage/coa/lib/coaparam.js.html
A node_modules/coa/coverage/coa/lib/color.js.html
A node_modules/coa/coverage/coa/lib/completion.js.html
A node_modules/coa/coverage/coa/lib/index.html
A node_modules/coa/coverage/coa/lib/index.js.html
A node_modules/coa/coverage/coa/lib/opt.js.html
A node_modules/coa/coverage/coa/lib/shell.js.html
A node_modules/coa/coverage/index.html
A node_modules/coa/coverage/prettify.css
A node_modules/coa/coverage/prettify.js
A node_modules/coa/coverage/sort-arrow-sprite.png
A node_modules/coa/coverage/sorter.js
M node_modules/coa/package.json
A node_modules/coa/qq.js
M node_modules/commander/index.js
M node_modules/commander/package.json
M node_modules/compressible/package.json
M node_modules/compression/index.js
M node_modules/compression/node_modules/bytes/index.js
M node_modules/compression/node_modules/bytes/package.json
R node_modules/compression/node_modules/debug/.coveralls.yml
R node_modules/compression/node_modules/debug/.eslintrc
D node_modules/compression/node_modules/debug/.jshintrc
M node_modules/compression/node_modules/debug/.npmignore
R node_modules/compression/node_modules/debug/.travis.yml
R node_modules/compression/node_modules/debug/LICENSE
M node_modules/compression/node_modules/debug/Makefile
D node_modules/compression/node_modules/debug/bower.json
D node_modules/compression/node_modules/debug/browser.js
M node_modules/compression/node_modules/debug/component.json
D node_modules/compression/node_modules/debug/debug.js
R node_modules/compression/node_modules/debug/karma.conf.js
M node_modules/compression/node_modules/debug/node.js
M node_modules/compression/node_modules/debug/package.json
R node_modules/compression/node_modules/debug/src/browser.js
R node_modules/compression/node_modules/debug/src/debug.js
R node_modules/compression/node_modules/debug/src/index.js
R node_modules/compression/node_modules/debug/src/node.js
D node_modules/compression/node_modules/ms/.npmignore
D node_modules/compression/node_modules/ms/LICENSE
D node_modules/compression/node_modules/ms/index.js
D node_modules/compression/node_modules/ms/package.json
M node_modules/compression/package.json
M node_modules/debug/.npmignore
D 

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Update recommendation-api to 95c9bd1

[Mobrovac (Code Review)]

Mobrovac has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/367733 )

Change subject: Update recommendation-api to 95c9bd1
..


Update recommendation-api to 95c9bd1

List of changes:
865e64d Fix split call
95c9bd1 Switch to Node v6.11
xxx Update node module dependencies

Change-Id: Ie6c94064db211359d513eba24fa60258e28b9448
---
M node_modules/bl/package.json
M node_modules/heapdump/build/Makefile
M 
node_modules/heapdump/build/Release/.deps/Release/obj.target/addon/src/heapdump.o.d
M node_modules/heapdump/build/addon.target.mk
M node_modules/heapdump/build/config.gypi
M node_modules/kad/package.json
M node_modules/mime-db/db.json
M node_modules/mime-db/package.json
M node_modules/mime-types/index.js
M node_modules/mime-types/package.json
M node_modules/msgpack5/.travis.yml
M node_modules/msgpack5/example.js
M node_modules/msgpack5/index.js
M node_modules/msgpack5/lib/encoder.js
M node_modules/msgpack5/lib/streams.js
M node_modules/msgpack5/package.json
M node_modules/msgpack5/test/1-byte-length-buffers.js
M node_modules/msgpack5/test/1-byte-length-exts.js
M node_modules/msgpack5/test/1-byte-length-strings.js
M node_modules/msgpack5/test/15-elements-arrays.js
M node_modules/msgpack5/test/15-elements-maps.js
M node_modules/msgpack5/test/16-bits-signed-integers.js
M node_modules/msgpack5/test/16-bits-unsigned-integers.js
M node_modules/msgpack5/test/2-bytes-length-arrays.js
M node_modules/msgpack5/test/2-bytes-length-buffers.js
M node_modules/msgpack5/test/2-bytes-length-exts.js
M node_modules/msgpack5/test/2-bytes-length-maps.js
M node_modules/msgpack5/test/2-bytes-length-strings.js
M node_modules/msgpack5/test/31-chars-strings.js
M node_modules/msgpack5/test/32-bits-signed-integers.js
M node_modules/msgpack5/test/32-bits-unsigned-integers.js
M node_modules/msgpack5/test/32-bytes-strings.js
M node_modules/msgpack5/test/4-bytes-length-arrays.js
M node_modules/msgpack5/test/4-bytes-length-buffers.js
M node_modules/msgpack5/test/4-bytes-length-exts.js
M node_modules/msgpack5/test/4-bytes-length-strings.js
M node_modules/msgpack5/test/5-bits-negative-integers.js
M node_modules/msgpack5/test/64-bits-signed-integers.js
M node_modules/msgpack5/test/64-bits-unsigned-integers.js
M node_modules/msgpack5/test/7-bits-positive-integers.js
M node_modules/msgpack5/test/8-bits-positive-integers.js
M node_modules/msgpack5/test/8-bits-signed-integers.js
M node_modules/msgpack5/test/booleans.js
M node_modules/msgpack5/test/doubles.js
M node_modules/msgpack5/test/ext-custom-encode-check.js
M node_modules/msgpack5/test/fixexts.js
M node_modules/msgpack5/test/floats.js
M node_modules/msgpack5/test/null.js
M node_modules/msgpack5/test/object-with-buffers.js
M node_modules/msgpack5/test/streams.js
M node_modules/safe-buffer/package.json
M node_modules/semver/package.json
M node_modules/semver/semver.js
M node_modules/swagger-ui/package.json
M src
55 files changed, 525 insertions(+), 300 deletions(-)

Approvals:
  Mobrovac: Verified; Looks good to me, approved



diff --git a/node_modules/bl/package.json b/node_modules/bl/package.json
index 3741bf2..fac8bc9 100644
--- a/node_modules/bl/package.json
+++ b/node_modules/bl/package.json
@@ -2,18 +2,18 @@
   "_args": [
 [
   {
-"raw": "bl@^1.0.0",
+"raw": "bl@^1.2.1",
 "scope": null,
 "escapedName": "bl",
 "name": "bl",
-"rawSpec": "^1.0.0",
-"spec": ">=1.0.0 <2.0.0",
+"rawSpec": "^1.2.1",
+"spec": ">=1.2.1 <2.0.0",
 "type": "range"
   },
   "/opt/service/node_modules/msgpack5"
 ]
   ],
-  "_from": "bl@>=1.0.0 <2.0.0",
+  "_from": "bl@>=1.2.1 <2.0.0",
   "_id": "bl@1.2.1",
   "_inCache": true,
   "_location": "/bl",
@@ -29,12 +29,12 @@
   "_npmVersion": "3.10.10",
   "_phantomChildren": {},
   "_requested": {
-"raw": "bl@^1.0.0",
+"raw": "bl@^1.2.1",
 "scope": null,
 "escapedName": "bl",
 "name": "bl",
-"rawSpec": "^1.0.0",
-"spec": ">=1.0.0 <2.0.0",
+"rawSpec": "^1.2.1",
+"spec": ">=1.2.1 <2.0.0",
 "type": "range"
   },
   "_requiredBy": [
@@ -43,7 +43,7 @@
   "_resolved": "https://registry.npmjs.org/bl/-/bl-1.2.1.tgz;,
   "_shasum": "cac328f7bee45730d404b692203fcb590e172d5e",
   "_shrinkwrap": null,
-  "_spec": "bl@^1.0.0",
+  "_spec": "bl@^1.2.1",
   "_where": "/opt/service/node_modules/msgpack5",
   "authors": [
 "Rod Vagg  (https://github.com/rvagg)",
diff --git a/node_modules/heapdump/build/Makefile 
b/node_modules/heapdump/build/Makefile
index 80ab260..6197a30 100644
--- a/node_modules/heapdump/build/Makefile
+++ b/node_modules/heapdump/build/Makefile
@@ -308,8 +308,8 @@
 endif
 
 quiet_cmd_regen_makefile = ACTION Regenerating $@
-cmd_regen_makefile = cd $(srcdir); 
/usr/local/nvm/versions/node/v6.9.1/lib/node_modules/npm/node_modules/node-gyp/gyp/gyp_main.py
 -fmake --ignore-environment "--toplevel-dir=." 

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Update eventstreams to 29abd70

[Mobrovac (Code Review)]

Mobrovac has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/367740 )

Change subject: Update eventstreams to 29abd70
..


Update eventstreams to 29abd70

List of changes:
29abd70 Switch to Node v6.11
xxx Update node module dependencies

Change-Id: I6223885415704286051f162b6ebcd834de30ea17
---
M node_modules/ajv/dist/ajv.bundle.js
M node_modules/ajv/dist/ajv.min.js
M node_modules/ajv/dist/ajv.min.js.map
M node_modules/ajv/dist/nodent.min.js
M node_modules/ajv/dist/regenerator.min.js
M node_modules/ajv/lib/ajv.d.ts
M node_modules/ajv/lib/compile/formats.js
M node_modules/ajv/lib/dot/custom.jst
M node_modules/ajv/lib/dot/validate.jst
M node_modules/ajv/lib/dotjs/anyOf.js
M node_modules/ajv/lib/dotjs/constant.js
M node_modules/ajv/lib/dotjs/custom.js
M node_modules/ajv/lib/dotjs/dependencies.js
M node_modules/ajv/lib/dotjs/enum.js
M node_modules/ajv/lib/dotjs/format.js
M node_modules/ajv/lib/dotjs/items.js
M node_modules/ajv/lib/dotjs/multipleOf.js
M node_modules/ajv/lib/dotjs/not.js
M node_modules/ajv/lib/dotjs/oneOf.js
M node_modules/ajv/lib/dotjs/pattern.js
M node_modules/ajv/lib/dotjs/patternRequired.js
M node_modules/ajv/lib/dotjs/properties.js
M node_modules/ajv/lib/dotjs/ref.js
M node_modules/ajv/lib/dotjs/required.js
M node_modules/ajv/lib/dotjs/switch.js
M node_modules/ajv/lib/dotjs/uniqueItems.js
M node_modules/ajv/lib/dotjs/validate.js
M node_modules/ajv/package.json
M node_modules/ajv/scripts/compile-dots.js
M node_modules/ajv/scripts/travis-gh-pages
M node_modules/asap/package.json
M node_modules/balanced-match/index.js
M node_modules/balanced-match/package.json
M node_modules/bindings/bindings.js
M node_modules/bindings/package.json
M node_modules/bl/bl.js
M node_modules/bl/package.json
M node_modules/bl/test/test.js
M node_modules/body-parser/lib/read.js
M node_modules/body-parser/package.json
M node_modules/brace-expansion/index.js
M node_modules/brace-expansion/package.json
D node_modules/buffer-shims/index.js
D node_modules/buffer-shims/package.json
M node_modules/bunyan/bin/bunyan
M node_modules/bunyan/lib/bunyan.js
M node_modules/bunyan/package.json
M node_modules/commander/index.js
M node_modules/commander/package.json
M node_modules/debug/.npmignore
D node_modules/debug/bower.json
M node_modules/debug/component.json
M node_modules/debug/package.json
M node_modules/debug/src/browser.js
M node_modules/debug/src/debug.js
M node_modules/debug/src/node.js
M node_modules/dtrace-provider/libusdt/Makefile
M node_modules/dtrace-provider/package.json
M node_modules/dtrace-provider/scripts/install.js
M node_modules/esprima/ChangeLog
M node_modules/esprima/bin/esvalidate.js
M node_modules/esprima/dist/esprima.js
M node_modules/esprima/package.json
M node_modules/express/lib/application.js
M node_modules/express/lib/middleware/init.js
M node_modules/express/lib/response.js
M node_modules/express/package.json
M node_modules/extend/.eslintrc
M node_modules/extend/.jscs.json
M node_modules/extend/.travis.yml
M node_modules/extend/index.js
M node_modules/extend/package.json
D node_modules/finalhandler/node_modules/debug/.coveralls.yml
D node_modules/finalhandler/node_modules/debug/.eslintrc
D node_modules/finalhandler/node_modules/debug/.npmignore
D node_modules/finalhandler/node_modules/debug/.travis.yml
D node_modules/finalhandler/node_modules/debug/LICENSE
D node_modules/finalhandler/node_modules/debug/Makefile
D node_modules/finalhandler/node_modules/debug/bower.json
D node_modules/finalhandler/node_modules/debug/component.json
D node_modules/finalhandler/node_modules/debug/karma.conf.js
D node_modules/finalhandler/node_modules/debug/node.js
D node_modules/finalhandler/node_modules/debug/package.json
D node_modules/finalhandler/node_modules/debug/src/browser.js
D node_modules/finalhandler/node_modules/debug/src/debug.js
D node_modules/finalhandler/node_modules/debug/src/index.js
D node_modules/finalhandler/node_modules/debug/src/node.js
M node_modules/finalhandler/package.json
M node_modules/form-data/lib/form_data.js
M node_modules/form-data/package.json
M node_modules/getpass/package.json
D node_modules/graceful-readlink/.npmignore
D node_modules/graceful-readlink/.travis.yml
D node_modules/graceful-readlink/LICENSE
D node_modules/graceful-readlink/index.js
D node_modules/graceful-readlink/package.json
M node_modules/heapdump/build/Makefile
M 
node_modules/heapdump/build/Release/.deps/Release/obj.target/addon/src/heapdump.o.d
M node_modules/heapdump/build/addon.target.mk
M node_modules/heapdump/build/config.gypi
M node_modules/hosted-git-info/index.js
M node_modules/hosted-git-info/package.json
M node_modules/hot-shots/lib/statsd.js
M node_modules/hot-shots/package.json
D node_modules/jodid25519/.npmignore
D node_modules/jodid25519/.travis.yml
D node_modules/jodid25519/LICENSE
D node_modules/jodid25519/almond.0
D node_modules/jodid25519/almond.1
D node_modules/jodid25519/index.js
D 

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Update trending-edits to 713323e

[Mobrovac (Code Review)]

Mobrovac has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/367729 )

Change subject: Update trending-edits to 713323e
..


Update trending-edits to 713323e

List of changes:
713323e Switch to Node v6.11
xxx Update node module dependencies

Change-Id: Iadd5e08c1aca707cc90a166c905af6539eb1c172
---
M node_modules/asap/package.json
M node_modules/balanced-match/index.js
M node_modules/balanced-match/package.json
M node_modules/bindings/bindings.js
M node_modules/bindings/package.json
M node_modules/bl/package.json
M node_modules/brace-expansion/package.json
M node_modules/compressible/package.json
M node_modules/compression/index.js
M node_modules/compression/node_modules/bytes/index.js
M node_modules/compression/node_modules/bytes/package.json
A node_modules/compression/node_modules/debug/.coveralls.yml
A node_modules/compression/node_modules/debug/.eslintrc
D node_modules/compression/node_modules/debug/.jshintrc
M node_modules/compression/node_modules/debug/.npmignore
A node_modules/compression/node_modules/debug/.travis.yml
A node_modules/compression/node_modules/debug/LICENSE
M node_modules/compression/node_modules/debug/Makefile
D node_modules/compression/node_modules/debug/bower.json
M node_modules/compression/node_modules/debug/component.json
A node_modules/compression/node_modules/debug/karma.conf.js
M node_modules/compression/node_modules/debug/node.js
M node_modules/compression/node_modules/debug/package.json
R node_modules/compression/node_modules/debug/src/browser.js
R node_modules/compression/node_modules/debug/src/debug.js
A node_modules/compression/node_modules/debug/src/index.js
A node_modules/compression/node_modules/debug/src/node.js
D node_modules/compression/node_modules/ms/.npmignore
D node_modules/compression/node_modules/ms/LICENSE
D node_modules/compression/node_modules/ms/index.js
D node_modules/compression/node_modules/ms/package.json
M node_modules/compression/package.json
M node_modules/dtrace-provider/package.json
M node_modules/dtrace-provider/scripts/install.js
M node_modules/esprima/ChangeLog
M node_modules/esprima/bin/esvalidate.js
M node_modules/esprima/dist/esprima.js
M node_modules/esprima/package.json
M node_modules/heapdump/build/Makefile
M 
node_modules/heapdump/build/Release/.deps/Release/obj.target/addon/src/heapdump.o.d
M node_modules/heapdump/build/addon.target.mk
M node_modules/heapdump/build/config.gypi
M node_modules/hosted-git-info/index.js
M node_modules/hosted-git-info/package.json
D node_modules/jodid25519/.npmignore
D node_modules/jodid25519/.travis.yml
D node_modules/jodid25519/LICENSE
D node_modules/jodid25519/almond.0
D node_modules/jodid25519/almond.1
D node_modules/jodid25519/index.js
D node_modules/jodid25519/jsdoc.json
D node_modules/jodid25519/lib/core.js
D node_modules/jodid25519/lib/curve255.js
D node_modules/jodid25519/lib/dh.js
D node_modules/jodid25519/lib/eddsa.js
D node_modules/jodid25519/lib/utils.js
D node_modules/jodid25519/package.json
M node_modules/js-yaml/dist/js-yaml.js
M node_modules/js-yaml/dist/js-yaml.min.js
M node_modules/js-yaml/lib/js-yaml/dumper.js
M node_modules/js-yaml/lib/js-yaml/loader.js
M node_modules/js-yaml/package.json
M node_modules/jsbn/package.json
M node_modules/kad/package.json
M node_modules/mime-db/db.json
M node_modules/mime-db/package.json
M node_modules/mime-types/index.js
M node_modules/mime-types/package.json
M node_modules/ms/package.json
M node_modules/msgpack5/.travis.yml
M node_modules/msgpack5/example.js
M node_modules/msgpack5/index.js
M node_modules/msgpack5/lib/encoder.js
M node_modules/msgpack5/lib/streams.js
M node_modules/msgpack5/package.json
M node_modules/msgpack5/test/1-byte-length-buffers.js
M node_modules/msgpack5/test/1-byte-length-exts.js
M node_modules/msgpack5/test/1-byte-length-strings.js
M node_modules/msgpack5/test/15-elements-arrays.js
M node_modules/msgpack5/test/15-elements-maps.js
M node_modules/msgpack5/test/16-bits-signed-integers.js
M node_modules/msgpack5/test/16-bits-unsigned-integers.js
M node_modules/msgpack5/test/2-bytes-length-arrays.js
M node_modules/msgpack5/test/2-bytes-length-buffers.js
M node_modules/msgpack5/test/2-bytes-length-exts.js
M node_modules/msgpack5/test/2-bytes-length-maps.js
M node_modules/msgpack5/test/2-bytes-length-strings.js
M node_modules/msgpack5/test/31-chars-strings.js
M node_modules/msgpack5/test/32-bits-signed-integers.js
M node_modules/msgpack5/test/32-bits-unsigned-integers.js
M node_modules/msgpack5/test/32-bytes-strings.js
M node_modules/msgpack5/test/4-bytes-length-arrays.js
M node_modules/msgpack5/test/4-bytes-length-buffers.js
M node_modules/msgpack5/test/4-bytes-length-exts.js
M node_modules/msgpack5/test/4-bytes-length-strings.js
M node_modules/msgpack5/test/5-bits-negative-integers.js
M node_modules/msgpack5/test/64-bits-signed-integers.js
M node_modules/msgpack5/test/64-bits-unsigned-integers.js
M 

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Update service-mobileapp-node to e19ed25

[Mobrovac (Code Review)]

Mobrovac has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/367734 )

Change subject: Update service-mobileapp-node to e19ed25
..


Update service-mobileapp-node to e19ed25

List of changes:
e19ed25 Switch to Node v6.11
xxx Update node module dependencies

Change-Id: Iba961baebbf4213b8c665cc18de55ddf17a151d7
---
M node_modules/cryptiles/.npmignore
M node_modules/cryptiles/.travis.yml
M node_modules/esprima/dist/esprima.js
M node_modules/hawk/.npmignore
M node_modules/hawk/.travis.yml
M node_modules/hawk/bower.json
M node_modules/hawk/component.json
M node_modules/hawk/dist/client.js
M node_modules/hawk/example/usage.js
M node_modules/hawk/lib/browser.js
M node_modules/hawk/lib/client.js
M node_modules/hawk/lib/crypto.js
M node_modules/hawk/lib/index.js
M node_modules/hawk/lib/server.js
M node_modules/hawk/lib/utils.js
M node_modules/hawk/test/browser.js
M node_modules/hawk/test/client.js
M node_modules/hawk/test/crypto.js
M node_modules/hawk/test/index.js
M node_modules/hawk/test/readme.js
M node_modules/hawk/test/server.js
M node_modules/hawk/test/uri.js
M node_modules/hawk/test/utils.js
M node_modules/heapdump/build/Makefile
M 
node_modules/heapdump/build/Release/.deps/Release/obj.target/addon/src/heapdump.o.d
M node_modules/heapdump/build/addon.target.mk
M node_modules/heapdump/build/config.gypi
M node_modules/json-schema/draft-00/hyper-schema
M node_modules/json-schema/draft-00/json-ref
M node_modules/json-schema/draft-00/links
M node_modules/json-schema/draft-00/schema
M node_modules/json-schema/draft-01/hyper-schema
M node_modules/json-schema/draft-01/json-ref
M node_modules/json-schema/draft-01/links
M node_modules/json-schema/draft-01/schema
M node_modules/json-schema/draft-02/hyper-schema
M node_modules/json-schema/draft-02/json-ref
M node_modules/json-schema/draft-02/links
M node_modules/json-schema/draft-02/schema
M node_modules/json-schema/draft-03/examples/address
M node_modules/json-schema/draft-03/examples/calendar
M node_modules/json-schema/draft-03/examples/card
M node_modules/json-schema/draft-03/examples/geo
M node_modules/json-schema/draft-03/examples/interfaces
M node_modules/json-schema/draft-03/hyper-schema
M node_modules/json-schema/draft-03/json-ref
M node_modules/json-schema/draft-03/links
M node_modules/json-schema/draft-03/schema
M node_modules/json-schema/draft-04/hyper-schema
M node_modules/json-schema/draft-04/links
M node_modules/json-schema/draft-04/schema
M node_modules/json-schema/draft-zyp-json-schema-03.xml
M node_modules/json-schema/draft-zyp-json-schema-04.xml
M node_modules/json-schema/lib/links.js
M node_modules/json-schema/lib/validate.js
M node_modules/json-schema/test/tests.js
M node_modules/kad/package.json
M node_modules/long/.npmignore
M node_modules/long/.travis.yml
M node_modules/long/LICENSE
M node_modules/long/bower.json
M node_modules/long/dist/Long.js
M node_modules/long/externs/Long.js
M node_modules/long/index.js
M node_modules/long/jsdoc.json
M node_modules/long/scripts/build.js
M node_modules/long/src/Long.js
M node_modules/long/src/bower.json
M node_modules/long/src/wrap.js
M node_modules/long/tests/goog.math.long.js
M node_modules/long/tests/suite.js
M node_modules/merge/LICENSE
M node_modules/merge/merge.js
M node_modules/merge/merge.min.js
M node_modules/mime-db/db.json
M node_modules/mime-db/package.json
M node_modules/mime-types/index.js
M node_modules/mime-types/package.json
M src
79 files changed, 22,107 insertions(+), 22,023 deletions(-)

Approvals:
  Mobrovac: Verified; Looks good to me, approved
  jenkins-bot: Verified




-- 
To view, visit https://gerrit.wikimedia.org/r/367734
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iba961baebbf4213b8c665cc18de55ddf17a151d7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/mobileapps/deploy
Gerrit-Branch: master
Gerrit-Owner: Ppchelko 
Gerrit-Reviewer: BearND 
Gerrit-Reviewer: Mholloway 
Gerrit-Reviewer: Mobrovac 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Update graphoid to 85a5861

[Mobrovac (Code Review)]

Mobrovac has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/367741 )

Change subject: Update graphoid to 85a5861
..


Update graphoid to 85a5861

List of changes:
85a5861 Switch to Node v6.11
xxx Update node module dependencies

Change-Id: Ida3682687af719fb88e3b58b4403895a7529ad49
---
D node_modules/acorn/.editorconfig
M node_modules/acorn/.npmignore
D node_modules/acorn/.tern-project
D node_modules/acorn/.travis.yml
M node_modules/acorn/AUTHORS
M node_modules/acorn/LICENSE
M node_modules/acorn/bin/acorn
D node_modules/acorn/bin/build-acorn.js
D node_modules/acorn/bin/generate-identifier-regex.js
D node_modules/acorn/bin/prepublish.sh
D node_modules/acorn/bin/update_authors.sh
D node_modules/acorn/bin/without_eval
A node_modules/acorn/dist/acorn.es.js
M node_modules/acorn/dist/acorn.js
D node_modules/acorn/dist/acorn_csp.js
A node_modules/acorn/dist/acorn_loose.es.js
M node_modules/acorn/dist/acorn_loose.js
A node_modules/acorn/dist/walk.es.js
M node_modules/acorn/dist/walk.js
M node_modules/acorn/package.json
D node_modules/acorn/src/expression.js
D node_modules/acorn/src/identifier.js
D node_modules/acorn/src/index.js
D node_modules/acorn/src/location.js
D node_modules/acorn/src/loose/acorn_loose.js
D node_modules/acorn/src/loose/expression.js
D node_modules/acorn/src/loose/index.js
D node_modules/acorn/src/loose/parseutil.js
D node_modules/acorn/src/loose/state.js
D node_modules/acorn/src/loose/statement.js
D node_modules/acorn/src/loose/tokenize.js
D node_modules/acorn/src/lval.js
D node_modules/acorn/src/node.js
D node_modules/acorn/src/options.js
D node_modules/acorn/src/parseutil.js
D node_modules/acorn/src/state.js
D node_modules/acorn/src/statement.js
D node_modules/acorn/src/tokencontext.js
D node_modules/acorn/src/tokenize.js
D node_modules/acorn/src/tokentype.js
D node_modules/acorn/src/util.js
D node_modules/acorn/src/walk/index.js
D node_modules/acorn/src/whitespace.js
M node_modules/ajv/dist/ajv.bundle.js
M node_modules/ajv/dist/ajv.min.js
M node_modules/ajv/dist/ajv.min.js.map
M node_modules/ajv/lib/dot/validate.jst
M node_modules/ajv/lib/dotjs/validate.js
M node_modules/ajv/package.json
M node_modules/asap/package.json
M node_modules/balanced-match/index.js
M node_modules/balanced-match/package.json
M node_modules/bl/bl.js
M node_modules/bl/package.json
M node_modules/bl/test/test.js
M node_modules/body-parser/lib/read.js
M node_modules/body-parser/package.json
M node_modules/brace-expansion/package.json
D node_modules/buffer-shims/index.js
D node_modules/buffer-shims/package.json
M node_modules/canvas/build/Makefile
M 
node_modules/canvas/build/Release/.deps/Release/obj.target/canvas/src/Canvas.o.d
M 
node_modules/canvas/build/Release/.deps/Release/obj.target/canvas/src/CanvasGradient.o.d
M 
node_modules/canvas/build/Release/.deps/Release/obj.target/canvas/src/CanvasPattern.o.d
M 
node_modules/canvas/build/Release/.deps/Release/obj.target/canvas/src/CanvasRenderingContext2d.o.d
M 
node_modules/canvas/build/Release/.deps/Release/obj.target/canvas/src/FontFace.o.d
M 
node_modules/canvas/build/Release/.deps/Release/obj.target/canvas/src/Image.o.d
M 
node_modules/canvas/build/Release/.deps/Release/obj.target/canvas/src/ImageData.o.d
M 
node_modules/canvas/build/Release/.deps/Release/obj.target/canvas/src/color.o.d
M node_modules/canvas/build/Release/.deps/Release/obj.target/canvas/src/init.o.d
M node_modules/canvas/build/canvas.target.mk
M node_modules/canvas/build/config.gypi
M node_modules/compressible/package.json
M node_modules/compression/index.js
M node_modules/compression/node_modules/bytes/index.js
M node_modules/compression/node_modules/bytes/package.json
R node_modules/compression/node_modules/debug/.coveralls.yml
R node_modules/compression/node_modules/debug/.eslintrc
D node_modules/compression/node_modules/debug/.jshintrc
M node_modules/compression/node_modules/debug/.npmignore
R node_modules/compression/node_modules/debug/.travis.yml
R node_modules/compression/node_modules/debug/LICENSE
M node_modules/compression/node_modules/debug/Makefile
D node_modules/compression/node_modules/debug/bower.json
D node_modules/compression/node_modules/debug/browser.js
M node_modules/compression/node_modules/debug/component.json
D node_modules/compression/node_modules/debug/debug.js
R node_modules/compression/node_modules/debug/karma.conf.js
M node_modules/compression/node_modules/debug/node.js
M node_modules/compression/node_modules/debug/package.json
R node_modules/compression/node_modules/debug/src/browser.js
R node_modules/compression/node_modules/debug/src/debug.js
R node_modules/compression/node_modules/debug/src/index.js
R node_modules/compression/node_modules/debug/src/node.js
D node_modules/compression/node_modules/ms/.npmignore
D node_modules/compression/node_modules/ms/LICENSE
D node_modules/compression/node_modules/ms/index.js
D node_modules/compression/node_modules/ms/package.json
M 

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Update citoid to 7ae3c7e

[Mobrovac (Code Review)]

Mobrovac has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/367744 )

Change subject: Update citoid to 7ae3c7e
..


Update citoid to 7ae3c7e

List of changes:
762e219 Try to improve performance with pubmed
7ae3c7e Switch to Node v6.11; release v0.5.3
xxx Update node module dependencies

Change-Id: I58483b3b66229833f91fe3c641e4fc764a4337f9
---
M node_modules/asap/package.json
M node_modules/balanced-match/index.js
M node_modules/balanced-match/package.json
M node_modules/bl/package.json
M node_modules/brace-expansion/package.json
D node_modules/buffer-shims/index.js
D node_modules/buffer-shims/package.json
M node_modules/dtrace-provider/libusdt/Makefile
M node_modules/dtrace-provider/package.json
M node_modules/dtrace-provider/scripts/install.js
M node_modules/es5-ext/.lint
M node_modules/es5-ext/array/#/@@iterator/implement.js
M node_modules/es5-ext/array/#/@@iterator/index.js
M node_modules/es5-ext/array/#/@@iterator/is-implemented.js
M node_modules/es5-ext/array/#/@@iterator/shim.js
M node_modules/es5-ext/array/#/_compare-by-length.js
M node_modules/es5-ext/array/#/binary-search.js
M node_modules/es5-ext/array/#/clear.js
M node_modules/es5-ext/array/#/compact.js
M node_modules/es5-ext/array/#/concat/implement.js
M node_modules/es5-ext/array/#/concat/index.js
M node_modules/es5-ext/array/#/concat/is-implemented.js
M node_modules/es5-ext/array/#/concat/shim.js
M node_modules/es5-ext/array/#/contains.js
M node_modules/es5-ext/array/#/copy-within/implement.js
M node_modules/es5-ext/array/#/copy-within/index.js
M node_modules/es5-ext/array/#/copy-within/is-implemented.js
M node_modules/es5-ext/array/#/copy-within/shim.js
M node_modules/es5-ext/array/#/diff.js
M node_modules/es5-ext/array/#/e-index-of.js
M node_modules/es5-ext/array/#/e-last-index-of.js
M node_modules/es5-ext/array/#/entries/implement.js
M node_modules/es5-ext/array/#/entries/index.js
M node_modules/es5-ext/array/#/entries/is-implemented.js
M node_modules/es5-ext/array/#/entries/shim.js
M node_modules/es5-ext/array/#/exclusion.js
M node_modules/es5-ext/array/#/fill/implement.js
M node_modules/es5-ext/array/#/fill/index.js
M node_modules/es5-ext/array/#/fill/is-implemented.js
M node_modules/es5-ext/array/#/fill/shim.js
M node_modules/es5-ext/array/#/filter/implement.js
M node_modules/es5-ext/array/#/filter/index.js
M node_modules/es5-ext/array/#/filter/is-implemented.js
M node_modules/es5-ext/array/#/filter/shim.js
M node_modules/es5-ext/array/#/find-index/implement.js
M node_modules/es5-ext/array/#/find-index/index.js
M node_modules/es5-ext/array/#/find-index/is-implemented.js
M node_modules/es5-ext/array/#/find-index/shim.js
M node_modules/es5-ext/array/#/find/implement.js
M node_modules/es5-ext/array/#/find/index.js
M node_modules/es5-ext/array/#/find/is-implemented.js
M node_modules/es5-ext/array/#/find/shim.js
M node_modules/es5-ext/array/#/first-index.js
M node_modules/es5-ext/array/#/first.js
M node_modules/es5-ext/array/#/flatten.js
M node_modules/es5-ext/array/#/for-each-right.js
M node_modules/es5-ext/array/#/group.js
M node_modules/es5-ext/array/#/index.js
M node_modules/es5-ext/array/#/indexes-of.js
M node_modules/es5-ext/array/#/intersection.js
M node_modules/es5-ext/array/#/is-copy.js
M node_modules/es5-ext/array/#/is-uniq.js
M node_modules/es5-ext/array/#/keys/implement.js
M node_modules/es5-ext/array/#/keys/index.js
M node_modules/es5-ext/array/#/keys/is-implemented.js
M node_modules/es5-ext/array/#/keys/shim.js
M node_modules/es5-ext/array/#/last-index.js
M node_modules/es5-ext/array/#/last.js
M node_modules/es5-ext/array/#/map/implement.js
M node_modules/es5-ext/array/#/map/index.js
M node_modules/es5-ext/array/#/map/is-implemented.js
M node_modules/es5-ext/array/#/map/shim.js
M node_modules/es5-ext/array/#/remove.js
M node_modules/es5-ext/array/#/separate.js
M node_modules/es5-ext/array/#/slice/implement.js
M node_modules/es5-ext/array/#/slice/index.js
M node_modules/es5-ext/array/#/slice/is-implemented.js
M node_modules/es5-ext/array/#/slice/shim.js
M node_modules/es5-ext/array/#/some-right.js
M node_modules/es5-ext/array/#/splice/implement.js
M node_modules/es5-ext/array/#/splice/index.js
M node_modules/es5-ext/array/#/splice/is-implemented.js
M node_modules/es5-ext/array/#/splice/shim.js
M node_modules/es5-ext/array/#/uniq.js
M node_modules/es5-ext/array/#/values/implement.js
M node_modules/es5-ext/array/#/values/index.js
M node_modules/es5-ext/array/#/values/is-implemented.js
M node_modules/es5-ext/array/#/values/shim.js
M node_modules/es5-ext/array/_is-extensible.js
M node_modules/es5-ext/array/_sub-array-dummy-safe.js
M node_modules/es5-ext/array/_sub-array-dummy.js
M node_modules/es5-ext/array/from/implement.js
M node_modules/es5-ext/array/from/index.js
M node_modules/es5-ext/array/from/is-implemented.js
M node_modules/es5-ext/array/from/shim.js
M node_modules/es5-ext/array/generate.js
M 

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Update cxserver to 8278e44

[Mobrovac (Code Review)]

Mobrovac has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/367745 )

Change subject: Update cxserver to 8278e44
..


Update cxserver to 8278e44

List of changes:
8278e44 Switch to Node v6.11
xxx Update node module dependencies

Change-Id: If08ed41648559eb0e23a867d2099905eda66dd2e
---
M node_modules/ajv/dist/ajv.bundle.js
M node_modules/ajv/dist/ajv.min.js
M node_modules/ajv/dist/ajv.min.js.map
M node_modules/ajv/dist/nodent.min.js
M node_modules/ajv/dist/regenerator.min.js
M node_modules/ajv/lib/ajv.d.ts
M node_modules/ajv/lib/compile/formats.js
M node_modules/ajv/lib/dot/custom.jst
M node_modules/ajv/lib/dot/validate.jst
M node_modules/ajv/lib/dotjs/anyOf.js
M node_modules/ajv/lib/dotjs/constant.js
M node_modules/ajv/lib/dotjs/custom.js
M node_modules/ajv/lib/dotjs/dependencies.js
M node_modules/ajv/lib/dotjs/enum.js
M node_modules/ajv/lib/dotjs/format.js
M node_modules/ajv/lib/dotjs/items.js
M node_modules/ajv/lib/dotjs/multipleOf.js
M node_modules/ajv/lib/dotjs/not.js
M node_modules/ajv/lib/dotjs/oneOf.js
M node_modules/ajv/lib/dotjs/pattern.js
M node_modules/ajv/lib/dotjs/patternRequired.js
M node_modules/ajv/lib/dotjs/properties.js
M node_modules/ajv/lib/dotjs/ref.js
M node_modules/ajv/lib/dotjs/required.js
M node_modules/ajv/lib/dotjs/switch.js
M node_modules/ajv/lib/dotjs/uniqueItems.js
M node_modules/ajv/lib/dotjs/validate.js
M node_modules/ajv/package.json
M node_modules/ajv/scripts/compile-dots.js
M node_modules/ajv/scripts/travis-gh-pages
M node_modules/asap/package.json
M node_modules/balanced-match/index.js
M node_modules/balanced-match/package.json
M node_modules/bl/bl.js
M node_modules/bl/package.json
M node_modules/bl/test/test.js
M node_modules/body-parser/lib/read.js
M node_modules/body-parser/package.json
M node_modules/brace-expansion/index.js
M node_modules/brace-expansion/package.json
D node_modules/buffer-shims/index.js
D node_modules/buffer-shims/package.json
M node_modules/bunyan/bin/bunyan
M node_modules/bunyan/lib/bunyan.js
M node_modules/bunyan/package.json
M node_modules/compressible/package.json
M node_modules/compression/index.js
M node_modules/compression/node_modules/bytes/index.js
M node_modules/compression/node_modules/bytes/package.json
R node_modules/compression/node_modules/debug/.coveralls.yml
R node_modules/compression/node_modules/debug/.eslintrc
D node_modules/compression/node_modules/debug/.jshintrc
M node_modules/compression/node_modules/debug/.npmignore
R node_modules/compression/node_modules/debug/.travis.yml
R node_modules/compression/node_modules/debug/LICENSE
M node_modules/compression/node_modules/debug/Makefile
D node_modules/compression/node_modules/debug/bower.json
D node_modules/compression/node_modules/debug/browser.js
M node_modules/compression/node_modules/debug/component.json
D node_modules/compression/node_modules/debug/debug.js
R node_modules/compression/node_modules/debug/karma.conf.js
M node_modules/compression/node_modules/debug/node.js
M node_modules/compression/node_modules/debug/package.json
R node_modules/compression/node_modules/debug/src/browser.js
R node_modules/compression/node_modules/debug/src/debug.js
R node_modules/compression/node_modules/debug/src/index.js
R node_modules/compression/node_modules/debug/src/node.js
D node_modules/compression/node_modules/ms/.npmignore
D node_modules/compression/node_modules/ms/LICENSE
D node_modules/compression/node_modules/ms/index.js
D node_modules/compression/node_modules/ms/package.json
M node_modules/compression/package.json
M node_modules/debug/.npmignore
D node_modules/debug/bower.json
M node_modules/debug/component.json
M node_modules/debug/package.json
M node_modules/debug/src/browser.js
M node_modules/debug/src/debug.js
M node_modules/debug/src/node.js
M node_modules/dtrace-provider/libusdt/Makefile
M node_modules/dtrace-provider/package.json
M node_modules/dtrace-provider/scripts/install.js
M node_modules/esprima/ChangeLog
M node_modules/esprima/bin/esvalidate.js
M node_modules/esprima/dist/esprima.js
M node_modules/esprima/package.json
M node_modules/express/lib/application.js
M node_modules/express/lib/middleware/init.js
M node_modules/express/lib/response.js
M node_modules/express/package.json
M node_modules/extend/.eslintrc
M node_modules/extend/.jscs.json
M node_modules/extend/.travis.yml
M node_modules/extend/index.js
M node_modules/extend/package.json
D node_modules/finalhandler/node_modules/debug/.npmignore
D node_modules/finalhandler/node_modules/debug/Makefile
D node_modules/finalhandler/node_modules/debug/bower.json
D node_modules/finalhandler/node_modules/debug/component.json
D node_modules/finalhandler/node_modules/debug/node.js
D node_modules/finalhandler/node_modules/debug/package.json
M node_modules/finalhandler/package.json
M node_modules/form-data/lib/form_data.js
M node_modules/form-data/package.json
M node_modules/getpass/package.json
M 

[MediaWiki-commits] [Gerrit] mediawiki...citoid[master]: Switch to Node v6.11; release v0.5.3

[Mobrovac (Code Review)]

Mobrovac has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/367728 )

Change subject: Switch to Node v6.11; release v0.5.3
..


Switch to Node v6.11; release v0.5.3

Change-Id: I13bb8ae81cd9469117cfe916be07ab3aafb2ff8c
---
M package.json
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Mobrovac: Verified; Looks good to me, approved
  jenkins-bot: Verified



diff --git a/package.json b/package.json
index da66aad..a32b331 100644
--- a/package.json
+++ b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "citoid",
-  "version": "0.5.2",
+  "version": "0.5.3",
   "description": "Converts search terms such as URL or DOI into citations.",
   "homepage": "https://www.mediawiki.org/wiki/Citoid;,
   "license": "Apache-2.0",
@@ -43,7 +43,7 @@
   },
   "deploy": {
 "target": "debian",
-"node": "6.9.1",
+"node": "6.11.1",
 "dependencies": {
   "_all": []
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/367728
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I13bb8ae81cd9469117cfe916be07ab3aafb2ff8c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/citoid
Gerrit-Branch: master
Gerrit-Owner: Mobrovac 
Gerrit-Reviewer: Mobrovac 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...electron-render[master]: Switch to Node v6.11

[Mobrovac (Code Review)]

Mobrovac has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/367727 )

Change subject: Switch to Node v6.11
..


Switch to Node v6.11

Bug: T170548
Change-Id: Ica43cd9bc32430f4c5c228e51dcd044a49b2a727
---
M package.json
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Mobrovac: Verified; Looks good to me, approved



diff --git a/package.json b/package.json
index b35183b..60103c8 100644
--- a/package.json
+++ b/package.json
@@ -44,7 +44,7 @@
   },
   "deploy": {
 "target": "debian",
-"node": "6.9.1",
+"node": "6.11.1",
 "dependencies": {
   "_all": []
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/367727
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ica43cd9bc32430f4c5c228e51dcd044a49b2a727
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/electron-render
Gerrit-Branch: master
Gerrit-Owner: Mobrovac 
Gerrit-Reviewer: Mobrovac 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...citoid[master]: Switch to Node v6.11; release v0.5.3

[Mobrovac (Code Review)]

Mobrovac has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/367728 )

Change subject: Switch to Node v6.11; release v0.5.3
..

Switch to Node v6.11; release v0.5.3

Change-Id: I13bb8ae81cd9469117cfe916be07ab3aafb2ff8c
---
M package.json
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/citoid 
refs/changes/28/367728/1

diff --git a/package.json b/package.json
index da66aad..a32b331 100644
--- a/package.json
+++ b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "citoid",
-  "version": "0.5.2",
+  "version": "0.5.3",
   "description": "Converts search terms such as URL or DOI into citations.",
   "homepage": "https://www.mediawiki.org/wiki/Citoid;,
   "license": "Apache-2.0",
@@ -43,7 +43,7 @@
   },
   "deploy": {
 "target": "debian",
-"node": "6.9.1",
+"node": "6.11.1",
 "dependencies": {
   "_all": []
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/367728
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I13bb8ae81cd9469117cfe916be07ab3aafb2ff8c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/citoid
Gerrit-Branch: master
Gerrit-Owner: Mobrovac 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...electron-render[master]: Switch to Node v6.11

[Mobrovac (Code Review)]

Mobrovac has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/367727 )

Change subject: Switch to Node v6.11
..

Switch to Node v6.11

Bug: T170548
Change-Id: Ica43cd9bc32430f4c5c228e51dcd044a49b2a727
---
M package.json
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/electron-render 
refs/changes/27/367727/1

diff --git a/package.json b/package.json
index b35183b..60103c8 100644
--- a/package.json
+++ b/package.json
@@ -44,7 +44,7 @@
   },
   "deploy": {
 "target": "debian",
-"node": "6.9.1",
+"node": "6.11.1",
 "dependencies": {
   "_all": []
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/367727
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ica43cd9bc32430f4c5c228e51dcd044a49b2a727
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/electron-render
Gerrit-Branch: master
Gerrit-Owner: Mobrovac 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...citoid[master]: Try to improve performance with pubmed

[Mobrovac (Code Review)]

Mobrovac has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/363593 )

Change subject: Try to improve performance with pubmed
..


Try to improve performance with pubmed

Adds config option to not request pubmed
after every request.

If pubmed: true, then lib/Exporter will wait for the initial
request for additional identifiers (if made) and attempt
to make a new request for identifiers later if not made.

If pubmed: false, then the identifiers are requested
at the beginning of the request, when the DOI
is known either because the DOI, PMID or PMCID was
initially requested or was found from the URL.
We do not wait for the pubmed request to
complete, so if the request takes longer than the time it
takes to finish filling in the citation from other sources,
then we simply return without it.

Bug: T162886
Change-Id: I6b5a381ed46cef6958cb2dcd37504f2bbc41eff1
---
M app.js
M config.dev.yaml
M config.prod.yaml
M lib/Citation.js
M lib/CitoidService.js
M lib/Exporter.js
A test/features/scraping/noPubmed.js
M test/features/scraping/zotero.js
8 files changed, 398 insertions(+), 37 deletions(-)

Approvals:
  Mobrovac: Verified; Looks good to me, approved
  jenkins-bot: Verified



diff --git a/app.js b/app.js
index 90c2b9c..255a5df 100644
--- a/app.js
+++ b/app.js
@@ -43,9 +43,9 @@
 if(!app.conf.userAgent) { app.conf.userAgent = 'Citoid/' + 
app.info.version; }
 
 // backwards compatibility for configurations which predate use of 
'zotero' keyword in conf
-if (typeof app.conf.zotero === 'undefined') {
-app.conf.zotero = true;
-}
+if (app.conf.zotero === undefined) {app.conf.zotero = true;}
+// backwards compatibility for configurations which predate use of 
'pubmed' keyword in conf
+if (app.conf.pubmed === undefined){app.conf.pubmed = true;}
 
 // ensure sane defaults for Zotero
 if (app.conf.zotero) {
diff --git a/config.dev.yaml b/config.dev.yaml
index 6dac9ac..57e6557 100644
--- a/config.dev.yaml
+++ b/config.dev.yaml
@@ -65,6 +65,8 @@
   userAgent: null
   # enable use of zotero's translation-server service to query for URLs; 
defaults to true if undefined
   zotero: true
+  # enable use of NIH PubMed id converter to add pmids and pmcids to 
citations at the end of a request; defaults to true if undefined
+  pubmed: false
   # URL where to contact Zotero
   zoteroInterface: 127.0.0.1
   # zotero's server port
diff --git a/config.prod.yaml b/config.prod.yaml
index 9161279..4e671b6 100644
--- a/config.prod.yaml
+++ b/config.prod.yaml
@@ -65,6 +65,8 @@
 
   # enable use of zotero's translation-server service to query for URLs; 
defaults to true if undefined
   zotero: true
+  # enable use of NIH PubMed id converted to add pmids and pmcids to 
citations at the end of a request; defaults to true if undefined
+  pubmed: false
   # URL where to contact Zotero
   zoteroInterface: 127.0.0.1
   # zotero's server port
diff --git a/lib/Citation.js b/lib/Citation.js
index 6a58812..f6a4ae0 100644
--- a/lib/Citation.js
+++ b/lib/Citation.js
@@ -21,6 +21,10 @@
 this.pmid = (this.idType === 'pmid') ? this.idValue : null;
 this.isbn = (this.idType === 'isbn') ? this.idValue : null;
 
+// Whether or not PubMed data has been requested yet.
+// Either false or a Promise
+this.hasRequestedPubMed = false;
+
 this.content = {}; // Initialise empty object for fields
 this.format = null; // Target format
 this.formattedContent = {}; // Content translated into targeted format
diff --git a/lib/CitoidService.js b/lib/CitoidService.js
index b41f68e..97666e2 100644
--- a/lib/CitoidService.js
+++ b/lib/CitoidService.js
@@ -13,10 +13,11 @@
 var urlParse = require('url');
 
 /* Import Local Modules */
+var AddressError = require('./hostIsAllowed').AddressError;
 var Citation = require('./Citation.js');
 var CitoidRequest = require('./CitoidRequest.js');
+var fetchPubMedIDs = require('./Exporter.js').fetchPubMedIDs;
 var hostIsAllowed = require('./hostIsAllowed').hostIsAllowed;
-var AddressError = require('./hostIsAllowed').AddressError;
 var pubMedRequest = require('./pubMedRequest.js');
 var unshorten = require('./unshorten.js');
 var WorldCatService = require('./WorldCatService.js');
@@ -28,14 +29,19 @@
 var JSONReader = require('./JSONReader.js');
 var XMLReader = require('./XMLReader.js');
 
+var defaultLogger;
+var userAgent;
+
 /**
  * Constructor for CitoidService object
  * @param {Object} app   Express object containing logger, stats, conf
  */
 function CitoidService(app) {
 
-this.userAgent = app.conf.userAgent;
-this.logger = app.logger;
+this.pubmed = app.conf.pubmed;
+
+this.userAgent = userAgent = app.conf.userAgent;
+this.logger = defaultLogger = app.logger;
 this.stats = app.metrics;
 this.conf = app.conf;
 
@@ -225,6 +231,12 @@
 citation.format = cr.format;
 

[MediaWiki-commits] [Gerrit] mediawiki...recommendation-api[master]: Switch to Node v6.11

[Mobrovac (Code Review)]

Mobrovac has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/367725 )

Change subject: Switch to Node v6.11
..


Switch to Node v6.11

Bug: T170548
Change-Id: I2b078fa3e183eb0d5f3cf5388613b684ab544327
---
M package.json
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Mobrovac: Verified; Looks good to me, approved



diff --git a/package.json b/package.json
index bc84f96..2a614a7 100644
--- a/package.json
+++ b/package.json
@@ -58,7 +58,7 @@
   },
   "deploy": {
 "target": "debian",
-"node": "6.9.1",
+"node": "6.11.1",
 "dependencies": {
   "_all": []
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/367725
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2b078fa3e183eb0d5f3cf5388613b684ab544327
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/recommendation-api
Gerrit-Branch: master
Gerrit-Owner: Mobrovac 
Gerrit-Reviewer: Mobrovac 
Gerrit-Reviewer: Nschaaf 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...trending-edits[master]: Switch to Node v6.11

[Mobrovac (Code Review)]

Mobrovac has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/367724 )

Change subject: Switch to Node v6.11
..


Switch to Node v6.11

Bug: T170548
Change-Id: Ib59367f89e521501f8b86c58455cbc21155e53bf
---
M package.json
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Mobrovac: Verified; Looks good to me, approved



diff --git a/package.json b/package.json
index f6525d1..6a5b000 100644
--- a/package.json
+++ b/package.json
@@ -46,7 +46,7 @@
 "nsp": "^2.6.1"
   },
   "deploy": {
-"node": "6.9.1",
+"node": "6.11.1",
 "target": "debian",
 "env": {
   "BUILD_LIBRDKAFKA": "0"

-- 
To view, visit https://gerrit.wikimedia.org/r/367724
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib59367f89e521501f8b86c58455cbc21155e53bf
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/trending-edits
Gerrit-Branch: master
Gerrit-Owner: Mobrovac 
Gerrit-Reviewer: BearND 
Gerrit-Reviewer: Jdlrobson 
Gerrit-Reviewer: Mobrovac 
Gerrit-Reviewer: Niedzielski 
Gerrit-Reviewer: Ppchelko 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...recommendation-api[master]: Switch to Node v6.11

[Mobrovac (Code Review)]

Mobrovac has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/367725 )

Change subject: Switch to Node v6.11
..

Switch to Node v6.11

Bug: T170548
Change-Id: I2b078fa3e183eb0d5f3cf5388613b684ab544327
---
M package.json
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/services/recommendation-api 
refs/changes/25/367725/1

diff --git a/package.json b/package.json
index bc84f96..2a614a7 100644
--- a/package.json
+++ b/package.json
@@ -58,7 +58,7 @@
   },
   "deploy": {
 "target": "debian",
-"node": "6.9.1",
+"node": "6.11.1",
 "dependencies": {
   "_all": []
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/367725
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2b078fa3e183eb0d5f3cf5388613b684ab544327
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/recommendation-api
Gerrit-Branch: master
Gerrit-Owner: Mobrovac 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...trending-edits[master]: Switch to Node v6.11

[Mobrovac (Code Review)]

Mobrovac has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/367724 )

Change subject: Switch to Node v6.11
..

Switch to Node v6.11

Bug: T170548
Change-Id: Ib59367f89e521501f8b86c58455cbc21155e53bf
---
M package.json
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/trending-edits 
refs/changes/24/367724/1

diff --git a/package.json b/package.json
index f6525d1..6a5b000 100644
--- a/package.json
+++ b/package.json
@@ -46,7 +46,7 @@
 "nsp": "^2.6.1"
   },
   "deploy": {
-"node": "6.9.1",
+"node": "6.11.1",
 "target": "debian",
 "env": {
   "BUILD_LIBRDKAFKA": "0"

-- 
To view, visit https://gerrit.wikimedia.org/r/367724
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib59367f89e521501f8b86c58455cbc21155e53bf
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/trending-edits
Gerrit-Branch: master
Gerrit-Owner: Mobrovac 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Switch to Node v6.11

[Mobrovac (Code Review)]

Mobrovac has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/367723 )

Change subject: Switch to Node v6.11
..


Switch to Node v6.11

Bug: T170548
Change-Id: Ifb679f7f530cf9e3bc9c8a38fa99b2511bca58ad
---
M package.json
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Mobrovac: Verified; Looks good to me, approved



diff --git a/package.json b/package.json
index df94a4f..ace1ab6 100644
--- a/package.json
+++ b/package.json
@@ -76,7 +76,7 @@
   },
   "deploy": {
 "target": "debian",
-"node": "6.9.1",
+"node": "6.11.1",
 "dependencies": {
   "_all": []
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/367723
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifb679f7f530cf9e3bc9c8a38fa99b2511bca58ad
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/mobileapps
Gerrit-Branch: master
Gerrit-Owner: Mobrovac 
Gerrit-Reviewer: BearND 
Gerrit-Reviewer: Mobrovac 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...mathoid[master]: Switch to Node v6.11; release v0.6.5

[Mobrovac (Code Review)]

Mobrovac has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/367722 )

Change subject: Switch to Node v6.11; release v0.6.5
..


Switch to Node v6.11; release v0.6.5

Bug: T170548
Change-Id: I3b1595a0e4fc434c79f585f1e83e3fd1cb694e30
---
M package.json
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Mobrovac: Verified; Looks good to me, approved



diff --git a/package.json b/package.json
index fb10bbf..5852b21 100644
--- a/package.json
+++ b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "mathoid",
-  "version": "0.6.4",
+  "version": "0.6.5",
   "description": "Render TeX to SVG and MathML using MathJax. Based on 
svgtex.",
   "main": "./app.js",
   "scripts": {
@@ -67,7 +67,7 @@
 "node": ">=4"
   },
   "deploy": {
-"node": "6.9.1",
+"node": "6.11.1",
 "target": "debian",
 "dependencies": {
   "_all": [

-- 
To view, visit https://gerrit.wikimedia.org/r/367722
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3b1595a0e4fc434c79f585f1e83e3fd1cb694e30
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/mathoid
Gerrit-Branch: master
Gerrit-Owner: Mobrovac 
Gerrit-Reviewer: Mobrovac 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Switch to Node v6.11

[Mobrovac (Code Review)]

Mobrovac has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/367723 )

Change subject: Switch to Node v6.11
..

Switch to Node v6.11

Bug: T170548
Change-Id: Ifb679f7f530cf9e3bc9c8a38fa99b2511bca58ad
---
M package.json
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/mobileapps 
refs/changes/23/367723/1

diff --git a/package.json b/package.json
index df94a4f..ace1ab6 100644
--- a/package.json
+++ b/package.json
@@ -76,7 +76,7 @@
   },
   "deploy": {
 "target": "debian",
-"node": "6.9.1",
+"node": "6.11.1",
 "dependencies": {
   "_all": []
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/367723
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifb679f7f530cf9e3bc9c8a38fa99b2511bca58ad
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/mobileapps
Gerrit-Branch: master
Gerrit-Owner: Mobrovac 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...mathoid[master]: Switch to Node v6.11; release v0.6.5

[Mobrovac (Code Review)]

Mobrovac has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/367722 )

Change subject: Switch to Node v6.11; release v0.6.5
..

Switch to Node v6.11; release v0.6.5

Bug: T170548
Change-Id: I3b1595a0e4fc434c79f585f1e83e3fd1cb694e30
---
M package.json
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/mathoid 
refs/changes/22/367722/1

diff --git a/package.json b/package.json
index fb10bbf..5852b21 100644
--- a/package.json
+++ b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "mathoid",
-  "version": "0.6.4",
+  "version": "0.6.5",
   "description": "Render TeX to SVG and MathML using MathJax. Based on 
svgtex.",
   "main": "./app.js",
   "scripts": {
@@ -67,7 +67,7 @@
 "node": ">=4"
   },
   "deploy": {
-"node": "6.9.1",
+"node": "6.11.1",
 "target": "debian",
 "dependencies": {
   "_all": [

-- 
To view, visit https://gerrit.wikimedia.org/r/367722
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3b1595a0e4fc434c79f585f1e83e3fd1cb694e30
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/mathoid
Gerrit-Branch: master
Gerrit-Owner: Mobrovac 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...graphoid[master]: Switch to Node v6.11

[Mobrovac (Code Review)]

Mobrovac has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/367721 )

Change subject: Switch to Node v6.11
..


Switch to Node v6.11

Bug: T170548
Change-Id: I8daee94331846da82837034e3465dca3c643ac7c
---
M package.json
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Mobrovac: Verified; Looks good to me, approved



diff --git a/package.json b/package.json
index 882a825..e911728 100644
--- a/package.json
+++ b/package.json
@@ -57,7 +57,7 @@
   },
   "deploy": {
 "target": "debian",
-"node": "6.9.1",
+"node": "6.11.1",
 "dependencies": {
   "_all": ["libcairo2-dev", "libgif-dev", "libpango1.0-dev"],
   "ubuntu": ["libjpeg62-dev"],

-- 
To view, visit https://gerrit.wikimedia.org/r/367721
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8daee94331846da82837034e3465dca3c643ac7c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/graphoid
Gerrit-Branch: master
Gerrit-Owner: Mobrovac 
Gerrit-Reviewer: Mobrovac 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...eventstreams[master]: Switch to Node v6.11

[Mobrovac (Code Review)]

Mobrovac has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/367720 )

Change subject: Switch to Node v6.11
..


Switch to Node v6.11

Bug: T170548
Change-Id: I96efbdee8df39beb12708b1d1cebcfee636717da
---
M package.json
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Mobrovac: Verified; Looks good to me, approved



diff --git a/package.json b/package.json
index baff48e..9dde51b 100644
--- a/package.json
+++ b/package.json
@@ -60,7 +60,7 @@
 "bunyan-prettystream": "^0.1.3"
   },
   "deploy": {
-"node": "6.9.1",
+"node": "6.11.1",
 "target": "debian",
 "env": {
   "BUILD_LIBRDKAFKA": "0"

-- 
To view, visit https://gerrit.wikimedia.org/r/367720
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I96efbdee8df39beb12708b1d1cebcfee636717da
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/eventstreams
Gerrit-Branch: master
Gerrit-Owner: Mobrovac 
Gerrit-Reviewer: Mobrovac 
Gerrit-Reviewer: Ottomata 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...graphoid[master]: Switch to Node v6.11

[Mobrovac (Code Review)]

Mobrovac has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/367721 )

Change subject: Switch to Node v6.11
..

Switch to Node v6.11

Bug: T170548
Change-Id: I8daee94331846da82837034e3465dca3c643ac7c
---
M package.json
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/graphoid 
refs/changes/21/367721/1

diff --git a/package.json b/package.json
index 882a825..e911728 100644
--- a/package.json
+++ b/package.json
@@ -57,7 +57,7 @@
   },
   "deploy": {
 "target": "debian",
-"node": "6.9.1",
+"node": "6.11.1",
 "dependencies": {
   "_all": ["libcairo2-dev", "libgif-dev", "libpango1.0-dev"],
   "ubuntu": ["libjpeg62-dev"],

-- 
To view, visit https://gerrit.wikimedia.org/r/367721
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8daee94331846da82837034e3465dca3c643ac7c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/graphoid
Gerrit-Branch: master
Gerrit-Owner: Mobrovac 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...eventstreams[master]: Switch to Node v6.11

[Mobrovac (Code Review)]

Mobrovac has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/367720 )

Change subject: Switch to Node v6.11
..

Switch to Node v6.11

Bug: T170548
Change-Id: I96efbdee8df39beb12708b1d1cebcfee636717da
---
M package.json
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/eventstreams 
refs/changes/20/367720/1

diff --git a/package.json b/package.json
index baff48e..9dde51b 100644
--- a/package.json
+++ b/package.json
@@ -60,7 +60,7 @@
 "bunyan-prettystream": "^0.1.3"
   },
   "deploy": {
-"node": "6.9.1",
+"node": "6.11.1",
 "target": "debian",
 "env": {
   "BUILD_LIBRDKAFKA": "0"

-- 
To view, visit https://gerrit.wikimedia.org/r/367720
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I96efbdee8df39beb12708b1d1cebcfee636717da
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/eventstreams
Gerrit-Branch: master
Gerrit-Owner: Mobrovac 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...cxserver[master]: Switch to Node v6.11

[Mobrovac (Code Review)]

Mobrovac has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/367719 )

Change subject: Switch to Node v6.11
..


Switch to Node v6.11

Bug: T170548
Change-Id: I606fcec06dfeea6337d766b5cf4a2ccf321a9755
---
M package.json
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Mobrovac: Verified; Looks good to me, approved



diff --git a/package.json b/package.json
index 9e5a11d..deb7a8f 100644
--- a/package.json
+++ b/package.json
@@ -55,7 +55,7 @@
   },
   "main": "./app.js",
   "deploy": {
-"node": "6.9.1",
+"node": "6.11.1",
 "target": "debian",
 "dependencies": {
   "_all": []

-- 
To view, visit https://gerrit.wikimedia.org/r/367719
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I606fcec06dfeea6337d766b5cf4a2ccf321a9755
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/cxserver
Gerrit-Branch: master
Gerrit-Owner: Mobrovac 
Gerrit-Reviewer: Mobrovac 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...cxserver[master]: Switch to Node v6.11

[Mobrovac (Code Review)]

Mobrovac has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/367719 )

Change subject: Switch to Node v6.11
..

Switch to Node v6.11

Bug: T170548
Change-Id: I606fcec06dfeea6337d766b5cf4a2ccf321a9755
---
M package.json
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/cxserver 
refs/changes/19/367719/1

diff --git a/package.json b/package.json
index 9e5a11d..deb7a8f 100644
--- a/package.json
+++ b/package.json
@@ -55,7 +55,7 @@
   },
   "main": "./app.js",
   "deploy": {
-"node": "6.9.1",
+"node": "6.11.1",
 "target": "debian",
 "dependencies": {
   "_all": []

-- 
To view, visit https://gerrit.wikimedia.org/r/367719
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I606fcec06dfeea6337d766b5cf4a2ccf321a9755
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/cxserver
Gerrit-Branch: master
Gerrit-Owner: Mobrovac 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Update restbase to 6176450

[Mobrovac (Code Review)]

Mobrovac has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/367712 )

Change subject: Update restbase to 6176450
..


Update restbase to 6176450

List of changes:
6176450 Use Node v6.11, update dependencies and release v0.16.8
xxx Update node module dependencies

Change-Id: I576146587deaa506ace7c6978a29807e894fdbd3
---
M node_modules/content-type/package.json
M node_modules/heapdump/build/Makefile
M 
node_modules/heapdump/build/Release/.deps/Release/obj.target/addon/src/heapdump.o.d
M node_modules/heapdump/build/addon.target.mk
M node_modules/heapdump/build/config.gypi
M node_modules/hyperswitch/package.json
M node_modules/json-stable-stringify/package.json
M node_modules/kad/package.json
M node_modules/mediawiki-title/package.json
M node_modules/mime-db/db.json
M node_modules/mime-db/package.json
M node_modules/mime-types/index.js
M node_modules/mime-types/package.json
M node_modules/restbase-mod-table-cassandra/package.json
M node_modules/semver/package.json
M node_modules/semver/semver.js
M node_modules/swagger-ui/package.json
M restbase
18 files changed, 336 insertions(+), 158 deletions(-)

Approvals:
  Mobrovac: Verified; Looks good to me, approved



diff --git a/node_modules/content-type/package.json 
b/node_modules/content-type/package.json
index 01af050..8213b75 100644
--- a/node_modules/content-type/package.json
+++ b/node_modules/content-type/package.json
@@ -49,7 +49,7 @@
 "/"
   ],
   "_resolved": 
"git+https://github.com/wikimedia/content-type.git#47b2632d0a2ee79a7d67268e2f6621becd95d05b;,
-  "_shasum": "a39631ada19096dcb9643fe34a1b6c77ec219a63",
+  "_shasum": "51f506a1c6529b74c09442b820b480d0907128b0",
   "_shrinkwrap": null,
   "_spec": 
"content-type@git+https://github.com/wikimedia/content-type.git#master;,
   "_where": "/opt/service",
diff --git a/node_modules/heapdump/build/Makefile 
b/node_modules/heapdump/build/Makefile
index 2f27e5e..6197a30 100644
--- a/node_modules/heapdump/build/Makefile
+++ b/node_modules/heapdump/build/Makefile
@@ -308,8 +308,8 @@
 endif
 
 quiet_cmd_regen_makefile = ACTION Regenerating $@
-cmd_regen_makefile = cd $(srcdir); 
/usr/local/nvm/versions/node/v6.9.1/lib/node_modules/npm/node_modules/node-gyp/gyp/gyp_main.py
 -fmake --ignore-environment "--toplevel-dir=." 
-I/opt/service/node_modules/heapdump/build/config.gypi 
-I/usr/local/nvm/versions/node/v6.9.1/lib/node_modules/npm/node_modules/node-gyp/addon.gypi
 -I/root/.node-gyp/6.9.1/include/node/common.gypi "--depth=." "-Goutput_dir=." 
"--generator-output=build" "-Dlibrary=shared_library" "-Dvisibility=default" 
"-Dnode_root_dir=/root/.node-gyp/6.9.1" 
"-Dnode_gyp_dir=/usr/local/nvm/versions/node/v6.9.1/lib/node_modules/npm/node_modules/node-gyp"
 "-Dnode_lib_file=node.lib" 
"-Dmodule_root_dir=/opt/service/node_modules/heapdump" binding.gyp
-Makefile: 
$(srcdir)/../../../../usr/local/nvm/versions/node/v6.9.1/lib/node_modules/npm/node_modules/node-gyp/addon.gypi
 $(srcdir)/build/config.gypi $(srcdir)/binding.gyp 
$(srcdir)/../../../../root/.node-gyp/6.9.1/include/node/common.gypi
+cmd_regen_makefile = cd $(srcdir); 
/usr/local/nvm/versions/node/v6.11.1/lib/node_modules/npm/node_modules/node-gyp/gyp/gyp_main.py
 -fmake --ignore-environment "--toplevel-dir=." 
-I/opt/service/node_modules/heapdump/build/config.gypi 
-I/usr/local/nvm/versions/node/v6.11.1/lib/node_modules/npm/node_modules/node-gyp/addon.gypi
 -I/root/.node-gyp/6.11.1/include/node/common.gypi "--depth=." "-Goutput_dir=." 
"--generator-output=build" "-Dlibrary=shared_library" "-Dvisibility=default" 
"-Dnode_root_dir=/root/.node-gyp/6.11.1" 
"-Dnode_gyp_dir=/usr/local/nvm/versions/node/v6.11.1/lib/node_modules/npm/node_modules/node-gyp"
 "-Dnode_lib_file=node.lib" 
"-Dmodule_root_dir=/opt/service/node_modules/heapdump" binding.gyp
+Makefile: 
$(srcdir)/../../../../usr/local/nvm/versions/node/v6.11.1/lib/node_modules/npm/node_modules/node-gyp/addon.gypi
 $(srcdir)/build/config.gypi $(srcdir)/binding.gyp 
$(srcdir)/../../../../root/.node-gyp/6.11.1/include/node/common.gypi
$(call do_cmd,regen_makefile)
 
 # "all" is a concatenation of the "all" targets from all the included
diff --git 
a/node_modules/heapdump/build/Release/.deps/Release/obj.target/addon/src/heapdump.o.d
 
b/node_modules/heapdump/build/Release/.deps/Release/obj.target/addon/src/heapdump.o.d
index f1c3bd7..575cf1b 100644
--- 
a/node_modules/heapdump/build/Release/.deps/Release/obj.target/addon/src/heapdump.o.d
+++ 
b/node_modules/heapdump/build/Release/.deps/Release/obj.target/addon/src/heapdump.o.d
@@ -1,34 +1,34 @@
-cmd_Release/obj.target/addon/src/heapdump.o := g++ 
'-DNODE_GYP_MODULE_NAME=addon' '-DUSING_UV_SHARED=1' '-DUSING_V8_SHARED=1' 
'-DV8_DEPRECATION_WARNINGS=1' '-D_LARGEFILE_SOURCE' '-D_FILE_OFFSET_BITS=64' 
'-DBUILDING_NODE_EXTENSION' -I/root/.node-gyp/6.9.1/include/node 
-I/root/.node-gyp/6.9.1/src -I/root/.node-gyp/6.9.1/deps/uv/include 

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Update restbase to dc02487

[Mobrovac (Code Review)]

Mobrovac has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/366560 )

Change subject: Update restbase to dc02487
..


Update restbase to dc02487

List of changes:
dc02487 Translation API: Bug fix: return CXServer's response

Change-Id: I25e980b18129412100396a2381f9d69a7ec2864b
---
M restbase
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Mobrovac: Verified; Looks good to me, approved



diff --git a/restbase b/restbase
index 7f4c526..dc02487 16
--- a/restbase
+++ b/restbase
@@ -1 +1 @@
-Subproject commit 7f4c526d041400bdb695412dbea083e850b1c994
+Subproject commit dc02487fc884c06a3e0aa74437ebbd08a01bbece

-- 
To view, visit https://gerrit.wikimedia.org/r/366560
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I25e980b18129412100396a2381f9d69a7ec2864b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/restbase/deploy
Gerrit-Branch: master
Gerrit-Owner: Mobrovac 
Gerrit-Reviewer: Mobrovac 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Update restbase to dc02487

[Mobrovac (Code Review)]

Mobrovac has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366560 )

Change subject: Update restbase to dc02487
..

Update restbase to dc02487

List of changes:
dc02487 Translation API: Bug fix: return CXServer's response

Change-Id: I25e980b18129412100396a2381f9d69a7ec2864b
---
M restbase
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/restbase/deploy 
refs/changes/60/366560/1

diff --git a/restbase b/restbase
index 7f4c526..dc02487 16
--- a/restbase
+++ b/restbase
@@ -1 +1 @@
-Subproject commit 7f4c526d041400bdb695412dbea083e850b1c994
+Subproject commit dc02487fc884c06a3e0aa74437ebbd08a01bbece

-- 
To view, visit https://gerrit.wikimedia.org/r/366560
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I25e980b18129412100396a2381f9d69a7ec2864b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/restbase/deploy
Gerrit-Branch: master
Gerrit-Owner: Mobrovac 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Cassandra: Switch logback-encoder to Scap3

[Mobrovac (Code Review)]

Mobrovac has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366473 )

Change subject: Cassandra: Switch logback-encoder to Scap3
..

Cassandra: Switch logback-encoder to Scap3

Bug: T116340
Change-Id: Iccc142cf6a97291e90db1bfb063543883b8bf431
Depends-On: I0726e183e494471dee6abc6d1eeb110113bad3f1
---
M hieradata/common/role/deployment.yaml
M hieradata/labs/deployment-prep/common.yaml
M hieradata/role/common/deployment_server.yaml
M modules/cassandra/manifests/logging.pp
4 files changed, 14 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/73/366473/1

diff --git a/hieradata/common/role/deployment.yaml 
b/hieradata/common/role/deployment.yaml
index 5f04ce9..80d8fa1 100644
--- a/hieradata/common/role/deployment.yaml
+++ b/hieradata/common/role/deployment.yaml
@@ -26,9 +26,6 @@
 upstream: 
https://gerrit.wikimedia.org/r/operations/software/cassandra-metrics-collector
   sentry/sentry:
 upstream: https://gerrit.wikimedia.org/r/operations/software/sentry
-  cassandra/logstash-logback-encoder:
-gitfat_enabled: true
-upstream: 
https://gerrit.wikimedia.org/r/operations/software/logstash-logback-encoder
   wikimedia/discovery/analytics:
 upstream: https://gerrit.wikimedia.org/r/wikimedia/discovery/analytics
   analytics/aqs/deploy:
diff --git a/hieradata/labs/deployment-prep/common.yaml 
b/hieradata/labs/deployment-prep/common.yaml
index d64be24..d8662f3 100644
--- a/hieradata/labs/deployment-prep/common.yaml
+++ b/hieradata/labs/deployment-prep/common.yaml
@@ -315,6 +315,10 @@
   # Recommendation API
   recommendation-api/deploy: {}
 
+  # Cassandra logback encoder for Logstash
+  cassandra/logstash-logback-encoder:
+repository: operations/software/logstash-logback-encoder
+
 prometheus_nodes:
   - deployment-prometheus01.deployment-prep.eqiad.wmflabs
 profile::recommendation_api::wdqs_uri: http://wdqs-test.wmflabs.org
diff --git a/hieradata/role/common/deployment_server.yaml 
b/hieradata/role/common/deployment_server.yaml
index 8fc5810..0612566 100644
--- a/hieradata/role/common/deployment_server.yaml
+++ b/hieradata/role/common/deployment_server.yaml
@@ -139,6 +139,9 @@
 lvs_service: zotero
   zotero/translators:
 lvs_service: zotero
+  # Cassandra logback encoder for Logstash
+  cassandra/logstash-logback-encoder:
+repository: operations/software/logstash-logback-encoder
   # Time-window compaction strategy for Cassandra
   cassandra/twcs:
 repository: operations/software/cassandra-twcs
diff --git a/modules/cassandra/manifests/logging.pp 
b/modules/cassandra/manifests/logging.pp
index cf6b597..d70ac1f 100644
--- a/modules/cassandra/manifests/logging.pp
+++ b/modules/cassandra/manifests/logging.pp
@@ -10,33 +10,33 @@
 ) {
 require ::cassandra
 
-package { 'cassandra/logstash-logback-encoder':
-ensure   => present,
-provider => 'trebuchet',
+scap::target { 'cassandra/logstash-logback-encoder':
+deploy_user => 'deploy-service',
+manage_user => true,
 }
 
 file { '/usr/share/cassandra/lib/logstash-logback-encoder.jar':
 ensure  => 'link',
 target  => 
'/srv/deployment/cassandra/logstash-logback-encoder/lib/logstash-logback-encoder-4.2.jar',
-require => Package['cassandra/logstash-logback-encoder'],
+require => Scap::Target['cassandra/logstash-logback-encoder'],
 }
 
 file { '/usr/share/cassandra/lib/jackson-annotations-2.4.0.jar':
 ensure  => 'link',
 target  => 
'/srv/deployment/cassandra/logstash-logback-encoder/lib/jackson-annotations-2.4.0.jar',
-require => Package['cassandra/logstash-logback-encoder'],
+require => Scap::Target['cassandra/logstash-logback-encoder'],
 }
 
 file { '/usr/share/cassandra/lib/jackson-core-2.4.0.jar':
 ensure  => 'link',
 target  => 
'/srv/deployment/cassandra/logstash-logback-encoder/lib/jackson-core-2.4.0.jar',
-require => Package['cassandra/logstash-logback-encoder'],
+require => Scap::Target['cassandra/logstash-logback-encoder'],
 }
 
 file { '/usr/share/cassandra/lib/jackson-databind-2.4.0.jar':
 ensure  => 'link',
 target  => 
'/srv/deployment/cassandra/logstash-logback-encoder/lib/jackson-databind-2.4.0.jar',
-require => Package['cassandra/logstash-logback-encoder'],
+require => Scap::Target['cassandra/logstash-logback-encoder'],
 }
 
 # removes unnecessary dependencies, deprecates T128787; the following code

-- 
To view, visit https://gerrit.wikimedia.org/r/366473
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iccc142cf6a97291e90db1bfb063543883b8bf431
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Mobrovac 

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Update restbase to 7f4c526

[Mobrovac (Code Review)]

Mobrovac has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366319 )

Change subject: Update restbase to 7f4c526
..

Update restbase to 7f4c526

List of changes:
52c4e09 Revert "Log a warning when revision-mismatch code actually plays out"

Change-Id: I818ed0a878c0941d70a0d9fcb34ba77820bde545
---
M restbase
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/restbase/deploy 
refs/changes/19/366319/1

diff --git a/restbase b/restbase
index a5cb2b7..7f4c526 16
--- a/restbase
+++ b/restbase
@@ -1 +1 @@
-Subproject commit a5cb2b7c18cb0c9516294bb394f589dda40830ad
+Subproject commit 7f4c526d041400bdb695412dbea083e850b1c994

-- 
To view, visit https://gerrit.wikimedia.org/r/366319
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I818ed0a878c0941d70a0d9fcb34ba77820bde545
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/restbase/deploy
Gerrit-Branch: master
Gerrit-Owner: Mobrovac 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations...logstash-logback-encoder[master]: Add the Scap3 configuration

[Mobrovac (Code Review)]

Mobrovac has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366466 )

Change subject: Add the Scap3 configuration
..

Add the Scap3 configuration

Bug: T116340
Change-Id: I0726e183e494471dee6abc6d1eeb110113bad3f1
---
A scap/environments/beta/betacluster
A scap/environments/beta/scap.cfg
A scap/environments/dev-cluster/dev-cluster
A scap/environments/dev-cluster/dev-cluster-canary
A scap/environments/dev-cluster/scap.cfg
A scap/environments/staging/scap.cfg
A scap/environments/staging/staging
A scap/environments/staging/staging-canary
A scap/scap.cfg
A scap/target-canary
A scap/targets
11 files changed, 74 insertions(+), 0 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/operations/software/logstash-logback-encoder 
refs/changes/66/366466/1

diff --git a/scap/environments/beta/betacluster 
b/scap/environments/beta/betacluster
new file mode 100644
index 000..1f41c83
--- /dev/null
+++ b/scap/environments/beta/betacluster
@@ -0,0 +1,2 @@
+deployment-restbase01.deployment-prep.eqiad.wmflabs
+deployment-restbase02.deployment-prep.eqiad.wmflabs
diff --git a/scap/environments/beta/scap.cfg b/scap/environments/beta/scap.cfg
new file mode 100644
index 000..323d650
--- /dev/null
+++ b/scap/environments/beta/scap.cfg
@@ -0,0 +1,3 @@
+[deployment-prep.eqiad.wmflabs]
+server_groups: default
+dsh_targets: betacluster
diff --git a/scap/environments/dev-cluster/dev-cluster 
b/scap/environments/dev-cluster/dev-cluster
new file mode 100644
index 000..eda5232
--- /dev/null
+++ b/scap/environments/dev-cluster/dev-cluster
@@ -0,0 +1,2 @@
+restbase-dev1002.eqiad.wmnet
+restbase-dev1003.eqiad.wmnet
diff --git a/scap/environments/dev-cluster/dev-cluster-canary 
b/scap/environments/dev-cluster/dev-cluster-canary
new file mode 100644
index 000..8e808a6
--- /dev/null
+++ b/scap/environments/dev-cluster/dev-cluster-canary
@@ -0,0 +1 @@
+restbase-dev1001.eqiad.wmnet
diff --git a/scap/environments/dev-cluster/scap.cfg 
b/scap/environments/dev-cluster/scap.cfg
new file mode 100644
index 000..0b84de0
--- /dev/null
+++ b/scap/environments/dev-cluster/scap.cfg
@@ -0,0 +1,4 @@
+[wmnet]
+server_groups: canary, default
+dsh_targets: dev-cluster
+canary_dsh_targets: dev-cluster-canary
diff --git a/scap/environments/staging/scap.cfg 
b/scap/environments/staging/scap.cfg
new file mode 100644
index 000..8e33939
--- /dev/null
+++ b/scap/environments/staging/scap.cfg
@@ -0,0 +1,4 @@
+[wmnet]
+server_groups: canary, default
+dsh_targets: staging
+canary_dsh_targets: staging-canary
diff --git a/scap/environments/staging/staging 
b/scap/environments/staging/staging
new file mode 100644
index 000..6ae57fa
--- /dev/null
+++ b/scap/environments/staging/staging
@@ -0,0 +1,5 @@
+cerium.eqiad.wmnet
+xenon.eqiad.wmnet
+restbase-test2001.codfw.wmnet
+restbase-test2002.codfw.wmnet
+restbase-test2003.codfw.wmnet
diff --git a/scap/environments/staging/staging-canary 
b/scap/environments/staging/staging-canary
new file mode 100644
index 000..d1f8136
--- /dev/null
+++ b/scap/environments/staging/staging-canary
@@ -0,0 +1 @@
+praseodymium.eqiad.wmnet
diff --git a/scap/scap.cfg b/scap/scap.cfg
new file mode 100644
index 000..719c7f9
--- /dev/null
+++ b/scap/scap.cfg
@@ -0,0 +1,28 @@
+[global]
+# the repo's name in gerrit and ops/puppet
+git_repo: cassandra/logstash-logback-encoder
+# the destination path on the target
+git_deploy_dir: /srv/deployment
+# the user that can clone the repo
+git_repo_user: deploy-service
+# the user to act as on the target server
+ssh_user: deploy-service
+# the server deployment groups
+server_groups: canary, default
+# the file name containing the target host list
+dsh_targets: targets
+# the size of each group to deploy in parallel
+group_size: 10
+# whether there are git submodules to be checked out
+git_submodules: False
+# this repository uses gitfat
+git_fat: True
+# the file name containing the list of canaries
+canary_dsh_targets: target-canary
+# we do not permit the canaries to fail
+canary_failure_limit: 0
+# the lock file to use
+lock_file: /tmp/scap.cassandra.logback-encoder.lock
+
+[deployment-prep.eqiad.wmflabs]
+environment: beta
diff --git a/scap/target-canary b/scap/target-canary
new file mode 100644
index 000..2259262
--- /dev/null
+++ b/scap/target-canary
@@ -0,0 +1,2 @@
+restbase2001.codfw.wmnet
+restbase1007.eqiad.wmnet
diff --git a/scap/targets b/scap/targets
new file mode 100644
index 000..7a8ee83
--- /dev/null
+++ b/scap/targets
@@ -0,0 +1,22 @@
+restbase1008.eqiad.wmnet
+restbase1009.eqiad.wmnet
+restbase1010.eqiad.wmnet
+restbase1011.eqiad.wmnet
+restbase1012.eqiad.wmnet
+restbase1013.eqiad.wmnet
+restbase1014.eqiad.wmnet
+restbase1015.eqiad.wmnet
+restbase1016.eqiad.wmnet
+restbase1017.eqiad.wmnet
+restbase1018.eqiad.wmnet
+restbase2002.codfw.wmnet
+restbase2003.codfw.wmnet
+restbase2004.codfw.wmnet
+restbase2005.codfw.wmnet
+restbase2006.codfw.wmnet

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Config: Add the CXServer host URI

[Mobrovac (Code Review)]

Mobrovac has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/366312 )

Change subject: Config: Add the CXServer host URI
..


Config: Add the CXServer host URI

Bug: T107914
Change-Id: I5ba53ae4d339c2d671a0f73012eec90988c8fd00
---
M scap/templates/config.yaml.j2
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Mobrovac: Verified; Looks good to me, approved



diff --git a/scap/templates/config.yaml.j2 b/scap/templates/config.yaml.j2
index b9a1949..9012345 100644
--- a/scap/templates/config.yaml.j2
+++ b/scap/templates/config.yaml.j2
@@ -104,8 +104,8 @@
   cache_control: s-maxage=600, max-age=600
   uri: <%= pdfrender_uri %>
   secret: <%= pdfrender_key %>
-translate:
-  host: <%= cxserver_uri %>
+transform:
+  cx_host: <%= cxserver_uri %>
 
 # A separate project for en.wikipedia because it is more feature-rich
 en.wikipedia.org: 

-- 
To view, visit https://gerrit.wikimedia.org/r/366312
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5ba53ae4d339c2d671a0f73012eec90988c8fd00
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/restbase/deploy
Gerrit-Branch: master
Gerrit-Owner: Mobrovac 
Gerrit-Reviewer: Mobrovac 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Cassandra: Switch metrics-collector to use Scap3

[Mobrovac (Code Review)]

Mobrovac has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366459 )

Change subject: Cassandra: Switch metrics-collector to use Scap3
..

Cassandra: Switch metrics-collector to use Scap3

Bug: T137371
Change-Id: Ib9e9c039fc35a0ca9d6492a3665ed11ed73acc8d
---
M hieradata/common/role/deployment.yaml
M hieradata/labs/deployment-prep/common.yaml
M hieradata/role/common/deployment_server.yaml
M modules/cassandra/manifests/metrics.pp
4 files changed, 11 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/59/366459/1

diff --git a/hieradata/common/role/deployment.yaml 
b/hieradata/common/role/deployment.yaml
index 5f04ce9..cd57718 100644
--- a/hieradata/common/role/deployment.yaml
+++ b/hieradata/common/role/deployment.yaml
@@ -21,9 +21,6 @@
   dropwizard/metrics:
 gitfat_enabled: true
 upstream: 
https://gerrit.wikimedia.org/r/operations/software/dropwizard-metrics
-  cassandra/metrics-collector:
-gitfat_enabled: true
-upstream: 
https://gerrit.wikimedia.org/r/operations/software/cassandra-metrics-collector
   sentry/sentry:
 upstream: https://gerrit.wikimedia.org/r/operations/software/sentry
   cassandra/logstash-logback-encoder:
diff --git a/hieradata/labs/deployment-prep/common.yaml 
b/hieradata/labs/deployment-prep/common.yaml
index d64be24..84167ed 100644
--- a/hieradata/labs/deployment-prep/common.yaml
+++ b/hieradata/labs/deployment-prep/common.yaml
@@ -315,6 +315,10 @@
   # Recommendation API
   recommendation-api/deploy: {}
 
+  # Cassandra metrics collection
+  cassandra/metrics-collector:
+repository: operations/software/cassandra-metrics-collector
+
 prometheus_nodes:
   - deployment-prometheus01.deployment-prep.eqiad.wmflabs
 profile::recommendation_api::wdqs_uri: http://wdqs-test.wmflabs.org
diff --git a/hieradata/role/common/deployment_server.yaml 
b/hieradata/role/common/deployment_server.yaml
index 8fc5810..0c3d45c 100644
--- a/hieradata/role/common/deployment_server.yaml
+++ b/hieradata/role/common/deployment_server.yaml
@@ -142,6 +142,9 @@
   # Time-window compaction strategy for Cassandra
   cassandra/twcs:
 repository: operations/software/cassandra-twcs
+  # Cassandra metrics collection
+  cassandra/metrics-collector:
+repository: operations/software/cassandra-metrics-collector
   # Prometheus JMX exporter
   prometheus/jmx_exporter:
 repository: operations/software/prometheus_jmx_exporter
diff --git a/modules/cassandra/manifests/metrics.pp 
b/modules/cassandra/manifests/metrics.pp
index ba0c477..dc9f7a4 100644
--- a/modules/cassandra/manifests/metrics.pp
+++ b/modules/cassandra/manifests/metrics.pp
@@ -57,9 +57,9 @@
 $collector_version = '4.0.1'
 }
 
-package { 'cassandra/metrics-collector':
-ensure   => present,
-provider => 'trebuchet',
+scap::target { 'cassandra/metrics-collector':
+deploy_user => 'deploy-service',
+manage_user => true,
 }
 
 file { '/etc/cassandra-metrics-collector':
@@ -87,7 +87,7 @@
 file { $collector_jar:
 ensure  => 'link',
 target  => 
"/srv/deployment/cassandra/metrics-collector/lib/cassandra-metrics-collector-${collector_version}-jar-with-dependencies.jar",
-require => Package['cassandra/metrics-collector'],
+require => Scap::Target['cassandra/metrics-collector'],
 }
 
 cron { 'cassandra-metrics-collector':

-- 
To view, visit https://gerrit.wikimedia.org/r/366459
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib9e9c039fc35a0ca9d6492a3665ed11ed73acc8d
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Mobrovac 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Update restbase to a5cb2b7

[Mobrovac (Code Review)]

Mobrovac has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/366309 )

Change subject: Update restbase to a5cb2b7
..


Update restbase to a5cb2b7

List of changes:
b8b9404 Add cassandra 3 to travis to check it out (#834)
2fa08a5 Disable sending previous content to Parsoid
b37a886 Log a warning when revision-mismatch code actually plays out
92e1366 Add the translation public API specification
aab4148 Add the /page/segmented/{title}{/revision} end point
a5cb2b7 Translation API: Add the domain-specific routes
xxx Update node module dependencies

Change-Id: I8600f564d06771c01b72a3db41dbe0412602edf3
---
M node_modules/asap/package.json
M node_modules/bl/node_modules/readable-stream/lib/_stream_readable.js
M node_modules/bl/node_modules/readable-stream/lib/_stream_writable.js
M node_modules/bl/node_modules/readable-stream/package.json
M node_modules/bl/node_modules/string_decoder/package.json
M node_modules/bl/package.json
M node_modules/content-type/package.json
M node_modules/esprima/ChangeLog
M node_modules/esprima/bin/esvalidate.js
M node_modules/esprima/dist/esprima.js
M node_modules/esprima/package.json
M node_modules/heapdump/build/Makefile
M 
node_modules/heapdump/build/Release/.deps/Release/obj.target/addon/src/heapdump.o.d
M node_modules/heapdump/build/addon.target.mk
M node_modules/heapdump/build/config.gypi
M node_modules/hosted-git-info/index.js
M node_modules/hosted-git-info/package.json
M node_modules/hyperswitch/lib/swaggerUI.js
M node_modules/hyperswitch/package.json
M node_modules/js-yaml/dist/js-yaml.js
M node_modules/js-yaml/dist/js-yaml.min.js
M node_modules/js-yaml/lib/js-yaml/dumper.js
M node_modules/js-yaml/lib/js-yaml/loader.js
M node_modules/js-yaml/package.json
M node_modules/json-stable-stringify/package.json
M node_modules/kad-fs/node_modules/readable-stream/lib/_stream_readable.js
M node_modules/kad-fs/node_modules/readable-stream/lib/_stream_writable.js
M node_modules/kad-fs/node_modules/readable-stream/package.json
M node_modules/kad-fs/node_modules/string_decoder/package.json
M node_modules/kad-memstore/node_modules/readable-stream/lib/_stream_readable.js
M node_modules/kad-memstore/node_modules/readable-stream/lib/_stream_writable.js
M node_modules/kad-memstore/node_modules/readable-stream/package.json
M node_modules/kad-memstore/node_modules/string_decoder/package.json
M node_modules/kad/package.json
M node_modules/limitation/node_modules/readable-stream/lib/_stream_readable.js
M node_modules/limitation/node_modules/readable-stream/lib/_stream_writable.js
M node_modules/limitation/node_modules/readable-stream/package.json
M node_modules/limitation/node_modules/string_decoder/package.json
M node_modules/mediawiki-title/lib/index.js
M node_modules/mediawiki-title/package.json
M node_modules/mediawiki-title/test/index.js
M node_modules/msgpack5/.travis.yml
M node_modules/msgpack5/example.js
M node_modules/msgpack5/index.js
M node_modules/msgpack5/lib/encoder.js
M node_modules/msgpack5/lib/streams.js
M node_modules/msgpack5/node_modules/readable-stream/lib/_stream_readable.js
M node_modules/msgpack5/node_modules/readable-stream/lib/_stream_writable.js
M node_modules/msgpack5/node_modules/readable-stream/package.json
M node_modules/msgpack5/node_modules/string_decoder/package.json
M node_modules/msgpack5/package.json
M node_modules/msgpack5/test/1-byte-length-buffers.js
M node_modules/msgpack5/test/1-byte-length-exts.js
M node_modules/msgpack5/test/1-byte-length-strings.js
M node_modules/msgpack5/test/15-elements-arrays.js
M node_modules/msgpack5/test/15-elements-maps.js
M node_modules/msgpack5/test/16-bits-signed-integers.js
M node_modules/msgpack5/test/16-bits-unsigned-integers.js
M node_modules/msgpack5/test/2-bytes-length-arrays.js
M node_modules/msgpack5/test/2-bytes-length-buffers.js
M node_modules/msgpack5/test/2-bytes-length-exts.js
M node_modules/msgpack5/test/2-bytes-length-maps.js
M node_modules/msgpack5/test/2-bytes-length-strings.js
M node_modules/msgpack5/test/31-chars-strings.js
M node_modules/msgpack5/test/32-bits-signed-integers.js
M node_modules/msgpack5/test/32-bits-unsigned-integers.js
M node_modules/msgpack5/test/32-bytes-strings.js
M node_modules/msgpack5/test/4-bytes-length-arrays.js
M node_modules/msgpack5/test/4-bytes-length-buffers.js
M node_modules/msgpack5/test/4-bytes-length-exts.js
M node_modules/msgpack5/test/4-bytes-length-strings.js
M node_modules/msgpack5/test/5-bits-negative-integers.js
M node_modules/msgpack5/test/64-bits-signed-integers.js
M node_modules/msgpack5/test/64-bits-unsigned-integers.js
M node_modules/msgpack5/test/7-bits-positive-integers.js
M node_modules/msgpack5/test/8-bits-positive-integers.js
M node_modules/msgpack5/test/8-bits-signed-integers.js
M node_modules/msgpack5/test/booleans.js
M node_modules/msgpack5/test/doubles.js
M node_modules/msgpack5/test/ext-custom-encode-check.js
M node_modules/msgpack5/test/fixexts.js
M 

[MediaWiki-commits] [Gerrit] operations...cassandra-metrics-collector[master]: Add the Scap configuration

[Mobrovac (Code Review)]

Mobrovac has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366404 )

Change subject: Add the Scap configuration
..

Add the Scap configuration

Bug: T137371
Change-Id: I0bea05b02d8f22d68b886cd28e58fb20362eddaf
---
A scap/environments/beta/betacluster
A scap/environments/beta/scap.cfg
A scap/environments/dev-cluster/dev-cluster
A scap/environments/dev-cluster/dev-cluster-canary
A scap/environments/dev-cluster/scap.cfg
A scap/environments/staging/scap.cfg
A scap/environments/staging/staging
A scap/environments/staging/staging-canary
A scap/scap.cfg
A scap/target-canary
A scap/targets
11 files changed, 76 insertions(+), 0 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/operations/software/cassandra-metrics-collector
 refs/changes/04/366404/1

diff --git a/scap/environments/beta/betacluster 
b/scap/environments/beta/betacluster
new file mode 100644
index 000..1f41c83
--- /dev/null
+++ b/scap/environments/beta/betacluster
@@ -0,0 +1,2 @@
+deployment-restbase01.deployment-prep.eqiad.wmflabs
+deployment-restbase02.deployment-prep.eqiad.wmflabs
diff --git a/scap/environments/beta/scap.cfg b/scap/environments/beta/scap.cfg
new file mode 100644
index 000..323d650
--- /dev/null
+++ b/scap/environments/beta/scap.cfg
@@ -0,0 +1,3 @@
+[deployment-prep.eqiad.wmflabs]
+server_groups: default
+dsh_targets: betacluster
diff --git a/scap/environments/dev-cluster/dev-cluster 
b/scap/environments/dev-cluster/dev-cluster
new file mode 100644
index 000..eda5232
--- /dev/null
+++ b/scap/environments/dev-cluster/dev-cluster
@@ -0,0 +1,2 @@
+restbase-dev1002.eqiad.wmnet
+restbase-dev1003.eqiad.wmnet
diff --git a/scap/environments/dev-cluster/dev-cluster-canary 
b/scap/environments/dev-cluster/dev-cluster-canary
new file mode 100644
index 000..8e808a6
--- /dev/null
+++ b/scap/environments/dev-cluster/dev-cluster-canary
@@ -0,0 +1 @@
+restbase-dev1001.eqiad.wmnet
diff --git a/scap/environments/dev-cluster/scap.cfg 
b/scap/environments/dev-cluster/scap.cfg
new file mode 100644
index 000..0b84de0
--- /dev/null
+++ b/scap/environments/dev-cluster/scap.cfg
@@ -0,0 +1,4 @@
+[wmnet]
+server_groups: canary, default
+dsh_targets: dev-cluster
+canary_dsh_targets: dev-cluster-canary
diff --git a/scap/environments/staging/scap.cfg 
b/scap/environments/staging/scap.cfg
new file mode 100644
index 000..8e33939
--- /dev/null
+++ b/scap/environments/staging/scap.cfg
@@ -0,0 +1,4 @@
+[wmnet]
+server_groups: canary, default
+dsh_targets: staging
+canary_dsh_targets: staging-canary
diff --git a/scap/environments/staging/staging 
b/scap/environments/staging/staging
new file mode 100644
index 000..6ae57fa
--- /dev/null
+++ b/scap/environments/staging/staging
@@ -0,0 +1,5 @@
+cerium.eqiad.wmnet
+xenon.eqiad.wmnet
+restbase-test2001.codfw.wmnet
+restbase-test2002.codfw.wmnet
+restbase-test2003.codfw.wmnet
diff --git a/scap/environments/staging/staging-canary 
b/scap/environments/staging/staging-canary
new file mode 100644
index 000..d1f8136
--- /dev/null
+++ b/scap/environments/staging/staging-canary
@@ -0,0 +1 @@
+praseodymium.eqiad.wmnet
diff --git a/scap/scap.cfg b/scap/scap.cfg
new file mode 100644
index 000..8d13405
--- /dev/null
+++ b/scap/scap.cfg
@@ -0,0 +1,30 @@
+[global]
+# the repo's name in gerrit and ops/puppet
+git_repo: cassandra/metrics-collector
+# the destination path on the target
+git_deploy_dir: /srv/deployment
+# the user that can clone the repo
+git_repo_user: deploy-service
+# the user to act as on the target server
+ssh_user: deploy-service
+# the server deployment groups
+server_groups: canary, default
+# the file name containing the target host list
+dsh_targets: targets
+# the size of each group to deploy in parallel
+group_size: 10
+# whether there are git submodules to be checked out
+git_submodules: False
+# this repository uses gitfat
+git_fat: True
+# the file name containing the list of canaries
+canary_dsh_targets: target-canary
+# the canary grop size
+canary_group_size: 1
+# we do not permit the canaries to fail
+canary_failure_limit: 0
+# the lock file to use
+lock_file: /tmp/scap.cassandra.metrics.lock
+
+[deployment-prep.eqiad.wmflabs]
+environment: beta
diff --git a/scap/target-canary b/scap/target-canary
new file mode 100644
index 000..2259262
--- /dev/null
+++ b/scap/target-canary
@@ -0,0 +1,2 @@
+restbase2001.codfw.wmnet
+restbase1007.eqiad.wmnet
diff --git a/scap/targets b/scap/targets
new file mode 100644
index 000..7a8ee83
--- /dev/null
+++ b/scap/targets
@@ -0,0 +1,22 @@
+restbase1008.eqiad.wmnet
+restbase1009.eqiad.wmnet
+restbase1010.eqiad.wmnet
+restbase1011.eqiad.wmnet
+restbase1012.eqiad.wmnet
+restbase1013.eqiad.wmnet
+restbase1014.eqiad.wmnet
+restbase1015.eqiad.wmnet
+restbase1016.eqiad.wmnet
+restbase1017.eqiad.wmnet
+restbase1018.eqiad.wmnet
+restbase2002.codfw.wmnet
+restbase2003.codfw.wmnet
+restbase2004.codfw.wmnet
+restbase2005.codfw.wmnet

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Update restbase to 7f4c526

[Mobrovac (Code Review)]

Mobrovac has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/366319 )

Change subject: Update restbase to 7f4c526
..


Update restbase to 7f4c526

List of changes:
52c4e09 Revert "Log a warning when revision-mismatch code actually plays out"

Change-Id: I818ed0a878c0941d70a0d9fcb34ba77820bde545
---
M restbase
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Mobrovac: Verified; Looks good to me, approved



diff --git a/restbase b/restbase
index a5cb2b7..7f4c526 16
--- a/restbase
+++ b/restbase
@@ -1 +1 @@
-Subproject commit a5cb2b7c18cb0c9516294bb394f589dda40830ad
+Subproject commit 7f4c526d041400bdb695412dbea083e850b1c994

-- 
To view, visit https://gerrit.wikimedia.org/r/366319
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I818ed0a878c0941d70a0d9fcb34ba77820bde545
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/restbase/deploy
Gerrit-Branch: master
Gerrit-Owner: Mobrovac 
Gerrit-Reviewer: Mobrovac 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Config: Add the CXServer host URI

[Mobrovac (Code Review)]

Mobrovac has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366312 )

Change subject: Config: Add the CXServer host URI
..

Config: Add the CXServer host URI

Bug: T107914
Change-Id: I5ba53ae4d339c2d671a0f73012eec90988c8fd00
---
M scap/templates/config.yaml.j2
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/restbase/deploy 
refs/changes/12/366312/1

diff --git a/scap/templates/config.yaml.j2 b/scap/templates/config.yaml.j2
index b9a1949..9012345 100644
--- a/scap/templates/config.yaml.j2
+++ b/scap/templates/config.yaml.j2
@@ -104,8 +104,8 @@
   cache_control: s-maxage=600, max-age=600
   uri: <%= pdfrender_uri %>
   secret: <%= pdfrender_key %>
-translate:
-  host: <%= cxserver_uri %>
+transform:
+  cx_host: <%= cxserver_uri %>
 
 # A separate project for en.wikipedia because it is more feature-rich
 en.wikipedia.org: 

-- 
To view, visit https://gerrit.wikimedia.org/r/366312
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5ba53ae4d339c2d671a0f73012eec90988c8fd00
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/restbase/deploy
Gerrit-Branch: master
Gerrit-Owner: Mobrovac 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Revert "Temporarily remove wtp2019 from the target for a mem...

[Mobrovac (Code Review)]

Mobrovac has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/366009 )

Change subject: Revert "Temporarily remove wtp2019 from the target for a 
memtest"
..


Revert "Temporarily remove wtp2019 from the target for a memtest"

This reverts commit 86c80ec3d20047bd61a2d856df7100bc6cec1aa7.

Bug: T146113
Change-Id: Iafd92a97c5c82faeb8e539e2e26c8e262f03d216
---
M scap/targets
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Mobrovac: Verified; Looks good to me, approved



diff --git a/scap/targets b/scap/targets
index 2dc1f8e..12934ef 100644
--- a/scap/targets
+++ b/scap/targets
@@ -38,4 +38,5 @@
 wtp2016.codfw.wmnet
 wtp2017.codfw.wmnet
 wtp2018.codfw.wmnet
+wtp2019.codfw.wmnet
 wtp2020.codfw.wmnet

-- 
To view, visit https://gerrit.wikimedia.org/r/366009
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iafd92a97c5c82faeb8e539e2e26c8e262f03d216
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/parsoid/deploy
Gerrit-Branch: master
Gerrit-Owner: Mobrovac 
Gerrit-Reviewer: Mobrovac 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Revert "Temporarily remove wtp2019 from the target for a mem...

[Mobrovac (Code Review)]

Mobrovac has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/366009 )

Change subject: Revert "Temporarily remove wtp2019 from the target for a 
memtest"
..

Revert "Temporarily remove wtp2019 from the target for a memtest"

This reverts commit 86c80ec3d20047bd61a2d856df7100bc6cec1aa7.

Bug: T146113
Change-Id: Iafd92a97c5c82faeb8e539e2e26c8e262f03d216
---
M scap/targets
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/parsoid/deploy 
refs/changes/09/366009/1

diff --git a/scap/targets b/scap/targets
index 2dc1f8e..12934ef 100644
--- a/scap/targets
+++ b/scap/targets
@@ -38,4 +38,5 @@
 wtp2016.codfw.wmnet
 wtp2017.codfw.wmnet
 wtp2018.codfw.wmnet
+wtp2019.codfw.wmnet
 wtp2020.codfw.wmnet

-- 
To view, visit https://gerrit.wikimedia.org/r/366009
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iafd92a97c5c82faeb8e539e2e26c8e262f03d216
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/parsoid/deploy
Gerrit-Branch: master
Gerrit-Owner: Mobrovac 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Config: Only update restbase if the revision content changed.

[Mobrovac (Code Review)]

Mobrovac has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/362453 )

Change subject: Config: Only update restbase if the revision content changed.
..


Config: Only update restbase if the revision content changed.

Change-Id: I8eab744a386200b12b1952f6d7df3faf92aad870
PR: https://github.com/wikimedia/change-propagation/pull/195
Depends-On: Ibd32ceb99bc650e3927c1bde28c05d0145fc205b
---
M scap/templates/config.yaml.j2
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Mobrovac: Verified; Looks good to me, approved



diff --git a/scap/templates/config.yaml.j2 b/scap/templates/config.yaml.j2
index aad95ab..01216e9 100644
--- a/scap/templates/config.yaml.j2
+++ b/scap/templates/config.yaml.j2
@@ -192,6 +192,8 @@
   status:
 - '5xx'
 - 404 # Sometimes occasional 404s happen because of the 
mysql replication lag, so retry
+match:
+  rev_content_changed: true
 match_not:
   - meta:
   domain: /\.wikidata\.org$/
@@ -593,6 +595,7 @@
   page_namespace: 0
   # It's impossible to modify a comment in wikidata while 
editing the entity.
   comment: '/wbeditentity|wbsetdescription|undo/'
+  rev_content_changed: true
 exec:
   method: post
   uri: '/sys/links/wikidata_descriptions'

-- 
To view, visit https://gerrit.wikimedia.org/r/362453
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8eab744a386200b12b1952f6d7df3faf92aad870
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/services/change-propagation/deploy
Gerrit-Branch: master
Gerrit-Owner: Ppchelko 
Gerrit-Reviewer: GWicke 
Gerrit-Reviewer: Mobrovac 
Gerrit-Reviewer: Ppchelko 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Update change-propagation to 9541214

[Mobrovac (Code Review)]

Mobrovac has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/365665 )

Change subject: Update change-propagation to 9541214
..


Update change-propagation to 9541214

List of changes:
d392920 Correctly normalise special pages
932398b Update the tests as well
51c5190 Generalized the deduplication as a filter
7b09463 Revert "Generalized the deduplication as a filter"
ec9a3fa Disable precachign for wikis that have ORES review tool enabled
7d98a89 Adapt the backlinks to the new page-create event
c516b94 Removed stale config
3784353 Updated the tests
6ab4e64 Extend blacklisting for derived updates
9541214 Only update when the content of the revision actually changed
xxx Update node module dependencies

Change-Id: Ic3b2c7369f9a2c1d29609bcc7e3a424550f739b7
---
M node_modules/asap/package.json
M node_modules/bl/node_modules/readable-stream/lib/_stream_readable.js
M node_modules/bl/node_modules/readable-stream/lib/_stream_writable.js
M 
node_modules/bl/node_modules/readable-stream/lib/internal/streams/BufferList.js
M node_modules/bl/node_modules/readable-stream/package.json
D 
node_modules/bl/node_modules/string_decoder/node_modules/safe-buffer/.travis.yml
D node_modules/bl/node_modules/string_decoder/node_modules/safe-buffer/LICENSE
D 
node_modules/bl/node_modules/string_decoder/node_modules/safe-buffer/browser.js
D node_modules/bl/node_modules/string_decoder/node_modules/safe-buffer/index.js
D 
node_modules/bl/node_modules/string_decoder/node_modules/safe-buffer/package.json
D node_modules/bl/node_modules/string_decoder/node_modules/safe-buffer/test.js
M node_modules/bl/node_modules/string_decoder/package.json
M node_modules/bl/package.json
M node_modules/esprima/ChangeLog
M node_modules/esprima/bin/esvalidate.js
M node_modules/esprima/dist/esprima.js
M node_modules/esprima/package.json
M node_modules/heapdump/build/Makefile
M 
node_modules/heapdump/build/Release/.deps/Release/obj.target/addon/src/heapdump.o.d
M node_modules/heapdump/build/addon.target.mk
M node_modules/heapdump/build/config.gypi
M node_modules/hosted-git-info/index.js
M node_modules/hosted-git-info/package.json
M node_modules/js-yaml/dist/js-yaml.js
M node_modules/js-yaml/dist/js-yaml.min.js
M node_modules/js-yaml/lib/js-yaml/dumper.js
M node_modules/js-yaml/lib/js-yaml/loader.js
M node_modules/js-yaml/package.json
M node_modules/kad-fs/node_modules/readable-stream/lib/_stream_readable.js
M node_modules/kad-fs/node_modules/readable-stream/lib/_stream_writable.js
M 
node_modules/kad-fs/node_modules/readable-stream/lib/internal/streams/BufferList.js
M node_modules/kad-fs/node_modules/readable-stream/package.json
D 
node_modules/kad-fs/node_modules/string_decoder/node_modules/safe-buffer/.travis.yml
D 
node_modules/kad-fs/node_modules/string_decoder/node_modules/safe-buffer/LICENSE
D 
node_modules/kad-fs/node_modules/string_decoder/node_modules/safe-buffer/browser.js
D 
node_modules/kad-fs/node_modules/string_decoder/node_modules/safe-buffer/index.js
D 
node_modules/kad-fs/node_modules/string_decoder/node_modules/safe-buffer/package.json
D 
node_modules/kad-fs/node_modules/string_decoder/node_modules/safe-buffer/test.js
M node_modules/kad-fs/node_modules/string_decoder/package.json
M node_modules/kad-fs/package.json
M node_modules/kad-memstore/node_modules/readable-stream/lib/_stream_readable.js
M node_modules/kad-memstore/node_modules/readable-stream/lib/_stream_writable.js
M 
node_modules/kad-memstore/node_modules/readable-stream/lib/internal/streams/BufferList.js
M node_modules/kad-memstore/node_modules/readable-stream/package.json
D 
node_modules/kad-memstore/node_modules/string_decoder/node_modules/safe-buffer/.travis.yml
D 
node_modules/kad-memstore/node_modules/string_decoder/node_modules/safe-buffer/LICENSE
D 
node_modules/kad-memstore/node_modules/string_decoder/node_modules/safe-buffer/browser.js
D 
node_modules/kad-memstore/node_modules/string_decoder/node_modules/safe-buffer/index.js
D 
node_modules/kad-memstore/node_modules/string_decoder/node_modules/safe-buffer/package.json
D 
node_modules/kad-memstore/node_modules/string_decoder/node_modules/safe-buffer/test.js
M node_modules/kad-memstore/node_modules/string_decoder/package.json
M node_modules/kad-memstore/package.json
M node_modules/kad/package.json
M node_modules/limitation/node_modules/readable-stream/lib/_stream_readable.js
M node_modules/limitation/node_modules/readable-stream/lib/_stream_writable.js
M 
node_modules/limitation/node_modules/readable-stream/lib/internal/streams/BufferList.js
M node_modules/limitation/node_modules/readable-stream/package.json
D 
node_modules/limitation/node_modules/string_decoder/node_modules/safe-buffer/.travis.yml
D 
node_modules/limitation/node_modules/string_decoder/node_modules/safe-buffer/LICENSE
D 
node_modules/limitation/node_modules/string_decoder/node_modules/safe-buffer/browser.js
D 

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Update change-propagation to 9541214

[Mobrovac (Code Review)]

Mobrovac has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/365665 )

Change subject: Update change-propagation to 9541214
..

Update change-propagation to 9541214

List of changes:
d392920 Correctly normalise special pages
932398b Update the tests as well
51c5190 Generalized the deduplication as a filter
7b09463 Revert "Generalized the deduplication as a filter"
ec9a3fa Disable precachign for wikis that have ORES review tool enabled
7d98a89 Adapt the backlinks to the new page-create event
c516b94 Removed stale config
3784353 Updated the tests
6ab4e64 Extend blacklisting for derived updates
9541214 Only update when the content of the revision actually changed
xxx Update node module dependencies

Change-Id: Ic3b2c7369f9a2c1d29609bcc7e3a424550f739b7
---
M node_modules/asap/package.json
M node_modules/bl/node_modules/readable-stream/lib/_stream_readable.js
M node_modules/bl/node_modules/readable-stream/lib/_stream_writable.js
M 
node_modules/bl/node_modules/readable-stream/lib/internal/streams/BufferList.js
M node_modules/bl/node_modules/readable-stream/package.json
D 
node_modules/bl/node_modules/string_decoder/node_modules/safe-buffer/.travis.yml
D node_modules/bl/node_modules/string_decoder/node_modules/safe-buffer/LICENSE
D 
node_modules/bl/node_modules/string_decoder/node_modules/safe-buffer/browser.js
D node_modules/bl/node_modules/string_decoder/node_modules/safe-buffer/index.js
D 
node_modules/bl/node_modules/string_decoder/node_modules/safe-buffer/package.json
D node_modules/bl/node_modules/string_decoder/node_modules/safe-buffer/test.js
M node_modules/bl/node_modules/string_decoder/package.json
M node_modules/bl/package.json
M node_modules/esprima/ChangeLog
M node_modules/esprima/bin/esvalidate.js
M node_modules/esprima/dist/esprima.js
M node_modules/esprima/package.json
M node_modules/heapdump/build/Makefile
M 
node_modules/heapdump/build/Release/.deps/Release/obj.target/addon/src/heapdump.o.d
M node_modules/heapdump/build/addon.target.mk
M node_modules/heapdump/build/config.gypi
M node_modules/hosted-git-info/index.js
M node_modules/hosted-git-info/package.json
M node_modules/js-yaml/dist/js-yaml.js
M node_modules/js-yaml/dist/js-yaml.min.js
M node_modules/js-yaml/lib/js-yaml/dumper.js
M node_modules/js-yaml/lib/js-yaml/loader.js
M node_modules/js-yaml/package.json
M node_modules/kad-fs/node_modules/readable-stream/lib/_stream_readable.js
M node_modules/kad-fs/node_modules/readable-stream/lib/_stream_writable.js
M 
node_modules/kad-fs/node_modules/readable-stream/lib/internal/streams/BufferList.js
M node_modules/kad-fs/node_modules/readable-stream/package.json
D 
node_modules/kad-fs/node_modules/string_decoder/node_modules/safe-buffer/.travis.yml
D 
node_modules/kad-fs/node_modules/string_decoder/node_modules/safe-buffer/LICENSE
D 
node_modules/kad-fs/node_modules/string_decoder/node_modules/safe-buffer/browser.js
D 
node_modules/kad-fs/node_modules/string_decoder/node_modules/safe-buffer/index.js
D 
node_modules/kad-fs/node_modules/string_decoder/node_modules/safe-buffer/package.json
D 
node_modules/kad-fs/node_modules/string_decoder/node_modules/safe-buffer/test.js
M node_modules/kad-fs/node_modules/string_decoder/package.json
M node_modules/kad-fs/package.json
M node_modules/kad-memstore/node_modules/readable-stream/lib/_stream_readable.js
M node_modules/kad-memstore/node_modules/readable-stream/lib/_stream_writable.js
M 
node_modules/kad-memstore/node_modules/readable-stream/lib/internal/streams/BufferList.js
M node_modules/kad-memstore/node_modules/readable-stream/package.json
D 
node_modules/kad-memstore/node_modules/string_decoder/node_modules/safe-buffer/.travis.yml
D 
node_modules/kad-memstore/node_modules/string_decoder/node_modules/safe-buffer/LICENSE
D 
node_modules/kad-memstore/node_modules/string_decoder/node_modules/safe-buffer/browser.js
D 
node_modules/kad-memstore/node_modules/string_decoder/node_modules/safe-buffer/index.js
D 
node_modules/kad-memstore/node_modules/string_decoder/node_modules/safe-buffer/package.json
D 
node_modules/kad-memstore/node_modules/string_decoder/node_modules/safe-buffer/test.js
M node_modules/kad-memstore/node_modules/string_decoder/package.json
M node_modules/kad-memstore/package.json
M node_modules/kad/package.json
M node_modules/limitation/node_modules/readable-stream/lib/_stream_readable.js
M node_modules/limitation/node_modules/readable-stream/lib/_stream_writable.js
M 
node_modules/limitation/node_modules/readable-stream/lib/internal/streams/BufferList.js
M node_modules/limitation/node_modules/readable-stream/package.json
D 
node_modules/limitation/node_modules/string_decoder/node_modules/safe-buffer/.travis.yml
D 
node_modules/limitation/node_modules/string_decoder/node_modules/safe-buffer/LICENSE
D 
node_modules/limitation/node_modules/string_decoder/node_modules/safe-buffer/browser.js
D 

[MediaWiki-commits] [Gerrit] mediawiki...mathoid[master]: Add node version requirement >= 4

[Mobrovac (Code Review)]

Mobrovac has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/365513 )

Change subject: Add node version requirement >= 4
..


Add node version requirement >= 4

Added at package.json.

Change-Id: I3eadf9c193de7127db0437a387a6050eed25265a
---
M package.json
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Mobrovac: Verified; Looks good to me, approved



diff --git a/package.json b/package.json
index b834376..fb10bbf 100644
--- a/package.json
+++ b/package.json
@@ -63,6 +63,9 @@
 "rewire": "^2.5.1",
 "xmldom": "^0.1.21"
   },
+  "engines": {
+"node": ">=4"
+  },
   "deploy": {
 "node": "6.9.1",
 "target": "debian",

-- 
To view, visit https://gerrit.wikimedia.org/r/365513
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3eadf9c193de7127db0437a387a6050eed25265a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/mathoid
Gerrit-Branch: master
Gerrit-Owner: Golopotw 
Gerrit-Reviewer: Mobrovac 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Add din.wikipedia.org to RESTBase

[Mobrovac (Code Review)]

Mobrovac has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/365426 )

Change subject: Add din.wikipedia.org to RESTBase
..


Add din.wikipedia.org to RESTBase

Bug: T168518
Change-Id: Idcde93fd2c00c3426289cad3153ba0ace14eaf2a
---
M scap/vars.yaml
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Mobrovac: Verified; Looks good to me, approved



diff --git a/scap/vars.yaml b/scap/vars.yaml
index 4b9ce11..eda7525 100644
--- a/scap/vars.yaml
+++ b/scap/vars.yaml
@@ -115,6 +115,7 @@
 cy.wikipedia.org: default_project
 da.wikipedia.org: default_project
 de.wikipedia.org: default_project
+din.wikipedia.org: default_project
 diq.wikipedia.org: default_project
 dsb.wikipedia.org: default_project
 dty.wikipedia.org: default_project

-- 
To view, visit https://gerrit.wikimedia.org/r/365426
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idcde93fd2c00c3426289cad3153ba0ace14eaf2a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/restbase/deploy
Gerrit-Branch: master
Gerrit-Owner: Mobrovac 
Gerrit-Reviewer: Mobrovac 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Add din.wikipedia.org to RESTBase

[Mobrovac (Code Review)]

Mobrovac has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/365426 )

Change subject: Add din.wikipedia.org to RESTBase
..

Add din.wikipedia.org to RESTBase

Bug: T168518
Change-Id: Idcde93fd2c00c3426289cad3153ba0ace14eaf2a
---
M scap/vars.yaml
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/restbase/deploy 
refs/changes/26/365426/1

diff --git a/scap/vars.yaml b/scap/vars.yaml
index 4b9ce11..eda7525 100644
--- a/scap/vars.yaml
+++ b/scap/vars.yaml
@@ -115,6 +115,7 @@
 cy.wikipedia.org: default_project
 da.wikipedia.org: default_project
 de.wikipedia.org: default_project
+din.wikipedia.org: default_project
 diq.wikipedia.org: default_project
 dsb.wikipedia.org: default_project
 dty.wikipedia.org: default_project

-- 
To view, visit https://gerrit.wikimedia.org/r/365426
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Idcde93fd2c00c3426289cad3153ba0ace14eaf2a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/restbase/deploy
Gerrit-Branch: master
Gerrit-Owner: Mobrovac 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...recommendation-api[master]: Fix split call

[Mobrovac (Code Review)]

Mobrovac has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/365211 )

Change subject: Fix split call
..


Fix split call

Change-Id: I8e74740e7ca8cc4506b2f927f7e00d4f320b6c6a
---
M routes/translation.js
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Mobrovac: Verified; Looks good to me, approved



diff --git a/routes/translation.js b/routes/translation.js
index 158c6fd..191bed9 100644
--- a/routes/translation.js
+++ b/routes/translation.js
@@ -46,7 +46,7 @@
  * Gets the articles existing in source but missing in domain.
  */
 router.get('/articles/:source', (req, res) => {
-const target = req.params.domain.split('.', 0);
+const target = req.params.domain.split('.')[0];
 return recommend(req, res, req.params.source, target);
 });
 
@@ -56,7 +56,7 @@
  * Gets the articles existing in source but missing in domain based on seed.
  */
 router.get('/articles/:source/:seed', (req, res) => {
-const target = req.params.domain.split('.', 0);
+const target = req.params.domain.split('.')[0];
 return recommend(req, res, req.params.source, target, req.params.seed);
 });
 

-- 
To view, visit https://gerrit.wikimedia.org/r/365211
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8e74740e7ca8cc4506b2f927f7e00d4f320b6c6a
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/services/recommendation-api
Gerrit-Branch: master
Gerrit-Owner: Nschaaf 
Gerrit-Reviewer: Mobrovac 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Update recommendation-api to 5fbe070

[Mobrovac (Code Review)]

Mobrovac has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/364908 )

Change subject: Update recommendation-api to 5fbe070
..


Update recommendation-api to 5fbe070

List of changes:
5fbe070 Temporary work-around: Do not test for bad source

Change-Id: I5b35c56857b66ea047ccb3c0e82712755ee257c8
---
M src
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Mobrovac: Verified; Looks good to me, approved



diff --git a/src b/src
index c1c4606..5fbe070 16
--- a/src
+++ b/src
@@ -1 +1 @@
-Subproject commit c1c46061db3efa7b025763efa5861d7bb051e9c2
+Subproject commit 5fbe0701c81185fbbaecc023e61b0fa5f0241600

-- 
To view, visit https://gerrit.wikimedia.org/r/364908
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5b35c56857b66ea047ccb3c0e82712755ee257c8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/recommendation-api/deploy
Gerrit-Branch: master
Gerrit-Owner: Mobrovac 
Gerrit-Reviewer: Mobrovac 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Update recommendation-api to 5fbe070

[Mobrovac (Code Review)]

Mobrovac has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/364908 )

Change subject: Update recommendation-api to 5fbe070
..

Update recommendation-api to 5fbe070

List of changes:
5fbe070 Temporary work-around: Do not test for bad source

Change-Id: I5b35c56857b66ea047ccb3c0e82712755ee257c8
---
M src
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/services/recommendation-api/deploy 
refs/changes/08/364908/1

diff --git a/src b/src
index c1c4606..5fbe070 16
--- a/src
+++ b/src
@@ -1 +1 @@
-Subproject commit c1c46061db3efa7b025763efa5861d7bb051e9c2
+Subproject commit 5fbe0701c81185fbbaecc023e61b0fa5f0241600

-- 
To view, visit https://gerrit.wikimedia.org/r/364908
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5b35c56857b66ea047ccb3c0e82712755ee257c8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/recommendation-api/deploy
Gerrit-Branch: master
Gerrit-Owner: Mobrovac 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...recommendation-api[master]: Temporary work-around: Do not test for bad source

[Mobrovac (Code Review)]

Mobrovac has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/364907 )

Change subject: Temporary work-around: Do not test for bad source
..


Temporary work-around: Do not test for bad source

In production this returns a 403 instead of a 504, because we call the
MW API end point regardless of the wiki domain we are after, while
outside of production we use the wiki's domain directly in the URI.
Therefore, we cannot set a unique status code, so disable this specific
check for now.

Bug: T165760
Change-Id: I979211772161190904289a1766616b674cff58cf
---
M spec.yaml
1 file changed, 10 insertions(+), 9 deletions(-)

Approvals:
  Mobrovac: Verified; Looks good to me, approved



diff --git a/spec.yaml b/spec.yaml
index ffc925a..dfa7c22 100644
--- a/spec.yaml
+++ b/spec.yaml
@@ -107,15 +107,16 @@
 status: 200
 headers:
   content-type: application/json
-- title: bad source
-  request:
-params:
-  source: qqq
-  domain: de.wikipedia.org
-  response:
-status: 504
-headers:
-  content-type: application/json
+## TODO: Find a solution for this case
+#- title: bad source
+#  request:
+#params:
+#  source: qqq
+#  domain: de.wikipedia.org
+#  response:
+#status: 504
+#headers:
+#  content-type: application/json
 - title: bad seed
   request:
 params:

-- 
To view, visit https://gerrit.wikimedia.org/r/364907
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I979211772161190904289a1766616b674cff58cf
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/recommendation-api
Gerrit-Branch: master
Gerrit-Owner: Mobrovac 
Gerrit-Reviewer: Mobrovac 
Gerrit-Reviewer: Nschaaf 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...recommendation-api[master]: Temporary work-around: Do not test for bad source

[Mobrovac (Code Review)]

Mobrovac has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/364907 )

Change subject: Temporary work-around: Do not test for bad source
..

Temporary work-around: Do not test for bad source

In production this returns a 403 instead of a 504, because we call the
MW API end point regardless of the wiki domain we are after, while
outside of production we use the wiki's domain directly in the URI.
Therefore, we cannot set a unique status code, so disable this specific
check for now.

Bug: T165760
Change-Id: I979211772161190904289a1766616b674cff58cf
---
M spec.yaml
1 file changed, 10 insertions(+), 9 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/services/recommendation-api 
refs/changes/07/364907/1

diff --git a/spec.yaml b/spec.yaml
index ffc925a..dfa7c22 100644
--- a/spec.yaml
+++ b/spec.yaml
@@ -107,15 +107,16 @@
 status: 200
 headers:
   content-type: application/json
-- title: bad source
-  request:
-params:
-  source: qqq
-  domain: de.wikipedia.org
-  response:
-status: 504
-headers:
-  content-type: application/json
+## TODO: Find a solution for this case
+#- title: bad source
+#  request:
+#params:
+#  source: qqq
+#  domain: de.wikipedia.org
+#  response:
+#status: 504
+#headers:
+#  content-type: application/json
 - title: bad seed
   request:
 params:

-- 
To view, visit https://gerrit.wikimedia.org/r/364907
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I979211772161190904289a1766616b674cff58cf
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/recommendation-api
Gerrit-Branch: master
Gerrit-Owner: Mobrovac 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Config: No proxy and fix WDQS' URI

[Mobrovac (Code Review)]

Mobrovac has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/364902 )

Change subject: Config: No proxy and fix WDQS' URI
..

Config: No proxy and fix WDQS' URI

The service does not contact any external entities, so do not expose the
proxy setting to it at all.

The Wikidata Query Service allows POSTs only on its /sparql end point,
so use that one when querying it.

Bug: T165760
Change-Id: I1cc06cc4b3ec1175efbe734bcd2757db24a79691
---
M scap/templates/config.yaml.j2
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/services/recommendation-api/deploy 
refs/changes/02/364902/1

diff --git a/scap/templates/config.yaml.j2 b/scap/templates/config.yaml.j2
index 3dfcfc4..d3591fe 100644
--- a/scap/templates/config.yaml.j2
+++ b/scap/templates/config.yaml.j2
@@ -50,7 +50,7 @@
   # content for the CSP headers
   # csp: false  # uncomment this line to disable sending them
   # URL of the outbound proxy to use (complete with protocol)
-  proxy: <%= proxy if proxy else '' %>
+  # proxy: <%= proxy if proxy else '' %>
   # the list of domains for which not to use the proxy defined above
   # no_proxy_list:
   #   - domain1.com
@@ -83,7 +83,7 @@
 body: '{{request.body}}'
   wdqsapi_req:
 method: 'post'
-uri: <%= wdqs_uri %>
+uri: <%= wdqs_uri %>/sparql
 headers:
   user-agent: '{{user-agent}}'
 body:

-- 
To view, visit https://gerrit.wikimedia.org/r/364902
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1cc06cc4b3ec1175efbe734bcd2757db24a79691
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/recommendation-api/deploy
Gerrit-Branch: master
Gerrit-Owner: Mobrovac 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Config: No proxy and fix WDQS' URI

[Mobrovac (Code Review)]

Mobrovac has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/364902 )

Change subject: Config: No proxy and fix WDQS' URI
..


Config: No proxy and fix WDQS' URI

The service does not contact any external entities, so do not expose the
proxy setting to it at all.

The Wikidata Query Service allows POSTs only on its /sparql end point,
so use that one when querying it.

Bug: T165760
Change-Id: I1cc06cc4b3ec1175efbe734bcd2757db24a79691
---
M scap/templates/config.yaml.j2
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Mobrovac: Verified; Looks good to me, approved



diff --git a/scap/templates/config.yaml.j2 b/scap/templates/config.yaml.j2
index 3dfcfc4..d3591fe 100644
--- a/scap/templates/config.yaml.j2
+++ b/scap/templates/config.yaml.j2
@@ -50,7 +50,7 @@
   # content for the CSP headers
   # csp: false  # uncomment this line to disable sending them
   # URL of the outbound proxy to use (complete with protocol)
-  proxy: <%= proxy if proxy else '' %>
+  # proxy: <%= proxy if proxy else '' %>
   # the list of domains for which not to use the proxy defined above
   # no_proxy_list:
   #   - domain1.com
@@ -83,7 +83,7 @@
 body: '{{request.body}}'
   wdqsapi_req:
 method: 'post'
-uri: <%= wdqs_uri %>
+uri: <%= wdqs_uri %>/sparql
 headers:
   user-agent: '{{user-agent}}'
 body:

-- 
To view, visit https://gerrit.wikimedia.org/r/364902
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1cc06cc4b3ec1175efbe734bcd2757db24a79691
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/recommendation-api/deploy
Gerrit-Branch: master
Gerrit-Owner: Mobrovac 
Gerrit-Reviewer: Mobrovac 
Gerrit-Reviewer: Nschaaf 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Update recommendation-api to c1c4606

[Mobrovac (Code Review)]

Mobrovac has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/364799 )

Change subject: Update recommendation-api to c1c4606
..


Update recommendation-api to c1c4606

List of changes:
c1c4606 Add domain parameter
xxx Update node module dependencies

Change-Id: I35744d10d6914cece2179c8f88b404dd3e5cc276
---
M node_modules/asap/package.json
M node_modules/balanced-match/index.js
M node_modules/balanced-match/package.json
M node_modules/brace-expansion/package.json
D node_modules/buffer-shims/index.js
D node_modules/buffer-shims/package.json
M node_modules/compressible/package.json
M node_modules/compression/index.js
M node_modules/compression/node_modules/bytes/index.js
M node_modules/compression/node_modules/bytes/package.json
A node_modules/compression/node_modules/debug/.coveralls.yml
A node_modules/compression/node_modules/debug/.eslintrc
D node_modules/compression/node_modules/debug/.jshintrc
M node_modules/compression/node_modules/debug/.npmignore
A node_modules/compression/node_modules/debug/.travis.yml
A node_modules/compression/node_modules/debug/LICENSE
M node_modules/compression/node_modules/debug/Makefile
D node_modules/compression/node_modules/debug/bower.json
M node_modules/compression/node_modules/debug/component.json
A node_modules/compression/node_modules/debug/karma.conf.js
M node_modules/compression/node_modules/debug/node.js
M node_modules/compression/node_modules/debug/package.json
R node_modules/compression/node_modules/debug/src/browser.js
R node_modules/compression/node_modules/debug/src/debug.js
A node_modules/compression/node_modules/debug/src/index.js
A node_modules/compression/node_modules/debug/src/node.js
D node_modules/compression/node_modules/ms/.npmignore
D node_modules/compression/node_modules/ms/LICENSE
D node_modules/compression/node_modules/ms/index.js
D node_modules/compression/node_modules/ms/package.json
M node_modules/compression/package.json
M node_modules/dtrace-provider/libusdt/Makefile
M node_modules/dtrace-provider/package.json
M node_modules/dtrace-provider/scripts/install.js
M node_modules/esprima/ChangeLog
M node_modules/esprima/bin/esvalidate.js
M node_modules/esprima/dist/esprima.js
M node_modules/esprima/package.json
M node_modules/heapdump/build/Makefile
M 
node_modules/heapdump/build/Release/.deps/Release/obj.target/addon/src/heapdump.o.d
M node_modules/heapdump/build/addon.target.mk
M node_modules/heapdump/build/config.gypi
M node_modules/hosted-git-info/index.js
M node_modules/hosted-git-info/package.json
D node_modules/jodid25519/.npmignore
D node_modules/jodid25519/.travis.yml
D node_modules/jodid25519/LICENSE
D node_modules/jodid25519/almond.0
D node_modules/jodid25519/almond.1
D node_modules/jodid25519/index.js
D node_modules/jodid25519/jsdoc.json
D node_modules/jodid25519/lib/core.js
D node_modules/jodid25519/lib/curve255.js
D node_modules/jodid25519/lib/dh.js
D node_modules/jodid25519/lib/eddsa.js
D node_modules/jodid25519/lib/utils.js
D node_modules/jodid25519/package.json
M node_modules/js-yaml/dist/js-yaml.js
M node_modules/js-yaml/dist/js-yaml.min.js
M node_modules/js-yaml/lib/js-yaml/dumper.js
M node_modules/js-yaml/lib/js-yaml/loader.js
M node_modules/js-yaml/package.json
M node_modules/jsbn/package.json
M node_modules/kad/package.json
M node_modules/ms/package.json
M node_modules/normalize-package-data/lib/fixer.js
M node_modules/normalize-package-data/lib/warning_messages.json
M node_modules/normalize-package-data/package.json
M node_modules/readable-stream/.travis.yml
M node_modules/readable-stream/lib/_stream_duplex.js
M node_modules/readable-stream/lib/_stream_passthrough.js
M node_modules/readable-stream/lib/_stream_readable.js
M node_modules/readable-stream/lib/_stream_transform.js
M node_modules/readable-stream/lib/_stream_writable.js
M node_modules/readable-stream/lib/internal/streams/BufferList.js
A node_modules/readable-stream/lib/internal/streams/destroy.js
M node_modules/readable-stream/package.json
M node_modules/readable-stream/writable.js
D node_modules/safe-buffer/browser.js
M node_modules/safe-buffer/index.js
M node_modules/safe-buffer/package.json
M node_modules/safe-buffer/test.js
M node_modules/sshpk/lib/dhe.js
M node_modules/sshpk/lib/key.js
M node_modules/sshpk/lib/private-key.js
M node_modules/sshpk/package.json
M node_modules/string_decoder/package.json
M node_modules/swagger-ui/package.json
A node_modules/uuid/.eslintrc.json
D node_modules/uuid/.npmignore
D node_modules/uuid/.travis.yml
M node_modules/uuid/bin/uuid
M node_modules/uuid/lib/bytesToUuid.js
M node_modules/uuid/lib/rng-browser.js
M node_modules/uuid/lib/rng.js
A node_modules/uuid/lib/sha1-browser.js
A node_modules/uuid/lib/sha1.js
M node_modules/uuid/package.json
D node_modules/uuid/test/mocha.opts
D node_modules/uuid/test/test.js
M node_modules/uuid/v1.js
A node_modules/uuid/v5.js
M node_modules/vary/package.json
M src
104 files changed, 8,425 

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Update recommendation-api to c1c4606

[Mobrovac (Code Review)]

Mobrovac has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/364799 )

Change subject: Update recommendation-api to c1c4606
..

Update recommendation-api to c1c4606

List of changes:
c1c4606 Add domain parameter
xxx Update node module dependencies

Change-Id: I35744d10d6914cece2179c8f88b404dd3e5cc276
---
M node_modules/asap/package.json
M node_modules/balanced-match/index.js
M node_modules/balanced-match/package.json
M node_modules/brace-expansion/package.json
D node_modules/buffer-shims/index.js
D node_modules/buffer-shims/package.json
M node_modules/compressible/package.json
M node_modules/compression/index.js
M node_modules/compression/node_modules/bytes/index.js
M node_modules/compression/node_modules/bytes/package.json
A node_modules/compression/node_modules/debug/.coveralls.yml
A node_modules/compression/node_modules/debug/.eslintrc
D node_modules/compression/node_modules/debug/.jshintrc
M node_modules/compression/node_modules/debug/.npmignore
A node_modules/compression/node_modules/debug/.travis.yml
A node_modules/compression/node_modules/debug/LICENSE
M node_modules/compression/node_modules/debug/Makefile
D node_modules/compression/node_modules/debug/bower.json
M node_modules/compression/node_modules/debug/component.json
A node_modules/compression/node_modules/debug/karma.conf.js
M node_modules/compression/node_modules/debug/node.js
M node_modules/compression/node_modules/debug/package.json
R node_modules/compression/node_modules/debug/src/browser.js
R node_modules/compression/node_modules/debug/src/debug.js
A node_modules/compression/node_modules/debug/src/index.js
A node_modules/compression/node_modules/debug/src/node.js
D node_modules/compression/node_modules/ms/.npmignore
D node_modules/compression/node_modules/ms/LICENSE
D node_modules/compression/node_modules/ms/index.js
D node_modules/compression/node_modules/ms/package.json
M node_modules/compression/package.json
M node_modules/dtrace-provider/libusdt/Makefile
M node_modules/dtrace-provider/package.json
M node_modules/dtrace-provider/scripts/install.js
M node_modules/esprima/ChangeLog
M node_modules/esprima/bin/esvalidate.js
M node_modules/esprima/dist/esprima.js
M node_modules/esprima/package.json
M node_modules/heapdump/build/Makefile
M 
node_modules/heapdump/build/Release/.deps/Release/obj.target/addon/src/heapdump.o.d
M node_modules/heapdump/build/addon.target.mk
M node_modules/heapdump/build/config.gypi
M node_modules/hosted-git-info/index.js
M node_modules/hosted-git-info/package.json
D node_modules/jodid25519/.npmignore
D node_modules/jodid25519/.travis.yml
D node_modules/jodid25519/LICENSE
D node_modules/jodid25519/almond.0
D node_modules/jodid25519/almond.1
D node_modules/jodid25519/index.js
D node_modules/jodid25519/jsdoc.json
D node_modules/jodid25519/lib/core.js
D node_modules/jodid25519/lib/curve255.js
D node_modules/jodid25519/lib/dh.js
D node_modules/jodid25519/lib/eddsa.js
D node_modules/jodid25519/lib/utils.js
D node_modules/jodid25519/package.json
M node_modules/js-yaml/dist/js-yaml.js
M node_modules/js-yaml/dist/js-yaml.min.js
M node_modules/js-yaml/lib/js-yaml/dumper.js
M node_modules/js-yaml/lib/js-yaml/loader.js
M node_modules/js-yaml/package.json
M node_modules/jsbn/package.json
M node_modules/kad/package.json
M node_modules/ms/package.json
M node_modules/normalize-package-data/lib/fixer.js
M node_modules/normalize-package-data/lib/warning_messages.json
M node_modules/normalize-package-data/package.json
M node_modules/readable-stream/.travis.yml
M node_modules/readable-stream/lib/_stream_duplex.js
M node_modules/readable-stream/lib/_stream_passthrough.js
M node_modules/readable-stream/lib/_stream_readable.js
M node_modules/readable-stream/lib/_stream_transform.js
M node_modules/readable-stream/lib/_stream_writable.js
M node_modules/readable-stream/lib/internal/streams/BufferList.js
A node_modules/readable-stream/lib/internal/streams/destroy.js
M node_modules/readable-stream/package.json
M node_modules/readable-stream/writable.js
D node_modules/safe-buffer/browser.js
M node_modules/safe-buffer/index.js
M node_modules/safe-buffer/package.json
M node_modules/safe-buffer/test.js
M node_modules/sshpk/lib/dhe.js
M node_modules/sshpk/lib/key.js
M node_modules/sshpk/lib/private-key.js
M node_modules/sshpk/package.json
M node_modules/string_decoder/package.json
M node_modules/swagger-ui/package.json
A node_modules/uuid/.eslintrc.json
D node_modules/uuid/.npmignore
D node_modules/uuid/.travis.yml
M node_modules/uuid/bin/uuid
M node_modules/uuid/lib/bytesToUuid.js
M node_modules/uuid/lib/rng-browser.js
M node_modules/uuid/lib/rng.js
A node_modules/uuid/lib/sha1-browser.js
A node_modules/uuid/lib/sha1.js
M node_modules/uuid/package.json
D node_modules/uuid/test/mocha.opts
D node_modules/uuid/test/test.js
M node_modules/uuid/v1.js
A node_modules/uuid/v5.js
M node_modules/vary/package.json
M src
104 files changed, 8,425 insertions(+), 9,615 

[MediaWiki-commits] [Gerrit] mediawiki...recommendation-api[master]: Add domain parameter

[Mobrovac (Code Review)]

Mobrovac has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/364786 )

Change subject: Add domain parameter
..


Add domain parameter

Bug: T170439
Change-Id: I7bc0d4099863ed411c0961350f4aab14c1726c6b
---
M routes/translation.js
M spec.yaml
2 files changed, 20 insertions(+), 18 deletions(-)

Approvals:
  Mobrovac: Verified; Looks good to me, approved



diff --git a/routes/translation.js b/routes/translation.js
index ae10527..158c6fd 100644
--- a/routes/translation.js
+++ b/routes/translation.js
@@ -42,20 +42,22 @@
 
 
 /**
- * GET /articles/{source}/{target}
- * Gets the articles existing in source but missing in target.
+ * GET /articles/{source}
+ * Gets the articles existing in source but missing in domain.
  */
-router.get('/articles/:source/:target', (req, res) => {
-return recommend(req, res, req.params.source, req.params.target);
+router.get('/articles/:source', (req, res) => {
+const target = req.params.domain.split('.', 0);
+return recommend(req, res, req.params.source, target);
 });
 
 
 /**
- * GET /articles/{source}/{target}/{seed}
- * Gets the articles existing in source but missing in target based on seed.
+ * GET /articles/{source}/{seed}
+ * Gets the articles existing in source but missing in domain based on seed.
  */
-router.get('/articles/:source/:target/:seed', (req, res) => {
-return recommend(req, res, req.params.source, req.params.target, 
req.params.seed);
+router.get('/articles/:source/:seed', (req, res) => {
+const target = req.params.domain.split('.', 0);
+return recommend(req, res, req.params.source, target, req.params.seed);
 });
 
 
@@ -65,7 +67,7 @@
 
 return {
 path: '/translation',
-skip_domain: true,
+api_version: 1,
 router
 };
 
diff --git a/spec.yaml b/spec.yaml
index 5ea4ec0..ffc925a 100644
--- a/spec.yaml
+++ b/spec.yaml
@@ -54,14 +54,14 @@
   response:
 status: 404
   # from routes/translation.js
-  /translation/articles/{source}/{target}{/seed}:
+  /{domain}/v1/translation/articles/{source}{/seed}:
 get:
   tags:
 - Recommend
   summary: Recommend missing articles
   description: |
 Recommends articles to be translated from the source
-to the target language.
+to the domain language.
 Stability: 
[unstable](https://www.mediawiki.org/wiki/API_versioning#Unstable)
   produces:
 - applicaiton/json
@@ -71,9 +71,9 @@
   description: The source language code
   type: string
   required: true
-- name: target
+- name: domain
   in: path
-  description: The target language code
+  description: The target domain
   type: string
   required: true
 - name: seed
@@ -92,7 +92,7 @@
   request:
 params:
   source: en
-  target: de
+  domain: de.wikipedia.org
   response:
 status: 200
 headers:
@@ -101,7 +101,7 @@
   request:
 params:
   source: en
-  target: de
+  domain: de.wikipedia.org
   seed: Apple
   response:
 status: 200
@@ -111,7 +111,7 @@
   request:
 params:
   source: qqq
-  target: de
+  domain: de.wikipedia.org
   response:
 status: 504
 headers:
@@ -120,7 +120,7 @@
   request:
 params:
   source: en
-  target: de
+  domain: de.wikipedia.org
   seed: thishsouldnotreturnanyresultsfromthesearchapi
   response:
 status: 404
@@ -130,7 +130,7 @@
   request:
 params:
   source: en
-  target: de
+  domain: de.wikipedia.org
 query:
   count: -123
   response:

-- 
To view, visit https://gerrit.wikimedia.org/r/364786
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7bc0d4099863ed411c0961350f4aab14c1726c6b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/recommendation-api
Gerrit-Branch: master
Gerrit-Owner: Nschaaf 
Gerrit-Reviewer: Mobrovac 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Bug fix: Fix typos in check names

[Mobrovac (Code Review)]

Mobrovac has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/364769 )

Change subject: Bug fix: Fix typos in check names
..


Bug fix: Fix typos in check names

Bug: T165760
Change-Id: I92a9dd6c3128f2e6aeb1c70e649292b13d9fa48e
---
M scap/checks.yaml
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Mobrovac: Verified; Looks good to me, approved



diff --git a/scap/checks.yaml b/scap/checks.yaml
index beb30f0..e703342 100644
--- a/scap/checks.yaml
+++ b/scap/checks.yaml
@@ -2,13 +2,13 @@
   endpoints:
 type: nrpe
 stage: restart_service
-command: check_endpoints_recomendation_api
+command: check_endpoints_recommendation_api
   depool:
 type: command
 stage: promote
-command: depool-recomendation_api
+command: depool-recommendation-api
   repool:
 type: command
 stage: restart_service
-command: pool-recomendation_api
+command: pool-recommendation-api
 

-- 
To view, visit https://gerrit.wikimedia.org/r/364769
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I92a9dd6c3128f2e6aeb1c70e649292b13d9fa48e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/recommendation-api/deploy
Gerrit-Branch: master
Gerrit-Owner: Mobrovac 
Gerrit-Reviewer: Mobrovac 
Gerrit-Reviewer: Nschaaf 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Bug fix: Fix typos in check names

[Mobrovac (Code Review)]

Mobrovac has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/364769 )

Change subject: Bug fix: Fix typos in check names
..

Bug fix: Fix typos in check names

Bug: T165760
Change-Id: I92a9dd6c3128f2e6aeb1c70e649292b13d9fa48e
---
M scap/checks.yaml
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/services/recommendation-api/deploy 
refs/changes/69/364769/1

diff --git a/scap/checks.yaml b/scap/checks.yaml
index beb30f0..e703342 100644
--- a/scap/checks.yaml
+++ b/scap/checks.yaml
@@ -2,13 +2,13 @@
   endpoints:
 type: nrpe
 stage: restart_service
-command: check_endpoints_recomendation_api
+command: check_endpoints_recommendation_api
   depool:
 type: command
 stage: promote
-command: depool-recomendation_api
+command: depool-recommendation-api
   repool:
 type: command
 stage: restart_service
-command: pool-recomendation_api
+command: pool-recommendation-api
 

-- 
To view, visit https://gerrit.wikimedia.org/r/364769
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I92a9dd6c3128f2e6aeb1c70e649292b13d9fa48e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/recommendation-api/deploy
Gerrit-Branch: master
Gerrit-Owner: Mobrovac 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Temporarily remove wtp2019 from the target for a memtest

[Mobrovac (Code Review)]

Mobrovac has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/363689 )

Change subject: Temporarily remove wtp2019 from the target for a memtest
..

Temporarily remove wtp2019 from the target for a memtest

Bug: T146113
Change-Id: Ie7cc9d6ac9f5f23b06987624d5ffd2e41954b806
---
M scap/targets
1 file changed, 0 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/parsoid/deploy 
refs/changes/89/363689/1

diff --git a/scap/targets b/scap/targets
index 12934ef..2dc1f8e 100644
--- a/scap/targets
+++ b/scap/targets
@@ -38,5 +38,4 @@
 wtp2016.codfw.wmnet
 wtp2017.codfw.wmnet
 wtp2018.codfw.wmnet
-wtp2019.codfw.wmnet
 wtp2020.codfw.wmnet

-- 
To view, visit https://gerrit.wikimedia.org/r/363689
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie7cc9d6ac9f5f23b06987624d5ffd2e41954b806
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/parsoid/deploy
Gerrit-Branch: master
Gerrit-Owner: Mobrovac 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Update citoid to 4090f9d

[Mobrovac (Code Review)]

Mobrovac has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/363196 )

Change subject: Update citoid to 4090f9d
..


Update citoid to 4090f9d

List of changes:
f321c30 K8s: Add the Dockerfile and config for Kubernetes
e0bdcfb Remove the bad PMCID stanza from swagger spec
40b035a Fallback to crossRef for restricted URLs
7f46a41 README: add quickstart section
4090f9d Use marcXML translator in addition to dc for ISBN

Change-Id: I1b8a6081976c1f1cf7afef54e35facd86ac4527b
---
M src
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Mobrovac: Verified; Looks good to me, approved
  jenkins-bot: Verified



diff --git a/src b/src
index 6683ecd..4090f9d 16
--- a/src
+++ b/src
@@ -1 +1 @@
-Subproject commit 6683ecd661fbf438be7ed5ea926eace50903589c
+Subproject commit 4090f9dda5b0d4d7b4dc39d305f550ce39a986ee

-- 
To view, visit https://gerrit.wikimedia.org/r/363196
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1b8a6081976c1f1cf7afef54e35facd86ac4527b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/citoid/deploy
Gerrit-Branch: master
Gerrit-Owner: Mobrovac 
Gerrit-Reviewer: Mobrovac 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Update citoid to 4090f9d

[Mobrovac (Code Review)]

Mobrovac has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/363196 )

Change subject: Update citoid to 4090f9d
..

Update citoid to 4090f9d

List of changes:
f321c30 K8s: Add the Dockerfile and config for Kubernetes
e0bdcfb Remove the bad PMCID stanza from swagger spec
40b035a Fallback to crossRef for restricted URLs
7f46a41 README: add quickstart section
4090f9d Use marcXML translator in addition to dc for ISBN

Change-Id: I1b8a6081976c1f1cf7afef54e35facd86ac4527b
---
M src
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/citoid/deploy 
refs/changes/96/363196/1

diff --git a/src b/src
index 6683ecd..4090f9d 16
--- a/src
+++ b/src
@@ -1 +1 @@
-Subproject commit 6683ecd661fbf438be7ed5ea926eace50903589c
+Subproject commit 4090f9dda5b0d4d7b4dc39d305f550ce39a986ee

-- 
To view, visit https://gerrit.wikimedia.org/r/363196
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1b8a6081976c1f1cf7afef54e35facd86ac4527b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/citoid/deploy
Gerrit-Branch: master
Gerrit-Owner: Mobrovac 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...citoid[master]: Use marcXML translator in addition to dc for ISBN

[Mobrovac (Code Review)]

Mobrovac has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/355097 )

Change subject: Use marcXML translator in addition to dc for ISBN
..


Use marcXML translator in addition to dc for ISBN

Request both dublin core and marcXML data from
WorldCat, as marcXML lacks an itemType field,
and dublinCore lacks edition and publisher
fields.

Also fixes some bugs in dublin core translator
which were missing some author fields.

Add "overwriteAuthors" parameter to Translator;
this allows multiple translators to be used on a
creators field. Must be used with caution as it
make cause duplicate authors.

Fix extendGeneral method in translators/util/
which used the same key (contributors) in the
translator.

Bug: T155161
Change-Id: I58489d2959306b620f9bfa4a5bfb2a81ea7cb4a4
---
M lib/CitoidService.js
M lib/Translator.js
M lib/XMLReader.js
M lib/translators/README.md
M lib/translators/bePress.js
M lib/translators/coins.js
M lib/translators/dublinCore.js
M lib/translators/general.js
A lib/translators/marcXML.js
D lib/translators/template.js.txt
M lib/translators/util/index.js
M test/features/scraping/isbn.js
R test/features/unit/translator.js
M test/features/unit/translators/coins.js
M test/features/unit/translators/general.js
M test/features/unit/translators/util.js
16 files changed, 771 insertions(+), 183 deletions(-)

Approvals:
  Mobrovac: Verified; Looks good to me, approved
  jenkins-bot: Verified



diff --git a/lib/CitoidService.js b/lib/CitoidService.js
index 3e234c7..b41f68e 100644
--- a/lib/CitoidService.js
+++ b/lib/CitoidService.js
@@ -517,8 +517,13 @@
 citation.format = cr.format;
 citation.doi = cr.doi;
 
-var wskeyFormat = 'dc';
 var self = this;
+
+var dcXML;
+var scrapeDC;
+
+var marcXML;
+var scrapeMARC;
 
 // Set responses if below is rejected
 function reject(){
@@ -532,16 +537,38 @@
 return cr;
 }
 
-// Make request to WorldCat srn index service
-return this.worldCatService.singleRecordRequest(citation.isbn, 'isbn', 
wskeyFormat).then(
-function(body){
-return self.scrapeXML(citation, cr, body, wskeyFormat);
+dcXML = this.worldCatService.singleRecordRequest(citation.isbn, 'isbn', 
'dc');
+marcXML = this.worldCatService.singleRecordRequest(citation.isbn, 'isbn', 
'marc');
+
+// Make concurrent requests for the data in both Dublin Core and MarcXML
+return BBPromise.all([dcXML, marcXML]).then(function(results){
+
+// Promises for scraping results from each of dc and marc
+scrapeDC =  self.scrapeXML(citation, cr, results[0], 'dc', true); // 
Boolean at end allows multiple creators translators to be used within the dc 
translator
+scrapeMARC =  self.scrapeXML(citation, cr, results[1], 'marc');
+
+// Scrape dc first because it can determine type
+return scrapeDC.then(function(){
+return scrapeMARC.then(function(){
+citation.responseCode = 200;
+citation.source.push('WorldCat');
+return cr;
+},
+// If rejected by scrapeMARC, still send 200 because DC was 
successfully added
+function(){
+citation.responseCode = 200;
+citation.source.push('WorldCat');
+return cr;
+});
 },
-// Rejection handler
+// If unable to scrape DC, reject.
 function(){
-return reject();
-}
-);
+reject();
+});
+},
+function(){
+reject();
+});
 
 
 };
@@ -622,8 +649,8 @@
  * @param  {String}   wskeyFormat  Format the XML citation will come back 
in. Can be 'dc', 'marcXML', or WorldCat's native 'openSearch' format
  * @return {Object}BBPromise for CitoidRequest object
  */
-CitoidService.prototype.scrapeXML = function(citation, cr, xml, wskeyFormat){
-return this.xml.translate(citation, cr, xml, wskeyFormat);
+CitoidService.prototype.scrapeXML = function(citation, cr, xml, wskeyFormat, 
creatorOverwrite){
+return this.xml.translate(citation, cr, xml, wskeyFormat, 
creatorOverwrite);
 };
 
 module.exports = CitoidService;
diff --git a/lib/Translator.js b/lib/Translator.js
index 8a9b562..f2dd75c 100644
--- a/lib/Translator.js
+++ b/lib/Translator.js
@@ -18,21 +18,37 @@
  * specific type, and a translator specific to that metadata type
  * @param  {Object} metadata   flat metadata object (i.e. metadata.openGraph)
  * @param  {Object} translator
+ * @param  {Boolean} creatorOverwrite whether or not unique creator 
translators can be run multiply
  */
-Translator.prototype.translate = function(citation, metadata, translator){
+Translator.prototype.translate = function(citation, metadata, translator, 
creatorOverwrite){
var logger = this.logger;
 if (!translator || !metadata){return citation;}
 var property;
-

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Beta: Add deployment-sca0[34] to the mix

[Mobrovac (Code Review)]

Mobrovac has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/363062 )

Change subject: Beta: Add deployment-sca0[34] to the mix
..


Beta: Add deployment-sca0[34] to the mix

Also, increase the deployment group size in beta, since there is no
depooling/repooling going on there.

Bug: T165760
Change-Id: Idebe233f0e98c32856674c0d60353f238d7945cc
---
M scap/environments/beta/betacluster
M scap/environments/beta/scap.cfg
2 files changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Mobrovac: Verified; Looks good to me, approved



diff --git a/scap/environments/beta/betacluster 
b/scap/environments/beta/betacluster
index f62e6b6..f702b62 100644
--- a/scap/environments/beta/betacluster
+++ b/scap/environments/beta/betacluster
@@ -1,3 +1,5 @@
 deployment-sca01.deployment-prep.eqiad.wmflabs
 deployment-sca02.deployment-prep.eqiad.wmflabs
+deployment-sca03.deployment-prep.eqiad.wmflabs
+deployment-sca04.deployment-prep.eqiad.wmflabs
 
diff --git a/scap/environments/beta/scap.cfg b/scap/environments/beta/scap.cfg
index 323d650..8958999 100644
--- a/scap/environments/beta/scap.cfg
+++ b/scap/environments/beta/scap.cfg
@@ -1,3 +1,4 @@
 [deployment-prep.eqiad.wmflabs]
 server_groups: default
 dsh_targets: betacluster
+group_size: 10

-- 
To view, visit https://gerrit.wikimedia.org/r/363062
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idebe233f0e98c32856674c0d60353f238d7945cc
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/recommendation-api/deploy
Gerrit-Branch: master
Gerrit-Owner: Mobrovac 
Gerrit-Reviewer: Mobrovac 
Gerrit-Reviewer: Nschaaf 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Beta: Add deployment-sca0[34] to the mix

[Mobrovac (Code Review)]

Mobrovac has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/363062 )

Change subject: Beta: Add deployment-sca0[34] to the mix
..

Beta: Add deployment-sca0[34] to the mix

Also, increase the deployment group size in beta, since there is no
depooling/repooling going on there.

Bug: T165760
Change-Id: Idebe233f0e98c32856674c0d60353f238d7945cc
---
M scap/environments/beta/betacluster
M scap/environments/beta/scap.cfg
2 files changed, 3 insertions(+), 0 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/services/recommendation-api/deploy 
refs/changes/62/363062/1

diff --git a/scap/environments/beta/betacluster 
b/scap/environments/beta/betacluster
index f62e6b6..f702b62 100644
--- a/scap/environments/beta/betacluster
+++ b/scap/environments/beta/betacluster
@@ -1,3 +1,5 @@
 deployment-sca01.deployment-prep.eqiad.wmflabs
 deployment-sca02.deployment-prep.eqiad.wmflabs
+deployment-sca03.deployment-prep.eqiad.wmflabs
+deployment-sca04.deployment-prep.eqiad.wmflabs
 
diff --git a/scap/environments/beta/scap.cfg b/scap/environments/beta/scap.cfg
index 323d650..8958999 100644
--- a/scap/environments/beta/scap.cfg
+++ b/scap/environments/beta/scap.cfg
@@ -1,3 +1,4 @@
 [deployment-prep.eqiad.wmflabs]
 server_groups: default
 dsh_targets: betacluster
+group_size: 10

-- 
To view, visit https://gerrit.wikimedia.org/r/363062
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Idebe233f0e98c32856674c0d60353f238d7945cc
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/recommendation-api/deploy
Gerrit-Branch: master
Gerrit-Owner: Mobrovac 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Beta: Separate the files into environments/beta and do no ch...

[Mobrovac (Code Review)]

Mobrovac has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/363053 )

Change subject: Beta: Separate the files into environments/beta and do no 
checks there
..


Beta: Separate the files into environments/beta and do no checks there

Bug: T165760
Change-Id: I5ff0d5c3e45cba4b38df2b7f896356ea8b92a1dc
---
R scap/environments/beta/betacluster
A scap/environments/beta/checks.yaml
A scap/environments/beta/scap.cfg
M scap/scap.cfg
4 files changed, 7 insertions(+), 2 deletions(-)

Approvals:
  Mobrovac: Verified; Looks good to me, approved



diff --git a/scap/betacluster b/scap/environments/beta/betacluster
similarity index 100%
rename from scap/betacluster
rename to scap/environments/beta/betacluster
diff --git a/scap/environments/beta/checks.yaml 
b/scap/environments/beta/checks.yaml
new file mode 100644
index 000..ff38a8d
--- /dev/null
+++ b/scap/environments/beta/checks.yaml
@@ -0,0 +1,4 @@
+checks:
+  depool: {}
+  repool: {}
+  endpoints: {}
diff --git a/scap/environments/beta/scap.cfg b/scap/environments/beta/scap.cfg
new file mode 100644
index 000..323d650
--- /dev/null
+++ b/scap/environments/beta/scap.cfg
@@ -0,0 +1,3 @@
+[deployment-prep.eqiad.wmflabs]
+server_groups: default
+dsh_targets: betacluster
diff --git a/scap/scap.cfg b/scap/scap.cfg
index 21a994a..ec5b2d3 100644
--- a/scap/scap.cfg
+++ b/scap/scap.cfg
@@ -15,5 +15,3 @@
 
 [deployment-prep.eqiad.wmflabs]
 environment: beta
-server_groups: default
-dsh_targets: betacluster

-- 
To view, visit https://gerrit.wikimedia.org/r/363053
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5ff0d5c3e45cba4b38df2b7f896356ea8b92a1dc
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/recommendation-api/deploy
Gerrit-Branch: master
Gerrit-Owner: Mobrovac 
Gerrit-Reviewer: Mobrovac 
Gerrit-Reviewer: Nschaaf 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Beta: Separate the files into environments/beta and do no ch...

[Mobrovac (Code Review)]

Mobrovac has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/363053 )

Change subject: Beta: Separate the files into environments/beta and do no 
checks there
..

Beta: Separate the files into environments/beta and do no checks there

Bug: T165760
Change-Id: I5ff0d5c3e45cba4b38df2b7f896356ea8b92a1dc
---
R scap/environments/beta/betacluster
A scap/environments/beta/checks.yaml
A scap/environments/beta/scap.cfg
M scap/scap.cfg
4 files changed, 7 insertions(+), 2 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/services/recommendation-api/deploy 
refs/changes/53/363053/1

diff --git a/scap/betacluster b/scap/environments/beta/betacluster
similarity index 100%
rename from scap/betacluster
rename to scap/environments/beta/betacluster
diff --git a/scap/environments/beta/checks.yaml 
b/scap/environments/beta/checks.yaml
new file mode 100644
index 000..ff38a8d
--- /dev/null
+++ b/scap/environments/beta/checks.yaml
@@ -0,0 +1,4 @@
+checks:
+  depool: {}
+  repool: {}
+  endpoints: {}
diff --git a/scap/environments/beta/scap.cfg b/scap/environments/beta/scap.cfg
new file mode 100644
index 000..323d650
--- /dev/null
+++ b/scap/environments/beta/scap.cfg
@@ -0,0 +1,3 @@
+[deployment-prep.eqiad.wmflabs]
+server_groups: default
+dsh_targets: betacluster
diff --git a/scap/scap.cfg b/scap/scap.cfg
index 21a994a..ec5b2d3 100644
--- a/scap/scap.cfg
+++ b/scap/scap.cfg
@@ -15,5 +15,3 @@
 
 [deployment-prep.eqiad.wmflabs]
 environment: beta
-server_groups: default
-dsh_targets: betacluster

-- 
To view, visit https://gerrit.wikimedia.org/r/363053
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5ff0d5c3e45cba4b38df2b7f896356ea8b92a1dc
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/recommendation-api/deploy
Gerrit-Branch: master
Gerrit-Owner: Mobrovac 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: OCG: Do not use the INFO command as a readiness check

[Mobrovac (Code Review)]

Mobrovac has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/363045 )

Change subject: OCG: Do not use the INFO command as a readiness check
..

OCG: Do not use the INFO command as a readiness check

We run Redis behind Nutcracker, which doesn't support the INFO command,
used by the driver as a rediness check. Hence, disable it altogether.

Change-Id: I2a2d302819acfe7dbe7a56f4c60dd57d6ba28156
Depends-On: I61dfc38dd662a2bf86da3568ab21511fe627d5b6
---
M modules/ocg/templates/mw-ocg-service.js.erb
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/45/363045/1

diff --git a/modules/ocg/templates/mw-ocg-service.js.erb 
b/modules/ocg/templates/mw-ocg-service.js.erb
index 2075233d..f6a3a23 100644
--- a/modules/ocg/templates/mw-ocg-service.js.erb
+++ b/modules/ocg/templates/mw-ocg-service.js.erb
@@ -19,6 +19,7 @@
config.redis.host = "<%= @redis_host %>";
config.redis.port = <%= @redis_port %>;
config.redis.password = "<%= @redis_password %>";
+   config.redis.no_ready_check = true;
 
config.frontend.port = <%= @service_port %>;
 

-- 
To view, visit https://gerrit.wikimedia.org/r/363045
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2a2d302819acfe7dbe7a56f4c60dd57d6ba28156
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Mobrovac 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Update mobileapps to 07ef2e8

[Mobrovac (Code Review)]

Mobrovac has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/363010 )

Change subject: Update mobileapps to 07ef2e8
..


Update mobileapps to 07ef2e8

List of changes:
07ef2e8 Temporarily disable pronunciation tests

Change-Id: I386b061eceb41be15f779b586e802d498a198191
---
M src
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Mobrovac: Verified; Looks good to me, approved



diff --git a/src b/src
index 0b05026..07ef2e8 16
--- a/src
+++ b/src
@@ -1 +1 @@
-Subproject commit 0b05026202670175035cf6f1a1b325a71b61c29d
+Subproject commit 07ef2e8be08dbdd2c9627ab762711ae1ad233d5f

-- 
To view, visit https://gerrit.wikimedia.org/r/363010
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I386b061eceb41be15f779b586e802d498a198191
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/mobileapps/deploy
Gerrit-Branch: master
Gerrit-Owner: Mobrovac 
Gerrit-Reviewer: BearND 
Gerrit-Reviewer: Mholloway 
Gerrit-Reviewer: Mobrovac 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Update mobileapps to 07ef2e8

[Mobrovac (Code Review)]

Mobrovac has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/363010 )

Change subject: Update mobileapps to 07ef2e8
..

Update mobileapps to 07ef2e8

List of changes:
07ef2e8 Temporarily disable pronunciation tests

Change-Id: I386b061eceb41be15f779b586e802d498a198191
---
M src
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/services/mobileapps/deploy 
refs/changes/10/363010/1

diff --git a/src b/src
index 0b05026..07ef2e8 16
--- a/src
+++ b/src
@@ -1 +1 @@
-Subproject commit 0b05026202670175035cf6f1a1b325a71b61c29d
+Subproject commit 07ef2e8be08dbdd2c9627ab762711ae1ad233d5f

-- 
To view, visit https://gerrit.wikimedia.org/r/363010
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I386b061eceb41be15f779b586e802d498a198191
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/mobileapps/deploy
Gerrit-Branch: master
Gerrit-Owner: Mobrovac 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki/event-schemas[master]: Revision-Create: Include rev_content_changed field.

[Mobrovac (Code Review)]

Mobrovac has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/362321 )

Change subject: Revision-Create: Include rev_content_changed field.
..


Revision-Create: Include rev_content_changed field.

Some actions, for example protecting the pages, create a new
revision but don't actually change the page content. If a major
template on a wiki gets protected, we're doing an enormous amount
of work rerendering dependencies while we know the result will
not change.

Change-Id: Ia5492563e8e88b60eba49eccf603b1599c6c3a74
---
M jsonschema/mediawiki/revision/create/1.yaml
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  Mobrovac: Verified; Looks good to me, approved
  jenkins-bot: Verified



diff --git a/jsonschema/mediawiki/revision/create/1.yaml 
b/jsonschema/mediawiki/revision/create/1.yaml
index 3ee33c4..81a7e9e 100644
--- a/jsonschema/mediawiki/revision/create/1.yaml
+++ b/jsonschema/mediawiki/revision/create/1.yaml
@@ -147,6 +147,10 @@
 description: The content format of the revision.
 type: string
 
+  rev_content_changed:
+description: Whether the revision actually changes the page content.
+type: boolean
+
   page_is_redirect:
 description: >
   True if this revision is a redirect.  This

-- 
To view, visit https://gerrit.wikimedia.org/r/362321
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia5492563e8e88b60eba49eccf603b1599c6c3a74
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/event-schemas
Gerrit-Branch: master
Gerrit-Owner: Ppchelko 
Gerrit-Reviewer: GWicke 
Gerrit-Reviewer: Mobrovac 
Gerrit-Reviewer: Ottomata 
Gerrit-Reviewer: Ppchelko 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Update restbase to 021f586

[Mobrovac (Code Review)]

Mobrovac has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/362299 )

Change subject: Update restbase to 021f586
..


Update restbase to 021f586

List of changes:
021f586 Protect special characters in PDF render backend requests

Change-Id: I8dcac3abe982efc0e5212ebe4c9078ea1b3fde7d
---
M restbase
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Mobrovac: Verified; Looks good to me, approved



diff --git a/restbase b/restbase
index b33bf90..021f586 16
--- a/restbase
+++ b/restbase
@@ -1 +1 @@
-Subproject commit b33bf9067b8ca60d5f8a0ef97fe4b0be3dfa2892
+Subproject commit 021f5865bbb19f3002d9d405fa644cf93218c816

-- 
To view, visit https://gerrit.wikimedia.org/r/362299
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8dcac3abe982efc0e5212ebe4c9078ea1b3fde7d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/restbase/deploy
Gerrit-Branch: master
Gerrit-Owner: Mobrovac 
Gerrit-Reviewer: Mobrovac 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Update restbase to 021f586

[Mobrovac (Code Review)]

Mobrovac has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/362299 )

Change subject: Update restbase to 021f586
..

Update restbase to 021f586

List of changes:
021f586 Protect special characters in PDF render backend requests

Change-Id: I8dcac3abe982efc0e5212ebe4c9078ea1b3fde7d
---
M restbase
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/restbase/deploy 
refs/changes/99/362299/1

diff --git a/restbase b/restbase
index b33bf90..021f586 16
--- a/restbase
+++ b/restbase
@@ -1 +1 @@
-Subproject commit b33bf9067b8ca60d5f8a0ef97fe4b0be3dfa2892
+Subproject commit 021f5865bbb19f3002d9d405fa644cf93218c816

-- 
To view, visit https://gerrit.wikimedia.org/r/362299
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8dcac3abe982efc0e5212ebe4c9078ea1b3fde7d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/restbase/deploy
Gerrit-Branch: master
Gerrit-Owner: Mobrovac 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits