[MediaWiki-commits] [Gerrit] UserrightsPage::makeGroupNameListForLog() was removed - change (mediawiki/core)

2016-04-01 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: UserrightsPage::makeGroupNameListForLog() was removed
..


UserrightsPage::makeGroupNameListForLog() was removed

Deprecated since 1.21. Use in Gerrit extensions was replaced.

Bug: T122754
Depends-on: If9a2764c5c15be9c07d066a52543c4c9d97e0f35
Change-Id: If45eafca7ea332475eb864f04665d0a0bf1603d1
---
M RELEASE-NOTES-1.27
M includes/specials/SpecialUserrights.php
2 files changed, 1 insertion(+), 17 deletions(-)

Approvals:
  Addshore: Looks good to me, approved
  jenkins-bot: Verified

Objections:
  Krinkle: There's a problem with this change, please improve



diff --git a/RELEASE-NOTES-1.27 b/RELEASE-NOTES-1.27
index 2f8f53a..8a0ab11 100644
--- a/RELEASE-NOTES-1.27
+++ b/RELEASE-NOTES-1.27
@@ -250,6 +250,7 @@
 * OutputPage::getScript() was removed (deprecated since 1.24).
 * OutputPage::out() was removed (deprecated since 1.22).
 * OutputPage::setAllowedModules() was removed (deprecated since 1.24).
+* UserrightsPage::makeGroupNameListForLog() was removed (deprecated since 
1.21).
 
 === Languages updated in 1.27 ===
 
diff --git a/includes/specials/SpecialUserrights.php 
b/includes/specials/SpecialUserrights.php
index 29261f3..7901d37 100644
--- a/includes/specials/SpecialUserrights.php
+++ b/includes/specials/SpecialUserrights.php
@@ -426,23 +426,6 @@
}
 
/**
-* Make a list of group names to be stored as parameter for log entries
-*
-* @deprecated since 1.21; use LogFormatter instead.
-* @param array $ids
-* @return string
-*/
-   function makeGroupNameListForLog( $ids ) {
-   wfDeprecated( __METHOD__, '1.21' );
-
-   if ( empty( $ids ) ) {
-   return '';
-   } else {
-   return $this->makeGroupNameList( $ids );
-   }
-   }
-
-   /**
 * Output a form to allow searching for a user
 */
function switchForm() {

-- 
To view, visit https://gerrit.wikimedia.org/r/276051
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If45eafca7ea332475eb864f04665d0a0bf1603d1
Gerrit-PatchSet: 6
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Siebrand 
Gerrit-Reviewer: Addshore 
Gerrit-Reviewer: Florianschmidtwelzow 
Gerrit-Reviewer: Krinkle 
Gerrit-Reviewer: Siebrand 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] UserrightsPage::makeGroupNameListForLog() was removed - change (mediawiki/core)

2016-03-08 Thread Siebrand (Code Review) 
Siebrand has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/276051

Change subject: UserrightsPage::makeGroupNameListForLog() was removed
..

UserrightsPage::makeGroupNameListForLog() was removed

Deprecated since 1.21. Remaining use in core replaced. No uses in Gerrit
extensions.

Change-Id: If45eafca7ea332475eb864f04665d0a0bf1603d1
---
M RELEASE-NOTES-1.27
M includes/specials/SpecialUserrights.php
2 files changed, 1 insertion(+), 17 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/51/276051/1

diff --git a/RELEASE-NOTES-1.27 b/RELEASE-NOTES-1.27
index 9dfde84..9da54d2 100644
--- a/RELEASE-NOTES-1.27
+++ b/RELEASE-NOTES-1.27
@@ -240,6 +240,7 @@
 * OutputPage::getScript() was removed (deprecated since 1.24).
 * OutputPage::out() was removed (deprecated since 1.22).
 * OutputPage::setAllowedModules() was removed (deprecated since 1.24).
+* UserrightsPage::makeGroupNameListForLog() was removed (deprecated since 
1.21).
 
 === Languages updated in 1.27 ===
 
diff --git a/includes/specials/SpecialUserrights.php 
b/includes/specials/SpecialUserrights.php
index 29261f3..7901d37 100644
--- a/includes/specials/SpecialUserrights.php
+++ b/includes/specials/SpecialUserrights.php
@@ -426,23 +426,6 @@
}
 
/**
-* Make a list of group names to be stored as parameter for log entries
-*
-* @deprecated since 1.21; use LogFormatter instead.
-* @param array $ids
-* @return string
-*/
-   function makeGroupNameListForLog( $ids ) {
-   wfDeprecated( __METHOD__, '1.21' );
-
-   if ( empty( $ids ) ) {
-   return '';
-   } else {
-   return $this->makeGroupNameList( $ids );
-   }
-   }
-
-   /**
 * Output a form to allow searching for a user
 */
function switchForm() {

-- 
To view, visit https://gerrit.wikimedia.org/r/276051
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If45eafca7ea332475eb864f04665d0a0bf1603d1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Siebrand 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits