[MediaWiki-commits] [Gerrit] mediawiki...BlueSpiceUserManager[master]: WikiAdmin is not part of BlueSpice 3. Removed unneeded code and

2018-01-18 Thread Robert Vogel (Code Review)
Robert Vogel has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/404949 )

Change subject: WikiAdmin is not part of BlueSpice 3. Removed unneeded code and
..


WikiAdmin is not part of BlueSpice 3. Removed unneeded code and

used new registry for admin tools

Change-Id: Id355087830f0d1f92dc23b2e941429daba7b6ff6
---
M UserManager.class.php
M extension.json
A src/AdminTool.php
3 files changed, 43 insertions(+), 8 deletions(-)

Approvals:
  Robert Vogel: Verified; Looks good to me, approved



diff --git a/UserManager.class.php b/UserManager.class.php
index af3c860..6aac30a 100644
--- a/UserManager.class.php
+++ b/UserManager.class.php
@@ -44,14 +44,6 @@
$this->mExtensionFile = __FILE__;
$this->mExtensionType = EXTTYPE::VARIABLE;
 
-   WikiAdmin::registerModule( 'UserManager', array(
-   'image' => 
'/extensions/BlueSpiceExtensions/WikiAdmin/resources/images/bs-btn_usermanagement_v1.png',
-   'level' => 'wikiadmin',
-   'message' => 'bs-usermanager-label',
-   'iconCls' => 'bs-icon-user-add',
-   'permissions' => [ 'usermanager-viewspecialpage' ],
-   ) );
-
wfProfileOut( 'BS::'.__METHOD__ );
}
 
diff --git a/extension.json b/extension.json
index a260955..359b2f3 100644
--- a/extension.json
+++ b/extension.json
@@ -17,6 +17,9 @@
"extPath": "/BlueSpiceUserManager"
}
},
+   "BlueSpiceFoundationAdminToolRegistry": {
+   "bs-usermanager-manager": "BlueSpice\\UserManager\\AdminTool"
+   },
"SpecialPages": {
"UserManager": "SpecialUserManager"
},
diff --git a/src/AdminTool.php b/src/AdminTool.php
new file mode 100644
index 000..eea1cbd
--- /dev/null
+++ b/src/AdminTool.php
@@ -0,0 +1,40 @@
+getLocalURL();
+   }
+
+   public function getDescription() {
+   return wfMessage( 'bs-usermanager-desc' );
+   }
+
+   public function getName() {
+   return wfMessage( 'bs-usermanager-label' );
+   }
+
+   public function getClasses() {
+   $classes = array(
+   'bs-icon-user-add'
+   );
+
+   return $classes;
+   }
+
+   public function getDataAttributes() {
+   }
+
+   public function getPermissions() {
+   $permissions = array(
+   'usermanager-viewspecialpage'
+   );
+   return $permissions;
+   }
+
+}
\ No newline at end of file

-- 
To view, visit https://gerrit.wikimedia.org/r/404949
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id355087830f0d1f92dc23b2e941429daba7b6ff6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BlueSpiceUserManager
Gerrit-Branch: master
Gerrit-Owner: Dvogel hallowelt 
Gerrit-Reviewer: Ljonka 
Gerrit-Reviewer: Mglaser 
Gerrit-Reviewer: Pwirth 
Gerrit-Reviewer: Robert Vogel 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] mediawiki...BlueSpiceUserManager[master]: WikiAdmin is not part of BlueSpice 3. Removed unneeded code and

2018-01-18 Thread Dvogel hallowelt (Code Review)
Dvogel hallowelt has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404949 )

Change subject: WikiAdmin is not part of BlueSpice 3. Removed unneeded code and
..

WikiAdmin is not part of BlueSpice 3. Removed unneeded code and

used new registry for admin tools

Change-Id: Id355087830f0d1f92dc23b2e941429daba7b6ff6
---
M UserManager.class.php
M extension.json
A src/AdminTool.php
3 files changed, 43 insertions(+), 8 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/BlueSpiceUserManager 
refs/changes/49/404949/1

diff --git a/UserManager.class.php b/UserManager.class.php
index af3c860..6aac30a 100644
--- a/UserManager.class.php
+++ b/UserManager.class.php
@@ -44,14 +44,6 @@
$this->mExtensionFile = __FILE__;
$this->mExtensionType = EXTTYPE::VARIABLE;
 
-   WikiAdmin::registerModule( 'UserManager', array(
-   'image' => 
'/extensions/BlueSpiceExtensions/WikiAdmin/resources/images/bs-btn_usermanagement_v1.png',
-   'level' => 'wikiadmin',
-   'message' => 'bs-usermanager-label',
-   'iconCls' => 'bs-icon-user-add',
-   'permissions' => [ 'usermanager-viewspecialpage' ],
-   ) );
-
wfProfileOut( 'BS::'.__METHOD__ );
}
 
diff --git a/extension.json b/extension.json
index a260955..359b2f3 100644
--- a/extension.json
+++ b/extension.json
@@ -17,6 +17,9 @@
"extPath": "/BlueSpiceUserManager"
}
},
+   "BlueSpiceFoundationAdminToolRegistry": {
+   "bs-usermanager-manager": "BlueSpice\\UserManager\\AdminTool"
+   },
"SpecialPages": {
"UserManager": "SpecialUserManager"
},
diff --git a/src/AdminTool.php b/src/AdminTool.php
new file mode 100644
index 000..eea1cbd
--- /dev/null
+++ b/src/AdminTool.php
@@ -0,0 +1,40 @@
+getLocalURL();
+   }
+
+   public function getDescription() {
+   return wfMessage( 'bs-usermanager-desc' );
+   }
+
+   public function getName() {
+   return wfMessage( 'bs-usermanager-label' );
+   }
+
+   public function getClasses() {
+   $classes = array(
+   'bs-icon-user-add'
+   );
+
+   return $classes;
+   }
+
+   public function getDataAttributes() {
+   }
+
+   public function getPermissions() {
+   $permissions = array(
+   'usermanager-viewspecialpage'
+   );
+   return $permissions;
+   }
+
+}
\ No newline at end of file

-- 
To view, visit https://gerrit.wikimedia.org/r/404949
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id355087830f0d1f92dc23b2e941429daba7b6ff6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BlueSpiceUserManager
Gerrit-Branch: master
Gerrit-Owner: Dvogel hallowelt 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits