[MediaWiki-commits] [Gerrit] mediawiki...CirrusSearch[wmf/1.30.0-wmf.4]: Fix T167473 - should use object access, not array, for selec...

2017-06-08 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/357953 )

Change subject: Fix T167473 - should use object access, not array, for select 
results.
..


Fix T167473 - should use object access, not array, for select results.

Bug: T167473
Change-Id: Ia2b4ddfd63fc45d9967996f63798abb78aba73d3
---
M includes/Job/DeleteArchive.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Chad: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/Job/DeleteArchive.php b/includes/Job/DeleteArchive.php
index fb9560b..061c884 100644
--- a/includes/Job/DeleteArchive.php
+++ b/includes/Job/DeleteArchive.php
@@ -23,7 +23,7 @@
 
// Remove page IDs that still have archived revs
foreach ( $archive->listRevisions() as $rev ) {
-   unset( $docs[$rev['ar_page_id']] );
+   unset( $docs[$rev->ar_page_id] );
}
 
if ( empty( $docs ) ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/357953
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia2b4ddfd63fc45d9967996f63798abb78aba73d3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CirrusSearch
Gerrit-Branch: wmf/1.30.0-wmf.4
Gerrit-Owner: Smalyshev 
Gerrit-Reviewer: Chad 
Gerrit-Reviewer: DCausse 
Gerrit-Reviewer: EBernhardson 
Gerrit-Reviewer: Gehel 
Gerrit-Reviewer: Tjones 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...CirrusSearch[wmf/1.30.0-wmf.4]: Fix T167473 - should use object access, not array, for selec...

2017-06-08 Thread Smalyshev (Code Review) 
Smalyshev has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/357953 )

Change subject: Fix T167473 - should use object access, not array, for select 
results.
..

Fix T167473 - should use object access, not array, for select results.

Bug: T167473
Change-Id: Ia2b4ddfd63fc45d9967996f63798abb78aba73d3
---
M includes/Job/DeleteArchive.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CirrusSearch 
refs/changes/53/357953/1

diff --git a/includes/Job/DeleteArchive.php b/includes/Job/DeleteArchive.php
index fb9560b..061c884 100644
--- a/includes/Job/DeleteArchive.php
+++ b/includes/Job/DeleteArchive.php
@@ -23,7 +23,7 @@
 
// Remove page IDs that still have archived revs
foreach ( $archive->listRevisions() as $rev ) {
-   unset( $docs[$rev['ar_page_id']] );
+   unset( $docs[$rev->ar_page_id] );
}
 
if ( empty( $docs ) ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/357953
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia2b4ddfd63fc45d9967996f63798abb78aba73d3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CirrusSearch
Gerrit-Branch: wmf/1.30.0-wmf.4
Gerrit-Owner: Smalyshev 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits