[MediaWiki-commits] [Gerrit] mediawiki...ContentTranslation[master]: Change empty result states
jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/383176 )
Change subject: Change empty result states
..
Change empty result states
- Drop minimum height for search results container.
- Don't show missing pages while searching in New translation dialog.
- Show message when there are no search results for user input query.
- Remove red border for validation on New translation dialog input field.
- Provide option to close search results on Escape key.
- Don't close search results when New translation dialog input
field is tabbed out.
Bug: T177469
Bug: T177470
Depends-On: I9e7dd451c61a6a88679628acbbf28d45c0a1e0e8
Change-Id: I70cc3fa25e153b29486b0d42adf7bd8cd17d9ee8
---
M extension.json
M i18n/en.json
M i18n/qqq.json
M modules/source/ext.cx.source.selector.js
M modules/source/styles/ext.cx.source.selector.less
M modules/ui/widgets/mw.cx.ui.PageSelectorWidget.js
6 files changed, 103 insertions(+), 32 deletions(-)
Approvals:
jenkins-bot: Verified
Nikerabbit: Looks good to me, approved
diff --git a/extension.json b/extension.json
index 17ffe5c..dd35779 100644
--- a/extension.json
+++ b/extension.json
@@ -366,8 +366,9 @@
"cx-sourceselector-dialog-error-title-in-use",
"cx-sourceselector-dialog-error-no-source-article",
"cx-sourceselector-embedded-selected-item-pageviews",
- "cx-sourceselector-embedded-recent-edits",
+
"cx-sourceselector-embedded-recent-edits-header",
"cx-sourceselector-embedded-recent-edits-no-results",
+ "cx-sourceselector-embedded-search-no-results",
"cx-license-agreement",
"cx-error-server-connection"
]
diff --git a/i18n/en.json b/i18n/en.json
index 806ff22..5d4fd2c 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -100,8 +100,9 @@
"cx-sourceselector-missing-in-target-language": "Missing in $1",
"cx-sourceselector-number-of-languages": "Number of languages",
"cx-sourceselector-embedded-selected-item-pageviews": "{{PLURAL:$1|$1
visit per|$1 visits per|0=No visits this}} week",
- "cx-sourceselector-embedded-recent-edits": "Recently edited by you",
+ "cx-sourceselector-embedded-recent-edits-header": "Recently edited by
you",
"cx-sourceselector-embedded-recent-edits-no-results": "Think of any
topic of your interest. You don’t need to be an expert to create a great
translation.",
+ "cx-sourceselector-embedded-search-no-results": "No pages found for
\"$1\" in $2",
"cx-mt-abuse-warning-title": "Your translation {{PLURAL:$1|contains}}
$1% of unmodified machine-translated text",
"cx-mt-abuse-warning-text": "Machine translation is provided only as a
starting point. You need to make sure that the content is accurate and reads
naturally in your language.",
"cx-publish-captcha-title": "Security question",
diff --git a/i18n/qqq.json b/i18n/qqq.json
index 39cba34..aa7069e 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -109,8 +109,9 @@
"cx-sourceselector-missing-in-target-language": "Label appended to
search result in Special:ContentTranslation when using the \"Start new
article\" feature, which indicates that matching article is missing in target
language.\n\nParameters:\n* $1 - The autonym of the language",
"cx-sourceselector-number-of-languages": "Tooltip shown in
Special:ContentTranslation over the icon that shows many languages the article
is available in",
"cx-sourceselector-embedded-selected-item-pageviews": "Label appended
to selected item in New translation embedded dialog on Content Translation
dashboard, used for representing number of page visits in the last week.\n$1 -
number of visits per week",
- "cx-sourceselector-embedded-recent-edits": "Label used in New
translation embedded dialog, above the suggestions based on user's Recently
edited pages.",
+ "cx-sourceselector-embedded-recent-edits-header": "Label used in New
translation embedded dialog, above the suggestions based on user's Recently
edited pages.",
"cx-sourceselector-embedded-recent-edits-no-results": "Message used in
New translation embedded dialog, when there are no suggestions based on user's
Recently edited pages.",
+ "cx-sourceselector-embedded-search-no-results": "Message used in New
translation embedded dialog, displayed when there are no search results for
user's input query.\n\nParameters:\n* $1 - User's input query\n* $2 - Autonym
name of currently selected source language",
"cx-mt-abuse-warning-title": "Title text shown in machine translation
abuse card.\n* $1: Percentage of machine translation",
"cx-mt-abuse-warning-text": "Detailed expla
[MediaWiki-commits] [Gerrit] mediawiki...ContentTranslation[master]: Change empty result states
Petar.petkovic has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/383176 )
Change subject: Change empty result states
..
Change empty result states
- Drop minimum height for search results container.
- Don't show missing pages while searching in New translation dialog.
- Show message when there are no search results for user input query.
- Remove red border for validation on New translation dialog input field.
- Provide option to close search results on Escape key.
- Don't close search results when New translation dialog input
field is tabbed out.
Bug: T177469
Bug: T177470
Depends-On: I9e7dd451c61a6a88679628acbbf28d45c0a1e0e8
Change-Id: I70cc3fa25e153b29486b0d42adf7bd8cd17d9ee8
---
M extension.json
M i18n/en.json
M i18n/qqq.json
M modules/source/ext.cx.source.selector.js
M modules/source/styles/ext.cx.source.selector.less
M modules/ui/widgets/mw.cx.ui.PageSelectorWidget.js
6 files changed, 105 insertions(+), 32 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ContentTranslation
refs/changes/76/383176/1
diff --git a/extension.json b/extension.json
index 0b8226d..e6d0130 100644
--- a/extension.json
+++ b/extension.json
@@ -369,8 +369,9 @@
"cx-sourceselector-dialog-error-title-in-use",
"cx-sourceselector-dialog-error-no-source-article",
"cx-sourceselector-embedded-selected-item-pageviews",
- "cx-sourceselector-embedded-recent-edits",
+
"cx-sourceselector-embedded-recent-edits-header",
"cx-sourceselector-embedded-recent-edits-no-results",
+ "cx-sourceselector-embedded-search-no-results",
"cx-license-agreement",
"cx-error-server-connection"
]
diff --git a/i18n/en.json b/i18n/en.json
index 41d3cab..f890f7b 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -99,8 +99,9 @@
"cx-sourceselector-dialog-error-no-source-article": "The page to
translate does not exist in $1",
"cx-sourceselector-missing-in-target-language": "Missing in $1",
"cx-sourceselector-embedded-selected-item-pageviews": "{{PLURAL:$1|$1
visit per|$1 visits per|0=No visits this}} week",
- "cx-sourceselector-embedded-recent-edits": "Recently edited by you",
+ "cx-sourceselector-embedded-recent-edits-header": "Recently edited by
you",
"cx-sourceselector-embedded-recent-edits-no-results": "Think of any
topic of your interest. You don’t need to be an expert to create a great
translation.",
+ "cx-sourceselector-embedded-search-no-results": "No pages found for
'$1' in $2",
"cx-mt-abuse-warning-title": "Your translation {{PLURAL:$1|contains}}
$1% of unmodified machine-translated text",
"cx-mt-abuse-warning-text": "Machine translation is provided only as a
starting point. You need to make sure that the content is accurate and reads
naturally in your language.",
"cx-publish-captcha-title": "Security question",
diff --git a/i18n/qqq.json b/i18n/qqq.json
index 550145d..98fd369 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -108,8 +108,9 @@
"cx-sourceselector-dialog-error-no-source-article": "Error that
indicates there is no page with the specified title in the source language to
translate.\n\nParameters:\n* $1 - the source language",
"cx-sourceselector-missing-in-target-language": "Label appended to
search result in Special:ContentTranslation when using the \"Start new
article\" feature, which indicates that matching article is missing in target
language.\n\nParameters:\n* $1 - The autonym of the language",
"cx-sourceselector-embedded-selected-item-pageviews": "Label appended
to selected item in New translation embedded dialog on Content Translation
dashboard, used for representing number of page visits in the last week.\n$1 -
number of visits per week",
- "cx-sourceselector-embedded-recent-edits": "Label used in New
translation embedded dialog, above the suggestions based on user's Recently
edited pages.",
+ "cx-sourceselector-embedded-recent-edits-header": "Label used in New
translation embedded dialog, above the suggestions based on user's Recently
edited pages.",
"cx-sourceselector-embedded-recent-edits-no-results": "Message used in
New translation embedded dialog, when there are no suggestions based on user's
Recently edited pages.",
+ "cx-sourceselector-embedded-search-no-results": "Message used in New
translation embedded dialog, displayed when there are no search results for
user's input query.\n\nParameters:\n* $1 - User's input query\n* $2 - Autonym
name of currently selected source language",
"cx-mt-abuse-warning-title": "Title text shown in machine translation
abus
