[MediaWiki-commits] [Gerrit] mediawiki...ContentTranslation[master]: Make Translation::getConflictingTranslations() static

2017-09-16 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/378353 )

Change subject: Make Translation::getConflictingTranslations() static
..


Make Translation::getConflictingTranslations() static

It's already being called as such (which causes notices),
and doesn't use $this.

Change-Id: Id044c0447d2fd435bec2e4e726fc22e1a02f8320
---
M includes/Translation.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  jenkins-bot: Verified
  Nikerabbit: Looks good to me, approved



diff --git a/includes/Translation.php b/includes/Translation.php
index 5027eaf..43da941 100644
--- a/includes/Translation.php
+++ b/includes/Translation.php
@@ -194,7 +194,7 @@
 * @param TranslationWork $work
 * @return array
 */
-   public function getConflictingTranslations( TranslationWork $work ) {
+   public static function getConflictingTranslations( TranslationWork 
$work ) {
// Use the fact that find returns all items when given array of 
titles.
$drafts = self::find(
$work->getSourceLanguage(),

-- 
To view, visit https://gerrit.wikimedia.org/r/378353
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id044c0447d2fd435bec2e4e726fc22e1a02f8320
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ContentTranslation
Gerrit-Branch: master
Gerrit-Owner: Catrope 
Gerrit-Reviewer: Nikerabbit 
Gerrit-Reviewer: Santhosh 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...ContentTranslation[master]: Make Translation::getConflictingTranslations() static

2017-09-15 Thread Catrope (Code Review) 
Catrope has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/378353 )

Change subject: Make Translation::getConflictingTranslations() static
..

Make Translation::getConflictingTranslations() static

It's already being called as such (which causes notices),
and doesn't use $this.

Change-Id: Id044c0447d2fd435bec2e4e726fc22e1a02f8320
---
M includes/Translation.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ContentTranslation 
refs/changes/53/378353/1

diff --git a/includes/Translation.php b/includes/Translation.php
index 5027eaf..43da941 100644
--- a/includes/Translation.php
+++ b/includes/Translation.php
@@ -194,7 +194,7 @@
 * @param TranslationWork $work
 * @return array
 */
-   public function getConflictingTranslations( TranslationWork $work ) {
+   public static function getConflictingTranslations( TranslationWork 
$work ) {
// Use the fact that find returns all items when given array of 
titles.
$drafts = self::find(
$work->getSourceLanguage(),

-- 
To view, visit https://gerrit.wikimedia.org/r/378353
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id044c0447d2fd435bec2e4e726fc22e1a02f8320
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ContentTranslation
Gerrit-Branch: master
Gerrit-Owner: Catrope 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits