[MediaWiki-commits] [Gerrit] mediawiki...ContentTranslation[master]: Show progress indicator after clicking on the placeholder se...

2017-09-15 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/378224 )

Change subject: Show progress indicator after clicking on the placeholder 
section
..


Show progress indicator after clicking on the placeholder section

Change-Id: I01cbd9090c4ad1094ca1554631102d7ecaad143d
---
M modules/ve-cx/ce/ve.ce.CXPlaceholderNode.js
1 file changed, 5 insertions(+), 0 deletions(-)

Approvals:
  Catrope: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/ve-cx/ce/ve.ce.CXPlaceholderNode.js 
b/modules/ve-cx/ce/ve.ce.CXPlaceholderNode.js
index 88de981..aee26d6 100644
--- a/modules/ve-cx/ce/ve.ce.CXPlaceholderNode.js
+++ b/modules/ve-cx/ce/ve.ce.CXPlaceholderNode.js
@@ -48,9 +48,14 @@
 
 ve.ce.CXPlaceholderNode.prototype.executeCommand = function () {
this.active = true;
+   this.showProgressIndicator();
this.getDocument().emit( 'activatePlaceholder', this );
 };
 
+ve.ce.CXPlaceholderNode.prototype.showProgressIndicator = function () {
+   this.$element.empty().append( mw.cx.widgets.spinner() );
+};
+
 ve.ce.CXPlaceholderNode.prototype.createHighlights = function () {
 };
 

-- 
To view, visit https://gerrit.wikimedia.org/r/378224
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I01cbd9090c4ad1094ca1554631102d7ecaad143d
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/ContentTranslation
Gerrit-Branch: master
Gerrit-Owner: Santhosh 
Gerrit-Reviewer: Catrope 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...ContentTranslation[master]: Show progress indicator after clicking on the placeholder se...

2017-09-15 Thread Santhosh (Code Review) 
Santhosh has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/378224 )

Change subject: Show progress indicator after clicking on the placeholder 
section
..

Show progress indicator after clicking on the placeholder section

Change-Id: I01cbd9090c4ad1094ca1554631102d7ecaad143d
---
M modules/ve-cx/ce/ve.ce.CXPlaceholderNode.js
1 file changed, 5 insertions(+), 0 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ContentTranslation 
refs/changes/24/378224/1

diff --git a/modules/ve-cx/ce/ve.ce.CXPlaceholderNode.js 
b/modules/ve-cx/ce/ve.ce.CXPlaceholderNode.js
index 88de981..aee26d6 100644
--- a/modules/ve-cx/ce/ve.ce.CXPlaceholderNode.js
+++ b/modules/ve-cx/ce/ve.ce.CXPlaceholderNode.js
@@ -48,9 +48,14 @@
 
 ve.ce.CXPlaceholderNode.prototype.executeCommand = function () {
this.active = true;
+   this.showProgressIndicator();
this.getDocument().emit( 'activatePlaceholder', this );
 };
 
+ve.ce.CXPlaceholderNode.prototype.showProgressIndicator = function () {
+   this.$element.empty().append( mw.cx.widgets.spinner() );
+};
+
 ve.ce.CXPlaceholderNode.prototype.createHighlights = function () {
 };
 

-- 
To view, visit https://gerrit.wikimedia.org/r/378224
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I01cbd9090c4ad1094ca1554631102d7ecaad143d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ContentTranslation
Gerrit-Branch: master
Gerrit-Owner: Santhosh 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits