[MediaWiki-commits] [Gerrit] mediawiki...ContentTranslation[master]: Use .then(success, fail) when using .then

2017-12-18 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/398600 )

Change subject: Use .then(success,fail) when using .then
..


Use .then(success,fail) when using .then

Change-Id: Ib2e995a71a83ef8902b96b9df77965cd7d8ed270
---
M modules/dashboard/ext.cx.dashboard.js
1 file changed, 14 insertions(+), 11 deletions(-)

Approvals:
  jenkins-bot: Verified
  Santhosh: Looks good to me, approved



diff --git a/modules/dashboard/ext.cx.dashboard.js 
b/modules/dashboard/ext.cx.dashboard.js
index da455b3..f42bda0 100644
--- a/modules/dashboard/ext.cx.dashboard.js
+++ b/modules/dashboard/ext.cx.dashboard.js
@@ -80,20 +80,23 @@
this.render();
 
// Get acceptable source/target language pairs
-   this.siteMapper.getLanguagePairs().then( function ( data ) {
-   // We store valid source and target languages as 
"static" variables of LanguageFilter
-   mw.cx.ui.LanguageFilter.sourceLanguages = 
data.sourceLanguages;
-   mw.cx.ui.LanguageFilter.targetLanguages = 
data.targetLanguages;
+   this.siteMapper.getLanguagePairs().then(
+   function ( data ) {
+   // We store valid source and target languages 
as "static" variables of LanguageFilter
+   mw.cx.ui.LanguageFilter.sourceLanguages = 
data.sourceLanguages;
+   mw.cx.ui.LanguageFilter.targetLanguages = 
data.targetLanguages;
 
-   self.setDefaultLanguages();
+   self.setDefaultLanguages();
 
-   self.initLists();
-   self.listen();
+   self.initLists();
+   self.listen();
 
-   mw.hook( 'mw.cx.dashboard.ready' ).fire();
-   } ).fail( function () {
-   mw.hook( 'mw.cx.error' ).fire( mw.msg( 
'cx-error-server-connection' ) );
-   } );
+   mw.hook( 'mw.cx.dashboard.ready' ).fire();
+   },
+   function () {
+   mw.hook( 'mw.cx.error' ).fire( mw.msg( 
'cx-error-server-connection' ) );
+   }
+   );
};
 
// Find valid source and target language pair and store them in local 
storage

-- 
To view, visit https://gerrit.wikimedia.org/r/398600
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib2e995a71a83ef8902b96b9df77965cd7d8ed270
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ContentTranslation
Gerrit-Branch: master
Gerrit-Owner: Esanders 
Gerrit-Reviewer: Santhosh 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...ContentTranslation[master]: Use .then(success, fail) when using .then

2017-12-15 Thread Esanders (Code Review) 
Esanders has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/398600 )

Change subject: Use .then(success,fail) when using .then
..

Use .then(success,fail) when using .then

Change-Id: Ib2e995a71a83ef8902b96b9df77965cd7d8ed270
---
M modules/dashboard/ext.cx.dashboard.js
1 file changed, 14 insertions(+), 11 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ContentTranslation 
refs/changes/00/398600/1

diff --git a/modules/dashboard/ext.cx.dashboard.js 
b/modules/dashboard/ext.cx.dashboard.js
index da455b3..f42bda0 100644
--- a/modules/dashboard/ext.cx.dashboard.js
+++ b/modules/dashboard/ext.cx.dashboard.js
@@ -80,20 +80,23 @@
this.render();
 
// Get acceptable source/target language pairs
-   this.siteMapper.getLanguagePairs().then( function ( data ) {
-   // We store valid source and target languages as 
"static" variables of LanguageFilter
-   mw.cx.ui.LanguageFilter.sourceLanguages = 
data.sourceLanguages;
-   mw.cx.ui.LanguageFilter.targetLanguages = 
data.targetLanguages;
+   this.siteMapper.getLanguagePairs().then(
+   function ( data ) {
+   // We store valid source and target languages 
as "static" variables of LanguageFilter
+   mw.cx.ui.LanguageFilter.sourceLanguages = 
data.sourceLanguages;
+   mw.cx.ui.LanguageFilter.targetLanguages = 
data.targetLanguages;
 
-   self.setDefaultLanguages();
+   self.setDefaultLanguages();
 
-   self.initLists();
-   self.listen();
+   self.initLists();
+   self.listen();
 
-   mw.hook( 'mw.cx.dashboard.ready' ).fire();
-   } ).fail( function () {
-   mw.hook( 'mw.cx.error' ).fire( mw.msg( 
'cx-error-server-connection' ) );
-   } );
+   mw.hook( 'mw.cx.dashboard.ready' ).fire();
+   },
+   function () {
+   mw.hook( 'mw.cx.error' ).fire( mw.msg( 
'cx-error-server-connection' ) );
+   }
+   );
};
 
// Find valid source and target language pair and store them in local 
storage

-- 
To view, visit https://gerrit.wikimedia.org/r/398600
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib2e995a71a83ef8902b96b9df77965cd7d8ed270
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ContentTranslation
Gerrit-Branch: master
Gerrit-Owner: Esanders 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits