[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[wmf/1.29.0-wmf.6]: Fix fullscreen map not closing properly

2016-12-15 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/327423 )

Change subject: Fix fullscreen map not closing properly
..


Fix fullscreen map not closing properly

Bug: T153100
Change-Id: I6288b79483962f06b031e9b77f19826c1f311525
(cherry picked from commit 6baad5148be53d7880bff35129e8be9663a0c70c)
---
M modules/dialog/index.js
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Hashar: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/dialog/index.js b/modules/dialog/index.js
index 683da45..b735471 100644
--- a/modules/dialog/index.js
+++ b/modules/dialog/index.js
@@ -98,6 +98,7 @@
 
if ( map.useRouter && !routerEnabled ) {
router.on( 'route', 
closeIfNotMapRoute );
+   router.route( '', 
closeIfNotMapRoute );
routerEnabled = true;
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/327423
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6288b79483962f06b031e9b77f19826c1f311525
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Kartographer
Gerrit-Branch: wmf/1.29.0-wmf.6
Gerrit-Owner: Yurik 
Gerrit-Reviewer: Hashar 
Gerrit-Reviewer: JGirault 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[wmf/1.29.0-wmf.6]: Fix fullscreen map not closing properly

2016-12-14 Thread Yurik (Code Review) 
Yurik has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/327423 )

Change subject: Fix fullscreen map not closing properly
..

Fix fullscreen map not closing properly

Bug: T153100
Change-Id: I6288b79483962f06b031e9b77f19826c1f311525
(cherry picked from commit 6baad5148be53d7880bff35129e8be9663a0c70c)
---
M modules/dialog/index.js
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Kartographer 
refs/changes/23/327423/1

diff --git a/modules/dialog/index.js b/modules/dialog/index.js
index 683da45..b735471 100644
--- a/modules/dialog/index.js
+++ b/modules/dialog/index.js
@@ -98,6 +98,7 @@
 
if ( map.useRouter && !routerEnabled ) {
router.on( 'route', 
closeIfNotMapRoute );
+   router.route( '', 
closeIfNotMapRoute );
routerEnabled = true;
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/327423
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6288b79483962f06b031e9b77f19826c1f311525
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Kartographer
Gerrit-Branch: wmf/1.29.0-wmf.6
Gerrit-Owner: Yurik 
Gerrit-Reviewer: JGirault 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits