[MediaWiki-commits] [Gerrit] mediawiki...LoginNotify[wmf/1.30.0-wmf.15]: Fix typo where IP wasn't retrieved from job

2017-08-23 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/373387 )

Change subject: Fix typo where IP wasn't retrieved from job
..


Fix typo where IP wasn't retrieved from job

I think this might be causing T173888
(Although I don't really know)

Bug: T173888
Change-Id: I8d64a8b1c6607cb5b32a25182ec3496477322fdd
(cherry picked from commit 23f4a71831987998f0de95b6de7427ba6c8c129f)
---
M includes/DeferredChecksJob.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  MaxSem: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/DeferredChecksJob.php b/includes/DeferredChecksJob.php
index 05096eb..9bfeb42 100644
--- a/includes/DeferredChecksJob.php
+++ b/includes/DeferredChecksJob.php
@@ -40,7 +40,7 @@
. print_r( $this->params['subnet'], true )
);
}
-   $subnet = $this->params['resultSoFar'];
+   $subnet = $this->params['subnet'];
if ( !isset( $this->params['resultSoFar'] ) || !is_string( 
$this->params['resultSoFar'] ) ) {
throw new Exception( __CLASS__
. " expected to receive a string parameter 
'resultSoFar', got "

-- 
To view, visit https://gerrit.wikimedia.org/r/373387
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8d64a8b1c6607cb5b32a25182ec3496477322fdd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/LoginNotify
Gerrit-Branch: wmf/1.30.0-wmf.15
Gerrit-Owner: Niharika29 
Gerrit-Reviewer: Brian Wolff 
Gerrit-Reviewer: MaxSem 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...LoginNotify[wmf/1.30.0-wmf.15]: Fix typo where IP wasn't retrieved from job

2017-08-23 Thread Niharika29 (Code Review) 
Niharika29 has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/373387 )

Change subject: Fix typo where IP wasn't retrieved from job
..

Fix typo where IP wasn't retrieved from job

I think this might be causing T173888
(Although I don't really know)

Bug: T173888
Change-Id: I8d64a8b1c6607cb5b32a25182ec3496477322fdd
(cherry picked from commit 23f4a71831987998f0de95b6de7427ba6c8c129f)
---
M includes/DeferredChecksJob.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/LoginNotify 
refs/changes/87/373387/1

diff --git a/includes/DeferredChecksJob.php b/includes/DeferredChecksJob.php
index 05096eb..9bfeb42 100644
--- a/includes/DeferredChecksJob.php
+++ b/includes/DeferredChecksJob.php
@@ -40,7 +40,7 @@
. print_r( $this->params['subnet'], true )
);
}
-   $subnet = $this->params['resultSoFar'];
+   $subnet = $this->params['subnet'];
if ( !isset( $this->params['resultSoFar'] ) || !is_string( 
$this->params['resultSoFar'] ) ) {
throw new Exception( __CLASS__
. " expected to receive a string parameter 
'resultSoFar', got "

-- 
To view, visit https://gerrit.wikimedia.org/r/373387
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8d64a8b1c6607cb5b32a25182ec3496477322fdd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/LoginNotify
Gerrit-Branch: wmf/1.30.0-wmf.15
Gerrit-Owner: Niharika29 
Gerrit-Reviewer: Brian Wolff 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits