[MediaWiki-commits] [Gerrit] mediawiki...MixedNamespaceSearchSuggestions[master]: Fix PHP notice

2017-11-10 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/390416 )

Change subject: Fix PHP notice
..


Fix PHP notice

A rookie mistake that simple testing would have caught.

Change-Id: If5c398c8ec9ce6d6ada0f4a4fb1d0601b9284922
---
M MixedNamespaceSearchSuggestionsHooks.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Umherirrender: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/MixedNamespaceSearchSuggestionsHooks.php 
b/MixedNamespaceSearchSuggestionsHooks.php
index 0b51555..986fe98 100644
--- a/MixedNamespaceSearchSuggestionsHooks.php
+++ b/MixedNamespaceSearchSuggestionsHooks.php
@@ -9,7 +9,7 @@
 * This is a hook function.
 * @param OutputPage $out The OutputPage, which wasn't yet obvious to 
the linter.
 */
-   public function onBeforePageDisplay( OutputPage $out ) {
+   public static function onBeforePageDisplay( OutputPage $out ) {
$out->addModules( 'ext.mnss.search' );
}
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/390416
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If5c398c8ec9ce6d6ada0f4a4fb1d0601b9284922
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MixedNamespaceSearchSuggestions
Gerrit-Branch: master
Gerrit-Owner: Nikerabbit 
Gerrit-Reviewer: Umherirrender 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...MixedNamespaceSearchSuggestions[master]: Fix PHP notice

2017-11-10 Thread Nikerabbit (Code Review) 
Nikerabbit has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/390416 )

Change subject: Fix PHP notice
..

Fix PHP notice

A rookie mistake that simple testing would have caught.

Change-Id: If5c398c8ec9ce6d6ada0f4a4fb1d0601b9284922
---
M MixedNamespaceSearchSuggestionsHooks.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MixedNamespaceSearchSuggestions
 refs/changes/16/390416/1

diff --git a/MixedNamespaceSearchSuggestionsHooks.php 
b/MixedNamespaceSearchSuggestionsHooks.php
index 0b51555..986fe98 100644
--- a/MixedNamespaceSearchSuggestionsHooks.php
+++ b/MixedNamespaceSearchSuggestionsHooks.php
@@ -9,7 +9,7 @@
 * This is a hook function.
 * @param OutputPage $out The OutputPage, which wasn't yet obvious to 
the linter.
 */
-   public function onBeforePageDisplay( OutputPage $out ) {
+   public static function onBeforePageDisplay( OutputPage $out ) {
$out->addModules( 'ext.mnss.search' );
}
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/390416
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If5c398c8ec9ce6d6ada0f4a4fb1d0601b9284922
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MixedNamespaceSearchSuggestions
Gerrit-Branch: master
Gerrit-Owner: Nikerabbit 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits