[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[specialpages]: Default to regular font size in special mobileoptions
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/395606 ) Change subject: Default to regular font size in special mobileoptions .. Default to regular font size in special mobileoptions Raynor flagged that in incognito window the font size defaults to small. This corrects that. Bug: T169369 Change-Id: Idbe4c0f99cbb27a246647537e5ef0399efc1f4d6 --- M resources/mobile.special.mobileoptions.scripts/mobileoptions.js 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Pmiazga: Verified; Looks good to me, approved jenkins-bot: Verified diff --git a/resources/mobile.special.mobileoptions.scripts/mobileoptions.js b/resources/mobile.special.mobileoptions.scripts/mobileoptions.js index 4f454f9..228b142 100644 --- a/resources/mobile.special.mobileoptions.scripts/mobileoptions.js +++ b/resources/mobile.special.mobileoptions.scripts/mobileoptions.js @@ -48,10 +48,11 @@ * @ignore */ function addFontChangerToForm( $form ) { - var fontChanger, fontChangerDropdown; + var fontChanger, fontChangerDropdown, + currentFontSize = storage.get( FONT_SIZE_KEY ); fontChangerDropdown = new OO.ui.DropdownInputWidget( { - value: parseInt( storage.get( FONT_SIZE_KEY ), 10 ), + value: currentFontSize ? parseInt( currentFontSize, 10 ) : 100, options: [ { data: 90, -- To view, visit https://gerrit.wikimedia.org/r/395606 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idbe4c0f99cbb27a246647537e5ef0399efc1f4d6 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: specialpages Gerrit-Owner: JdlrobsonGerrit-Reviewer: Pmiazga Gerrit-Reviewer: jenkins-bot <> ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[specialpages]: Default to regular font size in special mobileoptions
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395606 ) Change subject: Default to regular font size in special mobileoptions .. Default to regular font size in special mobileoptions Raynor flagged that in incognito window the font size defaults to small. This corrects that. Bug: T169369 Change-Id: Idbe4c0f99cbb27a246647537e5ef0399efc1f4d6 --- M resources/mobile.special.mobileoptions.scripts/mobileoptions.js 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend refs/changes/06/395606/1 diff --git a/resources/mobile.special.mobileoptions.scripts/mobileoptions.js b/resources/mobile.special.mobileoptions.scripts/mobileoptions.js index 4f454f9..228b142 100644 --- a/resources/mobile.special.mobileoptions.scripts/mobileoptions.js +++ b/resources/mobile.special.mobileoptions.scripts/mobileoptions.js @@ -48,10 +48,11 @@ * @ignore */ function addFontChangerToForm( $form ) { - var fontChanger, fontChangerDropdown; + var fontChanger, fontChangerDropdown, + currentFontSize = storage.get( FONT_SIZE_KEY ); fontChangerDropdown = new OO.ui.DropdownInputWidget( { - value: parseInt( storage.get( FONT_SIZE_KEY ), 10 ), + value: currentFontSize ? parseInt( currentFontSize, 10 ) : 100, options: [ { data: 90, -- To view, visit https://gerrit.wikimedia.org/r/395606 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Idbe4c0f99cbb27a246647537e5ef0399efc1f4d6 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: specialpages Gerrit-Owner: Jdlrobson___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits