Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/399327 )
Change subject: Drop use of MobileOptionsTracking schema ...................................................................... Drop use of MobileOptionsTracking schema Going forward we can rely on pageview data to get a sense of how many users are in beta. Bug: T182235 Change-Id: I365a31a2e4d1cce280d89fc2a2004290e8ff548d --- M includes/specials/SpecialMobileOptions.php 1 file changed, 2 insertions(+), 23 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend refs/changes/27/399327/1 diff --git a/includes/specials/SpecialMobileOptions.php b/includes/specials/SpecialMobileOptions.php index 18ed4f1..84c52c1 100644 --- a/includes/specials/SpecialMobileOptions.php +++ b/includes/specials/SpecialMobileOptions.php @@ -202,12 +202,6 @@ * Saves the settings submitted by the settings form */ private function submitSettingsForm() { - $schema = 'MobileOptionsTracking'; - $schemaRevision = 16934032; - $schemaData = [ - 'action' => 'success', - 'beta' => "nochange", - ]; $context = MobileContext::singleton(); $request = $this->getRequest(); $user = $this->getUser(); @@ -218,27 +212,12 @@ $this->getOutput()->addHTML( '<div class="error">' . $this->msg( "mobile-frontend-save-error" )->parse() . '</div>' - ); - $schemaData['action'] = 'error'; - $schemaData['errorText'] = $errorText; - ExtMobileFrontend::eventLog( $schema, $schemaRevision, $schemaData ); + ) $this->addSettingsForm(); return; } - if ( $request->getBool( 'enableBeta' ) ) { - $group = 'beta'; - if ( !$context->isBetaGroupMember() ) { - // The request was to turn on beta - $schemaData['beta'] = "on"; - } - } else { - $group = ''; - if ( $context->isBetaGroupMember() ) { - // beta was turned off - $schemaData['beta'] = "off"; - } - } + $group = $request->getBool( 'enableBeta' ) ? 'beta' : ''; $context->setMobileMode( $group ); $url = $this->getPageTitle()->getFullURL( 'success' ); $context->getOutput()->redirect( MobileContext::singleton()->getMobileUrl( $url ) ); -- To view, visit https://gerrit.wikimedia.org/r/399327 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I365a31a2e4d1cce280d89fc2a2004290e8ff548d Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: specialpages Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits