[MediaWiki-commits] [Gerrit] mediawiki...ProofreadPage[wmf/1.30.0-wmf.14]: Revert to db7507246665e69384c1d92af2aedc62263a5116

2017-08-17 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/372427 )

Change subject: Revert to db7507246665e69384c1d92af2aedc62263a5116
..


Revert to db7507246665e69384c1d92af2aedc62263a5116

Moves function related to display out of PageDisplayHandler

This reverts commit 9e21fdabc8278889ea5f04c62931bdeee1a4db18.
This reverts commit e596fbd97018b2b9c476ec32406e4914d3e583d3
This reverts commit c98a61b1d8517cd6a255f71aaba5ca959bc81002
This reverts commit ab2eaeb9fbd51de38c6e2acf8018430ec7b0a89c
This reverts commit f6ca5179d7eec5ee72c0bd29607e4c0de22b03bc
This reverts commit 24f9d414fe856d21b16f54074d5130e9b9251198
This reverts commit 760d213788061dc8d6dfbc7724dfe4c8ad18ef6a
This reverts commit b48f361d7d606eff5ab48cc2a64c1cae4e794c84.

Bug: T173520
Change-Id: Ia419c028f1578792e1d7dc9c6e14d192d4264f38
---
M ProofreadPage.body.php
M ProofreadPage.namespaces.php
M composer.json
M extension.json
M i18n/mr.json
M i18n/ug-arab.json
M includes/Context.php
M includes/Pagination/PageList.php
M includes/Pagination/PageNumber.php
M includes/Pagination/Pagination.php
M includes/Parser/PagesTagParser.php
M includes/ProofreadPageInit.php
D includes/index/CustomIndexFieldsParser.php
M includes/index/EditIndexPage.php
M includes/index/IndexContent.php
M includes/index/IndexContentHandler.php
D includes/index/IndexDifferenceEngine.php
M includes/index/ProofreadIndexDbConnector.php
R includes/index/ProofreadIndexEntry.php
M includes/index/ProofreadIndexPage.php
M includes/page/PageContentBuilder.php
M includes/page/PageDifferenceEngine.php
M includes/page/PageDisplayHandler.php
M includes/page/PageLevel.php
M includes/page/ProofreadPageDbConnector.php
M includes/page/ProofreadPagePage.php
M phpcs.xml
M tests/phpunit/ContextTest.php
M tests/phpunit/FileProviderTest.php
M tests/phpunit/Pagination/FilePaginationTest.php
M tests/phpunit/Pagination/PagePaginationTest.php
M tests/phpunit/Pagination/PaginationFactoryTest.php
M tests/phpunit/ProofreadPageInitTest.php
M tests/phpunit/ProofreadPageTestCase.php
D tests/phpunit/index/CustomIndexFieldsParserTest.php
M tests/phpunit/index/IndexContentTest.php
M tests/phpunit/index/IndexRedirectContentTest.php
M tests/phpunit/index/ProofreadIndexPageTest.php
M tests/phpunit/page/PageContentBuilderTest.php
M tests/phpunit/page/PageContentTest.php
M tests/phpunit/page/PageDisplayHandlerTest.php
M tests/phpunit/page/PageLevelTest.php
M tests/phpunit/page/ProofreadPagePageTest.php
43 files changed, 738 insertions(+), 934 deletions(-)

Approvals:
  Aaron Schulz: Looks good to me, but someone else must approve
  Thcipriani: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/ProofreadPage.body.php b/ProofreadPage.body.php
index 56b01ed..eda957a 100644
--- a/ProofreadPage.body.php
+++ b/ProofreadPage.body.php
@@ -38,7 +38,7 @@
 *
 * Returns id of Page namespace.
 *
-* @return int
+* @return integer
 */
public static function getPageNamespaceId() {
return Context::getDefaultContext()->getPageNamespaceId();
@@ -49,7 +49,7 @@
 *
 * Returns id of Index namespace.
 *
-* @return int
+* @return integer
 */
public static function getIndexNamespaceId() {
return Context::getDefaultContext()->getIndexNamespaceId();
@@ -86,7 +86,7 @@
 *
 * @param Title $title the title page
 * @param string $model the content model for the page
-* @return bool if we have to continue the research for a content 
handler
+* @return boolean if we have to continue the research for a content 
handler
 */
public static function onContentHandlerDefaultModelFor( Title $title, 
&$model ) {
if ( $title->inNamespace( self::getPageNamespaceId() ) ) {
@@ -104,7 +104,7 @@
 * Set up our custom parser hooks when initializing parser.
 *
 * @param Parser $parser
-* @return bool hook return value
+* @return boolean hook return value
 */
public static function onParserFirstCallInit( Parser $parser ) {
$parser->setHook(
diff --git a/ProofreadPage.namespaces.php b/ProofreadPage.namespaces.php
index 63216c2..572dcd7 100644
--- a/ProofreadPage.namespaces.php
+++ b/ProofreadPage.namespaces.php
@@ -240,7 +240,7 @@
'page' => 'ಪುಟ',
'page_talk' => 'ಪುಟ_ಚರ್ಚೆ',
'index' => 'ಪರಿವಿಡಿ',
-   'index_talk' => 'ಪರಿವಿಡಿ_ಚರ್ಚೆ'
+   'index_talk' =>  'ಪರಿವಿಡಿ_ಚರ್ಚೆ'
 ];
 
 /** Korean (한국어) */
@@ -264,7 +264,7 @@
'page' => 'താൾ',
'page_talk' => 'താളിന്റെ_സംവാദം',
'index' => 'സൂചിക',
-   'index_talk' => 'സൂചികയുടെ_സംവാദം'
+   'index_talk' =>  'സൂചികയുടെ_സംവാദം'
 ];
 
 /** Marathi (मराठी) */
@@ -272,7 +272,7 @@
'page' => 'पान',
'page_talk' => 'पान_चर्चा',
'index' => 'अनुक्रमणिका',
-

[MediaWiki-commits] [Gerrit] mediawiki...ProofreadPage[wmf/1.30.0-wmf.14]: Revert to db7507246665e69384c1d92af2aedc62263a5116

2017-08-17 Thread Thcipriani (Code Review) 
Thcipriani has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/372427 )

Change subject: Revert to db7507246665e69384c1d92af2aedc62263a5116
..

Revert to db7507246665e69384c1d92af2aedc62263a5116

Moves function related to display out of PageDisplayHandler

This reverts commit 9e21fdabc8278889ea5f04c62931bdeee1a4db18.
This reverts commit e596fbd97018b2b9c476ec32406e4914d3e583d3
This reverts commit c98a61b1d8517cd6a255f71aaba5ca959bc81002
This reverts commit ab2eaeb9fbd51de38c6e2acf8018430ec7b0a89c
This reverts commit f6ca5179d7eec5ee72c0bd29607e4c0de22b03bc
This reverts commit 24f9d414fe856d21b16f54074d5130e9b9251198
This reverts commit 760d213788061dc8d6dfbc7724dfe4c8ad18ef6a
This reverts commit b48f361d7d606eff5ab48cc2a64c1cae4e794c84.

Bug: T173520
Change-Id: Ia419c028f1578792e1d7dc9c6e14d192d4264f38
---
M ProofreadPage.body.php
M ProofreadPage.namespaces.php
M composer.json
M extension.json
M i18n/mr.json
M i18n/ug-arab.json
M includes/Context.php
M includes/Pagination/PageList.php
M includes/Pagination/PageNumber.php
M includes/Pagination/Pagination.php
M includes/Parser/PagesTagParser.php
M includes/ProofreadPageInit.php
D includes/index/CustomIndexFieldsParser.php
M includes/index/EditIndexPage.php
M includes/index/IndexContent.php
M includes/index/IndexContentHandler.php
D includes/index/IndexDifferenceEngine.php
M includes/index/ProofreadIndexDbConnector.php
R includes/index/ProofreadIndexEntry.php
M includes/index/ProofreadIndexPage.php
M includes/page/PageContentBuilder.php
M includes/page/PageDifferenceEngine.php
M includes/page/PageDisplayHandler.php
M includes/page/PageLevel.php
M includes/page/ProofreadPageDbConnector.php
M includes/page/ProofreadPagePage.php
M phpcs.xml
M tests/phpunit/ContextTest.php
M tests/phpunit/FileProviderTest.php
M tests/phpunit/Pagination/FilePaginationTest.php
M tests/phpunit/Pagination/PagePaginationTest.php
M tests/phpunit/Pagination/PaginationFactoryTest.php
M tests/phpunit/ProofreadPageInitTest.php
M tests/phpunit/ProofreadPageTestCase.php
D tests/phpunit/index/CustomIndexFieldsParserTest.php
M tests/phpunit/index/IndexContentTest.php
M tests/phpunit/index/IndexRedirectContentTest.php
M tests/phpunit/index/ProofreadIndexPageTest.php
M tests/phpunit/page/PageContentBuilderTest.php
M tests/phpunit/page/PageContentTest.php
M tests/phpunit/page/PageDisplayHandlerTest.php
M tests/phpunit/page/PageLevelTest.php
M tests/phpunit/page/ProofreadPagePageTest.php
43 files changed, 738 insertions(+), 934 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ProofreadPage 
refs/changes/27/372427/1

diff --git a/ProofreadPage.body.php b/ProofreadPage.body.php
index 56b01ed..eda957a 100644
--- a/ProofreadPage.body.php
+++ b/ProofreadPage.body.php
@@ -38,7 +38,7 @@
 *
 * Returns id of Page namespace.
 *
-* @return int
+* @return integer
 */
public static function getPageNamespaceId() {
return Context::getDefaultContext()->getPageNamespaceId();
@@ -49,7 +49,7 @@
 *
 * Returns id of Index namespace.
 *
-* @return int
+* @return integer
 */
public static function getIndexNamespaceId() {
return Context::getDefaultContext()->getIndexNamespaceId();
@@ -86,7 +86,7 @@
 *
 * @param Title $title the title page
 * @param string $model the content model for the page
-* @return bool if we have to continue the research for a content 
handler
+* @return boolean if we have to continue the research for a content 
handler
 */
public static function onContentHandlerDefaultModelFor( Title $title, 
&$model ) {
if ( $title->inNamespace( self::getPageNamespaceId() ) ) {
@@ -104,7 +104,7 @@
 * Set up our custom parser hooks when initializing parser.
 *
 * @param Parser $parser
-* @return bool hook return value
+* @return boolean hook return value
 */
public static function onParserFirstCallInit( Parser $parser ) {
$parser->setHook(
diff --git a/ProofreadPage.namespaces.php b/ProofreadPage.namespaces.php
index 63216c2..572dcd7 100644
--- a/ProofreadPage.namespaces.php
+++ b/ProofreadPage.namespaces.php
@@ -240,7 +240,7 @@
'page' => 'ಪುಟ',
'page_talk' => 'ಪುಟ_ಚರ್ಚೆ',
'index' => 'ಪರಿವಿಡಿ',
-   'index_talk' => 'ಪರಿವಿಡಿ_ಚರ್ಚೆ'
+   'index_talk' =>  'ಪರಿವಿಡಿ_ಚರ್ಚೆ'
 ];
 
 /** Korean (한국어) */
@@ -264,7 +264,7 @@
'page' => 'താൾ',
'page_talk' => 'താളിന്റെ_സംവാദം',
'index' => 'സൂചിക',
-   'index_talk' => 'സൂചികയുടെ_സംവാദം'
+   'index_talk' =>  'സൂചികയുടെ_സംവാദം'
 ];
 
 /** Marathi (मराठी) */
@@ -272,7 +272,7 @@
'page' => 'पान',
'page_talk' => 'पान_चर्चा',
'index' => 'अनुक्रमणिका',
-   'index_talk' => 'अनुक्रमणिका_चर्चा'
+