[MediaWiki-commits] [Gerrit] mediawiki...SyntaxHighlight_GeSHi[master]: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/400929 ) Change subject: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 .. build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 Change-Id: If136f446383a4b7563bf5c6d26c1af64513caf09 --- M SyntaxHighlight.php M composer.json 2 files changed, 2 insertions(+), 3 deletions(-) Approvals: Legoktm: Looks good to me, approved jenkins-bot: Verified diff --git a/SyntaxHighlight.php b/SyntaxHighlight.php index 3961c33..ee7eda5 100644 --- a/SyntaxHighlight.php +++ b/SyntaxHighlight.php @@ -386,8 +386,7 @@ // to DoS the system by asking for a huge range. // Impose an arbitrary limit on the number of lines in a // given range to reduce the impact. - return - ctype_digit( $start ) && + return ctype_digit( $start ) && ctype_digit( $end ) && $start > 0 && $start < $end && diff --git a/composer.json b/composer.json index 2725a84..e4c5736 100644 --- a/composer.json +++ b/composer.json @@ -6,7 +6,7 @@ }, "require-dev": { "jakub-onderka/php-parallel-lint": "0.9.2", - "mediawiki/mediawiki-codesniffer": "14.1.0", + "mediawiki/mediawiki-codesniffer": "15.0.0", "jakub-onderka/php-console-highlighter": "0.3.2", "mediawiki/minus-x": "0.2.1" }, -- To view, visit https://gerrit.wikimedia.org/r/400929 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: If136f446383a4b7563bf5c6d26c1af64513caf09 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SyntaxHighlight_GeSHi Gerrit-Branch: master Gerrit-Owner: LibraryupgraderGerrit-Reviewer: Legoktm Gerrit-Reviewer: jenkins-bot <> ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] mediawiki...SyntaxHighlight_GeSHi[master]: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0
Libraryupgrader has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/400929 ) Change subject: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 .. build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 Change-Id: If136f446383a4b7563bf5c6d26c1af64513caf09 --- M SyntaxHighlight.php M composer.json 2 files changed, 2 insertions(+), 3 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SyntaxHighlight_GeSHi refs/changes/29/400929/1 diff --git a/SyntaxHighlight.php b/SyntaxHighlight.php index 3961c33..ee7eda5 100644 --- a/SyntaxHighlight.php +++ b/SyntaxHighlight.php @@ -386,8 +386,7 @@ // to DoS the system by asking for a huge range. // Impose an arbitrary limit on the number of lines in a // given range to reduce the impact. - return - ctype_digit( $start ) && + return ctype_digit( $start ) && ctype_digit( $end ) && $start > 0 && $start < $end && diff --git a/composer.json b/composer.json index 2725a84..e4c5736 100644 --- a/composer.json +++ b/composer.json @@ -6,7 +6,7 @@ }, "require-dev": { "jakub-onderka/php-parallel-lint": "0.9.2", - "mediawiki/mediawiki-codesniffer": "14.1.0", + "mediawiki/mediawiki-codesniffer": "15.0.0", "jakub-onderka/php-console-highlighter": "0.3.2", "mediawiki/minus-x": "0.2.1" }, -- To view, visit https://gerrit.wikimedia.org/r/400929 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If136f446383a4b7563bf5c6d26c1af64513caf09 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SyntaxHighlight_GeSHi Gerrit-Branch: master Gerrit-Owner: Libraryupgrader___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits