[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[wmf/1.29.0-wmf.5]: Use deep clone for empty convertFromSource

2016-12-14 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/327375 )

Change subject: Use deep clone for empty convertFromSource
..


Use deep clone for empty convertFromSource

Bug: T153254
Change-Id: I0dc6be0d20020e3fb385c9d065f9395dbda5a6b6
(cherry picked from commit 854256bb8e5b5a8298d8904f1e938722cb4140c1)
---
M modules/ve-mw/dm/ve.dm.MWWikitextSurfaceFragment.js
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Alex Monk: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/ve-mw/dm/ve.dm.MWWikitextSurfaceFragment.js 
b/modules/ve-mw/dm/ve.dm.MWWikitextSurfaceFragment.js
index 68c5850..5cd872c 100644
--- a/modules/ve-mw/dm/ve.dm.MWWikitextSurfaceFragment.js
+++ b/modules/ve-mw/dm/ve.dm.MWWikitextSurfaceFragment.js
@@ -155,7 +155,7 @@
var parsePromise;
if ( !source ) {
parsePromise = $.Deferred().resolve(
-   this.getDocument().shallowCloneFromRange( new ve.Range( 
0 ) )
+   this.getDocument().cloneFromRange( new ve.Range( 0 ) )
).promise();
} else {
parsePromise = new mw.Api().post( {

-- 
To view, visit https://gerrit.wikimedia.org/r/327375
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0dc6be0d20020e3fb385c9d065f9395dbda5a6b6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: wmf/1.29.0-wmf.5
Gerrit-Owner: Jforrester 
Gerrit-Reviewer: Alex Monk 
Gerrit-Reviewer: Esanders 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[wmf/1.29.0-wmf.5]: Use deep clone for empty convertFromSource

2016-12-14 Thread Jforrester (Code Review) 
Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/327375 )

Change subject: Use deep clone for empty convertFromSource
..

Use deep clone for empty convertFromSource

Bug: T153254
Change-Id: I0dc6be0d20020e3fb385c9d065f9395dbda5a6b6
(cherry picked from commit 854256bb8e5b5a8298d8904f1e938722cb4140c1)
---
M modules/ve-mw/dm/ve.dm.MWWikitextSurfaceFragment.js
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/75/327375/1

diff --git a/modules/ve-mw/dm/ve.dm.MWWikitextSurfaceFragment.js 
b/modules/ve-mw/dm/ve.dm.MWWikitextSurfaceFragment.js
index 68c5850..5cd872c 100644
--- a/modules/ve-mw/dm/ve.dm.MWWikitextSurfaceFragment.js
+++ b/modules/ve-mw/dm/ve.dm.MWWikitextSurfaceFragment.js
@@ -155,7 +155,7 @@
var parsePromise;
if ( !source ) {
parsePromise = $.Deferred().resolve(
-   this.getDocument().shallowCloneFromRange( new ve.Range( 
0 ) )
+   this.getDocument().cloneFromRange( new ve.Range( 0 ) )
).promise();
} else {
parsePromise = new mw.Api().post( {

-- 
To view, visit https://gerrit.wikimedia.org/r/327375
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0dc6be0d20020e3fb385c9d065f9395dbda5a6b6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: wmf/1.29.0-wmf.5
Gerrit-Owner: Jforrester 
Gerrit-Reviewer: Esanders 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits