[MediaWiki-commits] [Gerrit] mediawiki...WikibaseQualityConstraints[master]: Rename WikibaseQualityConstraintsHooks function

2017-12-05 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/395589 )

Change subject: Rename WikibaseQualityConstraintsHooks function
..


Rename WikibaseQualityConstraintsHooks function

It now checks not only whether the statements were changed, but whether
the *constraint* statements changed, so let’s update the method name to
reflect that.

Bug: T182110
Change-Id: I6fc3d8dbe49ede6833007e76d21403639ec7e1a7
---
M WikibaseQualityConstraintsHooks.php
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Ladsgroup: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/WikibaseQualityConstraintsHooks.php 
b/WikibaseQualityConstraintsHooks.php
index 05b4316..9970f27 100644
--- a/WikibaseQualityConstraintsHooks.php
+++ b/WikibaseQualityConstraintsHooks.php
@@ -36,7 +36,7 @@
 
public static function onWikibaseChange( Change $change ) {
if ( MediaWikiServices::getInstance()->getMainConfig()->get( 
'WBQualityConstraintsEnableConstraintsImportFromStatements' ) &&
-   self::isPropertyStatementsChange( $change )
+   self::isConstraintStatementsChange( $change )
) {
/** @var EntityChange $change */
$title = Title::newMainPage();
@@ -47,7 +47,7 @@
}
}
 
-   private static function isPropertyStatementsChange( Change $change ) {
+   private static function isConstraintStatementsChange( Change $change ) {
if ( !( $change instanceof EntityChange ) ||
 $change->getAction() !== EntityChange::UPDATE ||
 !( $change->getEntityId() instanceof PropertyId )

-- 
To view, visit https://gerrit.wikimedia.org/r/395589
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6fc3d8dbe49ede6833007e76d21403639ec7e1a7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseQualityConstraints
Gerrit-Branch: master
Gerrit-Owner: Lucas Werkmeister (WMDE) 
Gerrit-Reviewer: Ladsgroup 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseQualityConstraints[master]: Rename WikibaseQualityConstraintsHooks function

2017-12-05 Thread Lucas Werkmeister (WMDE) (Code Review) 
Lucas Werkmeister (WMDE) has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/395589 )

Change subject: Rename WikibaseQualityConstraintsHooks function
..

Rename WikibaseQualityConstraintsHooks function

It now checks not only whether the statements were changed, but whether
the *constraint* statements changed, so let’s update the method name to
reflect that.

Bug: T182110
Change-Id: I6fc3d8dbe49ede6833007e76d21403639ec7e1a7
---
M WikibaseQualityConstraintsHooks.php
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikibaseQualityConstraints
 refs/changes/89/395589/1

diff --git a/WikibaseQualityConstraintsHooks.php 
b/WikibaseQualityConstraintsHooks.php
index 05b4316..9970f27 100644
--- a/WikibaseQualityConstraintsHooks.php
+++ b/WikibaseQualityConstraintsHooks.php
@@ -36,7 +36,7 @@
 
public static function onWikibaseChange( Change $change ) {
if ( MediaWikiServices::getInstance()->getMainConfig()->get( 
'WBQualityConstraintsEnableConstraintsImportFromStatements' ) &&
-   self::isPropertyStatementsChange( $change )
+   self::isConstraintStatementsChange( $change )
) {
/** @var EntityChange $change */
$title = Title::newMainPage();
@@ -47,7 +47,7 @@
}
}
 
-   private static function isPropertyStatementsChange( Change $change ) {
+   private static function isConstraintStatementsChange( Change $change ) {
if ( !( $change instanceof EntityChange ) ||
 $change->getAction() !== EntityChange::UPDATE ||
 !( $change->getEntityId() instanceof PropertyId )

-- 
To view, visit https://gerrit.wikimedia.org/r/395589
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6fc3d8dbe49ede6833007e76d21403639ec7e1a7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseQualityConstraints
Gerrit-Branch: master
Gerrit-Owner: Lucas Werkmeister (WMDE) 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits