[MediaWiki-commits] [Gerrit] mediawiki...WikibaseQualityConstraints[master]: Update typehint for MediaWikiServices::getStatsdDataFactory

2017-07-08 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/363998 )

Change subject: Update typehint for MediaWikiServices::getStatsdDataFactory
..


Update typehint for MediaWikiServices::getStatsdDataFactory

Follows-up I6897f8243ce (a10bd20059).

Depends-On: I06de59122625f9c23e7c1a1bfa69a7ddabbf379e
Change-Id: I734505a1b3daf46f816888c1955d64632a2084c5
---
M includes/ConstraintCheck/Helper/SparqlHelper.php
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Jonas Kress (WMDE): Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/ConstraintCheck/Helper/SparqlHelper.php 
b/includes/ConstraintCheck/Helper/SparqlHelper.php
index 474214e..11a877b 100644
--- a/includes/ConstraintCheck/Helper/SparqlHelper.php
+++ b/includes/ConstraintCheck/Helper/SparqlHelper.php
@@ -4,7 +4,7 @@
 
 use Config;
 use Http;
-use MediawikiStatsdDataFactory;
+use IBufferingStatsdDataFactory;
 use MediaWiki\MediaWikiServices;
 use Wikibase\DataModel\Entity\EntityIdParser;
 use Wikibase\DataModel\Entity\EntityIdParsingException;
@@ -42,7 +42,7 @@
private $entityIdParser;
 
/**
-* @var MediawikiStatsdDataFactory
+* @var IBufferingStatsdDataFactory
 */
private $dataFactory;
 

-- 
To view, visit https://gerrit.wikimedia.org/r/363998
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I734505a1b3daf46f816888c1955d64632a2084c5
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/WikibaseQualityConstraints
Gerrit-Branch: master
Gerrit-Owner: Krinkle 
Gerrit-Reviewer: Jonas Kress (WMDE) 
Gerrit-Reviewer: Krinkle 
Gerrit-Reviewer: Smalyshev 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] mediawiki...WikibaseQualityConstraints[master]: Update typehint for MediaWikiServices::getStatsdDataFactory

2017-07-07 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/363998 )

Change subject: Update typehint for MediaWikiServices::getStatsdDataFactory
..

Update typehint for MediaWikiServices::getStatsdDataFactory

Follows-up I6897f8243ce (a10bd20059).

Depends-On: I06de59122625f9c23e7c1a1bfa69a7ddabbf379e
Change-Id: I734505a1b3daf46f816888c1955d64632a2084c5
---
M includes/ConstraintCheck/Helper/SparqlHelper.php
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikibaseQualityConstraints
 refs/changes/98/363998/1

diff --git a/includes/ConstraintCheck/Helper/SparqlHelper.php 
b/includes/ConstraintCheck/Helper/SparqlHelper.php
index 474214e..11a877b 100644
--- a/includes/ConstraintCheck/Helper/SparqlHelper.php
+++ b/includes/ConstraintCheck/Helper/SparqlHelper.php
@@ -4,7 +4,7 @@
 
 use Config;
 use Http;
-use MediawikiStatsdDataFactory;
+use IBufferingStatsdDataFactory;
 use MediaWiki\MediaWikiServices;
 use Wikibase\DataModel\Entity\EntityIdParser;
 use Wikibase\DataModel\Entity\EntityIdParsingException;
@@ -42,7 +42,7 @@
private $entityIdParser;
 
/**
-* @var MediawikiStatsdDataFactory
+* @var IBufferingStatsdDataFactory
 */
private $dataFactory;
 

-- 
To view, visit https://gerrit.wikimedia.org/r/363998
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I734505a1b3daf46f816888c1955d64632a2084c5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseQualityConstraints
Gerrit-Branch: master
Gerrit-Owner: Krinkle 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits