[MediaWiki-commits] [Gerrit] mediawiki...WikimediaEvents[wmf/1.31.0-wmf.5]: Turn on Cirrus AB test for DBN group sizing
jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/387956 )
Change subject: Turn on Cirrus AB test for DBN group sizing
..
Turn on Cirrus AB test for DBN group sizing
Change-Id: I6b7963af774dd5ca2f9da7c03ae97a1180004753
(cherry picked from commit 62d7c4f375395f1360634b7363d10abc955b9b88)
---
M extension.json
M modules/ext.wikimediaEvents.searchSatisfaction.js
2 files changed, 20 insertions(+), 6 deletions(-)
Approvals:
Thcipriani: Looks good to me, approved
jenkins-bot: Verified
diff --git a/extension.json b/extension.json
index 18556d4..1de11da 100644
--- a/extension.json
+++ b/extension.json
@@ -107,6 +107,11 @@
"schema": "CompletionSuggestions",
"revision": 13630018
},
+ "schema.SearchSatisfaction": {
+ "class": "ResourceLoaderSchemaModule",
+ "schema": "SearchSatisfaction",
+ "revision": 17374996
+ },
"schema.TestSearchSatisfaction2": {
"class": "ResourceLoaderSchemaModule",
"schema": "TestSearchSatisfaction2",
diff --git a/modules/ext.wikimediaEvents.searchSatisfaction.js
b/modules/ext.wikimediaEvents.searchSatisfaction.js
index 4f743e0..40b1cc1 100644
--- a/modules/ext.wikimediaEvents.searchSatisfaction.js
+++ b/modules/ext.wikimediaEvents.searchSatisfaction.js
@@ -113,7 +113,9 @@
function initialize( session ) {
var sessionId = session.get( 'sessionId' ),
- validBuckets = [],
+ validBuckets = mw.config.get( 'wgDBname' ) ===
'enwiki' ?
+ [ 'control', 'dbn20', 'dbn20-i',
'dbn35', 'dbn35-i' ] :
+ [],
sampleSize = ( function () {
var dbName = mw.config.get( 'wgDBname'
),
// Provides a place to handle
wiki-specific sampling,
@@ -134,9 +136,12 @@
test: 350,
subTest: null
},
+ // .0005 works out to
~2.7k sessions per week.
+ // .15 increases that
to 810k per week. Giving
+ // 160k sessions per
bucket per week.
enwiki: {
- test: 2000,
- subTest: null
+ test: 0.15,
+ subTest: 0.996
},
enwiktionary: {
test: 40,
@@ -529,7 +534,11 @@
function genLogEventFn( source, session ) {
return function ( action, extraData ) {
- var scrollTop = $( window ).scrollTop(),
+ // A/B testing data is verbose and blacklisted from
mysql. Our dashboarding though
+ // still sources data from mysql. For that reason send
AB test data to different
+ // schema.
+ var schema = session.get( 'subTest' ) ?
'SearchSatisfaction' : 'TestSearchSatisfaction2',
+ scrollTop = $( window ).scrollTop(),
evt = {
// searchResultPage, visitPage,
checkin, click or iwclick
action: action,
@@ -583,9 +592,9 @@
}
// ship the event
- mw.loader.using( [ 'schema.TestSearchSatisfaction2' ]
).then( function () {
+ mw.loader.using( [ 'schema.' + schema ] ).then(
function () {
eventLog = eventLog || extendMwEventLog();
- eventLog.logEvent( 'TestSearchSatisfaction2',
evt );
+ eventLog.logEvent( schema, evt );
} );
};
}
--
To view, visit https://gerrit.wikimedia.org/r/387956
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6b7963af774dd5ca2f9da7c03ae97a1180004753
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikimediaEvents
Gerrit-Branch: wmf
[MediaWiki-commits] [Gerrit] mediawiki...WikimediaEvents[wmf/1.31.0-wmf.5]: Turn on Cirrus AB test for DBN group sizing
EBernhardson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/387956 )
Change subject: Turn on Cirrus AB test for DBN group sizing
..
Turn on Cirrus AB test for DBN group sizing
Change-Id: I6b7963af774dd5ca2f9da7c03ae97a1180004753
(cherry picked from commit 62d7c4f375395f1360634b7363d10abc955b9b88)
---
M extension.json
M modules/ext.wikimediaEvents.searchSatisfaction.js
2 files changed, 20 insertions(+), 6 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikimediaEvents
refs/changes/56/387956/1
diff --git a/extension.json b/extension.json
index 18556d4..1de11da 100644
--- a/extension.json
+++ b/extension.json
@@ -107,6 +107,11 @@
"schema": "CompletionSuggestions",
"revision": 13630018
},
+ "schema.SearchSatisfaction": {
+ "class": "ResourceLoaderSchemaModule",
+ "schema": "SearchSatisfaction",
+ "revision": 17374996
+ },
"schema.TestSearchSatisfaction2": {
"class": "ResourceLoaderSchemaModule",
"schema": "TestSearchSatisfaction2",
diff --git a/modules/ext.wikimediaEvents.searchSatisfaction.js
b/modules/ext.wikimediaEvents.searchSatisfaction.js
index 4f743e0..40b1cc1 100644
--- a/modules/ext.wikimediaEvents.searchSatisfaction.js
+++ b/modules/ext.wikimediaEvents.searchSatisfaction.js
@@ -113,7 +113,9 @@
function initialize( session ) {
var sessionId = session.get( 'sessionId' ),
- validBuckets = [],
+ validBuckets = mw.config.get( 'wgDBname' ) ===
'enwiki' ?
+ [ 'control', 'dbn20', 'dbn20-i',
'dbn35', 'dbn35-i' ] :
+ [],
sampleSize = ( function () {
var dbName = mw.config.get( 'wgDBname'
),
// Provides a place to handle
wiki-specific sampling,
@@ -134,9 +136,12 @@
test: 350,
subTest: null
},
+ // .0005 works out to
~2.7k sessions per week.
+ // .15 increases that
to 810k per week. Giving
+ // 160k sessions per
bucket per week.
enwiki: {
- test: 2000,
- subTest: null
+ test: 0.15,
+ subTest: 0.996
},
enwiktionary: {
test: 40,
@@ -529,7 +534,11 @@
function genLogEventFn( source, session ) {
return function ( action, extraData ) {
- var scrollTop = $( window ).scrollTop(),
+ // A/B testing data is verbose and blacklisted from
mysql. Our dashboarding though
+ // still sources data from mysql. For that reason send
AB test data to different
+ // schema.
+ var schema = session.get( 'subTest' ) ?
'SearchSatisfaction' : 'TestSearchSatisfaction2',
+ scrollTop = $( window ).scrollTop(),
evt = {
// searchResultPage, visitPage,
checkin, click or iwclick
action: action,
@@ -583,9 +592,9 @@
}
// ship the event
- mw.loader.using( [ 'schema.TestSearchSatisfaction2' ]
).then( function () {
+ mw.loader.using( [ 'schema.' + schema ] ).then(
function () {
eventLog = eventLog || extendMwEventLog();
- eventLog.logEvent( 'TestSearchSatisfaction2',
evt );
+ eventLog.logEvent( schema, evt );
} );
};
}
--
To view, visit https://gerrit.wikimedia.org/r/387956
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6b7963af774dd5ca2f9da7c03ae97a1180004753
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikimed
