[MediaWiki-commits] [Gerrit] performance[refs/meta/dashboards/custom]: Update "Other patches" to hide if already reviewed by MW or ...

2017-11-30 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/394511 )

Change subject: Update "Other patches" to hide if already reviewed by MW or WMF 
groups
..

Update "Other patches" to hide if already reviewed by MW or WMF groups

Because they're also authorised to review in mediawiki/core.

This means we still don't hide patches if they've already been
reviewed by guest accounts or accounts with rights elsewhere,
but also don't show all patches unless one of us has reviewed them.

Also update limits a bit.

Change-Id: Ib49ffecabbed7ba31aa25cefddc6de3437146528
---
M custom
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/performance refs/changes/11/394511/1

diff --git a/custom b/custom
index 1e167f6..4e767bb 100644
--- a/custom
+++ b/custom
@@ -4,10 +4,10 @@
 [section "Our patches awaiting review"]
   query = is:open ownerin:performance -owner:self -message:WIP -message:DNM 
-label:Verified<0 -label:Code-Review<0 limit:40
 [section "Other patches in subscribed areas"]
-  query = is:open -ownerin:performance -message:WIP -message:DNM 
-label:Verified<0 -label:Code-Review=-2 -label:Code-Review<0,group=performance 
(project:mediawiki/extensions/NavigationTiming OR 
project:mediawiki/extensions/PerformanceInspector OR project:performance OR 
project:performance/docroot OR project:performance/WebPageTest OR 
(project:mediawiki/core reviewerin:performance)) limit:20
+  query = is:open -ownerin:performance -message:WIP -message:DNM 
-label:Verified<0 -label:Code-Review=-2 -label:Code-Review<0,group=performance 
-label:Code-Review<0,group=mediawiki -label:Code-Review<0,group=wmf-deployment 
(project:mediawiki/extensions/NavigationTiming OR 
project:mediawiki/extensions/PerformanceInspector OR project:performance OR 
project:performance/docroot OR project:performance/WebPageTest OR 
(project:mediawiki/core reviewerin:performance)) limit:15
 [section "My patches awaiting review"]
   query = is:open ownerin:performance owner:self -message:WIP -message:DNM 
-label:Verified<0 -label:Code-Review<0 limit:40
 [section "My other patches"]
   query = is:open ownerin:performance owner:self (message:WIP OR message:DNM 
OR label:Verified<0 OR label:Code-Review<0) limit:40
 [section "Recently merged"]
-  query = is:merged ownerin:performance limit:30
+  query = is:merged ownerin:performance limit:15

-- 
To view, visit https://gerrit.wikimedia.org/r/394511
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib49ffecabbed7ba31aa25cefddc6de3437146528
Gerrit-PatchSet: 1
Gerrit-Project: performance
Gerrit-Branch: refs/meta/dashboards/custom
Gerrit-Owner: Krinkle 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] performance[refs/meta/dashboards/custom]: Update "Other patches" to hide if already reviewed by MW or ...

2017-11-30 Thread Krinkle (Code Review)
Krinkle has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/394511 )

Change subject: Update "Other patches" to hide if already reviewed by MW or WMF 
groups
..


Update "Other patches" to hide if already reviewed by MW or WMF groups

Because they're also authorised to review in mediawiki/core.

This means we still don't hide patches if they've already been
reviewed by guest accounts or accounts with rights elsewhere,
but also don't show all patches unless one of us has reviewed them.

Also update limits a bit.

Change-Id: Ib49ffecabbed7ba31aa25cefddc6de3437146528
---
M custom
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Krinkle: Verified; Looks good to me, approved



diff --git a/custom b/custom
index 1e167f6..4e767bb 100644
--- a/custom
+++ b/custom
@@ -4,10 +4,10 @@
 [section "Our patches awaiting review"]
   query = is:open ownerin:performance -owner:self -message:WIP -message:DNM 
-label:Verified<0 -label:Code-Review<0 limit:40
 [section "Other patches in subscribed areas"]
-  query = is:open -ownerin:performance -message:WIP -message:DNM 
-label:Verified<0 -label:Code-Review=-2 -label:Code-Review<0,group=performance 
(project:mediawiki/extensions/NavigationTiming OR 
project:mediawiki/extensions/PerformanceInspector OR project:performance OR 
project:performance/docroot OR project:performance/WebPageTest OR 
(project:mediawiki/core reviewerin:performance)) limit:20
+  query = is:open -ownerin:performance -message:WIP -message:DNM 
-label:Verified<0 -label:Code-Review=-2 -label:Code-Review<0,group=performance 
-label:Code-Review<0,group=mediawiki -label:Code-Review<0,group=wmf-deployment 
(project:mediawiki/extensions/NavigationTiming OR 
project:mediawiki/extensions/PerformanceInspector OR project:performance OR 
project:performance/docroot OR project:performance/WebPageTest OR 
(project:mediawiki/core reviewerin:performance)) limit:15
 [section "My patches awaiting review"]
   query = is:open ownerin:performance owner:self -message:WIP -message:DNM 
-label:Verified<0 -label:Code-Review<0 limit:40
 [section "My other patches"]
   query = is:open ownerin:performance owner:self (message:WIP OR message:DNM 
OR label:Verified<0 OR label:Code-Review<0) limit:40
 [section "Recently merged"]
-  query = is:merged ownerin:performance limit:30
+  query = is:merged ownerin:performance limit:15

-- 
To view, visit https://gerrit.wikimedia.org/r/394511
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib49ffecabbed7ba31aa25cefddc6de3437146528
Gerrit-PatchSet: 1
Gerrit-Project: performance
Gerrit-Branch: refs/meta/dashboards/custom
Gerrit-Owner: Krinkle 
Gerrit-Reviewer: Krinkle 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits