[MediaWiki-commits] [Gerrit] wikimedia/wikimania-scholarships[master]: Remove Final:Full report from app

2016-12-03 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Remove Final:Full report from app
..


Remove Final:Full report from app

Bug: T151377
Change-Id: I492ff77c21c82092921ee015238b63bbd11c5497
---
M data/templates/base_auth.html
M src/App.php
D src/Controllers/Review/Scores.php
3 files changed, 0 insertions(+), 48 deletions(-)

Approvals:
  BryanDavis: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/data/templates/base_auth.html b/data/templates/base_auth.html
index 39f3e53..4bc9a65 100644
--- a/data/templates/base_auth.html
+++ b/data/templates/base_auth.html
@@ -31,7 +31,6 @@
 {{ 'phase-2'|message 
}}
 {% if isadmin|default(false) %}
 
-{{ 'final-full'|message 
}}
 {{ 
'nav-reports-export'|message }}
 {% endif %}
   
diff --git a/src/App.php b/src/App.php
index 9a94bb8..272d31b 100644
--- a/src/App.php
+++ b/src/App.php
@@ -432,12 +432,6 @@
$page();
} )->name( 'review_countries' );
 
-   $slim->get( 'scores', function () use ( $slim ) {
-   $page = new Controllers\Review\Scores( $slim );
-   $page->setDao( $slim->applyDao );
-   $page();
-   } )->name( 'review_scores' );
-
$slim->get( 'regions', function () use ( $slim ) {
$page = new Controllers\Review\Regions( $slim );
$page->setDao( $slim->applyDao );
diff --git a/src/Controllers/Review/Scores.php 
b/src/Controllers/Review/Scores.php
deleted file mode 100644
index 471e7a6..000
--- a/src/Controllers/Review/Scores.php
+++ /dev/null
@@ -1,41 +0,0 @@
-http://www.gnu.org/licenses/>.
- *
- * @file
- */
-
-namespace Wikimania\Scholarship\Controllers\Review;
-
-use Wikimedia\Slimapp\Controller;
-
-/**
- * List applications by score.
- *
- * @author Bryan Davis 
- * @copyright © 2013 Bryan Davis and Wikimedia Foundation.
- */
-class Scores extends Controller {
-
-   protected function handleGet() {
-   $rows = $this->dao->getP2List( 'All' );
-   $this->view->set( 'records', $rows );
-   $this->render( 'review/scores.html' );
-   }
-
-}

-- 
To view, visit https://gerrit.wikimedia.org/r/324715
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I492ff77c21c82092921ee015238b63bbd11c5497
Gerrit-PatchSet: 2
Gerrit-Project: wikimedia/wikimania-scholarships
Gerrit-Branch: master
Gerrit-Owner: Niharika29 
Gerrit-Reviewer: BryanDavis 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] wikimedia/wikimania-scholarships[master]: Remove Final:Full report from app

2016-12-01 Thread Niharika29 (Code Review) 
Niharika29 has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/324715

Change subject: Remove Final:Full report from app
..

Remove Final:Full report from app

Bug: T151377
Change-Id: I492ff77c21c82092921ee015238b63bbd11c5497
---
M data/templates/base_auth.html
M src/App.php
D src/Controllers/Review/Scores.php
3 files changed, 0 insertions(+), 48 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/wikimedia/wikimania-scholarships 
refs/changes/15/324715/1

diff --git a/data/templates/base_auth.html b/data/templates/base_auth.html
index 39f3e53..4bc9a65 100644
--- a/data/templates/base_auth.html
+++ b/data/templates/base_auth.html
@@ -31,7 +31,6 @@
 {{ 'phase-2'|message 
}}
 {% if isadmin|default(false) %}
 
-{{ 'final-full'|message 
}}
 {{ 
'nav-reports-export'|message }}
 {% endif %}
   
diff --git a/src/App.php b/src/App.php
index 9a94bb8..272d31b 100644
--- a/src/App.php
+++ b/src/App.php
@@ -432,12 +432,6 @@
$page();
} )->name( 'review_countries' );
 
-   $slim->get( 'scores', function () use ( $slim ) {
-   $page = new Controllers\Review\Scores( $slim );
-   $page->setDao( $slim->applyDao );
-   $page();
-   } )->name( 'review_scores' );
-
$slim->get( 'regions', function () use ( $slim ) {
$page = new Controllers\Review\Regions( $slim );
$page->setDao( $slim->applyDao );
diff --git a/src/Controllers/Review/Scores.php 
b/src/Controllers/Review/Scores.php
deleted file mode 100644
index 471e7a6..000
--- a/src/Controllers/Review/Scores.php
+++ /dev/null
@@ -1,41 +0,0 @@
-http://www.gnu.org/licenses/>.
- *
- * @file
- */
-
-namespace Wikimania\Scholarship\Controllers\Review;
-
-use Wikimedia\Slimapp\Controller;
-
-/**
- * List applications by score.
- *
- * @author Bryan Davis 
- * @copyright © 2013 Bryan Davis and Wikimedia Foundation.
- */
-class Scores extends Controller {
-
-   protected function handleGet() {
-   $rows = $this->dao->getP2List( 'All' );
-   $this->view->set( 'records', $rows );
-   $this->render( 'review/scores.html' );
-   }
-
-}

-- 
To view, visit https://gerrit.wikimedia.org/r/324715
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I492ff77c21c82092921ee015238b63bbd11c5497
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/wikimania-scholarships
Gerrit-Branch: master
Gerrit-Owner: Niharika29 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits