Gehel has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/380591 )
Change subject: Disable some spotbugs checks.
......................................................................
Disable some spotbugs checks.
Previous attempt by using an exclusion filter file makes it too complex to
manage dependencies, this **should** work better.
Change-Id: I944306d8fe354b3ea210236a0c6bcb4feec61f99
---
D
discovery-build-tools/src/main/resources/org/wikimedia/discovery/build/tools/spotbugs/spotbugs-excludes.xml
M pom.xml
2 files changed, 1 insertion(+), 36 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/wikimedia/discovery/discovery-parent-pom
refs/changes/91/380591/1
diff --git
a/discovery-build-tools/src/main/resources/org/wikimedia/discovery/build/tools/spotbugs/spotbugs-excludes.xml
b/discovery-build-tools/src/main/resources/org/wikimedia/discovery/build/tools/spotbugs/spotbugs-excludes.xml
deleted file mode 100644
index 3039b90..0000000
---
a/discovery-build-tools/src/main/resources/org/wikimedia/discovery/build/tools/spotbugs/spotbugs-excludes.xml
+++ /dev/null
@@ -1,35 +0,0 @@
-<?xml version="1.0"?>
-<FindBugsFilter>
- <!-- the following bugs are always ignored -->
- <Match>
- <!--
- Manually sizing collections is error prone and in most cases tend
- to be a micro optimization.
- -->
- <Bug pattern="PSC_PRESIZE_COLLECTIONS"/>
- </Match>
-
- <Match>
- <!-- Softening exception is an acceptable pattern in this project. -->
- <Or>
- <Bug pattern="EXS_EXCEPTION_SOFTENING_HAS_CHECKED"/>
- <Bug pattern="EXS_EXCEPTION_SOFTENING_NO_CONSTRAINTS"/>
- </Or>
- </Match>
-
- <Match>
- <!--
- Inverting comparison order when String literals are involved leads
- to unnatural code. Proper null checking should always be done
- anyway.
- -->
- <Bug pattern="LSC_LITERAL_STRING_COMPARISON"/>
- </Match>
-
- <!-- specific exceptions -->
- <Match
classregex="org\.wikimedia\.search\.extra\.regex\.SourceRegexQueryBuilder.*">
- <!-- In this case, an array is accessed with known locations in array
-->
- <Bug pattern="CLI_CONSTANT_LIST_INDEX"/>
- </Match>
-
-</FindBugsFilter>
\ No newline at end of file
diff --git a/pom.xml b/pom.xml
index e4c2b49..620b798 100644
--- a/pom.xml
+++ b/pom.xml
@@ -144,7 +144,7 @@
<configuration>
<effort>high</effort>
<threshold>low</threshold>
-
<excludeFilterFile>org/wikimedia/discovery/build/tools/spotbugs/spotbugs-excludes.xml</excludeFilterFile>
+ <omitVisitors>PSC_PRESIZE_COLLECTIONS,
EXS_EXCEPTION_SOFTENING_HAS_CHECKED, EXS_EXCEPTION_SOFTENING_NO_CONSTRAINTS,
LSC_LITERAL_STRING_COMPARISON</omitVisitors>
<plugins>
<plugin>
<groupId>com.mebigfatguy.fb-contrib</groupId>
--
To view, visit https://gerrit.wikimedia.org/r/380591
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I944306d8fe354b3ea210236a0c6bcb4feec61f99
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/discovery/discovery-parent-pom
Gerrit-Branch: master
Gerrit-Owner: Gehel <guillaume.leder...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
