[MediaWiki-commits] [Gerrit] (bug 40083) fix AJAX preview feature after changes to LivePr... - change (mediawiki...LiquidThreads[master])

2012-09-19 Thread Siebrand (Code Review) 
Siebrand has submitted this change and it was merged.

Change subject: (bug 40083) fix AJAX preview feature after changes to 
LivePreview
..


(bug 40083) fix AJAX preview feature after changes to LivePreview

Due to the way LivePreview was used (loading the .js file without
dependencies and (ab)using a function that used to be global) LiquidThreads
broke after some cleanup changes to it. This change removes the cruft and
adds live preview as a dependency.

Change-Id: I14806b4e85902af1217c1c382bcf7042abb2c067
---
M LiquidThreads.php
M lqt.js
2 files changed, 1 insertion(+), 14 deletions(-)

Approvals:
  CSteipp: Looks good to me, but someone else must approve
  Siebrand: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/23171
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I14806b4e85902af1217c1c382bcf7042abb2c067
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/LiquidThreads
Gerrit-Branch: master
Gerrit-Owner: Matmarex matma@gmail.com
Gerrit-Reviewer: CSteipp cste...@wikimedia.org
Gerrit-Reviewer: Krinkle ttij...@wikimedia.org
Gerrit-Reviewer: Matmarex matma@gmail.com
Gerrit-Reviewer: Nemo bis federicol...@tiscali.it
Gerrit-Reviewer: Nikerabbit niklas.laxst...@gmail.com
Gerrit-Reviewer: Siebrand siebr...@wikimedia.org
Gerrit-Reviewer: Werdna agarr...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] (bug 40083) fix AJAX preview feature after changes to LivePr... - change (mediawiki...LiquidThreads[master])

2012-09-08 Thread Matmarex (Code Review) 
Matmarex has uploaded a new change for review.

Change subject: (bug 40083) fix AJAX preview feature after changes to 
LivePreview
..

(bug 40083) fix AJAX preview feature after changes to LivePreview

Due to the way LivePreview was used (loading the .js file without
dependencies and (ab)using a function that used to be global) LiquidThreads
broke after some cleanup changes to it. This change removes the cruft and
uses mw.loader.load to load the script, which automatically registers its
click handlers.

Change-Id: I14806b4e85902af1217c1c382bcf7042abb2c067
---
M lqt.js
1 file changed, 2 insertions(+), 12 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/LiquidThreads 
refs/changes/71/23171/1
--
To view, visit https://gerrit.wikimedia.org/r/23171
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I14806b4e85902af1217c1c382bcf7042abb2c067
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/LiquidThreads
Gerrit-Branch: master
Gerrit-Owner: Matmarex matma@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits