[MediaWiki-commits] [Gerrit] (bug 43876) Return false in onclick handler to prevent page ... - change (mediawiki...EducationProgram)

2013-02-26 Thread Reedy (Code Review) 
Reedy has submitted this change and it was merged.

Change subject: (bug 43876) Return false in onclick handler to prevent page 
from jumping
..


(bug 43876) Return false in onclick handler to prevent page from jumping

Change-Id: I5a0ef8dedbf219199fbcf0676ce1ea03fc65fc3c
---
M resources/ep.enlist.js
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  Reedy: Verified; Looks good to me, approved
  jenkins-bot: Verified



diff --git a/resources/ep.enlist.js b/resources/ep.enlist.js
index eebd78f..7e45315 100644
--- a/resources/ep.enlist.js
+++ b/resources/ep.enlist.js
@@ -105,6 +105,8 @@
doRemove();
}
} );
+
+   return false;
} );
 
$( '.ep-add-role' ).click( function( event ) {
@@ -286,6 +288,8 @@
 
this.nameInput.keypress( enterHandler );
this.summaryInput.keypress( enterHandler );
+
+   return false;
} );
 
} );

-- 
To view, visit https://gerrit.wikimedia.org/r/50489
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5a0ef8dedbf219199fbcf0676ce1ea03fc65fc3c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/EducationProgram
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw jeroended...@gmail.com
Gerrit-Reviewer: CSteipp cste...@wikimedia.org
Gerrit-Reviewer: Ragesoss rages...@gmail.com
Gerrit-Reviewer: Reedy re...@wikimedia.org
Gerrit-Reviewer: jenkins-bot

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] (bug 43876) Return false in onclick handler to prevent page ... - change (mediawiki...EducationProgram)

2013-02-23 Thread Jeroen De Dauw (Code Review) 
Jeroen De Dauw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/50489


Change subject: (bug 43876) Return false in onclick handler to prevent page 
from jumping
..

(bug 43876) Return false in onclick handler to prevent page from jumping

Change-Id: I5a0ef8dedbf219199fbcf0676ce1ea03fc65fc3c
---
M resources/ep.enlist.js
1 file changed, 4 insertions(+), 0 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/EducationProgram 
refs/changes/89/50489/1

diff --git a/resources/ep.enlist.js b/resources/ep.enlist.js
index eebd78f..7e45315 100644
--- a/resources/ep.enlist.js
+++ b/resources/ep.enlist.js
@@ -105,6 +105,8 @@
doRemove();
}
} );
+
+   return false;
} );
 
$( '.ep-add-role' ).click( function( event ) {
@@ -286,6 +288,8 @@
 
this.nameInput.keypress( enterHandler );
this.summaryInput.keypress( enterHandler );
+
+   return false;
} );
 
} );

-- 
To view, visit https://gerrit.wikimedia.org/r/50489
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5a0ef8dedbf219199fbcf0676ce1ea03fc65fc3c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/EducationProgram
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw jeroended...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits