[MediaWiki-commits] [Gerrit] [BREAKING CHANGE] Kill ve.indexOf and thus @until - change (VisualEditor/VisualEditor)

2015-07-29 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: [BREAKING CHANGE] Kill ve.indexOf and thus @until
..


[BREAKING CHANGE] Kill ve.indexOf and thus @until

Change-Id: Ib6aca26b33c9c8c8541c5bc6753091481acb7531
---
M .jsduck/CustomTags.rb
M src/ve.utils.js
2 files changed, 0 insertions(+), 33 deletions(-)

Approvals:
  Krinkle: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/.jsduck/CustomTags.rb b/.jsduck/CustomTags.rb
index 26fe678..b37eab0 100644
--- a/.jsduck/CustomTags.rb
+++ b/.jsduck/CustomTags.rb
@@ -48,24 +48,6 @@
   end
 end
 
-class UntilTag  CommonTag
-  def initialize
-@tagname = :until
-@pattern = 'until'
-super
-  end
-
-  def to_html(context)
--EOHTML
-  h3Until/h3
-  div class=signature-boxp
-  This method provides strongbrowser compatibility/strong for:
-  #{ context[@tagname].map { |tag| tag[:doc] }.join(\n) }
-  /p/div
-EOHTML
-  end
-end
-
 class SeeTag  CommonTag
   def initialize
 @tagname = :see
diff --git a/src/ve.utils.js b/src/ve.utils.js
index 81a0ef6..a8a9ebe 100644
--- a/src/ve.utils.js
+++ b/src/ve.utils.js
@@ -146,21 +146,6 @@
 ve.isEmptyObject = $.isEmptyObject;
 
 /**
- * Wrapper for Array#indexOf.
- *
- * Values are compared without type coercion.
- *
- * @method
- * @source http://api.jquery.com/jQuery.inArray/
- * @until ES5: Array#indexOf
- * @param {Mixed} value Element to search for
- * @param {Array} array Array to search in
- * @param {number} [fromIndex=0] Index to being searching from
- * @returns {number} Index of value in array, or -1 if not found
- */
-ve.indexOf = $.inArray;
-
-/**
  * Merge properties of one or more objects into another.
  * Preserves original object's inheritance (e.g. Array, Object, whatever).
  * In case of array or array-like objects only the indexed properties

-- 
To view, visit https://gerrit.wikimedia.org/r/227868
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib6aca26b33c9c8c8541c5bc6753091481acb7531
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester jforres...@wikimedia.org
Gerrit-Reviewer: Alex Monk kren...@gmail.com
Gerrit-Reviewer: Esanders esand...@wikimedia.org
Gerrit-Reviewer: Jforrester jforres...@wikimedia.org
Gerrit-Reviewer: Krinkle krinklem...@gmail.com
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] [BREAKING CHANGE] Kill ve.indexOf and thus @until - change (VisualEditor/VisualEditor)

2015-07-29 Thread Jforrester (Code Review) 
Jforrester has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/227868

Change subject: [BREAKING CHANGE] Kill ve.indexOf and thus @until
..

[BREAKING CHANGE] Kill ve.indexOf and thus @until

Change-Id: Ib6aca26b33c9c8c8541c5bc6753091481acb7531
---
M .jsduck/CustomTags.rb
M src/ve.utils.js
2 files changed, 0 insertions(+), 33 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor 
refs/changes/68/227868/1

diff --git a/.jsduck/CustomTags.rb b/.jsduck/CustomTags.rb
index 26fe678..b37eab0 100644
--- a/.jsduck/CustomTags.rb
+++ b/.jsduck/CustomTags.rb
@@ -48,24 +48,6 @@
   end
 end
 
-class UntilTag  CommonTag
-  def initialize
-@tagname = :until
-@pattern = 'until'
-super
-  end
-
-  def to_html(context)
--EOHTML
-  h3Until/h3
-  div class=signature-boxp
-  This method provides strongbrowser compatibility/strong for:
-  #{ context[@tagname].map { |tag| tag[:doc] }.join(\n) }
-  /p/div
-EOHTML
-  end
-end
-
 class SeeTag  CommonTag
   def initialize
 @tagname = :see
diff --git a/src/ve.utils.js b/src/ve.utils.js
index 81a0ef6..a8a9ebe 100644
--- a/src/ve.utils.js
+++ b/src/ve.utils.js
@@ -146,21 +146,6 @@
 ve.isEmptyObject = $.isEmptyObject;
 
 /**
- * Wrapper for Array#indexOf.
- *
- * Values are compared without type coercion.
- *
- * @method
- * @source http://api.jquery.com/jQuery.inArray/
- * @until ES5: Array#indexOf
- * @param {Mixed} value Element to search for
- * @param {Array} array Array to search in
- * @param {number} [fromIndex=0] Index to being searching from
- * @returns {number} Index of value in array, or -1 if not found
- */
-ve.indexOf = $.inArray;
-
-/**
  * Merge properties of one or more objects into another.
  * Preserves original object's inheritance (e.g. Array, Object, whatever).
  * In case of array or array-like objects only the indexed properties

-- 
To view, visit https://gerrit.wikimedia.org/r/227868
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib6aca26b33c9c8c8541c5bc6753091481acb7531
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester jforres...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits